[GitHub] cordova-plugin-inappbrowser pull request #203: CB-10799 (ios) fix toolbar in...

2016-12-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/203


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-ios pull request #282: CB-11810 (ios) fix unable to load index page ...

2016-12-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/282


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2016-12-22 Thread filmaj
Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/244
  
Oh! I totally forgot to ping @alsorokin for a review :)

If you find the time, please review good sir!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-wkwebview-engine issue #16: CB-11554 - too 'brutal' app reloa...

2016-12-22 Thread pwbs
Github user pwbs commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16
  
@mccraigmccraig thank you for your reply. I'll try to find some time for 
that next month...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-wkwebview-engine issue #16: CB-11554 - too 'brutal' app reloa...

2016-12-22 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16
  
so that's pretty occasional then, which will make it hard to track down (i 
haven't seen WSOD at all recently)

my approach when i first worked on this was to fork this repo and create a 
build with debug logging wherever i thought it might be useful, wait for the 
bug to occur and then immediately grab the console logs off of my phone

can you do that ? put some logging in the `onAppWillEnterForeground` 
callback etc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-wkwebview-engine issue #16: CB-11554 - too 'brutal' app reloa...

2016-12-22 Thread pwbs
Github user pwbs commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16
  
I've just witnessed it again: this time there's no doubt that it's 
`about:blank`. 

However this time I have some weird messages in Safari's console:
https://cloud.githubusercontent.com/assets/15014298/21432820/764c3e40-c86d-11e6-84c2-3c71bdcbc64b.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] cordova-serve 1.0.1 release

2016-12-22 Thread Vladimir Kotikov (Akvelon)
I vote +1

- Verified archive signature
- Verified license headers
- Verified dependencies have appropriate licenses
- Verified ‘cordova serve’ command and browser platform work with the version 
being released

-
Best regards, Vladimir
 

On 12/22/16, 13:07, "Alexander Sorokin (Akvelon)"  
wrote:

I vote +1.

* Verified archive with coho
* Verified tag
* Ability to install/uninstall Cordova
* Ability to update Cordova
* Ability to create blank app for Windows, Android
* Ability to build/run apps
* Reviewed release notes
* Verified version
* Verified line breaks
* Verified 'cordova serve'
* Verified that browserified app builds and runs correctly
* Ensured --nobuild option works



From: Tim Barham 
Sent: Thursday, December 22, 2016 7:24:23 AM
To: dev@cordova.apache.org
Subject: [VOTE] cordova-serve 1.0.1 release

Please review and vote on this Tools Release by replying to this email (and 
keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-12289=02%7C01%7Cv-alsoro%40microsoft.com%7C9688f4a40c104c8857de08d42a2279c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636179774936024514=Lt701h2YtQAVLUhXv6kqLK2FH5E0X3i245dEIcBGQPk%3D=0

The release has been published to dist/dev: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-12289%2F=02%7C01%7Cv-alsoro%40microsoft.com%7C9688f4a40c104c8857de08d42a2279c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636179774936024514=mgEMD%2FAXvtRhefGha89Ca%2F1ShQt%2F0wVRe2avrB6vi80%3D=0.
 It has also been published to npm with the "rc" tag, and can be installed for 
testing using "cordova-serve@rc"

The packages were published from their corresponding git tags:

cordova-lib: serve-1.0.1 (510a698841)

Upon a successful vote I will upload the archives to dist/, publish them to 
NPM, and post the corresponding blog post.

Voting guidelines: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md=02%7C01%7Cv-alsoro%40microsoft.com%7C9688f4a40c104c8857de08d42a2279c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636179774936024514=x4H9lVx8d6Q5H%2FSocZjdkHsMu7%2BF0ttejlPH8sVJHbw%3D=0

Voting will go on for a minimum of 48 hours.

I vote +1:

* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies 
have Apache-compatible licenses
* Manually verified package contents




[GitHub] cordova-android issue #352: Include armeabi, arm64-v8a and x86_64 libs

2016-12-22 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/352
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/352?src=pr) is 
35.58% (diff: 100%)
> Merging 
[#352](https://codecov.io/gh/apache/cordova-android/pull/352?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #352   diff @@
==
  Files12 12  
  Lines  1037   1037  
  Methods 205205  
  Messages  0  0  
  Branches173173  
==
  Hits369369  
  Misses  668668  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[6c60dc5...57c8a81](https://codecov.io/gh/apache/cordova-android/compare/6c60dc5dc8e487db3da599d4beef73989309d85b...57c8a8141c60fc77fa176564b79027c1cdd0b6fb?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera issue #243: Double exif rotation on android with camer...

2016-12-22 Thread sarantist
Github user sarantist commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/243
  
Same problem exists for Samsung Galaxy S3, S4 and S5. All of the other test 
devices work as intended.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [VOTE] cordova-serve 1.0.1 release

2016-12-22 Thread Alexander Sorokin (Akvelon)
I vote +1.

* Verified archive with coho
* Verified tag
* Ability to install/uninstall Cordova
* Ability to update Cordova
* Ability to create blank app for Windows, Android
* Ability to build/run apps
* Reviewed release notes
* Verified version
* Verified line breaks
* Verified 'cordova serve'
* Verified that browserified app builds and runs correctly
* Ensured --nobuild option works



From: Tim Barham 
Sent: Thursday, December 22, 2016 7:24:23 AM
To: dev@cordova.apache.org
Subject: [VOTE] cordova-serve 1.0.1 release

Please review and vote on this Tools Release by replying to this email (and 
keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-12289=02%7C01%7Cv-alsoro%40microsoft.com%7C9688f4a40c104c8857de08d42a2279c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636179774936024514=Lt701h2YtQAVLUhXv6kqLK2FH5E0X3i245dEIcBGQPk%3D=0

The release has been published to dist/dev: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-12289%2F=02%7C01%7Cv-alsoro%40microsoft.com%7C9688f4a40c104c8857de08d42a2279c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636179774936024514=mgEMD%2FAXvtRhefGha89Ca%2F1ShQt%2F0wVRe2avrB6vi80%3D=0.
 It has also been published to npm with the "rc" tag, and can be installed for 
testing using "cordova-serve@rc"

The packages were published from their corresponding git tags:

cordova-lib: serve-1.0.1 (510a698841)

Upon a successful vote I will upload the archives to dist/, publish them to 
NPM, and post the corresponding blog post.

Voting guidelines: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md=02%7C01%7Cv-alsoro%40microsoft.com%7C9688f4a40c104c8857de08d42a2279c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636179774936024514=x4H9lVx8d6Q5H%2FSocZjdkHsMu7%2BF0ttejlPH8sVJHbw%3D=0

Voting will go on for a minimum of 48 hours.

I vote +1:

* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Manually verified package contents