Nightly build #458 for cordova has succeeded!

2017-08-18 Thread Apache Jenkins Server
Nightly build #458 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/458/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs issue #719: CB-13076,CB-13068 : Removed references of cordova d...

2017-08-18 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-docs/pull/719
  
ping @maverickmishra 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request #721: CB-13195 Source Code link in footer on cordo...

2017-08-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/721


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] [Play Services Version]

2017-08-18 Thread Steven Gill
The solution I'm working on in that discuss repo would allow users to set
the versions on config.xml. It isn't tied to play services

Plugin devs would have to modify the framework tags to use a variable

On Aug 18, 2017 12:03 PM, "julio cesar sanchez" 
wrote:

> Yes, that one is for forcing Android Support Libraries to use the 25
> version, but the problem is the same as with Google Play Services, plugins
> using different versions of libraries causing conflict between them.
>
> 2017-08-18 19:49 GMT+02:00 Steven Gill :
>
> > On first glance, that plugin does seem to solve a similar problem.
> >
> > On Fri, Aug 18, 2017 at 10:45 AM, Jan Piotrowski 
> > wrote:
> >
> > > Is this the same problem that (allegedly) can be fixed by using this
> > > plugin?
> > > https://github.com/dpa99c/cordova-android-support-gradle-release
> > >
> > > 2017-08-18 18:02 GMT+02:00 julio cesar sanchez  >:
> > > > This problem is not only present on Play Services version, any other
> > > > library or framework, from Android (like support libraries) or any
> 3rd
> > > > party.
> > > > For 3rd party is less common, but for support libraries is very
> common
> > to
> > > > have this kind of problem.
> > > >
> > > > I have had another idea that I think should be simpler, but will be a
> > big
> > > > breaking change.
> > > >
> > > > What if we drop support for the framework tag in plugin xml and move
> > the
> > > > functionality to config.xml?
> > > >
> > > > Plugin authors should use config-file tag to add the framework on the
> > > > config.xml, something like
> > > > 
> > > > 
> > > > 
> > > >
> > > >
> > > > The problem is that any plugin using a framework will need an update,
> > > while
> > > > the other proposed approach will only need to update conflicting
> > plugins.
> > > >
> > > >
> > > > And if the config.xml already includes a
> com.android.support:support-v4
> > > > then ignore it.
> > > >
> > > > El 8 ago. 2017 3:03 p. m., "Audrey So" 
> > > escribió:
> > > >
> > > >> Hi all!
> > > >>
> > > >>
> > > >> There is a proposal to offer an alternative solution for CB-13145:
> > > >> https://issues.apache.org/jira/browse/CB-13145.
> > > >>
> > > >> Please review the proposal below:
> > > >>
> > > >> https://github.com/cordova/cordova-discuss/pull/74/files
> > > >>
> > > >>
> > > >> We would appreciate any feedback, advice, comments, and questions
> you
> > > have
> > > >> on this proposal. Looking forward to hearing any thoughts. Thanks so
> > > much!
> > > >>
> > > >>
> > > >> Audrey
> > > >>
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>


Re: [DISCUSS] [Play Services Version]

2017-08-18 Thread julio cesar sanchez
Yes, that one is for forcing Android Support Libraries to use the 25
version, but the problem is the same as with Google Play Services, plugins
using different versions of libraries causing conflict between them.

2017-08-18 19:49 GMT+02:00 Steven Gill :

> On first glance, that plugin does seem to solve a similar problem.
>
> On Fri, Aug 18, 2017 at 10:45 AM, Jan Piotrowski 
> wrote:
>
> > Is this the same problem that (allegedly) can be fixed by using this
> > plugin?
> > https://github.com/dpa99c/cordova-android-support-gradle-release
> >
> > 2017-08-18 18:02 GMT+02:00 julio cesar sanchez :
> > > This problem is not only present on Play Services version, any other
> > > library or framework, from Android (like support libraries) or any 3rd
> > > party.
> > > For 3rd party is less common, but for support libraries is very common
> to
> > > have this kind of problem.
> > >
> > > I have had another idea that I think should be simpler, but will be a
> big
> > > breaking change.
> > >
> > > What if we drop support for the framework tag in plugin xml and move
> the
> > > functionality to config.xml?
> > >
> > > Plugin authors should use config-file tag to add the framework on the
> > > config.xml, something like
> > > 
> > > 
> > > 
> > >
> > >
> > > The problem is that any plugin using a framework will need an update,
> > while
> > > the other proposed approach will only need to update conflicting
> plugins.
> > >
> > >
> > > And if the config.xml already includes a com.android.support:support-v4
> > > then ignore it.
> > >
> > > El 8 ago. 2017 3:03 p. m., "Audrey So" 
> > escribió:
> > >
> > >> Hi all!
> > >>
> > >>
> > >> There is a proposal to offer an alternative solution for CB-13145:
> > >> https://issues.apache.org/jira/browse/CB-13145.
> > >>
> > >> Please review the proposal below:
> > >>
> > >> https://github.com/cordova/cordova-discuss/pull/74/files
> > >>
> > >>
> > >> We would appreciate any feedback, advice, comments, and questions you
> > have
> > >> on this proposal. Looking forward to hearing any thoughts. Thanks so
> > much!
> > >>
> > >>
> > >> Audrey
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: [DISCUSS] [Play Services Version]

2017-08-18 Thread Steven Gill
On first glance, that plugin does seem to solve a similar problem.

On Fri, Aug 18, 2017 at 10:45 AM, Jan Piotrowski 
wrote:

> Is this the same problem that (allegedly) can be fixed by using this
> plugin?
> https://github.com/dpa99c/cordova-android-support-gradle-release
>
> 2017-08-18 18:02 GMT+02:00 julio cesar sanchez :
> > This problem is not only present on Play Services version, any other
> > library or framework, from Android (like support libraries) or any 3rd
> > party.
> > For 3rd party is less common, but for support libraries is very common to
> > have this kind of problem.
> >
> > I have had another idea that I think should be simpler, but will be a big
> > breaking change.
> >
> > What if we drop support for the framework tag in plugin xml and move the
> > functionality to config.xml?
> >
> > Plugin authors should use config-file tag to add the framework on the
> > config.xml, something like
> > 
> > 
> > 
> >
> >
> > The problem is that any plugin using a framework will need an update,
> while
> > the other proposed approach will only need to update conflicting plugins.
> >
> >
> > And if the config.xml already includes a com.android.support:support-v4
> > then ignore it.
> >
> > El 8 ago. 2017 3:03 p. m., "Audrey So" 
> escribió:
> >
> >> Hi all!
> >>
> >>
> >> There is a proposal to offer an alternative solution for CB-13145:
> >> https://issues.apache.org/jira/browse/CB-13145.
> >>
> >> Please review the proposal below:
> >>
> >> https://github.com/cordova/cordova-discuss/pull/74/files
> >>
> >>
> >> We would appreciate any feedback, advice, comments, and questions you
> have
> >> on this proposal. Looking forward to hearing any thoughts. Thanks so
> much!
> >>
> >>
> >> Audrey
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Re: [DISCUSS] [Play Services Version]

2017-08-18 Thread Jan Piotrowski
Is this the same problem that (allegedly) can be fixed by using this plugin?
https://github.com/dpa99c/cordova-android-support-gradle-release

2017-08-18 18:02 GMT+02:00 julio cesar sanchez :
> This problem is not only present on Play Services version, any other
> library or framework, from Android (like support libraries) or any 3rd
> party.
> For 3rd party is less common, but for support libraries is very common to
> have this kind of problem.
>
> I have had another idea that I think should be simpler, but will be a big
> breaking change.
>
> What if we drop support for the framework tag in plugin xml and move the
> functionality to config.xml?
>
> Plugin authors should use config-file tag to add the framework on the
> config.xml, something like
> 
> 
> 
>
>
> The problem is that any plugin using a framework will need an update, while
> the other proposed approach will only need to update conflicting plugins.
>
>
> And if the config.xml already includes a com.android.support:support-v4
> then ignore it.
>
> El 8 ago. 2017 3:03 p. m., "Audrey So"  escribió:
>
>> Hi all!
>>
>>
>> There is a proposal to offer an alternative solution for CB-13145:
>> https://issues.apache.org/jira/browse/CB-13145.
>>
>> Please review the proposal below:
>>
>> https://github.com/cordova/cordova-discuss/pull/74/files
>>
>>
>> We would appreciate any feedback, advice, comments, and questions you have
>> on this proposal. Looking forward to hearing any thoughts. Thanks so much!
>>
>>
>> Audrey
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] [Play Services Version]

2017-08-18 Thread julio cesar sanchez
This problem is not only present on Play Services version, any other
library or framework, from Android (like support libraries) or any 3rd
party.
For 3rd party is less common, but for support libraries is very common to
have this kind of problem.

I have had another idea that I think should be simpler, but will be a big
breaking change.

What if we drop support for the framework tag in plugin xml and move the
functionality to config.xml?

Plugin authors should use config-file tag to add the framework on the
config.xml, something like





The problem is that any plugin using a framework will need an update, while
the other proposed approach will only need to update conflicting plugins.


And if the config.xml already includes a com.android.support:support-v4
then ignore it.

El 8 ago. 2017 3:03 p. m., "Audrey So"  escribió:

> Hi all!
>
>
> There is a proposal to offer an alternative solution for CB-13145:
> https://issues.apache.org/jira/browse/CB-13145.
>
> Please review the proposal below:
>
> https://github.com/cordova/cordova-discuss/pull/74/files
>
>
> We would appreciate any feedback, advice, comments, and questions you have
> on this proposal. Looking forward to hearing any thoughts. Thanks so much!
>
>
> Audrey
>


[GitHub] cordova-docs pull request #721: CB-13195 Source Code link in footer on cordo...

2017-08-18 Thread tony--
GitHub user tony-- opened a pull request:

https://github.com/apache/cordova-docs/pull/721

CB-13195 Source Code link in footer on cordova.apache.org needs updated

### Platforms affected
N/A

### What does this PR do?
Fix the "Source Code" link in footer (CB-13195)

### What testing has been done on this change?
Tested locally with _node_modules/.bin/gulp serve --nodocs_ and clicked the 
link.  It works!

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tony--/cordova-docs CB-13195

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/721.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #721


commit 877f1132e0358de186dabf5f5629ebdb1369641b
Author: Tony Homer 
Date:   2017-08-18T15:03:11Z

CB-13195 Source Code link in footer on cordova.apache.org needs updated




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-screen-orientation issue #20: Rotate device only if needed

2017-08-18 Thread jonathanherdt
Github user jonathanherdt commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/20
  
Created bug report CB-13193 for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-screen-orientation issue #20: Rotate device only if needed

2017-08-18 Thread jonathanherdt
Github user jonathanherdt commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/20
  
Doesn't work for me if I want to lock the orientation to landscape but the 
device is in portrait. The UI should rotate into landscape in this case but it 
doesn't do so with these changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org