Nightly build #493 for cordova has succeeded!

2017-09-22 Thread Apache Jenkins Server
Nightly build #493 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/493/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[ANNOUNCE] Plugins Release

2017-09-22 Thread Steven Gill
Plugins release is out!

Blog: http://cordova.apache.org/news/2017/09/22/plugins-release.html
Tweet: https://twitter.com/apachecordova/status/911368906043985920


Re: [DISCUSS] Plugin release

2017-09-22 Thread Steven Gill
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
but I used the new undocumented automatic release script that fil created
for this past one. I'll document it up for this next release

On Fri, Sep 22, 2017 at 3:04 PM, Simon MacDonald 
wrote:

> Yeah, we should be doing another plugins release soon. We have:
>
> cordova-plugin-status-bar
> cordova-plugin-file-transfer
>
> Needing releases.
>
> Steve, is the release process documented anywhere so you don't have to be
> the person who runs it each and every time?
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Fri, Sep 22, 2017 at 6:00 PM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > For next release I want cordova-plugin-statusbar as I fixed it to work
> > properly on iPhone X
> >
> > 2017-09-22 21:27 GMT+02:00 Steven Gill :
> >
> > > Please review the blog post for the release
> > >
> > > https://github.com/apache/cordova-docs/pull/734
> > >
> > > On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill 
> > > wrote:
> > >
> > > > Yeah I only released the plugins that people mentioned in this thread
> > to
> > > > release. I can fire up another plugins release next week. What
> plugins
> > do
> > > > people want reviewed/released?
> > > >
> > > > On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald <
> > > > simon.macdon...@gmail.com> wrote:
> > > >
> > > >> Just realized that cordova-plugin-file-transfer was never bumped. It
> > > >> includes an important fix for apps. Without it new apps may be
> > rejected
> > > >> from the Play Store.
> > > >>
> > > >>
> > > >> Simon Mac Donald
> > > >> http://simonmacdonald.com
> > > >>
> > > >> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill <
> stevengil...@gmail.com>
> > > >> wrote:
> > > >>
> > > >> > the ios release blog post tells users about the console plugin.
> > > >> > http://cordova.apache.org/announcements/2017/09/08/ios-
> release.html
> > > >> >
> > > >> > I'll make sure to highlight these changes in the plugins release
> > blog
> > > >> post.
> > > >> >
> > > >> > Starting a new vote with console + compat only having minor bumps
> > > >> >
> > > >> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
> > > >> > jcesarmob...@gmail.com
> > > >> > > wrote:
> > > >> >
> > > >> > > There has been already a few people asking about the duplicate
> > > >> symbols on
> > > >> > > slack
> > > >> > >
> > > >> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald <
> > > simon.macdon...@gmail.com
> > > >> >:
> > > >> > >
> > > >> > > > IMHO both cordova-plugin-compat and cordova-plugin-console
> > should
> > > >> > receive
> > > >> > > > minor version bumps. Neither breaks backwards compatibility
> so I
> > > >> don't
> > > >> > > feel
> > > >> > > > like a major version bump is warranted.
> > > >> > > >
> > > >> > > > As well all of our core plugins that depend on
> > > cordova-plugin-compat
> > > >> > use
> > > >> > > > the ^1.x in their semver so they would pull in the earlier
> > version
> > > >> of
> > > >> > the
> > > >> > > > compat plugin and in combination with the upcoming
> > cordova-android
> > > >> > 6.3.0
> > > >> > > > pretty much all apps will fail to build.
> > > >> > > >
> > > >> > > > When it comes to cordova-plugin-console we should also err on
> > the
> > > >> side
> > > >> > of
> > > >> > > > caution when it comes to the version number bump. I spent some
> > > time
> > > >> > this
> > > >> > > > morning debugging an internal app that was using cordova-ios
> > 4.5.0
> > > >> and
> > > >> > > > cordova-plugin-console. It was failing to build because of
> > > duplicate
> > > >> > > code.
> > > >> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release
> > > before
> > > >> > > > cordova-ios 4.5.0 the problem would not have existed.
> > > >> > > >
> > > >> > > > I think we need to be ready to start answering that question
> as
> > to
> > > >> why
> > > >> > > apps
> > > >> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post
> > is
> > > in
> > > >> > > order?
> > > >> > > >
> > > >> > > > My recommendations is to restart this vote thread with the
> four
> > > >> plugins
> > > >> > > but
> > > >> > > > tag their versions as cordova-plugin-compat@1.2.0,
> > > >> > > > cordova-plugin-console@1.1.0. The device motion and device
> > > >> orientation
> > > >> > > > plugins can have any version number we want as they will not
> run
> > > >> into
> > > >> > the
> > > >> > > > above problems.
> > > >> > > >
> > > >> > > >
> > > >> > > > Simon Mac Donald
> > > >> > > > http://simonmacdonald.com
> > > >> > > >
> > > >> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill <
> > > >> stevengil...@gmail.com>
> > > >> > > > wrote:
> > > >> > > >
> > > >> > > > > Plugin vote is going to fail it seems due to the issue simon
> > > >> found.
> > > >> > > > >
> > > >> > > > > Simons  message:
> > > >> > > > > "Failed
> > > >> > > > > * Added cordova-plugin-camera to a project with
> > cordova-android
> > > >> 6.3.0
> > > >> > > > which
> > > >> > > > >

Re: [DISCUSS] Plugin release

2017-09-22 Thread Simon MacDonald
Thanks, trying get back into being more involved on the cordova side.

Simon Mac Donald
http://simonmacdonald.com

On Fri, Sep 22, 2017 at 6:06 PM, julio cesar sanchez  wrote:

> Yes, it's documented in coho
> https://github.com/apache/cordova-coho/blob/master/docs/
> plugins-release-process.md
>
> 2017-09-23 0:04 GMT+02:00 Simon MacDonald :
>
> > Yeah, we should be doing another plugins release soon. We have:
> >
> > cordova-plugin-status-bar
> > cordova-plugin-file-transfer
> >
> > Needing releases.
> >
> > Steve, is the release process documented anywhere so you don't have to be
> > the person who runs it each and every time?
> >
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Fri, Sep 22, 2017 at 6:00 PM, julio cesar sanchez <
> > jcesarmob...@gmail.com
> > > wrote:
> >
> > > For next release I want cordova-plugin-statusbar as I fixed it to work
> > > properly on iPhone X
> > >
> > > 2017-09-22 21:27 GMT+02:00 Steven Gill :
> > >
> > > > Please review the blog post for the release
> > > >
> > > > https://github.com/apache/cordova-docs/pull/734
> > > >
> > > > On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill  >
> > > > wrote:
> > > >
> > > > > Yeah I only released the plugins that people mentioned in this
> thread
> > > to
> > > > > release. I can fire up another plugins release next week. What
> > plugins
> > > do
> > > > > people want reviewed/released?
> > > > >
> > > > > On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald <
> > > > > simon.macdon...@gmail.com> wrote:
> > > > >
> > > > >> Just realized that cordova-plugin-file-transfer was never bumped.
> It
> > > > >> includes an important fix for apps. Without it new apps may be
> > > rejected
> > > > >> from the Play Store.
> > > > >>
> > > > >>
> > > > >> Simon Mac Donald
> > > > >> http://simonmacdonald.com
> > > > >>
> > > > >> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill <
> > stevengil...@gmail.com>
> > > > >> wrote:
> > > > >>
> > > > >> > the ios release blog post tells users about the console plugin.
> > > > >> > http://cordova.apache.org/announcements/2017/09/08/ios-
> > release.html
> > > > >> >
> > > > >> > I'll make sure to highlight these changes in the plugins release
> > > blog
> > > > >> post.
> > > > >> >
> > > > >> > Starting a new vote with console + compat only having minor
> bumps
> > > > >> >
> > > > >> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
> > > > >> > jcesarmob...@gmail.com
> > > > >> > > wrote:
> > > > >> >
> > > > >> > > There has been already a few people asking about the duplicate
> > > > >> symbols on
> > > > >> > > slack
> > > > >> > >
> > > > >> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald <
> > > > simon.macdon...@gmail.com
> > > > >> >:
> > > > >> > >
> > > > >> > > > IMHO both cordova-plugin-compat and cordova-plugin-console
> > > should
> > > > >> > receive
> > > > >> > > > minor version bumps. Neither breaks backwards compatibility
> > so I
> > > > >> don't
> > > > >> > > feel
> > > > >> > > > like a major version bump is warranted.
> > > > >> > > >
> > > > >> > > > As well all of our core plugins that depend on
> > > > cordova-plugin-compat
> > > > >> > use
> > > > >> > > > the ^1.x in their semver so they would pull in the earlier
> > > version
> > > > >> of
> > > > >> > the
> > > > >> > > > compat plugin and in combination with the upcoming
> > > cordova-android
> > > > >> > 6.3.0
> > > > >> > > > pretty much all apps will fail to build.
> > > > >> > > >
> > > > >> > > > When it comes to cordova-plugin-console we should also err
> on
> > > the
> > > > >> side
> > > > >> > of
> > > > >> > > > caution when it comes to the version number bump. I spent
> some
> > > > time
> > > > >> > this
> > > > >> > > > morning debugging an internal app that was using cordova-ios
> > > 4.5.0
> > > > >> and
> > > > >> > > > cordova-plugin-console. It was failing to build because of
> > > > duplicate
> > > > >> > > code.
> > > > >> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release
> > > > before
> > > > >> > > > cordova-ios 4.5.0 the problem would not have existed.
> > > > >> > > >
> > > > >> > > > I think we need to be ready to start answering that question
> > as
> > > to
> > > > >> why
> > > > >> > > apps
> > > > >> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog
> post
> > > is
> > > > in
> > > > >> > > order?
> > > > >> > > >
> > > > >> > > > My recommendations is to restart this vote thread with the
> > four
> > > > >> plugins
> > > > >> > > but
> > > > >> > > > tag their versions as cordova-plugin-compat@1.2.0,
> > > > >> > > > cordova-plugin-console@1.1.0. The device motion and device
> > > > >> orientation
> > > > >> > > > plugins can have any version number we want as they will not
> > run
> > > > >> into
> > > > >> > the
> > > > >> > > > above problems.
> > > > >> > > >
> > > > >> > > >
> > > > >> > > > Simon Mac Donald
> > > > >> > > > http://simonmacdonald.com
> > > > >> > > >
> > > > >> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill <
> > > > >> s

Re: [DISCUSS] Plugin release

2017-09-22 Thread julio cesar sanchez
Yes, it's documented in coho
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md

2017-09-23 0:04 GMT+02:00 Simon MacDonald :

> Yeah, we should be doing another plugins release soon. We have:
>
> cordova-plugin-status-bar
> cordova-plugin-file-transfer
>
> Needing releases.
>
> Steve, is the release process documented anywhere so you don't have to be
> the person who runs it each and every time?
>
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Fri, Sep 22, 2017 at 6:00 PM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > For next release I want cordova-plugin-statusbar as I fixed it to work
> > properly on iPhone X
> >
> > 2017-09-22 21:27 GMT+02:00 Steven Gill :
> >
> > > Please review the blog post for the release
> > >
> > > https://github.com/apache/cordova-docs/pull/734
> > >
> > > On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill 
> > > wrote:
> > >
> > > > Yeah I only released the plugins that people mentioned in this thread
> > to
> > > > release. I can fire up another plugins release next week. What
> plugins
> > do
> > > > people want reviewed/released?
> > > >
> > > > On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald <
> > > > simon.macdon...@gmail.com> wrote:
> > > >
> > > >> Just realized that cordova-plugin-file-transfer was never bumped. It
> > > >> includes an important fix for apps. Without it new apps may be
> > rejected
> > > >> from the Play Store.
> > > >>
> > > >>
> > > >> Simon Mac Donald
> > > >> http://simonmacdonald.com
> > > >>
> > > >> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill <
> stevengil...@gmail.com>
> > > >> wrote:
> > > >>
> > > >> > the ios release blog post tells users about the console plugin.
> > > >> > http://cordova.apache.org/announcements/2017/09/08/ios-
> release.html
> > > >> >
> > > >> > I'll make sure to highlight these changes in the plugins release
> > blog
> > > >> post.
> > > >> >
> > > >> > Starting a new vote with console + compat only having minor bumps
> > > >> >
> > > >> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
> > > >> > jcesarmob...@gmail.com
> > > >> > > wrote:
> > > >> >
> > > >> > > There has been already a few people asking about the duplicate
> > > >> symbols on
> > > >> > > slack
> > > >> > >
> > > >> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald <
> > > simon.macdon...@gmail.com
> > > >> >:
> > > >> > >
> > > >> > > > IMHO both cordova-plugin-compat and cordova-plugin-console
> > should
> > > >> > receive
> > > >> > > > minor version bumps. Neither breaks backwards compatibility
> so I
> > > >> don't
> > > >> > > feel
> > > >> > > > like a major version bump is warranted.
> > > >> > > >
> > > >> > > > As well all of our core plugins that depend on
> > > cordova-plugin-compat
> > > >> > use
> > > >> > > > the ^1.x in their semver so they would pull in the earlier
> > version
> > > >> of
> > > >> > the
> > > >> > > > compat plugin and in combination with the upcoming
> > cordova-android
> > > >> > 6.3.0
> > > >> > > > pretty much all apps will fail to build.
> > > >> > > >
> > > >> > > > When it comes to cordova-plugin-console we should also err on
> > the
> > > >> side
> > > >> > of
> > > >> > > > caution when it comes to the version number bump. I spent some
> > > time
> > > >> > this
> > > >> > > > morning debugging an internal app that was using cordova-ios
> > 4.5.0
> > > >> and
> > > >> > > > cordova-plugin-console. It was failing to build because of
> > > duplicate
> > > >> > > code.
> > > >> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release
> > > before
> > > >> > > > cordova-ios 4.5.0 the problem would not have existed.
> > > >> > > >
> > > >> > > > I think we need to be ready to start answering that question
> as
> > to
> > > >> why
> > > >> > > apps
> > > >> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post
> > is
> > > in
> > > >> > > order?
> > > >> > > >
> > > >> > > > My recommendations is to restart this vote thread with the
> four
> > > >> plugins
> > > >> > > but
> > > >> > > > tag their versions as cordova-plugin-compat@1.2.0,
> > > >> > > > cordova-plugin-console@1.1.0. The device motion and device
> > > >> orientation
> > > >> > > > plugins can have any version number we want as they will not
> run
> > > >> into
> > > >> > the
> > > >> > > > above problems.
> > > >> > > >
> > > >> > > >
> > > >> > > > Simon Mac Donald
> > > >> > > > http://simonmacdonald.com
> > > >> > > >
> > > >> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill <
> > > >> stevengil...@gmail.com>
> > > >> > > > wrote:
> > > >> > > >
> > > >> > > > > Plugin vote is going to fail it seems due to the issue simon
> > > >> found.
> > > >> > > > >
> > > >> > > > > Simons  message:
> > > >> > > > > "Failed
> > > >> > > > > * Added cordova-plugin-camera to a project with
> > cordova-android
> > > >> 6.3.0
> > > >> > > > which
> > > >> > > > > depends on cordova-plugin-compat and the build fails.
> > > >> > > > >
> > > >> > > > > The reason the build fails is 

Re: [DISCUSS] Plugin release

2017-09-22 Thread Simon MacDonald
Yeah, we should be doing another plugins release soon. We have:

cordova-plugin-status-bar
cordova-plugin-file-transfer

Needing releases.

Steve, is the release process documented anywhere so you don't have to be
the person who runs it each and every time?


Simon Mac Donald
http://simonmacdonald.com

On Fri, Sep 22, 2017 at 6:00 PM, julio cesar sanchez  wrote:

> For next release I want cordova-plugin-statusbar as I fixed it to work
> properly on iPhone X
>
> 2017-09-22 21:27 GMT+02:00 Steven Gill :
>
> > Please review the blog post for the release
> >
> > https://github.com/apache/cordova-docs/pull/734
> >
> > On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill 
> > wrote:
> >
> > > Yeah I only released the plugins that people mentioned in this thread
> to
> > > release. I can fire up another plugins release next week. What plugins
> do
> > > people want reviewed/released?
> > >
> > > On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald <
> > > simon.macdon...@gmail.com> wrote:
> > >
> > >> Just realized that cordova-plugin-file-transfer was never bumped. It
> > >> includes an important fix for apps. Without it new apps may be
> rejected
> > >> from the Play Store.
> > >>
> > >>
> > >> Simon Mac Donald
> > >> http://simonmacdonald.com
> > >>
> > >> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill 
> > >> wrote:
> > >>
> > >> > the ios release blog post tells users about the console plugin.
> > >> > http://cordova.apache.org/announcements/2017/09/08/ios-release.html
> > >> >
> > >> > I'll make sure to highlight these changes in the plugins release
> blog
> > >> post.
> > >> >
> > >> > Starting a new vote with console + compat only having minor bumps
> > >> >
> > >> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
> > >> > jcesarmob...@gmail.com
> > >> > > wrote:
> > >> >
> > >> > > There has been already a few people asking about the duplicate
> > >> symbols on
> > >> > > slack
> > >> > >
> > >> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald <
> > simon.macdon...@gmail.com
> > >> >:
> > >> > >
> > >> > > > IMHO both cordova-plugin-compat and cordova-plugin-console
> should
> > >> > receive
> > >> > > > minor version bumps. Neither breaks backwards compatibility so I
> > >> don't
> > >> > > feel
> > >> > > > like a major version bump is warranted.
> > >> > > >
> > >> > > > As well all of our core plugins that depend on
> > cordova-plugin-compat
> > >> > use
> > >> > > > the ^1.x in their semver so they would pull in the earlier
> version
> > >> of
> > >> > the
> > >> > > > compat plugin and in combination with the upcoming
> cordova-android
> > >> > 6.3.0
> > >> > > > pretty much all apps will fail to build.
> > >> > > >
> > >> > > > When it comes to cordova-plugin-console we should also err on
> the
> > >> side
> > >> > of
> > >> > > > caution when it comes to the version number bump. I spent some
> > time
> > >> > this
> > >> > > > morning debugging an internal app that was using cordova-ios
> 4.5.0
> > >> and
> > >> > > > cordova-plugin-console. It was failing to build because of
> > duplicate
> > >> > > code.
> > >> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release
> > before
> > >> > > > cordova-ios 4.5.0 the problem would not have existed.
> > >> > > >
> > >> > > > I think we need to be ready to start answering that question as
> to
> > >> why
> > >> > > apps
> > >> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post
> is
> > in
> > >> > > order?
> > >> > > >
> > >> > > > My recommendations is to restart this vote thread with the four
> > >> plugins
> > >> > > but
> > >> > > > tag their versions as cordova-plugin-compat@1.2.0,
> > >> > > > cordova-plugin-console@1.1.0. The device motion and device
> > >> orientation
> > >> > > > plugins can have any version number we want as they will not run
> > >> into
> > >> > the
> > >> > > > above problems.
> > >> > > >
> > >> > > >
> > >> > > > Simon Mac Donald
> > >> > > > http://simonmacdonald.com
> > >> > > >
> > >> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill <
> > >> stevengil...@gmail.com>
> > >> > > > wrote:
> > >> > > >
> > >> > > > > Plugin vote is going to fail it seems due to the issue simon
> > >> found.
> > >> > > > >
> > >> > > > > Simons  message:
> > >> > > > > "Failed
> > >> > > > > * Added cordova-plugin-camera to a project with
> cordova-android
> > >> 6.3.0
> > >> > > > which
> > >> > > > > depends on cordova-plugin-compat and the build fails.
> > >> > > > >
> > >> > > > > The reason the build fails is that all of the cordova plugins
> > that
> > >> > > depend
> > >> > > > > on cordova-plugin-compat do so using a semver of ^1.0.0 or
> > ^1.1.0.
> > >> > > Since
> > >> > > > > compat was bumped to 2.0.0 when you install
> > cordova-plugin-camera
> > >> on
> > >> > > your
> > >> > > > > cordova-android 6.3.0 project it fails the semver and it pulls
> > in
> > >> the
> > >> > > > 1.1.0
> > >> > > > > version. Now both compat and cordova-android deliver the same
> > >> classes
> > >> > > and
> > >> > > > > the b

Re: [DISCUSS] Plugin release

2017-09-22 Thread julio cesar sanchez
For next release I want cordova-plugin-statusbar as I fixed it to work
properly on iPhone X

2017-09-22 21:27 GMT+02:00 Steven Gill :

> Please review the blog post for the release
>
> https://github.com/apache/cordova-docs/pull/734
>
> On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill 
> wrote:
>
> > Yeah I only released the plugins that people mentioned in this thread to
> > release. I can fire up another plugins release next week. What plugins do
> > people want reviewed/released?
> >
> > On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald <
> > simon.macdon...@gmail.com> wrote:
> >
> >> Just realized that cordova-plugin-file-transfer was never bumped. It
> >> includes an important fix for apps. Without it new apps may be rejected
> >> from the Play Store.
> >>
> >>
> >> Simon Mac Donald
> >> http://simonmacdonald.com
> >>
> >> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill 
> >> wrote:
> >>
> >> > the ios release blog post tells users about the console plugin.
> >> > http://cordova.apache.org/announcements/2017/09/08/ios-release.html
> >> >
> >> > I'll make sure to highlight these changes in the plugins release blog
> >> post.
> >> >
> >> > Starting a new vote with console + compat only having minor bumps
> >> >
> >> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
> >> > jcesarmob...@gmail.com
> >> > > wrote:
> >> >
> >> > > There has been already a few people asking about the duplicate
> >> symbols on
> >> > > slack
> >> > >
> >> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald <
> simon.macdon...@gmail.com
> >> >:
> >> > >
> >> > > > IMHO both cordova-plugin-compat and cordova-plugin-console should
> >> > receive
> >> > > > minor version bumps. Neither breaks backwards compatibility so I
> >> don't
> >> > > feel
> >> > > > like a major version bump is warranted.
> >> > > >
> >> > > > As well all of our core plugins that depend on
> cordova-plugin-compat
> >> > use
> >> > > > the ^1.x in their semver so they would pull in the earlier version
> >> of
> >> > the
> >> > > > compat plugin and in combination with the upcoming cordova-android
> >> > 6.3.0
> >> > > > pretty much all apps will fail to build.
> >> > > >
> >> > > > When it comes to cordova-plugin-console we should also err on the
> >> side
> >> > of
> >> > > > caution when it comes to the version number bump. I spent some
> time
> >> > this
> >> > > > morning debugging an internal app that was using cordova-ios 4.5.0
> >> and
> >> > > > cordova-plugin-console. It was failing to build because of
> duplicate
> >> > > code.
> >> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release
> before
> >> > > > cordova-ios 4.5.0 the problem would not have existed.
> >> > > >
> >> > > > I think we need to be ready to start answering that question as to
> >> why
> >> > > apps
> >> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is
> in
> >> > > order?
> >> > > >
> >> > > > My recommendations is to restart this vote thread with the four
> >> plugins
> >> > > but
> >> > > > tag their versions as cordova-plugin-compat@1.2.0,
> >> > > > cordova-plugin-console@1.1.0. The device motion and device
> >> orientation
> >> > > > plugins can have any version number we want as they will not run
> >> into
> >> > the
> >> > > > above problems.
> >> > > >
> >> > > >
> >> > > > Simon Mac Donald
> >> > > > http://simonmacdonald.com
> >> > > >
> >> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill <
> >> stevengil...@gmail.com>
> >> > > > wrote:
> >> > > >
> >> > > > > Plugin vote is going to fail it seems due to the issue simon
> >> found.
> >> > > > >
> >> > > > > Simons  message:
> >> > > > > "Failed
> >> > > > > * Added cordova-plugin-camera to a project with cordova-android
> >> 6.3.0
> >> > > > which
> >> > > > > depends on cordova-plugin-compat and the build fails.
> >> > > > >
> >> > > > > The reason the build fails is that all of the cordova plugins
> that
> >> > > depend
> >> > > > > on cordova-plugin-compat do so using a semver of ^1.0.0 or
> ^1.1.0.
> >> > > Since
> >> > > > > compat was bumped to 2.0.0 when you install
> cordova-plugin-camera
> >> on
> >> > > your
> >> > > > > cordova-android 6.3.0 project it fails the semver and it pulls
> in
> >> the
> >> > > > 1.1.0
> >> > > > > version. Now both compat and cordova-android deliver the same
> >> classes
> >> > > and
> >> > > > > the build fails."
> >> > > > >
> >> > > > > I actually have 1.2.0 version of the plugin already tagged from
> >> when
> >> > I
> >> > > > ran
> >> > > > > the plugin process on Monday. It is identical to the 2.0.0
> version
> >> > that
> >> > > > is
> >> > > > > being voted on. We can either stop the current vote thread and
> >> start
> >> > a
> >> > > > new
> >> > > > > one with 1.2.0 instead of 2.0.0, or we could continue the
> current
> >> > vote
> >> > > > > thread and start a new one just for compat@1.2.0. If we go with
> >> > option
> >> > > > 2,
> >> > > > > we can release both 1.2.0 and 2.0.0.
> >> > > > >
> >> > > > > This is a good point to rememb

Re: [Discuss] Cordova-Android 6.3.0 Release

2017-09-22 Thread Simon MacDonald
SGTM

Simon Mac Donald
http://simonmacdonald.com

On Fri, Sep 22, 2017 at 5:29 PM, Steven Gill  wrote:

> yup!
>
> On Fri, Sep 22, 2017 at 2:18 PM, Joe Bowser  wrote:
>
> > OK, we should start the vote on Monday so that we don't leave a vote over
> > the weekend that people miss.  Everyone cool with that?
> >
> > On Tue, Sep 5, 2017 at 4:48 PM, Simon MacDonald <
> simon.macdon...@gmail.com
> > >
> > wrote:
> >
> > > As soon as we release cordova-plugin-compat because we've added all
> those
> > > classes into cordova-android propper.
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > > On Tue, Sep 5, 2017 at 7:46 PM, Simon MacDonald <
> > simon.macdon...@gmail.com
> > > >
> > > wrote:
> > >
> > > > Let's do it
> > > >
> > > > Simon Mac Donald
> > > > http://simonmacdonald.com
> > > >
> > > > On Tue, Sep 5, 2017 at 2:01 PM, Steven Gill 
> > > > wrote:
> > > >
> > > >> Lets do it. I'll update cordova-common in android now
> > > >>
> > > >> On Tue, Sep 5, 2017 at 10:58 AM, Joe Bowser 
> > wrote:
> > > >>
> > > >> > Hey
> > > >> >
> > > >> > I'm back from PTO and while I was out, Android Oreo got
> released.  I
> > > >> bumped
> > > >> > the target SDK in the repo before I left for PTO, and I'm
> wondering
> > > how
> > > >> > people feel about doing a 6.3.0 release to support Oreo now that
> > it's
> > > a
> > > >> > real thing?
> > > >> >
> > > >> > Thoughts?
> > > >> >
> > > >> > Joe
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
>


Re: [Discuss] Cordova-Android 6.3.0 Release

2017-09-22 Thread Steven Gill
yup!

On Fri, Sep 22, 2017 at 2:18 PM, Joe Bowser  wrote:

> OK, we should start the vote on Monday so that we don't leave a vote over
> the weekend that people miss.  Everyone cool with that?
>
> On Tue, Sep 5, 2017 at 4:48 PM, Simon MacDonald  >
> wrote:
>
> > As soon as we release cordova-plugin-compat because we've added all those
> > classes into cordova-android propper.
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Tue, Sep 5, 2017 at 7:46 PM, Simon MacDonald <
> simon.macdon...@gmail.com
> > >
> > wrote:
> >
> > > Let's do it
> > >
> > > Simon Mac Donald
> > > http://simonmacdonald.com
> > >
> > > On Tue, Sep 5, 2017 at 2:01 PM, Steven Gill 
> > > wrote:
> > >
> > >> Lets do it. I'll update cordova-common in android now
> > >>
> > >> On Tue, Sep 5, 2017 at 10:58 AM, Joe Bowser 
> wrote:
> > >>
> > >> > Hey
> > >> >
> > >> > I'm back from PTO and while I was out, Android Oreo got released.  I
> > >> bumped
> > >> > the target SDK in the repo before I left for PTO, and I'm wondering
> > how
> > >> > people feel about doing a 6.3.0 release to support Oreo now that
> it's
> > a
> > >> > real thing?
> > >> >
> > >> > Thoughts?
> > >> >
> > >> > Joe
> > >> >
> > >>
> > >
> > >
> >
>


Re: [Discuss] Cordova-Android 6.3.0 Release

2017-09-22 Thread Joe Bowser
OK, we should start the vote on Monday so that we don't leave a vote over
the weekend that people miss.  Everyone cool with that?

On Tue, Sep 5, 2017 at 4:48 PM, Simon MacDonald 
wrote:

> As soon as we release cordova-plugin-compat because we've added all those
> classes into cordova-android propper.
>
> Simon Mac Donald
> http://simonmacdonald.com
>
> On Tue, Sep 5, 2017 at 7:46 PM, Simon MacDonald  >
> wrote:
>
> > Let's do it
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> > On Tue, Sep 5, 2017 at 2:01 PM, Steven Gill 
> > wrote:
> >
> >> Lets do it. I'll update cordova-common in android now
> >>
> >> On Tue, Sep 5, 2017 at 10:58 AM, Joe Bowser  wrote:
> >>
> >> > Hey
> >> >
> >> > I'm back from PTO and while I was out, Android Oreo got released.  I
> >> bumped
> >> > the target SDK in the repo before I left for PTO, and I'm wondering
> how
> >> > people feel about doing a 6.3.0 release to support Oreo now that it's
> a
> >> > real thing?
> >> >
> >> > Thoughts?
> >> >
> >> > Joe
> >> >
> >>
> >
> >
>


Re: [VOTE] Plugins Release (attempt 2)

2017-09-22 Thread Steven Gill
The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Joe Bowser
Simon MacDonalod

The vote has passed.


On Wed, Sep 20, 2017 at 4:32 PM, Steven Gill  wrote:

> discuss thread Simon!
>
> On Wed, Sep 20, 2017 at 4:21 PM, Simon MacDonald <
> simon.macdon...@gmail.com> wrote:
>
>> Just realized that cordova-plugin-file-transfer was never bumped. It
>> includes an important fix for apps. Without it new apps may be rejected
>> from the Play Store.
>>
>>
>> Simon Mac Donald
>> http://simonmacdonald.com
>>
>> On Wed, Sep 20, 2017 at 6:01 PM, Joe Bowser  wrote:
>>
>> > I vote +1
>> >
>> > * Verified Archives
>> > * Tested MobileSpec and made sure that Camera actually got installed
>> > * Tested against master of cordova-android (cordova-android >= 6.3.0)
>> >
>> > On Wed, Sep 20, 2017 at 11:25 AM, Simon MacDonald <
>> > simon.macdon...@gmail.com
>> > > wrote:
>> >
>> > > I vote + 1
>> > >
>> > > Passed
>> > > * Checked for deprecation notices for plugin-device-motion &
>> orientation
>> > > * Tested that cordova-plugin-console is not added for ios when
>> > cordova-ios
>> > > >= 4.5.0
>> > > * Tested that cordova-plugin-compat is not added for android when
>> > > cordova-android >= 6.3.0
>> > > * Added cordova-plugin-camera to a project with cordova-android 6.3.0
>> > which
>> > > depends on cordova-plugin-compat (from github master) and the build
>> > passes.
>> > >
>> > >
>> > > Simon Mac Donald
>> > > http://simonmacdonald.com
>> > >
>> > > On Wed, Sep 20, 2017 at 1:57 PM, Steven Gill 
>> > > wrote:
>> > >
>> > > > Please review and vote on the release of this plugins release
>> > > > by replying to this email (and keep discussion on the DISCUSS
>> thread)
>> > > >
>> > > > Release issue: https://issues.apache.org/jira/browse/CB-13294
>> > > >
>> > > > The plugins have been published to
>> > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13294/
>> > > >
>> > > > The packages were published from their corresponding git tags:
>> > > > cordova-plugin-console: 1.1.0 (ef9bd9ceb4)
>> > > > cordova-plugin-compat: 1.2.0 (be2a46be8d)
>> > > > cordova-plugin-device-motion: 2.0.0 (1236b957af)
>> > > > cordova-plugin-device-orientation: 2.0.0 (d6b3322fcb)
>> > > >
>> > > > Upon a successful vote I will upload the archives to dist/, upload
>> > > > them to npm, and post the corresponding blog post.
>> > > >
>> > > > Voting guidelines:
>> > > > https://github.com/apache/cordova-coho/blob/master/docs/
>> > > release-voting.md
>> > > > How to vote on a plugins release at
>> > > > https://github.com/apache/cordova-coho/blob/master/docs/
>> > > > plugins-release-process.md#voting
>> > > >
>> > > > Voting will go on for a minimum of 48 hours.
>> > > >
>> > > > I vote +1:
>> > > > * Ran coho audit-license-headers over the relevant repos
>> > > > * Ran coho check-license to ensure all dependencies and
>> > > > subdependencies have Apache-compatible licenses
>> > > > * Ensured continuous build was green when repos were tagged
>> > > >
>> > >
>> >
>>
>
>


[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2017-09-22 Thread andreszs
Github user andreszs commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
@dpogue That worked perfectly, thank you!! +10


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2017-09-22 Thread dpogue
Github user dpogue commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
@andreszs Something like this should work:

```xml



```


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2017-09-22 Thread andreszs
Github user andreszs commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
@ktop Please let me know if the plugin can be used to add the attribute 
`android:installLocation="auto"` into the `manifest` node itself. The docs only 
explain how to add **child nodes**, and I really tried many ways to add only 
this attribute only without success. Thank you.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Plugin release

2017-09-22 Thread Steven Gill
Please review the blog post for the release

https://github.com/apache/cordova-docs/pull/734

On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill  wrote:

> Yeah I only released the plugins that people mentioned in this thread to
> release. I can fire up another plugins release next week. What plugins do
> people want reviewed/released?
>
> On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald <
> simon.macdon...@gmail.com> wrote:
>
>> Just realized that cordova-plugin-file-transfer was never bumped. It
>> includes an important fix for apps. Without it new apps may be rejected
>> from the Play Store.
>>
>>
>> Simon Mac Donald
>> http://simonmacdonald.com
>>
>> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill 
>> wrote:
>>
>> > the ios release blog post tells users about the console plugin.
>> > http://cordova.apache.org/announcements/2017/09/08/ios-release.html
>> >
>> > I'll make sure to highlight these changes in the plugins release blog
>> post.
>> >
>> > Starting a new vote with console + compat only having minor bumps
>> >
>> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez <
>> > jcesarmob...@gmail.com
>> > > wrote:
>> >
>> > > There has been already a few people asking about the duplicate
>> symbols on
>> > > slack
>> > >
>> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald > >:
>> > >
>> > > > IMHO both cordova-plugin-compat and cordova-plugin-console should
>> > receive
>> > > > minor version bumps. Neither breaks backwards compatibility so I
>> don't
>> > > feel
>> > > > like a major version bump is warranted.
>> > > >
>> > > > As well all of our core plugins that depend on cordova-plugin-compat
>> > use
>> > > > the ^1.x in their semver so they would pull in the earlier version
>> of
>> > the
>> > > > compat plugin and in combination with the upcoming cordova-android
>> > 6.3.0
>> > > > pretty much all apps will fail to build.
>> > > >
>> > > > When it comes to cordova-plugin-console we should also err on the
>> side
>> > of
>> > > > caution when it comes to the version number bump. I spent some time
>> > this
>> > > > morning debugging an internal app that was using cordova-ios 4.5.0
>> and
>> > > > cordova-plugin-console. It was failing to build because of duplicate
>> > > code.
>> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release before
>> > > > cordova-ios 4.5.0 the problem would not have existed.
>> > > >
>> > > > I think we need to be ready to start answering that question as to
>> why
>> > > apps
>> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is in
>> > > order?
>> > > >
>> > > > My recommendations is to restart this vote thread with the four
>> plugins
>> > > but
>> > > > tag their versions as cordova-plugin-compat@1.2.0,
>> > > > cordova-plugin-console@1.1.0. The device motion and device
>> orientation
>> > > > plugins can have any version number we want as they will not run
>> into
>> > the
>> > > > above problems.
>> > > >
>> > > >
>> > > > Simon Mac Donald
>> > > > http://simonmacdonald.com
>> > > >
>> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill <
>> stevengil...@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > Plugin vote is going to fail it seems due to the issue simon
>> found.
>> > > > >
>> > > > > Simons  message:
>> > > > > "Failed
>> > > > > * Added cordova-plugin-camera to a project with cordova-android
>> 6.3.0
>> > > > which
>> > > > > depends on cordova-plugin-compat and the build fails.
>> > > > >
>> > > > > The reason the build fails is that all of the cordova plugins that
>> > > depend
>> > > > > on cordova-plugin-compat do so using a semver of ^1.0.0 or ^1.1.0.
>> > > Since
>> > > > > compat was bumped to 2.0.0 when you install cordova-plugin-camera
>> on
>> > > your
>> > > > > cordova-android 6.3.0 project it fails the semver and it pulls in
>> the
>> > > > 1.1.0
>> > > > > version. Now both compat and cordova-android deliver the same
>> classes
>> > > and
>> > > > > the build fails."
>> > > > >
>> > > > > I actually have 1.2.0 version of the plugin already tagged from
>> when
>> > I
>> > > > ran
>> > > > > the plugin process on Monday. It is identical to the 2.0.0 version
>> > that
>> > > > is
>> > > > > being voted on. We can either stop the current vote thread and
>> start
>> > a
>> > > > new
>> > > > > one with 1.2.0 instead of 2.0.0, or we could continue the current
>> > vote
>> > > > > thread and start a new one just for compat@1.2.0. If we go with
>> > option
>> > > > 2,
>> > > > > we can release both 1.2.0 and 2.0.0.
>> > > > >
>> > > > > This is a good point to remember in the future. Deprecation
>> should be
>> > > > minor
>> > > > > not major bumps.
>> > > > >
>> > > > >
>> > > > > On Tue, Sep 12, 2017 at 11:43 PM, Shazron 
>> wrote:
>> > > > >
>> > > > > > Created PR for CB-13170 cordova-plugin-console
>> > > > > > https://github.com/apache/cordova-plugin-console/pull/25
>> > > > > >
>> > > > > > On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald <
>> > > > > > simon.macdon...@gmail.com>
>> > > > > > wrote:
>> > > > > >
>> >