[GitHub] cordova-android issue #365: CB-12524: Fix the GradleBuilder so that it build...
Github user csantanapr commented on the issue: https://github.com/apache/cordova-android/pull/365 I'm confuse what jar you are referring? I don't see the jar on the change set files Adding a gradlew it's perfectly fine, this is useful as it takes care of the dependencies and saves on installation versions headaches --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update
Github user csantanapr commented on the issue: https://github.com/apache/cordova-lib/pull/465 LGTM Maybe print some message about next steps "you need to manually moved any platform configuration from backup version a.b.c to x.y.z as you see it fit for your project" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: Telemetry
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218834713 Sounds good to me to proceed then, it was a random idea --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: Telemetry
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-218715695 I have one question, maybe I missed it in discussion why is this implemented in CLI and not LIB I think it make more sense to implement in the top level of API entry points in LIB like create platform plugin etc. In LIB will be disable by default CLI will call API with new parameter to enable telemetry CLI telemetry will Be enable by default and CLI will offer user a CLI flag and env to disable telemetry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: Telemetry
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/247#issuecomment-217944908 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-203621399 @rakatyal Thanks for prompt review and working with @dubeejw :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-202988290 ping @rakatyal can you review this PR and merge if its good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/417 CB-10965 xml helper allows multiple instances to be merge in config.xml @vladimir-kotikov I this is the real fix on duplicate names ending up in final config.xml triggering the unwanted rename of the xcode project in ios You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-lib CB-10965 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/417.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #417 commit 4577f3e61693db8ac531917ed4a273f4de40b903 Author: Carlos Santana <csantan...@gmail.com> Date: 2016-03-26T22:53:52Z CB-10965 xml helper allows multiple instances to be merge in config.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-201937380 @vladimir-kotikov yes lets fix this in cordova-lib to get a fix in CLI 6.1.1, but I agree with you that problem should also be fix in iOS The root of the problem is the merge of XML the value from project config.xml doesn't overwrite the in default platform config.xml I open the JIRA [CB-10965](https://issues.apache.org/jira/browse/CB-10965) The real problem is cordova-common merge util where i think the tag name should be single instance in result of merge https://github.com/apache/cordova-lib/blob/master/cordova-common/src/util/xml-helpers.js#L197 similar as author and description. it will require a cordova-common release, then an iOS to pick up the change. But I think fixing in CLI 6.1.1 is required to not brake other ios platforms versions that don't have this fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-201893339 @riknoll @vladimir-kotikov I found a way to skip prepare hooks on first prepare call. made the change I rebase, please review again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-201881251 @riknoll I don't think is big deal if prepare hooks twice, I will look to see if there is a way to call first prepare without hooks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/416 CB-10961 Error when adding ios platform and plugin declare in config.xml @vladimir-kotikov can you review This other commit https://github.com/apache/cordova-lib/commit/3b9face5187857d354d85f3e3f4316cbace100db changing the order to run prepare after plugin install cause the problem. I added a prepare before, and left the prepare on after plugin install. I don't think there is harm on running prepare twice on platform add You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-lib CB-10961 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/416.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #416 commit 9359d3b421a323601ea62587cab19bfad8690fb7 Author: Carlos Santana <csantan...@gmail.com> Date: 2016-03-25T20:17:01Z CB-10961 Error no such file or directory adding ios platform when plugins present or required --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-199892126 @dubeejw can you review your changes again , CI is failing appveyor and travois-ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9264 - Duplicate entries in config.xm...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/412#issuecomment-197559090 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10694 - Platform-specific configurati...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/411#issuecomment-197558977 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-197128552 @stevengill the npm install portion is reverted now, I will take a look at your PR for npm fetch on how is handling the template fetching and npm install. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-197123180 @stevengill oops good catch, that npm install portion was not suppose to be there, I was just experimenting, only the top portion for the sub dir. I agree npm install should be part of [cordova/cordova-discuss#33](https://github.com/cordova/cordova-discuss/pull/33) where everything is npm fetch and handles npm install --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-196831845 @vladimir-kotikov thanks for the review I will check on those --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-196618485 @dblotsky I vote for using links #555 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-196488029 @dblotsky LGTM ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/410#issuecomment-196399690 @stevengill @vladimir-kotikov could you review this when you have chance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10808 **CLI** Should handle templates...
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/410 CB-10808 **CLI** Should handle templates with files located in sub directory Refer to [CB-1080](https://issues.apache.org/jira/browse/CB-10808) for more info You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-lib CB-10808 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/410.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #410 commit e77d71d1d617173e8406ff581332f96845bfd01a Author: Carlos Santana <csantan...@gmail.com> Date: 2016-03-14T16:17:58Z CB-10808 **CLI** __src__ Support templates with subdirectory commit 0f767439949e97de91fc0e26d90f4a7426a05122 Author: Carlos Santana <csantan...@gmail.com> Date: 2016-03-14T16:18:14Z CB-10808 **CLI** __test__ Support templates with subdirectory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-195847261 They don't have to be on the row on mobile. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-195847241 @dblotsky no way we can make it work on mobile float, flex, css, etc.. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/551#issuecomment-195385864 @dblotsky Love the option to help with translations to get them to the right spot in Crowding. Still I think the label for the button should be changed from "Edit" that was my initial concern. just Edit it's hard to spot and not knowing if it's going to login the user like the wiki Can we have for English the button say "Edit Source on Github" and just be a Link, this way Link means you are going to leave this page and visit Gihub. Since there is one option. Other Languages I would put two links "Edit Source on Gihub" and "Edit Translation on Crowding" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Blog post for Plugin release 03 12
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/550#issuecomment-194888965 @dpogue weird I didn't catch this I was using VSCode preview and they looked fine, it could a difference in markdown with Github, I fixed, thanks for the review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Blog post for Plugin release 03 12
Github user csantanapr commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/550#discussion_r55690550 --- Diff: www/_posts/2016-03-12-plugin-release.md --- @@ -0,0 +1,74 @@ +--- +layout: post +author: +name: Carlos Santana +url: https://twitter.com/csantanapr +title: "Plugins Release" +categories: news +tags: release plugins +--- + +The following plugins were updated today: + +* cordova-plugin-camera@2.1.1 +* cordova-plugin-statusbar@2.1.2 +* cordova-plugin-globalization@1.0.3 +* cordova-plugin-splashscreen@3.2.1 + + + +You can update any plugin by removing it, and then re-adding it. + + E.g. To update your media plugin: + +cordova plugin rm cordova-plugin-camera --save +cordova plugin add cordova-plugin-camera@2.1.1 --save + +Changes include: + + +cordova-plugin-camera@2.1.1 +* [CB-10825](https://issues.apache.org/jira/browse/CB-10825) android: Always request READ permission for gallery source --- End diff -- @dpogue weird I didn't catch this I was using VSCode preview and they looked fine, it could a difference in markdown with Github, I fixed, thanks for the review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Plugin release 03 12
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-docs/pull/550 Plugin release 03 12 You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-docs plugin_release_03_12 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/550.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #550 commit 6ff5b20ed6a842f0d29a3cca5c2c6aaafc72fe86 Author: Carlos Santana <csantan...@gmail.com> Date: 2016-03-10T04:29:59Z blog post for plugin release for 2016-03-12 commit eee4ace8e022cf5450e73d38368c7629b7a213bd Author: Carlos Santana <csantan...@gmail.com> Date: 2016-03-10T04:32:25Z added links --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194599948 @riknoll what's the final conclusion for the plugin release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/191#issuecomment-194567940 @riknoll I'm not too familiar with android permission would be up to @infil00p @jcesarmobile or maybe @macdonst --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10788 Add blog post about browser@4....
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/539#issuecomment-194374056 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-globalization pull request: CB-10792 -Cannot instal...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/47#issuecomment-192465550 @dubeejw I meant not the file itself but the path, I think you know what I meant :laughing: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-globalization pull request: CB-10792 -Cannot instal...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/47#issuecomment-192465283 Hi @dubeejw it would be good to go over all the cordova plugins plugin.xml and check which one have this bug of not using lower case for source files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8976: Removing the auto-version f...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-android/pull/270#issuecomment-192333002 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10687 added android 5.1.1 release bl...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/529#issuecomment-191343818 Let's use "CLI" in "Cordova CLI 6.0.0" With so many Cordova components is good to be explicit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-186021548 Thanks @jcesarmobile for commenting we wanted someone to review it before we took it out. @eymorale looks like it's OK to go ahead and remove then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/193#issuecomment-186017788 Thanks @mhartington for testing you were able to recreate very easy in your setup. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-185330171 I agree we should remove the file all together is not required for functionality that the plugin offers. @infil00p Are you OK with the removal of the js file? @infil00p the error message is anorying and confusing to developers in the console. CSP is not required for the Whitelist code to work. I think we should also move the CSP info from the README to the Security Guide in the docs, it gives the false impresion that the cordova plugin is parsing the CSP tag and processing and doing something with it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/9#issuecomment-184509346 Can you open a JIRA for this change, and the reasoning behind? What is content:// for? Why do you think this have to be added by default instead of having developer explicit added them to via config.xml or plugin? We want whitelist to be lock/secure by default, and developer to open only what's required, not every developer needs all these defaults. cc @infil00p --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/493#issuecomment-184499148 Sorry I'm late to this one, It looks like @stevengill already review. Just some dumb questions 1. What impact this has to translation process? 2. Everything automated to avoid maintenance headache to keep website in sync? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-android/pull/257#issuecomment-180554647 @riknoll you are going to merge this or there is more work to be done? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-android/pull/257#issuecomment-180557444 @riknoll sure no problem, I was just curious if there was more you wanted me to look at. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10498: Resume event should be sti...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-android/pull/257#issuecomment-180171364 @riknoll I tested the pull request and it's working for me. lastResume keeps the data, any new listener that get's attached get's the data. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10505 Adds cordova-plugin-inappbrows...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/486#issuecomment-179833612 Change the date on the file and to 2016-02-04 Other than that looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/373 CB-10499 - --template should pull the latest template from NPM when version isn't specified - Pull the latest template if no version is specified - Rename NPM to npm rename github to git This close #372 You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-lib pr-372 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/373.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #373 commit a65333cfe490288dc5bc0ce992c88d4764872a94 Author: dubeejw <jwdu...@us.ibm.com> Date: 2016-02-01T20:31:26Z CB-10499 - --template should pull the latest template from NPM when version isn't specified - Pull the latest template if no version is specified - Rename NPM to npm rename github to git This close #372 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-windows/pull/147#issuecomment-178054738 For what version is this for? cordova-windows@5.0.0 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10472 NullPointerException: org.a...
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-android/pull/255 CB-10472 NullPointerException: org.apache.cordova.PluginManager.onSav… …eInstanceState check if pluginManager is null before using it You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-android CB-10472 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/255.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #255 commit 907e67d2b8dc13673271182555ab66a2564448af Author: Carlos Santana <csantan...@gmail.com> Date: 2016-01-28T20:57:38Z CB-10472 NullPointerException: org.apache.cordova.PluginManager.onSaveInstanceState check if pluginManager is null before using it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9311 CB-10162 fixes app icon 87x87 an...
Github user csantanapr closed the pull request at: https://github.com/apache/cordova-ios/pull/183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/182#issuecomment-163343647 @eymorale LGTM go ahead and merge it, I will close mine #183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9311 CB-10162 fixes app icon 87x87 an...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/183#issuecomment-163343873 closing this one since #182 fixed it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162933618 @shazron ah ok, maybe I was thinking oh what about whitelist stuff? Any other high level feature? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162934923 ok, I went over the wholes changes, that's it I didn't find anything else --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162930851 What about mentioning other some high level features: 1. Support Asset Catalog 2. ios-sim (will use internal version, no need to npm i -g ios-sim) 3. ios-deploy (get the latest version) 4. can handle new fields in config.xml (I'm making this up? like xxconfig additions) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162934402 What about AppDelegate changes/moving? What about minimum Deployment Target to iOS 8.0? What does this means for humans :-), no ios 7? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add cordova-ios-4.0.0 release blog post...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/436#issuecomment-162974919 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/182#discussion_r47048171
--- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
@@ -257,10 +257,11 @@ function handleBuildSettings(platformConfig,
locations) {
return Q();
}
-function handleIcons(projectConfig, platformRoot) {
+function handleIcons(projectConfig, platformRoot, locations) {
var icons = projectConfig.getIcons('ios');
-var appRoot = projectConfig.path;
+var appRoot = path.dirname(projectConfig.path);
+var originalName = path.basename(locations.xcodeCordovaProj);
--- End diff --
no need to create a new variable originalName or add 3rd parameter, use the
value already provided here self.locations.xcodeCordovaProj
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-10162 correct the paths for iOS icon ...
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/182#discussion_r47048069
--- Diff: bin/templates/scripts/cordova/lib/prepare.js ---
@@ -47,8 +47,8 @@ module.exports.prepare = function (cordovaProject) {
return updateProject(self._config, self.locations);
})
.then(function () {
-handleIcons(cordovaProject.projectConfig, self.root);
-handleSplashScreens(cordovaProject.projectConfig, self.root);
+handleIcons(cordovaProject.projectConfig, self.root,
self.locations);
--- End diff --
@eymorale
instead of passing self.locations, pass the directory to use
handleIcons(cordovaProject.projectConfig, self.locations.xcodeCordovaProj);
handleSplashScreens(cordovaProject.projectConfig,
self.locations.xcodeCordovaProj);
then no need to do basename or create new variable originalName
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9311 CB-10162 fixes app icon 87x87 an...
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-ios/pull/183 CB-9311 CB-10162 fixes app icon 87x87 and copy errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-ios CB-9311 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/183.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #183 commit 83a3b6184230e90cf6e42254e9673e28ee218b69 Author: Carlos Santana <csantan...@gmail.com> Date: 2015-12-09T03:48:54Z CB-9311 CB-10162 fixes app icon 87x87 and copy errors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: Cordova-cli doesn't work with node 5
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/228#issuecomment-161818866 @unimonkiez Open a JIRA issue if node 5 having issues in your use cases, latest cli works with node 4 and 5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Added page describing how to create iss...
Github user csantanapr commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/418#discussion_r44826426 --- Diff: www/contribute/contribute_guidelines.md --- @@ -0,0 +1,77 @@ +--- +layout: contribute-help +title: Apache Cordova Contribute Guidelines +--- +# Contributor Guidelines + +Thanks for helping to improve Cordova! This page provides a general guide on making contributions to Cordova. If you can't find something on this page, please feel free to contact the [dev mailing list](http://cordova.apache.org/contact) or ask questions on the Cordova Slack. + +## Prerequisites + +Before contributing to Apache Cordova, please complete the following steps: + +1. Sign the [Individual Contributor License Agreement (ICLA)](http://www.apache.org/licenses/#clas) and [submit it to the ASF](http://www.apache.org/licenses/#submitting). +* You should receive an email confirming you submission within a day or so and your name will appear in the [list of committers and non-committers](https://people.apache.org/committer-index.html) +* If you are submitting on behalf of a company, you may need to submit a CCLA as well +2. Join the [mailing list](http://cordova.apache.org/contact/) and send a brief introduction of yourself +3. Create an [Apache JIRA](https://issues.apache.org/jira/secure/Signup!default.jspa) account + +## Working with JIRA + +Issues for Apache Cordova are hosted in the Apache JIRA. All code contributions made to Cordova should have a corresponding JIRA issue. When reporting issues, please follow [these guidelines](./issues.html). + + Claiming Issues +If you find a JIRA issue that you would like to work on, you can ask to claim it; please leave a comment indicating your intention and a committer will assign it to you. Some issues in JIRA are auto-assigned to certain contributors. If it is clear that an issue is not being worked on, feel free to work on it yourself (but please comment first to let the asignee know). If you are looking for a place to start, try searching the [issues labelled easyfix](https://issues.apache.org/jira/browse/CB-9974?jql=project%20%3D%20CB%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20%22easyfix%22%20ORDER%20BY%20createdDate%20DESC). + + +## Submitting Code --- End diff -- Do you want to add some information from the coho repo here? https://github.com/apache/cordova-coho/blob/master/docs/committer-workflow.md Some steps are useful, specially for new folks using git We also have a one for submitting code for review, which in summary is use Github and mail dev list https://github.com/apache/cordova-coho/blob/master/docs/code-reviews.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Fixes CB-4712, CB-5439 stat...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/38#issuecomment-154596695 LGTM, rebase the two commits into a single one. Basically you added an observer that anytime that you get notify about status bar change, you do a resize. The approach sounds reasonable. It will be good if @shazron can take a quick look also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526 @shazron is this a lesson learned that certain experimental things should be kept in experimental branches and not in master :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/178#issuecomment-153887028 With this removal, is there a minimum ios version that this will work only using the IFRAME_NAV bridge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152646051 I think is a nice feature to open the browser to a good spot on the wen to search for plugins applicable for cli use cases where people are running by hand when they get started to use the CLI. not applicable to unattended. The current form is just a mess of a UI/UX. For scripting or unattended like gulp scripts I guess they can use npmsearh same way we are doing for the website plugin search. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-coho/pull/97#issuecomment-152054152 +1 LGTM Yes Agree, I think folks see a name associated with a bug, and they think that person already looked at it when it reality it's what @purplecabbage indicated it's all for grabs, and the active folks are more resident experts. I think it's great doc @nikhilkh and when we agree it can be put in the "Contribute" page on the website at least the portion of how to open a bug and what to do with the fields. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Remove ops
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151138324 I'm not android SME, maybe @macdonst can take a look. My general comment on this PR, is that if you don't know what are not sure what's the root cause of the problem, and and not sure about a proper fix you should not submit a patch, maybe better to open a new issue in JIRA http://issues.cordova.io with all background info you found so far. PS: Android can be a mess to support, just because something work in one version of Android doesn't mean that will work the same way in all other versions of Android. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase
Github user csantanapr closed the pull request at: https://github.com/apache/cordova-docs/pull/379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-docs/pull/379 Add ReactEurope App to Showcase ok this time link points to correct location where both apps ios and android are located You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-docs cordova-website Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/379.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #379 commit 179ece584b0fb735136bef7b893faa49e1e3eaeb Author: Carlos Santana <csantan...@gmail.com> Date: 2015-10-09T16:19:35Z Add ReactEurope App to Showcase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/375#issuecomment-146873280 This pull request is a mess, I close and try to do a new one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase
Github user csantanapr closed the pull request at: https://github.com/apache/cordova-docs/pull/375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/375#issuecomment-146871381 @dblotsky found the correct website that list both platforms ios and android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/375#issuecomment-146684495 Sorry about that @fredgalvao I changed the link to point to app in itunes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-docs/pull/375 Add ReactEurope App to Showcase You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-docs cordova-website Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/375.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #375 commit 202c67f1efce4c191b7c9c9850a1ad044d474e94 Author: Carlos Santana <csantan...@gmail.com> Date: 2015-10-08T19:31:39Z Add ReactEurope App to Showcase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9739 Prevent coho from creating brok...
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41204416
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
yield repoutil.forEachRepo(repos, function*(repo) {
+if(isWin) {
--- End diff --
Thanks for the clarification @daserge
On Mac by default using git from XCode Tools, both of the settings
core.autocrlf and core.eol are not set at all, so I would think let's leave
this check only for Win as you have it here, go ahead and merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/170#issuecomment-145299566 I did some investigation today, I found the reason why putting CLANG_ENABLE_MODULES = NO in build.xcconfig doesn't get reflected, is because build.xcconfig is for Project, not the Target, the Project file is set to Yes, and Project file has higher precedence than Project xcconfig For the variable assingment to be able to work it needs to be set in Target's release/build or extras xcconfig There is another value that also fixes our problem with a framework referring to a non-module header/class from CordovaLib CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES From looking at all levels in XCode, it looks like the iOS Platform default is: CLANG_ENABLE_MODULES = NO and CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = NO But XCode 7 when it creates a new projects, overwrites the default of one of them to CLANG_ENABLE_MODULES = YES It might be safer to set CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES which I think is more closer to the compile error that we are getting, and maybe has less side effects. By Google Power I discover this page, explains variable assignment precedence: http://pewpewthespells.com/blog/xcconfig_guide.html What you all think? And what would be the best to assign it? Project (build.xcconfig) or Target (build-debug.xcconfig and build-release.xcconfig) We could use extras but I would like to leave extra empty for the developer/user to overwrite values from Target and Project xcconfig programmatically --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9739 Prevent coho from creating brok...
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41020487
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
yield repoutil.forEachRepo(repos, function*(repo) {
+if(isWin) {
--- End diff --
Why the windows check?
Can a mac or linux users have a bad git config? and then the check will not
run for them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9739 Prevent coho from creating brok...
Github user csantanapr commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/95#discussion_r41082335
--- Diff: src/create-verify-archive.js ---
@@ -76,6 +77,49 @@ exports.createCommand = function*(argv) {
var absOutDir = path.resolve(outDir);
yield repoutil.forEachRepo(repos, function*(repo) {
+if(isWin) {
--- End diff --
@nikhilkh I'm Ok with the change I was just curious of why the isWin,
that's all.
I was not trying to blocked the merge. Merge away..
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-141170683 :+1: @vladimir-kotikov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-140060516 @vladimir-kotikov yes, This PR is good to merge to cordova-lib, that's what I meant with "I agree with the change then..." :-) :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-140060717 We need to merge and release fast cli and lib with this bug, nodejs@4 is out and this is a major bug --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-140061087 @vladimir-kotikov yes change to node-code looks good send the PR to see what they want to do, we don't have to wait for a new node-xcode since we switched cordova-lib to use sync method which is preferred in this situation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-139655827 Thanks for explanation @vladimir-kotikov and thanks for your input @pmuellr I agree with the change then after explanation. I still think it should be nice to let the owner of Xcode about a problem of their code with Node4 and open a issue on their repo and suggestion on how to handle. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-139548204 Hi @vladimir-kotikov can you give explanation why the fix is to run Sync? In general I'm not fan on Sync in nodejs, but would like to understand what's the root cause of the problem, and the solution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9297 Parse xcode project syncronously...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/305#issuecomment-139555231 If it's something wrong with npm package xcode, we should open an issue and maybe help with a PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128835312 @jengee you don't have to get tired of update the template every time, you can implement a user land cordova hook after_prepare [1] [2] you can have a simple nodejs script or any other type of script, and parse the index.html after being copy to the platform/**/www/ and and check if csp is missing the value that you want http://localhost:8247; and added there. having an arbitrary localhost port open in csp, present for a common template will raise an eye brow of concerns for people using it in other platforms than blackberry. [1] http://cordova.apache.org/docs/en/edge/guide_appdev_hooks_index.md.html#Hooks%20Guide [2] http://photokandy.tumblr.com/post/47426024187/cordova-cli-simple-hooks-and-merges --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128833712 -1 hum this looks very ugly in the template. I don't like to have this in the default template. people might think that is a security whole. In another platform like android, not picking android then that port will be expose, it will not get intercepted because is not blackberry some options: 1. bb plugin to implement plugin hook, this is a new type of hook that plugins can implement If this is only required for BlackBerry, then the plugin for blackberry can implement a plugin hook to edit the index.html during after_prepare. it can parse the index.html look for the tag and if http://locahost:8472 doesn't exist then added. 2. the cordova.js for blackberry dynamically edits the csp tag in the dom when cordova.js runs before setting up the plugin update the csp meta, I don't know if this is too late to change since index.html is already parsed, if this is not an option then take a look at option 1 above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9453 Updating to iOS@3.9.0 not buildi...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/150#issuecomment-128156902 I just finish testing this and it also works for me cordova platform add ios cordova build cordova platform update ../cordova-ios-CB9453/ cordova build cordova emulate --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-8855 Fix display ios devices with --l...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/137#issuecomment-93073139 :beer: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-57020278 @sgrebnov I tested the pull request and it looks good :+1: . Go ahead and merge it into master. this is great extensibility feature :beers: :tophat: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-56910355 I will review the pull request and if it looks you want me to merge it or you want to do it @sgrebnov ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-wp8 pull request: 3.6.x fixing problems with node_modules ...
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-wp8/pull/55 3.6.x fixing problems with node_modules and bins You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-wp8 3.6.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-wp8/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit d2aeff23032f5d3705cb262d6d7a3e30e6f2b049 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-09-02T13:00:13Z CB-7444 Fixes XHR callback failure when requested file doesn't exists commit 99180e9e1a649b475380da1709bd9b25c09e39b7 Author: Steven Gill stevengil...@gmail.com Date: 2014-09-02T17:19:07Z updated version on master to 3.7.0-dev commit be3e065cc1e8bfc92dfd9151e9bfb034307977f0 Author: Steven Gill stevengil...@gmail.com Date: 2014-09-03T00:12:49Z updated release notes commit b14af9b342a34dd86e9651b32d018c759f48180b Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2014-09-03T01:23:28Z Merge branch 'CB-7444' of https://github.com/MSOpenTech/cordova-wp8 commit 98448f5f98b987c73d4af76fbce5901c383f7007 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-09-03T08:33:31Z Moves node_modules from package root to bin/ folder This is necessary since 'npm pack' removes root node_modules before creating archive. Reviewed by sgrebnov. commit d89b15394aa46e8f187d4d0341dd6782e23775c7 Author: Josh Soref jso...@blackberry.com Date: 2014-09-03T14:33:14Z CB-7455 add bundledDependencies commit 73eb7c9977db97d410abe54a7d561f1f5d7061c4 Author: Carlos Santana csantan...@gmail.com Date: 2014-09-05T21:57:23Z merged master in commit 8695d0cef7afa77cc70bb78db035b5fa546ea797 Author: Carlos Santana csantan...@gmail.com Date: 2014-09-05T22:09:57Z move node_modules up same level as package.json --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-wp8 pull request: fixes for node_modules missing files
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-wp8/pull/56 fixes for node_modules missing files You can merge this pull request into a Git repository by running: $ git pull https://github.com/csantanapr/cordova-wp8 master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-wp8/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit a879f5258b54e5a4e2d30a3f0cf0669515368102 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2014-08-26T23:24:35Z Update 3.6.x branch commit 64a046e8305f8102ad165f16f046f03a372904b2 Author: Steven Gill stevengil...@gmail.com Date: 2014-09-02T17:16:18Z updated package.json commit f5453b938893618ee81058c0ef8c497209511f25 Author: Josh Soref jso...@blackberry.com Date: 2014-09-03T14:33:14Z CB-7455 add bundledDependencies commit f6690f1caab797da60fc018ec3464c465b14ff30 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2014-09-03T22:31:44Z updated package.json version commit 7943002a55e730756c33a7440f2a87e7071b1aab Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2014-09-04T15:59:18Z fix merge issue, package modified commit cf8b82c570e605637a438247509a3db8adc064c8 Author: Steven Gill stevengil...@gmail.com Date: 2014-09-03T00:12:49Z updated release notes (cherry picked from commit be3e065cc1e8bfc92dfd9151e9bfb034307977f0) commit 023ee78bd4c4559d960c6a30f8396b57fc4239e2 Author: Marcel Kinard cmarc...@gmail.com Date: 2014-09-05T18:24:32Z CB-7383 Bump version to 3.6.1 commit 73eb7c9977db97d410abe54a7d561f1f5d7061c4 Author: Carlos Santana csantan...@gmail.com Date: 2014-09-05T21:57:23Z merged master in commit 8695d0cef7afa77cc70bb78db035b5fa546ea797 Author: Carlos Santana csantan...@gmail.com Date: 2014-09-05T22:09:57Z move node_modules up same level as package.json commit daa7af9a3c9ffa73787c76a70c7ae785c429f2ce Author: Carlos Santana csantan...@gmail.com Date: 2014-09-05T22:16:26Z merge fixs for node_modules --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: Adding the sugar platform to cordova
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/83#issuecomment-54324098 Please associate this pull request with a JIRA item. Process can be found here: http://wiki.apache.org/cordova/ContributorWorkflow I think before this code can be merge only when the sugar platform is added to the Apache Git Repo and part of Cordova like the other platforms. Currently Cordova CLI only supports platforms that are part of the Apache Cordova Project. The current expectation for end users using the Cordova CLI is that all source code used by Cordova is blessed by Apache Cordova Project. So that means that https://api.github.com/repos/puneetgkaur/cordova-sugar/tarball/sugar? in needs to be change to something like this: https://git-wip-us.apache.org/repos/asf?p=cordova-sugar.git in platforms.js If you don't want or can't contribute the cordova-sugar platform to Apache Cordova Project, the cli is working on supporting platforms from npm. This could open the door for anyone to have a platform implementation use by cordova cli, but this is something to be discuss in the cordova mailing list on how is going to be handle to be very clear to end users what code is from Apache and what is not. Could you add some unit test cases under cordova-lib/spec-cordova and cordova-lib/spec-plugman ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/55#issuecomment-52305148
@purplecabbage That was one of my points, that context.cmdLine is not
useful as a String.
Why slide() and not just context.cmdLine = process.argv ? just to get a
shallow copy?
Not part of this pull request, but I think no where in inside cordova-lib
the global object process.argv should be assume to be use.
I think is a responsibility of of who ever is calling cordova-lib which in
this case is cordova-cli here:
https://github.com/apache/cordova-cli/blob/master/bin/cordova#L41
addTs('start');
var cli = require('../src/cli');
cli(process.argv);
addTs('end');
then in ../src/cli
should parse and pass down remains/noneparsed of inputArgs down to the
cordova-lib command.
But for now for this pull request I +1 to do context.proc_argv =
process.argv.slice()
@sgrebnov you going to merge this pull request into master soon?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/55#issuecomment-52238594
@sgrebnov here some feedback about context.cmdLine
Any strong reason why this has to be a string instead of an Array like
process.argv ?
https://github.com/MSOpenTech/cordova-lib/blob/CB-6481-hooks/cordova-lib/src/hooks/Context.js#L44
this.cmdLine = process.argv.join(' ');
I want to parse but I don't feel comfortable doing a split(' ') on spaces
because the parameter I'm looking for is a path and path can have spaces
specially in Windows :-)
Can we make context.cmdLine be process.argv and not a String or add a
context.cmdArgv to Context Class.
This is what I have and don't like the idea of converting to Array with
split on spaces
var cmdLine = context.cmdLine.split(' ').filter(function(item){
return item !== '--';
});
var knowOpts = {'wlpath': path};
var shortHands = {'wl' : '--wlpath'};
var parsedCmdLine = nopt(knowOpts, shortHands, cmdLine, 0);
console.log(parsedCmdLine);
if(parsedCmdLine.wlpath){
console.log('Updating Worklight App path to;'+parsedCmdLine.wlpath);
wlappPath = parsedCmdLine.wlpath;
}
Oh one thing weird about using nopt is if dash dash space '-- ' is
present nopt doesn't parse correctly, that's why I'm using a filter
Let me know what you think
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/55#issuecomment-51937234
@sgrebnov I agree now that plugin hooks are located in a unique place like
plugins/mypluginid/src I can have my node module dependencies isolated without
impacting others. and now thinking about user needing to do npm install, I
think the node modules should be a short list so I can include node_modules
directory with the modules already installed with my plugin.
I just tried var nopt = context.requireCordovaModule('nopt');
maybe I did a typo before, when it was not working. so far I'm trying to
keep the hook simple without external dependencies.
on requireCordovaModule I think we should keep it for now, it's a very good
backdoor :-) we can use it during development to come up with what set of
things we want to expose.
For now I need a parser, so adding context.opts.parsers =[{ios:},
{android:}] and array with parser might be a good thing.
about context.cmdLine I see it now, I must be blind :-p
Go ahead and work CordovaProject, let me know if you need help or just
feedback.
I will continue to work on the hook for IBM, and add test cases for in
cordova-lib as I find use cases we want to cover in unit tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51805610 Yes I agree having a class, but still pass a single context to the hook and then the Context object contains a CordovaProject class object return by util.js I think this is the module that know more about the project if I recall corectly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51839887 So how do we move forward with plugin hooks? Do we land what we have here and then open a new JIRA to take care about cordovaProject object? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51840027 I mean land in terms of pushing to master for others to contribute, and when feature is ready document as public api/feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/55#issuecomment-51868008
Here is a gist of a Hook I'm working on for IBM
https://gist.github.com/csantanapr/9fc45c76b4d9a2d5ef85
You can see how I'm using Context opts and requireCordovaModule
2 Items I'm looking how to improve is:
1. I want to be able to use nopt module, but I can't using
requireCordovaModule, because nopt is a dep from cli not cordova-lib
2. Getting a parser for the platform doing
platforms = context.requireCordovaModule('../cordova/platforms')
parser = new platforms[platformId].parser(platformPath);
parser.www_dir()
It feels like using a private API ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
