[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154574485 Looks fine, but maybe we should just remove this check and do this another way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154577826 I think that's what #112 does. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154187370 Can you create a JIRA issue for this, so I know what I'm testing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44106504 --- Diff: src/android/ContentFilesystem.java --- @@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under one */ package org.apache.cordova.file; -import java.io.File; -import java.io.FileNotFoundException; -import java.io.IOException; -import java.io.OutputStream; - -import org.apache.cordova.CordovaResourceApi; -import org.json.JSONArray; -import org.json.JSONException; -import org.json.JSONObject; - import android.content.ContentResolver; import android.content.Context; import android.database.Cursor; import android.net.Uri; +import android.provider.DocumentsContract; import android.provider.MediaStore; import android.provider.OpenableColumns; +import java.io.File; +import java.io.FileNotFoundException; +import java.io.IOException; +import org.apache.cordova.CordovaResourceApi; +import org.json.JSONException; +import org.json.JSONObject; --- End diff -- LULZ! They follow the "Android Studio/Eclipse put it there for me style". Seriously, Cordova, Android and Java imports should be grouped separately, but I'm not completely concerned about the order of the groupings. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-153969952 @charlesverge, do you have an ICLA signed for this? Usually when people write entire new methods, I need an ICLA before I can accept public contributions like this. You can find the info here: http://www.apache.org/licenses/#clas BTW, I like this better than #93. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-docs/pull/409 Update to plugin.md regarding Cordova-Android 5.0.x changes Also changed out-of-date debugging information. Also, the Android Permissions information was completely missing from the plugin documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-docs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/409.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #409 commit adba0fc578685b14afba3131ac2a4badae706e45 Author: Joe Bowser <bows...@apache.org> Date: 2015-10-30T22:50:18Z Desperate update needed to plugin.md regarding Cordova-Android 5.0.x changes, as well as out-of-date debugging, and Android Permissions missing from the plugin documentation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9910 android: Add permissio...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/132#issuecomment-153199173 That permission request looks fine. I really wish we could communicate why we need the damn permission. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fix CB-9752: FileEntry.getDirect...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152660125 Where are you adding the unit test? We currently don't have a way to unit test plugins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/53#issuecomment-152604278 Rebased this code in, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...
Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes for Cordova Android ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/78#issuecomment-152604483 Rebased into master, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes for Cordova Android ...
Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/78 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Adding permissions, giving read ...
Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/71#issuecomment-152604611 Rebased, Closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: API for saving/restoring plugin and ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/236#issuecomment-151959575 Can we get an updated Camera plugin branch with the same branch name so that we can work off the same code? Also, an example app for this may be a good idea as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: API for saving/restoring plugin and ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/236#issuecomment-152024614 I turned on "Don't keep activities" on both a Moto E (Android 4.4.1) and a Samsung Galaxy S6 Edge (Android 5.1) to test this, and I'm not able to actually get the camera to come back. What device was this tested in, and is there any other variables that we're missing here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Remove ops
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151176788 Is there a JIRA issue related to this pull request. We need to be able to see what the problem is before we can talk about this issue. We're not going to accept a pull request where you comment code out, especially since git is version control and we can just delete it anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/128#issuecomment-150695843 Closing pull request. Code has now been rebased and merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-150703173 @cojomojo Won't this still have the problem you found when you filed this? https://issues.apache.org/jira/browse/CB-9506 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....
Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149986619 I agree with @purplecabbage, and I'm still -1 on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-149992603 Does this actually work if you have a signficantly large application loading in the background? Or is this going to cause more white flashes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/223#issuecomment-149619074 I rebased this into the repository, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149027648 -1 to this as well. This wouldn't be consistent on Android, since we're using Intents to launch a camera, and it's possible some devices wouldn't have the library icon on their Camera activity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [Android] fix: support lollipo...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/93#issuecomment-148098334 I've added a smaller fix in the Marshmallow camera to provide a real path, but it doesn't work with remote files. We're not accepting this code in the repository without an ICLA or a CCLA, depending in how big SecuriTeam is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-9741 Updated Android AudioPl...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/72#issuecomment-148106620 This is a good idea, since this removed a required permission from the Audio plugin. Can you ask on the Cordova list if there's a reason this isn't stored in the application's storage directory, since I have no idea why we're not using this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-147443002 Can this wait until after my Cordova-Android 5.0.x pull request is merged in? checkForDuplicateImage requires a permission on Android 6.0+ and I want to make sure that we don't accidentally add something without a permissions check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/226#issuecomment-147458901 Why is all of element-tree and the other npm dependencies checked in? That seems very odd, and makes it harder to figure out what's going on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes for Cordova Android ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/78#issuecomment-147040788 @maheshravva Your question has nothing to do with this pull request. Please ask your question on Stack Overflow, or on a different forum. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....
Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Adding permissions, giving read ...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-file/pull/135 Adding permissions, giving read seems to give write access as well This is so we can write to the shared directory if we need to. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-plugin-file smores Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #135 commit d6615e4e7bf0c947a0976c4c2b493c7d75b94821 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-28T18:06:39Z Adding permissions, giving read seems to give write access as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/128 Marshmallow/Cordova Android 5.0.x compatibility changes This patch also fixes a long-standing issue with files not actually being returned, and instead Content URIs being returned instead. Since the CordovaResourceApi should already be able to handle this, we use it to find the file. However, this doesn't work with files in the cloud that may not be in the device. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-plugin-camera smores Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #128 commit e41e037bc940af9ee1e6294bc0997300b09f224a Author: Joe Bowser <bows...@apache.org> Date: 2015-09-02T22:33:36Z CB-9583: Permissions for Marshmallow commit 8828b0d02b4e3e7b45ff4bc2ffbdae024d90e5c8 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-03T16:08:47Z Fix permission handling commit 4561867309f22f5d016e4c685696cccac5882f5f Author: Joe Bowser <bows...@apache.org> Date: 2015-09-24T22:07:57Z Add engine tag for Cordova-Android 5.0.x commit d950769f2423f464878361a6a6f6c88b0505f49c Author: Joe Bowser <bows...@apache.org> Date: 2015-10-01T23:19:06Z Using the CordovaResourceApi to fine paths of files in the background thread. If the file doesn't exist, return the content URI We also do a refactor to bring this in line. This code got bike-shedded a bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/220#issuecomment-144519379 Going to close and issue a new pull request based on the prior pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....
Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...
Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9616 AndroidM Runtime Permission ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/222#issuecomment-144543404 Check out #223 for the new API updates, it's a lot of the same code, but abstracts the permission checking code out of the individual plugins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Cordova-Android 5.0/Marshmallow Upda...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/223 Cordova-Android 5.0/Marshmallow Updates - Take 2 This has some changes based on the feedback from Pull Request #220 You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android smores Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #223 commit d3044f3524866a0056f0c2632b5fdb68eafdf0f3 Author: Joe Bowser <bows...@apache.org> Date: 2015-07-14T21:31:07Z Commiting code to handle permissions, and the special case of the Geolocation Plugin commit e62696e72e36a62304f39ecf3a8fae5148a36072 Author: Joe Bowser <bows...@apache.org> Date: 2015-07-14T21:58:55Z Finally got it kinda working, Geolocation is not going to work in browser anymore commit e766eaed2826110cca3afd561c2efe9a7f91d804 Author: Joe Bowser <bows...@apache.org> Date: 2015-08-20T20:47:57Z Bump up to API level 23 commit d42c53b0c7fb04f372fa711dd0481c33be5bf0fe Author: Joe Bowser <bows...@apache.org> Date: 2015-08-28T23:50:16Z Refactoring based on feedback from Andrew commit e00cae122c246c7e8aa468460ff25ea7671d8ceb Author: Joe Bowser <bows...@apache.org> Date: 2015-08-31T22:32:53Z Got the PoC working with the Contacts plugin, going to work through all the plugins commit 10c913268555f5f7745e3d70419ee0efaf1afd96 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-18T20:52:12Z Working on getting the Geolocation Plugin to work by default with the default WebView. Crosswalk will need to make similar modifications. commit 9825a0f2f54a401fd240d6571ffc7f0a71254899 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-24T21:55:30Z Manually updating version to 5.0.0-dev for engine tags commit c2a84323f2d9046c6ab84f3eefd4675871af31c3 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-30T19:20:40Z Refactor of the Cordova Plugin/Permissions API --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....
GitHub user infil00p reopened a pull request: https://github.com/apache/cordova-plugin-camera/pull/125 Marshmallow/Cordova Android 5.0.x compatibility changes You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-plugin-camera smores Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/125.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #125 commit e41e037bc940af9ee1e6294bc0997300b09f224a Author: Joe Bowser <bows...@apache.org> Date: 2015-09-02T22:33:36Z CB-9583: Permissions for Marshmallow commit 8828b0d02b4e3e7b45ff4bc2ffbdae024d90e5c8 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-03T16:08:47Z Fix permission handling commit 4561867309f22f5d016e4c685696cccac5882f5f Author: Joe Bowser <bows...@apache.org> Date: 2015-09-24T22:07:57Z Add engine tag for Cordova-Android 5.0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40473698
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView view, ICordovaClientCe
*/
public void onConfigurationChanged(Configuration newConfig) {
}
+
+/**
+ * Called by the Plugin Manager when we need to actually request
permissions
+ *
+ * @return Returns the permission that was stored in the
plugin
+ */
+
+public String[] getPermissionRequest() {
+return permissions;
+}
+
+public boolean hasPermisssion() {
+for(String p : permissions)
+{
+if(PackageManager.PERMISSION_DENIED ==
cordova.getActivity().checkSelfPermission(p))
--- End diff --
Perhaps it should, although I haven't ran into any issues with this so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40475167
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView view, ICordovaClientCe
*/
public void onConfigurationChanged(Configuration newConfig) {
}
+
+/**
+ * Called by the Plugin Manager when we need to actually request
permissions
+ *
+ * @return Returns the permission that was stored in the
plugin
+ */
+
+public String[] getPermissionRequest() {
+return permissions;
+}
+
+public boolean hasPermisssion() {
+for(String p : permissions)
+{
+if(PackageManager.PERMISSION_DENIED ==
cordova.getActivity().checkSelfPermission(p))
--- End diff --
That's probably the case. I'm almost tempted to remove the code from this
method entirely, since this really exists only for a Geolocation plugin. The
geolocation plugin is a special case, and no other plugins work this way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes for Cordova Android ...
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/78#discussion_r40477508
--- Diff: src/android/ContactManager.java ---
@@ -48,13 +54,66 @@ Licensed to the Apache Software Foundation (ASF) under
one
public static final int NOT_SUPPORTED_ERROR = 5;
public static final int PERMISSION_DENIED_ERROR = 20;
private static final int CONTACT_PICKER_RESULT = 1000;
+public static String [] permissions;
+
+
+//Request code for the permissions picker (Pick is async and uses
intents)
+public static final int SEARCH_REQ_CODE = 0;
+public static final int SAVE_REQ_CODE = 1;
+public static final int REMOVE_REQ_CODE = 2;
+
/**
* Constructor.
*/
public ContactManager() {
+permissions = new String[2];
+permissions[0] = Manifest.permission.READ_CONTACTS;
+permissions[1] = Manifest.permission.WRITE_CONTACTS;
+}
+
+public String [] requestPermissions()
+{
+return permissions;
--- End diff --
I don't think this is needed, to be honest. Contacts was the first actual
plugin where I implement the permissions.
But this is very similar to Geolocation, and if there is a call to
requestPermissions(), it is recommended that a plugin actually return the
permissions. We could very easily drop this and only do it for the Geolocation
plugin in hindsight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40476918
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView view, ICordovaClientCe
*/
public void onConfigurationChanged(Configuration newConfig) {
}
+
+/**
+ * Called by the Plugin Manager when we need to actually request
permissions
+ *
+ * @return Returns the permission that was stored in the
plugin
+ */
+
+public String[] getPermissionRequest() {
+return permissions;
+}
+
+public boolean hasPermisssion() {
+for(String p : permissions)
+{
+if(PackageManager.PERMISSION_DENIED ==
cordova.getActivity().checkSelfPermission(p))
--- End diff --
The geolocation plugin ONLY handles the permissions, and since we require
both the coarse location and the fine location to be requested, we send them
both to the activity. There isn't this sort of behaviour in any other plugin
that we currently maintain. However, it's possible that other plugins will
want to send a bunch of permission as a batch, so we facilitate that here,
which is why it's public.
That said, we don't do this for the media plugin. I chose the one
permission at a time approach because it's easier to control a plugin's
callbackContext that way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40478236
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView view, ICordovaClientCe
*/
public void onConfigurationChanged(Configuration newConfig) {
}
+
+/**
+ * Called by the Plugin Manager when we need to actually request
permissions
+ *
+ * @return Returns the permission that was stored in the
plugin
+ */
+
+public String[] getPermissionRequest() {
+return permissions;
+}
+
+public boolean hasPermisssion() {
+for(String p : permissions)
+{
+if(PackageManager.PERMISSION_DENIED ==
cordova.getActivity().checkSelfPermission(p))
--- End diff --
No, we still need the base class methods and helpers defined so that if we
need to, we can pull up any plugin and access these methods without having to
do some reflection to make sure that they still exist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/220 Current Cordova-Android 5.0 changes. These are the changes to Cordova-Android that make it a 5.0 change. This is a very minor major release, since we're literally just adding the ability for plugins to handle permissions, and adding a special hook for Geolocation so that browser geolocation can work. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android smores Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/220.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #220 commit d3044f3524866a0056f0c2632b5fdb68eafdf0f3 Author: Joe Bowser <bows...@apache.org> Date: 2015-07-14T21:31:07Z Commiting code to handle permissions, and the special case of the Geolocation Plugin commit e62696e72e36a62304f39ecf3a8fae5148a36072 Author: Joe Bowser <bows...@apache.org> Date: 2015-07-14T21:58:55Z Finally got it kinda working, Geolocation is not going to work in browser anymore commit e766eaed2826110cca3afd561c2efe9a7f91d804 Author: Joe Bowser <bows...@apache.org> Date: 2015-08-20T20:47:57Z Bump up to API level 23 commit d42c53b0c7fb04f372fa711dd0481c33be5bf0fe Author: Joe Bowser <bows...@apache.org> Date: 2015-08-28T23:50:16Z Refactoring based on feedback from Andrew commit e00cae122c246c7e8aa468460ff25ea7671d8ceb Author: Joe Bowser <bows...@apache.org> Date: 2015-08-31T22:32:53Z Got the PoC working with the Contacts plugin, going to work through all the plugins commit 10c913268555f5f7745e3d70419ee0efaf1afd96 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-18T20:52:12Z Working on getting the Geolocation Plugin to work by default with the default WebView. Crosswalk will need to make similar modifications. commit 9825a0f2f54a401fd240d6571ffc7f0a71254899 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-24T21:55:30Z Manually updating version to 5.0.0-dev for engine tags --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes for Cordova Android ...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/78 Changes for Cordova Android 5.0/Marshmallow Functionality This includes a refactor since many of the methods had to be pulled out of the if/else statement. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-plugin-contacts smores Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/78.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #78 commit 6d3e8fc83b1b1ddfd0d19eaaf4f4db90715b99aa Author: Joe Bowser <bows...@apache.org> Date: 2015-08-31T22:31:17Z Commit of Contacts Plugin with new API commit 18ffafd9d61b4a8a752cc4a7565ad6827b6543a3 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-03T15:43:24Z Fixed error with permission checking. We should exit the method after the permission is denied. commit ab22d9f06906e5a5db9dca1d4df324d0a54f473b Author: Joe Bowser <bows...@apache.org> Date: 2015-09-24T22:13:35Z Adding engine tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/125 Marshmallow/Cordova Android 5.0.x compatibility changes You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-plugin-camera smores Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/125.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #125 commit e41e037bc940af9ee1e6294bc0997300b09f224a Author: Joe Bowser <bows...@apache.org> Date: 2015-09-02T22:33:36Z CB-9583: Permissions for Marshmallow commit 8828b0d02b4e3e7b45ff4bc2ffbdae024d90e5c8 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-03T16:08:47Z Fix permission handling commit 4561867309f22f5d016e4c685696cccac5882f5f Author: Joe Bowser <bows...@apache.org> Date: 2015-09-24T22:07:57Z Add engine tag for Cordova-Android 5.0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-media/pull/71 Cordova-Android 5.0/Marshmallow Updates This one had to be re-written because of our workflow. The PHONE_STATE permission needs to be removed in favour of AudioFocus You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-plugin-media smores Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit 45113294cea104ad99ade7857797073bef44d622 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-24T18:17:39Z Adding engine tag commit 8d2dad550ae1b253e0320dcb06f0e40386152710 Author: Joe Bowser <bows...@apache.org> Date: 2015-09-24T22:46:24Z Adding the media permissions code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Current Cordova-Android 5.0 changes.
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40387288
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -161,4 +164,35 @@ public ActivityResultHolder(int requestCode, int
resultCode, Intent intent) {
this.intent = intent;
}
}
+
+/**
+ * Called by the system when the user grants permissions
+ *
+ * @param requestCode
+ * @param permissions
+ * @param grantResults
+ */
+public void onRequestPermissionResult(int requestCode, String[]
permissions,
+ int[] grantResults) throws
JSONException {
+if(permissionResultCallback != null)
+{
+
permissionResultCallback.onRequestPermissionResult(requestCode, permissions,
grantResults);
+permissionResultCallback = null;
+}
+}
+
+public void requestPermission(CordovaPlugin plugin, int requestCode,
String permission) {
+permissionResultCallback = plugin;
+String[] permissions = new String [1];
+permissions[0] = permission;
+getActivity().requestPermissions(permissions, requestCode);
+}
+
+public void requestPermissions(CordovaPlugin plugin, int requestCode)
+{
+permissionResultCallback = plugin;
+String[] permissions = plugin.getPermissionRequest();
--- End diff --
This is actually in response to Andrew's feedback that we do this. Most of
the plugins don't actually have a set list of permissions, and most only have
one permission. This becomes far more clear when you read the plugins that
have permissions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Creation of the Geolocati...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/52 Creation of the Geolocation Plugin entirely for permissions handling on Marshmallow. This is an ugly hack, but it works. It may make sense for a webview to come packaged with a utility plugin to control it somehow, but this is up to the plugin implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-plugin-geolocation smores Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-geolocation/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit 82a520b8e1bb324eea4c6111888e7568e92efc5b Author: Joe Bowser <bows...@apache.org> Date: 2015-09-18T20:59:00Z Thanks to Marshmallow, we now have a bunch of new code to handle the permissions. This is a major step backwards. commit e9bff32b0ed54b55641227d299b5809f0b8f86ea Author: Joe Bowser <bows...@apache.org> Date: 2015-09-22T23:03:28Z CB-9105: Fixing JS errors in the shim commit 6a912ef4a183c4e53cbe152927776cde10ee35af Author: Joe Bowser <bows...@apache.org> Date: 2015-09-24T22:15:22Z Adding engine tags: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-9562 Fixed incorrect...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/99#issuecomment-135206061 https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;a=commit;h=2b31723708256c08c5209308eb6ccfb03e2ab990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-9562 Fixed incorrect...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/99#issuecomment-135205895 Oops. I forgot to do the comment to close this when I merged it. Can you please do this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-133185529 You removed part of the cropping functionality, we can't accept this pull request as it is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [Android] fix: support lollipo...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/93#issuecomment-119692899 Does this have a corresponding JIRA issue? Also, I'm going to talk about this on the dev list before pulling it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9298: Preferences are now passed ...
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9298: Preferences are now passed ...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/192#issuecomment-119032970 Didn't read the plugin info. Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9298: Preferences are now passed ...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/192 CB-9298: Preferences are now passed to the Cordova Interface I'm doing a pull request instead of just slamming this in because this is actually a pretty important change that will impact people. I can't figure out another way to do this, and I think this will be the least intrusive. Please look it over and let me know. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #192 commit 2d2fc64c5a8d517c2ace068dfdeecca2b2da9935 Author: Joe Bowser bows...@apache.org Date: 2015-07-06T22:52:06Z CB-9298: Preferences are now passed to the Cordova Interface to be accessible to the plugins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-113225945 Agree with @purplecabbage, the iOS whitespace stripping is a blocker. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112232035 Why does this pull request touch iOS? Can you make it so that it's only Android? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-104742963 Just as @jcesarmobile said, there are no modules needed, therefore this should be closed. Because this is a copy of the repository, and not the repository itself, I can't close this one from here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-5059 Add a CookieManager abstract...
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/151#discussion_r23665332
--- Diff: framework/src/org/apache/cordova/ICordovaCookieManager.java ---
@@ -0,0 +1,45 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+package org.apache.cordova;
+
+public interface ICordovaCookieManager {
--- End diff --
The problem with using Android APIs and adopting them as our own is that we
have to support stupid crap that isn't universal. I'd rather add an API later
that we needed than have some extra cruft that we have to test. We should work
on having the bare minimum needed for FileTransfer to work, and if a
third-party API uses this, they can then submit a bug or send a pull request to
add something to the API. Adding to an API is an API change, but it's not a
breaking one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-3679 Move splashscreen logic into...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/134#issuecomment-66163613 Glad that this is taking spinners out. Those spinners have been a personal pet-peeve for years. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-3679 Move splashscreen logic into...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/134#issuecomment-66163749 This looks good, let's merge it in. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: BugFix Android installati...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/24#issuecomment-64906784 I have no idea why Amazon FireOS still has a Geolocation plugin. This is clearly a bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Support for PluginFactory
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/97#issuecomment-48951400 init() has been recently deprecated. I'm not convinced that this is solving a problem that we currently have. I'm not in favour of having Factories just because it's a Java pattern. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46241179 I've accepted the first two and did the last fix at the same time. Can you close this pull request, since I don't remember how Apache wants us to do this. (I'm not kidding, I don't have the ability right in front of me) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-media-capture pull request: CB-5202 fix from lubogo...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/13#issuecomment-40491756 Actually, you're right. Android generally returns 3gp and mp4 files. Returning an AVI container may mess things up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
