[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87750373
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -159,4 +160,16 @@ function generateUapCapabilities(capabilities) {
}
+/**
+ * This is an override of generate_plugin_config_munge method from
cordova-common's PluginInfo class.
+ * @param {[Object]} pluginInfo instance of 'PluginInfo'
+ * @param {[Object]} vars plugin's variables
+ * @param {[Object]} edit_config_changes
+ * @return {[Object]} plugin's munge
+ */
+PlatformMunger.prototype.generate_plugin_config_munge = function
(pluginInfo, vars, edit_config_changes) {
+ var self = this;
--- End diff --
This doesn't seem to be requried - calling a prototype is not a closure so
you can safely use `this`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87752005
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+this.getConfigFiles = function(platform) {
+var changes = parentGetConfigFiles(platform);
+var editChanges = this.getEditConfigs(platform);
+if (editChanges && editChanges.length !== 0) {
+changes.push(editChanges);
+}
+// Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+// Only spend the cycles if there are version-specific plugin
settings
+if (changes.some(function(change) {
+return change.target === 'package.appxmanifest';
--- End diff --
@daserge, i think this condition has been moved to [line
50](https://github.com/apache/cordova-windows/pull/207/files#diff-93a26ea6e269125a5b151c4176a3b42bR50)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87751494
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+this.getConfigFiles = function(platform) {
+var changes = parentGetConfigFiles(platform);
+var editChanges = this.getEditConfigs(platform);
--- End diff --
I don't think that we should do something with `` tags here.
You'd probably need to override parent `getEditConfigs` method in a same way as
`getConfigFiles` possibly sharing the similar logic between them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87752877
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+this.getConfigFiles = function(platform) {
+var changes = parentGetConfigFiles(platform);
+var editChanges = this.getEditConfigs(platform);
+if (editChanges && editChanges.length !== 0) {
+changes.push(editChanges);
+}
+// Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+// Only spend the cycles if there are version-specific plugin
settings
+if (changes.some(function(change) {
+return change.target === 'package.appxmanifest';
+}))
+{
+var oldChanges = changes;
+changes = [];
+
+oldChanges.forEach(function(change, changeIndex) {
--- End diff --
A general comment - can you please divide this function into smaller
pieces, so it'd be easier to review and test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87751321
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
--- End diff --
Rather than saving this into a variable i'd propose to call
`ThisClass.super_.prototype.generate_plugin_config_munge` method directly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87751813
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+this.getConfigFiles = function(platform) {
+var changes = parentGetConfigFiles(platform);
+var editChanges = this.getEditConfigs(platform);
+if (editChanges && editChanges.length !== 0) {
+changes.push(editChanges);
+}
+// Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+// Only spend the cycles if there are version-specific plugin
settings
+if (changes.some(function(change) {
--- End diff --
Nit: could you please invert `if` condition here? Also it might be more
convenient to assign this condition to intermediate variable, something like
`var hasManifestChanges = changes.some(function(change) { return change.target
=== 'package.appxmanifest' })`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87752512
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+this.getConfigFiles = function(platform) {
+var changes = parentGetConfigFiles(platform);
+var editChanges = this.getEditConfigs(platform);
+if (editChanges && editChanges.length !== 0) {
+changes.push(editChanges);
+}
+// Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+// Only spend the cycles if there are version-specific plugin
settings
+if (changes.some(function(change) {
+return change.target === 'package.appxmanifest';
+}))
+{
+var oldChanges = changes;
+changes = [];
+
+oldChanges.forEach(function(change, changeIndex) {
+// Only support semver/device-target demux for
package.appxmanifest
+// Pass through in case something downstream wants to use
it
+if (change.target !== 'package.appxmanifest') {
+changes.push(change);
+return;
+}
+
+var hasVersion = (typeof change.versions !== 'undefined');
+var hasTargets = (typeof change.deviceTarget !==
'undefined');
+
+// No semver/device-target for this config-file, pass it
through
+if (!(hasVersion || hasTargets)) {
+// New windows template separate manifest files for
Windows10, Windows8.1 and WP8.1
+var substs = ['package.phone.appxmanifest',
'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+changes = changes.concat(substs.map(function(subst) {
+return Object.assign({}, change, {target: subst});
+}));
+return changes;
--- End diff --
Nit: you can just `return` here - result of this function is not used
anywhere
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87752779
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,109 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+CommonPluginInfo.apply(this, arguments);
--- End diff --
Pls add a comment, clarifying why you're not using `util.inherit` to build
a children class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #240: CB-12086: Added NSPhotoLibraryUsageDescrip...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/240 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #165: CB-12107: (android) Trigger media s...
Github user beatgrabe commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/165 @infil00p Alrightâ¦keep me updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 @stevengill This is exactly the behavior. The media should pause as soon as `onPause()` is triggered and resumed on `onResume()` Currently this feature is documented as "Quirk" on the iOS platform. https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/#ios-quirks `playAudioWhenScreenIsLocked` I will create a new pull request by tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #196: CB-12140: (android) Content descript...
Github user PhilippeMorier commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 @jcesarmobile, I hope this is ok. Thanks for looking into it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #196: CB-12140: (android) Content descript...
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 Yes, it's ok, I'll merge it later, thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #207: Move windows-specific logic from cordova-common
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/207 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/207?src=pr) is 75.35% (diff: 95.77%) > Merging [#207](https://codecov.io/gh/apache/cordova-windows/pull/207?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will increase coverage by **0.70%** ```diff @@ master #207 diff @@ == Files15 16 +1 Lines 2067 2138+71 Methods 390409+19 Messages 0 0 Branches403410 +7 == + Hits 1543 1611+68 - Misses 524527 +3 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [7ed3c99...6019414](https://codecov.io/gh/apache/cordova-windows/compare/7ed3c997af55d818354f5b5c38453b7d76ec4aa7...601941453fa52b7715674baf0a57a9430c692a20?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 @stevengill in the newer plugin version, 2.4.0 there is a `pauseAllLostFocus()` and `resumeAllGainedFocus()` functionality. Unfortunately that does not works with the `playAudioWhenScreenIsLocked` parameter. I have to look into that to avoid duplications. Can you point me to the documentation that explains those functions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #207: CB-12142: Move windows-specific logic from cordo...
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-windows/pull/207 @vladimir-kotikov @daserge, I've created a Jira issue: https://issues.apache.org/jira/browse/CB-12142, fixed all your comments. Also I think it would be better to add prefix to commit after squashing. Pls, review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request #51: CB-11230 CB-11505 iOS: ...
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/51 CB-11230 CB-11505 iOS: Add compatibility with IPv6 ### Platforms affected iOS ### What does this PR do? This PR adds compatibility with IPv6. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. Remove the logic associated with the local wi-fi because of the narrow use case for this API and the large potential for misuse See also docs https://developer.apple.com/library/content/samplecode/Reachability/Listings/ReadMe_md.html#//apple_ref/doc/uid/DTS40007324-ReadMe_md-DontLinkElementID_11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/matrosov-nikita/cordova-plugin-network-information CB-11230 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit eff1bd27acb5ff8232f7313c1df4d7fd03446a09 Author: Nikita Matrosov Date: 2016-11-14T14:05:21Z CB-11230 CB-11505 iOS: Add compatibility with IPv6 Remove the logic associated with the local wi-fi because of the narrow use case for this API and the large potential for misuse See also docs https://developer.apple.com/library/content/samplecode/Reachability/Listings/ReadMe_md.html#//apple_ref/doc/uid/DTS40007324-ReadMe_md-DontLinkElementID_11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87809027
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+var SUBSTS = ['package.phone.appxmanifest',
'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+var TARGETS = ['windows', 'phone', 'all'];
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+// We needn't use 'util.inherit' in this case because there aren't any
methods on prototype in cordova-common's PluginInfo class
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+var parentGetEditConfigs = this.getEditConfigs;
+
+this.getEditConfigs = function(platform) {
+var editConfigs = parentGetEditConfigs(platform);
+return processChanges(editConfigs);
+};
+
+this.getConfigFiles = function(platform) {
+var configFiles = parentGetConfigFiles(platform);
+return processChanges(configFiles);
+};
+
+function processChanges(changes) {
+var hasManifestChanges = checkManifestChanges(changes);
+
+// Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+// Only spend the cycles if there are version-specific plugin
settings
+if (hasManifestChanges)
+{
+var oldChanges = changes;
+changes = [];
+
+oldChanges.forEach(function(change, changeIndex) {
+// Only support semver/device-target demux for
package.appxmanifest
+// Pass through in case something downstream wants to use
it
+if (change.target !== 'package.appxmanifest') {
+changes.push(change);
+return;
+}
+
+// No semver/device-target for this config-file, pass it
through
+if (!(hasChangeVersion(change) ||
hasChangeTarget(change))) {
+// New windows template separate manifest files for
Windows10, Windows8.1 and WP8.1
+changes =
changes.concat(demuxChangeWithSubsts(change));
+return;
+}
+
+var targetDeviceSet = getDeviceTargetSetForChange(change);
+changes = replaceChangeTarget(targetDeviceSet, change,
changes);
+});
+}
+return changes;
+}
+
+function checkManifestChanges(changes) {
+return changes.some(function(change) {
+return change.target === 'package.appxmanifest';
+});
+}
+function hasChangeVersion(change) {
+return (typeof change.versions !== 'undefined');
+}
+
+function hasChangeTarget(change) {
--- End diff --
Same here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87810296
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+var SUBSTS = ['package.phone.appxmanifest',
'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+var TARGETS = ['windows', 'phone', 'all'];
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+// We needn't use 'util.inherit' in this case because there aren't any
methods on prototype in cordova-common's PluginInfo class
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+var parentGetEditConfigs = this.getEditConfigs;
+
+this.getEditConfigs = function(platform) {
+var editConfigs = parentGetEditConfigs(platform);
+return processChanges(editConfigs);
+};
+
+this.getConfigFiles = function(platform) {
+var configFiles = parentGetConfigFiles(platform);
+return processChanges(configFiles);
+};
+
+function processChanges(changes) {
+var hasManifestChanges = checkManifestChanges(changes);
+
+// Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+// Only spend the cycles if there are version-specific plugin
settings
+if (hasManifestChanges)
+{
+var oldChanges = changes;
+changes = [];
+
+oldChanges.forEach(function(change, changeIndex) {
+// Only support semver/device-target demux for
package.appxmanifest
+// Pass through in case something downstream wants to use
it
+if (change.target !== 'package.appxmanifest') {
+changes.push(change);
+return;
+}
+
+// No semver/device-target for this config-file, pass it
through
+if (!(hasChangeVersion(change) ||
hasChangeTarget(change))) {
+// New windows template separate manifest files for
Windows10, Windows8.1 and WP8.1
+changes =
changes.concat(demuxChangeWithSubsts(change));
+return;
+}
+
+var targetDeviceSet = getDeviceTargetSetForChange(change);
+changes = replaceChangeTarget(targetDeviceSet, change,
changes);
--- End diff --
Consider renaming `replaceChangeTarget` to something more appropriate as it
doesn't really replace anything in the original array
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87809002
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+var SUBSTS = ['package.phone.appxmanifest',
'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+var TARGETS = ['windows', 'phone', 'all'];
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+// We needn't use 'util.inherit' in this case because there aren't any
methods on prototype in cordova-common's PluginInfo class
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+var parentGetEditConfigs = this.getEditConfigs;
+
+this.getEditConfigs = function(platform) {
+var editConfigs = parentGetEditConfigs(platform);
+return processChanges(editConfigs);
+};
+
+this.getConfigFiles = function(platform) {
+var configFiles = parentGetConfigFiles(platform);
+return processChanges(configFiles);
+};
+
+function processChanges(changes) {
+var hasManifestChanges = checkManifestChanges(changes);
+
+// Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+// Only spend the cycles if there are version-specific plugin
settings
+if (hasManifestChanges)
+{
+var oldChanges = changes;
+changes = [];
+
+oldChanges.forEach(function(change, changeIndex) {
+// Only support semver/device-target demux for
package.appxmanifest
+// Pass through in case something downstream wants to use
it
+if (change.target !== 'package.appxmanifest') {
+changes.push(change);
+return;
+}
+
+// No semver/device-target for this config-file, pass it
through
+if (!(hasChangeVersion(change) ||
hasChangeTarget(change))) {
+// New windows template separate manifest files for
Windows10, Windows8.1 and WP8.1
+changes =
changes.concat(demuxChangeWithSubsts(change));
+return;
+}
+
+var targetDeviceSet = getDeviceTargetSetForChange(change);
+changes = replaceChangeTarget(targetDeviceSet, change,
changes);
+});
+}
+return changes;
+}
+
+function checkManifestChanges(changes) {
+return changes.some(function(change) {
+return change.target === 'package.appxmanifest';
+});
+}
+function hasChangeVersion(change) {
--- End diff --
Ditto
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87807973
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+var SUBSTS = ['package.phone.appxmanifest',
'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+var TARGETS = ['windows', 'phone', 'all'];
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+// We needn't use 'util.inherit' in this case because there aren't any
methods on prototype in cordova-common's PluginInfo class
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+var parentGetEditConfigs = this.getEditConfigs;
+
+this.getEditConfigs = function(platform) {
+var editConfigs = parentGetEditConfigs(platform);
+return processChanges(editConfigs);
+};
+
+this.getConfigFiles = function(platform) {
+var configFiles = parentGetConfigFiles(platform);
+return processChanges(configFiles);
+};
+
+function processChanges(changes) {
--- End diff --
I'd suggest to move this out of `PluginInfo` - this way it'd be possible to
use this function in tests (using `rewire`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87810709
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+var SUBSTS = ['package.phone.appxmanifest',
'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+var TARGETS = ['windows', 'phone', 'all'];
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+// We needn't use 'util.inherit' in this case because there aren't any
methods on prototype in cordova-common's PluginInfo class
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+var parentGetEditConfigs = this.getEditConfigs;
+
+this.getEditConfigs = function(platform) {
+var editConfigs = parentGetEditConfigs(platform);
+return processChanges(editConfigs);
+};
+
+this.getConfigFiles = function(platform) {
+var configFiles = parentGetConfigFiles(platform);
+return processChanges(configFiles);
+};
+
+function processChanges(changes) {
+var hasManifestChanges = checkManifestChanges(changes);
+
+// Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+// Only spend the cycles if there are version-specific plugin
settings
+if (hasManifestChanges)
+{
+var oldChanges = changes;
+changes = [];
+
+oldChanges.forEach(function(change, changeIndex) {
+// Only support semver/device-target demux for
package.appxmanifest
+// Pass through in case something downstream wants to use
it
+if (change.target !== 'package.appxmanifest') {
+changes.push(change);
+return;
+}
+
+// No semver/device-target for this config-file, pass it
through
+if (!(hasChangeVersion(change) ||
hasChangeTarget(change))) {
+// New windows template separate manifest files for
Windows10, Windows8.1 and WP8.1
+changes =
changes.concat(demuxChangeWithSubsts(change));
+return;
+}
+
+var targetDeviceSet = getDeviceTargetSetForChange(change);
+changes = replaceChangeTarget(targetDeviceSet, change,
changes);
+});
+}
+return changes;
+}
+
+function checkManifestChanges(changes) {
+return changes.some(function(change) {
+return change.target === 'package.appxmanifest';
+});
+}
+function hasChangeVersion(change) {
+return (typeof change.versions !== 'undefined');
+}
+
+function hasChangeTarget(change) {
+return (typeof change.deviceTarget !== 'undefined');
+}
+
+function demuxChangeWithSubsts(change) {
+return SUBSTS.map(function(subst) {
+ return createChangeWithNewTarget(change, subst);
+});
+}
+
+function createChangeWithNewTarget(change, substTarget) {
+var changeWithNewTarget = {};
+Object.keys(change).forEach(function(changeKey) {
+changeWithNewTarget[changeKey] = change[changeKey];
+});
+changeWithNewTarget.target = substTarget;
+return changeWithNewTarget;
+}
+
+function getDeviceTargetSetForChange(change) {
+var targetDeviceSet = hasChangeTarget(change) ?
change.deviceTarget : 'all';
+if (TARGETS.indexOf(targetDeviceSet) === -1) {
+// target-device couldn't be resolved, fix it up here to a
valid value
+targetDeviceSet = 'all';
+}
+return targetDeviceSet;
+}
+
+// This is a local function that creates the new replacement
representing the
+// mutation. Used
[GitHub] cordova-windows pull request #207: CB-12142: Move windows-specific logic fro...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/207#discussion_r87808967
--- Diff: template/cordova/lib/PluginInfo.js ---
@@ -0,0 +1,150 @@
+var semver = require('semver');
+var CommonPluginInfo = require('cordova-common').PluginInfo;
+
+var MANIFESTS = {
+'windows': {
+'8.1.0': 'package.windows.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'phone': {
+'8.1.0': 'package.phone.appxmanifest',
+'10.0.0': 'package.windows10.appxmanifest'
+},
+'all': {
+'8.1.0': ['package.windows.appxmanifest',
'package.phone.appxmanifest'],
+'10.0.0': 'package.windows10.appxmanifest'
+}
+};
+
+var SUBSTS = ['package.phone.appxmanifest',
'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+var TARGETS = ['windows', 'phone', 'all'];
+/*
+A class for holidng the information currently stored in plugin.xml
+It's inherited from cordova-common's PluginInfo class
+In addition it overrides getConfigFiles method to use windows-specific
logic
+ */
+function PluginInfo(dirname) {
+// We needn't use 'util.inherit' in this case because there aren't any
methods on prototype in cordova-common's PluginInfo class
+CommonPluginInfo.apply(this, arguments);
+var parentGetConfigFiles = this.getConfigFiles;
+var parentGetEditConfigs = this.getEditConfigs;
+
+this.getEditConfigs = function(platform) {
+var editConfigs = parentGetEditConfigs(platform);
+return processChanges(editConfigs);
+};
+
+this.getConfigFiles = function(platform) {
+var configFiles = parentGetConfigFiles(platform);
+return processChanges(configFiles);
+};
+
+function processChanges(changes) {
+var hasManifestChanges = checkManifestChanges(changes);
+
+// Demux 'package.appxmanifest' into relevant platform-specific
appx manifests.
+// Only spend the cycles if there are version-specific plugin
settings
+if (hasManifestChanges)
+{
+var oldChanges = changes;
+changes = [];
+
+oldChanges.forEach(function(change, changeIndex) {
+// Only support semver/device-target demux for
package.appxmanifest
+// Pass through in case something downstream wants to use
it
+if (change.target !== 'package.appxmanifest') {
+changes.push(change);
+return;
+}
+
+// No semver/device-target for this config-file, pass it
through
+if (!(hasChangeVersion(change) ||
hasChangeTarget(change))) {
+// New windows template separate manifest files for
Windows10, Windows8.1 and WP8.1
+changes =
changes.concat(demuxChangeWithSubsts(change));
+return;
+}
+
+var targetDeviceSet = getDeviceTargetSetForChange(change);
+changes = replaceChangeTarget(targetDeviceSet, change,
changes);
+});
+}
+return changes;
+}
+
+function checkManifestChanges(changes) {
--- End diff --
You're calling this only once - is there a real need to wrap this into
function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[CI STATUS REPORT] - 19 actual failures, 3 known failures
http://status.cordova.io # ACTUAL FAILURES 1. Parts of all 19 plugins are failing (seems to be temp file issues: FATAL: Unable to produce a script file java.io.IOException: Failed to create a temp file on E:\jenkins\workspace\cordova-periodic-build) # KNOWN FAILURES (CI issues) 1. cordova-lib (being worked on https://issues.apache.org/jira/browse/CB-12116 , ANDROID_HOME CI issue) 2. cordova-paramedic - AppVeyor - https://issues.apache.org/ jira/browse/CB-12032 3. cordova-plugin-wkwebview - Travis - https://issues.apache.org/ jira/browse/CB-11937
[GitHub] cordova-plugin-network-information issue #51: CB-11230 CB-11505 iOS: Add com...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/51 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-network-information/pull/51/commits/eff1bd27acb5ff8232f7313c1df4d7fd03446a09) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information-pr/19//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #196: CB-12140: (android) Content d...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #198: CB-12145: (android) Allow thi...
GitHub user tmoxon opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/198 CB-12145: (android) Allow third party cookies if parameter set Affects: Android 5+ Creates a new parameter for Android browser setup: acceptThirdPartyCookies. If set to 'yes' then, for Android 5 and above, the cookie manager policy to allow third party cookies will be set. Note that this is not entirely original in concept - a [PR was already raised](https://github.com/apache/cordova-plugin-inappbrowser/pull/165) for this however I've expanded on this to make it optional which seems pragmatic given the role of the in app browser. I have built and tested this against android 4.x and 6.x phones in both modes and confirmed behaviours. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tmoxon/cordova-plugin-inappbrowser master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/198.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #198 commit e3b971673537f111782a22477f8e6fa2fb6ea54d Author: Tim Moxon Date: 2016-11-14T20:02:47Z Added third party cookie policy by acceptThirdPartyCookies parameter. commit 81f35dc8bcbe9ffd94f05468953a4ff6b28bc37e Author: Tim Moxon Date: 2016-11-14T20:11:43Z Fixed spacing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #198: CB-12145: (android) Allow third part...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/198 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/198/commits/81f35dc8bcbe9ffd94f05468953a4ff6b28bc37e) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/96//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request #121: CB-12146: (android) Adds support for...
GitHub user romedius opened a pull request: https://github.com/apache/cordova-plugin-media/pull/121 CB-12146: (android) Adds support for "playAudioWhenScreenIsLocked" already used in iOS ### Platforms affected Android ### What does this PR do? Handle sound pausing and resuming on events like onPause, AudioFocus and if the phone rings. In this patch we handle the playAudioWhenScreenIsLocked option and we must handle three cases independently * on Pause and onResume - pause depening if playAudioWhenScreenIsLocked is set for this audio player * AudioFocus (refactored) * phone ringing (refactored) We have three general states: * No paused sounds * All sounds paused * Sounds only paused if the playAudioWhenScreenIsLocked flag is set to false ### What testing has been done on this change? Manual testing on Nexus 5 ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/romedius/cordova-plugin-media master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 commit 941062bcbe6bc9631fa47a16f73e06e5b9390460 Author: Romedius Weiss Date: 2016-11-14T15:03:11Z added playAudioWhenScreenIsLocked support commit f5e802afc24b07f88b60246106455ed6f8c31301 Author: Romedius Weiss Date: 2016-11-14T20:32:13Z Handle sound pausing and resuming on events like onPause, AudioFocus and if the phone rings. In this patch we handle the playAudioWhenScreenIsLocked option and we must handle three cases independently * on Pause and onResume - pause depening if playAudioWhenScreenIsLocked is set for this audio player * AudioFocus (refactored) * phone ringing (refactored) We have three general states: * No paused sounds * All sounds paused * Sounds only paused if the playAudioWhenScreenIsLocked flag is set to false --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #210: CB-12147: (windows) Fix typo in verbose o...
GitHub user MSLaguana opened a pull request: https://github.com/apache/cordova-windows/pull/210 CB-12147: (windows) Fix typo in verbose output ### Platforms affected Windows ### What does this PR do? Fixes a typo that reduced the verbose output ### What testing has been done on this change? I checked that with the correct event name the line is printed in verbose mode ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. Fixing a typo in an event. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSLaguana/cordova-windows patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #210 commit 0383d33519aef4c1af64c0aab5c5069ad944e73b Author: Jimmy Thomson Date: 2016-11-14T21:22:45Z CB-12147: (windows) Fix typo in verbose output CB-12147: (windows) Fix typo in verbose output --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 @stevengill I've created a new pull request. See: https://github.com/apache/cordova-plugin-media/pull/121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #198: CB-12145: (android) Allow third part...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/198 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/198/commits/76e662583d20ec7d0c673ceedd9ee6af5a21e3ad) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/97//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-ios/pull/277 It seems like the xcconfig settings override the buildFlag flag. When I run this command on a starter cordova-ios 4.3.0 project, the MinimumOSVersion in the App's Info.plist is still iOS 8.0. cordova compile ios --buildFlag="IPHONEOS_DEPLOYMENT_TARGET=9.0" I get a similar result with the `TARGETED_DEVICE_FAMILY` setting. I added the settings back into the pbxproj to handle the case where the user doesn't use one of these config options. Otherwise the default would be a minimum version of iOS 10 and iPhone only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/121/commits/f5e802afc24b07f88b60246106455ed6f8c31301) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/84//PLATFORM=android/artifact/) | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...
Github user cjpearson commented on the issue: https://github.com/apache/cordova-ios/pull/277 Regarding the tests, based on what I'm seeing they should not be failing. The settings are properly added to the project, but they are ignored in the final product. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #125: CB-9445 Improves executeScript callb...
Github user bash88 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/125 failed for me too on iOS10.1 on iPhone 5s --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #210: CB-12147: (windows) Fix typo in verbose output
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/210 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/210?src=pr) is 74.64% (diff: 100%) > Merging [#210](https://codecov.io/gh/apache/cordova-windows/pull/210?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage ```diff @@ master #210 diff @@ == Files15 15 Lines 2067 2067 Methods 390390 Messages 0 0 Branches403403 == Hits 1543 1543 Misses 524524 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [74e84e3...0383d33](https://codecov.io/gh/apache/cordova-windows/compare/74e84e3dc48d6f6a78cc3eb3f170352e3937e0b8...0383d33519aef4c1af64c0aab5c5069ad944e73b?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #277: CB-11243: Fix target-device and deployment-target pr...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/277 @cjpearson we need the unit tests to work first before this can be pulled in. I added those tests (which should have been there in the first place) because this PR didn't come with one but this is Cordova's fault not having one in the first place. I'll try to get that sorted. Regarding xcconfig, yeah you are right xcconfig overrides the command line build settings (XCODE_XCCONFIG_FILE env var to a xcconfig file overrides them all, but that's not relevant here). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 Hey @romedius, Just to confirm, this replaces your other pr. https://github.com/apache/cordova-plugin-media/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #121: CB-12146: (android) Adds support for "playA...
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/121 Yes, I just wanted to wait with closing the other one until there is some activity on this one :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media issue #54: Handles the "playAudioWhenScreenIsLocked" si...
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/54 Replaced by #121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request #54: Handles the "playAudioWhenScreenIsLoc...
Github user romedius closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Nightly build #227 for cordova has succeeded!
Nightly build #227 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/227/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request #210: CB-12147: (windows) Fix typo in verbose o...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
