[jira] [Resolved] (RAT-333) --force option will change the file permissions
[ https://issues.apache.org/jira/browse/RAT-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger resolved RAT-333. --- Resolution: Fixed Merged. > --force option will change the file permissions > --- > > Key: RAT-333 > URL: https://issues.apache.org/jira/browse/RAT-333 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.17 > > > Specifically forcing the update causes the header to be added to the file in > place. > However, with the file is copied back from the *.new file the execute bit > will be disabled even if it was enabled to begin with. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-345) Dependency updates via dependabot performed for release 0.17
[ https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830181#comment-17830181 ] ASF subversion and git services commented on RAT-345: - Commit 3e49be6a20d495c08147178d1cf1ee2bd448c1ca in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=3e49be6a ] RAT-345: Rearrange changelog to leave space for new entries > Dependency updates via dependabot performed for release 0.17 > > > Key: RAT-345 > URL: https://issues.apache.org/jira/browse/RAT-345 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > h1. Updates via dependabot in RAT 0.17 > h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 > * https://github.com/apache/creadur-rat/pull/209 3.25.2 > * https://github.com/apache/creadur-rat/pull/212 3.25.3 > h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 > * https://github.com/apache/creadur-rat/pull/213 > h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 > * https://github.com/apache/creadur-rat/pull/211 > h2. (/) Update junit.version from 5.10.1 to 5.10.2 > * https://github.com/apache/creadur-rat/pull/210 > h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 > * https://github.com/apache/creadur-rat/pull/214 > h2. (/) Update commons-compress from 1.25.0 to 1.26.1 > * https://github.com/apache/creadur-rat/pull/215 1.26.0 > * https://github.com/apache/creadur-rat/pull/220 1.26.1 > h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 > * https://github.com/apache/creadur-rat/pull/219 3.2.0 > h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 > * https://github.com/apache/creadur-rat/pull/218 > h2. (/) Update actions/cache from 4.0.0 to 4.0.2 > * https://github.com/apache/creadur-rat/pull/217 4.0.1 > * https://github.com/apache/creadur-rat/pull/226 4.0.2 > h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 > * https://github.com/apache/creadur-rat/pull/216 4.1.0 > * https://github.com/apache/creadur-rat/pull/222 4.2.0 > h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 > * https://github.com/apache/creadur-rat/pull/225 > h2. (/) Update gitignore-reader from 1.4.0 to 1.5.1 > * https://github.com/apache/creadur-rat/pull/229/ 1.5.1 > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > > h1. TODO before release > * add changelog entries for each above PRs -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-333) --force option will change the file permissions
[ https://issues.apache.org/jira/browse/RAT-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830180#comment-17830180 ] ASF subversion and git services commented on RAT-333: - Commit 2f798859953d1895f2848f4262f799cd4eda327c in creadur-rat's branch refs/heads/master from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=2f798859 ] Merge pull request #223 from Claudenw/RAT-333_file_permission_change_during_force RAT-333: fix --force option will change the file permissions > --force option will change the file permissions > --- > > Key: RAT-333 > URL: https://issues.apache.org/jira/browse/RAT-333 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.17 > > > Specifically forcing the update causes the header to be added to the file in > place. > However, with the file is copied back from the *.new file the execute bit > will be disabled even if it was enabled to begin with. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-333) --force option will change the file permissions
[ https://issues.apache.org/jira/browse/RAT-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830179#comment-17830179 ] ASF subversion and git services commented on RAT-333: - Commit f60ffc69b07b955107f161a2a4f24bbb7aaa3156 in creadur-rat's branch refs/heads/master from Claude Warren [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=f60ffc69 ] Fix for RAT-333 > --force option will change the file permissions > --- > > Key: RAT-333 > URL: https://issues.apache.org/jira/browse/RAT-333 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Major > Fix For: 0.17 > > > Specifically forcing the update causes the header to be added to the file in > place. > However, with the file is copied back from the *.new file the execute bit > will be disabled even if it was enabled to begin with. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-333: fix --force option will change the file permissions [creadur-rat]
ottlinger merged PR #223: URL: https://github.com/apache/creadur-rat/pull/223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-333: fix --force option will change the file permissions [creadur-rat]
ottlinger commented on PR #223: URL: https://github.com/apache/creadur-rat/pull/223#issuecomment-2016621846 Thanks for spotting this error and providing a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (RAT-77) output missing headers inline from plugin
[ https://issues.apache.org/jira/browse/RAT-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-77: - Fix Version/s: 0.17 > output missing headers inline from plugin > - > > Key: RAT-77 > URL: https://issues.apache.org/jira/browse/RAT-77 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.6, 0.7 >Reporter: Michael Rheinheimer >Assignee: Claude Warren >Priority: Major > Fix For: 0.17 > > Attachments: missing-headers.xsl > > > I would very much like to see a list of files in which the headers are > missing in the regular maven output, rather than in the target/rat.txt file. > So, two possible requests here: > 1) output list of offending files in regular maven output, so a trip to > target/rat.txt is not necessary (make this configurable?) > 2) if target/rat.txt is the only output, change the maven output to indicate > where to look. Currently, only the following is output: "[INFO] Too many > unapproved licenses: 1" Perhaps you can append ", please see target/rat.txt" > for those new to RAT plugin. :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-77: output files with missing headers [creadur-rat]
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536663580
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -303,15 +314,13 @@ static Options buildOptions() {
opts.addOption(null, SCAN_HIDDEN_DIRECTORIES, false, "Scan hidden
directories");
OptionGroup addLicenseGroup = new OptionGroup();
-String addLicenseDesc = "Add the default license header to any file
with an unknown license that is not in the exclusion list. "
-+ "By default new files will be created with the license
header, "
-+ "to force the modification of existing files use the --force
option.";
-
// RAT-85/RAT-203: Deprecated! added only for convenience and for
backwards
// compatibility
-Option addLicence = new Option(ADD_OLD, "addLicence", false,
addLicenseDesc);
+Option addLicence = new Option(ADD_OLD, false, "(deprecated) Add the
default license header to any file with an unknown license. Use '-A' or
---addLicense instead.");
Review Comment:
@Claudenw Should we rename the internal variable to ADD_DEPRECATED (instead
of OLD)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RAT-77: output files with missing headers [creadur-rat]
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536701128
##
src/site/apt/index.apt.vm:
##
@@ -111,6 +113,17 @@ java -jar apache-rat-${project.version}.jar --help
+--+
Read more {{{./apache-rat-plugin/index.html} here}}.
+
+ ** Styling output
+
+ Rat allows you to style the output as you see fit. Three stylesheets are
included in the rat package.
+
+plain-rat The default stylesheet.
Review Comment:
Will commit directly to your branch - hope this is okay, @Claudenw
fyi:
https://maven.apache.org/doxia/references/apt-format.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (RAT-345) Dependency updates via dependabot performed for release 0.17
[ https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830176#comment-17830176 ] ASF subversion and git services commented on RAT-345: - Commit db037e7af8dbde482600a92baae70ca8051f1a1c in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=db037e7a ] RAT-362, RAT-345: Update gitignore reader to handle special case when excluded file name matches parts of the project directory > Dependency updates via dependabot performed for release 0.17 > > > Key: RAT-345 > URL: https://issues.apache.org/jira/browse/RAT-345 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > h1. Updates via dependabot in RAT 0.17 > h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 > * https://github.com/apache/creadur-rat/pull/209 3.25.2 > * https://github.com/apache/creadur-rat/pull/212 3.25.3 > h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 > * https://github.com/apache/creadur-rat/pull/213 > h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 > * https://github.com/apache/creadur-rat/pull/211 > h2. (/) Update junit.version from 5.10.1 to 5.10.2 > * https://github.com/apache/creadur-rat/pull/210 > h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 > * https://github.com/apache/creadur-rat/pull/214 > h2. (/) Update commons-compress from 1.25.0 to 1.26.1 > * https://github.com/apache/creadur-rat/pull/215 1.26.0 > * https://github.com/apache/creadur-rat/pull/220 1.26.1 > h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 > * https://github.com/apache/creadur-rat/pull/219 3.2.0 > h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 > * https://github.com/apache/creadur-rat/pull/218 > h2. (/) Update actions/cache from 4.0.0 to 4.0.2 > * https://github.com/apache/creadur-rat/pull/217 4.0.1 > * https://github.com/apache/creadur-rat/pull/226 4.0.2 > h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 > * https://github.com/apache/creadur-rat/pull/216 4.1.0 > * https://github.com/apache/creadur-rat/pull/222 4.2.0 > h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 > * https://github.com/apache/creadur-rat/pull/225 > h2. (/) Update gitignore-reader from 1.4.0 to 1.5.1 > * https://github.com/apache/creadur-rat/pull/229/ 1.5.1 > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > > h1. TODO before release > * add changelog entries for each above PRs -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-362) plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830175#comment-17830175 ] ASF subversion and git services commented on RAT-362: - Commit db037e7af8dbde482600a92baae70ca8051f1a1c in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=db037e7a ] RAT-362, RAT-345: Update gitignore reader to handle special case when excluded file name matches parts of the project directory > plugin: .gitignore not correctly applied - bugfix in underlying > gitignore-reader library > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.17 > > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (RAT-362) plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger resolved RAT-362. --- Resolution: Fixed [~engelen] would you mind giving feedback if the current 0.17-SNAPSHOT fixes the issue you've experienced. In case you do not have RAT available locally it may make sense to at least wait 24h until all SNAPSHOTs (built on ASF infra) provide the most current version of RAT. Thanks > plugin: .gitignore not correctly applied - bugfix in underlying > gitignore-reader library > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.17 > > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-362) plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830171#comment-17830171 ] ASF subversion and git services commented on RAT-362: - Commit eb07d579ac9568f56d019acd25cfbab5e9548146 in creadur-rat's branch refs/heads/master from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=eb07d579 ] Merge pull request #229 from nielsbasjes/RAT-362-GitIgnore RAT-362, RAT-345: Fix gitignore directory handling - switch to relative paths in underlying library > plugin: .gitignore not correctly applied - bugfix in underlying > gitignore-reader library > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.17 > > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-362) plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830169#comment-17830169 ] ASF subversion and git services commented on RAT-362: - Commit 9192925ceb82b4eaccea54db2dbc7fc32dd13869 in creadur-rat's branch refs/heads/master from Niels Basjes [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=9192925c ] [RAT-362] Add test to reproduce the problem > plugin: .gitignore not correctly applied - bugfix in underlying > gitignore-reader library > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.17 > > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-362, RAT-345: Fix gitignore directory handling - switch to relative paths in underlying library [creadur-rat]
ottlinger merged PR #229: URL: https://github.com/apache/creadur-rat/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-345) Dependency updates via dependabot performed for release 0.17
[ https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830172#comment-17830172 ] ASF subversion and git services commented on RAT-345: - Commit eb07d579ac9568f56d019acd25cfbab5e9548146 in creadur-rat's branch refs/heads/master from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=eb07d579 ] Merge pull request #229 from nielsbasjes/RAT-362-GitIgnore RAT-362, RAT-345: Fix gitignore directory handling - switch to relative paths in underlying library > Dependency updates via dependabot performed for release 0.17 > > > Key: RAT-345 > URL: https://issues.apache.org/jira/browse/RAT-345 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > h1. Updates via dependabot in RAT 0.17 > h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 > * https://github.com/apache/creadur-rat/pull/209 3.25.2 > * https://github.com/apache/creadur-rat/pull/212 3.25.3 > h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 > * https://github.com/apache/creadur-rat/pull/213 > h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 > * https://github.com/apache/creadur-rat/pull/211 > h2. (/) Update junit.version from 5.10.1 to 5.10.2 > * https://github.com/apache/creadur-rat/pull/210 > h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 > * https://github.com/apache/creadur-rat/pull/214 > h2. (/) Update commons-compress from 1.25.0 to 1.26.1 > * https://github.com/apache/creadur-rat/pull/215 1.26.0 > * https://github.com/apache/creadur-rat/pull/220 1.26.1 > h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 > * https://github.com/apache/creadur-rat/pull/219 3.2.0 > h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 > * https://github.com/apache/creadur-rat/pull/218 > h2. (/) Update actions/cache from 4.0.0 to 4.0.2 > * https://github.com/apache/creadur-rat/pull/217 4.0.1 > * https://github.com/apache/creadur-rat/pull/226 4.0.2 > h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 > * https://github.com/apache/creadur-rat/pull/216 4.1.0 > * https://github.com/apache/creadur-rat/pull/222 4.2.0 > h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 > * https://github.com/apache/creadur-rat/pull/225 > h2. (/) Update gitignore-reader from 1.4.0 to 1.5.1 > * https://github.com/apache/creadur-rat/pull/229/ 1.5.1 > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > h2. (/) Update > > h1. TODO before release > * add changelog entries for each above PRs -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-362) plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830170#comment-17830170 ] ASF subversion and git services commented on RAT-362: - Commit 17b7a049bff405c4f9935ede307da90074c45f41 in creadur-rat's branch refs/heads/master from Niels Basjes [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=17b7a049 ] [RAT-362] Fix test on Windows > plugin: .gitignore not correctly applied - bugfix in underlying > gitignore-reader library > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.17 > > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-362) plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830168#comment-17830168 ] ASF subversion and git services commented on RAT-362: - Commit 75a977516b6a13a7f733013d86ca487a66f3c700 in creadur-rat's branch refs/heads/master from Niels Basjes [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=75a97751 ] [RAT-362] Fix gitignore directory handling > plugin: .gitignore not correctly applied - bugfix in underlying > gitignore-reader library > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.17 > > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-362, RAT-345: Fix gitignore directory handling - switch to relative paths in underlying library [creadur-rat]
ottlinger commented on PR #229: URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016612423 @Claudenw I do hope it is fine with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-362, RAT-345: Fix gitignore directory handling - switch to relative paths in underlying library [creadur-rat]
nielsbasjes commented on code in PR #229: URL: https://github.com/apache/creadur-rat/pull/229#discussion_r1536664496 ## apache-rat-plugin/src/test/resources/unit/RAT-362-GitIgnore/pom.xml: ## @@ -0,0 +1,43 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + org.apache.rat.test + RAT362 Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-362, RAT-345: Fix gitignore directory handling - switch to relative paths in underlying library [creadur-rat]
nielsbasjes commented on PR #229: URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016552089 I suspect the new test will fail on Windows because I expect to get a drive letter in the middle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-77: output files with missing headers [creadur-rat]
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536663898
##
src/site/apt/index.apt.vm:
##
@@ -111,6 +113,17 @@ java -jar apache-rat-${project.version}.jar --help
+--+
Read more {{{./apache-rat-plugin/index.html} here}}.
+
+ ** Styling output
+
+ Rat allows you to style the output as you see fit. Three stylesheets are
included in the rat package.
+
+plain-rat The default stylesheet.
Review Comment:
fyi: I'll will try to add a link on the the branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RAT-77: output files with missing headers [creadur-rat]
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536663580
##
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##
@@ -303,15 +314,13 @@ static Options buildOptions() {
opts.addOption(null, SCAN_HIDDEN_DIRECTORIES, false, "Scan hidden
directories");
OptionGroup addLicenseGroup = new OptionGroup();
-String addLicenseDesc = "Add the default license header to any file
with an unknown license that is not in the exclusion list. "
-+ "By default new files will be created with the license
header, "
-+ "to force the modification of existing files use the --force
option.";
-
// RAT-85/RAT-203: Deprecated! added only for convenience and for
backwards
// compatibility
-Option addLicence = new Option(ADD_OLD, "addLicence", false,
addLicenseDesc);
+Option addLicence = new Option(ADD_OLD, false, "(deprecated) Add the
default license header to any file with an unknown license. Use '-A' or
---addLicense instead.");
Review Comment:
Should we rename the internal variable to ADD_DEPRECATED (instead of OLD)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] RAT-77: output files with missing headers [creadur-rat]
ottlinger commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536663808
##
apache-rat/src/site/apt/index.apt.vm:
##
@@ -79,12 +79,10 @@ usage: java -jar
apache-rat/target/apache-rat-${project.version}.jar
[options] [DIR|TARBALL]
Available options
- -a,--addLicenceAdd the default license header to any file
-with an unknown license that is not in the
-exclusion list. By default new files will
-be created with the license header, to
-force the modification of existing files
-use the --force option.
+ -a (deprecated) Add the default license
+header to any file with an unknown
+license. Use '-a' or ---addLicense
Review Comment:
Now it is visible for me as well. Thanks for verifying!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (RAT-362) plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-362: -- Summary: plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library (was: plugin: .gitignore not correctly applied) > plugin: .gitignore not correctly applied - bugfix in underlying > gitignore-reader library > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.17 > > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (RAT-362) plugin: .gitignore not correctly applied
[ https://issues.apache.org/jira/browse/RAT-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger reassigned RAT-362: - Assignee: Philipp Ottlinger (was: Jean-Baptiste Onofré) > plugin: .gitignore not correctly applied > > > Key: RAT-362 > URL: https://issues.apache.org/jira/browse/RAT-362 > Project: Apache Rat > Issue Type: Bug >Affects Versions: 0.16.1 >Reporter: Arnout Engelen >Assignee: Philipp Ottlinger >Priority: Minor > Fix For: 0.17 > > > When I have a Maven project checked out in the directory '/foo', and I have a > file called 'foo.md' in the root of that project, ignoring it by putting a > '/foo.md' entry in the .gitignore file does not work. > It is unclear whether this is an issue in the plugin or in de codeowners > gitignore-reader dependency: the plugin is passing relative filenames (i.e. > 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method > don't make it too clear whether that is intended to accept absolute > filenames, relative filename, or both. > In this scenario, it seems to take the relative filename 'foo.md' and remove > the project base directory '/foo' from it, leaving '/.md' (which then of > course does not match the 'foo.md' from the .gitignore). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RAT-345) Dependency updates via dependabot performed for release 0.17
[ https://issues.apache.org/jira/browse/RAT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-345: -- Description: h1. Updates via dependabot in RAT 0.17 h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 * https://github.com/apache/creadur-rat/pull/209 3.25.2 * https://github.com/apache/creadur-rat/pull/212 3.25.3 h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 * https://github.com/apache/creadur-rat/pull/213 h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 * https://github.com/apache/creadur-rat/pull/211 h2. (/) Update junit.version from 5.10.1 to 5.10.2 * https://github.com/apache/creadur-rat/pull/210 h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 * https://github.com/apache/creadur-rat/pull/214 h2. (/) Update commons-compress from 1.25.0 to 1.26.1 * https://github.com/apache/creadur-rat/pull/215 1.26.0 * https://github.com/apache/creadur-rat/pull/220 1.26.1 h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 * https://github.com/apache/creadur-rat/pull/219 3.2.0 h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 * https://github.com/apache/creadur-rat/pull/218 h2. (/) Update actions/cache from 4.0.0 to 4.0.2 * https://github.com/apache/creadur-rat/pull/217 4.0.1 * https://github.com/apache/creadur-rat/pull/226 4.0.2 h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 * https://github.com/apache/creadur-rat/pull/216 4.1.0 * https://github.com/apache/creadur-rat/pull/222 4.2.0 h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 * https://github.com/apache/creadur-rat/pull/225 h2. (/) Update gitignore-reader from 1.4.0 to 1.5.1 * https://github.com/apache/creadur-rat/pull/229/ 1.5.1 h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h1. TODO before release * add changelog entries for each above PRs was: h1. Updates via dependabot in RAT 0.17 h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 * https://github.com/apache/creadur-rat/pull/209 3.25.2 * https://github.com/apache/creadur-rat/pull/212 3.25.3 h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 * https://github.com/apache/creadur-rat/pull/213 h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 * https://github.com/apache/creadur-rat/pull/211 h2. (/) Update junit.version from 5.10.1 to 5.10.2 * https://github.com/apache/creadur-rat/pull/210 h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 * https://github.com/apache/creadur-rat/pull/214 h2. (/) Update commons-compress from 1.25.0 to 1.26.1 * https://github.com/apache/creadur-rat/pull/215 1.26.0 * https://github.com/apache/creadur-rat/pull/220 1.26.1 h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 * https://github.com/apache/creadur-rat/pull/219 3.2.0 h2. (/) Update extra-enforcer-rules from 1.7.0 to 1.8.0 * https://github.com/apache/creadur-rat/pull/218 h2. (/) Update actions/cache from 4.0.0 to 4.0.2 * https://github.com/apache/creadur-rat/pull/217 4.0.1 * https://github.com/apache/creadur-rat/pull/226 4.0.2 h2. (/) Update actions/setup-java from 4.0.0 to 4.2.0 * https://github.com/apache/creadur-rat/pull/216 4.1.0 * https://github.com/apache/creadur-rat/pull/222 4.2.0 h2. (/) Update maven-compiler-plugin from 3.12.1 to 3.13.0 * https://github.com/apache/creadur-rat/pull/225 h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h2. (/) Update h1. TODO before release * add changelog entries for each above PRs > Dependency updates via dependabot performed for release 0.17 > > > Key: RAT-345 > URL: https://issues.apache.org/jira/browse/RAT-345 > Project: Apache Rat > Issue Type: Improvement >Affects Versions: 0.16 >Reporter: Philipp Ottlinger >Assignee: Philipp Ottlinger >Priority: Major > Fix For: 0.17 > > > h1. Updates via dependabot in RAT 0.17 > h2. (/) Update Bump assertj-core from 3.25.1 to 3.25.3 > * https://github.com/apache/creadur-rat/pull/209 3.25.2 > * https://github.com/apache/creadur-rat/pull/212 3.25.3 > h2. (/) Update slf4j-simple from 2.0.11 to 2.0.12 > * https://github.com/apache/creadur-rat/pull/213 > h2. (/) Update junit-platform-runner from 1.10.1 to 1.10.2 > * https://github.com/apache/creadur-rat/pull/211 > h2. (/) Update junit.version from 5.10.1 to 5.10.2 > * https://github.com/apache/creadur-rat/pull/210 > h2. (/) Update gitignore-reader from 1.3.1 to 1.4.0 > * https://github.com/apache/creadur-rat/pull/214 > h2. (/) Update commons-compress from 1.25.0 to 1.26.1 > * https://github.com/apache/creadur-rat/pull/215 1.26.0 > * https://github.com/apache/creadur-rat/pull/220 1.26.1 > h2. (/) Update maven-remote-resources-plugin from 3.1.0 to 3.2.0 > * https://github.com/apache/creadur-rat/pull/219 3.2.0 > h2. (/) Update extra-enforcer-rules from
Re: [PR] RAT-362: Fix gitignore directory handling - switch to relative paths in underlying library [creadur-rat]
ottlinger commented on code in PR #229: URL: https://github.com/apache/creadur-rat/pull/229#discussion_r1536662289 ## apache-rat-plugin/src/test/resources/unit/RAT-362-GitIgnore/pom.xml: ## @@ -0,0 +1,43 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + org.apache.rat.test + RAT362 Review Comment: Please change to RAT-362 for better consistency with directory and resource names. Thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-362: Fix gitignore directory handling - switch to relative paths in underlying library [creadur-rat]
ottlinger commented on PR #229: URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016547369 @nielsbasjes pls rebase your branch in order for all build checks to run again (as RAT-367 is merged now). Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (RAT-367) Older junit3 tests are not run during the build after migrating to junit5
[ https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger resolved RAT-367. --- Resolution: Fixed Thanks > Older junit3 tests are not run during the build after migrating to junit5 > - > > Key: RAT-367 > URL: https://issues.apache.org/jira/browse/RAT-367 > Project: Apache Rat > Issue Type: Bug > Components: build >Affects Versions: 0.16.1 >Reporter: Niels Basjes >Priority: Major > Fix For: 0.17 > > > There are some tests that use the old Junit 3 APIs and these are not run by > default under Junit 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-367) Older junit3 tests are not run during the build after migrating to junit5
[ https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830111#comment-17830111 ] ASF subversion and git services commented on RAT-367: - Commit 3fa24824aac30fd86f283cff317456e1aa6ecf5e in creadur-rat's branch refs/heads/master from Philipp Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=3fa24824 ] RAT-367: Fix older junit3 tests are not run during the build after migrating to junit5 > Older junit3 tests are not run during the build after migrating to junit5 > - > > Key: RAT-367 > URL: https://issues.apache.org/jira/browse/RAT-367 > Project: Apache Rat > Issue Type: Bug >Reporter: Niels Basjes >Priority: Major > > There are some tests that use the old Junit 3 APIs and these are not run by > default under Junit 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (RAT-367) Older junit3 tests are not run during the build after migrating to junit5
[ https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-367: -- Component/s: build Fix Version/s: 0.17 Affects Version/s: 0.16.1 > Older junit3 tests are not run during the build after migrating to junit5 > - > > Key: RAT-367 > URL: https://issues.apache.org/jira/browse/RAT-367 > Project: Apache Rat > Issue Type: Bug > Components: build >Affects Versions: 0.16.1 >Reporter: Niels Basjes >Priority: Major > Fix For: 0.17 > > > There are some tests that use the old Junit 3 APIs and these are not run by > default under Junit 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-367) Older junit3 tests are not run during the build after migrating to junit5
[ https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830109#comment-17830109 ] ASF subversion and git services commented on RAT-367: - Commit 26b7516ba66d3fa4f48637ed31ddb82b8a71d9ab in creadur-rat's branch refs/heads/master from P. Ottlinger [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=26b7516b ] Merge pull request #230 from nielsbasjes/RAT-367-RunOldTests RAT-367: Enable running old junit tests during the build with junit5 > Older junit3 tests are not run during the build after migrating to junit5 > - > > Key: RAT-367 > URL: https://issues.apache.org/jira/browse/RAT-367 > Project: Apache Rat > Issue Type: Bug >Reporter: Niels Basjes >Priority: Major > > There are some tests that use the old Junit 3 APIs and these are not run by > default under Junit 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-367) Older junit3 tests are not run during the build after migrating to junit5
[ https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830108#comment-17830108 ] ASF subversion and git services commented on RAT-367: - Commit 2ac89a21296954dd0cf02343ce87caf9157201a4 in creadur-rat's branch refs/heads/master from Niels Basjes [ https://gitbox.apache.org/repos/asf?p=creadur-rat.git;h=2ac89a21 ] [RAT-367] Also run the old tests during the build. > Older junit3 tests are not run during the build after migrating to junit5 > - > > Key: RAT-367 > URL: https://issues.apache.org/jira/browse/RAT-367 > Project: Apache Rat > Issue Type: Bug >Reporter: Niels Basjes >Priority: Major > > There are some tests that use the old Junit 3 APIs and these are not run by > default under Junit 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-367: Enable running old junit tests during the build with junit5 [creadur-rat]
ottlinger merged PR #230: URL: https://github.com/apache/creadur-rat/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] RAT-367: Enable running old junit tests during the build with junit5 [creadur-rat]
ottlinger commented on PR #230: URL: https://github.com/apache/creadur-rat/pull/230#issuecomment-2016545480 Thanks for the catch, I'll add a changelog entry accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (RAT-367) Older junit3 tests are not run during the build after migrating to junit5
[ https://issues.apache.org/jira/browse/RAT-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated RAT-367: -- Description: There are some tests that use the old Junit 3 APIs and these are not run by default under Junit 5 was:There are some tests that use the old Junit 3 APIs and these are not run by default under Junit 5 Summary: Older junit3 tests are not run during the build after migrating to junit5 (was: Not all tests are run during the build) > Older junit3 tests are not run during the build after migrating to junit5 > - > > Key: RAT-367 > URL: https://issues.apache.org/jira/browse/RAT-367 > Project: Apache Rat > Issue Type: Bug >Reporter: Niels Basjes >Priority: Major > > There are some tests that use the old Junit 3 APIs and these are not run by > default under Junit 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (RAT-336) Use assertj in RAT tests
[ https://issues.apache.org/jira/browse/RAT-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830107#comment-17830107 ] Philipp Ottlinger commented on RAT-336: --- Maybe we could get rid of jUnit3 tests as well while migrating to AssertJ? > Use assertj in RAT tests > > > Key: RAT-336 > URL: https://issues.apache.org/jira/browse/RAT-336 > Project: Apache Rat > Issue Type: Improvement > Components: build >Affects Versions: 0.15 >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 0.17 > > > As discussed during RAT-322 fix, I will refactore all tests to use assertj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [RAT-362] Fix gitignore directory handling [creadur-rat]
nielsbasjes commented on PR #229: URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016494164 @Claudenw I think the testing issue https://github.com/apache/creadur-rat/pull/230 should be fixed first because otherwise there is no way to show this actually works on all JDK versions on all platforms (i.e. also Windows). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [RAT-362] Fix gitignore directory handling [creadur-rat]
nielsbasjes commented on PR #229: URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016492427 Also a merge request to fix this testing issue https://github.com/apache/creadur-rat/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [RAT-362] Fix gitignore directory handling [creadur-rat]
nielsbasjes commented on PR #229: URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016491170 For the tests I created this https://issues.apache.org/jira/browse/RAT-367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (RAT-367) Not all tests are run during the build
Niels Basjes created RAT-367: Summary: Not all tests are run during the build Key: RAT-367 URL: https://issues.apache.org/jira/browse/RAT-367 Project: Apache Rat Issue Type: Bug Reporter: Niels Basjes There are some tests that use the old Junit 3 APIs and these are not run by default under Junit 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [RAT-362] Fix gitignore directory handling [creadur-rat]
nielsbasjes commented on PR #229: URL: https://github.com/apache/creadur-rat/pull/229#issuecomment-2016485876 > @nielsbasjes do you have a test that shows failure before this fix is applied? Yes. In this case it is a problem in the upstream library (which I wrote) where I have included extensive tests to prove it now works correctly: https://github.com/nielsbasjes/codeowners/blob/main/gitignore-reader/src/test/java/nl/basjes/gitignore/TestBugreports.java#L32-L68 > Please include such a test in your pull request. Done. Note that on my machine none of the tests in RatCheckMojoTest run automatically during the build. I can run them manually though. Since this is using a very old Junit API, I'm unsure on how to fix this (separate) issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (RAT-366) Switch to Reading preparing header text and processing in one call.
[ https://issues.apache.org/jira/browse/RAT-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830061#comment-17830061 ] Claude Warren commented on RAT-366: --- Fix in [pull 228|https://github.com/apache/creadur-rat/pull/228] > Switch to Reading preparing header text and processing in one call. > --- > > Key: RAT-366 > URL: https://issues.apache.org/jira/browse/RAT-366 > Project: Apache Rat > Issue Type: Improvement > Components: core engine >Affects Versions: 0.16.1 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > Fix For: 0.17 > > > Currently the system spends a fair chunk of time processing input line by > line. The code path is much simplified if instead we read the maximum number > of lines that we would process under the old code and process that all at > once. > This will also improve memory footprint since the full text matcher will not > have to keep a copy of all the text it has seen so far, but rather just > process the block of text that is passed in. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] RAT-77: output files with missing headers [creadur-rat]
Claudenw commented on code in PR #224:
URL: https://github.com/apache/creadur-rat/pull/224#discussion_r1536599628
##
apache-rat/src/site/apt/index.apt.vm:
##
@@ -79,12 +79,10 @@ usage: java -jar
apache-rat/target/apache-rat-${project.version}.jar
[options] [DIR|TARBALL]
Available options
- -a,--addLicenceAdd the default license header to any file
-with an unknown license that is not in the
-exclusion list. By default new files will
-be created with the license header, to
-force the modification of existing files
-use the --force option.
+ -a (deprecated) Add the default license
+header to any file with an unknown
+license. Use '-a' or ---addLicense
Review Comment:
There must have been a github issue. I checked this AM and I had pushed and
currently github does show the changes in this pull request. Please check
again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
