[jira] [Commented] (DELTASPIKE-1402) ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during runtime
[
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123867#comment-17123867
]
Mark Struberg commented on DELTASPIKE-1402:
---
[~romain.manni-bucau] For disabling reload you can set {{deltaspike_reload=-1}}
inside the property file. On almost every box the file metadata is heavily
cached. So checking the lastModified is very cheap anyway. I've done quite a
few perf tests on Linux, OSX and Win. All look fine.
> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during
> runtime
>
>
> Key: DELTASPIKE-1402
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
> Project: DeltaSpike
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Configuration
>Affects Versions: 1.9.3
>Reporter: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
> does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes
> in this file.
> The same is true for other
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the
> last-changed timestamp of the file and only checked every minute or so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (DELTASPIKE-1402) ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during runtime
[
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123526#comment-17123526
]
ASF subversion and git services commented on DELTASPIKE-1402:
-
Commit 5ffcaf3b8243586e9a479f7a7e554a34c7669844 in deltaspike's branch
refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=5ffcaf3 ]
DELTASPIKE-1402 wait a bit longer
sadly a few file systems have a bigger lastModified granularity.
So we better wait a bit longer.
> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during
> runtime
>
>
> Key: DELTASPIKE-1402
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
> Project: DeltaSpike
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Configuration
>Affects Versions: 1.9.3
>Reporter: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
> does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes
> in this file.
> The same is true for other
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the
> last-changed timestamp of the file and only checked every minute or so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (DELTASPIKE-1402) ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during runtime
[
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123428#comment-17123428
]
ASF subversion and git services commented on DELTASPIKE-1402:
-
Commit 118b9d3e63970fb94038d6f9379f9c261b4e609b in deltaspike's branch
refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=118b9d3 ]
DELTASPIKE-1402 add a way to disable dynamic reloading
by using a deltaspike_reload smaller 0 you can disable dynamic reloading.
> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during
> runtime
>
>
> Key: DELTASPIKE-1402
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
> Project: DeltaSpike
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Configuration
>Affects Versions: 1.9.3
>Reporter: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
> does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes
> in this file.
> The same is true for other
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the
> last-changed timestamp of the file and only checked every minute or so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (DELTASPIKE-1402) ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during runtime
[
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17122508#comment-17122508
]
ASF subversion and git services commented on DELTASPIKE-1402:
-
Commit 33c3c2483907c2b0974c0ac3288e6b004c9e438b in deltaspike's branch
refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=deltaspike.git;h=33c3c24 ]
DELTASPIKE-1402 dynamic reload of PropertyFileConfigSource
DeltaSpike can now dynamically reload configuration of property files in a
file:// location.
The time after which we look for file modification (via lastModified time stamp
of the file)
can be configured with a 'deltaspike_reload=60' property in seconds.
In this case 60 seconds.
If this property is not set we check for changes every 300 seconds or 5 Minutes.
> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during
> runtime
>
>
> Key: DELTASPIKE-1402
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
> Project: DeltaSpike
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Configuration
>Affects Versions: 1.9.3
>Reporter: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
> does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes
> in this file.
> The same is true for other
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the
> last-changed timestamp of the file and only checked every minute or so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (DELTASPIKE-1402) ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during runtime
[
https://issues.apache.org/jira/browse/DELTASPIKE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120916#comment-17120916
]
Romain Manni-Bucau commented on DELTASPIKE-1402:
I guess we need to refine the target:
# hot reloading
# bootstrap config (what if the config is mapped to a runtime model, it can be
reloaded, it will never be refreshed)
# immutable deployments (some deployments will not want to reload cause it
means potentially breaking a valid deployment)
# performances: most servlet container have a dev mode with reloading at read
and a prod mode where it is disabled to avoid any IO which are cheap if done
alone but can be expensive if the disk is used with an IO expensive app
Therefore I suspect we can need a toggle to enable a refresh at read or a
cached mode (read once). Using an enum it can enable us to add later a
background refresh if needed so I would add something like
{code:java}
deltaspike.configsource.userhome.reloadStrategy=[SYNCHRONOUS_AT_READ|NONE]
{code}
Hope it makes sense.
> ~/.deltaspike/apache-deltaspike.properties doesn't pickup changes during
> runtime
>
>
> Key: DELTASPIKE-1402
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1402
> Project: DeltaSpike
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Configuration
>Affects Versions: 1.9.3
>Reporter: Mark Struberg
>Priority: Major
> Fix For: 1.9.4
>
>
> Right now the {{ConfigSource}} registered via
> {{org.apache.deltaspike.core.impl.config.DefaultConfigSourceProvider#addUserHomeConfigSource}}
> does not reload dynamically if the file got changed.
> That means DeltaSpike Config right now doesn't automatically pick up changes
> in this file.
> The same is true for other
> {{org.apache.deltaspike.core.impl.config.PropertyFileConfigSource}} but most
> of them are in a jar anyway, so it doesn't make any difference.
> Of course for PropertyFileConfigSources representing native files on the disk
> it might also be nice to detect dynamic changes.
> It might be perfectly fine to have changes only picked up based on the
> last-changed timestamp of the file and only checked every minute or so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
