[dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section

2016-06-22 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Thursday, June 16, 2016 10:05 AM
> To: dev at dpdk.org
> Cc: Dumitrescu, Cristian 
> Subject: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section
> 
> Replace APP_PARAM_ADD_LINK_FOR_TXQ with
> APP_PARAM_ADD_LINK_FOR_TM macro in TM (Traffic Manager) port
> section parsing function. This macro adds nic ports entry specified in TM port
> section of the application configuration file to the application parameters
> structure.
> 
> Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration parser")
> 
> Signed-off-by: Jasvinder Singh 
> Acked-by: Cristian Dumitrescu 
> ---
>  examples/ip_pipeline/config_parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ip_pipeline/config_parse.c
> b/examples/ip_pipeline/config_parse.c
> index 504018e..5e70d78 100644

Self-NACK ;  fix applied by another patch.



[dpdk-dev] [PATCH v4] ip_pipeline: configuration file parser cleanup

2016-06-08 Thread Singh, Jasvinder


> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, June 8, 2016 3:48 PM
> To: Singh, Jasvinder 
> Cc: dev at dpdk.org; Dumitrescu, Cristian 
> Subject: Re: [dpdk-dev] [PATCH v4] ip_pipeline: configuration file parser
> cleanup
> 
> clang compilation fails:
>   examples/ip_pipeline/config_parse.c:852:11: error:
>   implicit conversion from enumeration type 'enum
> app_pktq_out_type'
>   to different enumeration type 'enum app_pktq_in_type'

Thanks, Thomas. V5 has been sent fixing this error.


[dpdk-dev] dpdk pipeline multi app

2016-05-31 Thread Singh, Jasvinder
Hi Ramin,


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ramin Najjarbashi
> Sent: Tuesday, May 31, 2016 8:19 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] dpdk pipeline multi app
> 
> hi
> how we can arrive to this architecture?
> Every client is different like IPS, Firewall, DPI and else.
> 
> 
> http://stackoverflow.com/questions/37539194/dpdk-pipeline-multi-app

Have a look at example/ip_pipeline sample app. It contains various packet 
processing modules such as flow-classification firewall, flow-actions, routing, 
etc., developed using similar template.

Jasvinder


[dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure

2016-04-05 Thread Singh, Jasvinder
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang
> Sent: Thursday, March 31, 2016 2:29 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for
> rte_port_source_params structure
> 
> Several new fields will be added to structure rte_port_source_params for
> source port enhancement with pcap file reading support.
> 
> Signed-off-by: Fan Zhang 
> Acked-by: Cristian Dumitrescu 

Acked-by: Jasvinder Singh 


[dpdk-dev] [PATCH v4] librte_pipeline: add support for packet redirection at action handlers

2016-03-07 Thread Singh, Jasvinder
Hi Thomas,

> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, March 7, 2016 11:02 AM
> To: Singh, Jasvinder 
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] librte_pipeline: add support for packet
> redirection at action handlers
> 
> Hi Jasvinder,
> 
> Don't hesitate to leave some blank lines in your message, it's free :)

I will avail free service ;) thanks

> 2016-03-03 11:01, Jasvinder Singh:
> > Currently, there is no mechanism that allows the pipeline ports
> > (in/out) and table action handlers to override the default forwarding
> > decision (as previously configured per input port or in the table
> > entry). Therefore, new pipeline API functions have been added which
> > allows action handlers to hijack packets and remove them from the
> > pipeline processing, and then either drop them or send them out of the
> > pipeline on any output port. The port
> > (in/out) and table action handler prototypes have been changed for
> > making use of these new API functions. This feature will be helpful to
> > implement functions such as exception handling (e.g. TTL =0), load
> balancing etc.
> > Changes are made to the ports and table action handlers defined in
> > app/test_pipeline and ip_pipeline sample application.
> 
> I have the feeling it would be easier to parse if the structure changes were
> done in a separate commit, then introduce the new function.

I will send v5 as you advice.

> You have forgotten to remove the deprecation notice.

I think, I have updated the deprecation notice for the pipeline input port, 
output port
and table action handlers prototype. Do you mean anything else than this?


Thanks,
Jasvinder



[dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for packet redirection at action handlers

2016-03-03 Thread Singh, Jasvinder


> -Original Message-
> From: Panu Matilainen [mailto:pmatilai at redhat.com]
> Sent: Thursday, March 3, 2016 9:35 AM
> To: Singh, Jasvinder ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for
> packet redirection at action handlers
> 
> On 03/02/2016 10:41 PM, Jasvinder Singh wrote:
> > Currently, there is no mechanism that allows the pipeline ports
> > (in/out) and table action handlers to override the default forwarding
> > decision (as previously configured per input port or in the table
> > entry). Therefore, new pipeline API functions have been added which
> > allows action handlers to hijack packets and remove them from the
> > pipeline processing, and then either drop them or send them out of the
> > pipeline on any output port. The port
> > (in/out) and table action handler prototypes have been changed for
> > making use of these new API functions. This feature will be helpful to
> > implement functions such as exception handling (e.g. TTL =0), load
> balancing etc.
> >
> > Signed-off-by: Jasvinder Singh 
> > Acked-by: Cristian Dumitrescu 
> > ---
> > v3
> > * improved comments in "rte_pipeline.h"
> >
> > v2
> > * rebased on master
> >
> >   doc/guides/rel_notes/deprecation.rst |   5 -
> >   doc/guides/rel_notes/release_16_04.rst   |   6 +-
> >   lib/librte_pipeline/Makefile |   4 +-
> >   lib/librte_pipeline/rte_pipeline.c   | 461 
> > ++-
> >   lib/librte_pipeline/rte_pipeline.h   | 174 ++
> >   lib/librte_pipeline/rte_pipeline_version.map |   8 +
> >   6 files changed, 362 insertions(+), 296 deletions(-)
> >
> [...]
> 
> This causes a build failure:
> 
> == Build app/test-pipeline
>CC pipeline_stub.o
> /srv/work/repos/dpdk/app/test-pipeline/pipeline_stub.c: In function
> ?app_main_loop_worker_pipeline_stub?:
> /srv/work/repos/dpdk/app/test-pipeline/pipeline_stub.c:97:4: error:
> unknown field ?f_action_bulk? specified in initializer
>  .f_action_bulk = NULL,
>  ^
> /srv/work/repos/dpdk/mk/internal/rte.compile-pre.mk:126: recipe for
> target 'pipeline_stub.o' failed
> 
> Each individual commit needs to be buildable. Since its simply an
> incompatible API change, I guess there's no other way than updating the test
> app(s) in the same commit as the library. The other alternative would be
> temporarily disabling the test app(s) in the previous commit but that doesn't
> seem any better to me.
> 
I would prefer first suggestion to merge both commits (library and app) into 
one (library + app) so that all the build dependency could be resolved.

Thanks, 
Jasvinder


[dpdk-dev] Traffic scheduling in DPDK

2016-01-07 Thread Singh, Jasvinder
Hi Uday,


> -Original Message-
> From: ravulakollu.kumar at wipro.com [mailto:ravulakollu.kumar at wipro.com]
> Sent: Thursday, January 7, 2016 6:29 AM
> To: Singh, Jasvinder
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] Traffic scheduling in DPDK
> 
> Hi Jasvinder,
> 
> Below is my system configuration
> 
> Hugepages:
> --
> [root at qos_sched]# grep -i huge /proc/meminfo
> AnonHugePages:  4096 kB
> HugePages_Total:8000
> HugePages_Free: 7488
> HugePages_Rsvd:0
> HugePages_Surp:0
> Hugepagesize:   2048 kB
> 
> NUMA Nodes:
> --
> NUMA node0 CPU(s): 0,2,4,6,8,10
> NUMA node1 CPU(s): 1,3,5,7,9,11
> 
> Ports :
> 
> Two Ethernet 10G 2P X520 Adapter
> 
> Note : These two PCI devices are connected to NUMA socket 0
> 
> Below is the QoS scheduler command I am running .
> 
> ./build/qos_sched -c 0x14 -n 1 --socket-mem 1024,0 -- --pfc "0,1,2,4" --cfg
> ./profile.cfg
> 
> After running getting the below error.
> 
> APP: EAL core mask not configured properly, must be 16 instead of 14
> 
> So, changed the command line as below
> 
> ./build/qos_sched -c 0x16 -n 1 --socket-mem 1024,0 -- --pfc "0,1,2,4" --cfg
> ./profile.cfg
> 
> After running getting a different error as shown below.
> 
> PANIC in rte_eth_dev_data_alloc():
> Cannot allocate memzone for ethernet port data
> 10: [./build/qos_sched() [0x4039c9]]
> 9: [/lib64/libc.so.6(__libc_start_main+0xf5) [0x7fba5e95faf5]]
> 8: [./build/qos_sched(main+0x9) [0x403949]]
> 7: [./build/qos_sched(app_parse_args+0x2b) [0x4040eb]]
> 6: [/root/DPDK/x86_64-ivshmem-linuxapp-
> gcc/lib/libintel_dpdk.so(rte_eal_init+0xac2) [0x7fba5f8ba452]]
> 5: [/root/DPDK/x86_64-ivshmem-linuxapp-
> gcc/lib/libintel_dpdk.so(rte_eal_pci_probe+0x11d) [0x7fba5f8e767d]]
> 4: [/root /DPDK/x86_64-ivshmem-linuxapp-
> gcc/lib/libintel_dpdk.so(+0x11cafc) [0x7fba5f982afc]]
> 3: [/root /DPDK/x86_64-ivshmem-linuxapp-
> gcc/lib/libintel_dpdk.so(+0x11caa4) [0x7fba5f982aa4]]
> 2: [/root/DPDK/x86_64-ivshmem-linuxapp-
> gcc/lib/libintel_dpdk.so(__rte_panic+0xcb) [0x7fba5f894438]]
> 1: [/root/DPDK/x86_64-ivshmem-linuxapp-
> gcc/lib/libintel_dpdk.so(rte_dump_stack+0x18) [0x7fba5f8f2128]] Aborted
> 
> Could you help me in running this app as per my system configuration.


I guess you are reserving less memory using --socket-mem. In qos_sched, each 
mbuf has (1528 + sizeof(struct rte_mbuf) + RTE_PKTMBUF_HEADROOM)  bytes and we 
have mempool size equal to 2*1024*1024 mbufs. Altogether it becomes approx. 4 
GB. So, try using default memory allocated using hugepages or in case, if you 
want to use less than default ,   may use --socket-mem  5120,0   

Please refer source code as well to get an idea on memory requirements for this 
application.

> Thanks ,
> Uday
> 
> Bound two 10G
> -Original Message-
> From: Ravulakollu Udaya Kumar (WT01 - Product Engineering Service)
> Sent: Wednesday, January 06, 2016 6:10 PM
> To: 'Singh, Jasvinder'
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] Traffic scheduling in DPDK
> 
> Thanks Jasvinder,
> 
> Does this application works on systems with multiple NUMA Nodes ?
> 
> Thanks,
> Uday
> 
> -Original Message-
> From: Singh, Jasvinder [mailto:jasvinder.singh at intel.com]
> Sent: Tuesday, January 05, 2016 3:40 PM
> To: Ravulakollu Udaya Kumar (WT01 - Product Engineering Service)
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] Traffic scheduling in DPDK
> 
> Hi Uday,
> 
> >
> > Thanks Jasvinder , I am running the below command
> >
> > ./build/qos_sched -c 0xe -n 1  -- --pfc "0,1,3,2" --cfg ./profile.cfg
> >
> > Bound two 1G physical ports to DPDK , and started running the above
> > command with the default profile mentioned in profile.cfg .
> > I am using lcore 3 and 2 for RX and TX. It was not successful, getting
> > the below error.
> >
> > APP: Initializing port 0... PMD: eth_igb_rx_queue_setup():
> > sw_ring=0x7f5b20ba2240 hw_ring=0x7f5b20ba2680
> dma_addr=0xbf87a2680
> > PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance,
> > consider setting the TX WTHRESH value to 4, 8, or 16.
> > PMD: eth_igb_tx_queue_setup(): sw_ring=0x7f5b20b910c0
> > hw_ring=0x7f5b20b92100 dma_addr=0xbf8792100
> > PMD: eth_igb_start(): <<
> > done:  Link Up - speed 1000 Mbps - full-duplex
> > APP: Initializing port 1... PMD: eth_igb_rx_queue_setup():
> > sw_ring=0x7f5b20b80a40 hw_ring=0x7f5b20b80e80
> dma_addr=0xbf8780e80
> > PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance,
> > consider setting the TX W

[dpdk-dev] Traffic scheduling in DPDK

2016-01-06 Thread Singh, Jasvinder


> -Original Message-
> From: ravulakollu.kumar at wipro.com [mailto:ravulakollu.kumar at wipro.com]
> Sent: Wednesday, January 6, 2016 12:40 PM
> To: Singh, Jasvinder
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] Traffic scheduling in DPDK
> 
> Thanks Jasvinder,
> 
> Does this application works on systems with multiple NUMA Nodes ?
> 

It does. 

> Thanks,
> Uday
> 
> -Original Message-
> From: Singh, Jasvinder [mailto:jasvinder.singh at intel.com]
> Sent: Tuesday, January 05, 2016 3:40 PM
> To: Ravulakollu Udaya Kumar (WT01 - Product Engineering Service)
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] Traffic scheduling in DPDK
> 
> Hi Uday,
> 
> >
> > Thanks Jasvinder , I am running the below command
> >
> > ./build/qos_sched -c 0xe -n 1  -- --pfc "0,1,3,2" --cfg ./profile.cfg
> >
> > Bound two 1G physical ports to DPDK , and started running the above
> > command with the default profile mentioned in profile.cfg .
> > I am using lcore 3 and 2 for RX and TX. It was not successful, getting
> > the below error.
> >
> > APP: Initializing port 0... PMD: eth_igb_rx_queue_setup():
> > sw_ring=0x7f5b20ba2240 hw_ring=0x7f5b20ba2680
> dma_addr=0xbf87a2680
> > PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance,
> > consider setting the TX WTHRESH value to 4, 8, or 16.
> > PMD: eth_igb_tx_queue_setup(): sw_ring=0x7f5b20b910c0
> > hw_ring=0x7f5b20b92100 dma_addr=0xbf8792100
> > PMD: eth_igb_start(): <<
> > done:  Link Up - speed 1000 Mbps - full-duplex
> > APP: Initializing port 1... PMD: eth_igb_rx_queue_setup():
> > sw_ring=0x7f5b20b80a40 hw_ring=0x7f5b20b80e80
> dma_addr=0xbf8780e80
> > PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance,
> > consider setting the TX WTHRESH value to 4, 8, or 16.
> > PMD: eth_igb_tx_queue_setup(): sw_ring=0x7f5b20b6f8c0
> > hw_ring=0x7f5b20b70900 dma_addr=0xbf8770900
> > PMD: eth_igb_start(): <<
> > done:  Link Up - speed 1000 Mbps - full-duplex
> > SCHED: Low level config for pipe profile 0:
> > Token bucket: period = 3277, credits per period = 8, size = 100
> > Traffic classes: period = 500, credits per period = [12207,
> > 12207, 12207, 12207]
> > Traffic class 3 oversubscription: weight = 0
> > WRR cost: [1, 1, 1, 1], [1, 1, 1, 1], [1, 1, 1, 1], [1, 1, 1, 1]
> > EAL: Error - exiting with code: 1
> >   Cause: Unable to config sched subport 0, err=-2
> 
> 
> In default profile.cfg, It is assumed that all the nic ports have 10 Gbps 
> rate.
> The above error occurs when subport's  tb_rate (10Gbps) is found more than
> NIC port's capacity (1 Gbps). Therefore, you need to use either 10 Gbps ports
> in your application or have to amend the profile.cfg to work with 1 Gbps port.
> Please refer to  DPDK QoS framework document for more details on various
> parameters - http://dpdk.org/doc/guides/prog_guide/qos_framework.html
> 
> 
> > -Original Message-
> > From: Singh, Jasvinder [mailto:jasvinder.singh at intel.com]
> > Sent: Monday, January 04, 2016 9:26 PM
> > To: Ravulakollu Udaya Kumar (WT01 - Product Engineering Service);
> > dev at dpdk.org
> > Subject: RE: [dpdk-dev] Traffic scheduling in DPDK
> >
> > Hi Uday,
> >
> >
> > > I have an issue in running qos_sched application in DPDK .Could
> > > someone tell me how to run the command  and what each parameter
> does
> > > In the below mentioned text.
> > >
> > > Application mandatory parameters:
> > > --pfc "RX PORT, TX PORT, RX LCORE, WT LCORE" : Packet flow
> > configuration
> > >multiple pfc can be configured in command line
> >
> >
> > RX PORT - Specifies the packets receive port TX PORT - Specifies the
> > packets transmit port RXCORE - Specifies the  Core used for Packet
> > reception and Classification stage of the QoS application.
> > WTCORE-  Specifies the  Core used for Packet enqueue/dequeue operation
> > (QoS scheduling)  and subsequently transmitting the packets out.
> >
> > Multiple pfc  can be specified depending upon the number of instances
> > of qos sched required in application.  For example- in order to run
> > two instance, following can be used-
> >
> > ./build/qos_sched -c 0x7e -n 4 -- --pfc "0,1,2,3,4" --pfc "2,3,5,6"
> > --cfg "profile.cfg"
> >
> > First instance of qos sched receives packets from port 0 and transmits
> > its packets through port 1 ,while second qos sched will receives
> > packets fr

[dpdk-dev] Traffic scheduling in DPDK

2016-01-04 Thread Singh, Jasvinder
Hi Uday,


> I have an issue in running qos_sched application in DPDK .Could someone tell
> me how to run the command  and what each parameter does In the below
> mentioned text.
> 
> Application mandatory parameters:
> --pfc "RX PORT, TX PORT, RX LCORE, WT LCORE" : Packet flow configuration
>multiple pfc can be configured in command line


RX PORT - Specifies the packets receive port 
TX PORT - Specifies the packets transmit port 
RXCORE - Specifies the  Core used for Packet reception and Classification stage 
of the QoS application.
WTCORE-  Specifies the  Core used for Packet enqueue/dequeue operation (QoS 
scheduling)  and subsequently transmitting the packets out.

Multiple pfc  can be specified depending upon the number of instances of qos 
sched required in application.  For example- in order to run two instance, 
following can be used-

./build/qos_sched -c 0x7e -n 4 -- --pfc "0,1,2,3,4" --pfc "2,3,5,6" --cfg 
"profile.cfg"   

First instance of qos sched receives packets from port 0 and transmits its 
packets through port 1 ,while second qos sched will receives packets from port 
2 and transmit through port 3. In case of single qos sched instance, following 
can be used-

./build/qos_sched -c 0x1e -n 4 -- --pfc "0,1,2,3,4" --cfg "profile.cfg"


Thanks, 
Jasvinder


[dpdk-dev] [PATCH] examples/ip_pipeline: Fix compile issue with strict-aliasing

2015-12-09 Thread Singh, Jasvinder


> -Original Message-
> From: Qiu, Michael
> Sent: Wednesday, December 9, 2015 8:44 AM
> To: dev at dpdk.org
> Cc: Singh, Jasvinder; Dumitrescu, Cristian; Qiu, Michael
> Subject: [PATCH] examples/ip_pipeline: Fix compile issue with strict-aliasing
> 
> Compile ip_pipeline in CentOS 6.5 with kernel 2.6.32-431 GCC 4.4.7, will lead
> below error:
> 
> pipeline_routing_be.c: In function
> ?pipeline_routing_msg_req_arp_add_handler?:
> pipeline_routing_be.c:1817: error: dereferencing pointer ?({anonymous})?
>   does break strict-aliasing rules
> 
> This because the code break strict-aliasing rule.
> The patch solve this issue.
> 
> Fixes: 0ae7275810f1 (examples/ip_pipeline: add more functions to routing
> pipeline)
> 
> Signed-off-by: Michael Qiu 

Acked-by: Jasvinder Singh 


[dpdk-dev] [PATCH v4] ip_pipeline: add flow actions pipeline

2015-12-07 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, December 7, 2015 1:18 AM
> To: Zhang, Roy Fan
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] ip_pipeline: add flow actions pipeline
> 
> 2015-11-18 17:09, Fan Zhang:
> > Flow actions pipeline is an extension of flow-classification pipeline.
> > Some of the operations of flow classification pipeline such as traffic
> >
> > Signed-off-by: Jasvinder Singh 
> > Signed-off-by: Fan Zhang 
> > Acked-by: Cristian Dumitrescu 
> 
> Applied, thanks

Hi Thomas,

This patch is not merged in the master. I don't see any source file.

Regards,
Jasvinder


[dpdk-dev] [PATCH] doc: update release notes for ip_pipeline app

2015-11-04 Thread Singh, Jasvinder
> 
> Hi Jasvinder,
> 
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jasvinder Singh
> > Sent: Wednesday, November 04, 2015 3:05 PM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] [PATCH] doc: update release notes for ip_pipeline
> > app
> >
> > This patch updates the release notes with the features added to
> > ip_pipeline application.
> >
> > Signed-off-by: Jasvinder Singh 
> > ---
> 
> You have added the changes in the wrong place, under resolved issues.
> Could you send a v2 with those moved?
> 
> Thanks,
> Pablo

Thanks, Pablo. I will send v2 soon.

Jasvinder 


[dpdk-dev] [PATCH v4 0/2] cfgfile: modify the macros values

2015-10-23 Thread Singh, Jasvinder


> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, October 22, 2015 5:36 PM
> To: Singh, Jasvinder
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 0/2] cfgfile: modify the macros values
> 
> > Michal Jastrzebski (1):
> >   qos_sched: fix example modification to use librte_cfgfile
> >
> > Jasvinder Singh (1):
> >   librte_cfgfile(rte_cfgfile.h): modify the macros values
> 
> Applied with more meaningful titles:
>   examples/qos_sched: remove duplicated cfgfile library
>   cfgfile: increase entry name and value sizes

Thank you, Thomas. I will work on having more precise titles in future.


[dpdk-dev] [PATCH v3] ip_pipeline: add flow id parameter to flow classification

2015-10-12 Thread Singh, Jasvinder


> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Monday, October 12, 2015 4:47 PM
> To: Singh, Jasvinder; dev at dpdk.org
> Subject: RE: [PATCH v3] ip_pipeline: add flow id parameter to flow
> classification
> 
> 
> 
> > -Original Message-
> > From: Singh, Jasvinder
> > Sent: Monday, October 12, 2015 4:42 PM
> > To: dev at dpdk.org
> > Cc: Dumitrescu, Cristian
> > Subject: [PATCH v3] ip_pipeline: add flow id parameter to flow
> > classification
> >
> > *v3
> > fixed bug: changed LRU hash table operation to extendible bucket hash
> > table operation
> >
> > Signed-off-by: Jasvinder Singh 
> > ---
> 
> 
> Acked-by: Cristian Dumitrescu 
> 
> Jasvinder, next time we send new patch version with just a small
> modification (like this one), you can also include my Ack line from the
> previous version (just under the signoff line), as Thomas kindly suggested.

I will remember next time. Thanks.


[dpdk-dev] [PATCH] librte_cfgfile (rte_cfgfile.h): modify the macros values

2015-09-03 Thread Singh, Jasvinder

> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, September 2, 2015 9:48 PM
> To: Singh, Jasvinder
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] librte_cfgfile (rte_cfgfile.h): modify the
> macros values
> 
> 2015-09-02 16:53, Jasvinder Singh:
> > This patch refers to the ABI change proposed for librte_cfgfile
> (rte_cfgfile.h).
> > In order to allow for longer names and values, the new values of macros
> CFG_NAME_LEN and CFG_NAME_VAL are set.
> >
> > Signed-off-by: Jasvinder Singh 
> > ---
> >  lib/librte_cfgfile/rte_cfgfile.h | 9 +++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> If the ABI is changed, the LIBABIVER number must be bumped.
> The release notes must also be updated and the deprecation announce must
> be removed.
> Thanks

Thanks, Thomas. I will submit v2 patch. 


[dpdk-dev] [ 2nd try ] Lookup mechanim in DPDK HASH table.

2015-08-17 Thread Singh, Jasvinder
Hi,

> -Original Message-
> From: Yeddula, Avinash [mailto:ayeddula at ciena.com]
> Sent: Monday, August 17, 2015 5:35 PM
> To: Singh, Jasvinder; Richardson, Bruce
> Cc: dev at dpdk.org; Bly, Mike
> Subject: RE: [dpdk-dev] [ 2nd try ] Lookup mechanim in DPDK HASH table.
> 
> + Mike ( My team mate)
> Hi Jasvinder, It's not a bidirectional packet flow. The pipeline looks 
> something
> like this.
> 
> Ingress port-Table 1 Table-2 - Mac_Table - Table4  Egress
> port.
> 
> Before the frame goes reaches table 4, we do 2 lookups at the mac table.
> 1. src lookup ( To learn the MAC on the bridge) 2. dst lookup ( Flooding if 
> dst
> MAC look up fails else Unicast/forward if dst lookup success).
> 
> Here are the keys we are using.
> Src lookup key  -  Src MAC (src MAC in the frame) + Bridge ID ( Bridge on
> which it arrived).
> Dst lookup key  - Dst MAC (dst MAC in the frame) + Bridge ID ( Bridge on
> which it arrived)
> 

There is as such no mechanism to support double lookup on the same table for 
the packet. However, alternative approach could be-first perform 
destination lookup and  invoke action handler ( in both table hit & miss case). 
In action handler, Src MAC + bridge ID key can be added to the table 
(rte_pipeline_table_entry_add) .  If a new entry is successfully added to the 
hash for the specified key, or there is already an entry in the hash for the 
specified key, then the position of the entry is returned. In this way, table 
entries will be updated with incoming packets.


> Thanks
> -Avinash
> 
> -Original Message-
> From: Singh, Jasvinder [mailto:jasvinder.singh at intel.com]
> Sent: Monday, August 17, 2015 7:00 AM
> To: Richardson, Bruce; Yeddula, Avinash
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [ 2nd try ] Lookup mechanim in DPDK HASH table.
> 
> 
> 
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
> > Sent: Friday, August 14, 2015 10:25 AM
> > To: Yeddula, Avinash
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [ 2nd try ] Lookup mechanim in DPDK HASH table.
> >
> > On Thu, Aug 13, 2015 at 05:37:21PM -0400, Yeddula, Avinash wrote:
> > > Any comments on this question ?
> > >
> > > Thanks
> > > -Avinash
> > >
> > > -Original Message-
> > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yeddula,
> > > Avinash
> > > Sent: Wednesday, August 12, 2015 3:04 PM
> > > To: dev at dpdk.org
> > > Subject: [dpdk-dev] Lookup mechanim in DPDK HASH table.
> > >
> > > Hello All,
> > >
> > > I'm using DPDK extendable hash tables. This question is with respect
> > > to the
> > lookup aspect of the hash table.
> > > I see that there is just one "t->key_offset" that is pre-defined for
> > > the hash
> > table. I also understand that the frame needs to carry the "lookup_key
> > / keys" in the meta data.
> > >
> > > Here is my question:  How to support more than one lookup with
> > > different
> > keys on the same frame on the same table.
> > > Use case: Src mac  lookup and dst mac lookup on the same mac table.
> > >
> > > Thanks
> > > -Avinash
> >
> > Just to confirm: this is using the extensible bucket hash in the
> > rte_table library of packet framework, rather than the standalone
> > rte_hash library, right?
> >
> > /Bruce
> 
> Could you share detail on the two different keys used for lookups. In case if
> you are considering bidirectional packet flow between the source and
> destination, symmetric hash can be used-
> http://www.ndsl.kaist.edu/~kyoungsoo/papers/TR-symRSS.pdf
> 
> Jasvinder


[dpdk-dev] [ 2nd try ] Lookup mechanim in DPDK HASH table.

2015-08-17 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson
> Sent: Friday, August 14, 2015 10:25 AM
> To: Yeddula, Avinash
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [ 2nd try ] Lookup mechanim in DPDK HASH table.
> 
> On Thu, Aug 13, 2015 at 05:37:21PM -0400, Yeddula, Avinash wrote:
> > Any comments on this question ?
> >
> > Thanks
> > -Avinash
> >
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yeddula, Avinash
> > Sent: Wednesday, August 12, 2015 3:04 PM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] Lookup mechanim in DPDK HASH table.
> >
> > Hello All,
> >
> > I'm using DPDK extendable hash tables. This question is with respect to the
> lookup aspect of the hash table.
> > I see that there is just one "t->key_offset" that is pre-defined for the 
> > hash
> table. I also understand that the frame needs to carry the "lookup_key /
> keys" in the meta data.
> >
> > Here is my question:  How to support more than one lookup with different
> keys on the same frame on the same table.
> > Use case: Src mac  lookup and dst mac lookup on the same mac table.
> >
> > Thanks
> > -Avinash
> 
> Just to confirm: this is using the extensible bucket hash in the rte_table
> library of packet framework, rather than the standalone rte_hash library,
> right?
> 
> /Bruce

Could you share detail on the two different keys used for lookups. In case if 
you are considering bidirectional packet flow between the source and 
destination, symmetric hash can be used-  
http://www.ndsl.kaist.edu/~kyoungsoo/papers/TR-symRSS.pdf 

Jasvinder


[dpdk-dev] [PATCH] doc: ip_pipeline app user guide

2015-08-06 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, August 6, 2015 2:48 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: ip_pipeline app user guide
> 
> Added more extensive documentation for ip_pipeline application.
> 
> Signed-off-by: Cristian Dumitrescu 
> ---

Acked-by: Jasvinder Singh 









[dpdk-dev] [PATCH v2] announce ABI change for librte_table

2015-07-23 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 23, 2015 12:00 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v2] announce ABI change for librte_table
> 
> v2 changes:
> -changed item on LPM table to add LPM IPv6 -removed item for ACL table
> and replaced with item on table ops -added item for hash tables
> 
> Signed-off-by: Cristian Dumitrescu 
> ---

Acked-by: Jasvinder Singh 



[dpdk-dev] [PATCH] doc: announce ABI change for librte_pipeline

2015-07-17 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 6:08 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_pipeline
> 
> 
> Signed-off-by: Cristian Dumitrescu 
> ---

Acked-by: Jasvinder Singh 


[dpdk-dev] [PATCH] doc: announce ABI change for librte_table

2015-07-17 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 6:00 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_table
> 
> 
> Signed-off-by: Cristian Dumitrescu 
> ---

Acked-by: Jasvinder Singh 


[dpdk-dev] [PATCH v2] doc: announce ABI change for librte_port

2015-07-16 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 4:27 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v2] doc: announce ABI change for librte_port
> 
> v2 changes:
> -text simplification
> 
> Signed-off-by: Cristian Dumitrescu 
> ---

Acked-by: Jasvinder Singh 



[dpdk-dev] [PATCH] doc: announce ABI change for librte_port

2015-07-16 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 1:20 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port
> 
> 
> Signed-off-by: Cristian Dumitrescu 
> ---

Acked-by: Jasvinder Singh 


[dpdk-dev] [PATCH] doc: announce ABI change for librte_cfgfile

2015-07-16 Thread Singh, Jasvinder


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 12:37 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_cfgfile
> 
> 
> Signed-off-by: Cristian Dumitrescu 
> ---

Acked-by: Jasvinder Singh