[GitHub] drill pull request #893: DRILL-5703 Add Syntax Highlighting & Autocompletion...

2017-08-06 Thread cgivre 
Github user cgivre closed the pull request at:

https://github.com/apache/drill/pull/893


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #897: Drill-5703 Added Syntax Highlighting and Limited Au...

2017-08-06 Thread cgivre 
GitHub user cgivre opened a pull request:

https://github.com/apache/drill/pull/897

Drill-5703 Added Syntax Highlighting and Limited Autocomplete on Query Page

This is a clean PR for #893 . This PR replaces the textarea on the query 
page with the Ace Code editor. (https://ace.c9.io)  

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cgivre/drill ui

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/897.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #897


commit 309ef86bed73b39d39b2829df95c1b60afd9874d
Author: cgivre 
Date:   2017-08-07T03:58:43Z

Added Code Editor on Query Page

commit ad30bbddcec49f32f9b022e0b833b9f0165c5df2
Author: cgivre 
Date:   2017-08-07T04:03:59Z

Removed extraneous javasript files from Ace build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #896: WIP: Made UI links relative.

2017-08-06 Thread joerg84 
Github user joerg84 commented on the issue:

https://github.com/apache/drill/pull/896
  
Is the CI currently broken? This does not seem to be a related error (and 
occurs with other PRs as well).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Webui and absolute links

2017-08-06 Thread Jörg Schad 
Maybe code can express my intentions more clearly:
https://github.com/apache/drill/pull/896

On Sun, Aug 6, 2017 at 5:36 PM, Jörg Schad  wrote:

> Looking at it, it seems to be a separate issue to me.
>
> That issue is about external references, I care about the internal links.
> These currently use absolute addressing at many places, which leads to the
> problem in the DC/OS UI that css files etc cannot be loaded:
>
>
> On Sun, Aug 6, 2017 at 5:28 PM, Pritesh Maker  wrote:
>
>> Hi
>>
>> Could this be a duplicate of this JIRA - DRILL-5699: Drill Web UI Page
>> Source Has Links To External Sites
>>
>> It’s in progress with this PR – https://github.com/apache/drill/pull/891
>>
>> Pritesh
>>
>> On 8/6/17, 4:28 PM, "Jörg Schad"  wrote:
>>
>> Hi,
>> I am just creating a drill package for DC/OS / Apache Mesos.
>>
>> The one problem I am facing is the UI integration. Unfortunately the
>> drill
>> UI uses static links (
>> e.g.,
>> 
>> 
>> ) .
>> This does not work nicely with the DC/OS UI, which would reference the
>> drill UI via https:///service/drill/.
>>
>> Are there any objections against a PR making the all the links
>> relative (
>> e.g.,
>> 
>> 
>> ).
>>
>>
>> Thank you!
>> Joerg
>>
>>
>>
>

[GitHub] drill pull request #896: WIP: Made UI links relative.

2017-08-06 Thread joerg84 
GitHub user joerg84 opened a pull request:

https://github.com/apache/drill/pull/896

WIP: Made UI links relative.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joerg84/drill UI

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/896.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #896


commit dac4f1bbc38e4871447495e1df44eefc7ff963db
Author: Joerg Schad 
Date:   2017-08-07T01:23:35Z

WIP: Made UI links relative.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Webui and absolute links

2017-08-06 Thread Jörg Schad 
Looking at it, it seems to be a separate issue to me.

That issue is about external references, I care about the internal links.
These currently use absolute addressing at many places, which leads to the
problem in the DC/OS UI that css files etc cannot be loaded:


On Sun, Aug 6, 2017 at 5:28 PM, Pritesh Maker  wrote:

> Hi
>
> Could this be a duplicate of this JIRA - DRILL-5699: Drill Web UI Page
> Source Has Links To External Sites
>
> It’s in progress with this PR – https://github.com/apache/drill/pull/891
>
> Pritesh
>
> On 8/6/17, 4:28 PM, "Jörg Schad"  wrote:
>
> Hi,
> I am just creating a drill package for DC/OS / Apache Mesos.
>
> The one problem I am facing is the UI integration. Unfortunately the
> drill
> UI uses static links (
> e.g.,
> 
> 
> ) .
> This does not work nicely with the DC/OS UI, which would reference the
> drill UI via https:///service/drill/.
>
> Are there any objections against a PR making the all the links
> relative (
> e.g.,
> 
> 
> ).
>
>
> Thank you!
> Joerg
>
>
>

Re: Webui and absolute links

2017-08-06 Thread Pritesh Maker 
Hi

Could this be a duplicate of this JIRA - DRILL-5699: Drill Web UI Page Source 
Has Links To External Sites

It’s in progress with this PR – https://github.com/apache/drill/pull/891 

Pritesh

On 8/6/17, 4:28 PM, "Jörg Schad"  wrote:

Hi,
I am just creating a drill package for DC/OS / Apache Mesos.

The one problem I am facing is the UI integration. Unfortunately the drill
UI uses static links (
e.g.,


) .
This does not work nicely with the DC/OS UI, which would reference the
drill UI via https:///service/drill/.

Are there any objections against a PR making the all the links relative (
e.g.,


).


Thank you!
Joerg

Webui and absolute links

2017-08-06 Thread Jörg Schad 
Hi,
I am just creating a drill package for DC/OS / Apache Mesos.

The one problem I am facing is the UI integration. Unfortunately the drill
UI uses static links (
e.g.,


) .
This does not work nicely with the DC/OS UI, which would reference the
drill UI via https:///service/drill/.

Are there any objections against a PR making the all the links relative (
e.g.,


).


Thank you!
Joerg