[GitHub] [drill] KazydubB commented on a change in pull request #1985: DRILL-7565: ANALYZE TABLE ... REFRESH METADATA does not work for empty Parquet files

2020-02-17 Thread GitBox 
KazydubB commented on a change in pull request #1985: DRILL-7565: ANALYZE TABLE 
... REFRESH METADATA does not work for empty Parquet files
URL: https://github.com/apache/drill/pull/1985#discussion_r380227482
 
 

 ##
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/metastore/ColumnNamesOptions.java
 ##
 @@ -40,6 +41,7 @@ public ColumnNamesOptions(OptionManager optionManager) {
 this.rowGroupStart = 
optionManager.getOption(ExecConstants.IMPLICIT_ROW_GROUP_START_COLUMN_LABEL).string_val;
 this.rowGroupLength = 
optionManager.getOption(ExecConstants.IMPLICIT_ROW_GROUP_LENGTH_COLUMN_LABEL).string_val;
 this.lastModifiedTime = 
optionManager.getOption(ExecConstants.IMPLICIT_LAST_MODIFIED_TIME_COLUMN_LABEL).string_val;
+this.projectMetadataColumn = 
optionManager.getOption(ExecConstants.IMPLICIT_PROJECT_METADATA_COLUMN_LABEL).string_val;
 
 Review comment:
   I think, it is better to declare 
`ExecConstants.IMPLICIT_PROJECT_METADATA_COLUMN_LABEL` (and 
`ExecConstants.IMPLICIT_LAST_MODIFIED_TIME_COLUMN_LABEL`) as `StringValidator` 
and use it as `this.projectMetadataColumn = 
optionManager.getOption(ExecConstants.IMPLICIT_PROJECT_METADATA_COLUMN_LABEL);`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] KazydubB commented on a change in pull request #1985: DRILL-7565: ANALYZE TABLE ... REFRESH METADATA does not work for empty Parquet files

2020-02-17 Thread GitBox 
KazydubB commented on a change in pull request #1985: DRILL-7565: ANALYZE TABLE 
... REFRESH METADATA does not work for empty Parquet files
URL: https://github.com/apache/drill/pull/1985#discussion_r380231898
 
 

 ##
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/metadata/MetadataAggregateHelper.java
 ##
 @@ -117,16 +120,16 @@ private void createAggregatorInternal() {
   }
 }
 
-for (SchemaPath excludedColumn : excludedColumns) {
-  if 
(excludedColumn.equals(SchemaPath.getSimplePath(columnNamesOptions.rowGroupStart()))
-  || 
excludedColumn.equals(SchemaPath.getSimplePath(columnNamesOptions.rowGroupLength(
 {
-LogicalExpression lastModifiedTime = new FunctionCall("any_value",
+for (SchemaPath nonSchemaColumn : context.metadataColumns()) {
 
 Review comment:
   Rename to `metadataColumn` or `implicitColumn`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services