[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-414392376 @sohami thanks for the detailed follow-up review and running the regression tests with the PR (I assume with default setting of run-time pushdown disabled). @weijietong sorry I have not been responsive lately due to personal reasons. Thanks for addressing review comments. @sohami , it's a +1 from me as well, so when you get a chance pls go ahead and merge the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-409629930 @sohami pls see if your comments are addressed. @weijietong just FYI, the ongoing 1.14.0 release is yet to be finished (it is in voting stage), so there may be some delays in running regression tests on the QA cluster with your PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-408948442 Since most of my comments have been addressed, I am +1. Thanks @weijietong. Once you address @sohami 's comments, the next steps would be: - pls file JIRAs for items we identified during code review. - rebase on master and run unit tests - mark the JIRA ready-to-commit - we'll need a volunteer to run the regression tests on QA test cluster (I will ask for volunteer) - presumably with the default FALSE setting for the JPPD feature, tests are clean, then it can be merged to master. - continue further tests with a TRUE setting This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-407121370 @weijietong thanks for your patience. I have submitted a final round of review comments. Once you address them we can get the feature merged into 1.15.0 such that it gives it enough time to go through the normal functional and performance testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-407117879 One high level comment: if a query is cancelled and there's in-flight bloom-filter message from drillbit to foreman, or the broadcast message of the aggregated BF from foreman to drill bits, does that cleanup get handled appropriately ? We can have a follow-up JIRA if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-406929428 Hey @weijietong, sorry for the delay; I will send you my final comments by tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-403545024 @weijietong thanks for making these changes. I will do one final round of review hopefully soon and let you know. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-402828959 @weijietong I have couple of design questions that are better discussed in the JIRA, so I will add them there.. pls take a look. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-401246375 @weijietong thanks for the PR. Yes, this is high on my list to review. I am tied up until tomorrow but will review during the weekend. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
