[GitHub] fjy commented on issue #5976: Update license headers.

[GitBox]

fjy commented on issue #5976: Update license headers.
URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188549
 
 
   @gianm Yes IntList is from the same place


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm commented on issue #5976: Update license headers.

[GitBox]

gianm commented on issue #5976: Update license headers.
URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188534
 
 
   @fjy Do you know if IntList is from the same place?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] fjy commented on issue #5976: Update license headers.

[GitBox]

fjy commented on issue #5976: Update license headers.
URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188514
 
 
   ConciseSetUtils is from the original ConciseSet library under the Apache 
license. The license header is missing for the file but it should be the same 
as the rest of the files under the ConciseSet library (Apache v2).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm commented on issue #5976: Update license headers.

[GitBox]

gianm commented on issue #5976: Update license headers.
URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188392
 
 
   This is the earliest commit I can find for both of those files with no 
license headers. They both came from another repo that was copied into this one 
as part of #3694.
   
   
https://github.com/metamx/extendedset/commit/02366f18385b3e082866e5bbbd38357ceee13d79#diff-97bd266eb5d2e8b0e7a38a658921356d


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm commented on issue #5976: Update license headers.

[GitBox]

gianm commented on issue #5976: Update license headers.
URL: https://github.com/apache/incubator-druid/pull/5976#issuecomment-403188239
 
 
   Most of this diff is updating one set of boilerplate headers to another. 
Other than that, there are a few files in the extendset package that I want to 
call attention to.
   
   Files with a non-standard header (by Druid standards):
   
   - 
https://github.com/apache/incubator-druid/blob/master/extendedset/src/main/java/io/druid/extendedset/intset/AbstractIntSet.java
   - 
https://github.com/apache/incubator-druid/blob/master/extendedset/src/main/java/io/druid/extendedset/intset/ConciseSet.java
   - 
https://github.com/apache/incubator-druid/blob/master/extendedset/src/main/java/io/druid/extendedset/intset/IntSet.java
   
   The license on the these three files seems ok (it's Apache 2.0) and also we 
already call this copying out in the NOTICE file. So they seem ok to me but I'm 
just calling them out to double-check.
   
   We also have two files with no license header:
   
   - 
https://github.com/apache/incubator-druid/blob/master/extendedset/src/main/java/io/druid/extendedset/intset/ConciseSetUtils.java
   - 
https://github.com/apache/incubator-druid/blob/master/extendedset/src/main/java/io/druid/extendedset/utilities/IntList.java
   
   I am not sure what the provenance of these files is. @fjy - you did the 
initial checkin - do you remember if you wrote these files or if they were 
copied from somewhere else?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm opened a new pull request #5976: Update license headers.

[GitBox]

gianm opened a new pull request #5976: Update license headers.
URL: https://github.com/apache/incubator-druid/pull/5976
 
 
   For compliance with http://www.apache.org/legal/src-headers.html.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

Re: Druid repo migration plan

[Gian Merlino]

I asked in our original Infra ticket to adjust the mailing lists:
https://issues.apache.org/jira/browse/INFRA-16674?focusedCommentId=16535589&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16535589

Unfortunately setting up filters proved challenging in Gmail (gitbox sets a
custom header that could be used in theory, but Gmail doesn't support
filtering on arbitrary headers). I'm doing something like this now, in case
it proves useful for anyone else:
https://gist.github.com/gianm/0eb410915c02e3844e11235172894c62 (it's a gist
because the filters are partially based on content, and if paste them in
this message, they'll catch it as a false positive gitbox mail…)

On Fri, Jul 6, 2018 at 1:31 PM Gian Merlino  wrote:

> IMO, GitHub has good tools already for subscribing to repos,
> notifications, and issues. I would expect Druid contributors to use those
> tools and _not_ to join git...@druid.apache.org. I'd imagine the list
> would only exist for archival purposes (we want a copy of every discussion
> to be stored somehow on ASF infra).
>
> On Fri, Jul 6, 2018 at 1:27 PM Julian Hyde  wrote:
>
>> I see there are notifications not just for commits but for every comment
>> on every issue. That’s going to be overwhelming. I can’t imagine anyone
>> wanting to subscribe to the gitbox list at the current volume.
>>
>> How about only sending comments to people who have watched a particular
>> case?
>>
>> Julian
>>
>>
>> > On Jul 6, 2018, at 1:08 PM, Julian Hyde  wrote:
>> >
>> > I like the idea of a separate list for commits. Keeps the noise down on
>> the dev list.
>> >
>> > Other projects (e.g. calcite) would name that list “commits”, i.e.
>> comm...@druid.apache.org . If you were
>> to add other repos (e.g. a subversion repo for web site) you could send its
>> commits there too.
>> >
>> >> On Jul 6, 2018, at 12:24 PM, Samarth Jain > > wrote:
>> >>
>> >> +1 to sending to git...@druid.apache.org > git...@druid.apache.org>
>> >>
>> >> On Fri, Jul 6, 2018 at 12:17 PM, Gian Merlino > > wrote:
>> >>
>> >>> The repo move has happened: https://github.com/apache/incubator-druid
>> 
>> >>>
>> >>> My understanding is that now we can and should start prepping license,
>> >>> notice, etc for a release. And also making sure that our integrations
>> still
>> >>> work right (Travis / TeamCity).
>> >>>
>> >>> Also: does anyone else find the gitbox mails sent to
>> dev@druid.apache.org 
>> >>> annoying? I'm planning to set up a mail filter to put them into
>> another
>> >>> folder (they're redundant to notifications I already get from
>> GitHub). If
>> >>> people generally feel the same way we could ask Infra to move them to
>> a
>> >>> separate mailing list, maybe git...@druid.apache.org > git...@druid.apache.org>.
>> >>>
>> >>> On Tue, Jul 3, 2018 at 12:57 PM Gian Merlino > > wrote:
>> >>>
>>  Here is the ticket, btw: https://issues.apache.org/ <
>> https://issues.apache.org/>
>> >>> jira/browse/INFRA-16674.
>>  Repo move should be happening real soon now!
>> 
>>  On Mon, Jul 2, 2018 at 11:55 PM Gian Merlino > > wrote:
>> 
>> > Our infra ticket is progressing along and it looks like we're just
>> about
>> > ready to pull the trigger on moving the repo. So, committers, please
>> >>> make
>> > sure your ASF gitbox stuff is working:
>> https://gitbox.apache.org/setup/ 
>> >
>> > On Fri, Jun 22, 2018 at 1:22 PM Gian Merlino > > wrote:
>> >
>> >> Thanks for the tips, Max!! I think we are, hopefully, doing okay on
>> >>> some
>> >> of these. My thoughts inline.
>> >>
>> >>> Since you need elevated rights on both
>> >> orgs to move the repo (say airbnb and apache) and that both parties
>> >> aren't
>> >> ok with that, it's typical to use a middleman org like
>> `apacheinfra`.
>> >>
>> >> Luckily, our org is limited to just Druid stuff (
>> >> https://github.com/druid-io ) so we
>> should be OK to add Apache Infra
>> >> people with elevated rights.
>> >>
>> >>> * make merge hook checks optional, so that if coverage, travis, or
>> >>> code
>> >> quality checks do not prevent merging, since it's likely those
>> check
>> >> won't
>> >> trigger and as a non-admin you won't be able to force-merge
>> >>
>> >> We have a couple (Travis and TeamCity) and they're already
>> optional.
>> >>
>> >>> * consider unprotecting protected branches so that you can push to
>> >> master
>> >> if controlling master is important in your workflow. This way you
>> can
>> >> effectively merge PRs without clicking the button on GH.
>> >>
>> >> Master _is_ important. Although I think if we can't do PRs, 

[GitHub] asdf2014 commented on issue #5955: The annotation handler 'io.druid.annotations.SubclassesMustBePublicAnnotationProcessor' could not be found

[GitBox]

asdf2014 commented on issue #5955: The annotation handler 
'io.druid.annotations.SubclassesMustBePublicAnnotationProcessor' could not be 
found
URL: 
https://github.com/apache/incubator-druid/issues/5955#issuecomment-403180664
 
 
   I see. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] asdf2014 closed issue #5955: The annotation handler 'io.druid.annotations.SubclassesMustBePublicAnnotationProcessor' could not be found

[GitBox]

asdf2014 closed issue #5955: The annotation handler 
'io.druid.annotations.SubclassesMustBePublicAnnotationProcessor' could not be 
found
URL: https://github.com/apache/incubator-druid/issues/5955
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5975: [Backport] Increase timeout for BlockingPoolTest

[GitBox]

jihoonson opened a new pull request #5975: [Backport] Increase timeout for 
BlockingPoolTest
URL: https://github.com/apache/incubator-druid/pull/5975
 
 
   Backport of #5959 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5974: [Backport] Coordinator fix balance to try to move max segments instead of up to max segments

[GitBox]

jihoonson opened a new pull request #5974: [Backport] Coordinator fix balance 
to try to move max segments instead of up to max segments
URL: https://github.com/apache/incubator-druid/pull/5974
 
 
   Backport of #5927 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5973: [Backport] Fix ConcurrentModificationException in IncrementalPublishingKafkaIndexTaskRunner

[GitBox]

jihoonson opened a new pull request #5973: [Backport] Fix 
ConcurrentModificationException in IncrementalPublishingKafkaIndexTaskRunner
URL: https://github.com/apache/incubator-druid/pull/5973
 
 
   Backport of #5907 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5972: [Backport] Prevent KafkaSupervisor NPE in generateSequenceName

[GitBox]

jihoonson opened a new pull request #5972: [Backport] Prevent KafkaSupervisor 
NPE in generateSequenceName 
URL: https://github.com/apache/incubator-druid/pull/5972
 
 
   Backport of #5902 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5971: [Backport] Fix Kafka Indexing task pause forever if no events in taskDuration

[GitBox]

jihoonson opened a new pull request #5971: [Backport] Fix Kafka Indexing task 
pause forever if no events in taskDuration
URL: https://github.com/apache/incubator-druid/pull/5971
 
 
   Backport of #5899 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5970: [Backport] Coordinator segment balancer max load queue fix

[GitBox]

jihoonson opened a new pull request #5970: [Backport] Coordinator segment 
balancer max load queue fix
URL: https://github.com/apache/incubator-druid/pull/5970
 
 
   Backport of #5888 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5969: [Backport] Fix inefficient available segment cache population in SQLMetadataSegmentManager

[GitBox]

jihoonson opened a new pull request #5969: [Backport] Fix inefficient available 
segment cache population in SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/5969
 
 
   Backport of #5878 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5968: [Backport] HdfsDataSegmentPusher: Close tmpIndexFile before copying it.

[GitBox]

jihoonson opened a new pull request #5968: [Backport] HdfsDataSegmentPusher: 
Close tmpIndexFile before copying it.
URL: https://github.com/apache/incubator-druid/pull/5968
 
 
   Backport of #5873 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5967: [Backport] Fix mismatch in revoked task locks between memory and metastore after sync from storage

[GitBox]

jihoonson opened a new pull request #5967: [Backport] Fix mismatch in revoked 
task locks between memory and metastore after sync from storage
URL: https://github.com/apache/incubator-druid/pull/5967
 
 
   Backport of #5858 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5966: [Backport] Immediately send 401 on basic HTTP authentication failure

[GitBox]

jihoonson opened a new pull request #5966: [Backport] Immediately send 401 on 
basic HTTP authentication failure
URL: https://github.com/apache/incubator-druid/pull/5966
 
 
   Backport of #5856 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

[GitBox]

gianm commented on issue #5931: Support limit for timeseries query (#5894)
URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403171434
 
 
   @surekhasaharan could you please merge in master again to this branch, so 
you get the benefit of #5959? Hopefully that should be enough to get the tests 
to pass.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson commented on issue #5850: Fix Zip Slip vulnerability

[GitBox]

jihoonson commented on issue #5850: Fix Zip Slip vulnerability
URL: https://github.com/apache/incubator-druid/pull/5850#issuecomment-403171377
 
 
   Changed the milestone to 0.13.0 because 
https://github.com/apache/incubator-druid/pull/5421 is only in 0.13.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

[GitBox]

gianm commented on issue #5931: Support limit for timeseries query (#5894)
URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403171386
 
 
   Got one of these too.
   
   ```
   
testBySegmentResultsWithAllFiltersWithExtractionFns[config=v2ParallelCombine, 
runner=rtIndex](io.druid.query.groupby.GroupByQueryRunnerTest)  Time elapsed: 
2.693 sec  <<< ERROR!
   java.lang.OutOfMemoryError: Direct buffer memory
at java.nio.Bits.reserveMemory(Bits.java:694)
at java.nio.DirectByteBuffer.(DirectByteBuffer.java:123)
at java.nio.ByteBuffer.allocateDirect(ByteBuffer.java:311)
at 
io.druid.query.groupby.GroupByQueryRunnerTest$8.get(GroupByQueryRunnerTest.java:358)
at 
io.druid.query.groupby.GroupByQueryRunnerTest$8.get(GroupByQueryRunnerTest.java:354)
at 
io.druid.collections.StupidPool.makeObjectWithHandler(StupidPool.java:112)
at io.druid.collections.StupidPool.take(StupidPool.java:103)
at 
io.druid.query.groupby.epinephelinae.GroupByQueryEngineV2.process(GroupByQueryEngineV2.java:125)
at 
io.druid.query.groupby.strategy.GroupByStrategyV2.process(GroupByStrategyV2.java:354)
at 
io.druid.query.groupby.GroupByQueryRunnerFactory$GroupByQueryRunner.run(GroupByQueryRunnerFactory.java:108)
at io.druid.query.BySegmentQueryRunner.run(BySegmentQueryRunner.java:54)
at 
io.druid.query.FinalizeResultsQueryRunner.run(FinalizeResultsQueryRunner.java:104)
at 
io.druid.query.ChainedExecutionQueryRunner$1$1.call(ChainedExecutionQueryRunner.java:119)
at 
io.druid.query.ChainedExecutionQueryRunner$1$1.call(ChainedExecutionQueryRunner.java:114)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:297)
at 
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
at 
com.google.common.util.concurrent.AbstractListeningExecutorService.submit(AbstractListeningExecutorService.java:58)
at 
io.druid.query.ChainedExecutionQueryRunner$1.lambda$make$0(ChainedExecutionQueryRunner.java:112)
at com.google.common.collect.Iterators$8.transform(Iterators.java:794)
at 
com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
at com.google.common.collect.Iterators.addAll(Iterators.java:357)
at com.google.common.collect.Lists.newArrayList(Lists.java:147)
at com.google.common.collect.Lists.newArrayList(Lists.java:129)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5965: [Backport] Fix topN lexicographic sort

[GitBox]

jihoonson opened a new pull request #5965: [Backport] Fix topN lexicographic 
sort
URL: https://github.com/apache/incubator-druid/pull/5965
 
 
   Backport of #5815 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm closed pull request #5959: Increase timeout for BlockingPoolTest

[GitBox]

gianm closed pull request #5959: Increase timeout for BlockingPoolTest
URL: https://github.com/apache/incubator-druid/pull/5959
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/common/src/test/java/io/druid/collections/BlockingPoolTest.java 
b/common/src/test/java/io/druid/collections/BlockingPoolTest.java
index a6459a862f5..a1d673a902a 100644
--- a/common/src/test/java/io/druid/collections/BlockingPoolTest.java
+++ b/common/src/test/java/io/druid/collections/BlockingPoolTest.java
@@ -21,7 +21,9 @@
 
 import com.google.common.base.Suppliers;
 import com.google.common.collect.Lists;
-import org.junit.AfterClass;
+import io.druid.java.util.common.concurrent.Execs;
+import org.junit.After;
+import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
@@ -30,7 +32,6 @@
 import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
 
 import static org.junit.Assert.assertEquals;
@@ -40,26 +41,34 @@
 
 public class BlockingPoolTest
 {
-  private static final ExecutorService SERVICE = 
Executors.newFixedThreadPool(2);
+  private ExecutorService service;
 
-  private static final DefaultBlockingPool POOL = new 
DefaultBlockingPool<>(Suppliers.ofInstance(1), 10);
-  private static final BlockingPool EMPTY_POOL = new 
DefaultBlockingPool<>(Suppliers.ofInstance(1), 0);
+  private DefaultBlockingPool pool;
+  private BlockingPool emptyPool;
 
-  @AfterClass
-  public static void teardown()
+  @Rule
+  public ExpectedException expectedException = ExpectedException.none();
+
+  @Before
+  public void setup()
   {
-SERVICE.shutdown();
+service = Execs.multiThreaded(2, "blocking-pool-test");
+pool = new DefaultBlockingPool<>(Suppliers.ofInstance(1), 10);
+emptyPool = new DefaultBlockingPool<>(Suppliers.ofInstance(1), 0);
   }
 
-  @Rule
-  public ExpectedException expectedException = ExpectedException.none();
+  @After
+  public void teardown()
+  {
+service.shutdownNow();
+  }
 
   @Test
   public void testTakeFromEmptyPool()
   {
 expectedException.expect(IllegalStateException.class);
 expectedException.expectMessage("Pool was initialized with limit = 0, 
there are no objects to take.");
-EMPTY_POOL.take(0);
+emptyPool.take(0);
   }
 
   @Test
@@ -67,49 +76,49 @@ public void testDrainFromEmptyPool()
   {
 expectedException.expect(IllegalStateException.class);
 expectedException.expectMessage("Pool was initialized with limit = 0, 
there are no objects to take.");
-EMPTY_POOL.takeBatch(1, 0);
+emptyPool.takeBatch(1, 0);
   }
 
-  @Test(timeout = 1000)
+  @Test(timeout = 5000)
   public void testTake()
   {
-final ReferenceCountingResourceHolder holder = POOL.take(100);
+final ReferenceCountingResourceHolder holder = pool.take(100);
 assertNotNull(holder);
-assertEquals(9, POOL.getPoolSize());
+assertEquals(9, pool.getPoolSize());
 holder.close();
-assertEquals(10, POOL.getPoolSize());
+assertEquals(10, pool.getPoolSize());
   }
 
-  @Test(timeout = 1000)
+  @Test(timeout = 5000)
   public void testTakeTimeout()
   {
-final List> batchHolder = 
POOL.takeBatch(10, 100L);
-final ReferenceCountingResourceHolder holder = POOL.take(100);
+final List> batchHolder = 
pool.takeBatch(10, 100L);
+final ReferenceCountingResourceHolder holder = pool.take(100);
 assertNull(holder);
 batchHolder.forEach(ReferenceCountingResourceHolder::close);
   }
 
-  @Test(timeout = 1000)
+  @Test(timeout = 5000)
   public void testTakeBatch()
   {
-final List> holder = 
POOL.takeBatch(6, 100L);
+final List> holder = 
pool.takeBatch(6, 100L);
 assertNotNull(holder);
 assertEquals(6, holder.size());
-assertEquals(4, POOL.getPoolSize());
+assertEquals(4, pool.getPoolSize());
 holder.forEach(ReferenceCountingResourceHolder::close);
-assertEquals(10, POOL.getPoolSize());
+assertEquals(10, pool.getPoolSize());
   }
 
-  @Test(timeout = 1000)
+  @Test(timeout = 5000)
   public void testWaitAndTakeBatch() throws InterruptedException, 
ExecutionException
   {
-List> batchHolder = 
POOL.takeBatch(10, 10);
+List> batchHolder = 
pool.takeBatch(10, 10);
 assertNotNull(batchHolder);
 assertEquals(10, batchHolder.size());
-assertEquals(0, POOL.getPoolSize());
+assertEquals(0, pool.getPoolSize());
 
-final Future>> future = 
SERVICE.submit(
-() -> POOL.takeBatch(8, 100)
+final Future>> future = 
service.submit(
+() -> pool.takeBatch(8, 100)
 );
 Thread.sleep(20);
 batchHolder.forEach(ReferenceCountingResourceHolder::close);
@@ -1

[incubator-druid] branch master updated: Increase timeout for BlockingPoolTest (#5959)

[gian]

This is an automated email from the ASF dual-hosted git repository.

gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/master by this push:
 new d1d9358  Increase timeout for BlockingPoolTest (#5959)
d1d9358 is described below

commit d1d935827477af9cb9d049afbf9ce28d319a9890
Author: Jihoon Son 
AuthorDate: Fri Jul 6 16:34:53 2018 -0700

Increase timeout for BlockingPoolTest (#5959)
---
 .../io/druid/collections/BlockingPoolTest.java | 153 +++--
 1 file changed, 81 insertions(+), 72 deletions(-)

diff --git a/common/src/test/java/io/druid/collections/BlockingPoolTest.java 
b/common/src/test/java/io/druid/collections/BlockingPoolTest.java
index a6459a8..a1d673a 100644
--- a/common/src/test/java/io/druid/collections/BlockingPoolTest.java
+++ b/common/src/test/java/io/druid/collections/BlockingPoolTest.java
@@ -21,7 +21,9 @@ package io.druid.collections;
 
 import com.google.common.base.Suppliers;
 import com.google.common.collect.Lists;
-import org.junit.AfterClass;
+import io.druid.java.util.common.concurrent.Execs;
+import org.junit.After;
+import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
@@ -30,7 +32,6 @@ import java.util.List;
 import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
 
 import static org.junit.Assert.assertEquals;
@@ -40,26 +41,34 @@ import static org.junit.Assert.assertTrue;
 
 public class BlockingPoolTest
 {
-  private static final ExecutorService SERVICE = 
Executors.newFixedThreadPool(2);
+  private ExecutorService service;
 
-  private static final DefaultBlockingPool POOL = new 
DefaultBlockingPool<>(Suppliers.ofInstance(1), 10);
-  private static final BlockingPool EMPTY_POOL = new 
DefaultBlockingPool<>(Suppliers.ofInstance(1), 0);
+  private DefaultBlockingPool pool;
+  private BlockingPool emptyPool;
 
-  @AfterClass
-  public static void teardown()
+  @Rule
+  public ExpectedException expectedException = ExpectedException.none();
+
+  @Before
+  public void setup()
   {
-SERVICE.shutdown();
+service = Execs.multiThreaded(2, "blocking-pool-test");
+pool = new DefaultBlockingPool<>(Suppliers.ofInstance(1), 10);
+emptyPool = new DefaultBlockingPool<>(Suppliers.ofInstance(1), 0);
   }
 
-  @Rule
-  public ExpectedException expectedException = ExpectedException.none();
+  @After
+  public void teardown()
+  {
+service.shutdownNow();
+  }
 
   @Test
   public void testTakeFromEmptyPool()
   {
 expectedException.expect(IllegalStateException.class);
 expectedException.expectMessage("Pool was initialized with limit = 0, 
there are no objects to take.");
-EMPTY_POOL.take(0);
+emptyPool.take(0);
   }
 
   @Test
@@ -67,49 +76,49 @@ public class BlockingPoolTest
   {
 expectedException.expect(IllegalStateException.class);
 expectedException.expectMessage("Pool was initialized with limit = 0, 
there are no objects to take.");
-EMPTY_POOL.takeBatch(1, 0);
+emptyPool.takeBatch(1, 0);
   }
 
-  @Test(timeout = 1000)
+  @Test(timeout = 5000)
   public void testTake()
   {
-final ReferenceCountingResourceHolder holder = POOL.take(100);
+final ReferenceCountingResourceHolder holder = pool.take(100);
 assertNotNull(holder);
-assertEquals(9, POOL.getPoolSize());
+assertEquals(9, pool.getPoolSize());
 holder.close();
-assertEquals(10, POOL.getPoolSize());
+assertEquals(10, pool.getPoolSize());
   }
 
-  @Test(timeout = 1000)
+  @Test(timeout = 5000)
   public void testTakeTimeout()
   {
-final List> batchHolder = 
POOL.takeBatch(10, 100L);
-final ReferenceCountingResourceHolder holder = POOL.take(100);
+final List> batchHolder = 
pool.takeBatch(10, 100L);
+final ReferenceCountingResourceHolder holder = pool.take(100);
 assertNull(holder);
 batchHolder.forEach(ReferenceCountingResourceHolder::close);
   }
 
-  @Test(timeout = 1000)
+  @Test(timeout = 5000)
   public void testTakeBatch()
   {
-final List> holder = 
POOL.takeBatch(6, 100L);
+final List> holder = 
pool.takeBatch(6, 100L);
 assertNotNull(holder);
 assertEquals(6, holder.size());
-assertEquals(4, POOL.getPoolSize());
+assertEquals(4, pool.getPoolSize());
 holder.forEach(ReferenceCountingResourceHolder::close);
-assertEquals(10, POOL.getPoolSize());
+assertEquals(10, pool.getPoolSize());
   }
 
-  @Test(timeout = 1000)
+  @Test(timeout = 5000)
   public void testWaitAndTakeBatch() throws InterruptedException, 
ExecutionException
   {
-List> batchHolder = 
POOL.takeBatch(10, 10);
+List> batchHolder = 
pool.takeBatch(10, 10);
 assertNotNull(batchHolder);
 assertEquals(10, batchHolder.size());
-assertEquals(0, POOL.getPoolSize());

[GitHub] jihoonson opened a new pull request #5964: [Backport] Allow GCS data segment killer to delete if present

[GitBox]

jihoonson opened a new pull request #5964: [Backport] Allow GCS data segment 
killer to delete if present
URL: https://github.com/apache/incubator-druid/pull/5964
 
 
   Backport of #5675 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5963: [Backport] topN: Fix caching of Float dimension values

[GitBox]

jihoonson opened a new pull request #5963: [Backport] topN: Fix caching of 
Float dimension values
URL: https://github.com/apache/incubator-druid/pull/5963
 
 
   Backport of #5653 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5962: [Backport] Fix cache bug in stats module

[GitBox]

jihoonson opened a new pull request #5962: [Backport] Fix cache bug in stats 
module
URL: https://github.com/apache/incubator-druid/pull/5962
 
 
   Backport of #5650 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5961: [Backport] revert lambda conversion to fix occasional jvm error

[GitBox]

jihoonson opened a new pull request #5961: [Backport] revert lambda conversion 
to fix occasional jvm error
URL: https://github.com/apache/incubator-druid/pull/5961
 
 
   Backport of https://github.com/apache/incubator-druid/pull/5591 to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5960: add 'stopped' check and handling to HttpLoadQueuePeon load and drop segment methods

[GitBox]

jihoonson opened a new pull request #5960: add 'stopped' check and handling to 
HttpLoadQueuePeon load and drop segment methods
URL: https://github.com/apache/incubator-druid/pull/5960
 
 
   Backport of # to 0.12.2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson opened a new pull request #5959: Increase timeout for BlockingPoolTest

[GitBox]

jihoonson opened a new pull request #5959: Increase timeout for BlockingPoolTest
URL: https://github.com/apache/incubator-druid/pull/5959
 
 
   Hope this fixes this Travis failure 
(https://github.com/apache/incubator-druid/pull/5931#issuecomment-403133666).
   
   /cc @gianm @surekhasaharan 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] jihoonson commented on issue #5941: [Backport] Fix missing task type in task payload API

[GitBox]

jihoonson commented on issue #5941: [Backport] Fix missing task type in task 
payload API
URL: https://github.com/apache/incubator-druid/pull/5941#issuecomment-403153636
 
 
   @gianm it looks that the above failures come from another PR? The failed 
task in this PR was the below one, and I've fixed it.
   
   ```
   Failed tests: 
   
io.druid.indexing.overlord.http.OverlordResourceTest.testGetTaskStatus(io.druid.indexing.overlord.http.OverlordResourceTest)
 Run 1: OverlordResourceTest.testGetTaskStatus:346 expected: 
io.druid.indexing.overlord.http.TaskStatusResponse but was: 
io.druid.indexing.overlord.http.TaskStatusResponse
 Run 2: OverlordResourceTest.tearDown:359 
 Expectation failure on verify:
   TaskStorageQueryAdapter.getStatus("mytask"): expected: 1, actual: 1
   TaskStorageQueryAdapter.getStatus("othertask"): expected: 1, actual: 0```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm commented on issue #5941: [Backport] Fix missing task type in task payload API

[GitBox]

gianm commented on issue #5941: [Backport] Fix missing task type in task 
payload API
URL: https://github.com/apache/incubator-druid/pull/5941#issuecomment-403142259
 
 
   Errors in travis:
   
   ```Failed tests: 
 BlockingPoolTest.testConcurrentBatchClose:303
 BlockingPoolTest.testConcurrentTake:193 expected:<10> but was:<0>
 BlockingPoolTest.testConcurrentTakeBatch:263
 BlockingPoolTest.testTake:77
 BlockingPoolTest.testTakeBatch:96
   Tests in error: 
 BlockingPoolTest.testConcurrentTakeBatchClose:364 » Execution 
java.lang.NullPo...
 BlockingPoolTest.testTakeTimeout:89 NullPointer
 BlockingPoolTest.testWaitAndTakeBatch:106 »  test timed out after 1000 
millise...
   ```
   
   Similar to ones we saw in 
https://github.com/apache/incubator-druid/pull/5931#issuecomment-403133666.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] surekhasaharan commented on issue #5931: Support limit for timeseries query (#5894)

[GitBox]

surekhasaharan commented on issue #5931: Support limit for timeseries query 
(#5894)
URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403140174
 
 
   @gianm thanks for checking the TeamCity error. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

Re: Druid repo migration plan

[Gian Merlino]

IMO, GitHub has good tools already for subscribing to repos, notifications,
and issues. I would expect Druid contributors to use those tools and _not_
to join git...@druid.apache.org. I'd imagine the list would only exist for
archival purposes (we want a copy of every discussion to be stored somehow
on ASF infra).

On Fri, Jul 6, 2018 at 1:27 PM Julian Hyde  wrote:

> I see there are notifications not just for commits but for every comment
> on every issue. That’s going to be overwhelming. I can’t imagine anyone
> wanting to subscribe to the gitbox list at the current volume.
>
> How about only sending comments to people who have watched a particular
> case?
>
> Julian
>
>
> > On Jul 6, 2018, at 1:08 PM, Julian Hyde  wrote:
> >
> > I like the idea of a separate list for commits. Keeps the noise down on
> the dev list.
> >
> > Other projects (e.g. calcite) would name that list “commits”, i.e.
> comm...@druid.apache.org . If you were
> to add other repos (e.g. a subversion repo for web site) you could send its
> commits there too.
> >
> >> On Jul 6, 2018, at 12:24 PM, Samarth Jain  > wrote:
> >>
> >> +1 to sending to git...@druid.apache.org  git...@druid.apache.org>
> >>
> >> On Fri, Jul 6, 2018 at 12:17 PM, Gian Merlino  g...@apache.org>> wrote:
> >>
> >>> The repo move has happened: https://github.com/apache/incubator-druid
> 
> >>>
> >>> My understanding is that now we can and should start prepping license,
> >>> notice, etc for a release. And also making sure that our integrations
> still
> >>> work right (Travis / TeamCity).
> >>>
> >>> Also: does anyone else find the gitbox mails sent to
> dev@druid.apache.org 
> >>> annoying? I'm planning to set up a mail filter to put them into another
> >>> folder (they're redundant to notifications I already get from GitHub).
> If
> >>> people generally feel the same way we could ask Infra to move them to a
> >>> separate mailing list, maybe git...@druid.apache.org  git...@druid.apache.org>.
> >>>
> >>> On Tue, Jul 3, 2018 at 12:57 PM Gian Merlino  g...@apache.org>> wrote:
> >>>
>  Here is the ticket, btw: https://issues.apache.org/ <
> https://issues.apache.org/>
> >>> jira/browse/INFRA-16674.
>  Repo move should be happening real soon now!
> 
>  On Mon, Jul 2, 2018 at 11:55 PM Gian Merlino  > wrote:
> 
> > Our infra ticket is progressing along and it looks like we're just
> about
> > ready to pull the trigger on moving the repo. So, committers, please
> >>> make
> > sure your ASF gitbox stuff is working:
> https://gitbox.apache.org/setup/ 
> >
> > On Fri, Jun 22, 2018 at 1:22 PM Gian Merlino  > wrote:
> >
> >> Thanks for the tips, Max!! I think we are, hopefully, doing okay on
> >>> some
> >> of these. My thoughts inline.
> >>
> >>> Since you need elevated rights on both
> >> orgs to move the repo (say airbnb and apache) and that both parties
> >> aren't
> >> ok with that, it's typical to use a middleman org like
> `apacheinfra`.
> >>
> >> Luckily, our org is limited to just Druid stuff (
> >> https://github.com/druid-io ) so we
> should be OK to add Apache Infra
> >> people with elevated rights.
> >>
> >>> * make merge hook checks optional, so that if coverage, travis, or
> >>> code
> >> quality checks do not prevent merging, since it's likely those check
> >> won't
> >> trigger and as a non-admin you won't be able to force-merge
> >>
> >> We have a couple (Travis and TeamCity) and they're already optional.
> >>
> >>> * consider unprotecting protected branches so that you can push to
> >> master
> >> if controlling master is important in your workflow. This way you
> can
> >> effectively merge PRs without clicking the button on GH.
> >>
> >> Master _is_ important. Although I think if we can't do PRs, then
> >>> pushing
> >> directly to master is probably not going to be too helpful anyway
> (the
> >>> PRs
> >> are essential to our code review workflow). So I think we have to
> hope
> >>> for
> >> the best here?
> >>
> >>> * make sure core committers have their Gitbox access setup, I think
> >>> it
> >> can
> >> be a bit tricky and may involve your mentor / infra pulling some
> levers
> >> on
> >> whimsy
> >>
> >> I went through this process (via https://gitbox.apache.org/setup/ <
> https://gitbox.apache.org/setup/>) to
> >> get the ability to push to
> >> https://github.com/apache/incubator-druid-website <
> https://github.com/apache/incubator-druid-website>, which is powering
> >> https://druid.apache.org/ . It took a
> little while and was kind of
> >> confusing but it does work now. Other D

Re: Druid repo migration plan

[Julian Hyde]

I see there are notifications not just for commits but for every comment on 
every issue. That’s going to be overwhelming. I can’t imagine anyone wanting to 
subscribe to the gitbox list at the current volume.

How about only sending comments to people who have watched a particular case?

Julian


> On Jul 6, 2018, at 1:08 PM, Julian Hyde  wrote:
> 
> I like the idea of a separate list for commits. Keeps the noise down on the 
> dev list.
> 
> Other projects (e.g. calcite) would name that list “commits”, i.e. 
> comm...@druid.apache.org . If you were to 
> add other repos (e.g. a subversion repo for web site) you could send its 
> commits there too.
> 
>> On Jul 6, 2018, at 12:24 PM, Samarth Jain > > wrote:
>> 
>> +1 to sending to git...@druid.apache.org 
>> 
>> On Fri, Jul 6, 2018 at 12:17 PM, Gian Merlino > > wrote:
>> 
>>> The repo move has happened: https://github.com/apache/incubator-druid 
>>> 
>>> 
>>> My understanding is that now we can and should start prepping license,
>>> notice, etc for a release. And also making sure that our integrations still
>>> work right (Travis / TeamCity).
>>> 
>>> Also: does anyone else find the gitbox mails sent to dev@druid.apache.org 
>>> 
>>> annoying? I'm planning to set up a mail filter to put them into another
>>> folder (they're redundant to notifications I already get from GitHub). If
>>> people generally feel the same way we could ask Infra to move them to a
>>> separate mailing list, maybe git...@druid.apache.org 
>>> .
>>> 
>>> On Tue, Jul 3, 2018 at 12:57 PM Gian Merlino >> > wrote:
>>> 
 Here is the ticket, btw: https://issues.apache.org/ 
 
>>> jira/browse/INFRA-16674.
 Repo move should be happening real soon now!
 
 On Mon, Jul 2, 2018 at 11:55 PM Gian Merlino >>> > wrote:
 
> Our infra ticket is progressing along and it looks like we're just about
> ready to pull the trigger on moving the repo. So, committers, please
>>> make
> sure your ASF gitbox stuff is working: https://gitbox.apache.org/setup/ 
> 
> 
> On Fri, Jun 22, 2018 at 1:22 PM Gian Merlino  > wrote:
> 
>> Thanks for the tips, Max!! I think we are, hopefully, doing okay on
>>> some
>> of these. My thoughts inline.
>> 
>>> Since you need elevated rights on both
>> orgs to move the repo (say airbnb and apache) and that both parties
>> aren't
>> ok with that, it's typical to use a middleman org like `apacheinfra`.
>> 
>> Luckily, our org is limited to just Druid stuff (
>> https://github.com/druid-io ) so we should 
>> be OK to add Apache Infra
>> people with elevated rights.
>> 
>>> * make merge hook checks optional, so that if coverage, travis, or
>>> code
>> quality checks do not prevent merging, since it's likely those check
>> won't
>> trigger and as a non-admin you won't be able to force-merge
>> 
>> We have a couple (Travis and TeamCity) and they're already optional.
>> 
>>> * consider unprotecting protected branches so that you can push to
>> master
>> if controlling master is important in your workflow. This way you can
>> effectively merge PRs without clicking the button on GH.
>> 
>> Master _is_ important. Although I think if we can't do PRs, then
>>> pushing
>> directly to master is probably not going to be too helpful anyway (the
>>> PRs
>> are essential to our code review workflow). So I think we have to hope
>>> for
>> the best here?
>> 
>>> * make sure core committers have their Gitbox access setup, I think
>>> it
>> can
>> be a bit tricky and may involve your mentor / infra pulling some levers
>> on
>> whimsy
>> 
>> I went through this process (via https://gitbox.apache.org/setup/ 
>> ) to
>> get the ability to push to
>> https://github.com/apache/incubator-druid-website 
>> , which is powering
>> https://druid.apache.org/ . It took a little 
>> while and was kind of
>> confusing but it does work now. Other Druid committers: sounds like
>>> getting
>> set up on GitBox early is a good thing, so please check it out!
>> 
>> On Fri, Jun 22, 2018 at 11:51 AM Maxime Beauchemin <
>> maximebeauche...@gmail.com > wrote:
>> 
>>> @julian gotcha, I thought this was a more official vote
>>> 
>>> The Superset GH move INFRA ticket shows how the move can be really
>>> tricky/slow/disruptive. There was quite

[incubator-druid] annotated tag druid-0.12.1-iap6 deleted (was db761be)

[gian]

This is an automated email from the ASF dual-hosted git repository.

gian pushed a change to annotated tag druid-0.12.1-iap6
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git.


*** WARNING: tag druid-0.12.1-iap6 was deleted! ***

   tag was  db761be

The revisions that were on this annotated tag are still contained in
other references; therefore, this change does not discard any commits
from the repository.


-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

Re: Druid repo migration plan

[Julian Hyde]

I like the idea of a separate list for commits. Keeps the noise down on the dev 
list.

Other projects (e.g. calcite) would name that list “commits”, i.e. 
comm...@druid.apache.org . If you were to add 
other repos (e.g. a subversion repo for web site) you could send its commits 
there too.

> On Jul 6, 2018, at 12:24 PM, Samarth Jain  wrote:
> 
> +1 to sending to git...@druid.apache.org
> 
> On Fri, Jul 6, 2018 at 12:17 PM, Gian Merlino  wrote:
> 
>> The repo move has happened: https://github.com/apache/incubator-druid
>> 
>> My understanding is that now we can and should start prepping license,
>> notice, etc for a release. And also making sure that our integrations still
>> work right (Travis / TeamCity).
>> 
>> Also: does anyone else find the gitbox mails sent to dev@druid.apache.org
>> annoying? I'm planning to set up a mail filter to put them into another
>> folder (they're redundant to notifications I already get from GitHub). If
>> people generally feel the same way we could ask Infra to move them to a
>> separate mailing list, maybe git...@druid.apache.org.
>> 
>> On Tue, Jul 3, 2018 at 12:57 PM Gian Merlino  wrote:
>> 
>>> Here is the ticket, btw: https://issues.apache.org/
>> jira/browse/INFRA-16674.
>>> Repo move should be happening real soon now!
>>> 
>>> On Mon, Jul 2, 2018 at 11:55 PM Gian Merlino  wrote:
>>> 
 Our infra ticket is progressing along and it looks like we're just about
 ready to pull the trigger on moving the repo. So, committers, please
>> make
 sure your ASF gitbox stuff is working: https://gitbox.apache.org/setup/
 
 On Fri, Jun 22, 2018 at 1:22 PM Gian Merlino  wrote:
 
> Thanks for the tips, Max!! I think we are, hopefully, doing okay on
>> some
> of these. My thoughts inline.
> 
>> Since you need elevated rights on both
> orgs to move the repo (say airbnb and apache) and that both parties
> aren't
> ok with that, it's typical to use a middleman org like `apacheinfra`.
> 
> Luckily, our org is limited to just Druid stuff (
> https://github.com/druid-io) so we should be OK to add Apache Infra
> people with elevated rights.
> 
>> * make merge hook checks optional, so that if coverage, travis, or
>> code
> quality checks do not prevent merging, since it's likely those check
> won't
> trigger and as a non-admin you won't be able to force-merge
> 
> We have a couple (Travis and TeamCity) and they're already optional.
> 
>> * consider unprotecting protected branches so that you can push to
> master
> if controlling master is important in your workflow. This way you can
> effectively merge PRs without clicking the button on GH.
> 
> Master _is_ important. Although I think if we can't do PRs, then
>> pushing
> directly to master is probably not going to be too helpful anyway (the
>> PRs
> are essential to our code review workflow). So I think we have to hope
>> for
> the best here?
> 
>> * make sure core committers have their Gitbox access setup, I think
>> it
> can
> be a bit tricky and may involve your mentor / infra pulling some levers
> on
> whimsy
> 
> I went through this process (via https://gitbox.apache.org/setup/) to
> get the ability to push to
> https://github.com/apache/incubator-druid-website, which is powering
> https://druid.apache.org/. It took a little while and was kind of
> confusing but it does work now. Other Druid committers: sounds like
>> getting
> set up on GitBox early is a good thing, so please check it out!
> 
> On Fri, Jun 22, 2018 at 11:51 AM Maxime Beauchemin <
> maximebeauche...@gmail.com> wrote:
> 
>> @julian gotcha, I thought this was a more official vote
>> 
>> The Superset GH move INFRA ticket shows how the move can be really
>> tricky/slow/disruptive. There was quite a period of instability for us
>> and
>> a lot of slow back and forth with Apache infra. Hopefully the process
>> has
>> been ironed out since then. Be prepared and go into it knowing that
>> you
>> may
>> not be able to merge PRs for days/weeks.
>> https://issues.apache.org/jira/browse/INFRA-14267
>> 
>> On the ticket you open with INFRA, make it really clear what your GH
>> integrations are and validate that they are all approved/supported by
>> Apache prior to the move. Some integrations (like codeclimate) require
>> rights on the GH org (Apache) and INFRA is categoric against that. If
>> some
>> services aren't supported make sure to disable the integrations prior
>> to
>> the move, find replacement services. Also make sure INFRA will
>> adjust/tweak
>> the integration post move as you likely need admin rights to do so.
>> 
>> A caveat is around the "redirect chain" on GH. This is what allows
>> hitting `
>> github.com/airbnb/superset` 

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

[GitBox]

gianm commented on issue #5931: Support limit for timeseries query (#5894)
URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403134175
 
 
   @surekhasaharan The TeamCity error looks legit. It's complaining that this 
method isn't used anymore:
   
   ```
 public static VirtualColumns create(VirtualColumn...virtualColumns)
   ```
   
   It was only used in one place, in a single test in CalciteQueryTest, and 
this patch removes that test. So please remove the method in VirtualColumns as 
well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

[GitBox]

gianm commented on issue #5931: Support limit for timeseries query (#5894)
URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403133666
 
 
   Saw this in travis, restarting.
   
   ```Failed tests: 
 BlockingPoolTest.testConcurrentBatchClose:266 expected:<5> but was:<0>
 BlockingPoolTest.testConcurrentTake:186 expected:<10> but was:<0>
 BlockingPoolTest.testConcurrentTakeBatch:236 expected:<5> but was:<0>
 BlockingPoolTest.testConcurrentTakeBatchClose:319 expected:<10> but was:<0>
 BlockingPoolTest.testTake:77
 BlockingPoolTest.testTakeBatch:97 expected:<6> but was:<0>
   Tests in error: 
 BlockingPoolTest.testWaitAndTakeBatch:106 »  test timed out after 1000 
millise...
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

Re: Druid repo migration plan

[Samarth Jain]

+1 to sending to git...@druid.apache.org

On Fri, Jul 6, 2018 at 12:17 PM, Gian Merlino  wrote:

> The repo move has happened: https://github.com/apache/incubator-druid
>
> My understanding is that now we can and should start prepping license,
> notice, etc for a release. And also making sure that our integrations still
> work right (Travis / TeamCity).
>
> Also: does anyone else find the gitbox mails sent to dev@druid.apache.org
> annoying? I'm planning to set up a mail filter to put them into another
> folder (they're redundant to notifications I already get from GitHub). If
> people generally feel the same way we could ask Infra to move them to a
> separate mailing list, maybe git...@druid.apache.org.
>
> On Tue, Jul 3, 2018 at 12:57 PM Gian Merlino  wrote:
>
> > Here is the ticket, btw: https://issues.apache.org/
> jira/browse/INFRA-16674.
> > Repo move should be happening real soon now!
> >
> > On Mon, Jul 2, 2018 at 11:55 PM Gian Merlino  wrote:
> >
> >> Our infra ticket is progressing along and it looks like we're just about
> >> ready to pull the trigger on moving the repo. So, committers, please
> make
> >> sure your ASF gitbox stuff is working: https://gitbox.apache.org/setup/
> >>
> >> On Fri, Jun 22, 2018 at 1:22 PM Gian Merlino  wrote:
> >>
> >>> Thanks for the tips, Max!! I think we are, hopefully, doing okay on
> some
> >>> of these. My thoughts inline.
> >>>
> >>> > Since you need elevated rights on both
> >>> orgs to move the repo (say airbnb and apache) and that both parties
> >>> aren't
> >>> ok with that, it's typical to use a middleman org like `apacheinfra`.
> >>>
> >>> Luckily, our org is limited to just Druid stuff (
> >>> https://github.com/druid-io) so we should be OK to add Apache Infra
> >>> people with elevated rights.
> >>>
> >>> > * make merge hook checks optional, so that if coverage, travis, or
> code
> >>> quality checks do not prevent merging, since it's likely those check
> >>> won't
> >>> trigger and as a non-admin you won't be able to force-merge
> >>>
> >>> We have a couple (Travis and TeamCity) and they're already optional.
> >>>
> >>> > * consider unprotecting protected branches so that you can push to
> >>> master
> >>> if controlling master is important in your workflow. This way you can
> >>> effectively merge PRs without clicking the button on GH.
> >>>
> >>> Master _is_ important. Although I think if we can't do PRs, then
> pushing
> >>> directly to master is probably not going to be too helpful anyway (the
> PRs
> >>> are essential to our code review workflow). So I think we have to hope
> for
> >>> the best here?
> >>>
> >>> > * make sure core committers have their Gitbox access setup, I think
> it
> >>> can
> >>> be a bit tricky and may involve your mentor / infra pulling some levers
> >>> on
> >>> whimsy
> >>>
> >>> I went through this process (via https://gitbox.apache.org/setup/) to
> >>> get the ability to push to
> >>> https://github.com/apache/incubator-druid-website, which is powering
> >>> https://druid.apache.org/. It took a little while and was kind of
> >>> confusing but it does work now. Other Druid committers: sounds like
> getting
> >>> set up on GitBox early is a good thing, so please check it out!
> >>>
> >>> On Fri, Jun 22, 2018 at 11:51 AM Maxime Beauchemin <
> >>> maximebeauche...@gmail.com> wrote:
> >>>
>  @julian gotcha, I thought this was a more official vote
> 
>  The Superset GH move INFRA ticket shows how the move can be really
>  tricky/slow/disruptive. There was quite a period of instability for us
>  and
>  a lot of slow back and forth with Apache infra. Hopefully the process
>  has
>  been ironed out since then. Be prepared and go into it knowing that
> you
>  may
>  not be able to merge PRs for days/weeks.
>  https://issues.apache.org/jira/browse/INFRA-14267
> 
>  On the ticket you open with INFRA, make it really clear what your GH
>  integrations are and validate that they are all approved/supported by
>  Apache prior to the move. Some integrations (like codeclimate) require
>  rights on the GH org (Apache) and INFRA is categoric against that. If
>  some
>  services aren't supported make sure to disable the integrations prior
> to
>  the move, find replacement services. Also make sure INFRA will
>  adjust/tweak
>  the integration post move as you likely need admin rights to do so.
> 
>  A caveat is around the "redirect chain" on GH. This is what allows
>  hitting `
>  github.com/airbnb/superset`  to
>  redirect to `
>  github.com/apache/incubator-superset`
>   to redirect to the
> right
>  place. This
>  also allows `git remote`s to just work post move. This redirect chain
> is
>  fragile and can break in some cases. Since you need elevated rights on
>  both
>  orgs to move the repo (say airbnb and apache) and that both

Re: Druid repo migration plan

[Gian Merlino]

The repo move has happened: https://github.com/apache/incubator-druid

My understanding is that now we can and should start prepping license,
notice, etc for a release. And also making sure that our integrations still
work right (Travis / TeamCity).

Also: does anyone else find the gitbox mails sent to dev@druid.apache.org
annoying? I'm planning to set up a mail filter to put them into another
folder (they're redundant to notifications I already get from GitHub). If
people generally feel the same way we could ask Infra to move them to a
separate mailing list, maybe git...@druid.apache.org.

On Tue, Jul 3, 2018 at 12:57 PM Gian Merlino  wrote:

> Here is the ticket, btw: https://issues.apache.org/jira/browse/INFRA-16674.
> Repo move should be happening real soon now!
>
> On Mon, Jul 2, 2018 at 11:55 PM Gian Merlino  wrote:
>
>> Our infra ticket is progressing along and it looks like we're just about
>> ready to pull the trigger on moving the repo. So, committers, please make
>> sure your ASF gitbox stuff is working: https://gitbox.apache.org/setup/
>>
>> On Fri, Jun 22, 2018 at 1:22 PM Gian Merlino  wrote:
>>
>>> Thanks for the tips, Max!! I think we are, hopefully, doing okay on some
>>> of these. My thoughts inline.
>>>
>>> > Since you need elevated rights on both
>>> orgs to move the repo (say airbnb and apache) and that both parties
>>> aren't
>>> ok with that, it's typical to use a middleman org like `apacheinfra`.
>>>
>>> Luckily, our org is limited to just Druid stuff (
>>> https://github.com/druid-io) so we should be OK to add Apache Infra
>>> people with elevated rights.
>>>
>>> > * make merge hook checks optional, so that if coverage, travis, or code
>>> quality checks do not prevent merging, since it's likely those check
>>> won't
>>> trigger and as a non-admin you won't be able to force-merge
>>>
>>> We have a couple (Travis and TeamCity) and they're already optional.
>>>
>>> > * consider unprotecting protected branches so that you can push to
>>> master
>>> if controlling master is important in your workflow. This way you can
>>> effectively merge PRs without clicking the button on GH.
>>>
>>> Master _is_ important. Although I think if we can't do PRs, then pushing
>>> directly to master is probably not going to be too helpful anyway (the PRs
>>> are essential to our code review workflow). So I think we have to hope for
>>> the best here?
>>>
>>> > * make sure core committers have their Gitbox access setup, I think it
>>> can
>>> be a bit tricky and may involve your mentor / infra pulling some levers
>>> on
>>> whimsy
>>>
>>> I went through this process (via https://gitbox.apache.org/setup/) to
>>> get the ability to push to
>>> https://github.com/apache/incubator-druid-website, which is powering
>>> https://druid.apache.org/. It took a little while and was kind of
>>> confusing but it does work now. Other Druid committers: sounds like getting
>>> set up on GitBox early is a good thing, so please check it out!
>>>
>>> On Fri, Jun 22, 2018 at 11:51 AM Maxime Beauchemin <
>>> maximebeauche...@gmail.com> wrote:
>>>
 @julian gotcha, I thought this was a more official vote

 The Superset GH move INFRA ticket shows how the move can be really
 tricky/slow/disruptive. There was quite a period of instability for us
 and
 a lot of slow back and forth with Apache infra. Hopefully the process
 has
 been ironed out since then. Be prepared and go into it knowing that you
 may
 not be able to merge PRs for days/weeks.
 https://issues.apache.org/jira/browse/INFRA-14267

 On the ticket you open with INFRA, make it really clear what your GH
 integrations are and validate that they are all approved/supported by
 Apache prior to the move. Some integrations (like codeclimate) require
 rights on the GH org (Apache) and INFRA is categoric against that. If
 some
 services aren't supported make sure to disable the integrations prior to
 the move, find replacement services. Also make sure INFRA will
 adjust/tweak
 the integration post move as you likely need admin rights to do so.

 A caveat is around the "redirect chain" on GH. This is what allows
 hitting `
 github.com/airbnb/superset`  to
 redirect to `
 github.com/apache/incubator-superset`
  to redirect to the right
 place. This
 also allows `git remote`s to just work post move. This redirect chain is
 fragile and can break in some cases. Since you need elevated rights on
 both
 orgs to move the repo (say airbnb and apache) and that both parties
 aren't
 ok with that, it's typical to use a middleman org like `apacheinfra`.
 They
 grant you admin right to that org and you move the repo to there, and
 they
 do the second part. If, post move, the middleman was to fork a repo with
 the same name, or create one, it would break the red

[incubator-druid] branch 0.12.1-iap updated: [maven-release-plugin] prepare for next development iteration

[jihoonson]

This is an automated email from the ASF dual-hosted git repository.

jihoonson pushed a commit to branch 0.12.1-iap
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/0.12.1-iap by this push:
 new 203d5d0  [maven-release-plugin] prepare for next development iteration
203d5d0 is described below

commit 203d5d0528a182709af8be4ce6577532cb31fe57
Author: Jihoon Son 
AuthorDate: Fri Jul 6 12:12:50 2018 -0700

[maven-release-plugin] prepare for next development iteration
---
 api/pom.xml   | 2 +-
 aws-common/pom.xml| 2 +-
 benchmarks/pom.xml| 2 +-
 common/pom.xml| 2 +-
 distribution/pom.xml  | 2 +-
 examples/pom.xml  | 2 +-
 extendedset/pom.xml   | 2 +-
 extensions-contrib/ambari-metrics-emitter/pom.xml | 2 +-
 extensions-contrib/azure-extensions/pom.xml   | 2 +-
 extensions-contrib/cassandra-storage/pom.xml  | 2 +-
 extensions-contrib/cloudfiles-extensions/pom.xml  | 2 +-
 extensions-contrib/distinctcount/pom.xml  | 2 +-
 extensions-contrib/druid-rocketmq/pom.xml | 2 +-
 extensions-contrib/google-extensions/pom.xml  | 2 +-
 extensions-contrib/graphite-emitter/pom.xml   | 2 +-
 extensions-contrib/kafka-eight-simpleConsumer/pom.xml | 2 +-
 extensions-contrib/kafka-emitter/pom.xml  | 2 +-
 extensions-contrib/orc-extensions/pom.xml | 2 +-
 extensions-contrib/parquet-extensions/pom.xml | 2 +-
 extensions-contrib/rabbitmq/pom.xml   | 2 +-
 extensions-contrib/redis-cache/pom.xml| 2 +-
 extensions-contrib/sqlserver-metadata-storage/pom.xml | 2 +-
 extensions-contrib/statsd-emitter/pom.xml | 2 +-
 extensions-contrib/thrift-extensions/pom.xml  | 2 +-
 extensions-contrib/time-min-max/pom.xml   | 2 +-
 extensions-contrib/virtual-columns/pom.xml| 2 +-
 extensions-core/avro-extensions/pom.xml   | 2 +-
 extensions-core/datasketches/pom.xml  | 2 +-
 extensions-core/druid-basic-security/pom.xml  | 2 +-
 extensions-core/druid-kerberos/pom.xml| 2 +-
 extensions-core/hdfs-storage/pom.xml  | 2 +-
 extensions-core/histogram/pom.xml | 2 +-
 extensions-core/kafka-eight/pom.xml   | 2 +-
 extensions-core/kafka-extraction-namespace/pom.xml| 2 +-
 extensions-core/kafka-indexing-service/pom.xml| 2 +-
 extensions-core/lookups-cached-global/pom.xml | 2 +-
 extensions-core/lookups-cached-single/pom.xml | 2 +-
 extensions-core/mysql-metadata-storage/pom.xml| 2 +-
 extensions-core/postgresql-metadata-storage/pom.xml   | 2 +-
 extensions-core/protobuf-extensions/pom.xml   | 2 +-
 extensions-core/s3-extensions/pom.xml | 2 +-
 extensions-core/simple-client-sslcontext/pom.xml  | 2 +-
 extensions-core/stats/pom.xml | 2 +-
 hll/pom.xml   | 2 +-
 indexing-hadoop/pom.xml   | 2 +-
 indexing-service/pom.xml  | 2 +-
 integration-tests/pom.xml | 2 +-
 java-util/pom.xml | 2 +-
 pom.xml   | 4 ++--
 processing/pom.xml| 2 +-
 server/pom.xml| 2 +-
 services/pom.xml  | 2 +-
 sql/pom.xml   | 2 +-
 53 files changed, 54 insertions(+), 54 deletions(-)

diff --git a/api/pom.xml b/api/pom.xml
index b59d07f..7d6e8fd 100644
--- a/api/pom.xml
+++ b/api/pom.xml
@@ -28,7 +28,7 @@
 
 io.druid
 druid
-0.12.1-iap6
+0.12.1-iap7-SNAPSHOT
 
 
 
diff --git a/aws-common/pom.xml b/aws-common/pom.xml
index 824a2ad..cea43bd 100644
--- a/aws-common/pom.xml
+++ b/aws-common/pom.xml
@@ -26,7 +26,7 @@
 
 io.druid
 druid
-0.12.1-iap6
+0.12.1-iap7-SNAPSHOT
 
 
 
diff --git a/benchmarks/pom.xml b/benchmarks/pom.xml
index da8f63f..bf44262 100644
--- a/benchmarks/pom.xml
+++ b/benchmarks/pom.xml
@@ -27,7 +27,7 @@
   
 io.druid
 druid
-0.12.1-iap6
+0.12.1-iap7-SNAPSHOT
   
 
   
diff --git a/common/pom.xml b/common/pom.xml
index 8aacc42..cba083c 100644
--- a/common/pom.xml
+++ b/common/pom.xml
@@ -26,7 +26,7 @@
 
 io.druid
 druid
-0.12.1-iap6
+0.12.1-iap7-SNAPSHOT
 
 
 
diff --git a/distribution/pom.xml b/distribution/pom.xml
index a8b45e6..8a49a3e 100644
--- a/distribution/pom.xml
+++ b/distribution/pom.xml
@@ -28,7 +2

[incubator-druid] annotated tag druid-0.12.1-iap6 updated (ec62856 -> db761be)

[jihoonson]

This is an automated email from the ASF dual-hosted git repository.

jihoonson pushed a change to annotated tag druid-0.12.1-iap6
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git.


*** WARNING: tag druid-0.12.1-iap6 was modified! ***

from ec62856  (commit)
  to db761be  (tag)
 tagging ec62856638c0739dc58dbf2b25e5211801aa8c51 (commit)
 replaces druid-0.12.1
  by Jihoon Son
  on Fri Jul 6 12:12:44 2018 -0700

- Log -
[maven-release-plugin] copy for tag druid-0.12.1-iap6
---


No new revisions were added by this update.

Summary of changes:


-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[incubator-druid] branch 0.12.1-iap created (now ec62856)

[jihoonson]

This is an automated email from the ASF dual-hosted git repository.

jihoonson pushed a change to branch 0.12.1-iap
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git.


  at ec62856  [maven-release-plugin] prepare release druid-0.12.1-iap6

No new revisions were added by this update.


-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

[GitBox]

gianm commented on issue #5931: Support limit for timeseries query (#5894)
URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403122325
 
 
   LGTM, trying to re-run the checks (they lost track of what repo we were on)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] surekhasaharan opened a new pull request #5931: Support limit for timeseries query (#5894)

[GitBox]

surekhasaharan opened a new pull request #5931: Support limit for timeseries 
query (#5894)
URL: https://github.com/apache/incubator-druid/pull/5931
 
 
   Added limit param to `TimeseriesQuery` and support to limit results in 
`TimeseriesQueryQueryToolChest.mergeResults` and `TimeseriesQueryEngine`.
   Fixed unit tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] nishantmonu51 commented on issue #5452: SQL compatible Null Handling Part 2 - Processing Layer and Druid-SQL changes

[GitBox]

nishantmonu51 commented on issue #5452: SQL compatible Null Handling Part 2 - 
Processing Layer and Druid-SQL changes
URL: https://github.com/apache/incubator-druid/pull/5452#issuecomment-403121854
 
 
   Closing in favor of https://github.com/apache/incubator-druid/pull/5958


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling

[GitBox]

nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible 
Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-403121757
 
 
   @leventov : Created a new PR, please review. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] nishantmonu51 opened a new pull request #5958: Part 2 of changes for SQL Compatible Null Handling

[GitBox]

nishantmonu51 opened a new pull request #5958: Part 2 of changes for SQL 
Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958
 
 
   Part 2 of changes for SQL Compatible Null Handling - 
   This PR contains changes to improve handling of null values in druid by 
treating nulls as missing values which don’t actually exist. This will make it 
more compatible to SQL standard and help with integration with other existing 
BI systems which support ODBC/JDBC. (Detailed description in proposal - 
https://github.com/druid-io/druid/issues/4349)
   
   ## Nullability for Aggregators/Metrics
   
   As per the current implementation, most aggregators are coded to replace 
null values with default e.g. sum treats them as zeroes, min treats them as 
positive infinity, etc.
   To match the new semantics and make aggregators nullable, where if an 
aggregator encounters only the null values the result will be null value 
following changes are made -
   
   * Aggrgator/BufferAggregator - Added a new method boolean isNull() which 
returns false by default. aggregators that support nullability can choose to 
override this and return true if the aggregated result is null. 
   * Added a NullableAggregator/NullableBufferAggregator which is be used as a 
decorator for existing aggregator implementations to make them nullable. This 
will return null values if all the values aggregated are null, If any of the 
aggregated value is non-null, it will have same behavior as the delegate 
aggregator. 
   * If new null behavior is enabled, aggregator factories will decorate the 
aggregators with NullableAggregator/NullableBufferAggregator. 
   * Added a new abstract class NullableAggregatorFactory which helps in 
reducing duplicate code and decide to switch between nullable and non-nullable 
aggregators. 
   * Cardinality and HyperUnique  aggregators ignore null values and only count 
non-null values, If all the encountered values are null, the result will be 0. 
This is different from current behavior where null values are also counted.
   * Count aggregator - since count aggregator is not associated with any 
column and just a count of the number of rows, it has the same behavior as 
before. 
   
   ## Math Expressions Null Handling
   * For general calculations like sum, full expression is be considered as 
null if any of the components is null. 
   * StringLiteral now supports null and and expressions containing non-quoted 
null is parsed as StringLiteral with null 
   * Specifying a default value for null is supported by the use of NVL or IF 
clause to assign default values at query time.
   
   ## Filtering on Null values
   * SelectorDimFilter currently specifies filtering on null values but the 
implementation assumes null and empty strings as equivalent. The implementation 
is changed to consider null and empty string differently. Generation of cache 
key for selectorDimFilter is also modified to support null.
   * InFilter/ExpressionFilter/LikeFilter are also modified to not treat nulls 
as empty strings. 
   
   ## Changes to Druid build-in SQL layer
   * NULL and empty strings are treated differently. 
   * IS NULL and IS NOT NULL filters against null values instead of empty 
strings. 
   * NVL, IFNULL and COALESCE work as per SQL standard. 
   * count now skips null values and works as per SQL standard. 
   
   ## Backwards Compatibility 
   * **_"druid.generic.useDefaultValueForNull"_** is added as a new config. The 
default value is set to true for backwards compatibility. 
   *  code places in query/ingestion where we converted emptyToNull or 
nullToEmpty now use NullHandlingHelper which only does the conversion if 
backwards compatibility is enabled. 
   * Storage layer changes are backwards compatible for GenericIndexed/String 
columns. 
   * For Numeric columns new V2 serde implementations are introduced which also 
supports serde of nullRowsBitmaps. Previous implementations are kept unchanged 
to read any existing segments. 
   
   ## Testing 
   * Most of the unit tests that tested nulls are modified to have two branches 
of expected results to test new/old behavior both. 
   * For CI have added new runs to test matrix to test new behavior for nulls. 
   * To run the tests with new behavior run 
**_"-Ddruid.generic.useDefaultValueForNull=false"_**
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org

[GitHub] MTShannon commented on issue #2788: Jackson 2.4.6 incompatible with HDP 2.4

[GitBox]

MTShannon commented on issue #2788: Jackson 2.4.6 incompatible with HDP 2.4
URL: 
https://github.com/apache/incubator-druid/issues/2788#issuecomment-403099742
 
 
   @santhoshtangudu How did you stop passing multiple versions?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org