Re: [VOTE]: Release Apache dubbo-go v3.0.0

2021-12-20 Thread YunKun Huang
+1

* Release note looks good to me
* Git tag is correct
* Integration test works on my PC

On Mon, Dec 20, 2021 at 5:50 PM Jun Liu  wrote:
>
> +1 binding
>
> * LICENSE and NOTICE exist and contents are good
> * Signature and hash are good
> * Tag and hash can match
> * The samples I checked can run on with this RC on my Mac.
> * Release notes look fine
>
> Jun
>
> > On Dec 12, 2021, at 3:17 PM, Laurence  wrote:
> >
> > Hello Dubbo/Dubbogo Community,
> >
> >  This is a call for vote to release Apache dubbo-go version v3.0.0
> >
> >  The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0
> >
> >  Git tag for the
> > release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0
> >
> >  Hash for the release tag: 0ff42cebbe0d7722cedde8a9ceefeb66d644360e
> >
> >  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
> >
> >  The artifacts have been signed with Key :
> > B621FD9A0A7266FEC7AFBB584021F24691FF9300, which can be
> > found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> >  The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo-go Team
>


Re: [VOTE]: Release Apache dubbo-go v3.0.0

2021-12-20 Thread Jun Liu
+1 binding

* LICENSE and NOTICE exist and contents are good
* Signature and hash are good
* Tag and hash can match
* The samples I checked can run on with this RC on my Mac.
* Release notes look fine

Jun

> On Dec 12, 2021, at 3:17 PM, Laurence  wrote:
> 
> Hello Dubbo/Dubbogo Community,
> 
>  This is a call for vote to release Apache dubbo-go version v3.0.0
> 
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0
> 
>  Git tag for the
> release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0
> 
>  Hash for the release tag: 0ff42cebbe0d7722cedde8a9ceefeb66d644360e
> 
>  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
> 
>  The artifacts have been signed with Key :
> B621FD9A0A7266FEC7AFBB584021F24691FF9300, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> 
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> 
> 
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Dubbo-go Team



Re: [VOTE]: Release Apache dubbo-go v3.0.0

2021-12-19 Thread stocks alex
+1 (binding) .

I checked the following items.

[v]  Are release files in the correct location?
[v] Are the digital signatures and hashes correct?
[v] Do LICENSE and NOTICE files exist?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?

Laurence  于2021年12月12日周日 15:18写道:

> Hello Dubbo/Dubbogo Community,
>
>   This is a call for vote to release Apache dubbo-go version v3.0.0
>
>   The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0
>
>   Git tag for the
> release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0
>
>   Hash for the release tag: 0ff42cebbe0d7722cedde8a9ceefeb66d644360e
>
>   Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
>
>   The artifacts have been signed with Key :
> B621FD9A0A7266FEC7AFBB584021F24691FF9300, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>   The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


[VOTE]: Release Apache dubbo-go v3.0.0

2021-12-11 Thread Laurence
Hello Dubbo/Dubbogo Community,

  This is a call for vote to release Apache dubbo-go version v3.0.0

  The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0

  Git tag for the
release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0

  Hash for the release tag: 0ff42cebbe0d7722cedde8a9ceefeb66d644360e

  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md

  The artifacts have been signed with Key :
B621FD9A0A7266FEC7AFBB584021F24691FF9300, which can be
found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS

  The vote will be open for at least 72 hours or until necessary number of
votes are reached.


 Please vote accordingly:
 [ ] +1 approve
 [ ] +0 no opinion
 [ ] -1 disapprove with the reason

 Thanks,
 The Apache Dubbo-go Team


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc3

2021-11-01 Thread Albumen Kevin
+1 binding

I have checked:
* Hash and signature are good
* Unit tests passed
* LICENSE and NOTICE are good

On Mon, Nov 1, 2021 at 1:15 PM stocks alex  wrote:

>  +1 approve
>
> I have checked the following items.
>
> [v]  Are release files in correct location?
> [v] Are the digital signature and hashes correct?
> [v] Do LICENSE and NOTICE files exists?
> [v] Is the LICENSE and NOTICE text correct?
> [v] Is the NOTICE year correct?
> [x] Un-included software dependencies are not mentioned in LICENSE or
> NOTICE?
> [x] License information is not mentioned in NOTICE?
> [x] Are there any unexpected binary files in the release?
>
> joezou  于2021年11月1日周一 上午10:41写道:
>
> > +1 binding
> >
> > Checked
> > [√] All uts passed.
> > [√] CHANGE.md .
> > [√] License headers .
> > [√] Download links are fine.
> >
> > BTW,you should make a pre-release version for this tag.
> >
> > Laurence  于2021年10月31日周日 下午2:22写道:
> >
> > > Hello Dubbo/Dubbogo Community,
> > >
> > >   This is a call for vote to release Apache dubbo-go version v3.0.0-rc3
> > >
> > >   The release candidates:
> > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc3/
> > >
> > >   Git tag for the
> > > release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc3
> > >
> > >   Hash for the release tag: 669ab0ab3b5f386f339d7b94bb804ec7db753ed6
> > >
> > >   Release Notes:
> > https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
> > >
> > >   The artifacts have been signed with Key : 0E60D42F148E3CD1, which can
> > be
> > > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> > >
> > >   The vote will be open for at least 72 hours or until necessary number
> > of
> > > votes are reached.
> > >
> > >
> > >  Please vote accordingly:
> > >  [ ] +1 approve
> > >  [ ] +0 no opinion
> > >  [ ] -1 disapprove with the reason
> > >
> > >  Thanks,
> > >  The Apache Dubbo-go Team
> > >
> >
>


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc3

2021-10-31 Thread stocks alex
 +1 approve

I have checked the following items.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Are there any unexpected binary files in the release?

joezou  于2021年11月1日周一 上午10:41写道:

> +1 binding
>
> Checked
> [√] All uts passed.
> [√] CHANGE.md .
> [√] License headers .
> [√] Download links are fine.
>
> BTW,you should make a pre-release version for this tag.
>
> Laurence  于2021年10月31日周日 下午2:22写道:
>
> > Hello Dubbo/Dubbogo Community,
> >
> >   This is a call for vote to release Apache dubbo-go version v3.0.0-rc3
> >
> >   The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc3/
> >
> >   Git tag for the
> > release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc3
> >
> >   Hash for the release tag: 669ab0ab3b5f386f339d7b94bb804ec7db753ed6
> >
> >   Release Notes:
> https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
> >
> >   The artifacts have been signed with Key : 0E60D42F148E3CD1, which can
> be
> > found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> >   The vote will be open for at least 72 hours or until necessary number
> of
> > votes are reached.
> >
> >
> >  Please vote accordingly:
> >  [ ] +1 approve
> >  [ ] +0 no opinion
> >  [ ] -1 disapprove with the reason
> >
> >  Thanks,
> >  The Apache Dubbo-go Team
> >
>


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc3

2021-10-31 Thread joezou
+1 binding

Checked
[√] All uts passed.
[√] CHANGE.md .
[√] License headers .
[√] Download links are fine.

BTW,you should make a pre-release version for this tag.

Laurence  于2021年10月31日周日 下午2:22写道:

> Hello Dubbo/Dubbogo Community,
>
>   This is a call for vote to release Apache dubbo-go version v3.0.0-rc3
>
>   The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc3/
>
>   Git tag for the
> release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc3
>
>   Hash for the release tag: 669ab0ab3b5f386f339d7b94bb804ec7db753ed6
>
>   Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
>
>   The artifacts have been signed with Key : 0E60D42F148E3CD1, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>   The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


[VOTE]: Release Apache dubbo-go v3.0.0-rc3

2021-10-31 Thread Laurence
Hello Dubbo/Dubbogo Community,

  This is a call for vote to release Apache dubbo-go version v3.0.0-rc3

  The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc3/

  Git tag for the
release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc3

  Hash for the release tag: 669ab0ab3b5f386f339d7b94bb804ec7db753ed6

  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md

  The artifacts have been signed with Key : 0E60D42F148E3CD1, which can be
found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS

  The vote will be open for at least 72 hours or until necessary number of
votes are reached.


 Please vote accordingly:
 [ ] +1 approve
 [ ] +0 no opinion
 [ ] -1 disapprove with the reason

 Thanks,
 The Apache Dubbo-go Team


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc2

2021-07-01 Thread Laurence
 Hello Dubbo Community,

I am glad to announce that Apache Dubbo-go 3.0.0-rc2 was released.

You can check detailed release notes here:
https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc2

If you have any questions using this version, please send mail to here or
report the issue  on Github.

Best regards,
Dubbo Team

Jun Liu  于2021年6月28日周一 下午5:26写道:

> +1 binding
>
> I checked:
> * Signature and hash are good
> * LICENSE and NOTICE exist
> * Release note looks fine
> * Can compile from source
>
> Jun
>
> > On Jun 21, 2021, at 11:57 AM, Laurence  wrote:
> >
> > Hello Dubbo/Dubbogo Community,
> >
> >  This is a call for vote to release Apache dubbo-go version v3.0.0-rc2.
> >
> >  The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc2/
> >
> >  Git tag for the
> > release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc2
> >
> >  Hash for the release tag:  ca2a46f8dfb22e1c02fbfe2a3695356429525d09
> >
> >  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
> >
> >  The artifacts have been signed with Key : 9E35BEAEF085ED25, which can be
> > found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> >  The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo-go Team
>
>


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc2

2021-06-28 Thread Jun Liu
+1 binding

I checked:
* Signature and hash are good
* LICENSE and NOTICE exist
* Release note looks fine
* Can compile from source

Jun

> On Jun 21, 2021, at 11:57 AM, Laurence  wrote:
> 
> Hello Dubbo/Dubbogo Community,
> 
>  This is a call for vote to release Apache dubbo-go version v3.0.0-rc2.
> 
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc2/
> 
>  Git tag for the
> release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc2
> 
>  Hash for the release tag:  ca2a46f8dfb22e1c02fbfe2a3695356429525d09
> 
>  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
> 
>  The artifacts have been signed with Key : 9E35BEAEF085ED25, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> 
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> 
> 
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Dubbo-go Team



Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc2

2021-06-25 Thread stocks alex
+1(binding) to approve this release. As usual, I have checked the following
items:

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?

Howver, @Laurance, pls checks the following questions.

* 1 the shorter receiver name of AttachmentMatchJudger in
router/v3router/judger/attachment_match_judger.go should not be 'amj'. Just
one character should be enough. The same problem exists in the following
items too.
 router/v3router/judger/bool_match_judger.go BoolMathJudger
 router/v3router/judger/double_match_judger.go DoubleMatchJudger

 router/v3router/judger/double_range_match_judger.go DoubleRangeMatchJudger

 router/v3router/judger/list_double_match_judger.go ListDoubleMatchJudger

 router/v3router/judger/list_string_match_judger.go ListStringMatchJudger
 router/v3router/judger/method_match_judger.go MethodMatchJudger
 router/v3router/judger/string_match_judger.go StringMatchJudger
 router/v3router/dubbo_rule.go DubboRouterRule

Pls fix this problem in the following publish edition.

joezou  于2021年6月24日周四 上午12:23写道:

> +1 binding
>
> Checked
> [√] All uts passed.
> [√] CHANGE.md .
> [√] License headers .
> [√] Download links are fine.
>
> Laurence  于2021年6月21日周一 上午11:58写道:
>
> >  Hello Dubbo/Dubbogo Community,
> >
> >   This is a call for vote to release Apache dubbo-go version v3.0.0-rc2.
> >
> >   The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc2/
> >
> >   Git tag for the
> > release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc2
> >
> >   Hash for the release tag:  ca2a46f8dfb22e1c02fbfe2a3695356429525d09
> >
> >   Release Notes:
> https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
> >
> >   The artifacts have been signed with Key : 9E35BEAEF085ED25, which can
> be
> > found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> >   The vote will be open for at least 72 hours or until necessary number
> of
> > votes are reached.
> >
> >
> >  Please vote accordingly:
> >  [ ] +1 approve
> >  [ ] +0 no opinion
> >  [ ] -1 disapprove with the reason
> >
> >  Thanks,
> >  The Apache Dubbo-go Team
> >
>


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc2

2021-06-23 Thread joezou
+1 binding

Checked
[√] All uts passed.
[√] CHANGE.md .
[√] License headers .
[√] Download links are fine.

Laurence  于2021年6月21日周一 上午11:58写道:

>  Hello Dubbo/Dubbogo Community,
>
>   This is a call for vote to release Apache dubbo-go version v3.0.0-rc2.
>
>   The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc2/
>
>   Git tag for the
> release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc2
>
>   Hash for the release tag:  ca2a46f8dfb22e1c02fbfe2a3695356429525d09
>
>   Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md
>
>   The artifacts have been signed with Key : 9E35BEAEF085ED25, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>   The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


[VOTE]: Release Apache dubbo-go v3.0.0-rc2

2021-06-20 Thread Laurence
 Hello Dubbo/Dubbogo Community,

  This is a call for vote to release Apache dubbo-go version v3.0.0-rc2.

  The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc2/

  Git tag for the
release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc2

  Hash for the release tag:  ca2a46f8dfb22e1c02fbfe2a3695356429525d09

  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGELOG.md

  The artifacts have been signed with Key : 9E35BEAEF085ED25, which can be
found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS

  The vote will be open for at least 72 hours or until necessary number of
votes are reached.


 Please vote accordingly:
 [ ] +1 approve
 [ ] +0 no opinion
 [ ] -1 disapprove with the reason

 Thanks,
 The Apache Dubbo-go Team


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc1

2021-05-24 Thread laurence.apache
 Hello Dubbo/Dubbogo Community,

The release Apache dubbo-go version v3.0.0-rc1 vote finished, We’ve
received 3
+1
(binding) votes.

+1 binding, Stocks Alex
+1 binding, Joezou
+1 binding, Jun Liu

The vote and result thread:
https://lists.apache.org/thread.html/r27b4ac3a303f1322a46e86126282eefa6d6df5c7a89b3b75047dd1ef%40%3Cdev.dubbo.apache.org%3E


The vote passed. Thanks all.
I will proceed with the formal release later.


Best regards,

The Apache Dubbogo Team


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc1

2021-05-20 Thread joezou
+1 binding

Checked
[√] All uts passed.
[√] CHANGE.md .
[√] License headers .
[√] Download links are fine.

Jun Liu  于2021年5月19日周三 上午10:09写道:

> +1 binding
>
> Excited to see the first 3.0 golang version is about to release. I guess
>
> I checked,
>  * Signature and hash are good
>  * LICENSE and NOTICE exist
>  * Embedded test can run with client successfully calling server
>
> Jun
>
> > On May 16, 2021, at 11:06 AM, Laurence Lee 
> wrote:
> >
> > Hello Dubbo/Dubbogo Community,
> >
> >  This is a call for vote to release Apache dubbo-go version v3.0.0-rc1.
> >
> >  The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc1/
> >
> >  Git tag for the
> > release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc1
> >
> >  Hash for the release tag:  4cb6e4401b788d1088058cc7ca2d9bb205d2d261
> >
> >  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGE.md
> >
> >  The artifacts have been signed with Key : 9E35BEAEF085ED25, which can be
> > found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> >  The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo-go Team
>
>


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc1

2021-05-18 Thread Jun Liu
+1 binding

Excited to see the first 3.0 golang version is about to release. I guess 

I checked,
 * Signature and hash are good
 * LICENSE and NOTICE exist
 * Embedded test can run with client successfully calling server

Jun

> On May 16, 2021, at 11:06 AM, Laurence Lee  wrote:
> 
> Hello Dubbo/Dubbogo Community,
> 
>  This is a call for vote to release Apache dubbo-go version v3.0.0-rc1.
> 
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc1/
> 
>  Git tag for the
> release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc1
> 
>  Hash for the release tag:  4cb6e4401b788d1088058cc7ca2d9bb205d2d261
> 
>  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGE.md
> 
>  The artifacts have been signed with Key : 9E35BEAEF085ED25, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> 
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> 
> 
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Dubbo-go Team



Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc1

2021-05-16 Thread stocks alex
Hi,

+1 approve.

Besides all uts and dubbo-go-samples which has passed by github actions. I
checked:

[v]  Are release files in correct location?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?

Albumen Kevin  于2021年5月16日周日 下午2:28写道:

> Hi,
>
> I vote +1 non-binding
>
> I checked:
> - Signatures and hashes are fine
> - Do LICENSE and NOTICE files exists
> - Is the LICENSE and NOTICE text correct?
> - Is the NOTICE year correct?
> - Are release files in the correct location?
>
> I have also found that there are some minor issues.
> - This voting mail is not mailed by Apache Mail.
> - KEYS file contains two duplicated signatures (for key 9E35BEAEF085ED25)
>
> [1] https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> Thanks,
> Albumen Kevin
>
>
> On Sun, May 16, 2021 at 11:06 AM Laurence Lee 
> wrote:
>
> >  Hello Dubbo/Dubbogo Community,
> >
> >   This is a call for vote to release Apache dubbo-go version v3.0.0-rc1.
> >
> >   The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc1/
> >
> >   Git tag for the
> > release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc1
> >
> >   Hash for the release tag:  4cb6e4401b788d1088058cc7ca2d9bb205d2d261
> >
> >   Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGE.md
> >
> >   The artifacts have been signed with Key : 9E35BEAEF085ED25, which can
> be
> > found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> >   The vote will be open for at least 72 hours or until necessary number
> of
> > votes are reached.
> >
> >
> >  Please vote accordingly:
> >  [ ] +1 approve
> >  [ ] +0 no opinion
> >  [ ] -1 disapprove with the reason
> >
> >  Thanks,
> >  The Apache Dubbo-go Team
> >
>


Re: [VOTE]: Release Apache dubbo-go v3.0.0-rc1

2021-05-16 Thread Albumen Kevin
Hi,

I vote +1 non-binding

I checked:
- Signatures and hashes are fine
- Do LICENSE and NOTICE files exists
- Is the LICENSE and NOTICE text correct?
- Is the NOTICE year correct?
- Are release files in the correct location?

I have also found that there are some minor issues.
- This voting mail is not mailed by Apache Mail.
- KEYS file contains two duplicated signatures (for key 9E35BEAEF085ED25)

[1] https://dist.apache.org/repos/dist/dev/dubbo/KEYS

Thanks,
Albumen Kevin


On Sun, May 16, 2021 at 11:06 AM Laurence Lee 
wrote:

>  Hello Dubbo/Dubbogo Community,
>
>   This is a call for vote to release Apache dubbo-go version v3.0.0-rc1.
>
>   The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc1/
>
>   Git tag for the
> release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc1
>
>   Hash for the release tag:  4cb6e4401b788d1088058cc7ca2d9bb205d2d261
>
>   Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGE.md
>
>   The artifacts have been signed with Key : 9E35BEAEF085ED25, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>   The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


[VOTE]: Release Apache dubbo-go v3.0.0-rc1

2021-05-15 Thread Laurence Lee
 Hello Dubbo/Dubbogo Community,

  This is a call for vote to release Apache dubbo-go version v3.0.0-rc1.

  The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.0.0-rc1/

  Git tag for the
release:https://github.com/apache/dubbo-go/releases/tag/v3.0.0-rc1

  Hash for the release tag:  4cb6e4401b788d1088058cc7ca2d9bb205d2d261

  Release Notes: https://github.com/apache/dubbo-go/blob/3.0/CHANGE.md

  The artifacts have been signed with Key : 9E35BEAEF085ED25, which can be
found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS

  The vote will be open for at least 72 hours or until necessary number of
votes are reached.


 Please vote accordingly:
 [ ] +1 approve
 [ ] +0 no opinion
 [ ] -1 disapprove with the reason

 Thanks,
 The Apache Dubbo-go Team