Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[jun liu]

> Using "I think we should ..." rather than "We plan..." (or something
> along those lines) would make it clearer that it was your
> idea/suggestion rather than a community decision.

My apologies for the misleading and English fluency. 

BTW, the discussion has started in Dubbo community:
https://lists.apache.org/thread.html/e871b5fc5bac3c588514e6cf57f3520b16c088ca1ed483f0ffe582fb@%3Cdev.dubbo.apache.org%3E
 


Best regards,
Jun

> On 22 May 2018, at 4:45 PM, Mark Thomas  wrote:
> 
> On 22/05/18 02:53, Jun Liu wrote:
>>> Where did the community discuss this? I'd expect to see a discussion on
>>> a mailing list before a decision is announced.
>> 
>> Haven’t discussed yet, i will start one now.
> 
> Ah. OK. Just a phrasing issue then. No problem.
> 
> Using "I think we should ..." rather than "We plan..." (or something
> along those lines) would make it clearer that it was your
> idea/suggestion rather than a community decision.
> 
> Mark
> 
>> 
>> Best regards,
>> Jun
>> 
>>> On 22 May 2018, at 2:15 AM, Mark Thomas  wrote:
>>> 
>>> On 21/05/18 07:32, Jun Liu wrote:
>>> 
>>> 
>>> 
 we plan to solve this problem and start a new round of voting.
>>> 
>>> Where did the community discuss this? I'd expect to see a discussion on
>>> a mailing list before a decision is announced.
>>> 
>>> Mark
>> 
> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Mark Thomas]

On 22/05/18 02:53, Jun Liu wrote:
>> Where did the community discuss this? I'd expect to see a discussion on
>> a mailing list before a decision is announced.
> 
> Haven’t discussed yet, i will start one now.

Ah. OK. Just a phrasing issue then. No problem.

Using "I think we should ..." rather than "We plan..." (or something
along those lines) would make it clearer that it was your
idea/suggestion rather than a community decision.

Mark

> 
> Best regards,
> Jun
> 
>> On 22 May 2018, at 2:15 AM, Mark Thomas  wrote:
>>
>> On 21/05/18 07:32, Jun Liu wrote:
>>
>> 
>>
>>> we plan to solve this problem and start a new round of voting.
>>
>> Where did the community discuss this? I'd expect to see a discussion on
>> a mailing list before a decision is announced.
>>
>> Mark
> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Mark Thomas]

On 21/05/18 07:32, Jun Liu wrote:



> we plan to solve this problem and start a new round of voting.

Where did the community discuss this? I'd expect to see a discussion on
a mailing list before a decision is announced.

Mark

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Jun Liu]

> 1. there is bunch of dubbo-2.6.2-SNAPSHOT  in the pom.xml file, I guess the
> maven release plugin doesn't take all of them.
> .//bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
> .//dependencies-bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
> .//distribution/pom.xml:2.6.2-SNAPSHOT-SNAPSHOT
> .//pom.xml:  dubbo-2.6.2-SNAPSHOT
> 
> 2. I checked the source zip[1], it is not same with github tag one[2].
> There are some log files and empty directories which is not in the git
> repo, I guess it relates to the builder's workspace.
> It could be addressed by generate the source release kit in the
> distribution like we did here[3].

We rely on the release and assembly plugin to finish these works, there may 
have some inappropriate plugin configuration. I will check the problems you 
mentioned and fix them by following your guides.

> 3. I tried to build the source from kit, it looks the check style is
> enabled when since JDK 1.8 and I just got the out of memory error there.
> I found there are comment about this check style issue (it takes lots of
> time and it doesn't work on my box). So I created an issue[4] of it.
> I can build the source by modify the pom to skip the check style check, but
> it kind of hiking , so I had to vote -1 (binding) for it.

During the internal dubbo community vote, Justin, Huxing and Ian also reported 
the checkstyle plugin problem (cost time and resources) when build. Since this 
problem has confused you and maybe others from building the source, we plan to 
solve this problem and start a new round of voting.
 
> 4. I checked the binary kit, it only includes the jars file of dubbo[5], as
> we cannot provide the apache maven release now, it could cause some trouble
> for the user to consume the binary without third party dependencies. Do we
> have any plan for it ?

Besides the apache binary release, we will also publish the convenient maven 
artifacts to the central maven repository, which are not mentioned in this vote 
thread since it’s not a necessary part of the apache release. This way, users 
can consume from the central repository as before. 
In the next release, when the groupid change to “org.apache.dubbo”, we will 
switch from central maven repository to apache maven repository, and will 
include the apache maven staging repo address in the vote. The current binary 
zip, as you point out "only includes the jars file of dubbo[5]”, will be 
removed or replaced with more meaningful bin release, such as samples or quick 
start guides which users can help users start the journey of dubbo quickly.

To conclude, we decide to start a new round of voting regarding the problems 
found during this round. Thanks for the vote.

Best regards,
Jun

> On 21 May 2018, at 10:34 AM, Willem Jiang  wrote:
> 
> Hi,
> 
> I did some check on the source zip and binary zip, the License and Notice
> files looks good. But I also found some issues here.
> As I cannot build the binary without doing some changes on the pom file, I
> had to vote -1 (binding) here.
> 
> Here are the issues that I found:
> 
> 1. there is bunch of dubbo-2.6.2-SNAPSHOT  in the pom.xml file, I guess the
> maven release plugin doesn't take all of them.
> .//bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
> .//dependencies-bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
> .//distribution/pom.xml:2.6.2-SNAPSHOT-SNAPSHOT
> .//pom.xml:  dubbo-2.6.2-SNAPSHOT
> 
> 2. I checked the source zip[1], it is not same with github tag one[2].
> There are some log files and empty directories which is not in the git
> repo, I guess it relates to the builder's workspace.
> It could be addressed by generate the source release kit in the
> distribution like we did here[3].
> BTW, it's quite important that every one can build the kit by following the
> instruction. I didn't found the instruction file from the README.
> 
> 3. I tried to build the source from kit, it looks the check style is
> enabled when since JDK 1.8 and I just got the out of memory error there.
> I found there are comment about this check style issue (it takes lots of
> time and it doesn't work on my box). So I created an issue[4] of it.
> I can build the source by modify the pom to skip the check style check, but
> it kind of hiking , so I had to vote -1 (binding) for it.
> 
> 4. I checked the binary kit, it only includes the jars file of dubbo[5], as
> we cannot provide the apache maven release now, it could cause some trouble
> for the user to consume the binary without third party dependencies. Do we
> have any plan for it ?
> 
> Another tip for the release check is running some applications which is
> build on the top of the framework to make sure all the distribution is good.
> 
> 
> [1]
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/dubbo-incubating-2.6.2-source-release.zip
> [2]https://github.com/apache/incubator-dubbo/archive/dubbo-2.6.2.zip
> [3]
> 

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Willem Jiang]

Hi,

I did some check on the source zip and binary zip, the License and Notice
files looks good. But I also found some issues here.
As I cannot build the binary without doing some changes on the pom file, I
had to vote -1 (binding) here.

Here are the issues that I found:

1. there is bunch of dubbo-2.6.2-SNAPSHOT  in the pom.xml file, I guess the
maven release plugin doesn't take all of them.
.//bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
.//dependencies-bom/pom.xml:  dubbo-2.6.2-SNAPSHOT
.//distribution/pom.xml:2.6.2-SNAPSHOT-SNAPSHOT
.//pom.xml:  dubbo-2.6.2-SNAPSHOT

2. I checked the source zip[1], it is not same with github tag one[2].
There are some log files and empty directories which is not in the git
repo, I guess it relates to the builder's workspace.
It could be addressed by generate the source release kit in the
distribution like we did here[3].
BTW, it's quite important that every one can build the kit by following the
instruction. I didn't found the instruction file from the README.

3. I tried to build the source from kit, it looks the check style is
enabled when since JDK 1.8 and I just got the out of memory error there.
I found there are comment about this check style issue (it takes lots of
time and it doesn't work on my box). So I created an issue[4] of it.
I can build the source by modify the pom to skip the check style check, but
it kind of hiking , so I had to vote -1 (binding) for it.

4. I checked the binary kit, it only includes the jars file of dubbo[5], as
we cannot provide the apache maven release now, it could cause some trouble
for the user to consume the binary without third party dependencies. Do we
have any plan for it ?

Another tip for the release check is running some applications which is
build on the top of the framework to make sure all the distribution is good.


[1]
https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/dubbo-incubating-2.6.2-source-release.zip
[2]https://github.com/apache/incubator-dubbo/archive/dubbo-2.6.2.zip
[3]
https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/assembly/src.xml
[4]https://github.com/apache/incubator-dubbo/issues/1821
[5]
https://github.com/apache/incubator-dubbo/blob/2.6.2-release/distribution/src/assembly/release-bin.xml#L43



Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Fri, May 18, 2018 at 5:26 PM, Jun Liu  wrote:

> Hello All,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>
> The Apache Dubbo community has voted on and approved a proposal to release
> Apache Dubbo (Incubating) version 2.6.2.
>
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
> Apache Dubbo™ (incubating) is a high-performance, java based, open source
> RPC framework. Dubbo offers three key functionalities, which include
> interface based remote call, fault tolerance & load balancing, and
> automatic service registration & discovery.
>
> Dubbo vote thread:
> https://lists.apache.org/thread.html/2292dfa6698c97550419ca547c8cd9
> 71bae8c88c440ef277314c841f@%3Cdev.dubbo.apache.org%3E
>
> Dubbo vote result thread:
> https://lists.apache.org/thread.html/701b3d436920eea3030f2a977eb1d3
> 826774bc96e0b1d8b1d09a2ce8@%3Cdev.dubbo.apache.org%3E
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2
>
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
>
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
>
> Release Notes:
> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md
>
> The artifacts have been signed with Key : 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks.
> Jun Liu,
> The Apache Dubbo (Incubating) Team
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Von Gosling]

Hi,

+1

I checked:
- name includes incubating
- signatures and hashes correct
- disclaimer exists
- LICENSE and NOTICE correct
- No binary files in release
- Can compile from source
- The binary distribution (with different license and notice files) also looks 
good.

Some minor problems could be recorded in the next release checklist. Such as, 
not all source files have apache headers(nat are not always work well), odd 
unzip file name etc.

Best Regards,
Von Gosling

> 在 2018年5月16日，10:55，Justin Mclean  写道：
> 
> Hi,
> 
> +1 (binding)
> 
> I checked:
> - Incubating in name
> - Signatures and hashes good
> - DISCLAIMER exists
> - LICENSE and NOTICE good
> - A number of pom.xml and log4j.xml files haven’t had their headers changed 
> to the standard ASF one and are still copyright Alibaba (about 14 files) e.g 
> [4][5]
> - A couple of .sh files are missing ASF headers in [6] also here [9] and here 
> [10]
> - No unexpected binary files in the release
> - Can compile from source
> 
> I also checked the binary convenience release and it's all good re 
> signatures, naming, disclaimer, licenses and notice.
> 
> Some very minor issues (and IMO except for the MD5 issue) can be fixed next 
> release:
> - Can you remove the MD5 hashes please they are not needed and don’t follow 
> the current release policy. [1]
> - The source unzips into an odd directory name "dubbo-parent-2.6.2”, 
> “apache-dubbo-2.6.2” would be better.
> - The code of conduct may need some small updates for instance I see 
> "du...@googlegroups.com” mentioned.
> - The README.md has links to information would be nice to include build 
> instructions inside the README
> - A few poms have some out of date information [2][3]
> - The contributing document need a couple of minor updates (eg @author tags 
> are not used at Apache)
> - LICENSE includes " Copyright (c) 2001-2004 Caucho Technology, Inc” but some 
> of the header have the date range 2001-2008
> - Should these files be in the release? [7][8]
> - Maven check style plugin is taking a long time when compiling (10+minutes) 
> and runs out of memory on my machine. Disabling it (-Dcheckstyle.skip) 
> reduced compile time to under a minute.
> 
> I’ve not checked if the compile source actually works (which is sort of 
> important) so might be good if a few people check that when voting +1 :-)
> 
> Well done! It's not often I get to vote +1 on the first RC of a first release 
> by a project.
> 
> Thanks,
> Justin
> 
> 1. https://www.apache.org/dev/release-distribution.html#sigs-and-sums
> 2. ./bom/pom.xml
> 3. ./dependencies-bom/pom.xml
> 4. ./dubbo-rpc/dubbo-rpc-rest/pom.xml
> 5. ./dubbo-common/src/test/resources/log4j.xml
> 6. 
> dubbo-container/dubbo-container-api/src/main/resources/META-INF/assembly/bin/*.sh
> 7. dubbo-rpc/dubbo-rpc-default/dubbo.log
> 8. dubbo-rpc/dubbo-rpc-dubbo/dubbo.log
> 9. dubbo-test/dubbo-test-benchmark/src/main/resources/run.*
> 10. dubbo-test/dubbo-test-benchmark/src/test/resources/server/*.sh

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Yong Zhu]

+1

All UT passed with JDK 1.8 and JDK 9 on my mac.

Some minor issues I meet:
- When compile sources on JDK 10, a NPE is thrown by
maven-javadoc-plugin:3.0.0, which is a known issue
https://stackoverflow.com/questions/49460751/execution-attach-javadocs-of-goal-org-apache-maven-pluginsmaven-javadoc-plugin
- When run test on JDK 9, the process is interrupted by
maven-checkstyle-plugin:3.0.0 accidentally.

Best regards,
Jerrick

2018-05-18 12:53 GMT+08:00 Jun Liu :

> +1
>
> I have checked that the source release works fine:
> 1. All UT passed with JDK 1.7
> 2. All core features work fine with a certain amount of demos.
> 3. Review passed for changes mentioned in release notes.
>
> Best regards,
> Jun
>
> > On 15 May 2018, at 11:49 AM, Jun Liu  wrote:
> >
> > Hello Dubbo Community,
> >
> > This is a call for vote to release Apache Dubbo (Incubating) version
> 2.6.2.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 <
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2>/
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 <
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2>
> >
> > Hash for the release tag:
> > afab04c53edab38d52275d2a198ea1aff7a4f41e
> >
> > Release Notes:
> > https://github.com/apache/incubator-dubbo/releases/tag/
> untagged-4775c0a22c60fca55118  incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118>
> >
> > The artifacts have been signed with Key : 28681CB1, which can be found
> in the keys file:
> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS <
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS>
> >
> > The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo (Incubating) Team
>
>

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Jun Liu]

+1

I have checked that the source release works fine:
1. All UT passed with JDK 1.7
2. All core features work fine with a certain amount of demos.
3. Review passed for changes mentioned in release notes.

Best regards,
Jun

> On 15 May 2018, at 11:49 AM, Jun Liu  wrote:
> 
> Hello Dubbo Community,
> 
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
> 
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 
> /
> 
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 
> 
> 
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
> 
> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>  
> 
> 
> The artifacts have been signed with Key : 28681CB1, which can be found in the 
> keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS 
> 
> 
> The vote will be open for at least 72 hours or until necessary number of 
> votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve 
> [ ] +0 no opinion 
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Dubbo (Incubating) Team

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Ian Luo]

+1

This release looks good. We could follow up the minor issues Justin and
others point out in the next release.

Cheers,
-Ian.

On Tue, May 15, 2018 at 11:49 AM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 <
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2>/
>
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 <
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2>
>
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
>
> Release Notes:
>
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
> <
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
> >
>
> The artifacts have been signed with Key : 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS <
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS>
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[jun liu]

Hi Justin,

> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e

It’s included in the initial vote email.

> On 16 May 2018, at 10:44 AM, Justin Mclean  wrote:
> 
> HI,
> 
>> I don’t think we need to change the release tag hash. Tag ‘dubbo-2.6.2’ has 
>> never changed, so the source release, binary release and the release tag are 
>> still in consistent to each other.  Be aware that CHANGES.md only exists in 
>> the ‘2.6.2-release’ branch,  a branch we used for release purpose, it serves 
>> for the release process but not bounded. 
> 
> As tags are mutable in git it best to specify the hash in the release vote 
> email (ie afab04c).
> 
> Thanks,
> Justin

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Justin Mclean]

Hi,

+1 (binding)

I checked:
- Incubating in name
- Signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE good
- A number of pom.xml and log4j.xml files haven’t had their headers changed to 
the standard ASF one and are still copyright Alibaba (about 14 files) e.g [4][5]
- A couple of .sh files are missing ASF headers in [6] also here [9] and here 
[10]
- No unexpected binary files in the release
- Can compile from source

I also checked the binary convenience release and it's all good re signatures, 
naming, disclaimer, licenses and notice.

Some very minor issues (and IMO except for the MD5 issue) can be fixed next 
release:
- Can you remove the MD5 hashes please they are not needed and don’t follow the 
current release policy. [1]
- The source unzips into an odd directory name "dubbo-parent-2.6.2”, 
“apache-dubbo-2.6.2” would be better.
- The code of conduct may need some small updates for instance I see 
"du...@googlegroups.com” mentioned.
- The README.md has links to information would be nice to include build 
instructions inside the README
- A few poms have some out of date information [2][3]
- The contributing document need a couple of minor updates (eg @author tags are 
not used at Apache)
- LICENSE includes " Copyright (c) 2001-2004 Caucho Technology, Inc” but some 
of the header have the date range 2001-2008
- Should these files be in the release? [7][8]
- Maven check style plugin is taking a long time when compiling (10+minutes) 
and runs out of memory on my machine. Disabling it (-Dcheckstyle.skip) reduced 
compile time to under a minute.

I’ve not checked if the compile source actually works (which is sort of 
important) so might be good if a few people check that when voting +1 :-)

Well done! It's not often I get to vote +1 on the first RC of a first release 
by a project.

Thanks,
Justin

1. https://www.apache.org/dev/release-distribution.html#sigs-and-sums
2. ./bom/pom.xml
3. ./dependencies-bom/pom.xml
4. ./dubbo-rpc/dubbo-rpc-rest/pom.xml
5. ./dubbo-common/src/test/resources/log4j.xml
6. 
dubbo-container/dubbo-container-api/src/main/resources/META-INF/assembly/bin/*.sh
7. dubbo-rpc/dubbo-rpc-default/dubbo.log
8. dubbo-rpc/dubbo-rpc-dubbo/dubbo.log
9. dubbo-test/dubbo-test-benchmark/src/main/resources/run.*
10. dubbo-test/dubbo-test-benchmark/src/test/resources/server/*.sh

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Justin Mclean]

HI,

> I don’t think we need to change the release tag hash. Tag ‘dubbo-2.6.2’ has 
> never changed, so the source release, binary release and the release tag are 
> still in consistent to each other.  Be aware that CHANGES.md only exists in 
> the ‘2.6.2-release’ branch,  a branch we used for release purpose, it serves 
> for the release process but not bounded. 

As tags are mutable in git it best to specify the hash in the release vote 
email (ie afab04c).

Thanks,
Justin

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[jun liu]

>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>>  
>>> 
>> 
>> Sorry, the previous link seems invisible for non-committers, please check 
>> the following link for detailed release notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md 
>> 
> 
> Since you pushed to the release branch, the hash for the release tag
> should also be changed?

I don’t think we need to change the release tag hash. Tag ‘dubbo-2.6.2’ has 
never changed, so the source release, binary release and the release tag are 
still in consistent to each other.  Be aware that CHANGES.md only exists in the 
‘2.6.2-release’ branch,  a branch we used for release purpose, it serves for 
the release process but not bounded. 

Best regards,
Jun

> On 15 May 2018, at 3:38 PM, Huxing Zhang  wrote:
> 
> On Tue, May 15, 2018 at 2:11 PM, Jun Liu  > wrote:
>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>>  
>>> 
>> 
>> Sorry, the previous link seems invisible for non-committers, please check 
>> the following link for detailed release notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md 
>> 
> 
> Since you pushed to the release branch, the hash for the release tag
> should also be changed?
> 
>> 
>>> On 15 May 2018, at 11:49 AM, Jun Liu  wrote:
>>> 
>>> Hello Dubbo Community,
>>> 
>>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>>> 
>>> The release candidates:
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
>>> 
>>> Git tag for the release:
>>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
>>> 
>>> Hash for the release tag:
>>> afab04c53edab38d52275d2a198ea1aff7a4f41e
>>> 
>>> Release Notes:
>>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>> 
>>> The artifacts have been signed with Key : 28681CB1, which can be found in 
>>> the keys file:
>>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>> 
>>> The vote will be open for at least 72 hours or until necessary number of 
>>> votes are reached.
>>> 
>>> Please vote accordingly:
>>> 
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>> 
>>> Thanks,
>>> The Apache Dubbo (Incubating) Team
>> 
> 
> -- 
> Best Regards！
> Huxing

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Huxing Zhang]

On Tue, May 15, 2018 at 2:11 PM, Jun Liu  wrote:
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>
> Sorry, the previous link seems invisible for non-committers, please check the 
> following link for detailed release notes:
> https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md

Since you pushed to the release branch, the hash for the release tag
should also be changed?

>
>> On 15 May 2018, at 11:49 AM, Jun Liu  wrote:
>>
>> Hello Dubbo Community,
>>
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>>
>> The release candidates:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
>>
>> Git tag for the release:
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
>>
>> Hash for the release tag:
>> afab04c53edab38d52275d2a198ea1aff7a4f41e
>>
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>>
>> The artifacts have been signed with Key : 28681CB1, which can be found in 
>> the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>>
>> The vote will be open for at least 72 hours or until necessary number of 
>> votes are reached.
>>
>> Please vote accordingly:
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thanks,
>> The Apache Dubbo (Incubating) Team
>

-- 
Best Regards！
Huxing

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Huxing Zhang]

Hi,

[x] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

Details:

* incubator in name
* Disclaimer exists
* sha512 chesum ok
* signature ok
* NOTICE and LICENSE exist in META-INF of jar files of binary release.
* Unit test passed on Java 8 + OSX

Other minor comments:
* The unarchived directory name for
dubbo-incubating-2.6.2-source-release.zip is 'dubbo-parent-2.6.2', may
be better to change to  "dubbo-incubating-2.6.2"
* The link[1] to release notes is not accessible, should be [2], and
it is inaccessible to non-committer, maybe it is better to attach them
to the voting thread.
* dubbo-parent seems took 23+ min in my local environment, I checked
the jstack and it looks like maven-checkstyle-plugin is scanning
directories..

[1] 
https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
[2] 
https://github.com/apache/incubator-dubbo/releases/tag/untagged-616b91e8d915fe71a17f

On Tue, May 15, 2018 at 11:49 AM, Jun Liu  wrote:
> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2 
> /
>
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2 
> 
>
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
>
> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
>  
> 
>
> The artifacts have been signed with Key : 28681CB1, which can be found in the 
> keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS 
> 
>
> The vote will be open for at least 72 hours or until necessary number of 
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team

-- 
Best Regards！
Huxing

Re: [VOTE]: Release Apache Dubbo (Incubating) 2.6.2 [RC1]

[Jun Liu]

> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118

Sorry, the previous link seems invisible for non-committers, please check the 
following link for detailed release notes:
https://github.com/apache/incubator-dubbo/blob/2.6.2-release/CHANGES.md

> On 15 May 2018, at 11:49 AM, Jun Liu  wrote:
> 
> Hello Dubbo Community,
> 
> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.2.
> 
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
> 
> Git tag for the release:
> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.2
> 
> Hash for the release tag:
> afab04c53edab38d52275d2a198ea1aff7a4f41e
> 
> Release Notes:
> https://github.com/apache/incubator-dubbo/releases/tag/untagged-4775c0a22c60fca55118
> 
> The artifacts have been signed with Key : 28681CB1, which can be found in the 
> keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
> 
> The vote will be open for at least 72 hours or until necessary number of 
> votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve 
> [ ] +0 no opinion 
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Dubbo (Incubating) Team