Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Alex Harui]

On 12/27/16, 10:51 PM, "Yishay Weiss"  wrote:

>Nice stuff, Chris.
>
>
>
>All the bugs in the framework seem to be about failing to override the
>clone() method in Event. If I understand correctly, this is mainly to
>preserve state in case an event is re-dispatched. Is there anything
>special in FlexJS that makes this unnecessary, or should we go ahead and
>fix these bugs?

Org.apache.flex.events.Event overrides clone and calls cloneEvent so Event
subclasses in FlexJS should override cloneEvent instead of clone.  At
least for a while longer.  I hope to get the whole framework to support
clone() by allowing certain kinds of overrides in the compiler (which is
done) and getting the compiler to return the problems found against
different platforms in one report.

Also note, clone() is really only for SWF.  The GCL event subsystem
doesn't use it.

-Alex

RE: [FlexJS] ASF SonarQube available (Beta-Testing)

[Yishay Weiss]

Nice stuff, Chris.



All the bugs in the framework seem to be about failing to override the clone() 
method in Event. If I understand correctly, this is mainly to preserve state in 
case an event is re-dispatched. Is there anything special in FlexJS that makes 
this unnecessary, or should we go ahead and fix these bugs?



From: Christofer Dutz<mailto:christofer.d...@c-ware.de>
Sent: Tuesday, December 27, 2016 9:50 PM
To: dev@flex.apache.org<mailto:dev@flex.apache.org>
Subject: Re: [FlexJS] ASF SonarQube available (Beta-Testing)



Ok … stats are online:

Compiler: https://builds.apache.org/analysis/dashboard/index/2461
Typedefs: https://builds.apache.org/analysis/dashboard/index/20905
Framework: https://builds.apache.org/analysis/dashboard/index/20942

Happy reading,
   Chris

Am 27.12.16, 09:02 schrieb "Alex Harui" <aha...@adobe.com>:


On 12/26/16, 11:50 AM, "Josh Tynjala" <joshtynj...@gmail.com> wrote:

>I suspect that a big chunk of the duplicate code is related to the Basic
>and HTML projects. As I understand it, HTML was forked from Basic to try a
>different architecture approach, but a big portion of the code is still
>the
>same.

Makes sense.

I think there also some classes that have different ancestry in JS vs SWF
so a file will have two class definitions in it, one inside COMPILE::SWF
and one inside COMPILE::JS and there can be duplication there as well.


-Alex

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Carlos Rovira]

Thanks Chris for the effort on making this! :)

2016-12-27 20:50 GMT+01:00 Christofer Dutz :

> Ok … stats are online:
>
> Compiler: https://builds.apache.org/analysis/dashboard/index/2461
> Typedefs: https://builds.apache.org/analysis/dashboard/index/20905
> Framework: https://builds.apache.org/analysis/dashboard/index/20942
>
> Happy reading,
>Chris
>
> Am 27.12.16, 09:02 schrieb "Alex Harui" :
>
>
> On 12/26/16, 11:50 AM, "Josh Tynjala"  wrote:
>
> >I suspect that a big chunk of the duplicate code is related to the
> Basic
> >and HTML projects. As I understand it, HTML was forked from Basic to
> try a
> >different architecture approach, but a big portion of the code is
> still
> >the
> >same.
>
> Makes sense.
>
> I think there also some classes that have different ancestry in JS vs
> SWF
> so a file will have two class definitions in it, one inside
> COMPILE::SWF
> and one inside COMPILE::JS and there can be duplication there as well.
>
>
> -Alex
>
>
>
>


-- 

Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es

Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.

De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Christofer Dutz]

Ok … stats are online:

Compiler: https://builds.apache.org/analysis/dashboard/index/2461
Typedefs: https://builds.apache.org/analysis/dashboard/index/20905
Framework: https://builds.apache.org/analysis/dashboard/index/20942

Happy reading,
   Chris

Am 27.12.16, 09:02 schrieb "Alex Harui" :


On 12/26/16, 11:50 AM, "Josh Tynjala"  wrote:

>I suspect that a big chunk of the duplicate code is related to the Basic
>and HTML projects. As I understand it, HTML was forked from Basic to try a
>different architecture approach, but a big portion of the code is still
>the
>same.

Makes sense.

I think there also some classes that have different ancestry in JS vs SWF
so a file will have two class definitions in it, one inside COMPILE::SWF
and one inside COMPILE::JS and there can be duplication there as well.


-Alex

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Alex Harui]

On 12/26/16, 11:50 AM, "Josh Tynjala"  wrote:

>I suspect that a big chunk of the duplicate code is related to the Basic
>and HTML projects. As I understand it, HTML was forked from Basic to try a
>different architecture approach, but a big portion of the code is still
>the
>same.

Makes sense.

I think there also some classes that have different ancestry in JS vs SWF
so a file will have two class definitions in it, one inside COMPILE::SWF
and one inside COMPILE::JS and there can be duplication there as well.


-Alex

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Josh Tynjala]

I suspect that a big chunk of the duplicate code is related to the Basic
and HTML projects. As I understand it, HTML was forked from Basic to try a
different architecture approach, but a big portion of the code is still the
same.

- Josh

On Mon, Dec 26, 2016 at 8:39 AM, Christofer Dutz <christofer.d...@c-ware.de>
wrote:

> Ok … so the results aren’t that bad at all …
>
> Typedefs:
> 1 Bug
> 1 Vulnerability
> 308 Code Smells
>
> Framework:
> 17 Bugs
> 86 Vulnerabilities
> 8500 Code Smells (A lot is probably related to the conditional compilation)
> 35% of duplicated code
>
> 35% of duplicated code seems to indicate we could reuse quite a lot of
> that code but I haven’t looked into that.
> I added the missing configuration to the typedefs and framework modules
> and opened a ticket to install the Flex plugin to SonarQube.
>
> Chris
>
>
> Am 26.12.16, 15:50 schrieb "piotrz" <piotrzarzyck...@gmail.com>:
>
> Thank you. Looking forward to the results.
>
> Piotr
>
>
>
> -
> Apache Flex PMC
> piotrzarzyck...@gmail.com
>     --
> View this message in context: http://apache-flex-
> development.247.n4.nabble.com/FlexJS-ASF-SonarQube-
> available-Beta-Testing-tp57320p57570.html
> Sent from the Apache Flex Development mailing list archive at
> Nabble.com.
>
>
>

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[piotrz]

Thanks Chris. :) That's what I was intrested how much code duplication we
have. :)

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57572.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Christofer Dutz]

Ok … so the results aren’t that bad at all …

Typedefs:
1 Bug
1 Vulnerability
308 Code Smells

Framework:
17 Bugs
86 Vulnerabilities
8500 Code Smells (A lot is probably related to the conditional compilation)
35% of duplicated code

35% of duplicated code seems to indicate we could reuse quite a lot of that 
code but I haven’t looked into that. 
I added the missing configuration to the typedefs and framework modules and 
opened a ticket to install the Flex plugin to SonarQube.

Chris


Am 26.12.16, 15:50 schrieb "piotrz" <piotrzarzyck...@gmail.com>:

Thank you. Looking forward to the results.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57570.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[piotrz]

Thank you. Looking forward to the results.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57570.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Christofer Dutz]

I’ll set this up locally and give it a spin. I wouldn’t be surprised, if the 
result would be “catastrophic” because of all of the conditional compilation … 
I know that sonar doesn’t like this. So I’ll try to setup a build and settings 
for ActionScript on my local SonarQube first.

Chris

Am 26.12.16, 12:35 schrieb "piotrz" <piotrzarzyck...@gmail.com>:

Chris,

I think it's worth to try with putting into analysis also ActionScript code.
Who should we eventually ask for installing ActionScript plugin? 

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57566.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[piotrz]

Chris,

I think it's worth to try with putting into analysis also ActionScript code.
Who should we eventually ask for installing ActionScript plugin? 

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57566.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Christofer Dutz]

Yup ... currently only C#, Java and JavaScript rules are installed.

Chris

Am 19.12.16, 10:26 schrieb "Christofer Dutz" <christofer.d...@c-ware.de>:

Well In general it would be possible. SonarQube generally is able to scan 
ActionScript ...

I didn’t add anything, because I would bet a lot on the fact that the 
results would be so bad that we can’t do much with it. Because of all the huge 
amount of conditional compilation, which is regarded bad and FlexJS relies 
greatly upon.

Eventually I would have to have the SQ plugins for that installed though.

I could give it a try though. 

Chris

Am 19.12.16, 10:07 schrieb "piotrz" <piotrzarzyck...@gmail.com>:

Hi Chris,

Do you think that would be possible run anlysis also for ActionScript 
part
of framework? 

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57452.html
Sent from the Apache Flex Development mailing list archive at 
Nabble.com.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Christofer Dutz]

Well In general it would be possible. SonarQube generally is able to scan 
ActionScript ...

I didn’t add anything, because I would bet a lot on the fact that the results 
would be so bad that we can’t do much with it. Because of all the huge amount 
of conditional compilation, which is regarded bad and FlexJS relies greatly 
upon.

Eventually I would have to have the SQ plugins for that installed though.

I could give it a try though. 

Chris

Am 19.12.16, 10:07 schrieb "piotrz" <piotrzarzyck...@gmail.com>:

Hi Chris,

Do you think that would be possible run anlysis also for ActionScript part
of framework? 

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57452.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[piotrz]

Hi Chris,

Do you think that would be possible run anlysis also for ActionScript part
of framework? 

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/FlexJS-ASF-SonarQube-available-Beta-Testing-tp57320p57452.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Christofer Dutz]

Ok ... so now I brought in all the Maven built parts:

SDK Converter aka Mavnizer: https://builds.apache.org/analysis/overview?id=14055
BlazeDS: https://builds.apache.org/analysis/overview?id=11879
FlexJS: https://builds.apache.org/analysis/overview?id=2461

Chris


Am 16.12.16, 19:23 schrieb "Alex Harui" :

Nice!

On 12/16/16, 4:03 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira"
 wrote:

>Wow! That's dawn cool! :))
>
>2016-12-16 12:57 GMT+01:00 Christofer Dutz :
>
>> Ok ..
>>
>> so we managed to get the analyis running from Maven (includes code
>> coverage)
>> The link to this is:
>>
>> https://builds.apache.org/analysis/overview?id=2461
>>
>> Chris
>>
>> Am 16.12.16, 11:48 schrieb "Christofer Dutz"
>>:
>>
>> Hi,
>>
>> even if not officially communicated (We’re still beta-testing),
>>Gavin
>> recently setup a new SonarQube server and configured things to be able
>>to
>> run the SonarQube analysis on the normal Jenkins build machine.
>>
>> I am happy to announce that we now have publicly available SonarQube
>> stats:
>>
>> Feel free to have a look at:
>> https://builds.apache.org/analysis/overview?id=1
>>
>> Chris
>>
>>
>>
>>
>
>
>-- 
>
>Carlos Rovira
>Director General
>M: +34 607 22 60 05
>http://www.codeoscopic.com
>http://www.avant2.es
>
>Este mensaje se dirige exclusivamente a su destinatario y puede contener
>información privilegiada o confidencial. Si ha recibido este mensaje por
>error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
>proceda a su destrucción.
>
>De la vigente Ley Orgánica de Protección de Datos (15/1999), le
>comunicamos
>que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
>S.A. La finalidad de dicho tratamiento es facilitar la prestación del
>servicio o información solicitados, teniendo usted derecho de acceso,
>rectificación, cancelación y oposición de sus datos dirigiéndose a
>nuestras
>oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
>necesaria.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Alex Harui]

Nice!

On 12/16/16, 4:03 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira"
 wrote:

>Wow! That's dawn cool! :))
>
>2016-12-16 12:57 GMT+01:00 Christofer Dutz :
>
>> Ok ..
>>
>> so we managed to get the analyis running from Maven (includes code
>> coverage)
>> The link to this is:
>>
>> https://builds.apache.org/analysis/overview?id=2461
>>
>> Chris
>>
>> Am 16.12.16, 11:48 schrieb "Christofer Dutz"
>>:
>>
>> Hi,
>>
>> even if not officially communicated (We’re still beta-testing),
>>Gavin
>> recently setup a new SonarQube server and configured things to be able
>>to
>> run the SonarQube analysis on the normal Jenkins build machine.
>>
>> I am happy to announce that we now have publicly available SonarQube
>> stats:
>>
>> Feel free to have a look at:
>> https://builds.apache.org/analysis/overview?id=1
>>
>> Chris
>>
>>
>>
>>
>
>
>-- 
>
>Carlos Rovira
>Director General
>M: +34 607 22 60 05
>http://www.codeoscopic.com
>http://www.avant2.es
>
>Este mensaje se dirige exclusivamente a su destinatario y puede contener
>información privilegiada o confidencial. Si ha recibido este mensaje por
>error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
>proceda a su destrucción.
>
>De la vigente Ley Orgánica de Protección de Datos (15/1999), le
>comunicamos
>que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
>S.A. La finalidad de dicho tratamiento es facilitar la prestación del
>servicio o información solicitados, teniendo usted derecho de acceso,
>rectificación, cancelación y oposición de sus datos dirigiéndose a
>nuestras
>oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
>necesaria.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Carlos Rovira]

Wow! That's dawn cool! :))

2016-12-16 12:57 GMT+01:00 Christofer Dutz :

> Ok ..
>
> so we managed to get the analyis running from Maven (includes code
> coverage)
> The link to this is:
>
> https://builds.apache.org/analysis/overview?id=2461
>
> Chris
>
> Am 16.12.16, 11:48 schrieb "Christofer Dutz" :
>
> Hi,
>
> even if not officially communicated (We’re still beta-testing), Gavin
> recently setup a new SonarQube server and configured things to be able to
> run the SonarQube analysis on the normal Jenkins build machine.
>
> I am happy to announce that we now have publicly available SonarQube
> stats:
>
> Feel free to have a look at:
> https://builds.apache.org/analysis/overview?id=1
>
> Chris
>
>
>
>


-- 

Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es

Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.

De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.

Re: [FlexJS] ASF SonarQube available (Beta-Testing)

[Christofer Dutz]

Ok .. 

so we managed to get the analyis running from Maven (includes code coverage)
The link to this is:

https://builds.apache.org/analysis/overview?id=2461

Chris

Am 16.12.16, 11:48 schrieb "Christofer Dutz" :

Hi,

even if not officially communicated (We’re still beta-testing), Gavin 
recently setup a new SonarQube server and configured things to be able to run 
the SonarQube analysis on the normal Jenkins build machine.

I am happy to announce that we now have publicly available SonarQube stats:

Feel free to have a look at:
https://builds.apache.org/analysis/overview?id=1

Chris

[FlexJS] ASF SonarQube available (Beta-Testing)

[Christofer Dutz]

Hi,

even if not officially communicated (We’re still beta-testing), Gavin recently 
setup a new SonarQube server and configured things to be able to run the 
SonarQube analysis on the normal Jenkins build machine.

I am happy to announce that we now have publicly available SonarQube stats:

Feel free to have a look at:
https://builds.apache.org/analysis/overview?id=1

Chris