subject:"\[DISCUSS\] Flink dist directory management"

Re: [DISCUSS] Flink dist directory management

2017-03-27 Thread shijinkui

Hi, Fabian, Jark Wu, Greg
Thank for your feedback and support. I’ll create some sub-issue to
complete the every task of code refactor.

在 2017/3/27 下午3:38， "Fabian Hueske"  写入:

>Hi Jinkui,
>
>I agree with you, moving all examples into ./examples would be nice.
>Note, that for the DataSet and DataStream APIs, each example is packaged
>as
>a separate JAR with the main class being included in the MANIFEST file.
>
>I think we should select a few representative examples of the Table and
>Gelly examples and do the same.
>IMO, the Table API / SQL examples could also be improved a lot, but that's
>a different story.
>
>Best, Fabian
>
>2017-03-27 5:47 GMT+02:00 伍翀(云邪) :
>
>> Hi Jinkui,
>>
>> Thanks for bringing up this discussion. I’m +1 to moving table-examples
>> and belly-examples into "examples/“ to keep “opt” clean.
>>
>> Best,
>> Jark Wu
>>
>> > 在 2017年3月25日，下午3:46，shijinkui  写道：
>> >
>> > Hi, all
>> >
>> > The Flink distributionĄ¯s directory have no very clear responsibility
>> about what type of files should be in which directory.
>> >
>> > The "bin","conf","lib" directories are clear for their responsibility.
>> >
>> > But the Ą°opt" directories are mixed with library jars and example
>>jars.
>> >
>> > I think we can discuss how is reasonable for the directory. Once we
>> determined, we should follow it.
>> >
>> > IMO, directory style below is reasonable:
>> >
>> > - "examples" directory only contain example jars
>> > - "opt" directory only contain optional library jars in runtime
>> > - "lib" directory only contain library jar that must be loaded at
>>runtime
>> > - Ą°resourcesĄą directory only contain resource file used at runtime,
>> such as web file
>> >
>> > Show your opinion please.
>> >
>> > @wuchong, @fhueske @Fabian
>> >
>> > Best regards,
>> > Jinkui Shi
>> >
>> >
>> > .
>> > ŠĀŠ¤Š¤ LICENSE
>> > ŠĀŠ¤Š¤ NOTICE
>> > ŠĀŠ¤Š¤ README.txt
>> > ŠĀŠ¤Š¤ bin
>> > ŠĻ   ŠĀŠ¤Š¤ config.sh
>> > ŠĻ   ŠĀŠ¤Š¤ flink
>> > ŠĻ   ŠĀŠ¤Š¤ ...
>> > ŠĀŠ¤Š¤ conf
>> > ŠĻ   ŠĀŠ¤Š¤ flink-conf.yaml
>> > ŠĻ   ŠĀŠ¤Š¤ ...
>> > ŠĀŠ¤Š¤ examples
>> > ŠĻ   ŠĀŠ¤Š¤ batch
>> > ŠĻ   Š¸Š¤Š¤ streaming
>> > ŠĀŠ¤Š¤ lib
>> > ŠĻ   ŠĀŠ¤Š¤ flink-dist_2.11-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ flink-python_2.11-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ ...
>> > ŠĀŠ¤Š¤ log
>> > ŠĀŠ¤Š¤ opt
>> > ŠĻ   ŠĀŠ¤Š¤ flink-cep-scala_2.11-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ flink-cep_2.11-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ flink-gelly-examples_2.11-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ flink-gelly-scala_2.11-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ flink-gelly_2.11-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ flink-metrics-dropwizard-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ flink-metrics-ganglia-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ flink-metrics-graphite-1.3.0.jar
>> > ŠĻ   ŠĀŠ¤Š¤ flink-metrics-statsd-1.3.0.jar
>> > ŠĻ   Š¸Š¤Š¤ flink-ml_2.11-1.3.0.jar
>> > ŠĀŠ¤Š¤ resources
>> > ŠĻ   Š¸Š¤Š¤ python
>> > Š¸Š¤Š¤ tools
>> >Š¸Š¤Š¤ planVisualizer.html
>> >
>> >
>> > [1] https://github.com/apache/flink/pull/2460
>> >
>>
>>

Re: [DISCUSS] Flink dist directory management

2017-03-27 Thread Fabian Hueske

Hi Jinkui,

I agree with you, moving all examples into ./examples would be nice.
Note, that for the DataSet and DataStream APIs, each example is packaged as
a separate JAR with the main class being included in the MANIFEST file.

I think we should select a few representative examples of the Table and
Gelly examples and do the same.
IMO, the Table API / SQL examples could also be improved a lot, but that's
a different story.

Best, Fabian

2017-03-27 5:47 GMT+02:00 伍翀(云邪) :

> Hi Jinkui,
>
> Thanks for bringing up this discussion. I’m +1 to moving table-examples
> and belly-examples into "examples/“ to keep “opt” clean.
>
> Best,
> Jark Wu
>
> > 在 2017年3月25日，下午3:46，shijinkui  写道：
> >
> > Hi, all
> >
> > The Flink distributionĄ¯s directory have no very clear responsibility
> about what type of files should be in which directory.
> >
> > The "bin","conf","lib" directories are clear for their responsibility.
> >
> > But the Ą°opt" directories are mixed with library jars and example jars.
> >
> > I think we can discuss how is reasonable for the directory. Once we
> determined, we should follow it.
> >
> > IMO, directory style below is reasonable:
> >
> > - "examples" directory only contain example jars
> > - "opt" directory only contain optional library jars in runtime
> > - "lib" directory only contain library jar that must be loaded at runtime
> > - Ą°resourcesĄą directory only contain resource file used at runtime,
> such as web file
> >
> > Show your opinion please.
> >
> > @wuchong, @fhueske @Fabian
> >
> > Best regards,
> > Jinkui Shi
> >
> >
> > .
> > ŠĀŠ¤Š¤ LICENSE
> > ŠĀŠ¤Š¤ NOTICE
> > ŠĀŠ¤Š¤ README.txt
> > ŠĀŠ¤Š¤ bin
> > ŠĻ   ŠĀŠ¤Š¤ config.sh
> > ŠĻ   ŠĀŠ¤Š¤ flink
> > ŠĻ   ŠĀŠ¤Š¤ ...
> > ŠĀŠ¤Š¤ conf
> > ŠĻ   ŠĀŠ¤Š¤ flink-conf.yaml
> > ŠĻ   ŠĀŠ¤Š¤ ...
> > ŠĀŠ¤Š¤ examples
> > ŠĻ   ŠĀŠ¤Š¤ batch
> > ŠĻ   Š¸Š¤Š¤ streaming
> > ŠĀŠ¤Š¤ lib
> > ŠĻ   ŠĀŠ¤Š¤ flink-dist_2.11-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ flink-python_2.11-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ ...
> > ŠĀŠ¤Š¤ log
> > ŠĀŠ¤Š¤ opt
> > ŠĻ   ŠĀŠ¤Š¤ flink-cep-scala_2.11-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ flink-cep_2.11-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ flink-gelly-examples_2.11-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ flink-gelly-scala_2.11-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ flink-gelly_2.11-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ flink-metrics-dropwizard-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ flink-metrics-ganglia-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ flink-metrics-graphite-1.3.0.jar
> > ŠĻ   ŠĀŠ¤Š¤ flink-metrics-statsd-1.3.0.jar
> > ŠĻ   Š¸Š¤Š¤ flink-ml_2.11-1.3.0.jar
> > ŠĀŠ¤Š¤ resources
> > ŠĻ   Š¸Š¤Š¤ python
> > Š¸Š¤Š¤ tools
> >Š¸Š¤Š¤ planVisualizer.html
> >
> >
> > [1] https://github.com/apache/flink/pull/2460
> >
>
>

Re: [DISCUSS] Flink dist directory management

2017-03-26 Thread 伍翀(云邪)

Hi Jinkui,

Thanks for bringing up this discussion. I??m +1 to moving table-examples and 
belly-examples into "examples/?? to keep ??opt?? clean.

Best,
Jark Wu 

> ?? 2017??3??253:46??shijinkui  ??
> 
> Hi, all
> 
> The Flink distribution?0?1?0?4s directory have no very clear responsibility 
> about what type of files should be in which directory.
> 
> The "bin","conf","lib" directories are clear for their responsibility.
> 
> But the ?0?1??opt" directories are mixed with library jars and example jars.
> 
> I think we can discuss how is reasonable for the directory. Once we 
> determined, we should follow it.
> 
> IMO, directory style below is reasonable:
> 
> - "examples" directory only contain example jars
> - "opt" directory only contain optional library jars in runtime
> - "lib" directory only contain library jar that must be loaded at runtime
> - ?0?1??resources?0?1?0?2 directory only contain resource file used at 
> runtime, such as web file
> 
> Show your opinion please.
> 
> @wuchong, @fhueske @Fabian
> 
> Best regards,
> Jinkui Shi
> 
> 
> .
> ?0?7?0?8?0?7???0?7?? LICENSE
> ?0?7?0?8?0?7???0?7?? NOTICE
> ?0?7?0?8?0?7???0?7?? README.txt
> ?0?7?0?8?0?7???0?7?? bin
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? config.sh
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? ...
> ?0?7?0?8?0?7???0?7?? conf
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-conf.yaml
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? ...
> ?0?7?0?8?0?7???0?7?? examples
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? batch
> ?0?7?0?3   ?0?7?0?0?0?7???0?7?? streaming
> ?0?7?0?8?0?7???0?7?? lib
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-dist_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-python_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? ...
> ?0?7?0?8?0?7???0?7?? log
> ?0?7?0?8?0?7???0?7?? opt
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-cep-scala_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-cep_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-gelly-examples_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-gelly-scala_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-gelly_2.11-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-metrics-dropwizard-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-metrics-ganglia-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-metrics-graphite-1.3.0.jar
> ?0?7?0?3   ?0?7?0?8?0?7???0?7?? flink-metrics-statsd-1.3.0.jar
> ?0?7?0?3   ?0?7?0?0?0?7???0?7?? flink-ml_2.11-1.3.0.jar
> ?0?7?0?8?0?7???0?7?? resources
> ?0?7?0?3   ?0?7?0?0?0?7???0?7?? python
> ?0?7?0?0?0?7???0?7?? tools
>?0?7?0?0?0?7???0?7?? planVisualizer.html
> 
> 
> [1] https://github.com/apache/flink/pull/2460
>

Re: [DISCUSS] Flink dist directory management

2017-03-25 Thread Greg Hogan

Hi Jinkui,

+1 to moving gelly-examples into examples/.

Also sounds nice to similarly organize the Python examples.

Docs will also need to be updated (docs/dev/lib/gelly/index.md).

Greg


> On Mar 25, 2017, at 3:46 AM, shijinkui  wrote:
> 
> Hi, all
> 
> The Flink distributionĄ¯s directory have no very clear responsibility about 
> what type of files should be in which directory.
> 
> The "bin","conf","lib" directories are clear for their responsibility.
> 
> But the Ą°opt" directories are mixed with library jars and example jars.
> 
> I think we can discuss how is reasonable for the directory. Once we 
> determined, we should follow it.
> 
> IMO, directory style below is reasonable:
> 
> - "examples" directory only contain example jars
> - "opt" directory only contain optional library jars in runtime
> - "lib" directory only contain library jar that must be loaded at runtime
> - Ą°resourcesĄą directory only contain resource file used at runtime, such as 
> web file
> 
> Show your opinion please.
> 
> @wuchong, @fhueske @Fabian
> 
> Best regards,
> Jinkui Shi
> 
> 
> .
> ŠĀŠ¤Š¤ LICENSE
> ŠĀŠ¤Š¤ NOTICE
> ŠĀŠ¤Š¤ README.txt
> ŠĀŠ¤Š¤ bin
> ŠĻ   ŠĀŠ¤Š¤ config.sh
> ŠĻ   ŠĀŠ¤Š¤ flink
> ŠĻ   ŠĀŠ¤Š¤ ...
> ŠĀŠ¤Š¤ conf
> ŠĻ   ŠĀŠ¤Š¤ flink-conf.yaml
> ŠĻ   ŠĀŠ¤Š¤ ...
> ŠĀŠ¤Š¤ examples
> ŠĻ   ŠĀŠ¤Š¤ batch
> ŠĻ   Š¸Š¤Š¤ streaming
> ŠĀŠ¤Š¤ lib
> ŠĻ   ŠĀŠ¤Š¤ flink-dist_2.11-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ flink-python_2.11-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ ...
> ŠĀŠ¤Š¤ log
> ŠĀŠ¤Š¤ opt
> ŠĻ   ŠĀŠ¤Š¤ flink-cep-scala_2.11-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ flink-cep_2.11-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ flink-gelly-examples_2.11-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ flink-gelly-scala_2.11-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ flink-gelly_2.11-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ flink-metrics-dropwizard-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ flink-metrics-ganglia-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ flink-metrics-graphite-1.3.0.jar
> ŠĻ   ŠĀŠ¤Š¤ flink-metrics-statsd-1.3.0.jar
> ŠĻ   Š¸Š¤Š¤ flink-ml_2.11-1.3.0.jar
> ŠĀŠ¤Š¤ resources
> ŠĻ   Š¸Š¤Š¤ python
> Š¸Š¤Š¤ tools
>Š¸Š¤Š¤ planVisualizer.html
> 
> 
> [1] https://github.com/apache/flink/pull/2460
>

[DISCUSS] Flink dist directory management

2017-03-25 Thread shijinkui

Hi, all

The Flink distribution’s directory have no very clear responsibility about what 
type of files should be in which directory.

The "bin","conf","lib" directories are clear for their responsibility.

But the “opt" directories are mixed with library jars and example jars.

I think we can discuss how is reasonable for the directory. Once we determined, 
we should follow it.

IMO, directory style below is reasonable:

- "examples" directory only contain example jars
- "opt" directory only contain optional library jars in runtime
- "lib" directory only contain library jar that must be loaded at runtime
- “resources” directory only contain resource file used at runtime, such as web 
file

Show your opinion please.

@wuchong, @fhueske @Fabian

Best regards,
Jinkui Shi


.
├── LICENSE
├── NOTICE
├── README.txt
├── bin
│   ├── config.sh
│   ├── flink
│   ├── ...
├── conf
│   ├── flink-conf.yaml
│   ├── ...
├── examples
│   ├── batch
│   └── streaming
├── lib
│   ├── flink-dist_2.11-1.3.0.jar
│   ├── flink-python_2.11-1.3.0.jar
│   ├── ...
├── log
├── opt
│   ├── flink-cep-scala_2.11-1.3.0.jar
│   ├── flink-cep_2.11-1.3.0.jar
│   ├── flink-gelly-examples_2.11-1.3.0.jar
│   ├── flink-gelly-scala_2.11-1.3.0.jar
│   ├── flink-gelly_2.11-1.3.0.jar
│   ├── flink-metrics-dropwizard-1.3.0.jar
│   ├── flink-metrics-ganglia-1.3.0.jar
│   ├── flink-metrics-graphite-1.3.0.jar
│   ├── flink-metrics-statsd-1.3.0.jar
│   └── flink-ml_2.11-1.3.0.jar
├── resources
│   └── python
└── tools
└── planVisualizer.html


[1] https://github.com/apache/flink/pull/2460

Re: [DISCUSS] Flink dist directory management

Re: [DISCUSS] Flink dist directory management

Re: [DISCUSS] Flink dist directory management

Re: [DISCUSS] Flink dist directory management

[DISCUSS] Flink dist directory management

5 matches

Site Navigation

Mail list logo

Footer information