[jira] [Commented] (FLUME-1520) Timestamp interceptor should support custom headers

2017-09-11 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161964#comment-16161964
 ] 

Hudson commented on FLUME-1520:
---

FAILURE: Integrated in Jenkins build Flume-trunk-hbase-1 #319 (See 
[https://builds.apache.org/job/Flume-trunk-hbase-1/319/])
FLUME-1520. Timestamp interceptor should support custom headers (denes: 
[http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git=commit=13771c905316052d3e94aeb3b4a0d49a27c0f852])
* (edit) 
flume-ng-core/src/test/java/org/apache/flume/interceptor/TestTimestampInterceptor.java
* (edit) 
flume-ng-core/src/main/java/org/apache/flume/interceptor/TimestampInterceptor.java
* (edit) flume-ng-doc/sphinx/FlumeUserGuide.rst


> Timestamp interceptor should support custom headers
> ---
>
> Key: FLUME-1520
> URL: https://issues.apache.org/jira/browse/FLUME-1520
> Project: Flume
>  Issue Type: Improvement
>Reporter: Hari Shreedharan
>Assignee: Hari Shreedharan
> Fix For: 1.8.0
>
> Attachments: FLUME-1520-2.patch, FLUME-1520-3.patch, FLUME-1520.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLUME-1520) Timestamp interceptor should support custom headers

2017-09-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161869#comment-16161869
 ] 

ASF subversion and git services commented on FLUME-1520:


Commit 13771c905316052d3e94aeb3b4a0d49a27c0f852 in flume's branch 
refs/heads/trunk from [~denes]
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=13771c9 ]

FLUME-1520. Timestamp interceptor should support custom headers

This change adds a configuration parameter to the TimestampInterceptor
for the user to be able to define the name of the timestamp header.

Reviewers: Tristan Stevens, Attila Simon

(Hari Shreedharan, Tristan Stevens, Attila Simon via Denes Arvay)


> Timestamp interceptor should support custom headers
> ---
>
> Key: FLUME-1520
> URL: https://issues.apache.org/jira/browse/FLUME-1520
> Project: Flume
>  Issue Type: Improvement
>Reporter: Hari Shreedharan
>Assignee: Hari Shreedharan
> Fix For: 1.8.0
>
> Attachments: FLUME-1520-2.patch, FLUME-1520-3.patch, FLUME-1520.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLUME-1520) Timestamp interceptor should support custom headers

2017-07-21 Thread Denes Arvay (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096017#comment-16096017
 ] 

Denes Arvay commented on FLUME-1520:


Thank you all for the contribution, I'll commit the latest patch if there are 
no concerns.

> Timestamp interceptor should support custom headers
> ---
>
> Key: FLUME-1520
> URL: https://issues.apache.org/jira/browse/FLUME-1520
> Project: Flume
>  Issue Type: Improvement
>Reporter: Hari Shreedharan
>Assignee: Hari Shreedharan
> Fix For: 1.8.0
>
> Attachments: FLUME-1520-2.patch, FLUME-1520-3.patch, FLUME-1520.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLUME-1520) Timestamp interceptor should support custom headers

2017-07-20 Thread Attila Simon (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094497#comment-16094497
 ] 

Attila Simon commented on FLUME-1520:
-

Hi [~tmgstev],

The 2nd patch contains an extra file. I guess it was added by mistake: 
flume-ng-core/src/main/java/org/apache/flume/interceptor/TimestampInterceptor.java.orig
Unfortunately the patch fails maven build on checkstyle. 

Overall the doc, test and functionality looks good to me. 
I'm only nitpicking on the naming:
{code}
public class TimestampInterceptor implements Interceptor {
private final String header;
...
  public static class Constants {
public static final String CONFIG_PRESERVE = "preserveExisting";
public static final boolean DEFAULT_PRESERVE = false;
public static final String CONFIG_HEADER_NAME = "headerName";
public static final String DEFAULT_HEADER_NAME = "timestamp";
  }
{code}

I have this renaming and using final for constants as well as removed some 
unused local variables from the tests. I upload a patch which compiles and 
passes junit as well. Please feel free to use it (completely or parts) if you 
like.


> Timestamp interceptor should support custom headers
> ---
>
> Key: FLUME-1520
> URL: https://issues.apache.org/jira/browse/FLUME-1520
> Project: Flume
>  Issue Type: Improvement
>Reporter: Hari Shreedharan
>Assignee: Hari Shreedharan
> Fix For: 1.8.0
>
> Attachments: FLUME-1520-2.patch, FLUME-1520-3.patch, FLUME-1520.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)