Re: [FM3] Should localized template lookup be off by default?
Hi Daniel, >> * Assuming that the caching works the IO is minimal even for cache misses >> * Assuming that the little IO becomes relevant those user will be heavy >> users anyway >> >> Thanks in advance, >> >> Siegfried Goeschl >> >> >>> On 14 Jun 2017, at 11:12, Daniel Dekanywrote: >>> >>> Tuesday, June 13, 2017, 2:49:17 PM, brede...@me.com wrote: >>> -1 I think that is one place where feature by default is better than performance by default. >>> >>> OK, but why? With caching the performance impact is minimal so I don’t see why it is a concern. For specialised applications the opt-out setting is there and should be used. >>> The reason I prefer opt-in approach (as opposed to opt-out) here is >>> that you won't use this feature unless you are aware of its existence. >>> But if you are aware of its existence, and you want to use it too, >>> then certainly you will see that you have to turn it on. That is assuming that users will read the manual ;-) We don’t want people to turn away from FreeMarker because they assume the feature is missing or not working when they try (foo_en.ftl is almost a standard for localisation). That is only my opinion. Cheers, — Denis. >>> For the >>> others, who are the vast majority of users, why waste resources >>> (especially I/O) on something they will not use? For low level >>> libraries things like that mater, because you can't anticipate the use >>> cases. In some applications they may need to keep the >>> templateUpdateDelay low, and have many templates, so cache misses are >>> frequent. >>> Are the missing files cached? >>> >>> Yes, the fact that a file is missing is cached, for >>> cfg.templateUpdateDelay duration. >>> Cheers, -- Denis. Original Message From: Daniel Dekany Sent: Tuesday, 13 June 2017 13:19 To: dev@freemarker.incubator.apache.org Reply To: dev@freemarker.incubator.apache.org Subject: [FM3] Should localized template lookup be off by deault? In FM2 the localizedLookup configuration setting defaults to true, so by default if you issue cfg.getTemplate("foo.ftl") and cfg.locale is en_US, then FM will look for foo_en_US.ftl, then foo_en.ftl, then foo.ftl. I think most users don't use localized lookup, and they don't realize that this is happening, while this means extra I/O. I propose that in FM3 we change the default of this setting to false. >>> >>> -- >>> Thanks, >>> Daniel Dekany >>> >> >> > > -- > Thanks, > Daniel Dekany
Re: [FM3] Should localized template lookup be off by default?
Wednesday, June 14, 2017, 11:55:10 AM, Siegfried Goeschl wrote: > Hi folks, > > sorry to skip in as FM rookie :-) > > IMHO both approaches (opt-in & opt-out) are valid but I personally lean > towards opt-out > > * The newbie (and casual user) is delighted if a useful feature works out of > the box > * Changing the existing behaviour is an annoying (and potentially > breaking) change for existing users Note that FM3 is practically another template engine (see rationale on https://cwiki.apache.org/confluence/display/FREEMARKER/FreeMarker+3), so assuming someone doesn't approach it with that mind set, the annoyance factor is maximized anyway. I'm seriously considering renaming FM3 to FreeMarker NG 1.0.0 or such, just to avoid that. > * Assuming that the caching works the IO is minimal even for cache misses > * Assuming that the little IO becomes relevant those user will be heavy users > anyway > > Thanks in advance, > > Siegfried Goeschl > > >> On 14 Jun 2017, at 11:12, Daniel Dekanywrote: >> >> Tuesday, June 13, 2017, 2:49:17 PM, brede...@me.com wrote: >> >>> -1 >>> >>> I think that is one place where feature by default is better than >>> performance by default. >> >> OK, but why? >> >> The reason I prefer opt-in approach (as opposed to opt-out) here is >> that you won't use this feature unless you are aware of its existence. >> But if you are aware of its existence, and you want to use it too, >> then certainly you will see that you have to turn it on. For the >> others, who are the vast majority of users, why waste resources >> (especially I/O) on something they will not use? For low level >> libraries things like that mater, because you can't anticipate the use >> cases. In some applications they may need to keep the >> templateUpdateDelay low, and have many templates, so cache misses are >> frequent. >> >>> Are the missing files cached? >> >> Yes, the fact that a file is missing is cached, for >> cfg.templateUpdateDelay duration. >> >>> Cheers, >>> >>> -- Denis. >>> Original Message >>> From: Daniel Dekany >>> Sent: Tuesday, 13 June 2017 13:19 >>> To: dev@freemarker.incubator.apache.org >>> Reply To: dev@freemarker.incubator.apache.org >>> Subject: [FM3] Should localized template lookup be off by deault? >>> >>> In FM2 the localizedLookup configuration setting defaults to true, so >>> by default if you issue cfg.getTemplate("foo.ftl") and cfg.locale is >>> en_US, then FM will look for foo_en_US.ftl, then foo_en.ftl, then >>> foo.ftl. I think most users don't use localized lookup, and they don't >>> realize that this is happening, while this means extra I/O. >>> >>> I propose that in FM3 we change the default of this setting to false. >>> >> >> -- >> Thanks, >> Daniel Dekany >> > > -- Thanks, Daniel Dekany
Re: [FM3] Should localized template lookup be off by default?
+1 for turning it off by default. Just make sure it is clearly described in the localization section of the manual. I know it always depends but outofthebox-performance is more important here in my opinion. Am 14.06.2017 4:20 nachm. schrieb "Woonsan Ko": > I don't think the template lookup feature based on locale is used > often in practices, either. > In FM3, I think people need to follow a guideline on how to migrate > FM2 anyway, so it seems just fine to me if we turn it off by default > as the feature requires additional IOs. > > Regards, > > Woonsan > > > On Wed, Jun 14, 2017 at 5:55 AM, Siegfried Goeschl > wrote: > > Hi folks, > > > > sorry to skip in as FM rookie :-) > > > > IMHO both approaches (opt-in & opt-out) are valid but I personally lean > towards opt-out > > > > * The newbie (and casual user) is delighted if a useful feature works > out of the box > > * Changing the existing behaviour is an annoying (and potentially > breaking) change for existing users > > * Assuming that the caching works the IO is minimal even for cache misses > > * Assuming that the little IO becomes relevant those user will be heavy > users anyway > > > > Thanks in advance, > > > > Siegfried Goeschl > > > > > >> On 14 Jun 2017, at 11:12, Daniel Dekany wrote: > >> > >> Tuesday, June 13, 2017, 2:49:17 PM, brede...@me.com wrote: > >> > >>> -1 > >>> > >>> I think that is one place where feature by default is better than > performance by default. > >> > >> OK, but why? > >> > >> The reason I prefer opt-in approach (as opposed to opt-out) here is > >> that you won't use this feature unless you are aware of its existence. > >> But if you are aware of its existence, and you want to use it too, > >> then certainly you will see that you have to turn it on. For the > >> others, who are the vast majority of users, why waste resources > >> (especially I/O) on something they will not use? For low level > >> libraries things like that mater, because you can't anticipate the use > >> cases. In some applications they may need to keep the > >> templateUpdateDelay low, and have many templates, so cache misses are > >> frequent. > >> > >>> Are the missing files cached? > >> > >> Yes, the fact that a file is missing is cached, for > >> cfg.templateUpdateDelay duration. > >> > >>> Cheers, > >>> > >>> -- Denis. > >>> Original Message > >>> From: Daniel Dekany > >>> Sent: Tuesday, 13 June 2017 13:19 > >>> To: dev@freemarker.incubator.apache.org > >>> Reply To: dev@freemarker.incubator.apache.org > >>> Subject: [FM3] Should localized template lookup be off by deault? > >>> > >>> In FM2 the localizedLookup configuration setting defaults to true, so > >>> by default if you issue cfg.getTemplate("foo.ftl") and cfg.locale is > >>> en_US, then FM will look for foo_en_US.ftl, then foo_en.ftl, then > >>> foo.ftl. I think most users don't use localized lookup, and they don't > >>> realize that this is happening, while this means extra I/O. > >>> > >>> I propose that in FM3 we change the default of this setting to false. > >>> > >> > >> -- > >> Thanks, > >> Daniel Dekany > >> > > > -- Synesty GmbH Moritz-von-Rohr-Str. 1a 07745 Jena Tel.: +49 3641 559649 Fax.: +49 3641 5596499 Internet: http://synesty.com Geschäftsführer: Christoph Rüger Unternehmenssitz: Jena Handelsregister B beim Amtsgericht: Jena Handelsregister-Nummer: HRB 508766 Ust-IdNr.: DE287564982
Re: [FM3] Should localized template lookup be off by default?
I don't think the template lookup feature based on locale is used often in practices, either. In FM3, I think people need to follow a guideline on how to migrate FM2 anyway, so it seems just fine to me if we turn it off by default as the feature requires additional IOs. Regards, Woonsan On Wed, Jun 14, 2017 at 5:55 AM, Siegfried Goeschlwrote: > Hi folks, > > sorry to skip in as FM rookie :-) > > IMHO both approaches (opt-in & opt-out) are valid but I personally lean > towards opt-out > > * The newbie (and casual user) is delighted if a useful feature works out of > the box > * Changing the existing behaviour is an annoying (and potentially breaking) > change for existing users > * Assuming that the caching works the IO is minimal even for cache misses > * Assuming that the little IO becomes relevant those user will be heavy users > anyway > > Thanks in advance, > > Siegfried Goeschl > > >> On 14 Jun 2017, at 11:12, Daniel Dekany wrote: >> >> Tuesday, June 13, 2017, 2:49:17 PM, brede...@me.com wrote: >> >>> -1 >>> >>> I think that is one place where feature by default is better than >>> performance by default. >> >> OK, but why? >> >> The reason I prefer opt-in approach (as opposed to opt-out) here is >> that you won't use this feature unless you are aware of its existence. >> But if you are aware of its existence, and you want to use it too, >> then certainly you will see that you have to turn it on. For the >> others, who are the vast majority of users, why waste resources >> (especially I/O) on something they will not use? For low level >> libraries things like that mater, because you can't anticipate the use >> cases. In some applications they may need to keep the >> templateUpdateDelay low, and have many templates, so cache misses are >> frequent. >> >>> Are the missing files cached? >> >> Yes, the fact that a file is missing is cached, for >> cfg.templateUpdateDelay duration. >> >>> Cheers, >>> >>> -- Denis. >>> Original Message >>> From: Daniel Dekany >>> Sent: Tuesday, 13 June 2017 13:19 >>> To: dev@freemarker.incubator.apache.org >>> Reply To: dev@freemarker.incubator.apache.org >>> Subject: [FM3] Should localized template lookup be off by deault? >>> >>> In FM2 the localizedLookup configuration setting defaults to true, so >>> by default if you issue cfg.getTemplate("foo.ftl") and cfg.locale is >>> en_US, then FM will look for foo_en_US.ftl, then foo_en.ftl, then >>> foo.ftl. I think most users don't use localized lookup, and they don't >>> realize that this is happening, while this means extra I/O. >>> >>> I propose that in FM3 we change the default of this setting to false. >>> >> >> -- >> Thanks, >> Daniel Dekany >> >
Re: [FM3] Should localized template lookup be off by default?
Hi folks, sorry to skip in as FM rookie :-) IMHO both approaches (opt-in & opt-out) are valid but I personally lean towards opt-out * The newbie (and casual user) is delighted if a useful feature works out of the box * Changing the existing behaviour is an annoying (and potentially breaking) change for existing users * Assuming that the caching works the IO is minimal even for cache misses * Assuming that the little IO becomes relevant those user will be heavy users anyway Thanks in advance, Siegfried Goeschl > On 14 Jun 2017, at 11:12, Daniel Dekanywrote: > > Tuesday, June 13, 2017, 2:49:17 PM, brede...@me.com wrote: > >> -1 >> >> I think that is one place where feature by default is better than >> performance by default. > > OK, but why? > > The reason I prefer opt-in approach (as opposed to opt-out) here is > that you won't use this feature unless you are aware of its existence. > But if you are aware of its existence, and you want to use it too, > then certainly you will see that you have to turn it on. For the > others, who are the vast majority of users, why waste resources > (especially I/O) on something they will not use? For low level > libraries things like that mater, because you can't anticipate the use > cases. In some applications they may need to keep the > templateUpdateDelay low, and have many templates, so cache misses are > frequent. > >> Are the missing files cached? > > Yes, the fact that a file is missing is cached, for > cfg.templateUpdateDelay duration. > >> Cheers, >> >> -- Denis. >> Original Message >> From: Daniel Dekany >> Sent: Tuesday, 13 June 2017 13:19 >> To: dev@freemarker.incubator.apache.org >> Reply To: dev@freemarker.incubator.apache.org >> Subject: [FM3] Should localized template lookup be off by deault? >> >> In FM2 the localizedLookup configuration setting defaults to true, so >> by default if you issue cfg.getTemplate("foo.ftl") and cfg.locale is >> en_US, then FM will look for foo_en_US.ftl, then foo_en.ftl, then >> foo.ftl. I think most users don't use localized lookup, and they don't >> realize that this is happening, while this means extra I/O. >> >> I propose that in FM3 we change the default of this setting to false. >> > > -- > Thanks, > Daniel Dekany >
Re: [FM3] Should localized template lookup be off by default?
-1 I think that is one place where feature by default is better than performance by default. Are the missing files cached? Cheers, -- Denis. Original Message From: Daniel Dekany Sent: Tuesday, 13 June 2017 13:19 To: dev@freemarker.incubator.apache.org Reply To: dev@freemarker.incubator.apache.org Subject: [FM3] Should localized template lookup be off by deault? In FM2 the localizedLookup configuration setting defaults to true, so by default if you issue cfg.getTemplate("foo.ftl") and cfg.locale is en_US, then FM will look for foo_en_US.ftl, then foo_en.ftl, then foo.ftl. I think most users don't use localized lookup, and they don't realize that this is happening, while this means extra I/O. I propose that in FM3 we change the default of this setting to false. -- Thanks, Daniel Dekany