[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447135#comment-16447135 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/243 > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang >Priority: Major > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447133#comment-16447133 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/243 # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/243?src=pr=h1) Report > Merging [#243](https://codecov.io/gh/apache/incubator-gearpump/pull/243?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/2d13b9cf883ee59b97751d992c2b52dc4068b16c?src=pr=desc) will **decrease** coverage by `0.06%`. > The diff coverage is `n/a`. ```diff @@Coverage Diff @@ ## master #243 +/- ## == - Coverage 68.98% 68.91% -0.07% == Files 191 191 Lines6171 6171 Branches 546 546 == - Hits 4257 4253 -4 - Misses 1914 1918 +4 ``` > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang >Priority: Major > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447128#comment-16447128 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/243 +1 > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang >Priority: Major > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447123#comment-16447123 ] ASF GitHub Bot commented on GEARPUMP-339: - GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/243 [GEARPUMP-339] Fix unknown tag parameter Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuzhang/incubator-gearpump improve_scaladoc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/243.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #243 commit 20024e1f4d43e776487cabcf67632d644fab07ae Author: manuzhangDate: 2018-04-22T07:17:51Z [GEARPUMP-339] Fix unknown tag parameter > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang >Priority: Major > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125202#comment-16125202 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/213 > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125143#comment-16125143 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 +1 > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125135#comment-16125135 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 BTW, the tests passes locally and this PR doesn't touch any codes. > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125128#comment-16125128 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/213#discussion_r132863041 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala --- @@ -137,11 +156,14 @@ class DefaultWindowRunner[IN, OUT]( } onTrigger(outputs, newWmk) } else { - // minimum of end of last triggered window and start of first un-triggered window + // The output watermark is the minimum of end of last triggered window + // and start of first un-triggered window TriggeredOutputs(outputs, TaskUtil.min(wmk, firstWin.startTime)) } } else { +// All windows have been triggered. if (time == Watermark.MAX) { + // This means there will no more inputs so it's safe to advance to the maximum watermark. --- End diff -- there will be no more > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125124#comment-16125124 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 Maybe it's killed after hanging since it took longer than usual. > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124939#comment-16124939 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/213 No unit test failed, so where does the failure come from? > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115949#comment-16115949 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/212 > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115825#comment-16115825 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/212#discussion_r131545040 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/scalaapi/StreamApp.scala --- @@ -62,6 +62,17 @@ class StreamApp( val dag = planner.plan(graph) StreamApplication(name, dag, userConfig) } + + def source[T](dataSource: DataSource, parallelism: Int = 1, + conf: UserConfig = UserConfig.empty, description: String = "source"): Stream[T] = { +implicit val sourceOp = DataSourceOp(dataSource, parallelism, description, conf) --- End diff -- Has to be implicit? > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115826#comment-16115826 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/212 Generally LGTM > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115669#comment-16115669 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/212 R: @huafengw > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115668#comment-16115668 ] ASF GitHub Bot commented on GEARPUMP-339: - GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/212 [GEARPUMP-339] Add ScalaDoc to Streaming DSL Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuzhang/incubator-gearpump plan_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #212 commit c2446fb54fce1ce727243be45391710d4a0dee0f Author: manuzhangDate: 2017-08-05T16:56:18Z [GEARPUMP-339] Add ScalaDoc to Streaming DSL > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115360#comment-16115360 ] Manu Zhang commented on GEARPUMP-339: - [genjavadoc doesn't support translating tparam tag|https://github.com/typesafehub/genjavadoc/issues/65] so we have to put up with Intellij complaining "Unknown Tag Parameter" or disable the inspection. > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115358#comment-16115358 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user manuzhang commented on the issue: https://github.com/apache/incubator-gearpump/pull/210 @huafengw Unfortunately, [genjavadoc doesn't support translating tparam tag](https://github.com/typesafehub/genjavadoc/issues/65). I will record this in jira and let's revisit when it's supported. > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115359#comment-16115359 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user manuzhang closed the pull request at: https://github.com/apache/incubator-gearpump/pull/210 > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115352#comment-16115352 ] ASF GitHub Bot commented on GEARPUMP-339: - Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/210 LGTM > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes
[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115351#comment-16115351 ] ASF GitHub Bot commented on GEARPUMP-339: - GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/210 [GEARPUMP-339] Fix unknown tag parameter Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit message is formatted like: `[GEARPUMP-] Meaningful description of pull request` - [ ] Make sure tests pass via `sbt clean test`. - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuzhang/incubator-gearpump improve_scaladoc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #210 commit c9759ba5edb1ab7b9c5d81e2f0810a8f4712b256 Author: manuzhangDate: 2017-08-05T09:41:31Z [GEARPUMP-339] Fix unknown tag parameter > Improve ScalaDoc for all public classes > --- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement >Affects Versions: 0.8.4 >Reporter: Manu Zhang >Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)