[jira] [Commented] (GEARPUMP-369) "executor-num" is overridden by the default value for arg "executors"(1)
[
https://issues.apache.org/jira/browse/GEARPUMP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427064#comment-16427064
]
ASF GitHub Bot commented on GEARPUMP-369:
-
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/242
> "executor-num" is overridden by the default value for arg "executors"(1)
> -
>
> Key: GEARPUMP-369
> URL: https://issues.apache.org/jira/browse/GEARPUMP-369
> Project: Apache Gearpump
> Issue Type: Bug
> Components: core
>Affects Versions: 0.8.4, 0.8.5
>Reporter: Hashan Gayasri Udugahapattuwa
>Priority: Minor
>
> org/apache/gearpump/cluster/main/AppSubmitter.scala:62
> System.setProperty(Constants.APPLICATION_EXECUTOR_NUMBER,
> config.getInt("executors").toString)
>
> replaces the value set by system properties (gear.conf) by the default
> value(1) even when no value is passed at as an argument. The expected
> behaviour is to only override the value when a value is given explicitly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEARPUMP-369) "executor-num" is overridden by the default value for arg "executors"(1)
[
https://issues.apache.org/jira/browse/GEARPUMP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426824#comment-16426824
]
ASF GitHub Bot commented on GEARPUMP-369:
-
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/242
+1
> "executor-num" is overridden by the default value for arg "executors"(1)
> -
>
> Key: GEARPUMP-369
> URL: https://issues.apache.org/jira/browse/GEARPUMP-369
> Project: Apache Gearpump
> Issue Type: Bug
> Components: core
>Affects Versions: 0.8.4, 0.8.5
>Reporter: Hashan Gayasri Udugahapattuwa
>Priority: Minor
>
> org/apache/gearpump/cluster/main/AppSubmitter.scala:62
> System.setProperty(Constants.APPLICATION_EXECUTOR_NUMBER,
> config.getInt("executors").toString)
>
> replaces the value set by system properties (gear.conf) by the default
> value(1) even when no value is passed at as an argument. The expected
> behaviour is to only override the value when a value is given explicitly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEARPUMP-369) "executor-num" is overridden by the default value for arg "executors"(1)
[
https://issues.apache.org/jira/browse/GEARPUMP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426716#comment-16426716
]
ASF GitHub Bot commented on GEARPUMP-369:
-
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/242
#
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/242?src=pr&el=h1)
Report
> Merging
[#242](https://codecov.io/gh/apache/incubator-gearpump/pull/242?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/8aac07b86d4b90e4f5118f3204610d3510f93b02?src=pr&el=desc)
will **increase** coverage by `0.09%`.
> The diff coverage is `50%`.
```diff
@@Coverage Diff @@
## master #242 +/- ##
==
+ Coverage 68.94% 69.03% +0.09%
==
Files 191 191
Lines6128 6130 +2
Branches 542 540 -2
==
+ Hits 4225 4232 +7
+ Misses 1903 1898 -5
```
> "executor-num" is overridden by the default value for arg "executors"(1)
> -
>
> Key: GEARPUMP-369
> URL: https://issues.apache.org/jira/browse/GEARPUMP-369
> Project: Apache Gearpump
> Issue Type: Bug
> Components: core
>Affects Versions: 0.8.4, 0.8.5
>Reporter: Hashan Gayasri Udugahapattuwa
>Priority: Minor
>
> org/apache/gearpump/cluster/main/AppSubmitter.scala:62
> System.setProperty(Constants.APPLICATION_EXECUTOR_NUMBER,
> config.getInt("executors").toString)
>
> replaces the value set by system properties (gear.conf) by the default
> value(1) even when no value is passed at as an argument. The expected
> behaviour is to only override the value when a value is given explicitly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEARPUMP-369) "executor-num" is overridden by the default value for arg "executors"(1)
[
https://issues.apache.org/jira/browse/GEARPUMP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426698#comment-16426698
]
ASF GitHub Bot commented on GEARPUMP-369:
-
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/242
R: @huafengw
> "executor-num" is overridden by the default value for arg "executors"(1)
> -
>
> Key: GEARPUMP-369
> URL: https://issues.apache.org/jira/browse/GEARPUMP-369
> Project: Apache Gearpump
> Issue Type: Bug
> Components: core
>Affects Versions: 0.8.4, 0.8.5
>Reporter: Hashan Gayasri Udugahapattuwa
>Priority: Minor
>
> org/apache/gearpump/cluster/main/AppSubmitter.scala:62
> System.setProperty(Constants.APPLICATION_EXECUTOR_NUMBER,
> config.getInt("executors").toString)
>
> replaces the value set by system properties (gear.conf) by the default
> value(1) even when no value is passed at as an argument. The expected
> behaviour is to only override the value when a value is given explicitly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEARPUMP-369) "executor-num" is overridden by the default value for arg "executors"(1)
[
https://issues.apache.org/jira/browse/GEARPUMP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426697#comment-16426697
]
ASF GitHub Bot commented on GEARPUMP-369:
-
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/242
[GEARPUMP-369] Fix configuring number of executors
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been
updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump
fix_config_executor_num
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #242
commit 669f4e1ea4669d98fe34a56900bd41a03918787d
Author: manuzhang
Date: 2018-04-05T10:04:35Z
[GEARPUMP-369] Fix configuring number of executors
> "executor-num" is overridden by the default value for arg "executors"(1)
> -
>
> Key: GEARPUMP-369
> URL: https://issues.apache.org/jira/browse/GEARPUMP-369
> Project: Apache Gearpump
> Issue Type: Bug
> Components: core
>Affects Versions: 0.8.4, 0.8.5
>Reporter: Hashan Gayasri Udugahapattuwa
>Priority: Minor
>
> org/apache/gearpump/cluster/main/AppSubmitter.scala:62
> System.setProperty(Constants.APPLICATION_EXECUTOR_NUMBER,
> config.getInt("executors").toString)
>
> replaces the value set by system properties (gear.conf) by the default
> value(1) even when no value is passed at as an argument. The expected
> behaviour is to only override the value when a value is given explicitly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
