[jira] [Updated] (GEODE-2572) Implement a getCache method for LuceneService

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun updated GEODE-2572:
---
Fix Version/s: 1.2.0

> Implement a getCache method for LuceneService
> -
>
> Key: GEODE-2572
> URL: https://issues.apache.org/jira/browse/GEODE-2572
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
> Fix For: 1.2.0
>
>
> LuceneService.getCache should return the cache which was used to init the 
> LuceneServiceImpl



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2572) Implement a getCache method for LuceneService

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun resolved GEODE-2572.

Resolution: Fixed

> Implement a getCache method for LuceneService
> -
>
> Key: GEODE-2572
> URL: https://issues.apache.org/jira/browse/GEODE-2572
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
> Fix For: 1.2.0
>
>
> LuceneService.getCache should return the cache which was used to init the 
> LuceneServiceImpl



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2572) Implement a getCache method for LuceneService

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891703#comment-15891703
 ] 

ASF subversion and git services commented on GEODE-2572:


Commit ab5650672077bd52109e2687ab9d91384a3fe12b in geode's branch 
refs/heads/develop from nabarunnag
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ab56506 ]

GEODE-2572: getCache method implemented for LuceneService

* getCache method implemented for LuceneService
* simple integration test to validate the result of 
LuceneService.getCache


> Implement a getCache method for LuceneService
> -
>
> Key: GEODE-2572
> URL: https://issues.apache.org/jira/browse/GEODE-2572
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> LuceneService.getCache should return the cache which was used to init the 
> LuceneServiceImpl



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Gfsh> Create regions with bad property values?

[Kirk Lund]

That's a result of replacing geode-joptsimple with a dependency on the
binary release of jopt-simple.

geode-joptsimple was a forked version that added this functionality.
Unfortunately this was implemented in a rather dodgy way by adding fields
to some internal exceptions which were then treated as a return type. We
would have to figure out a more appropriate way to implement this in order
to contribute an enhancement like this to jopt-simple.

This work is quite low in the priorities right now.

On Tue, Feb 28, 2017 at 9:17 PM Real Wes  wrote:

> This works in Geode 1.1.0 where GemFire 8 failed:
>
> gfsh> create region --name=Testxxx --type=PARTITION_REDUNDANT_HEAP_LRU
> --badProperty=badValue
>
>
> Is ignoring bad properties by design?  Or a bug?
>
> Thanks,
> Wes Williams
>
>
>

[jira] [Commented] (GEODE-2573) Client authentication to secured geode cluster fails

[Nilkanth Patel (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891639#comment-15891639
 ] 

Nilkanth Patel commented on GEODE-2573:
---

[~abiketov] IMO, you need to provide a mechanism by which credentials are 
submitted to server.

Can you try using adding one more property in your client program and give a 
try like,
config.setProperty("security-client-auth-init",
"org.apache.geode.security.templates.UserPasswordAuthInit.create"); 

> Client authentication to secured geode cluster fails
> 
>
> Key: GEODE-2573
> URL: https://issues.apache.org/jira/browse/GEODE-2573
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.1.0
>Reporter: Andrei Biketov
>
> I have simple setup: one locator and one server, both secured. Now I'm trying 
> to connect to the cluster from the client. I'm passing credentials as 
> security-username/security-password from the client but I'm getting exception:
> [info 2017/03/01 22:45:40.220 EST  tid=0x1b] Error 
> prefilling connections : 
> org.apache.geode.security.AuthenticationRequiredException: No security 
> credentials are provided
> org.apache.geode.security.AuthenticationRequiredException: No security 
> credentials are provided
>   at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.readMessage(HandShake.java:1473)
>   at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.greet(HandShake.java:1327)
>   at 
> org.apache.geode.cache.client.internal.ConnectionImpl.connect(ConnectionImpl.java:108)
>   at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:135)
>   at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:252)
>   at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefillConnection(ConnectionManagerImpl.java:758)
>   at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefill(ConnectionManagerImpl.java:701)
>   at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$PrefillConnectionsTask.run2(ConnectionManagerImpl.java:852)
>   at 
> org.apache.geode.cache.client.internal.PoolImpl$PoolTask.run(PoolImpl.java:1235)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Code:
> ClientCache cache = null;
>   Properties props = new Properties();
>   props.setProperty("security-username", "admin");
>   props.setProperty("security-password", "secret");
>   try {
>   System.out.println("Client app connecting to Geode 
> cluster");
>   cache = new 
> ClientCacheFactory(props).addPoolLocator("localhost", 10334).create();
>   
>   Region customer = 
> cache.getRegion("customer");
>   String value = customer.get("1");
>System.out.println("Value from the region:" + value);
>   } catch (Exception e) {
>   System.out.println("Error creating the Client Cache'");
>   System.out.println(e.getCause());
>   throw e;
>   }



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57229: getCache method implemented for LuceneServiceImpl

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57229/#review167647
---


Ship it!




Ship It!

- Dan Smith


On March 2, 2017, 2:47 a.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57229/
> ---
> 
> (Updated March 2, 2017, 2:47 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, Lynn Hughes-Godfrey, 
> Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Create a getCache method for LuceneServiceImpl  which will return the cache 
> which was used to init the LuceneServiceImpl
> 
> Also added a simple test to test the new method
> 
> 
> Diffs
> -
> 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java 
> 5cfae59 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
>  a1a6ef3 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
>  9b382e6 
> 
> 
> Diff: https://reviews.apache.org/r/57229/diff/1/
> 
> 
> Testing
> ---
> 
> SpotlessApply
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

[jira] [Updated] (GEODE-2573) Client authentication to secured geode cluster fails

[Andrei Biketov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Biketov updated GEODE-2573:
--
Affects Version/s: 1.1.0
  Description: 
I have simple setup: one locator and one server, both secured. Now I'm trying 
to connect to the cluster from the client. I'm passing credentials as 
security-username/security-password from the client but I'm getting exception:
[info 2017/03/01 22:45:40.220 EST  tid=0x1b] Error 
prefilling connections : 
org.apache.geode.security.AuthenticationRequiredException: No security 
credentials are provided
org.apache.geode.security.AuthenticationRequiredException: No security 
credentials are provided
at 
org.apache.geode.internal.cache.tier.sockets.HandShake.readMessage(HandShake.java:1473)
at 
org.apache.geode.internal.cache.tier.sockets.HandShake.greet(HandShake.java:1327)
at 
org.apache.geode.cache.client.internal.ConnectionImpl.connect(ConnectionImpl.java:108)
at 
org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:135)
at 
org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:252)
at 
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefillConnection(ConnectionManagerImpl.java:758)
at 
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefill(ConnectionManagerImpl.java:701)
at 
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$PrefillConnectionsTask.run2(ConnectionManagerImpl.java:852)
at 
org.apache.geode.cache.client.internal.PoolImpl$PoolTask.run(PoolImpl.java:1235)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

Code:
ClientCache cache = null;

Properties props = new Properties();
props.setProperty("security-username", "admin");
props.setProperty("security-password", "secret");

try {
System.out.println("Client app connecting to Geode 
cluster");
cache = new 
ClientCacheFactory(props).addPoolLocator("localhost", 10334).create();


Region customer = 
cache.getRegion("customer");
String value = customer.get("1");

 System.out.println("Value from the region:" + value);

} catch (Exception e) {
System.out.println("Error creating the Client Cache'");
System.out.println(e.getCause());
throw e;
}

  was:
I have simple setup: one locator and one server, both secured. Now I'm trying 
to connect to the cluster from the client. I'm passing credentials as 
security-username/security-password from the client but I'm getting exception:
org.apache.geode.security.AuthenticationRequiredException: No security-* 
properties are provided
at 
org.apache.geode.internal.cache.tier.sockets.HandShake.readMessage(HandShake.java:1473)
at 
org.apache.geode.internal.cache.tier.sockets.HandShake.greet(HandShake.java:1327)
at 
org.apache.geode.cache.client.internal.ConnectionImpl.connect(ConnectionImpl.java:108)
at 
org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:135)
at 
org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:252)
at 
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefillConnection(ConnectionManagerImpl.java:758)
at 
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefill(ConnectionManagerImpl.java:701)
at 
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$PrefillConnectionsTask.run2(ConnectionManagerImpl.java:852)
at 
org.apache.geode.cache.client.internal.PoolImpl$PoolTask.run(PoolImpl.java:1235)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

Code:
ClientCache cache = null;

Properties props = new Properties();
props.setProperty("security-username", "admin");
props.setProperty("security-password", "secret");

try {
System.out.println("Client app connecting to Geode 
cluster");
cache = new 
ClientCacheFactory(props).addPoolLocator("localhost", 

[jira] [Updated] (GEODE-2573) Client authentication to secured geode cluster fails

[Andrei Biketov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Biketov updated GEODE-2573:
--

Hi Anthony,

Turned out that was geode 1.0.0 version.
I just downloaded 1.1.0 and reproduced same scenario. Exception is a bit
different:
[info 2017/03/01 22:36:56.771 EST  tid=0x1b] Error
prefilling connections :
org.apache.geode.security.AuthenticationRequiredException: No security
credentials are provided
org.apache.geode.security.AuthenticationRequiredException: No security
credentials are provided
at
org.apache.geode.internal.cache.tier.sockets.HandShake.readMessage(HandShake.java:1473)
at
org.apache.geode.internal.cache.tier.sockets.HandShake.greet(HandShake.java:1327)
at
org.apache.geode.cache.client.internal.ConnectionImpl.connect(ConnectionImpl.java:108)
at
org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:135)
at
org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:252)
at
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefillConnection(ConnectionManagerImpl.java:758)
at
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefill(ConnectionManagerImpl.java:701)
at
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$PrefillConnectionsTask.run2(ConnectionManagerImpl.java:852)
at
org.apache.geode.cache.client.internal.PoolImpl$PoolTask.run(PoolImpl.java:1235)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

And here is a log:
System Properties:
awt.toolkit = sun.awt.windows.WToolkit
file.encoding = UTF-8
file.encoding.pkg = sun.io
file.separator = \
gemfire.sys.security-password = 
gemfire.sys.security-username = 
java.awt.graphicsenv = sun.awt.Win32GraphicsEnvironment
java.awt.printerjob = sun.awt.windows.WPrinterJob
java.class.version = 52.0
java.endorsed.dirs = C:\tools\Java\jdk1.8.0_121\jre\lib\endorsed
java.ext.dirs =
C:\tools\Java\jdk1.8.0_121\jre\lib\ext;C:\WINDOWS\Sun\Java\lib\ext
java.home = C:\tools\Java\jdk1.8.0_121\jre
java.io.tmpdir =
java.runtime.name = Java(TM) SE Runtime Environment
java.runtime.version = 1.8.0_121-b13
java.specification.name = Java Platform API Specification
java.specification.vendor = Oracle Corporation
java.specification.version = 1.8
java.vendor = Oracle Corporation
java.vendor.url = http://java.oracle.com/
java.vendor.url.bug = http://bugreport.sun.com/bugreport/
java.version = 1.8.0_121
java.vm.info = mixed mode
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.name = Java Virtual Machine Specification
java.vm.specification.vendor = Oracle Corporation
java.vm.specification.version = 1.8
java.vm.vendor = Oracle Corporation
java.vm.version = 25.121-b13
line.separator =

Thanks,

Andrei



On Wed, Mar 1, 2017 at 10:15 PM, Anthony Baker (JIRA) 



> Client authentication to secured geode cluster fails
> 
>
> Key: GEODE-2573
> URL: https://issues.apache.org/jira/browse/GEODE-2573
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Andrei Biketov
>
> I have simple setup: one locator and one server, both secured. Now I'm trying 
> to connect to the cluster from the client. I'm passing credentials as 
> security-username/security-password from the client but I'm getting exception:
> org.apache.geode.security.AuthenticationRequiredException: No security-* 
> properties are provided
>   at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.readMessage(HandShake.java:1473)
>   at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.greet(HandShake.java:1327)
>   at 
> org.apache.geode.cache.client.internal.ConnectionImpl.connect(ConnectionImpl.java:108)
>   at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:135)
>   at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:252)
>   at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefillConnection(ConnectionManagerImpl.java:758)
>   at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefill(ConnectionManagerImpl.java:701)
>   at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$PrefillConnectionsTask.run2(ConnectionManagerImpl.java:852)
>   at 
> 

[jira] [Commented] (GEODE-2573) Client authentication to secured geode cluster fails

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891547#comment-15891547
 ] 

Anthony Baker commented on GEODE-2573:
--

Which version of geode is this?

> Client authentication to secured geode cluster fails
> 
>
> Key: GEODE-2573
> URL: https://issues.apache.org/jira/browse/GEODE-2573
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Andrei Biketov
>
> I have simple setup: one locator and one server, both secured. Now I'm trying 
> to connect to the cluster from the client. I'm passing credentials as 
> security-username/security-password from the client but I'm getting exception:
> org.apache.geode.security.AuthenticationRequiredException: No security-* 
> properties are provided
>   at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.readMessage(HandShake.java:1473)
>   at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.greet(HandShake.java:1327)
>   at 
> org.apache.geode.cache.client.internal.ConnectionImpl.connect(ConnectionImpl.java:108)
>   at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:135)
>   at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:252)
>   at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefillConnection(ConnectionManagerImpl.java:758)
>   at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefill(ConnectionManagerImpl.java:701)
>   at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$PrefillConnectionsTask.run2(ConnectionManagerImpl.java:852)
>   at 
> org.apache.geode.cache.client.internal.PoolImpl$PoolTask.run(PoolImpl.java:1235)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Code:
> ClientCache cache = null;
>   Properties props = new Properties();
>   props.setProperty("security-username", "admin");
>   props.setProperty("security-password", "secret");
>   try {
>   System.out.println("Client app connecting to Geode 
> cluster");
>   cache = new 
> ClientCacheFactory(props).addPoolLocator("localhost", 10334).create();
>   
>   Region customer = 
> cache.getRegion("customer");
>   String value = customer.get("1");
>System.out.println("Value from the region:" + value);
>   } catch (Exception e) {
>   System.out.println("Error creating the Client Cache'");
>   System.out.println(e.getCause());
>   throw e;
>   }



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2573) Client authentication to secured geode cluster fails

[Andrei Biketov (JIRA)]

Andrei Biketov created GEODE-2573:
-

 Summary: Client authentication to secured geode cluster fails
 Key: GEODE-2573
 URL: https://issues.apache.org/jira/browse/GEODE-2573
 Project: Geode
  Issue Type: Bug
  Components: client/server
Reporter: Andrei Biketov


I have simple setup: one locator and one server, both secured. Now I'm trying 
to connect to the cluster from the client. I'm passing credentials as 
security-username/security-password from the client but I'm getting exception:
org.apache.geode.security.AuthenticationRequiredException: No security-* 
properties are provided
at 
org.apache.geode.internal.cache.tier.sockets.HandShake.readMessage(HandShake.java:1473)
at 
org.apache.geode.internal.cache.tier.sockets.HandShake.greet(HandShake.java:1327)
at 
org.apache.geode.cache.client.internal.ConnectionImpl.connect(ConnectionImpl.java:108)
at 
org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:135)
at 
org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:252)
at 
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefillConnection(ConnectionManagerImpl.java:758)
at 
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.prefill(ConnectionManagerImpl.java:701)
at 
org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl$PrefillConnectionsTask.run2(ConnectionManagerImpl.java:852)
at 
org.apache.geode.cache.client.internal.PoolImpl$PoolTask.run(PoolImpl.java:1235)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

Code:
ClientCache cache = null;

Properties props = new Properties();
props.setProperty("security-username", "admin");
props.setProperty("security-password", "secret");

try {
System.out.println("Client app connecting to Geode 
cluster");
cache = new 
ClientCacheFactory(props).addPoolLocator("localhost", 10334).create();


Region customer = 
cache.getRegion("customer");
String value = customer.get("1");

 System.out.println("Value from the region:" + value);

} catch (Exception e) {
System.out.println("Error creating the Client Cache'");
System.out.println(e.getCause());
throw e;
}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 57229: getCache method implemented for LuceneServiceImpl

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57229/
---

Review request for geode, Barry Oglesby, Jason Huynh, Lynn Hughes-Godfrey, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

Create a getCache method for LuceneServiceImpl  which will return the cache 
which was used to init the LuceneServiceImpl

Also added a simple test to test the new method


Diffs
-

  geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java 
5cfae59 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
 a1a6ef3 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplIntegrationTest.java
 9b382e6 


Diff: https://reviews.apache.org/r/57229/diff/1/


Testing
---

SpotlessApply
geode-lucene:precheckin


Thanks,

nabarun nag

[jira] [Assigned] (GEODE-2572) Implement a getCache method for LuceneService

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun reassigned GEODE-2572:
--

Assignee: nabarun

> Implement a getCache method for LuceneService
> -
>
> Key: GEODE-2572
> URL: https://issues.apache.org/jira/browse/GEODE-2572
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> LuceneService.getCache should return the cache which was used to init the 
> LuceneServiceImpl



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2572) Implement a getCache method for LuceneService

[nabarun (JIRA)]

nabarun created GEODE-2572:
--

 Summary: Implement a getCache method for LuceneService
 Key: GEODE-2572
 URL: https://issues.apache.org/jira/browse/GEODE-2572
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: nabarun


LuceneService.getCache should return the cache which was used to init the 
LuceneServiceImpl



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Also Requesting more JIRA permission

[Diane Rose Hardman]

Similar to Addison's request earlier, as a PM I too would like pmerission
to edit Jira tickets.
Addison and I have discussed ways to better organize our process of pulling
Jira tickets into our backlogs and this would really help.

Thanks,
Diane

[GitHub] geode pull request #404: Geode 2469

[hiteshk25]

Github user hiteshk25 commented on a diff in the pull request:

https://github.com/apache/geode/pull/404#discussion_r103499836
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -259,6 +307,16 @@ public void 
createRemoteRegionReferenceLocally(ByteArrayWrapper key, RedisDataTy
 
   private Region getOrCreateRegion0(ByteArrayWrapper key, 
RedisDataType type,
   ExecutionHandlerContext context, boolean addToMeta) {
+
+String regionName = key.toString();
+
+// check if type is hash TODO: remove
--- End diff --

do we need to look hash key here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57221: GEODE-2541: Fixed ClassCastException failure

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57221/#review167611
---


Ship it!




Ship It!

- Jared Stewart


On March 1, 2017, 10:25 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57221/
> ---
> 
> (Updated March 1, 2017, 10:25 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Kirk 
> Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Fixed in HeadlessGfsh, and added new test for handling a command response
> that's not a CommandResult object
> 
> Refactored HeadlessGfshIntegrationTest: removed wildcard imports and 
> extracted common test setup code
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java
>  72be0c7 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfshIntegrationTest.java
>  2ea8d99 
> 
> 
> Diff: https://reviews.apache.org/r/57221/diff/2/
> 
> 
> Testing
> ---
> 
> Ran spotlessApply
> Precheckin is in progress
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

[jira] [Commented] (GEODE-2562) Docs: simplify language in Main Features section

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891338#comment-15891338
 ] 

ASF subversion and git services commented on GEODE-2562:


Commit 812765920cd4ff5a7a950e00a1626e64e379b2e8 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8127659 ]

Revert "GEODE-2562 Revise Main Features paragraph per review"

This reverts commit c0d43b35ee78dfbfb2fee767bc552ed924da6eb7.


> Docs: simplify language in Main Features section
> 
>
> Key: GEODE-2562
> URL: https://issues.apache.org/jira/browse/GEODE-2562
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Simplify some language within the page that describes main features of Geode.
> Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57225: GEODE-2571 CacheClosedException during LuceneQueryFunction should be handled with a retry

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57225/#review167609
---


Ship it!




Ship It!

- Dan Smith


On March 1, 2017, 11:45 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57225/
> ---
> 
> (Updated March 1, 2017, 11:45 p.m.)
> 
> 
> Review request for geode, Lynn Hughes-Godfrey, nabarun nag, Dan Smith, and 
> xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added try catch around retrieving lucene index to handle cache clossed 
> exception
> Added catch during bucket querying to handle cache closed exception
> minor refactoring to break down the execute method
> Modified expected exception in tests to be more specific for certain tests
> Added tests
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java
>  dd70480 
>   
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java
>  6a9af9b 
> 
> 
> Diff: https://reviews.apache.org/r/57225/diff/1/
> 
> 
> Testing
> ---
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[jira] [Commented] (GEODE-2562) Docs: simplify language in Main Features section

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891319#comment-15891319
 ] 

ASF subversion and git services commented on GEODE-2562:


Commit c0d43b35ee78dfbfb2fee767bc552ed924da6eb7 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c0d43b3 ]

GEODE-2562 Revise Main Features paragraph per review


> Docs: simplify language in Main Features section
> 
>
> Key: GEODE-2562
> URL: https://issues.apache.org/jira/browse/GEODE-2562
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Simplify some language within the page that describes main features of Geode.
> Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2562) Docs: simplify language in Main Features section

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891320#comment-15891320
 ] 

ASF subversion and git services commented on GEODE-2562:


Commit 45c150d86c64e9c458881fc898c81629d97b268f in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=45c150d ]

Merge branch 'feature/GEODE-2562' into develop


> Docs: simplify language in Main Features section
> 
>
> Key: GEODE-2562
> URL: https://issues.apache.org/jira/browse/GEODE-2562
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Simplify some language within the page that describes main features of Geode.
> Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2562) Docs: simplify language in Main Features section

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891318#comment-15891318
 ] 

ASF subversion and git services commented on GEODE-2562:


Commit 83ff6e431884ab510d83ca3c8b0e17c68998 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=83ff677 ]

GEODE-2562 CTR  Revise docs Main Features section

- Remove instances of GemFire
- Simplify some language
- Add a paragraph about Geode Native (clients in other languages)


> Docs: simplify language in Main Features section
> 
>
> Key: GEODE-2562
> URL: https://issues.apache.org/jira/browse/GEODE-2562
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Simplify some language within the page that describes main features of Geode.
> Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891285#comment-15891285
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/36


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57221: GEODE-2541: Fixed ClassCastException failure

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57221/#review167606
---


Ship it!




Ship It!

- Kevin Duling


On March 1, 2017, 2:25 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57221/
> ---
> 
> (Updated March 1, 2017, 2:25 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Kirk 
> Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Fixed in HeadlessGfsh, and added new test for handling a command response
> that's not a CommandResult object
> 
> Refactored HeadlessGfshIntegrationTest: removed wildcard imports and 
> extracted common test setup code
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java
>  72be0c7 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfshIntegrationTest.java
>  2ea8d99 
> 
> 
> Diff: https://reviews.apache.org/r/57221/diff/2/
> 
> 
> Testing
> ---
> 
> Ran spotlessApply
> Precheckin is in progress
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

[jira] [Commented] (GEODE-2531) Replace HostAsm::atomic* and AtomicInc with std::atomic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891286#comment-15891286
 ] 

ASF GitHub Bot commented on GEODE-2531:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/37


> Replace HostAsm::atomic* and AtomicInc with std::atomic
> ---
>
> Key: GEODE-2531
> URL: https://issues.apache.org/jira/browse/GEODE-2531
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{HostAsm::atomic*}} and {{AtomicInc}} with 
> {{[std::atomic|http://en.cppreference.com/w/cpp/atomic/atomic]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891283#comment-15891283
 ] 

ASF subversion and git services commented on GEODE-2494:


Commit 2eb71eec6df5d7275be6cecb204e5594cd72c234 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=2eb71ee ]

GEODE-2494: Replace global statics with class scoped statics.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891282#comment-15891282
 ] 

ASF subversion and git services commented on GEODE-2494:


Commit c59fbe6bb99033be01c2b789a8f036c63e13e57e in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=c59fbe6 ]

GEODE-2494: Removed SpinLock.



> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891292#comment-15891292
 ] 

ASF subversion and git services commented on GEODE-2552:


Commit b48be223dede34f1c5d2cae18983b04bee3359d2 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=b48be22 ]

GEODE-2552: Replaced NanoTimer with std::chrono.


> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891287#comment-15891287
 ] 

ASF GitHub Bot commented on GEODE-2552:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/40


> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891284#comment-15891284
 ] 

ASF subversion and git services commented on GEODE-2494:


Commit b168e38990e11c9b7351bf389dac61663b3033fe in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=b168e38 ]

GEODE-2494: Reverts conversion to pointer from ref.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2531) Replace HostAsm::atomic* and AtomicInc with std::atomic

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891290#comment-15891290
 ] 

ASF subversion and git services commented on GEODE-2531:


Commit efced0d3d182113ebf5762b59fdb685524da8207 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=efced0d ]

GEODE-2531: Replace HostAsm::atomic with std::atomic.


> Replace HostAsm::atomic* and AtomicInc with std::atomic
> ---
>
> Key: GEODE-2531
> URL: https://issues.apache.org/jira/browse/GEODE-2531
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{HostAsm::atomic*}} and {{AtomicInc}} with 
> {{[std::atomic|http://en.cppreference.com/w/cpp/atomic/atomic]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891291#comment-15891291
 ] 

ASF subversion and git services commented on GEODE-2552:


Commit 01800657872ad53692abae90a9530a45f333e528 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=0180065 ]

GEODE-2552: Replace NanoSleep with std::this_thread::sleepFor.

- Replaced custom time/duration with std::crono.


> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891294#comment-15891294
 ] 

ASF subversion and git services commented on GEODE-2552:


Commit c3c42312f67f46b36a89458513133e112928e7f3 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=c3c4231 ]

GEODE-2552: Removed NanoTimer

- Replaced millisleep with std::this_thread::sleep_for.


> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891288#comment-15891288
 ] 

ASF subversion and git services commented on GEODE-2494:


Commit 4f00f1cd67c7881aa3704771b74028d7b4eb1387 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=4f00f1c ]

GEODE-2494: Remove dead code.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891289#comment-15891289
 ] 

ASF subversion and git services commented on GEODE-2494:


Commit 561f80a0e7202b077bf025e52e6f2a8af4fdf00b in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=561f80a ]

GEODE-2494: Fixes missing include for strlen.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891293#comment-15891293
 ] 

ASF subversion and git services commented on GEODE-2552:


Commit 6a9d755206c214cb5d125f4794158153fb7b6be1 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=6a9d755 ]

GEODE-2552: Replaced NanoTimer with std::chrono.


> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (GEODE-2571) CacheClosedException during LuceneQueryFunction should be handled with a retry

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-2571:
--

Assignee: Jason Huynh

> CacheClosedException during LuceneQueryFunction should be handled with a retry
> --
>
> Key: GEODE-2571
> URL: https://issues.apache.org/jira/browse/GEODE-2571
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There are multiple spots in LuceneQueryFunction that can throw a 
> CacheClosedException.  The query function should handle this and allow the 
> function service to retry instead of returning a CacheClosedException to the 
> user.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2562) Docs: simplify language in Main Features section

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller updated GEODE-2562:
---
Fix Version/s: 1.2.0

> Docs: simplify language in Main Features section
> 
>
> Key: GEODE-2562
> URL: https://issues.apache.org/jira/browse/GEODE-2562
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Simplify some language within the page that describes main features of Geode.
> Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2413) peer-to-peer authentication: Peer need to re-authenticate coordinator while accepting view message

[Bruce Schuchardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891261#comment-15891261
 ] 

Bruce Schuchardt commented on GEODE-2413:
-

thanks for the clarification [~hiteshkh25].  It looks like we are sending the 
credential but are not having it checked in GMSJoinLeave.processViewMessage().

> peer-to-peer authentication: Peer need to re-authenticate coordinator while 
> accepting view message
> --
>
> Key: GEODE-2413
> URL: https://issues.apache.org/jira/browse/GEODE-2413
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Hitesh Khamesra
>Assignee: Hitesh Khamesra
>
> In peer-to-peer authentication, coordinator authenticates the joining member. 
> Then coordinator includes that new member in the cluster and sends new view 
> message. This view message should include coordinator's credential so that 
> joining member can authenticate coordinator as well (i.e. mutual 
> authentication)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2562) Docs: simplify language in Main Features section

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller reassigned GEODE-2562:
--

Assignee: Karen Smoler Miller

> Docs: simplify language in Main Features section
> 
>
> Key: GEODE-2562
> URL: https://issues.apache.org/jira/browse/GEODE-2562
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Simplify some language within the page that describes main features of Geode.
> Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2562) Docs: simplify language in Main Features section

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-2562.

Resolution: Fixed

> Docs: simplify language in Main Features section
> 
>
> Key: GEODE-2562
> URL: https://issues.apache.org/jira/browse/GEODE-2562
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> Simplify some language within the page that describes main features of Geode.
> Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2413) peer-to-peer authentication: Peer need to re-authenticate coordinator while accepting view message

[Hitesh Khamesra (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891254#comment-15891254
 ] 

Hitesh Khamesra commented on GEODE-2413:


[~bschuchardt] It's not about encrypted UDP communication. In peer-to-peer 
authentication coordinator first, authenticates the new member when it joins 
the cluster. Then coordinator sends the new view with(new-member), and then 
new-member authenticates coordinator. This way it makes sure It joined the 
right cluster. I don't see the later code in geode as we have re-implemented 
this layer. 



> peer-to-peer authentication: Peer need to re-authenticate coordinator while 
> accepting view message
> --
>
> Key: GEODE-2413
> URL: https://issues.apache.org/jira/browse/GEODE-2413
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Hitesh Khamesra
>Assignee: Hitesh Khamesra
>
> In peer-to-peer authentication, coordinator authenticates the joining member. 
> Then coordinator includes that new member in the cluster and sends new view 
> message. This view message should include coordinator's credential so that 
> joining member can authenticate coordinator as well (i.e. mutual 
> authentication)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2413) peer-to-peer authentication: Peer need to re-authenticate coordinator while accepting view message

[Bruce Schuchardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891223#comment-15891223
 ] 

Bruce Schuchardt commented on GEODE-2413:
-

Hitesh, I think you need to clarify whether this is the new encrypted UDP 
communications or the Geode security authentication service.  I think you're 
talking about the new encrypted UDP communications.  This is causing confusion.

> peer-to-peer authentication: Peer need to re-authenticate coordinator while 
> accepting view message
> --
>
> Key: GEODE-2413
> URL: https://issues.apache.org/jira/browse/GEODE-2413
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Hitesh Khamesra
>Assignee: Hitesh Khamesra
>
> In peer-to-peer authentication, coordinator authenticates the joining member. 
> Then coordinator includes that new member in the cluster and sends new view 
> message. This view message should include coordinator's credential so that 
> joining member can authenticate coordinator as well (i.e. mutual 
> authentication)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #:

[joeymcallister]

Github user joeymcallister commented on the pull request:


https://github.com/apache/geode/commit/319304e28fa33f685ccab51d7574fc8696cee50b#commitcomment-21113152
  
In geode-docs/getting_started/product_intro.html.md.erb:
In geode-docs/getting_started/product_intro.html.md.erb on line 40:
Concurrent main-memory data structures and a highly optimized distribution 
infrastructure provide read-and-write throughput.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57221: GEODE-2541: Fixed ClassCastException failure

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57221/#review167593
---


Ship it!




Ship It!

- Jinmei Liao


On March 1, 2017, 10:25 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57221/
> ---
> 
> (Updated March 1, 2017, 10:25 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Kirk 
> Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Fixed in HeadlessGfsh, and added new test for handling a command response
> that's not a CommandResult object
> 
> Refactored HeadlessGfshIntegrationTest: removed wildcard imports and 
> extracted common test setup code
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java
>  72be0c7 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfshIntegrationTest.java
>  2ea8d99 
> 
> 
> Diff: https://reviews.apache.org/r/57221/diff/2/
> 
> 
> Testing
> ---
> 
> Ran spotlessApply
> Precheckin is in progress
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

[jira] [Commented] (GEODE-2562) Docs: simplify language in Main Features section

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891199#comment-15891199
 ] 

ASF subversion and git services commented on GEODE-2562:


Commit 319304e28fa33f685ccab51d7574fc8696cee50b in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=319304e ]

GEODE-2562 CTR  Revise docs Main Features section

- Remove instances of GemFire
- Simplify some language
- Add a paragraph about Geode Native (clients in other languages)


> Docs: simplify language in Main Features section
> 
>
> Key: GEODE-2562
> URL: https://issues.apache.org/jira/browse/GEODE-2562
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>
> Simplify some language within the page that describes main features of Geode.
> Will do this task as commit-then-review.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57221: GEODE-2541: Fixed ClassCastException failure

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57221/
---

(Updated March 1, 2017, 10:25 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Kirk 
Lund.


Repository: geode


Description
---

Fixed in HeadlessGfsh, and added new test for handling a command response
that's not a CommandResult object

Refactored HeadlessGfshIntegrationTest: removed wildcard imports and extracted 
common test setup code


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java
 72be0c7 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfshIntegrationTest.java
 2ea8d99 


Diff: https://reviews.apache.org/r/57221/diff/2/

Changes: https://reviews.apache.org/r/57221/diff/1-2/


Testing
---

Ran spotlessApply
Precheckin is in progress


Thanks,

Ken Howe

Re: export logs and stats

[Darrel Schneider]

The code that gets the list of old logs/stats to remove
is: 
org.apache.geode.internal.io.MainWithChildrenRollingFileHandler.checkDiskSpace(String,
File, long, File, LogWriterI18n)
You will see that it calls findChildrenExcept with a pattern.
You probably want to instead call findChildren and you will see it has a
couple of callers that pass it a pattern.

On Tue, Feb 28, 2017 at 3:25 PM, Jinmei Liao  wrote:

> Darrel, great, can you point me to the code to get a list of the files to
> copy?
>
> On Tue, Feb 28, 2017 at 3:16 PM, Darrel Schneider 
> wrote:
>
> > It sounds like you will pick up any file in the working directory that
> ends
> > with ".log" or ".log.gz".
> > But what if the geode server is sharing a directory with something else
> > that is also writing files with these extensions?
> > Or if multiple geode servers are running in the same directory?
> > I think it would be better to use the configured log file name and stat
> > archive name and use that to find the logs and stats to gather. The
> rolling
> > code has already been written that will find all the existing logs and
> > stats. In any bugs in that code need to be fixed since it would break the
> > code that removes old files based on disk space. So it seems like you
> > should be able to use this same code to get a list of the files to copy.
> >
> >
> > On Tue, Feb 28, 2017 at 2:57 PM, Dan Smith  wrote:
> >
> > > I'm a bit confused by (1). Isn't it actually more complicated for you
> to
> > > restrict log collection to a relative path? Why not just look for log
> > files
> > > no matter where they are written to? I also don't really follow the
> > > argument about why a user that writes to /var/logs is not going to want
> > to
> > > use this command. Won't all users want to be able to gather their logs
> > > using this command?
> > >
> > > 2 seems reasonable. It seems like we should restrict the file names if
> we
> > > are going to have this limitation.
> > >
> > > -Dan
> > >
> > > On Tue, Feb 28, 2017 at 2:43 PM, Jinmei Liao 
> wrote:
> > >
> > > > Hello community,
> > > >
> > > > We are currently trying to improve what "export logs" should do.
> > > Currently
> > > > export logs only export the logs(filtered by logLevel and start and
> end
> > > > date) to each individual member's file system. We want to make all
> the
> > > > member's logs exported to a central location  and if you are
> connecting
> > > > using http, it will be exported to your local file system. This is to
> > > > facilitate gathering logs in the cloud environment.
> > > >
> > > > That said, for the first round of implementation, we would like to
> > impose
> > > > these restrictions to this command:
> > > > 1) it will only look for the logs/stats in each members working
> > directory
> > > > only.
> > > > 2) it will only look for files that ends with .log, .log.gz, .gfs or
> > > > .gfs.gz.
> > > >
> > > > Background for 1): if you started your locator/server with "log-file"
> > or
> > > > "statistics-archive-file" with an absolute path, it will write these
> > > files
> > > > to that location, but if you simply give it a relative path, the
> files
> > > will
> > > > be written to the member's working directory. The reasoning behind 1)
> > is
> > > > that this command is mostly for those environment that you can't
> easily
> > > go
> > > > to the member's filesystem to get logs, but if you have started your
> > > > server/locator with an absolute path like "/var/logs", we are
> assuming
> > > you
> > > > already know how to get the logs, thus this command to not mean much
> to
> > > > you.
> > > >
> > > > For restriction 2), since logs and stats files roll over, it is much
> > > easier
> > > > to find the target files with extensions rather than file name
> > patterns.
> > > We
> > > > could either do not allow you to start server/locator with other file
> > > name
> > > > suffix or post a warning. We would need the community's input on
> this.
> > > >
> > > > Any feedback is appreciated.
> > > >
> > > > --
> > > > Cheers
> > > >
> > > > Jinmei
> > > >
> > >
> >
>
>
>
> --
> Cheers
>
> Jinmei
>

Re: Review Request 57221: GEODE-2541: Fixed ClassCastException failure

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57221/#review167585
---




geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfshIntegrationTest.java
Lines 121 (patched)


I think this cleanup can be moved to an @After method as it happens at the 
end of each test:
 ```
  gfsh.terminate();
cache.close();
ds.disconnect();
```


- Jared Stewart


On March 1, 2017, 9:59 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57221/
> ---
> 
> (Updated March 1, 2017, 9:59 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Kirk 
> Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Fixed in HeadlessGfsh, and added new test for handling a command response
> that's not a CommandResult object
> 
> Refactored HeadlessGfshIntegrationTest: removed wildcard imports and 
> extracted common test setup code
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java
>  72be0c7fa6839ff7f818cffa4ee5b436bebd2ce8 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfshIntegrationTest.java
>  2ea8d9947948810b8e69df83d3a6cf59038d901d 
> 
> 
> Diff: https://reviews.apache.org/r/57221/diff/1/
> 
> 
> Testing
> ---
> 
> Ran spotlessApply
> Precheckin is in progress
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

Re: export logs and stats

[Darrel Schneider]

IndexOutOfBoundError if you don't specify an extension is a bug that should
be fixed. It could be fixed by tacking on a default extension if one does
not exist.

I'm not sure what should be done about filenames with multiple "." in them
(like "foo.log.gz"). Currently I think the code says what comes after the
last "." is the extension and everything before that is the base name. It
could instead say everything after the first "." is the extension. Since
you give special meaning to it ending with ".gz" you could strip it off and
then see if you have an extension on what remains and if you don't add a
default (i.e. ".log") extension. It would be nice if when you gunzip a log
file if it would now end with ".log" and when you gunzip a stat archive it
would then end with ".gfs".

If the user explicitly configured a log file or stat archive with a
different extension I think that should continue to work. For example if
they configured their log to be "foo.txt" I don't think we should start
turning this into "foo.txt.log" or start giving them an error.

On Tue, Feb 28, 2017 at 4:20 PM, Jinmei Liao  wrote:

> Darrel, it seems if user defines a log file to be simply "serverLog" (a
> filename with no "."), when rolling over the log file once file size is
> reached, we get a IndexOutOfBoundError when it's trying to figure out
> what's the rolled-over filename should be.
>
> And if user defines a log file name to be "server.log.gz", when rolling
> over, the new filename seems to be "server.log_01_01.gz". Does not look
> like we handle the ".gz' suffix correctly. For now, we do want to enforce
> the log/stats filename ends with appropriate suffix.
>
> On Tue, Feb 28, 2017 at 3:16 PM, Darrel Schneider 
> wrote:
>
> > It sounds like you will pick up any file in the working directory that
> ends
> > with ".log" or ".log.gz".
> > But what if the geode server is sharing a directory with something else
> > that is also writing files with these extensions?
> > Or if multiple geode servers are running in the same directory?
> > I think it would be better to use the configured log file name and stat
> > archive name and use that to find the logs and stats to gather. The
> rolling
> > code has already been written that will find all the existing logs and
> > stats. In any bugs in that code need to be fixed since it would break the
> > code that removes old files based on disk space. So it seems like you
> > should be able to use this same code to get a list of the files to copy.
> >
> >
> > On Tue, Feb 28, 2017 at 2:57 PM, Dan Smith  wrote:
> >
> > > I'm a bit confused by (1). Isn't it actually more complicated for you
> to
> > > restrict log collection to a relative path? Why not just look for log
> > files
> > > no matter where they are written to? I also don't really follow the
> > > argument about why a user that writes to /var/logs is not going to want
> > to
> > > use this command. Won't all users want to be able to gather their logs
> > > using this command?
> > >
> > > 2 seems reasonable. It seems like we should restrict the file names if
> we
> > > are going to have this limitation.
> > >
> > > -Dan
> > >
> > > On Tue, Feb 28, 2017 at 2:43 PM, Jinmei Liao 
> wrote:
> > >
> > > > Hello community,
> > > >
> > > > We are currently trying to improve what "export logs" should do.
> > > Currently
> > > > export logs only export the logs(filtered by logLevel and start and
> end
> > > > date) to each individual member's file system. We want to make all
> the
> > > > member's logs exported to a central location  and if you are
> connecting
> > > > using http, it will be exported to your local file system. This is to
> > > > facilitate gathering logs in the cloud environment.
> > > >
> > > > That said, for the first round of implementation, we would like to
> > impose
> > > > these restrictions to this command:
> > > > 1) it will only look for the logs/stats in each members working
> > directory
> > > > only.
> > > > 2) it will only look for files that ends with .log, .log.gz, .gfs or
> > > > .gfs.gz.
> > > >
> > > > Background for 1): if you started your locator/server with "log-file"
> > or
> > > > "statistics-archive-file" with an absolute path, it will write these
> > > files
> > > > to that location, but if you simply give it a relative path, the
> files
> > > will
> > > > be written to the member's working directory. The reasoning behind 1)
> > is
> > > > that this command is mostly for those environment that you can't
> easily
> > > go
> > > > to the member's filesystem to get logs, but if you have started your
> > > > server/locator with an absolute path like "/var/logs", we are
> assuming
> > > you
> > > > already know how to get the logs, thus this command to not mean much
> to
> > > > you.
> > > >
> > > > For restriction 2), since logs and stats files roll over, it is much
> > > easier
> > > > to find the target files with extensions 

Review Request 57221: GEODE-2541: Fixed ClassCastException failure

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57221/
---

Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Kirk 
Lund.


Repository: geode


Description
---

Fixed in HeadlessGfsh, and added new test for handling a command response
that's not a CommandResult object

Refactored HeadlessGfshIntegrationTest: removed wildcard imports and extracted 
common test setup code


Diffs
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java
 72be0c7fa6839ff7f818cffa4ee5b436bebd2ce8 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfshIntegrationTest.java
 2ea8d9947948810b8e69df83d3a6cf59038d901d 


Diff: https://reviews.apache.org/r/57221/diff/1/


Testing
---

Ran spotlessApply
Precheckin is in progress


Thanks,

Ken Howe

Re: Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57208/#review167582
---


Ship it!




Ship It!

- Darrel Schneider


On March 1, 2017, 12:56 p.m., Kevin Duling wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57208/
> ---
> 
> (Updated March 1, 2017, 12:56 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jared Stewart, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2560: Missing disk files (.crf) during backup/restore throws exception
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> f5aec51a09e671bc7d4ca33d4de8f0f683ef4d73 
> 
> 
> Diff: https://reviews.apache.org/r/57208/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Kevin Duling
> 
>

[jira] [Commented] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891118#comment-15891118
 ] 

ASF subversion and git services commented on GEODE-2541:


Commit b8953046cb0b32155ff8bce09890161a77bea473 in geode's branch 
refs/heads/feature/GEODE-2541 from [~khowe]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b895304 ]

GEODE-2541: Fixed ClassCastException failure

Fixed in HeadlessGfsh, and added new test for handling a command response
that's not a CommandResult object


> NetstatDUnitTest fails with ClassCastException
> --
>
> Key: GEODE-2541
> URL: https://issues.apache.org/jira/browse/GEODE-2541
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> This might be a bug in the error handling code for gfsh or the functions used 
> by MiscellaneousCommands.
> {noformat}
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerOne FAILED
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not 
> process command due to GemFire error. Error occurred while executing netstat 
> on [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:82)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerTwo FAILED
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.geode.management.internal.cli.result.CommandResult
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeCommand(GfshShellConnectionRule.java:159)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:166)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerTwo(NetstatDUnitTest.java:88)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToLocator FAILED
> org.junit.ComparisonFailure: [{"errorCode":520,"message":["Could not find 
> member(s) with Id(s) or name(s): server-1."]}] expected:<[OK]> but 
> was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToLocator(NetstatDUnitTest.java:76)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2570) Export cluster-configuration returns "GemFire error" message

[Wes Williams (JIRA)]

Wes Williams created GEODE-2570:
---

 Summary: Export cluster-configuration returns "GemFire error" 
message
 Key: GEODE-2570
 URL: https://issues.apache.org/jira/browse/GEODE-2570
 Project: Geode
  Issue Type: Bug
  Components: configuration, gfsh
Reporter: Wes Williams
 Fix For: 1.2.0, 1.1.0


gfsh>version
1.1.0

gfsh>start locator --name=locator1 --port=10334 
--properties-file=config/locator.properties 
--load-cluster-configuration-from-dir=true --initial-heap=256m --max-heap=256m

gfsh>start server --name=server1 --server-port=0 
--properties-file=config/gemfire.properties --initial-heap=1g --max-heap=1g

gfsh>list regions
No Regions Found

gfsh>list members
  Name   | Id
 | 
locator1 | 192.168.0.5(locator1:43398:locator):1024
server1  | 192.168.0.5(server1:43404):1025

gfsh>create region --name=Test --type=PARTITION
Member  | Status
--- | ---
server1 | Region "/Test" created on "server1"

gfsh>export cluster-configuration --zip-file-name=test.zip
Could not process command due to GemFire error. Error while processing command 
 Reason : null

[info 2017/03/01 16:27:55.414 EST locator1  
tid=0x6c] (tid=108 msgId=72) Could not execute "export cluster-configuration 
--zip-file-name=test.zip".
java.lang.NullPointerException
at 
org.apache.geode.management.internal.cli.commands.ExportImportClusterConfigurationCommands.exportSharedConfig(ExportImportClusterConfigurationCommands.java:85)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:216)
at 
org.apache.geode.management.internal.cli.remote.RemoteExecutionStrategy.execute(RemoteExecutionStrategy.java:91)
at 
org.apache.geode.management.internal.cli.remote.CommandProcessor.executeCommand(CommandProcessor.java:117)
at 
org.apache.geode.management.internal.cli.remote.CommandStatementImpl.process(CommandStatementImpl.java:71)
at 
org.apache.geode.management.internal.cli.remote.MemberCommandService.processCommand(MemberCommandService.java:52)
at 
org.apache.geode.management.internal.beans.MemberMBeanBridge.processCommand(MemberMBeanBridge.java:1639)
at 
org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:404)
at 
org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:397)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275)
at 
com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
at 
com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
at 
com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:117)
at 
com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:54)
at 
com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
at 
com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
at 
javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1466)
at 
javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76)
at 
javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1307)
at 
javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1399)
at 
javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:828)
at sun.reflect.GeneratedMethodAccessor197.invoke(Unknown Source)
at 

[jira] [Updated] (GEODE-2569) Unhelpful log message

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-2569:

Priority: Trivial  (was: Major)

> Unhelpful log message
> -
>
> Key: GEODE-2569
> URL: https://issues.apache.org/jira/browse/GEODE-2569
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Reporter: Bruce Schuchardt
>Priority: Trivial
>
> I found this in a log file:
> Unable to form a TCP/IP connection to null in over 31 seconds
> Just prior to this the same thread logged this:
> Unable to form a TCP/IP connection to 10.32.109.100(15954):48987 in over 
> 31 seconds
> The member mentioned was being removed from the membership view in another 
> thread during this time and nothing malfunctioned, but it isn't useful to 
> print the message with "null" in it.  We should supress that message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2569) Unhelpful log message

[Bruce Schuchardt (JIRA)]

Bruce Schuchardt created GEODE-2569:
---

 Summary: Unhelpful log message
 Key: GEODE-2569
 URL: https://issues.apache.org/jira/browse/GEODE-2569
 Project: Geode
  Issue Type: Bug
  Components: membership, messaging
Reporter: Bruce Schuchardt


I found this in a log file:

Unable to form a TCP/IP connection to null in over 31 seconds

Just prior to this the same thread logged this:

Unable to form a TCP/IP connection to 10.32.109.100(15954):48987 in over 31 
seconds

The member mentioned was being removed from the membership view in another 
thread during this time and nothing malfunctioned, but it isn't useful to print 
the message with "null" in it.  We should supress that message.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

[Kenneth Howe (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891093#comment-15891093
 ] 

Kenneth Howe commented on GEODE-2541:
-

The issue with gfsh netstat command causing a Java heap OutOfMemoryError has 
been reported as GEODE-2488.


> NetstatDUnitTest fails with ClassCastException
> --
>
> Key: GEODE-2541
> URL: https://issues.apache.org/jira/browse/GEODE-2541
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> This might be a bug in the error handling code for gfsh or the functions used 
> by MiscellaneousCommands.
> {noformat}
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerOne FAILED
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not 
> process command due to GemFire error. Error occurred while executing netstat 
> on [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:82)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerTwo FAILED
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.geode.management.internal.cli.result.CommandResult
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeCommand(GfshShellConnectionRule.java:159)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:166)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerTwo(NetstatDUnitTest.java:88)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToLocator FAILED
> org.junit.ComparisonFailure: [{"errorCode":520,"message":["Could not find 
> member(s) with Id(s) or name(s): server-1."]}] expected:<[OK]> but 
> was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToLocator(NetstatDUnitTest.java:76)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2488) Netstat command fails with OutOfMemoryError

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe reassigned GEODE-2488:
---

Assignee: Kenneth Howe

> Netstat command fails with OutOfMemoryError
> ---
>
> Key: GEODE-2488
> URL: https://issues.apache.org/jira/browse/GEODE-2488
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, netstat
>
> Note: this can occur outside of dunit tests as well. Just using the gfsh 
> netstat command on locator or server with too little heap space will hit 
> this. See the 1st comment about not streaming the netstat output -- the 
> entire output is held in memory in a string and two byte arrays before 
> sending the result back from NetstatFunction.
> The JUnit controller JVM for NetstatDUnitTest fails with something like the 
> follow stack. The cause appears to be one of the DUnit VMs running out of 
> memory (see the OOME stack down further in this description.
> {noformat}
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not process 
> command due to GemFire error. Error occurred while executing netstat on 
> [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
>   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>   at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:163)
>   at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:81)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.apache.geode.test.junit.rules.DescribedExternalResource$1.evaluate(DescribedExternalResource.java:37)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> 

[jira] [Commented] (GEODE-1995) remove ReliableMessageQueueFactory, ReliableMessageQueue, and getReliableMessageQueueFactory

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891080#comment-15891080
 ] 

ASF subversion and git services commented on GEODE-1995:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> remove ReliableMessageQueueFactory, ReliableMessageQueue, and 
> getReliableMessageQueueFactory
> 
>
> Key: GEODE-1995
> URL: https://issues.apache.org/jira/browse/GEODE-1995
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>
> ReliableMessageQueueFactory, ReliableMessageQueue, and 
> GemFireCacheImpl.getReliableMessageQueueFactory should all be removed. They 
> are internal and were never used. No tests exist for them.
> They are part of required Roles which is a deprecated feature.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2460) Update dependency versions

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891079#comment-15891079
 ] 

ASF subversion and git services commented on GEODE-2460:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Update dependency versions
> --
>
> Key: GEODE-2460
> URL: https://issues.apache.org/jira/browse/GEODE-2460
> Project: Geode
>  Issue Type: Wish
>  Components: build, docs
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Here's the first bunch of dependency version updates that passes precheckin 
> without modifying source code:
> Update the following dependency versions defined in
> gradle/dependency-versions.properties.
> Update major versions (test-only):
> * org.apache.bcel:bcel:6.0
> Update minor versions (test and main):
> * commons-beanutils:1.9.3 
> * commons-fileupload:1.3.2 
> * commons-io:2.5 
> * commons-lang:2.6
> * commons-logging:1.2
> * commons-modeler:2.0.1
> * fastutil:7.0.13
> * guava:21.0
> * jansi:1.14
> * javax.mail-api:1.4.7
> * jline:2.14.3
> * jopt-simple:5.0.3
> * log4j-api:2.7
> * log4j-core:2.7
> * log4j-jcl:2.7
> * log4j-jul:2.7
> * log4j-slf4j-impl:2.7
> * netty-all:4.1.7.Final
> * shiro-core:1.3.2
> * slf4j-api:1.7.22
> Update minor versions (test-only):
> * assertj-core:3.6.2
> * cglib:cglib:3.2.4
> * commons-configuration:1.10
> * derby:10.13.1.1
> * google-gson:2.8.0
> * httpclient:4.5.2
> * httpcore:4.4.6
> * hsqldb:2.3.4
> * javassist:3.21.0-GA
> * jedis:2.9.0
> * JUnitParams:1.0.6
> * mockrunner:1.1.2
> * mortbay-jetty-servlet-api:2.5.20110712
> * phantomjsdriver:1.3.0
> * powermock-core:1.6.6
> * powermock-module-junit4:1.6.6
> * powermock-api-mockito:1.6.6
> * selenium-api:3.0.1
> * selenium-remote-driver:3.0.1
> * selenium-support:3.0.1
> * spymemcached:2.12.2
> * system-rules:1.16.1
> * tomcat-catalina:7.0.73 (tomcat7)
> * tomcat-coyote:7.0.73 (tomcat7)
> * tomcat-juli:7.0.73 (tomcat7)
> * tomcat-catalina:8.5.9 (tomcat8)
> * tomcat-coyote:8.5.9 (tomcat8)
> * tomcat-juli:8.5.9 (tomcat8)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2515) CI Failure: BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries FAILED failed with AssertionFailedError

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891085#comment-15891085
 ] 

ASF subversion and git services commented on GEODE-2515:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> CI Failure: 
> BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries FAILED 
> failed with AssertionFailedError
> ---
>
> Key: GEODE-2515
> URL: https://issues.apache.org/jira/browse/GEODE-2515
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
>   java.lang.AssertionError: Avg. Time taken to query with index should be 
> less than time taken without index
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.geode.cache.query.BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries(BaseLineAndCompareQueryPerfJUnitTest.java:299)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-880) Remove unused classes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891078#comment-15891078
 ] 

ASF subversion and git services commented on GEODE-880:
---

Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove unused classes
> -
>
> Key: GEODE-880
> URL: https://issues.apache.org/jira/browse/GEODE-880
> Project: Geode
>  Issue Type: Wish
>  Components: general
>Reporter: Kirk Lund
> Fix For: 1.2.0
>
>
> We would typically only keep unused classes if they were part of the user API 
> in a previous release.
> If an unused class is not required for backwards compatibility then it should 
> be deleted. This jira ticket lists unused classes that should be removed. If 
> you delete any of these classes, please add an appropriate comment and then 
> remove the class name from the ticket description.
> * geode-core/src/test/java/com/gemstone/gemfire/internal/JavaExec.java
> * geode-core/src/test/java/com/gemstone/gemfire/internal/LongBuffer.java



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2538) Lucene query with values should not invoke cache loader

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891082#comment-15891082
 ] 

ASF subversion and git services commented on GEODE-2538:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Lucene query with values should not invoke cache loader
> ---
>
> Key: GEODE-2538
> URL: https://issues.apache.org/jira/browse/GEODE-2538
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> Lucene queries use getAll to fetch pages when returning values.
> If an entry is destroyed after the query has found the list of keys, but 
> before the query finds the values, the getAll with trigger a cache loader and 
> reload the value. This may be unexpected behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891087#comment-15891087
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2545) NPE during lucene query execution when cache is closing or region is destroyed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891084#comment-15891084
 ] 

ASF subversion and git services commented on GEODE-2545:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> NPE during lucene query execution when cache is closing or region is destroyed
> --
>
> Key: GEODE-2545
> URL: https://issues.apache.org/jira/browse/GEODE-2545
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> If the LuceneQueryFunction executes while a cache is closing, it is possible 
> that the function receives a null region/index.  In this case the NPE is 
> thrown.  Instead we should detect this and fail the function.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891088#comment-15891088
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2550) Improve README

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891081#comment-15891081
 ] 

ASF subversion and git services commented on GEODE-2550:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Improve README
> --
>
> Key: GEODE-2550
> URL: https://issues.apache.org/jira/browse/GEODE-2550
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Anthony Baker
>Assignee: Anthony Baker
> Fix For: 1.2.0
>
>
> The project README and BUILDING could use some updates, particularly the 
> 'Geode in 5 minutes' example.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2526) Enhance log statement in StatsArchiveReader

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891077#comment-15891077
 ] 

ASF subversion and git services commented on GEODE-2526:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Enhance log statement in StatsArchiveReader
> ---
>
> Key: GEODE-2526
> URL: https://issues.apache.org/jira/browse/GEODE-2526
> Project: Geode
>  Issue Type: New Feature
>  Components: statistics
>Reporter: Srikanth Manvi
>Assignee: Srikanth Manvi
>Priority: Trivial
> Fix For: 1.2.0
>
>
> Rarely stats files are corrupted due to missing ResourceType info in the gfs 
> file. In those cases the gfs files cannot be opened in VSD tool as the tool 
> throws an error while loading.
> The log statement in the method 
> StatsArchiveReader.java(readResourceInstanceCreateToken())  prints out only 
> the missing ResourceTypeId which appears to be dynamically created. 
> If the log message can be enhanced to include the resourceName as well, it 
> will be valuable to know the name of ResourceType that is actually missing in 
> the stats file. 
> There is a [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility which takes in a corrupted stats files, name and id of the missing 
> ResourceType in the corrupted file and outputs a new .gfs file by filling in 
> the missing resource info. The new file can then be loaded and analyzed in 
> VSD.
>  
> For the [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility to be usable one needs to know the actual name of missing 
> resourceType, hence this New feature request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891091#comment-15891091
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891089#comment-15891089
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891086#comment-15891086
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891090#comment-15891090
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: 1.1.0 is done so let's start work on 1.2.0

[Hitesh Khamesra]

I would prefer to consider GEODE-2413 as well.
-Hitesh
  From: Anthony Baker 
 To: dev@geode.apache.org 
 Sent: Wednesday, March 1, 2017 1:21 PM
 Subject: Re: 1.1.0 is done so let's start work on 1.2.0
   
bump

The json.org removal is complete.  Any thoughts on additional scope / timing / 
release manager?

Anthony

> On Feb 16, 2017, at 8:20 AM, Anthony Baker  wrote:
> 
> Great job everyone on releasing 1.1.0!  Let’s get organized for the next 
> release :-)
> 
> Scope:
>     We definitely need to focus on eliminating JSON.org prior to 4/31.  See 
> GEODE-629, GEODE-2142, GEODE-2331, GEODE-2380.
>     Anything else?
> 
> Timing:
>     I suggest shooting for a release candidate around mid-March if possible 
> (release often!)
> 
> Release Manager:
>     Any volunteers?
> 
> Note:  as a process reminder please don’t set Fix Version in JIRA unless you 
> fix a bug that has been merged to develop or the issue has been prioritized 
> by the community for inclusion in a release.
> 
> Thanks,
> Anthony
> 


   

[jira] [Commented] (GEODE-2538) Lucene query with values should not invoke cache loader

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891074#comment-15891074
 ] 

ASF subversion and git services commented on GEODE-2538:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Lucene query with values should not invoke cache loader
> ---
>
> Key: GEODE-2538
> URL: https://issues.apache.org/jira/browse/GEODE-2538
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> Lucene queries use getAll to fetch pages when returning values.
> If an entry is destroyed after the query has found the list of keys, but 
> before the query finds the values, the getAll with trigger a cache loader and 
> reload the value. This may be unexpected behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891073#comment-15891073
 ] 

ASF subversion and git services commented on GEODE-1887:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2561) Docs: error in gfsecurity.properties example (Geode User Guide)

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891071#comment-15891071
 ] 

ASF subversion and git services commented on GEODE-2561:


Commit c3dbd742cde95a2aa9266990d6c42f4ce359cea2 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c3dbd74 ]

GEODE-2561 Docs: error in gfsecurity.properties example (Geode User Guide)


> Docs: error in gfsecurity.properties example (Geode User Guide)
> ---
>
> Key: GEODE-2561
> URL: https://issues.apache.org/jira/browse/GEODE-2561
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> Reported by Mike Martell:
> Looks like an error on this SSL Sample Impl page: 
> .../managing/security/ssl_example.html
> Seems like they're using a path for a password:
> ssl-truststore-password=/path/to/trusted.truststore
> [db note] 
> Check entire page to make sure properties shown are consistent with the 
> current implementation, as security properties (in particular) were recently 
> revised.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2461) Remove unnecessary explicit dependencies

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891075#comment-15891075
 ] 

ASF subversion and git services commented on GEODE-2461:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Remove unnecessary explicit dependencies
> 
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
>  Issue Type: Wish
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> These unused entries are potential candidates for removal from 
> gradle/dependency-versions.properties:
> * cdi-api.version
> * hadoop.version*
> * hbase.version (remove contains check from geode-assembly)
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version
> * spymemcached.version? (remove testCompile from geode-core)
> These entries are actually for transitive dependencies and should have the 
> explicit dependency removed:
> * activation.version
> * asm.version (done)
> * cglib.version (remove testRuntime from test.gradle)
> * classmate (remove compile from geode-web-api)
> * mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
> * scala.version (remove compile from geode-web-api)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2547) Interest registration can cause a CacheLoader to be invoked

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891076#comment-15891076
 ] 

ASF subversion and git services commented on GEODE-2547:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Interest registration can cause a CacheLoader to be invoked
> ---
>
> Key: GEODE-2547
> URL: https://issues.apache.org/jira/browse/GEODE-2547
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Barry Oglesby
>Assignee: Barry Oglesby
> Fix For: 1.2.0
>
>
> A simple scenario to reproduce this issue is:
> - configure a Region with a CacheLoader
> - destroy a key (it doesn't matter if the entry exists)
> - register interest in that key
> The CacheLoader will be invoked



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2551) Possible bugs in the source code

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891072#comment-15891072
 ] 

ASF subversion and git services commented on GEODE-2551:


Commit 635d3118177f6cae6b0497097e64bdb7a9aee800 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=635d311 ]

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode into 
develop

* 'develop' of https://git-wip-us.apache.org/repos/asf/geode: (57 commits)
  GEODE-2551 Fix code issues found by AppChecker
  Revert "GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type client and DataPolicy is Empty."
  GEODE-2538: Don't deserialize values on the server when getting results
  GEODE-2461: remove json4s-ast_2.10 as explicit dependency
  GEODE-2547: Interest registration no longer causes a CacheLoader to be invoked
  GEODE-2526: Enhance log statement to include ResourceTypeName
  GEODE-880 Remove unused classes
  GEODE-2460: update dependency versions
  GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, 
ReliableMessageQueueFactoryImpl and it's usage in the code from 
GemfireCacheImpl and DistributedRegion.
  GEODE-2550 Improve README and BUILDING
  GEODE-2538: Don't invoke a cache loader when fetching values for a lucene 
query
  GEODE-2404: Added support for destroying lucene indexes
  GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed
  GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest
  GEODE-2142: Removing JSON licence stuff from NOTICE files
  GEODE-2142: removing tests so run precheckin
  GEODE-2142: final compiling build
  GEODE-2142: cyclical dependency in gradle build
  GEODE-2142: spotless
  GEODE-2142: Refactoring of tests to work with new JSONObject class. Changing 
file export to use Base64 encoding.
  ...


> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, serialization
>Reporter: AppChecker
>Assignee: Anthony Baker
> Fix For: 1.2.0
>
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

[Kenneth Howe (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891065#comment-15891065
 ] 

Kenneth Howe commented on GEODE-2541:
-

The failure from ClassCastException results from 
org.apache.geode.management.internal.cli.HeadlessGfsh not handling a command 
results that's not a Result object as expected by the test rule.

The underlying cause of the test failure was a remote VM ran out of heap 
memory. The netstat command that gfsh was executing returned an error string 
instead of a CommandResult object, so the explicit cast in 
GfshShellConnectionRule threw the exception.

> NetstatDUnitTest fails with ClassCastException
> --
>
> Key: GEODE-2541
> URL: https://issues.apache.org/jira/browse/GEODE-2541
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> This might be a bug in the error handling code for gfsh or the functions used 
> by MiscellaneousCommands.
> {noformat}
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerOne FAILED
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not 
> process command due to GemFire error. Error occurred while executing netstat 
> on [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:82)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerTwo FAILED
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.geode.management.internal.cli.result.CommandResult
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeCommand(GfshShellConnectionRule.java:159)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:166)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerTwo(NetstatDUnitTest.java:88)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToLocator FAILED
> org.junit.ComparisonFailure: [{"errorCode":520,"message":["Could not find 
> member(s) with Id(s) or name(s): server-1."]}] expected:<[OK]> but 
> was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToLocator(NetstatDUnitTest.java:76)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2561) Docs: error in gfsecurity.properties example (Geode User Guide)

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-2561.

   Resolution: Fixed
Fix Version/s: 1.2.0

Example corrected. Properties check out with current list.

> Docs: error in gfsecurity.properties example (Geode User Guide)
> ---
>
> Key: GEODE-2561
> URL: https://issues.apache.org/jira/browse/GEODE-2561
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> Reported by Mike Martell:
> Looks like an error on this SSL Sample Impl page: 
> .../managing/security/ssl_example.html
> Seems like they're using a path for a password:
> ssl-truststore-password=/path/to/trusted.truststore
> [db note] 
> Check entire page to make sure properties shown are consistent with the 
> current implementation, as security properties (in particular) were recently 
> revised.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: 1.1.0 is done so let's start work on 1.2.0

[Anthony Baker]

bump

The json.org removal is complete.  Any thoughts on additional scope / timing / 
release manager?

Anthony

> On Feb 16, 2017, at 8:20 AM, Anthony Baker  wrote:
> 
> Great job everyone on releasing 1.1.0!  Let’s get organized for the next 
> release :-)
> 
> Scope:
>   We definitely need to focus on eliminating JSON.org prior to 4/31.  See 
> GEODE-629, GEODE-2142, GEODE-2331, GEODE-2380.
>   Anything else?
> 
> Timing:
>   I suggest shooting for a release candidate around mid-March if possible 
> (release often!)
> 
> Release Manager:
>   Any volunteers?
> 
> Note:  as a process reminder please don’t set Fix Version in JIRA unless you 
> fix a bug that has been merged to develop or the issue has been prioritized 
> by the community for inclusion in a release.
> 
> Thanks,
> Anthony
> 

[jira] [Assigned] (GEODE-2568) When its AsyncEventQueue is destroyed, its JMX MBean is not removed

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby reassigned GEODE-2568:


Assignee: Barry Oglesby

> When its AsyncEventQueue is destroyed, its JMX MBean is not removed
> ---
>
> Key: GEODE-2568
> URL: https://issues.apache.org/jira/browse/GEODE-2568
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Barry Oglesby
>Assignee: Barry Oglesby
>
> This results in the exception below if the AsyncEventQueue is re-added:
> {noformat}
> [warning 2017/03/01 10:53:33.500 PST   0> tid=0x3f] javax.management.InstanceAlreadyExistsException: 
> GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
> org.apache.geode.management.ManagementException: 
> javax.management.InstanceAlreadyExistsException: 
> GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
>   at 
> org.apache.geode.management.internal.MBeanJMXAdapter.registerMBean(MBeanJMXAdapter.java:114)
>   at 
> org.apache.geode.management.internal.SystemManagementService.registerInternalMBean(SystemManagementService.java:407)
>   at 
> org.apache.geode.management.internal.beans.ManagementAdapter.handleAsyncEventQueueCreation(ManagementAdapter.java:584)
>   at 
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:186)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2146)
>   at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:536)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.addAsyncEventQueue(GemFireCacheImpl.java:4068)
>   at 
> org.apache.geode.cache.asyncqueue.internal.AsyncEventQueueFactoryImpl.create(AsyncEventQueueFactoryImpl.java:197)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneIndexImpl.createAEQ(LuceneIndexImpl.java:184)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneIndexImpl.createAEQ(LuceneIndexImpl.java:150)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneIndexImpl.initialize(LuceneIndexImpl.java:140)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneServiceImpl.afterDataRegionCreated(LuceneServiceImpl.java:227)
>   at 
> org.apache.geode.cache.lucene.internal.LuceneServiceImpl$1.afterCreate(LuceneServiceImpl.java:207)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.invokeRegionAfter(GemFireCacheImpl.java:3370)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3349)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:3190)
>   at 
> org.apache.geode.internal.cache.GemFireCacheImpl.createRegion(GemFireCacheImpl.java:3178)
>   at org.apache.geode.cache.RegionFactory.create(RegionFactory.java:762)
>   at CreateRegionFunction.createRegion(CreateRegionFunction.java:27)
>   at CreateRegionFunction.execute(CreateRegionFunction.java:22)
>   at 
> org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66.executeFunctionaLocally(ExecuteFunction66.java:324)
>   at 
> org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66.cmdExecute(ExecuteFunction66.java:249)
>   at 
> org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction70.cmdExecute(ExecuteFunction70.java:55)
>   at 
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:141)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:783)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doOneMessage(ServerConnection.java:914)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1171)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:519)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: javax.management.InstanceAlreadyExistsException: 
> GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
>   at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:437)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1898)
>   at 
> 

[jira] [Created] (GEODE-2568) When its AsyncEventQueue is destroyed, its JMX MBean is not removed

[Barry Oglesby (JIRA)]

Barry Oglesby created GEODE-2568:


 Summary: When its AsyncEventQueue is destroyed, its JMX MBean is 
not removed
 Key: GEODE-2568
 URL: https://issues.apache.org/jira/browse/GEODE-2568
 Project: Geode
  Issue Type: Bug
  Components: wan
Reporter: Barry Oglesby


This results in the exception below if the AsyncEventQueue is re-added:
{noformat}
[warning 2017/03/01 10:53:33.500 PST   
tid=0x3f] javax.management.InstanceAlreadyExistsException: 
GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
org.apache.geode.management.ManagementException: 
javax.management.InstanceAlreadyExistsException: 
GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
at 
org.apache.geode.management.internal.MBeanJMXAdapter.registerMBean(MBeanJMXAdapter.java:114)
at 
org.apache.geode.management.internal.SystemManagementService.registerInternalMBean(SystemManagementService.java:407)
at 
org.apache.geode.management.internal.beans.ManagementAdapter.handleAsyncEventQueueCreation(ManagementAdapter.java:584)
at 
org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:186)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2146)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:536)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.addAsyncEventQueue(GemFireCacheImpl.java:4068)
at 
org.apache.geode.cache.asyncqueue.internal.AsyncEventQueueFactoryImpl.create(AsyncEventQueueFactoryImpl.java:197)
at 
org.apache.geode.cache.lucene.internal.LuceneIndexImpl.createAEQ(LuceneIndexImpl.java:184)
at 
org.apache.geode.cache.lucene.internal.LuceneIndexImpl.createAEQ(LuceneIndexImpl.java:150)
at 
org.apache.geode.cache.lucene.internal.LuceneIndexImpl.initialize(LuceneIndexImpl.java:140)
at 
org.apache.geode.cache.lucene.internal.LuceneServiceImpl.afterDataRegionCreated(LuceneServiceImpl.java:227)
at 
org.apache.geode.cache.lucene.internal.LuceneServiceImpl$1.afterCreate(LuceneServiceImpl.java:207)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.invokeRegionAfter(GemFireCacheImpl.java:3370)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3349)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:3190)
at 
org.apache.geode.internal.cache.GemFireCacheImpl.createRegion(GemFireCacheImpl.java:3178)
at org.apache.geode.cache.RegionFactory.create(RegionFactory.java:762)
at CreateRegionFunction.createRegion(CreateRegionFunction.java:27)
at CreateRegionFunction.execute(CreateRegionFunction.java:22)
at 
org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66.executeFunctionaLocally(ExecuteFunction66.java:324)
at 
org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66.cmdExecute(ExecuteFunction66.java:249)
at 
org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction70.cmdExecute(ExecuteFunction70.java:55)
at 
org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:141)
at 
org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:783)
at 
org.apache.geode.internal.cache.tier.sockets.ServerConnection.doOneMessage(ServerConnection.java:914)
at 
org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1171)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 
org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:519)
at java.lang.Thread.run(Thread.java:745)
Caused by: javax.management.InstanceAlreadyExistsException: 
GemFire:service=AsyncEventQueue,queue=cusip_index#_data,type=Member,member=192.168.2.9(74354)-1026
at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:437)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1898)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:966)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:900)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:324)
at 

[jira] [Assigned] (GEODE-2541) NetstatDUnitTest fails with ClassCastException

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe reassigned GEODE-2541:
---

Assignee: Kenneth Howe

> NetstatDUnitTest fails with ClassCastException
> --
>
> Key: GEODE-2541
> URL: https://issues.apache.org/jira/browse/GEODE-2541
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kenneth Howe
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> This might be a bug in the error handling code for gfsh or the functions used 
> by MiscellaneousCommands.
> {noformat}
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerOne FAILED
> org.junit.ComparisonFailure: [{"errorCode":505,"message":["Could not 
> process command due to GemFire error. Error occurred while executing netstat 
> on [server-1]"]}] expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerOne(NetstatDUnitTest.java:82)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToJmxManagerTwo FAILED
> java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.geode.management.internal.cli.result.CommandResult
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeCommand(GfshShellConnectionRule.java:159)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:166)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToJmxManagerTwo(NetstatDUnitTest.java:88)
> org.apache.geode.management.internal.cli.NetstatDUnitTest > 
> testConnectToLocator FAILED
> org.junit.ComparisonFailure: [{"errorCode":520,"message":["Could not find 
> member(s) with Id(s) or name(s): server-1."]}] expected:<[OK]> but 
> was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.test.dunit.rules.GfshShellConnectionRule.executeAndVerifyCommand(GfshShellConnectionRule.java:168)
> at 
> org.apache.geode.management.internal.cli.NetstatDUnitTest.testConnectToLocator(NetstatDUnitTest.java:76)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2567) gfsh destroy disk-store should be idempotent

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2567:
---

 Summary: gfsh destroy disk-store should be idempotent
 Key: GEODE-2567
 URL: https://issues.apache.org/jira/browse/GEODE-2567
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh
Reporter: Swapnil Bawaskar


Currently, gfsh {{destroy disk-store}} does *not* throw an error when run 
multiple times:
{{{
gfsh>destroy disk-store --name=foo
Member | Result
-- | ---
serv1  | Disk store not found on this member
serv2  | Disk store not found on this member

}}}
However, for a uniform user experience, it should. We should then add a 
{{--if-exists}} option to the command to make it idempotent.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2566) gfsh destroy index should be idempotent

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2566:
---

 Summary: gfsh destroy index should be idempotent
 Key: GEODE-2566
 URL: https://issues.apache.org/jira/browse/GEODE-2566
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh
Reporter: Swapnil Bawaskar


Currently, running destroy index multiple times return the following error:
{{{
gfsh>destroy index --name=i1
Index "i1" could not be destroyed for following reasons
Index named "i1" not found.
Occurred on following members
1. 192.168.1.181(serv1:17230):1025
2. 192.168.1.181(serv2:17842):1026
}}}
We should add a {{--if-exists}} option to destroy index command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2565) gfsh destroy gateway-sender should be idempotent

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2565:
---

 Summary: gfsh destroy gateway-sender should be idempotent
 Key: GEODE-2565
 URL: https://issues.apache.org/jira/browse/GEODE-2565
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh
Reporter: Swapnil Bawaskar


Currently, running destroy gateway-sender multiple times return the following 
error:
{{{
destroy gateway-sender --id=1

Member | Status
-- | -
serv2  | ERROR: GateWaySender with Id  1 not found
serv1  | ERROR: GateWaySender with Id  1 not found
}}}
We should add a {{--if-exists}} option to destroy gateway-sender command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57208: GEODE-2560: Missing disk files (.crf) during backup/restore throws exception

[Kevin Duling]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57208/
---

(Updated March 1, 2017, 12:56 p.m.)


Review request for geode, Darrel Schneider, Jared Stewart, Kirk Lund, and Dan 
Smith.


Repository: geode


Description
---

GEODE-2560: Missing disk files (.crf) during backup/restore throws exception


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
f5aec51a09e671bc7d4ca33d4de8f0f683ef4d73 


Diff: https://reviews.apache.org/r/57208/diff/2/

Changes: https://reviews.apache.org/r/57208/diff/1-2/


Testing
---

precheckin running


Thanks,

Kevin Duling

[jira] [Assigned] (GEODE-2551) Possible bugs in the source code

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker reassigned GEODE-2551:


Assignee: Anthony Baker

> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, serialization
>Reporter: AppChecker
>Assignee: Anthony Baker
> Fix For: 1.2.0
>
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2551) Possible bugs in the source code

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2551:
-
Component/s: serialization
 gfsh

> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, serialization
>Reporter: AppChecker
> Fix For: 1.2.0
>
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2551) Possible bugs in the source code

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker resolved GEODE-2551.
--
   Resolution: Fixed
Fix Version/s: 1.2.0

> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, serialization
>Reporter: AppChecker
>Assignee: Anthony Baker
> Fix For: 1.2.0
>
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2551) Possible bugs in the source code

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891011#comment-15891011
 ] 

ASF subversion and git services commented on GEODE-2551:


Commit 8b94e2ec2dc1192e96fc822b4b3a49561a76b2dc in geode's branch 
refs/heads/develop from [~amb]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8b94e2e ]

GEODE-2551 Fix code issues found by AppChecker

This closes #408


> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>Reporter: AppChecker
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #408: GEODE-2551 Fix code issues found by AppChecker

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/408


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2551) Possible bugs in the source code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891012#comment-15891012
 ] 

ASF GitHub Bot commented on GEODE-2551:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/408


> Possible bugs in the source code
> 
>
> Key: GEODE-2551
> URL: https://issues.apache.org/jira/browse/GEODE-2551
> Project: Geode
>  Issue Type: Bug
>Reporter: AppChecker
>
> Hello!
> We've checked your project with [static code analyzer 
> AppChecker|https://cnpo.ru/en/solutions/appchecker.php]
> It found several possible defects in the source code:
> 1) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/parser/ParserUtils.java#L96
> {code:java}
> if ((split[i].endsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> {noformat}split[i].endsWith("\"") {noformat} is checked twice.
> Probably it should be:
> {code:java}
> if ((split[i].startsWith("\"") && split[i].endsWith("\""))
> || (split[i].startsWith("\'") && split[i].endsWith("\'"))) {
> {code}
> 2) 
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1384
> https://github.com/apache/geode/blob/6e5013102927099a725282b6bad5d64a79152fab/geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java#L1444
> {code:java}
> else if (rs instanceof PortfolioPdx || rs instanceof PortfolioPdx) {
> {code}
> rs is checked twice
> 3) 
> https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JsonUtil.java#L388
> {code:java}
> } else if (klass.isAssignableFrom(Float.class) || 
> klass.isAssignableFrom(Float.class)) {
> {code}
> klass.isAssignableFrom(Float.class)  is checked twcie



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2561) Docs: error in gfsecurity.properties example (Geode User Guide)

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-2561:
--

Assignee: Dave Barnes

> Docs: error in gfsecurity.properties example (Geode User Guide)
> ---
>
> Key: GEODE-2561
> URL: https://issues.apache.org/jira/browse/GEODE-2561
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> Reported by Mike Martell:
> Looks like an error on this SSL Sample Impl page: 
> .../managing/security/ssl_example.html
> Seems like they're using a path for a password:
> ssl-truststore-password=/path/to/trusted.truststore
> [db note] 
> Check entire page to make sure properties shown are consistent with the 
> current implementation, as security properties (in particular) were recently 
> revised.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2563) All destroy commands in gfsh should be idempotent

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar updated GEODE-2563:

Description: If a developer is using gfsh script to define the geode 
cluster, we should support the ability to run the gfsh script multiple times.  
(was: If a developer is using gfsh script to define the geode cluster, we 
should support the ability to run the gfsh script multiple times. 
Currently, {{destroy region}} gfsh command throws an error if the region does 
not exist. We should an option {{--if-exists}} to the {{destroy region}} 
command so that it can be scripted.)

> All destroy commands in gfsh should be idempotent
> -
>
> Key: GEODE-2563
> URL: https://issues.apache.org/jira/browse/GEODE-2563
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>
> If a developer is using gfsh script to define the geode cluster, we should 
> support the ability to run the gfsh script multiple times.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2563) All destroy commands in gfsh should be idempotent

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar updated GEODE-2563:

Summary: All destroy commands in gfsh should be idempotent  (was: gfsh 
destroy region should be idempotent)

> All destroy commands in gfsh should be idempotent
> -
>
> Key: GEODE-2563
> URL: https://issues.apache.org/jira/browse/GEODE-2563
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>
> If a developer is using gfsh script to define the geode cluster, we should 
> support the ability to run the gfsh script multiple times. 
> Currently, {{destroy region}} gfsh command throws an error if the region does 
> not exist. We should an option {{--if-exists}} to the {{destroy region}} 
> command so that it can be scripted.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2563) gfsh destroy region should be idempotent

[Swapnil Bawaskar (JIRA)]

Swapnil Bawaskar created GEODE-2563:
---

 Summary: gfsh destroy region should be idempotent
 Key: GEODE-2563
 URL: https://issues.apache.org/jira/browse/GEODE-2563
 Project: Geode
  Issue Type: Improvement
  Components: gfsh
Reporter: Swapnil Bawaskar


If a developer is using gfsh script to define the geode cluster, we should 
support the ability to run the gfsh script multiple times. 
Currently, {{destroy region}} gfsh command throws an error if the region does 
not exist. We should an option {{--if-exists}} to the {{destroy region}} 
command so that it can be scripted.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #43: adding waypoints javascript for subnav

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/43


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---