[jira] [Commented] (GEODE-2796) NPE in ClassPathLoader

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975975#comment-15975975
 ] 

ASF subversion and git services commented on GEODE-2796:


Commit 48d662aab7ae4110f36a05aadefe9c12b48c1293 in geode's branch 
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=48d662a ]

GEODE-2796: ClassPathLoader does not blow up with null TCCL


> NPE in ClassPathLoader
> --
>
> Key: GEODE-2796
> URL: https://issues.apache.org/jira/browse/GEODE-2796
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> It looks like an NPE was introduced by the fix for GEODE-2290:
> {noformat}
> Caused by: java.lang.NullPointerException
> at 
> org.apache.geode.internal.ClassPathLoader.getResource(ClassPathLoader.java:130)
> at 
> org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:239)
> at 
> org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:264)
> at 
> org.apache.geode.internal.GemFireVersion$VersionDescription.(GemFireVersion.java:191)
> at 
> org.apache.geode.internal.GemFireVersion.getDescription(GemFireVersion.java:52)
> at 
> org.apache.geode.internal.GemFireVersion.getGemFireVersion(GemFireVersion.java:66)
> at org.apache.geode.cache.CacheFactory.getVersion(CacheFactory.java:305)
> ...
> {noformat}
> This is caused by the following method: 
> {noformat}
>  private List getClassLoaders() {
> ArrayList classLoaders = new ArrayList<>();
> if (!excludeTCCL) {
>   classLoaders.add(Thread.currentThread().getContextClassLoader());
> }
> classLoaders.add(classLoaderForDeployedJars);
> return classLoaders;
>   }
> {noformat}
> According to the JavaDocs, `getContextClassLoader()` actually returns null to 
> indicate the system class loader (rather than actually returning the system 
> class loader).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58550: AEQ regions being created before the user regions

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58550/
---

(Updated April 20, 2017, 2:03 a.m.)


Review request for geode, Jason Huynh and Dan Smith.


Repository: geode


Description
---

Testing a new start up mechanism where the AEQ is created before the user 
region. Please review and let us know if any modifications are needed, or if 
this is a viable solution


Diffs
-

  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 26bb488ed 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
 0f5553343 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 fea484547 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
 36f6720c3 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplFactory.java
 e99f3d9db 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneRawIndex.java
 75ab5cab3 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneRegionListener.java
 f4e2a79ef 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
 30952bfe2 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneEventListenerJUnitTest.java
 79de29a09 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java
 8e4c179a5 


Diff: https://reviews.apache.org/r/58550/diff/1/


Testing
---


Thanks,

nabarun nag

[jira] [Assigned] (GEODE-2802) TombstoneMessage can throw SerializationException when region is configured as persistent and non-persistent in cluster (in different nodes).

[Anilkumar Gingade (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade reassigned GEODE-2802:


Assignee: Anilkumar Gingade

> TombstoneMessage can throw SerializationException when region is configured 
> as persistent and non-persistent in cluster (in different nodes).
> -
>
> Key: GEODE-2802
> URL: https://issues.apache.org/jira/browse/GEODE-2802
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Assignee: Anilkumar Gingade
>
> TombstoneMessage serialization code assumes the member info in RVV to be 
> either membership-id or disk-id and uses this info while de-serializing.
> When there is a mix of persistent and non-persistent region in the cluster 
> (between nodes), the above assumption will not hold good; resulting in data 
> serialization exception.
> DistributedTombstoneOperation$TombstoneMessage
> toData() {
> -
> -
>  if (persistent) {
>   DiskStoreID id = new DiskStoreID();
>   InternalDataSerializer.invokeFromData(id, in);
>   mbr = id;
> } 
> -
> -



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2802) TombstoneMessage can throw SerializationException when region is configured as persistent and non-persistent in cluster (in different nodes).

[Anilkumar Gingade (JIRA)]

Anilkumar Gingade created GEODE-2802:


 Summary: TombstoneMessage can throw SerializationException when 
region is configured as persistent and non-persistent in cluster (in different 
nodes).
 Key: GEODE-2802
 URL: https://issues.apache.org/jira/browse/GEODE-2802
 Project: Geode
  Issue Type: Bug
  Components: regions
Reporter: Anilkumar Gingade


TombstoneMessage serialization code assumes the member info in RVV to be either 
membership-id or disk-id and uses this info while de-serializing.
When there is a mix of persistent and non-persistent region in the cluster 
(between nodes), the above assumption will not hold good; resulting in data 
serialization exception.

DistributedTombstoneOperation$TombstoneMessage
toData() {
-
-
 if (persistent) {
  DiskStoreID id = new DiskStoreID();
  InternalDataSerializer.invokeFromData(id, in);
  mbr = id;
} 
-
-




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2801) disk store backup can fail with ArrayIndexOutOfBoundsException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975770#comment-15975770
 ] 

ASF subversion and git services commented on GEODE-2801:


Commit 9e5b10b3b9b37929f5309a8918de33fa72ad6f3c in geode's branch 
refs/heads/feature/GEODE-2801 from [~dschneider]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9e5b10b ]

GEODE-2801: change krfIds to be thread safe


> disk store backup can fail with ArrayIndexOutOfBoundsException
> --
>
> Key: GEODE-2801
> URL: https://issues.apache.org/jira/browse/GEODE-2801
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>
> A race condition exists in which a disk store backup may fail with an 
> ArrayIndexOutOfBoundsException when calling hasKrf. Here is an example call 
> stack:
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 24
> at 
> it.unimi.dsi.fastutil.longs.LongOpenHashSet.contains(LongOpenHashSet.java:315)
> at 
> org.apache.geode.internal.cache.DiskInitFile.hasKrf(DiskInitFile.java:814)
> at org.apache.geode.internal.cache.Oplog.copyTo(Oplog.java:5724)
> at 
> org.apache.geode.internal.cache.DiskStoreImpl.finishBackup(DiskStoreImpl.java:4218)
> at 
> org.apache.geode.internal.cache.persistence.BackupManager.finishBackup(BackupManager.java:206)
> at 
> org.apache.geode.admin.internal.FinishBackupRequest.createResponse(FinishBackupRequest.java:101)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2801) disk store backup can fail with ArrayIndexOutOfBoundsException

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-2801:
---

Assignee: Darrel Schneider

> disk store backup can fail with ArrayIndexOutOfBoundsException
> --
>
> Key: GEODE-2801
> URL: https://issues.apache.org/jira/browse/GEODE-2801
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>
> A race condition exists in which a disk store backup may fail with an 
> ArrayIndexOutOfBoundsException when calling hasKrf. Here is an example call 
> stack:
> {code}
> java.lang.ArrayIndexOutOfBoundsException: 24
> at 
> it.unimi.dsi.fastutil.longs.LongOpenHashSet.contains(LongOpenHashSet.java:315)
> at 
> org.apache.geode.internal.cache.DiskInitFile.hasKrf(DiskInitFile.java:814)
> at org.apache.geode.internal.cache.Oplog.copyTo(Oplog.java:5724)
> at 
> org.apache.geode.internal.cache.DiskStoreImpl.finishBackup(DiskStoreImpl.java:4218)
> at 
> org.apache.geode.internal.cache.persistence.BackupManager.finishBackup(BackupManager.java:206)
> at 
> org.apache.geode.admin.internal.FinishBackupRequest.createResponse(FinishBackupRequest.java:101)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2801) disk store backup can fail with ArrayIndexOutOfBoundsException

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-2801:
---

 Summary: disk store backup can fail with 
ArrayIndexOutOfBoundsException
 Key: GEODE-2801
 URL: https://issues.apache.org/jira/browse/GEODE-2801
 Project: Geode
  Issue Type: Bug
  Components: persistence
Reporter: Darrel Schneider


A race condition exists in which a disk store backup may fail with an 
ArrayIndexOutOfBoundsException when calling hasKrf. Here is an example call 
stack:
{code}
java.lang.ArrayIndexOutOfBoundsException: 24
at 
it.unimi.dsi.fastutil.longs.LongOpenHashSet.contains(LongOpenHashSet.java:315)
at 
org.apache.geode.internal.cache.DiskInitFile.hasKrf(DiskInitFile.java:814)
at org.apache.geode.internal.cache.Oplog.copyTo(Oplog.java:5724)
at 
org.apache.geode.internal.cache.DiskStoreImpl.finishBackup(DiskStoreImpl.java:4218)
at 
org.apache.geode.internal.cache.persistence.BackupManager.finishBackup(BackupManager.java:206)
at 
org.apache.geode.admin.internal.FinishBackupRequest.createResponse(FinishBackupRequest.java:101)
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/#review172428
---


Ship it!




Ship It!

- Jinmei Liao


On April 19, 2017, 11:22 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58518/
> ---
> 
> (Updated April 19, 2017, 11:22 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'
> 
> - LocatorServerStarterRule will now always bounce the DUnit VMs in after() to 
> prevent corrupted cached values of `System.getProperty('user.dir')` that 
> refer to a temporary folder which no longer exists.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
>  d47b343 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
>  c5aaa74 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  34506c4 
>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberVM.java 
> 05e541a 
> 
> 
> Diff: https://reviews.apache.org/r/58518/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58537/#review172426
---


Ship it!




Ship It!

- Jinmei Liao


On April 19, 2017, 11:05 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58537/
> ---
> 
> (Updated April 19, 2017, 11:05 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl 
> dependencies
> 
> * extract fetching GemFireCacheImpl to Provider interface/class
> * use InternalCache instead of casting to Impl
> * delete useless javadocs and comments
> * reduce scope of constants, vars and methods
> * reorganize imports
> 
> I know that CacheProviderImpl still uses GemFireCacheImpl.getExisting, but 
> AbstractBaseController is now isolated from that so we can introduce better 
> unit testing by providing a mock of InternalCache at a later date. I decided 
> to package up the diff for geode-web-api as its own review and get it out of 
> the way of the geode-core refactorings.
> 
> 
> Diffs
> -
> 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
>  68080a3f27190eafb1541788b4f6bd6c93bd5346 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
>  89395425588abef7ff61a34aa30dfbe387342f89 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
>  62ce8609b437d02f43996cbb58d9fbbb33c9344e 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
>  e9b61f405c6c64f78551e137e1b98da02f920c4c 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
>  3b08c5fafd85d9513395037e01453a5f1fc94667 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
>  b00a7aa2d5d7439ba7c2d25fdd322448522cdf90 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java
>  PRE-CREATION 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58537/diff/3/
> 
> 
> Testing
> ---
> 
> precheckin passed
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/
---

(Updated April 19, 2017, 11:22 p.m.)


Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.


Changes
---

This uses a more elegant strategy to determine which VMs need bounced, rather 
than bouncing them all every time.


Repository: geode


Description
---

GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

- LocatorServerStarterRule will now always bounce the DUnit VMs in after() to 
prevent corrupted cached values of `System.getProperty('user.dir')` that refer 
to a temporary folder which no longer exists.


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
 d47b343 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
 c5aaa74 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 34506c4 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberVM.java 
05e541a 


Diff: https://reviews.apache.org/r/58518/diff/2/

Changes: https://reviews.apache.org/r/58518/diff/1-2/


Testing
---

Precheckin started (still running)


Thanks,

Jared Stewart

[jira] [Commented] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975733#comment-15975733
 ] 

ASF subversion and git services commented on GEODE-728:
---

Commit aaef124e3d4d7b46c82ddb4d2af65ee48b73ba53 in geode's branch 
refs/heads/develop from [~dalyssakim]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=aaef124 ]

GEODE-728: Rename Execution.withArgs to Execution.setArguments

 * created setArguments
 * deprecated withArgs
 * implemented setArguments of all Execution implementations in Geode project
 * replaced all of withArgs with setArguments

This closes #457


> Rename Execution.withArgs to Execution.setArguments
> ---
>
> Key: GEODE-728
> URL: https://issues.apache.org/jira/browse/GEODE-728
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, functions
>Reporter: Dan Smith
>Assignee: Alyssa Kim
>
> FunctionContext has a getArguments method. withArgs should be renamed to 
> match.
> See this discussion on the mailing list.
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201512.mbox/browser



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975734#comment-15975734
 ] 

ASF GitHub Bot commented on GEODE-728:
--

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/457


> Rename Execution.withArgs to Execution.setArguments
> ---
>
> Key: GEODE-728
> URL: https://issues.apache.org/jira/browse/GEODE-728
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, functions
>Reporter: Dan Smith
>Assignee: Alyssa Kim
>
> FunctionContext has a getArguments method. withArgs should be renamed to 
> match.
> See this discussion on the mailing list.
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201512.mbox/browser



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #457: GEODE-728 : Rename Execution.withArgs to Execution....

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/457


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (GEODE-510) Bug48571DUnitTest.testStatsMatchWithSize failed

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt reassigned GEODE-510:
--

Assignee: (was: Hitesh Khamesra)

> Bug48571DUnitTest.testStatsMatchWithSize failed
> ---
>
> Key: GEODE-510
> URL: https://issues.apache.org/jira/browse/GEODE-510
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: xiaojian zhou
>  Labels: CI, Flaky
> Fix For: 1.0.0-incubating.M3, 1.2.0
>
>
> revision d08e51d2eaa391fcda11cd18ee4413aa5fe6b80d
> {noformat}
> dunit.RMIException: While invoking 
> com.gemstone.gemfire.internal.cache.ha.Bug48571DUnitTest.createClientCache in 
> VM 1 running on Host venezuela.gemstone.com with 4 VMs
>   at dunit.VM.invoke(VM.java:170)
>   at 
> com.gemstone.gemfire.internal.cache.ha.Bug48571DUnitTest.testStatsMatchWithSize(Bug48571DUnitTest.java:99)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.GeneratedMethodAccessor176.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.GeneratedMethodAccessor175.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: 
> com.gemstone.gemfire.cache.NoSubscriptionServersAvailableException: 
> com.gemstone.gemfire.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
>   at 
> com.gemstone.gemfire.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:199)
>   at 
> com.gemstone.gemfire.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:531)
>   at 
> com.gemstone.gemfire.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:775)
>   at 
> 

[jira] [Resolved] (GEODE-510) Bug48571DUnitTest.testStatsMatchWithSize failed

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt resolved GEODE-510.

Fix Version/s: 1.2.0

> Bug48571DUnitTest.testStatsMatchWithSize failed
> ---
>
> Key: GEODE-510
> URL: https://issues.apache.org/jira/browse/GEODE-510
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: xiaojian zhou
>  Labels: CI, Flaky
> Fix For: 1.2.0, 1.0.0-incubating.M3
>
>
> revision d08e51d2eaa391fcda11cd18ee4413aa5fe6b80d
> {noformat}
> dunit.RMIException: While invoking 
> com.gemstone.gemfire.internal.cache.ha.Bug48571DUnitTest.createClientCache in 
> VM 1 running on Host venezuela.gemstone.com with 4 VMs
>   at dunit.VM.invoke(VM.java:170)
>   at 
> com.gemstone.gemfire.internal.cache.ha.Bug48571DUnitTest.testStatsMatchWithSize(Bug48571DUnitTest.java:99)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.GeneratedMethodAccessor176.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.GeneratedMethodAccessor175.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: 
> com.gemstone.gemfire.cache.NoSubscriptionServersAvailableException: 
> com.gemstone.gemfire.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
>   at 
> com.gemstone.gemfire.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:199)
>   at 
> com.gemstone.gemfire.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:531)
>   at 
> com.gemstone.gemfire.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:775)
>   at 
> 

[jira] [Commented] (GEODE-510) Bug48571DUnitTest.testStatsMatchWithSize failed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975724#comment-15975724
 ] 

ASF subversion and git services commented on GEODE-510:
---

Commit f038c2d9a57fcead8ace21ba81f2b357dcf81d34 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f038c2d ]

GEODE-510 Bug48571DUnitTest.testStatsMatchWithSize failed

This ticket was marked fixed in early 2016 but the Flaky annotation was
never removed and it was reopened by Anthony with no comment.  I'm removing
the Flaky annotation and closing the ticket.


> Bug48571DUnitTest.testStatsMatchWithSize failed
> ---
>
> Key: GEODE-510
> URL: https://issues.apache.org/jira/browse/GEODE-510
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: xiaojian zhou
>Assignee: Hitesh Khamesra
>  Labels: CI, Flaky
> Fix For: 1.0.0-incubating.M3
>
>
> revision d08e51d2eaa391fcda11cd18ee4413aa5fe6b80d
> {noformat}
> dunit.RMIException: While invoking 
> com.gemstone.gemfire.internal.cache.ha.Bug48571DUnitTest.createClientCache in 
> VM 1 running on Host venezuela.gemstone.com with 4 VMs
>   at dunit.VM.invoke(VM.java:170)
>   at 
> com.gemstone.gemfire.internal.cache.ha.Bug48571DUnitTest.testStatsMatchWithSize(Bug48571DUnitTest.java:99)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.GeneratedMethodAccessor176.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.GeneratedMethodAccessor175.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: 
> com.gemstone.gemfire.cache.NoSubscriptionServersAvailableException: 
> com.gemstone.gemfire.cache.NoSubscriptionServersAvailableException: Could not 

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58544/
---

(Updated April 19, 2017, 11:09 p.m.)


Review request for geode, Jason Huynh, Jinmei Liao, Jared Stewart, Ken Howe, 
and Dan Smith.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

GEODE-2632 refactoring part 5

GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

* minor cleanup: delete dead-code and useless javadocs/comments, reduce scope 
of vars/methods/constants, misc IDE warnings


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceProvider.java
 cded9c319e9731f74fb6ec14a7f4a02187ae1603 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/spi/CqServiceFactory.java
 68ebbd54d4d2459ec8df27b15ace8c83942723f6 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ClientCQImpl.java
 00a0aa5a9e7d8f770f2253e2c48dc6319d6864e3 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqQueryImpl.java
 22b4137c0d52bd84749b9617163b8723d1249ab6 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceFactoryImpl.java
 db90632437c80879b3ab213bbad34018809f1c31 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceImpl.java
 f1ca8328ad9b9c67e70292093f117cc885d911b5 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceStatisticsImpl.java
 ba71143cb271bd177b21e22e00d22a34f69c2834 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceVsdStats.java
 8435c4cea87401a6d29afc65d367d774dc3f4bf6 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ServerCQImpl.java
 ec6e984e24b3dcdf40628bb6f510d0ff96a800f5 
  
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ.java
 bcf98063c8ccf7c3d8ba44c9868b8921bb49a64b 
  
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java
 f333b4bdafdadad53060fe11ae9d98cc4f4593d4 
  
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java
 eac9ed3ad2da2afa92e1230d17b550301631307e 
  
geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqStatsDUnitTest.java
 7ace0e8e54bedf94622af5f011627a97c6316dd1 
  
geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqStatsUsingPoolDUnitTest.java
 d6068f1ecc88c076c3d1a8dbd3e3bc944766fbaa 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollector.java
 66c4c0a298156926793f66eee1ac3efc85b27a14 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java
 5313cedd48fa337ef9390a1659ed52dc9d9a0c77 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesCollectorJUnitTest.java
 3bfebdf2e3b213b6e8b89075f7510f8dc7fbfb4d 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java
 bf08877bf4cb1c8be07d69bd0bbdb529a2b2c340 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesJUnitTest.java
 fcfebbcb9b46a7beedecc661c31c71836df34dc2 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
 556311214371270259c024d565a6b4f0fa6a2146 


Diff: https://reviews.apache.org/r/58544/diff/3/

Changes: https://reviews.apache.org/r/58544/diff/2-3/


Testing
---

precheckin in progress


Thanks,

Kirk Lund

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

[Kirk Lund]

> On April 19, 2017, 10:27 p.m., Jinmei Liao wrote:
> > looks like your revision 1 and revision2 has no difference?

I updated again and it worked this time. Thanks!


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58537/#review172417
---


On April 19, 2017, 11:05 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58537/
> ---
> 
> (Updated April 19, 2017, 11:05 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl 
> dependencies
> 
> * extract fetching GemFireCacheImpl to Provider interface/class
> * use InternalCache instead of casting to Impl
> * delete useless javadocs and comments
> * reduce scope of constants, vars and methods
> * reorganize imports
> 
> I know that CacheProviderImpl still uses GemFireCacheImpl.getExisting, but 
> AbstractBaseController is now isolated from that so we can introduce better 
> unit testing by providing a mock of InternalCache at a later date. I decided 
> to package up the diff for geode-web-api as its own review and get it out of 
> the way of the geode-core refactorings.
> 
> 
> Diffs
> -
> 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
>  68080a3f27190eafb1541788b4f6bd6c93bd5346 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
>  89395425588abef7ff61a34aa30dfbe387342f89 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
>  62ce8609b437d02f43996cbb58d9fbbb33c9344e 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
>  e9b61f405c6c64f78551e137e1b98da02f920c4c 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
>  3b08c5fafd85d9513395037e01453a5f1fc94667 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
>  b00a7aa2d5d7439ba7c2d25fdd322448522cdf90 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java
>  PRE-CREATION 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58537/diff/3/
> 
> 
> Testing
> ---
> 
> precheckin passed
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58537/
---

(Updated April 19, 2017, 11:05 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.


Changes
---

Update diff again.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl 
dependencies

* extract fetching GemFireCacheImpl to Provider interface/class
* use InternalCache instead of casting to Impl
* delete useless javadocs and comments
* reduce scope of constants, vars and methods
* reorganize imports

I know that CacheProviderImpl still uses GemFireCacheImpl.getExisting, but 
AbstractBaseController is now isolated from that so we can introduce better 
unit testing by providing a mock of InternalCache at a later date. I decided to 
package up the diff for geode-web-api as its own review and get it out of the 
way of the geode-core refactorings.


Diffs (updated)
-

  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
 68080a3f27190eafb1541788b4f6bd6c93bd5346 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
 89395425588abef7ff61a34aa30dfbe387342f89 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
 62ce8609b437d02f43996cbb58d9fbbb33c9344e 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
 e9b61f405c6c64f78551e137e1b98da02f920c4c 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
 3b08c5fafd85d9513395037e01453a5f1fc94667 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
 b00a7aa2d5d7439ba7c2d25fdd322448522cdf90 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java
 PRE-CREATION 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58537/diff/3/

Changes: https://reviews.apache.org/r/58537/diff/2-3/


Testing
---

precheckin passed


Thanks,

Kirk Lund

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975684#comment-15975684
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit 3a4c6fc66afc59ba907ca815274a1ca73db0a8c3 in geode's branch 
refs/heads/feature/GEODE-2632-5 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3a4c6fc ]

GEODE-2103 Update gfsh start server|locator command
reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975686#comment-15975686
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit 8ea0f906917b40156d711717985b212364be72e1 in geode's branch 
refs/heads/feature/GEODE-2632-5 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8ea0f90 ]

Merge branch 'feature/GEODE-2103-2' into develop

This closes #462


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2605) Unable to do a Lucene query without CLUSTER:READ privilege

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975687#comment-15975687
 ] 

ASF subversion and git services commented on GEODE-2605:


Commit 9b49bc8fc53cb2520215e90930b2c9a27a918921 in geode's branch 
refs/heads/feature/GEODE-2632-5 from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9b49bc8 ]

GEODE-2605: Modified gfsh search lucene to require DATA:WRITE privilege to 
match client


> Unable to do a Lucene query without CLUSTER:READ privilege
> --
>
> Key: GEODE-2605
> URL: https://issues.apache.org/jira/browse/GEODE-2605
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene, security
>Reporter: Diane Hardman
>Assignee: Barry Oglesby
> Fix For: 1.2.0
>
> Attachments: security.json
>
>
> I have configured a small cluster with security and am testing the privileges 
> I need for creating a Lucene index and then executing a query/search using 
> Lucene. 
> I have confirmed that DATA:MANAGE privilege allows me to create a lucene 
> index (similar to creating OQL indexes).
> I assumed I needed DATA:WRITE privilege to execute 'search lucene' because 
> the implementation uses a function. Instead, I am getting an error that I 
> need CLUSTER:READ privilege. I don't know why.
> As an aside, we may want to document that all DATA privileges automatically 
> include CLUSTER:READ as I found I could create indexes with DATA:WRITE, but 
> could not list the indexes I created without CLUSTER:READ... go figure.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975685#comment-15975685
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit fdb7805292e34b7df998ac391b3ef98bc7778cbc in geode's branch 
refs/heads/feature/GEODE-2632-5 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fdb7805 ]

GEODE-2103 Revise http-service-port defn per review


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #460: Feature/geode 2703

[jhuynh1]

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/460


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #529 was SUCCESSFUL (with 1843 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #529 was successful.
---
Scheduled
1845 tests in total.

https://build.spring.io/browse/SGF-NAG-529/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58544/
---

(Updated April 19, 2017, 10:39 p.m.)


Review request for geode, Jason Huynh, Jinmei Liao, Jared Stewart, Ken Howe, 
and Dan Smith.


Changes
---

Fix compilation errors. Move lucene test utility to LuceneTestUtilies.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

GEODE-2632 refactoring part 5

GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

* minor cleanup: delete dead-code and useless javadocs/comments, reduce scope 
of vars/methods/constants, misc IDE warnings


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceProvider.java
 cded9c319e9731f74fb6ec14a7f4a02187ae1603 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/spi/CqServiceFactory.java
 68ebbd54d4d2459ec8df27b15ace8c83942723f6 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ClientCQImpl.java
 00a0aa5a9e7d8f770f2253e2c48dc6319d6864e3 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqQueryImpl.java
 22b4137c0d52bd84749b9617163b8723d1249ab6 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceFactoryImpl.java
 db90632437c80879b3ab213bbad34018809f1c31 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceImpl.java
 f1ca8328ad9b9c67e70292093f117cc885d911b5 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceStatisticsImpl.java
 ba71143cb271bd177b21e22e00d22a34f69c2834 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceVsdStats.java
 8435c4cea87401a6d29afc65d367d774dc3f4bf6 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ServerCQImpl.java
 ec6e984e24b3dcdf40628bb6f510d0ff96a800f5 
  
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ.java
 bcf98063c8ccf7c3d8ba44c9868b8921bb49a64b 
  
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java
 f333b4bdafdadad53060fe11ae9d98cc4f4593d4 
  
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java
 eac9ed3ad2da2afa92e1230d17b550301631307e 
  
geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqStatsDUnitTest.java
 7ace0e8e54bedf94622af5f011627a97c6316dd1 
  
geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqStatsUsingPoolDUnitTest.java
 d6068f1ecc88c076c3d1a8dbd3e3bc944766fbaa 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollector.java
 66c4c0a298156926793f66eee1ac3efc85b27a14 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java
 5313cedd48fa337ef9390a1659ed52dc9d9a0c77 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesCollectorJUnitTest.java
 3bfebdf2e3b213b6e8b89075f7510f8dc7fbfb4d 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java
 bf08877bf4cb1c8be07d69bd0bbdb529a2b2c340 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesJUnitTest.java
 fcfebbcb9b46a7beedecc661c31c71836df34dc2 
  
geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
 556311214371270259c024d565a6b4f0fa6a2146 


Diff: https://reviews.apache.org/r/58544/diff/2/

Changes: https://reviews.apache.org/r/58544/diff/1-2/


Testing
---

precheckin in progress


Thanks,

Kirk Lund

Re: Request For Geode Wiki Admin Karma

[Mark Bretl]

Thanks Dan! Much appreciated.

--Mark

On Wed, Apr 19, 2017 at 12:09 PM, Dan Smith  wrote:

> Hi Mark,
>
> I just made you a space admin on the wiki!
>
> -Dan
>
> On Wed, Apr 19, 2017 at 11:58 AM, Mark Bretl  wrote:
>
> > Ping.
> >
> > --Mark
> >
> > On Thu, Mar 30, 2017 at 3:51 PM, Mark Bretl  wrote:
> >
> > > Hi,
> > >
> > > I would like to follow Kirk's request with one of my own for Admin
> Karma
> > > on the Geode Wiki. Username is mbretl.
> > >
> > > Best Regards,
> > >
> > > --Mark
> > >
> >
>

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58537/#review172417
---



looks like your revision 1 and revision2 has no difference?

- Jinmei Liao


On April 19, 2017, 9:58 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58537/
> ---
> 
> (Updated April 19, 2017, 9:58 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl 
> dependencies
> 
> * extract fetching GemFireCacheImpl to Provider interface/class
> * use InternalCache instead of casting to Impl
> * delete useless javadocs and comments
> * reduce scope of constants, vars and methods
> * reorganize imports
> 
> I know that CacheProviderImpl still uses GemFireCacheImpl.getExisting, but 
> AbstractBaseController is now isolated from that so we can introduce better 
> unit testing by providing a mock of InternalCache at a later date. I decided 
> to package up the diff for geode-web-api as its own review and get it out of 
> the way of the geode-core refactorings.
> 
> 
> Diffs
> -
> 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
>  68080a3f27190eafb1541788b4f6bd6c93bd5346 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
>  89395425588abef7ff61a34aa30dfbe387342f89 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
>  62ce8609b437d02f43996cbb58d9fbbb33c9344e 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
>  e9b61f405c6c64f78551e137e1b98da02f920c4c 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
>  3b08c5fafd85d9513395037e01453a5f1fc94667 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
>  b00a7aa2d5d7439ba7c2d25fdd322448522cdf90 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java
>  PRE-CREATION 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58537/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin passed
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58537/
---

(Updated April 19, 2017, 9:58 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.


Changes
---

Remove getCache from CacheProvider.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl 
dependencies

* extract fetching GemFireCacheImpl to Provider interface/class
* use InternalCache instead of casting to Impl
* delete useless javadocs and comments
* reduce scope of constants, vars and methods
* reorganize imports

I know that CacheProviderImpl still uses GemFireCacheImpl.getExisting, but 
AbstractBaseController is now isolated from that so we can introduce better 
unit testing by providing a mock of InternalCache at a later date. I decided to 
package up the diff for geode-web-api as its own review and get it out of the 
way of the geode-core refactorings.


Diffs (updated)
-

  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
 68080a3f27190eafb1541788b4f6bd6c93bd5346 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
 89395425588abef7ff61a34aa30dfbe387342f89 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
 62ce8609b437d02f43996cbb58d9fbbb33c9344e 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
 e9b61f405c6c64f78551e137e1b98da02f920c4c 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
 3b08c5fafd85d9513395037e01453a5f1fc94667 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
 b00a7aa2d5d7439ba7c2d25fdd322448522cdf90 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java
 PRE-CREATION 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58537/diff/2/

Changes: https://reviews.apache.org/r/58537/diff/1-2/


Testing
---

precheckin passed


Thanks,

Kirk Lund

[jira] [Commented] (GEODE-2605) Unable to do a Lucene query without CLUSTER:READ privilege

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975611#comment-15975611
 ] 

ASF subversion and git services commented on GEODE-2605:


Commit 9b49bc8fc53cb2520215e90930b2c9a27a918921 in geode's branch 
refs/heads/feature/GEODE-2632-3 from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9b49bc8 ]

GEODE-2605: Modified gfsh search lucene to require DATA:WRITE privilege to 
match client


> Unable to do a Lucene query without CLUSTER:READ privilege
> --
>
> Key: GEODE-2605
> URL: https://issues.apache.org/jira/browse/GEODE-2605
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene, security
>Reporter: Diane Hardman
>Assignee: Barry Oglesby
> Fix For: 1.2.0
>
> Attachments: security.json
>
>
> I have configured a small cluster with security and am testing the privileges 
> I need for creating a Lucene index and then executing a query/search using 
> Lucene. 
> I have confirmed that DATA:MANAGE privilege allows me to create a lucene 
> index (similar to creating OQL indexes).
> I assumed I needed DATA:WRITE privilege to execute 'search lucene' because 
> the implementation uses a function. Instead, I am getting an error that I 
> need CLUSTER:READ privilege. I don't know why.
> As an aside, we may want to document that all DATA privileges automatically 
> include CLUSTER:READ as I found I could create indexes with DATA:WRITE, but 
> could not list the indexes I created without CLUSTER:READ... go figure.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975608#comment-15975608
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit 3a4c6fc66afc59ba907ca815274a1ca73db0a8c3 in geode's branch 
refs/heads/feature/GEODE-2632-3 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3a4c6fc ]

GEODE-2103 Update gfsh start server|locator command
reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975610#comment-15975610
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit 8ea0f906917b40156d711717985b212364be72e1 in geode's branch 
refs/heads/feature/GEODE-2632-3 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8ea0f90 ]

Merge branch 'feature/GEODE-2103-2' into develop

This closes #462


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975609#comment-15975609
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit fdb7805292e34b7df998ac391b3ef98bc7778cbc in geode's branch 
refs/heads/feature/GEODE-2632-3 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fdb7805 ]

GEODE-2103 Revise http-service-port defn per review


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58544/
---

Review request for geode, Jason Huynh, Jinmei Liao, Jared Stewart, Ken Howe, 
and Dan Smith.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

GEODE-2632 refactoring part 5

GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

* minor cleanup: delete dead-code and useless javadocs/comments, reduce scope 
of vars/methods/constants, misc IDE warnings


Diffs
-

  
geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceProvider.java
 cded9c319e9731f74fb6ec14a7f4a02187ae1603 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/spi/CqServiceFactory.java
 68ebbd54d4d2459ec8df27b15ace8c83942723f6 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ClientCQImpl.java
 00a0aa5a9e7d8f770f2253e2c48dc6319d6864e3 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqQueryImpl.java
 22b4137c0d52bd84749b9617163b8723d1249ab6 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceFactoryImpl.java
 db90632437c80879b3ab213bbad34018809f1c31 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceImpl.java
 f1ca8328ad9b9c67e70292093f117cc885d911b5 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceStatisticsImpl.java
 ba71143cb271bd177b21e22e00d22a34f69c2834 
  
geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceVsdStats.java
 8435c4cea87401a6d29afc65d367d774dc3f4bf6 
  
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ.java
 bcf98063c8ccf7c3d8ba44c9868b8921bb49a64b 
  
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java
 f333b4bdafdadad53060fe11ae9d98cc4f4593d4 
  
geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java
 eac9ed3ad2da2afa92e1230d17b550301631307e 
  
geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqStatsDUnitTest.java
 7ace0e8e54bedf94622af5f011627a97c6316dd1 
  
geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqStatsUsingPoolDUnitTest.java
 d6068f1ecc88c076c3d1a8dbd3e3bc944766fbaa 
  
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollector.java
 66c4c0a298156926793f66eee1ac3efc85b27a14 


Diff: https://reviews.apache.org/r/58544/diff/1/


Testing
---

precheckin in progress


Thanks,

Kirk Lund

[jira] [Assigned] (GEODE-2605) Unable to do a Lucene query without CLUSTER:READ privilege

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby reassigned GEODE-2605:


Assignee: Barry Oglesby

> Unable to do a Lucene query without CLUSTER:READ privilege
> --
>
> Key: GEODE-2605
> URL: https://issues.apache.org/jira/browse/GEODE-2605
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene, security
>Reporter: Diane Hardman
>Assignee: Barry Oglesby
> Fix For: 1.2.0
>
> Attachments: security.json
>
>
> I have configured a small cluster with security and am testing the privileges 
> I need for creating a Lucene index and then executing a query/search using 
> Lucene. 
> I have confirmed that DATA:MANAGE privilege allows me to create a lucene 
> index (similar to creating OQL indexes).
> I assumed I needed DATA:WRITE privilege to execute 'search lucene' because 
> the implementation uses a function. Instead, I am getting an error that I 
> need CLUSTER:READ privilege. I don't know why.
> As an aside, we may want to document that all DATA privileges automatically 
> include CLUSTER:READ as I found I could create indexes with DATA:WRITE, but 
> could not list the indexes I created without CLUSTER:READ... go figure.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2605) Unable to do a Lucene query without CLUSTER:READ privilege

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby resolved GEODE-2605.
--
   Resolution: Fixed
Fix Version/s: 1.2.0

> Unable to do a Lucene query without CLUSTER:READ privilege
> --
>
> Key: GEODE-2605
> URL: https://issues.apache.org/jira/browse/GEODE-2605
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene, security
>Reporter: Diane Hardman
>Assignee: Barry Oglesby
> Fix For: 1.2.0
>
> Attachments: security.json
>
>
> I have configured a small cluster with security and am testing the privileges 
> I need for creating a Lucene index and then executing a query/search using 
> Lucene. 
> I have confirmed that DATA:MANAGE privilege allows me to create a lucene 
> index (similar to creating OQL indexes).
> I assumed I needed DATA:WRITE privilege to execute 'search lucene' because 
> the implementation uses a function. Instead, I am getting an error that I 
> need CLUSTER:READ privilege. I don't know why.
> As an aside, we may want to document that all DATA privileges automatically 
> include CLUSTER:READ as I found I could create indexes with DATA:WRITE, but 
> could not list the indexes I created without CLUSTER:READ... go figure.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2605) Unable to do a Lucene query without CLUSTER:READ privilege

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975568#comment-15975568
 ] 

ASF subversion and git services commented on GEODE-2605:


Commit 9b49bc8fc53cb2520215e90930b2c9a27a918921 in geode's branch 
refs/heads/develop from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9b49bc8 ]

GEODE-2605: Modified gfsh search lucene to require DATA:WRITE privilege to 
match client


> Unable to do a Lucene query without CLUSTER:READ privilege
> --
>
> Key: GEODE-2605
> URL: https://issues.apache.org/jira/browse/GEODE-2605
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene, security
>Reporter: Diane Hardman
> Attachments: security.json
>
>
> I have configured a small cluster with security and am testing the privileges 
> I need for creating a Lucene index and then executing a query/search using 
> Lucene. 
> I have confirmed that DATA:MANAGE privilege allows me to create a lucene 
> index (similar to creating OQL indexes).
> I assumed I needed DATA:WRITE privilege to execute 'search lucene' because 
> the implementation uses a function. Instead, I am getting an error that I 
> need CLUSTER:READ privilege. I don't know why.
> As an aside, we may want to document that all DATA privileges automatically 
> include CLUSTER:READ as I found I could create indexes with DATA:WRITE, but 
> could not list the indexes I created without CLUSTER:READ... go figure.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2680) Gfsh start server command hangs while waiting for offline members

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975527#comment-15975527
 ] 

Anthony Baker commented on GEODE-2680:
--

Is this the expected behavior?

1) Wait for a period of time.
2) If the server hasn't started, log which members are being waited for (so the 
user could potentially revoke their disk stores).
3) Return control to the user after timing out.


> Gfsh start server command hangs while waiting for offline members
> -
>
> Key: GEODE-2680
> URL: https://issues.apache.org/jira/browse/GEODE-2680
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.1.0
>Reporter: Jason Huynh
> Attachments: cache.xml, oplogs1.tar.gz
>
>
> When starting up a server with persistent files, the server waits for the 
> other offline members as expected.  However the gfsh command seems to not 
> abort and instead is “stuck.”  Gfsh should complete and allow the user/admin 
> to continue administering commands to revoke members etc.
> Attached is a cache xml file and oplogs to reproduce the file.
> Steps to reproduce:
> Configuration:
> 1.) Edit the cache.xml file to point to the appropriate disk store location
> Commands:
> 1.) start locator —-name=locator1
> 2.) start server --name=server1  -—cache-xml-file=cache.xml
> Now the process is stuck.  In my run the locator eventually shuts itself down 
> too...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Edit Permissions for Confluence

[Galen M O'Sullivan]

Works! Thanks, Dan.
Galen

On Wed, Apr 19, 2017 at 12:07 PM, Dan Smith  wrote:

> I just added you, hopefully you should be able to edit now.
>
> -Dan
>
> On Wed, Apr 19, 2017 at 11:44 AM, Galen M O'Sullivan <
> gosulli...@pivotal.io>
> wrote:
>
> > Hi,
> >
> > I don't seem to have edit permissions for the Apache Confluence wiki.
> Would
> > someone with the proper permissions be willing to give me the proper
> > permissions, please? Username gosullivan.
> >
> > Thanks,
> > Galen
> >
>

[jira] [Resolved] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-2103.

Resolution: Fixed

> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975499#comment-15975499
 ] 

ASF GitHub Bot commented on GEODE-2103:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/462


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975497#comment-15975497
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit fdb7805292e34b7df998ac391b3ef98bc7778cbc in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fdb7805 ]

GEODE-2103 Revise http-service-port defn per review


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975498#comment-15975498
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit 8ea0f906917b40156d711717985b212364be72e1 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8ea0f90 ]

Merge branch 'feature/GEODE-2103-2' into develop

This closes #462


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #462: GEODE-2103 Update gfsh start server|locator command

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/462


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975496#comment-15975496
 ] 

ASF subversion and git services commented on GEODE-2103:


Commit 3a4c6fc66afc59ba907ca815274a1ca73db0a8c3 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3a4c6fc ]

GEODE-2103 Update gfsh start server|locator command
reference page.

- the optional http-service-port defaults to 7070
- both http-service-port and http-service-bind-address
are available for gfsh start server and gfsh start locator


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975491#comment-15975491
 ] 

ASF GitHub Bot commented on GEODE-2103:
---

Github user joeymcallister commented on the issue:

https://github.com/apache/geode/pull/462
  
+1


> start locator command should include --http-service-port and 
> --http-service-bind-address
> 
>
> Key: GEODE-2103
> URL: https://issues.apache.org/jira/browse/GEODE-2103
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, management
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> To facilitate starting the Admin REST API on a Locator, start locator command 
> should include --http-service-port and --http-service-bind-address.
> Workaround is to specify these configuration properties with --J:
> --J=-Dgemfire.http-service-port=
> --J=-Dgemfire.http-service-bind-address=



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #462: GEODE-2103 Update gfsh start server|locator command

[joeymcallister]

Github user joeymcallister commented on the issue:

https://github.com/apache/geode/pull/462
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58537/#review172405
---




geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java
Lines 24 (patched)


Do we need this method? Shouldn't getInternalCache also returns a Cache 
object, so any caller of this should just call getInteralCache then?


- Jinmei Liao


On April 19, 2017, 8:36 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58537/
> ---
> 
> (Updated April 19, 2017, 8:36 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl 
> dependencies
> 
> * extract fetching GemFireCacheImpl to Provider interface/class
> * use InternalCache instead of casting to Impl
> * delete useless javadocs and comments
> * reduce scope of constants, vars and methods
> * reorganize imports
> 
> I know that CacheProviderImpl still uses GemFireCacheImpl.getExisting, but 
> AbstractBaseController is now isolated from that so we can introduce better 
> unit testing by providing a mock of InternalCache at a later date. I decided 
> to package up the diff for geode-web-api as its own review and get it out of 
> the way of the geode-core refactorings.
> 
> 
> Diffs
> -
> 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
>  68080a3f27190eafb1541788b4f6bd6c93bd5346 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
>  89395425588abef7ff61a34aa30dfbe387342f89 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
>  62ce8609b437d02f43996cbb58d9fbbb33c9344e 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
>  e9b61f405c6c64f78551e137e1b98da02f920c4c 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
>  3b08c5fafd85d9513395037e01453a5f1fc94667 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
>  b00a7aa2d5d7439ba7c2d25fdd322448522cdf90 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java
>  PRE-CREATION 
>   
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58537/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin passed
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58537/
---

(Updated April 19, 2017, 8:36 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl 
dependencies

* extract fetching GemFireCacheImpl to Provider interface/class
* use InternalCache instead of casting to Impl
* delete useless javadocs and comments
* reduce scope of constants, vars and methods
* reorganize imports

I know that CacheProviderImpl still uses GemFireCacheImpl.getExisting, but 
AbstractBaseController is now isolated from that so we can introduce better 
unit testing by providing a mock of InternalCache at a later date. I decided to 
package up the diff for geode-web-api as its own review and get it out of the 
way of the geode-core refactorings.


Diffs
-

  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
 68080a3f27190eafb1541788b4f6bd6c93bd5346 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
 89395425588abef7ff61a34aa30dfbe387342f89 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
 62ce8609b437d02f43996cbb58d9fbbb33c9344e 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
 e9b61f405c6c64f78551e137e1b98da02f920c4c 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
 3b08c5fafd85d9513395037e01453a5f1fc94667 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
 b00a7aa2d5d7439ba7c2d25fdd322448522cdf90 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java
 PRE-CREATION 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58537/diff/1/


Testing (updated)
---

precheckin passed


Thanks,

Kirk Lund

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

[Kirk Lund]

> On April 19, 2017, 8:32 p.m., Kirk Lund wrote:
> > It looks like LocatorServerStartupRule now always bounces VMs even if the 
> > test did not change user.dir. I thought you wanted it to bounce only if 
> > user.dir was altered?

Maybe a UserDirRule would be better? This change will cause us to bounce the 
DUnit VMs after each test method in any dunit test that uses 
LocatorServerStartupRule.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/#review172401
---


On April 18, 2017, 9:58 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58518/
> ---
> 
> (Updated April 18, 2017, 9:58 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'
> 
> - LocatorServerStarterRule will now always bounce the DUnit VMs in after() to 
> prevent corrupted cached values of `System.getProperty('user.dir')` that 
> refer to a temporary folder which no longer exists.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
>  d47b3435a644f21ea28782c458afc6891577b1f4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
>  c5aaa743935bd0e5bff771213d111cb2f9b929cb 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  34506c4fa803a1121c29d240ad7d7aa6a55dca99 
> 
> 
> Diff: https://reviews.apache.org/r/58518/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/#review172401
---



It looks like LocatorServerStartupRule now always bounces VMs even if the test 
did not change user.dir. I thought you wanted it to bounce only if user.dir was 
altered?

- Kirk Lund


On April 18, 2017, 9:58 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58518/
> ---
> 
> (Updated April 18, 2017, 9:58 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'
> 
> - LocatorServerStarterRule will now always bounce the DUnit VMs in after() to 
> prevent corrupted cached values of `System.getProperty('user.dir')` that 
> refer to a temporary folder which no longer exists.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
>  d47b3435a644f21ea28782c458afc6891577b1f4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
>  c5aaa743935bd0e5bff771213d111cb2f9b929cb 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  34506c4fa803a1121c29d240ad7d7aa6a55dca99 
> 
> 
> Diff: https://reviews.apache.org/r/58518/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 58519: GEODE-2796: ClassPathLoader does not blow up with null TCCL

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58519/#review172400
---


Ship it!




Ship It!

- Kirk Lund


On April 19, 2017, 8:18 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58519/
> ---
> 
> (Updated April 19, 2017, 8:18 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2796: ClassPathLoader does not blow up with null TCCL
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/ClassPathLoader.java 
> 41cce05ce8c1cbf559f365d754e1db1b8bc98b3d 
>   
> geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java
>  c78331895bd33a6b908338af0cec7e60ed56b944 
> 
> 
> Diff: https://reviews.apache.org/r/58519/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin passed
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

[Jinmei Liao]

> On April 19, 2017, 4:30 p.m., Jinmei Liao wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
> > Lines 82 (patched)
> > 
> >
> > this class also has a stopMember call, does that needs to call bounce() 
> > too?
> > 
> > Is it possible that we have a cleanAndBounceVM function that would 
> > invoke the cleanupVM first inside the vm, and then bounce it, so that the 
> > after will just invoke this cleanAndBounce?
> 
> Jared Stewart wrote:
> Sure, it seems like just adding `member.getVM().bounce();` to the end of 
> stopMember() ought to be enough?

sounds good.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/#review172356
---


On April 18, 2017, 9:58 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58518/
> ---
> 
> (Updated April 18, 2017, 9:58 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'
> 
> - LocatorServerStarterRule will now always bounce the DUnit VMs in after() to 
> prevent corrupted cached values of `System.getProperty('user.dir')` that 
> refer to a temporary folder which no longer exists.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
>  d47b3435a644f21ea28782c458afc6891577b1f4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
>  c5aaa743935bd0e5bff771213d111cb2f9b929cb 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  34506c4fa803a1121c29d240ad7d7aa6a55dca99 
> 
> 
> Diff: https://reviews.apache.org/r/58518/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Review Request 58541: GEODE-576 & GEODE-516 Flaky test: GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58541/
---

Review request for geode, Galen O'Sullivan, Hitesh Khamesra, Udo Kohlmeyer, and 
Dan Smith.


Bugs: GEODE-516 and GEODE-576
https://issues.apache.org/jira/browse/GEODE-516
https://issues.apache.org/jira/browse/GEODE-576


Repository: geode


Description
---

Replaced pauses with Awaitilty.  Modified asyncs to use the DUnit blackboard to 
synchronize their actions for repeatable behavior.  Cleaned up static locks to 
allow their reuse in other tests or in repeating the same test.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java
 e0bbde06ba2ce8e8db55627920ee6cf23e4badb2 


Diff: https://reviews.apache.org/r/58541/diff/1/


Testing
---


Thanks,

Bruce Schuchardt

[GitHub] geode pull request #462: GEODE-2103 Update gfsh start server|locator command

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/462#discussion_r112304411
  
--- Diff: geode-docs/tools_modules/gfsh/command-pages/start.html.md.erb ---
@@ -398,6 +400,17 @@ See Overview of
 cluster-config
 
 
+\-\-http-service-port
+Specifies the port on which the HTTP service will listen.
--- End diff --

Maybe this should be "Specifies the port on which the HTTP service is 
started on


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (GEODE-576) CI Failure: GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt reassigned GEODE-576:
--

Assignee: Bruce Schuchardt

> CI Failure: 
> GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction
> 
>
> Key: GEODE-576
> URL: https://issues.apache.org/jira/browse/GEODE-576
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Barry Oglesby
>Assignee: Bruce Schuchardt
>  Labels: CI, Flaky
>
> Geode_develop_DistributedTests
> Private Build #612 (Nov 17, 2015 5:09:11 PM)
> Revision: 90b9a632b9738319fc7a7fddb93b6bef9ff57f7d
> Error Message
> {noformat}
> java.lang.Exception: An exception occured during async invocation
> {noformat}
> Stacktrace
> {noformat}
> java.lang.Exception: An exception occured during async invocation
>   at dunit.AsyncInvocation.getResult(AsyncInvocation.java:195)
>   at 
> com.gemstone.gemfire.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction(GemFireDeadlockDetectorDUnitTest.java:121)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.GeneratedMethodAccessor137.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.GeneratedMethodAccessor136.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: dunit.RMIException: While invoking 
> com.gemstone.gemfire.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest$2.run
>  in VM 0 running on Host rooktwo.gemstone.com with 4 VMs
>   at dunit.VM.invoke(VM.java:369)
>   at dunit.VM$2.run(VM.java:220)
>   at java.lang.Thread.run(Thread.java:745)
>   at dunit.AsyncInvocation.run(AsyncInvocation.java:209)
> Caused by: 
> 

[jira] [Assigned] (GEODE-516) GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction has NullPointerException

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt reassigned GEODE-516:
--

Assignee: Bruce Schuchardt

> GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction has 
> NullPointerException
> -
>
> Key: GEODE-516
> URL: https://issues.apache.org/jira/browse/GEODE-516
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: xiaojian zhou
>Assignee: Bruce Schuchardt
>  Labels: Flaky, ShowDeadlockCommand
>
> revision 0cc9d895b9f4465138d0fa223b0a0cadc1107893
> {noformat}
> java.lang.NullPointerException
>   at 
> com.gemstone.gemfire.distributed.internal.deadlock.DeadlockDetector.prettyFormat(DeadlockDetector.java:151)
>   at 
> com.gemstone.gemfire.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction(GemFireDeadlockDetectorDUnitTest.java:118)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.GeneratedMethodAccessor215.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.GeneratedMethodAccessor214.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2763) Remove of nonSingleHopsCount stat in client

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975442#comment-15975442
 ] 

ASF GitHub Bot commented on GEODE-2763:
---

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/90
  
@ameybarve15 @PivotalSarge will have a look at this soon.  
May we stay on the feature branch until the PR is approved, which will 
alleviate the  "merge" commit... 


> Remove of nonSingleHopsCount stat in client
> ---
>
> Key: GEODE-2763
> URL: https://issues.apache.org/jira/browse/GEODE-2763
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Michael Dodge
>Assignee: Amey Barve
>
> A pre-existing issue (GEODE-2017) required the removal of the 
> nonSingleHopsCount statistic in the clients. Whilst marked for the native 
> client as well, it was not addressed in the native client. It should be.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/90
  
@ameybarve15 @PivotalSarge will have a look at this soon.  
May we stay on the feature branch until the PR is approved, which will 
alleviate the  "merge" commit... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 58519: GEODE-2796: ClassPathLoader does not blow up with null TCCL

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58519/
---

(Updated April 19, 2017, 8:18 p.m.)


Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.


Repository: geode


Description
---

GEODE-2796: ClassPathLoader does not blow up with null TCCL


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/ClassPathLoader.java 
41cce05ce8c1cbf559f365d754e1db1b8bc98b3d 
  
geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java
 c78331895bd33a6b908338af0cec7e60ed56b944 


Diff: https://reviews.apache.org/r/58519/diff/1/


Testing (updated)
---

Precheckin passed


Thanks,

Jared Stewart

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

[Jared Stewart]

> On April 19, 2017, 4:30 p.m., Jinmei Liao wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
> > Lines 82 (patched)
> > 
> >
> > this class also has a stopMember call, does that needs to call bounce() 
> > too?
> > 
> > Is it possible that we have a cleanAndBounceVM function that would 
> > invoke the cleanupVM first inside the vm, and then bounce it, so that the 
> > after will just invoke this cleanAndBounce?

Sure, it seems like just adding `member.getVM().bounce();` to the end of 
stopMember() ought to be enough?


- Jared


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/#review172356
---


On April 18, 2017, 9:58 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58518/
> ---
> 
> (Updated April 18, 2017, 9:58 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'
> 
> - LocatorServerStarterRule will now always bounce the DUnit VMs in after() to 
> prevent corrupted cached values of `System.getProperty('user.dir')` that 
> refer to a temporary folder which no longer exists.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
>  d47b3435a644f21ea28782c458afc6891577b1f4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
>  c5aaa743935bd0e5bff771213d111cb2f9b929cb 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  34506c4fa803a1121c29d240ad7d7aa6a55dca99 
> 
> 
> Diff: https://reviews.apache.org/r/58518/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[jira] [Commented] (GEODE-2780) Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975425#comment-15975425
 ] 

ASF GitHub Bot commented on GEODE-2780:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/93


> Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> -
>
> Key: GEODE-2780
> URL: https://issues.apache.org/jira/browse/GEODE-2780
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Amey Barve
>Assignee: Amey Barve
>
> There is typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> ### Required Tools
> * [CMake 4.3](https://cmake.org/) or newer
> There is no version 4.3 of CMake



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2780) Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975423#comment-15975423
 ] 

ASF subversion and git services commented on GEODE-2780:


Commit a286f1209a9c6d4c26e836a99476281d6e354d6c in geode-native's branch 
refs/heads/develop from [~abarve]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=a286f12 ]

GEODE-2780: Fixing typo in client CONTRIBUTING.md file CMake 4.3 changed
to be CMake 3.4. There is no version 4.3 of CMake.


> Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> -
>
> Key: GEODE-2780
> URL: https://issues.apache.org/jira/browse/GEODE-2780
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Amey Barve
>Assignee: Amey Barve
>
> There is typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> ### Required Tools
> * [CMake 4.3](https://cmake.org/) or newer
> There is no version 4.3 of CMake



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #93: GEODE-2780: Fixing typo in client CONTRIBUTIN...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/93


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Request For Geode Wiki Admin Karma

[Dan Smith]

Hi Mark,

I just made you a space admin on the wiki!

-Dan

On Wed, Apr 19, 2017 at 11:58 AM, Mark Bretl  wrote:

> Ping.
>
> --Mark
>
> On Thu, Mar 30, 2017 at 3:51 PM, Mark Bretl  wrote:
>
> > Hi,
> >
> > I would like to follow Kirk's request with one of my own for Admin Karma
> > on the Geode Wiki. Username is mbretl.
> >
> > Best Regards,
> >
> > --Mark
> >
>

Re: Edit Permissions for Confluence

[Dan Smith]

I just added you, hopefully you should be able to edit now.

-Dan

On Wed, Apr 19, 2017 at 11:44 AM, Galen M O'Sullivan 
wrote:

> Hi,
>
> I don't seem to have edit permissions for the Apache Confluence wiki. Would
> someone with the proper permissions be willing to give me the proper
> permissions, please? Username gosullivan.
>
> Thanks,
> Galen
>

[jira] [Updated] (GEODE-2682) Compaction with async disk writes may resurrect removed entries

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-2682:
--
Labels: storage_2  (was: )

> Compaction with async disk writes may resurrect removed entries
> ---
>
> Key: GEODE-2682
> URL: https://issues.apache.org/jira/browse/GEODE-2682
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Jason Huynh
>  Labels: storage_2
> Attachments: cache.xml, oplogs.tar.gz
>
>
> This can occur for persistent async event queues and for regions when 
> concurrency checks are disabled.
> Currently->
> 1.) When rolling a crf we create a krf that is based on the current “live” 
> region
> 2.) If removes are being done at the same time, the krf will reflect the 
> current state, where the keys are not part of the krf file
> 3.) Due to the async disk write, the drf has yet to be updated.
> 4.) If the cluster gets shut down before the drf is written to.  This can 
> lead to the following scenarios:
>  * (No issue) the user recovers with the existing krf/drf/crf files.  This 
> works just fine as the krf has reflected the change
>  * (Problem!) If the user compacts and then recovers, the removed entries are 
> now resurrected and appear in the region due to the way compaction operates.  
> It ignores the krf and works on a the existing crf/drf files.  Because the 
> drf does not reflect removed events, the events are rolled forward from the 
> crf.
> Attached is a set oplogs for a single node prior to compaction and a 
> cache.xml (need to fill in the correct location for the diskstore directory) 
> Recovering from this set of oplogs recovers 0 entries for the async event 
> queues.
> If you run offline compaction on the oplogs and recover, there are now 
> entries in the async event queues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Request For Geode Wiki Admin Karma

[Mark Bretl]

Ping.

--Mark

On Thu, Mar 30, 2017 at 3:51 PM, Mark Bretl  wrote:

> Hi,
>
> I would like to follow Kirk's request with one of my own for Admin Karma
> on the Geode Wiki. Username is mbretl.
>
> Best Regards,
>
> --Mark
>

[jira] [Updated] (GEODE-2661) CacheListener gets invoked when an non-existent entry is removed using removeAll

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-2661:
--
Labels: storage_2  (was: )

> CacheListener gets invoked when an non-existent entry is removed using 
> removeAll
> 
>
> Key: GEODE-2661
> URL: https://issues.apache.org/jira/browse/GEODE-2661
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>  Labels: storage_2
>
> When a non-existing entry is removed using removeAll from PartitionedRegion 
> (need to verify this on replicated), the CacheListener's aftrerDestroy 
> callback method gets invoked. The afterDestroy should not be invoked for 
> entry which is not present.
> How to reproduce.
> region.put (k1, v1)
> region.put (k2, v2)
> List keys= Arrays.asList("k1", "k2", "k8");
> region.removeAll(l);
> The afterDestroy call back will be invoked for k8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Edit Permissions for Confluence

[Galen M O'Sullivan]

Hi,

I don't seem to have edit permissions for the Apache Confluence wiki. Would
someone with the proper permissions be willing to give me the proper
permissions, please? Username gosullivan.

Thanks,
Galen

Review Request 58537: GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl dependencies

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58537/
---

Review request for geode, Jinmei Liao, Jared Stewart, and Ken Howe.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

GEODE-2632: refactor code in geode-web-api to reduce GemFireCacheImpl 
dependencies

* extract fetching GemFireCacheImpl to Provider interface/class
* use InternalCache instead of casting to Impl
* delete useless javadocs and comments
* reduce scope of constants, vars and methods
* reorganize imports

I know that CacheProviderImpl still uses GemFireCacheImpl.getExisting, but 
AbstractBaseController is now isolated from that so we can introduce better 
unit testing by providing a mock of InternalCache at a later date. I decided to 
package up the diff for geode-web-api as its own review and get it out of the 
way of the geode-core refactorings.


Diffs
-

  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
 68080a3f27190eafb1541788b4f6bd6c93bd5346 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
 89395425588abef7ff61a34aa30dfbe387342f89 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java
 62ce8609b437d02f43996cbb58d9fbbb33c9344e 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
 e9b61f405c6c64f78551e137e1b98da02f920c4c 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java
 3b08c5fafd85d9513395037e01453a5f1fc94667 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java
 b00a7aa2d5d7439ba7c2d25fdd322448522cdf90 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProvider.java
 PRE-CREATION 
  
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/CacheProviderImpl.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58537/diff/1/


Testing
---

precheckin in progress


Thanks,

Kirk Lund

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/#review172364
---


Ship it!




Ship It!

- Ken Howe


On April 18, 2017, 9:58 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58518/
> ---
> 
> (Updated April 18, 2017, 9:58 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'
> 
> - LocatorServerStarterRule will now always bounce the DUnit VMs in after() to 
> prevent corrupted cached values of `System.getProperty('user.dir')` that 
> refer to a temporary folder which no longer exists.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
>  d47b3435a644f21ea28782c458afc6891577b1f4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
>  c5aaa743935bd0e5bff771213d111cb2f9b929cb 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  34506c4fa803a1121c29d240ad7d7aa6a55dca99 
> 
> 
> Diff: https://reviews.apache.org/r/58518/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Build failed in Jenkins: Geode-nightly #812

[Jared Stewart]

This is GEODE-2795, I have a review request out for a fix.

- Jared 
> On Apr 19, 2017, at 9:52 AM, Apache Jenkins Server 
>  wrote:
> 
> See 
> 
> 
> Changes:
> 
> [huynhja] GEODE-2703: Improve exception message when executing lucene within a
> 
> [ukohlmeyer] GEODE-2653: Fix testRemoveMember and remove FlakyTest. This 
> closes #437
> 
> --
> [...truncated 117.10 KB...]
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>   at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
>   ... 5 more
> 
> 6852 tests completed, 2 failed, 603 skipped
> :geode-core:distributedTest FAILED
> :geode-core:flakyTest
> :geode-core:integrationTest
> :geode-cq:assemble
> :geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
> API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 
> :geode-cq:processTestResources
> :geode-cq:testClasses
> :geode-cq:checkMissedTests
> :geode-cq:spotlessJavaCheck
> :geode-cq:spotlessCheck
> :geode-cq:test
> :geode-cq:check
> :geode-cq:build
> :geode-cq:distributedTest
> :geode-cq:flakyTest
> :geode-cq:integrationTest
> :geode-json:assemble
> :geode-json:compileTestJava UP-TO-DATE
> :geode-json:processTestResources
> :geode-json:testClasses
> :geode-json:checkMissedTests UP-TO-DATE
> :geode-json:spotlessJavaCheck
> :geode-json:spotlessCheck
> :geode-json:test UP-TO-DATE
> :geode-json:check
> :geode-json:build
> :geode-json:distributedTest UP-TO-DATE
> :geode-json:flakyTest UP-TO-DATE
> :geode-json:integrationTest UP-TO-DATE
> :geode-junit:javadoc
> :geode-junit:javadocJar
> :geode-junit:sourcesJar
> :geode-junit:signArchives SKIPPED
> :geode-junit:assemble
> :geode-junit:compileTestJava
> :geode-junit:processTestResources UP-TO-DATE
> :geode-junit:testClasses
> :geode-junit:checkMissedTests
> :geode-junit:spotlessJavaCheck
> :geode-junit:spotlessCheck
> :geode-junit:test
> :geode-junit:check
> :geode-junit:build
> :geode-junit:distributedTest
> :geode-junit:flakyTest
> :geode-junit:integrationTest
> :geode-lucene:assemble
> :geode-lucene:compileTestJavaNote: Some input files use or override a 
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 
> :geode-lucene:processTestResources
> :geode-lucene:testClasses
> :geode-lucene:checkMissedTests
> :geode-lucene:spotlessJavaCheck
> :geode-lucene:spotlessCheck
> :geode-lucene:test
> :geode-lucene:check
> :geode-lucene:build
> :geode-lucene:distributedTest
> :geode-lucene:flakyTest
> :geode-lucene:integrationTest
> :geode-old-client-support:assemble
> :geode-old-client-support:compileTestJava
> :geode-old-client-support:processTestResources UP-TO-DATE
> :geode-old-client-support:testClasses
> :geode-old-client-support:checkMissedTests
> :geode-old-client-support:spotlessJavaCheck
> :geode-old-client-support:spotlessCheck
> :geode-old-client-support:test
> :geode-old-client-support:check
> :geode-old-client-support:build
> :geode-old-client-support:distributedTest
> :geode-old-client-support:flakyTest
> :geode-old-client-support:integrationTest
> :geode-old-versions:javadoc UP-TO-DATE
> :geode-old-versions:javadocJar
> :geode-old-versions:sourcesJar
> :geode-old-versions:signArchives SKIPPED
> :geode-old-versions:assemble
> :geode-old-versions:compileTestJava UP-TO-DATE
> :geode-old-versions:processTestResources UP-TO-DATE
> :geode-old-versions:testClasses UP-TO-DATE
> :geode-old-versions:checkMissedTests UP-TO-DATE
> :geode-old-versions:spotlessJavaCheck
> :geode-old-versions:spotlessCheck
> :geode-old-versions:test UP-TO-DATE
> :geode-old-versions:check
> :geode-old-versions:build
> :geode-old-versions:distributedTest UP-TO-DATE
> :geode-old-versions:flakyTest UP-TO-DATE
> :geode-old-versions:integrationTest UP-TO-DATE
> :geode-pulse:assemble
> :geode-pulse:compileTestJavaNote: 
> 
>  uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: 
> 
>  uses unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 
> :geode-pulse:processTestResources
> :geode-pulse:testClasses
> :geode-pulse:checkMissedTests
> :geode-pulse:spotlessJavaCheck
> :geode-pulse:spotlessCheck
> :geode-pulse:test
> :geode-pulse:check
> :geode-pulse:build
> :geode-pulse:distributedTest
> 

Build failed in Jenkins: Geode-nightly #812

[Apache Jenkins Server]

See 


Changes:

[huynhja] GEODE-2703: Improve exception message when executing lucene within a

[ukohlmeyer] GEODE-2653: Fix testRemoveMember and remove FlakyTest. This closes 
#437

--
[...truncated 117.10 KB...]
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
at 
io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
... 5 more

6852 tests completed, 2 failed, 603 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:flakyTest

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975052#comment-15975052
 ] 

ASF subversion and git services commented on GEODE-2632:


Commit 76c498385995a9aabefd7523f057e32dd9d4a8fa in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=76c4983 ]

GEODE-2632: refactor code to use interfaces instead of impls

* use getInternalDistributedSystem instead of overriding getDistributedSystem
* use InternalCache instead of GemFireCacheImpl
* remove dead code
* remove useless javadocs and comments


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2151) PartitionedRegionLoadModelJUnitTest fails depending on /etc/hosts config

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-2151:

Component/s: messaging

> PartitionedRegionLoadModelJUnitTest fails depending on /etc/hosts config
> 
>
> Key: GEODE-2151
> URL: https://issues.apache.org/jira/browse/GEODE-2151
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Reporter: Galen O'Sullivan
>
> I was getting the following error while running the unit tests:
> {code}
> org.apache.geode.internal.cache.partitioned.PartitionedRegionLoadModelJUnitTest
>  > testRedundancySatisfactionPreferRemoteIp FAILED
> java.lang.AssertionError: 
> expected:<[Create[member=192.168.1.50(41227):3,bucketId=0], 
> Create[member=192.168.1.50(41227):3,bucketId=1], 
> Create[member=192.168.1.50(41227):3,bucketId=2]]> but 
> was:<[Create[member=192.168.1.50(41227):3,bucketId=0], 
> Create[member=192.168.1.50(41227):1,bucketId=1], 
> Create[member=192.168.1.50(41227):3,bucketId=2]]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at 
> org.apache.geode.internal.cache.partitioned.PartitionedRegionLoadModelJUnitTest.testRedundancySatisfactionPreferRemoteIp(PartitionedRegionLoadModelJUnitTest.java:227)
> 2931 tests completed, 1 failed, 10 skipped
> {code}
> My `/etc/hosts` file had the following line:
> {code}
> 127.0.0.1 localhost gosullivan-mbpro
> {code}
> Changing it to this fixed the problem:
> {code}
> 127.0.0.1 localhost
> 255.255.255.255 broadcasthost
> ::1 localhost
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-516) GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction has NullPointerException

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt reassigned GEODE-516:
--

Assignee: (was: Jinmei Liao)

> GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction has 
> NullPointerException
> -
>
> Key: GEODE-516
> URL: https://issues.apache.org/jira/browse/GEODE-516
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: xiaojian zhou
>  Labels: Flaky, ShowDeadlockCommand
>
> revision 0cc9d895b9f4465138d0fa223b0a0cadc1107893
> {noformat}
> java.lang.NullPointerException
>   at 
> com.gemstone.gemfire.distributed.internal.deadlock.DeadlockDetector.prettyFormat(DeadlockDetector.java:151)
>   at 
> com.gemstone.gemfire.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction(GemFireDeadlockDetectorDUnitTest.java:118)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.GeneratedMethodAccessor215.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.GeneratedMethodAccessor214.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-516) GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction has NullPointerException

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-516:
---
Component/s: (was: gfsh)
 messaging

> GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction has 
> NullPointerException
> -
>
> Key: GEODE-516
> URL: https://issues.apache.org/jira/browse/GEODE-516
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: xiaojian zhou
>Assignee: Jinmei Liao
>  Labels: Flaky, ShowDeadlockCommand
>
> revision 0cc9d895b9f4465138d0fa223b0a0cadc1107893
> {noformat}
> java.lang.NullPointerException
>   at 
> com.gemstone.gemfire.distributed.internal.deadlock.DeadlockDetector.prettyFormat(DeadlockDetector.java:151)
>   at 
> com.gemstone.gemfire.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction(GemFireDeadlockDetectorDUnitTest.java:118)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.GeneratedMethodAccessor215.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.GeneratedMethodAccessor214.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-576) CI Failure: GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-576:
---
Component/s: (was: functions)
 messaging

> CI Failure: 
> GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction
> 
>
> Key: GEODE-576
> URL: https://issues.apache.org/jira/browse/GEODE-576
> Project: Geode
>  Issue Type: Bug
>  Components: messaging
>Reporter: Barry Oglesby
>  Labels: CI, Flaky
>
> Geode_develop_DistributedTests
> Private Build #612 (Nov 17, 2015 5:09:11 PM)
> Revision: 90b9a632b9738319fc7a7fddb93b6bef9ff57f7d
> Error Message
> {noformat}
> java.lang.Exception: An exception occured during async invocation
> {noformat}
> Stacktrace
> {noformat}
> java.lang.Exception: An exception occured during async invocation
>   at dunit.AsyncInvocation.getResult(AsyncInvocation.java:195)
>   at 
> com.gemstone.gemfire.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction(GemFireDeadlockDetectorDUnitTest.java:121)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at junit.framework.TestCase.runTest(TestCase.java:176)
>   at junit.framework.TestCase.runBare(TestCase.java:141)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.GeneratedMethodAccessor137.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.GeneratedMethodAccessor136.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: dunit.RMIException: While invoking 
> com.gemstone.gemfire.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest$2.run
>  in VM 0 running on Host rooktwo.gemstone.com with 4 VMs
>   at dunit.VM.invoke(VM.java:369)
>   at dunit.VM$2.run(VM.java:220)
>   at java.lang.Thread.run(Thread.java:745)
>   at dunit.AsyncInvocation.run(AsyncInvocation.java:209)
> Caused by: 
> 

[jira] [Updated] (GEODE-717) CI failure: RedisDistDUnitTest.testConcCreateDestroy

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt updated GEODE-717:
---
Component/s: redis

> CI failure: RedisDistDUnitTest.testConcCreateDestroy
> 
>
> Key: GEODE-717
> URL: https://issues.apache.org/jira/browse/GEODE-717
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Jianxia Chen
>Assignee: Dan Smith
>  Labels: CI, Flaky
>
> Failed 1 times in the last 30 runs. Stability: 96 %
> Error Message
> dunit.RMIException: While invoking 
> com.gemstone.gemfire.redis.RedisDistDUnitTest$1.call in VM 1 running on Host 
> kuwait.gemstone.com with 4 VMs
> Stacktrace
> dunit.RMIException: While invoking 
> com.gemstone.gemfire.redis.RedisDistDUnitTest$1.call in VM 1 running on Host 
> kuwait.gemstone.com with 4 VMs
>   at dunit.VM.invoke(VM.java:369)
>   at dunit.VM.invoke(VM.java:312)
>   at dunit.VM.invoke(VM.java:280)
>   at 
> com.gemstone.gemfire.redis.RedisDistDUnitTest.setUp(RedisDistDUnitTest.java:94)
>   at junit.framework.TestCase.runBare(TestCase.java:139)
>   at junit.framework.TestResult$1.protect(TestResult.java:122)
>   at junit.framework.TestResult.runProtected(TestResult.java:142)
>   at junit.framework.TestResult.run(TestResult.java:125)
>   at junit.framework.TestCase.run(TestCase.java:129)
>   at junit.framework.TestSuite.runTest(TestSuite.java:252)
>   at junit.framework.TestSuite.run(TestSuite.java:247)
>   at 
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.GeneratedMethodAccessor33.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.GeneratedMethodAccessor32.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException: Could not start Server
>   at 
> com.gemstone.gemfire.redis.GemFireRedisServer.start(GemFireRedisServer.java:387)
>   at 
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.startRedisServer(GemFireCacheImpl.java:1243)
>   at 
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.init(GemFireCacheImpl.java:1167)
>   at 
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:774)
>   at 
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:794)
>   at com.gemstone.gemfire.cache.CacheFactory.create(CacheFactory.java:179)
>   at com.gemstone.gemfire.cache.CacheFactory.create(CacheFactory.java:226)
>   at 
> com.gemstone.gemfire.redis.RedisDistDUnitTest$1.call(RedisDistDUnitTest.java:89)
>   at 

[jira] [Created] (GEODE-2800) alter disk-store should allow changes to pre-existing configuration (eg allow-force-compaction)

[Mark Secrist (JIRA)]

Mark Secrist created GEODE-2800:
---

 Summary: alter disk-store should allow changes to pre-existing 
configuration (eg allow-force-compaction)
 Key: GEODE-2800
 URL: https://issues.apache.org/jira/browse/GEODE-2800
 Project: Geode
  Issue Type: Sub-task
Reporter: Mark Secrist


Most of the current options for alter disk-store relate to modifying the disk 
store files, not the configuration. For example, there is no way to change the 
'auto-compact' option or 'allow-force-compact' option. Generally, it appears 
most of the facilities that would change/alter the configuration in the 
cluster.xml aren't available.

Also - I suspect as a result of this, some features should be allowed to be 
made online as opposed to offline. Currently 'alter disk-store' can only be 
performed on offline disk-stores.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58519: GEODE-2796: ClassPathLoader does not blow up with null TCCL

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58519/#review172350
---


Ship it!




Ship It!

- Jinmei Liao


On April 18, 2017, 10:09 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58519/
> ---
> 
> (Updated April 18, 2017, 10:09 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2796: ClassPathLoader does not blow up with null TCCL
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/ClassPathLoader.java 
> 41cce05ce8c1cbf559f365d754e1db1b8bc98b3d 
>   
> geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java
>  c78331895bd33a6b908338af0cec7e60ed56b944 
> 
> 
> Diff: https://reviews.apache.org/r/58519/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[jira] [Commented] (GEODE-2780) Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974879#comment-15974879
 ] 

ASF GitHub Bot commented on GEODE-2780:
---

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/93
  
I thought so too... 


> Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> -
>
> Key: GEODE-2780
> URL: https://issues.apache.org/jira/browse/GEODE-2780
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Amey Barve
>Assignee: Amey Barve
>
> There is typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> ### Required Tools
> * [CMake 4.3](https://cmake.org/) or newer
> There is no version 4.3 of CMake



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #93: GEODE-2780: Fixing typo in client CONTRIBUTING.md fi...

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/93
  
I thought so too... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2798) Gfsh show missing-disk-stores command hangs if cache is initializing

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe resolved GEODE-2798.
-
Resolution: Duplicate

> Gfsh show missing-disk-stores command hangs if cache is initializing
> 
>
> Key: GEODE-2798
> URL: https://issues.apache.org/jira/browse/GEODE-2798
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.0.0-incubating
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>
> To reproduce:
> Use gfsh to create a cluster with a locator and 2 servers, "s0" & "s1".
> Create a disk-store and a PERSISTENT_REPLICATE region.
> Do some region operations.
> Stop "s0".
> Stop "s1".
> Restart "s0" using the existing cluster configuration. It will be in an 
> initializing state, waiting for the disk-store for "s1".
> In Gfsh run 'show missing-disk-stores'
> * The command will hang.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2681) Gfsh show missing-disk-stores command hangs when server is waiting for disk stores

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe reassigned GEODE-2681:
---

Assignee: Kenneth Howe

> Gfsh show missing-disk-stores command hangs when server is waiting for disk 
> stores
> --
>
> Key: GEODE-2681
> URL: https://issues.apache.org/jira/browse/GEODE-2681
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.1.0
>Reporter: Jason Huynh
>Assignee: Kenneth Howe
> Attachments: cache.xml, oplogs1.tar.gz
>
>
> Similar to GEODE-2680:
> When starting up a server with persistent files, the server waits for the 
> other offline members as expected.  
> When trying to show missing disk stores in a different gfsh process, this 
> command also hangs.  It is expected that this process should not be hung
> Attached is a cache xml file and oplogs to reproduce the file.
> Steps to reproduce:
> Configuration:
> 1.) Edit the cache.xml file to point to the appropriate disk store location
> Commands:
> 1.) start locator —-name=locator1
> 2.) start server --name=server1  -—cache-xml-file=cache.xml
> Attempt to start a separate gfsh process and run the following commands:
> 1.) connect
> 2.) show missing-disk-stores



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2780) Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974591#comment-15974591
 ] 

ASF GitHub Bot commented on GEODE-2780:
---

GitHub user ameybarve15 opened a pull request:

https://github.com/apache/geode-native/pull/93

GEODE-2780: Fixing typo in client CONTRIBUTING.md file

Fixing typo in client CONTRIBUTING.md file CMake 4.3 changed to be CMake 
3.4. There is no version 4.3 of CMake.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ameybarve15/geode-native feature/GEODE-2780

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #93


commit a286f1209a9c6d4c26e836a99476281d6e354d6c
Author: Amey Barve 
Date:   2017-04-19T06:06:35Z

GEODE-2780: Fixing typo in client CONTRIBUTING.md file CMake 4.3 changed
to be CMake 3.4. There is no version 4.3 of CMake.




> Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> -
>
> Key: GEODE-2780
> URL: https://issues.apache.org/jira/browse/GEODE-2780
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Amey Barve
>Assignee: Amey Barve
>
> There is typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> ### Required Tools
> * [CMake 4.3](https://cmake.org/) or newer
> There is no version 4.3 of CMake



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)