[jira] [Assigned] (GEODE-2866) Bytes.java is not used in product, Only used in BytesJUnitTest, should be removed

[Prasad Subhash Indulkar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad Subhash Indulkar reassigned GEODE-2866:
--

Assignee: Prasad Subhash Indulkar

> Bytes.java is not used in product, Only used in BytesJUnitTest, should be 
> removed
> -
>
> Key: GEODE-2866
> URL: https://issues.apache.org/jira/browse/GEODE-2866
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Avinash Dongre
>Assignee: Prasad Subhash Indulkar
>
> Bytes.java is not used only used in BytesJUnitTest, should be removed
> FYI [~bschuchardt]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: JIRA assignment privileges.

[Dan Smith]

Hi Prasad,

I've given you permissions, so you should have access now. Just reply to
the list if you have any issues. Thanks for contributing!

-Dan

On Tue, May 9, 2017 at 9:13 PM, Prasad Indulkar 
wrote:

> Hi ,
>
> I am working on GEODE-2866 . Please assign me permissions on JIRA so that I
> can assign the JIRA to myself .
> Apache JIRA id  : indulkarpra...@gmail.com
>
> Thanks
> Prasad
>

[jira] [Commented] (GEODE-2866) Bytes.java is not used in product, Only used in BytesJUnitTest, should be removed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004035#comment-16004035
 ] 

ASF GitHub Bot commented on GEODE-2866:
---

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/497
  
+1 LGTM


> Bytes.java is not used in product, Only used in BytesJUnitTest, should be 
> removed
> -
>
> Key: GEODE-2866
> URL: https://issues.apache.org/jira/browse/GEODE-2866
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Avinash Dongre
>
> Bytes.java is not used only used in BytesJUnitTest, should be removed
> FYI [~bschuchardt]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2907) Remove @Experimental tag from the Lucene module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003800#comment-16003800
 ] 

ASF GitHub Bot commented on GEODE-2907:
---

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115629507
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java
 ---
@@ -39,6 +41,8 @@
* Return score the score of the entry matching the query. Scores are 
computed by Lucene based on
* how closely documents match the query.
*
+   * @return float value representing the score of the document / entry 
obtained as a result of
--- End diff --

Fixed on both the lines


> Remove @Experimental tag from the Lucene module
> ---
>
> Key: GEODE-2907
> URL: https://issues.apache.org/jira/browse/GEODE-2907
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Issue:
> Remove the @Experimental tag from the files in the Lucene module to prepare 
> Apache Geode for the next release.
> Also improve on the javadocs for the interfaces present in the Lucene module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2907) Remove @Experimental tag from the Lucene module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003799#comment-16003799
 ] 

ASF GitHub Bot commented on GEODE-2907:
---

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115629459
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
@@ -37,21 +42,38 @@
  * Results are returned in order of their score with respect to this query.
  * 
  */
-@Experimental
 public interface LuceneQuery {
   /**
* Execute the query and return the region keys that match this query, 
up to the limit specified
* by {@link #getLimit()}.
-   * 
+   *
+   * @return Collection of Apache Geode region keys that satisfy the 
Lucene query.
* @throws LuceneQueryException if the query could not be parsed or 
executed.
+   * @throws CacheClosedException if the cache was closed while the Lucene 
query was being executed.
+   * @throws PrimaryBucketException if the primary bucket was moved from 
the node on which the
--- End diff --




Fixed


> Remove @Experimental tag from the Lucene module
> ---
>
> Key: GEODE-2907
> URL: https://issues.apache.org/jira/browse/GEODE-2907
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Issue:
> Remove the @Experimental tag from the files in the Lucene module to prepare 
> Apache Geode for the next release.
> Also improve on the javadocs for the interfaces present in the Lucene module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115629507
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java
 ---
@@ -39,6 +41,8 @@
* Return score the score of the entry matching the query. Scores are 
computed by Lucene based on
* how closely documents match the query.
*
+   * @return float value representing the score of the document / entry 
obtained as a result of
--- End diff --

Fixed on both the lines


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115629448
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java ---
@@ -19,39 +19,62 @@
 
 import org.apache.lucene.analysis.Analyzer;
 
-import org.apache.geode.annotations.Experimental;
-
 
 /**
  * 
- * An Lucene index is built over the data stored in a GemFire Region.
+ * LuceneIndex represents the Lucene index created over the data stored in 
Apache Geode regions. The
+ * Lucene indexes are maintained automatically by Apache Geode whenever 
the entries are updated in
+ * the associated regions. Lucene Indexes are created using {@link 
LuceneService#createIndexFactory}
+ * by specifying the Lucene index name, the region associated with the 
Lucene index, the fields on
--- End diff --

Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115629459
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
@@ -37,21 +42,38 @@
  * Results are returned in order of their score with respect to this query.
  * 
  */
-@Experimental
 public interface LuceneQuery {
   /**
* Execute the query and return the region keys that match this query, 
up to the limit specified
* by {@link #getLimit()}.
-   * 
+   *
+   * @return Collection of Apache Geode region keys that satisfy the 
Lucene query.
* @throws LuceneQueryException if the query could not be parsed or 
executed.
+   * @throws CacheClosedException if the cache was closed while the Lucene 
query was being executed.
+   * @throws PrimaryBucketException if the primary bucket was moved from 
the node on which the
--- End diff --




Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: ASF Board Report for Geode - Initial Reminder for May 2017

[Dan Smith]

+1 - Thanks for taking this on Anthony!

-Dan

On Tue, May 9, 2017 at 4:47 PM, Anthony Baker  wrote:

>
> Here’s a rough draft, please review and comment:
>
> (@Mark, I noticed that issues@geode has 0 emails.  Is that a
> configuration issue?)
>
> ## Description:
>  - Apache Geode provides a database-like consistency model, reliable
> transaction processing and a shared-nothing architecture to maintain very
> low latency performance with high concurrency processing.
>
> ## Issues:
>  - There are no issues requiring board attention at this time.
>
> ## Activity:
>  - The Geode PMC issued CVE-2017-5649 and released v1.1.1 to address this
> vulnerability.
>  - The geode-examples have been improved significantly to make it easier
> to add new examples and provide a better learning experience.
>  - The geode-native source and documentation has undergone significant
> changes to prepare it for inclusion in a Geode release.
>  - The community has discussed a number of new proposals on
> modularization, binary protocol, redis adapter, class loading, and
> finer-grained security.
>
> ## Health report:
>  - We’re continuing to work on attracting new contributors and making it
> easier to participate in the community.
>  - Mailing list activity is healthy and discussions are productive.
>  - Work is progressing towards the next Geode release, 1.2.0.
>
> ## PMC changes:
>
>  - Currently 35 PMC members.
>  - New PMC members:
> - Jacob Barrett was added to the PMC on Mon May 8 2017
> - Ernest Burghardt was added to the PMC on Mon Mar 20 2017
> - Jared Stewart was added to the PMC on Sun Feb 12 2017
>
> ## Committer base changes:
>
>  - Currently 79 committers.
>  - Ernest Burghardt was added as a committer on Tue Mar 21 2017
>
> ## Releases:
>
> - 1.1.1 was released on Sat Apr 1 2017
> - 1.1.0 was released on Wed Feb 15 2017
>
> ## Mailing list activity:
>
>  - Mailing lists remain active and we’re seeing continued growth in
> subscriber counts.  The dev@geode list in particular is highly active.
>
>  - dev@geode.apache.org:
> - 159 subscribers (up 3 in the last 3 months):
> - 7550 emails sent to list (4317 in previous quarter)
>
>  - iss...@geode.apache.org:
> - 55 subscribers (down -1 in the last 3 months):
> - 0 emails sent to list (1042 in previous quarter)
>
>  - u...@geode.apache.org:
> - 218 subscribers (up 12 in the last 3 months):
> - 215 emails sent to list (305 in previous quarter)
>
> ## JIRA activity:
>
>  - 461 JIRA tickets created in the last 3 months
>  - 327 JIRA tickets closed/resolved in the last 3 months
>
> Anthony
>
> > On May 8, 2017, at 9:14 AM, Mark Bretl  wrote:
> >
> > We need to submit a report by Friday and I have not seen any takers to
> > creating the report. If there are no volunteers, I will create a draft on
> > Wednesday.
> >
> > --Mark
> >
> > On Thu, Apr 27, 2017 at 12:48 PM, Mark Bretl  wrote:
> >
> >> Hi Everyone,
> >>
> >> Amazing how three months goes by so fast! We are approaching six months
> >> since our TLP graduation and its time for another board report.
> >>
> >> Do we have any volunteers to create a draft? No need to be a PMC member
> >> either, anyone can be involved with writing the report. There is a
> template
> >> on the Geode wiki [1].
> >>
> >> Best regards,
> >>
> >> --Mark
> >>
> >> [1]: https://cwiki.apache.org/confluence/display/GEODE/ASF+
> >> Board+Report+Template
> >>
> >>
> >> -- Forwarded message --
> >> From: Brett Porter 
> >> Date: Wed, Apr 26, 2017 at 6:16 AM
> >> Subject: ASF Board Report for Geode - Initial Reminder for May 2017
> >> To: Mark Bretl 
> >> Cc: priv...@geode.apache.org
> >>
> >>
> >> This email was sent on behalf of the ASF Board.  It is an initial
> reminder
> >> to
> >> give you plenty of time to prepare the report.
> >>
> >> According to board records, you are listed as the chair of a committee
> >> that is
> >> due to submit a report this month. [1] [2]
> >>
> >> The meeting is scheduled for Wed, 17 May 2017 at 10:30 PDT and the
> >> deadline for
> >> submitting your report is 1 full week prior to that (Wed May 10th)!
> >>
> >> Meeting times in other time zones:
> >>
> >>  https://timeanddate.com/s/38ta
> >>
> >> Please submit your report with sufficient time to allow the board
> members
> >> to review and digest. Again, the very latest you should submit your
> report
> >> is 1 full week (7days) prior to the board meeting (Wed May 10th).
> >>
> >> If you feel that an error has been made, please consult [1] and if there
> >> is still an issue then contact the board directly.
> >>
> >> As always, PMC chairs are welcome to attend the board meeting.
> >>
> >> Thanks,
> >> The ASF Board
> >>
> >> [1] - https://svn.apache.org/repos/private/committers/board/commit
> >> tee-info.txt
> >> [2] - https://svn.apache.org/repos/private/committers/board/
> calendar.txt
> >> [3] - 

Re: ASF Board Report for Geode - Initial Reminder for May 2017

[Anthony Baker]

Here’s a rough draft, please review and comment:

(@Mark, I noticed that issues@geode has 0 emails.  Is that a configuration 
issue?)

## Description: 
 - Apache Geode provides a database-like consistency model, reliable 
transaction processing and a shared-nothing architecture to maintain very low 
latency performance with high concurrency processing.
   
## Issues: 
 - There are no issues requiring board attention at this time.
   
## Activity: 
 - The Geode PMC issued CVE-2017-5649 and released v1.1.1 to address this 
vulnerability.
 - The geode-examples have been improved significantly to make it easier to add 
new examples and provide a better learning experience.
 - The geode-native source and documentation has undergone significant changes 
to prepare it for inclusion in a Geode release.
 - The community has discussed a number of new proposals on modularization, 
binary protocol, redis adapter, class loading, and finer-grained security.

## Health report: 
 - We’re continuing to work on attracting new contributors and making it easier 
to participate in the community.
 - Mailing list activity is healthy and discussions are productive.
 - Work is progressing towards the next Geode release, 1.2.0.
   
## PMC changes: 
   
 - Currently 35 PMC members. 
 - New PMC members: 
- Jacob Barrett was added to the PMC on Mon May 8 2017
- Ernest Burghardt was added to the PMC on Mon Mar 20 2017 
- Jared Stewart was added to the PMC on Sun Feb 12 2017 

## Committer base changes: 
   
 - Currently 79 committers. 
 - Ernest Burghardt was added as a committer on Tue Mar 21 2017 
   
## Releases: 
   
- 1.1.1 was released on Sat Apr 1 2017
- 1.1.0 was released on Wed Feb 15 2017 
   
## Mailing list activity: 
   
 - Mailing lists remain active and we’re seeing continued growth in subscriber 
counts.  The dev@geode list in particular is highly active.
   
 - dev@geode.apache.org:  
- 159 subscribers (up 3 in the last 3 months): 
- 7550 emails sent to list (4317 in previous quarter) 
   
 - iss...@geode.apache.org:  
- 55 subscribers (down -1 in the last 3 months): 
- 0 emails sent to list (1042 in previous quarter) 
   
 - u...@geode.apache.org:  
- 218 subscribers (up 12 in the last 3 months): 
- 215 emails sent to list (305 in previous quarter) 
   
## JIRA activity: 
   
 - 461 JIRA tickets created in the last 3 months 
 - 327 JIRA tickets closed/resolved in the last 3 months 
  
Anthony

> On May 8, 2017, at 9:14 AM, Mark Bretl  wrote:
> 
> We need to submit a report by Friday and I have not seen any takers to
> creating the report. If there are no volunteers, I will create a draft on
> Wednesday.
> 
> --Mark
> 
> On Thu, Apr 27, 2017 at 12:48 PM, Mark Bretl  wrote:
> 
>> Hi Everyone,
>> 
>> Amazing how three months goes by so fast! We are approaching six months
>> since our TLP graduation and its time for another board report.
>> 
>> Do we have any volunteers to create a draft? No need to be a PMC member
>> either, anyone can be involved with writing the report. There is a template
>> on the Geode wiki [1].
>> 
>> Best regards,
>> 
>> --Mark
>> 
>> [1]: https://cwiki.apache.org/confluence/display/GEODE/ASF+
>> Board+Report+Template
>> 
>> 
>> -- Forwarded message --
>> From: Brett Porter 
>> Date: Wed, Apr 26, 2017 at 6:16 AM
>> Subject: ASF Board Report for Geode - Initial Reminder for May 2017
>> To: Mark Bretl 
>> Cc: priv...@geode.apache.org
>> 
>> 
>> This email was sent on behalf of the ASF Board.  It is an initial reminder
>> to
>> give you plenty of time to prepare the report.
>> 
>> According to board records, you are listed as the chair of a committee
>> that is
>> due to submit a report this month. [1] [2]
>> 
>> The meeting is scheduled for Wed, 17 May 2017 at 10:30 PDT and the
>> deadline for
>> submitting your report is 1 full week prior to that (Wed May 10th)!
>> 
>> Meeting times in other time zones:
>> 
>>  https://timeanddate.com/s/38ta
>> 
>> Please submit your report with sufficient time to allow the board members
>> to review and digest. Again, the very latest you should submit your report
>> is 1 full week (7days) prior to the board meeting (Wed May 10th).
>> 
>> If you feel that an error has been made, please consult [1] and if there
>> is still an issue then contact the board directly.
>> 
>> As always, PMC chairs are welcome to attend the board meeting.
>> 
>> Thanks,
>> The ASF Board
>> 
>> [1] - https://svn.apache.org/repos/private/committers/board/commit
>> tee-info.txt
>> [2] - https://svn.apache.org/repos/private/committers/board/calendar.txt
>> [3] - https://svn.apache.org/repos/private/committers/board/templates
>> [4] - https://reporter.apache.org/
>> 
>> 

[jira] [Commented] (GEODE-2907) Remove @Experimental tag from the Lucene module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003765#comment-16003765
 ] 

ASF GitHub Bot commented on GEODE-2907:
---

Github user ladyVader commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115627251
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java ---
@@ -19,39 +19,62 @@
 
 import org.apache.lucene.analysis.Analyzer;
 
-import org.apache.geode.annotations.Experimental;
-
 
 /**
  * 
- * An Lucene index is built over the data stored in a GemFire Region.
+ * LuceneIndex represents the Lucene index created over the data stored in 
Apache Geode regions. The
+ * Lucene indexes are maintained automatically by Apache Geode whenever 
the entries are updated in
+ * the associated regions. Lucene Indexes are created using {@link 
LuceneService#createIndexFactory}
+ * by specifying the Lucene index name, the region associated with the 
Lucene index, the fields on
--- End diff --

maybe just add the word "and" before the last phrase here ... "and the 
fields on ..."


> Remove @Experimental tag from the Lucene module
> ---
>
> Key: GEODE-2907
> URL: https://issues.apache.org/jira/browse/GEODE-2907
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Issue:
> Remove the @Experimental tag from the files in the Lucene module to prepare 
> Apache Geode for the next release.
> Also improve on the javadocs for the interfaces present in the Lucene module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[ladyVader]

Github user ladyVader commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115627251
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java ---
@@ -19,39 +19,62 @@
 
 import org.apache.lucene.analysis.Analyzer;
 
-import org.apache.geode.annotations.Experimental;
-
 
 /**
  * 
- * An Lucene index is built over the data stored in a GemFire Region.
+ * LuceneIndex represents the Lucene index created over the data stored in 
Apache Geode regions. The
+ * Lucene indexes are maintained automatically by Apache Geode whenever 
the entries are updated in
+ * the associated regions. Lucene Indexes are created using {@link 
LuceneService#createIndexFactory}
+ * by specifying the Lucene index name, the region associated with the 
Lucene index, the fields on
--- End diff --

maybe just add the word "and" before the last phrase here ... "and the 
fields on ..."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2907) Remove @Experimental tag from the Lucene module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003761#comment-16003761
 ] 

ASF GitHub Bot commented on GEODE-2907:
---

Github user ladyVader commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115626998
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java
 ---
@@ -39,6 +41,8 @@
* Return score the score of the entry matching the query. Scores are 
computed by Lucene based on
* how closely documents match the query.
*
+   * @return float value representing the score of the document / entry 
obtained as a result of
--- End diff --

So, we should probably use entry (instead of document) in line 42 as well.


> Remove @Experimental tag from the Lucene module
> ---
>
> Key: GEODE-2907
> URL: https://issues.apache.org/jira/browse/GEODE-2907
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Issue:
> Remove the @Experimental tag from the files in the Lucene module to prepare 
> Apache Geode for the next release.
> Also improve on the javadocs for the interfaces present in the Lucene module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[ladyVader]

Github user ladyVader commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115626998
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java
 ---
@@ -39,6 +41,8 @@
* Return score the score of the entry matching the query. Scores are 
computed by Lucene based on
* how closely documents match the query.
*
+   * @return float value representing the score of the document / entry 
obtained as a result of
--- End diff --

So, we should probably use entry (instead of document) in line 42 as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 59035: GEODE-2883: Fix GFSH gc heap size output

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59035/
---

(Updated May 9, 2017, 11:24 p.m.)


Review request for geode, Barry Oglesby, Jinmei Liao, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Restructured code to avoid changing Sanctioned Serializables


Repository: geode


Description
---

GEODE-2883: Fix GFSH gc heap size output


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GarbageCollectionFunction.java
 354d353 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/BytesToString.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/BytesToStringTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59035/diff/4/

Changes: https://reviews.apache.org/r/59035/diff/3-4/


Testing
---

Precheckin started (still running)


Thanks,

Jared Stewart

[jira] [Commented] (GEODE-2907) Remove @Experimental tag from the Lucene module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003737#comment-16003737
 ] 

ASF GitHub Bot commented on GEODE-2907:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115623920
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
@@ -37,21 +42,38 @@
  * Results are returned in order of their score with respect to this query.
  * 
  */
-@Experimental
 public interface LuceneQuery {
   /**
* Execute the query and return the region keys that match this query, 
up to the limit specified
* by {@link #getLimit()}.
-   * 
+   *
+   * @return Collection of Apache Geode region keys that satisfy the 
Lucene query.
* @throws LuceneQueryException if the query could not be parsed or 
executed.
+   * @throws CacheClosedException if the cache was closed while the Lucene 
query was being executed.
+   * @throws PrimaryBucketException if the primary bucket was moved from 
the node on which the
--- End diff --

PrimaryBucketException is an internal exception, which should not be part 
of the API. Do we actually throw this exception from this method? It seems like 
we should be retrying in any case.


> Remove @Experimental tag from the Lucene module
> ---
>
> Key: GEODE-2907
> URL: https://issues.apache.org/jira/browse/GEODE-2907
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Issue:
> Remove the @Experimental tag from the files in the Lucene module to prepare 
> Apache Geode for the next release.
> Also improve on the javadocs for the interfaces present in the Lucene module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115624028
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
@@ -60,7 +82,16 @@
* the limit specified by {@link #getLimit()} A {@link 
LuceneResultStruct} contains the region
* key, value, and a score for that entry.
*
+   * @return a List of LuceneResultStruct that match the Lucene query
* @throws LuceneQueryException if the query could not be parsed or 
executed.
+   * @throws CacheClosedException if the cache was closed while the Lucene 
query was being executed.
+   * @throws PrimaryBucketException if the primary bucket was moved from 
the node on which the
--- End diff --

Another PrimaryBucketException


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2907) Remove @Experimental tag from the Lucene module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003738#comment-16003738
 ] 

ASF GitHub Bot commented on GEODE-2907:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115624028
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
@@ -60,7 +82,16 @@
* the limit specified by {@link #getLimit()} A {@link 
LuceneResultStruct} contains the region
* key, value, and a score for that entry.
*
+   * @return a List of LuceneResultStruct that match the Lucene query
* @throws LuceneQueryException if the query could not be parsed or 
executed.
+   * @throws CacheClosedException if the cache was closed while the Lucene 
query was being executed.
+   * @throws PrimaryBucketException if the primary bucket was moved from 
the node on which the
--- End diff --

Another PrimaryBucketException


> Remove @Experimental tag from the Lucene module
> ---
>
> Key: GEODE-2907
> URL: https://issues.apache.org/jira/browse/GEODE-2907
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Issue:
> Remove the @Experimental tag from the files in the Lucene module to prepare 
> Apache Geode for the next release.
> Also improve on the javadocs for the interfaces present in the Lucene module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115623920
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
@@ -37,21 +42,38 @@
  * Results are returned in order of their score with respect to this query.
  * 
  */
-@Experimental
 public interface LuceneQuery {
   /**
* Execute the query and return the region keys that match this query, 
up to the limit specified
* by {@link #getLimit()}.
-   * 
+   *
+   * @return Collection of Apache Geode region keys that satisfy the 
Lucene query.
* @throws LuceneQueryException if the query could not be parsed or 
executed.
+   * @throws CacheClosedException if the cache was closed while the Lucene 
query was being executed.
+   * @throws PrimaryBucketException if the primary bucket was moved from 
the node on which the
--- End diff --

PrimaryBucketException is an internal exception, which should not be part 
of the API. Do we actually throw this exception from this method? It seems like 
we should be retrying in any case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/503

GEODE-2907: Removed @Experimental tag from the Lucene module

* Removed the @experimental tag fromt the files in Lucene module.
* Improve on the javadocs for the interfaces present in the Lucene 
module.

This is the first draft for the javadocs improvements as a part of the task 
to remove the @Experimatal tags present in the Lucene Module.

Potential reviewers
@upthewaterspout @jhuynh1 @boglesby @ladyVader @gesterzhou 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2907

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #503


commit daf89a331ce59c87ca0d1c3c414bf76f78c1edfb
Author: nabarun 
Date:   2017-05-09T22:15:59Z

GEODE-2907: Removed @Experimental tag from the Lucene module

* Removed the @experimental tag fromt the files in Lucene module.
* Improve on the javadocs for the interfaces present in the Lucene 
module.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2896) ClassCastException in GMSMembershipManagerJUnitTest

[Bruce Schuchardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003706#comment-16003706
 ] 

Bruce Schuchardt commented on GEODE-2896:
-

HighPriorityAckedMessage should ignore the result of 
ds.getDistributionManager() if it's not an instance of DistributionManager.

> ClassCastException in GMSMembershipManagerJUnitTest
> ---
>
> Key: GEODE-2896
> URL: https://issues.apache.org/jira/browse/GEODE-2896
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: nabarun
>Assignee: nabarun
>
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSendFailureDueToForcedDisconnect FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testDirectChannelSendFailureDueToForcedDisconnect(GMSMembershipManagerJUnitTest.java:343)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testStartupEvents FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testStartupEvents(GMSMembershipManagerJUnitTest.java:219)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testSendToEmptyListIsRejected FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testSendToEmptyListIsRejected(GMSMembershipManagerJUnitTest.java:177)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSendAllRecipients FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testDirectChannelSendAllRecipients(GMSMembershipManagerJUnitTest.java:331)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSend FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testDirectChannelSend(GMSMembershipManagerJUnitTest.java:281)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSendFailureToOneRecipient FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testDirectChannelSendFailureToOneRecipient(GMSMembershipManagerJUnitTest.java:294)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSendFailureToAll FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testDirectChannelSendFailureToAll(GMSMembershipManagerJUnitTest.java:313)
> 

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #549 was SUCCESSFUL (with 1847 tests). Change made by John Blum and Oliver Gierke.

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #549 was successful.
---
Scheduled with changes by John Blum, Oliver Gierke.
1849 tests in total.

https://build.spring.io/browse/SGF-NAG-549/




--
Code Changes
--
John Blum (45da6ce9183b19bd1f3acc216197eafbb1891c8b):

>SGF-606 - Adapt to Spring Data Commons RepositoryConfigurationExtension API 
>changes.
>(cherry picked from commit 08fa89080aeae6e3d714fe849f9ef96625f65356)
>Signed-off-by: John Blum 

John Blum (9f7de3f39ec46b945460444516da56af9895d248):

>SGF-611 - Handle possible ClassLoader errors (NPE) related to logging detailed 
>information about Apache Geode on cache initialization.

John Blum (1a3909e9480cd275013770e646adfc21f969b179):

>SGF-609 - Adapt to changes in the Spring Data Commons API.



--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 58937: GEODE-2865 data loss in initial-image replication with multicas

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58937/#review174387
---


Ship it!




Ship It!

- Udo Kohlmeyer


On May 5, 2017, 4:57 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58937/
> ---
> 
> (Updated May 5, 2017, 4:57 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-2865
> https://issues.apache.org/jira/browse/GEODE-2865
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The state-flush algorithm relies on MembershipManager.waitForMessageState() 
> to ensure that all operations have been received and applied to the cache 
> prior to state replication starting.  For multicast there was a flaw in the 
> algorithm caused by two things: 1) cache operations were being sent 
> out-of-band, allowing them to be processed out of order with the state-flush 
> message, and 2) JGroupsMessenger was only waiting for the messages to be 
> dispatched by NAKACK2, which isn't necessarily the same as being dispatched 
> to the DistributionManager Executor that processes the message.
> 
> Cache operation messages are now sent in-band.
> JGroupsMessenger now tracks NAKACK2 (multicast) sequence numbers of messages 
> dispatched to the DistributionManager and this is used in 
> waitForMessageState() to make sure the messages have been queued.
> If multicast is enabled we now flush the serial executor to in 
> waitForMessageState() to make sure that all messages queued in it have been 
> applied to the region.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
>  e99eff2be344d54da67c257a0bfa73ad8268c4c6 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
>  8ae66d0b6839cfbd46b479d896104f54fd11a68d 
>   
> geode-core/src/test/java/org/apache/geode/distributed/DistributedSystemDUnitTest.java
>  9a64f531431e714916765d6d6c741841ef719fb8 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java
>  307b5948c02befee61d61b628c38b8b8b8693c4d 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java
>  7e798c8358aaec070d3dd9d04c2486bd33a21d9e 
> 
> 
> Diff: https://reviews.apache.org/r/58937/diff/2/
> 
> 
> Testing
> ---
> 
> passes precheckin and modified unit tests
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode-examples issue #4: Updating and simplifying examples

[davebarnes97]

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-examples/pull/4
  
+1
[Errata: Quoteloader, Bradbury, "...as **a** writer."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003670#comment-16003670
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit bbf016376b76c501f3051521ac46b995f6795781 in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=bbf0163 ]

GEODE-2900: spotlessApply


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2907) Remove @Experimental tag from the Lucene module

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun updated GEODE-2907:
---
Description: 
Issue:
Remove the @Experimental tag from the files in the Lucene module to prepare 
Apache Geode for the next release.

Also improve on the javadocs for the interfaces present in the Lucene module.



  was:
Issue:
Remove the @Experimental tag from the files in the Lucene module to prepare 
Apache Geode for the next release.




> Remove @Experimental tag from the Lucene module
> ---
>
> Key: GEODE-2907
> URL: https://issues.apache.org/jira/browse/GEODE-2907
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Issue:
> Remove the @Experimental tag from the files in the Lucene module to prepare 
> Apache Geode for the next release.
> Also improve on the javadocs for the interfaces present in the Lucene module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-2900:
---
Description: 
In this scenario when peek() is called from BucketRegionQueue, a side effect is 
that the key is removed from the eventSeqNumQueue and an event is placed into 
the peekedEvents list.

If there is failure dispatching the event, we add the peekedEvents list to a 
new peekedEvents list.  Before doing so, we remove any events that we are not 
primary for.  Now the event is not in the eventSeqNumQueue or the peekedEvents 
list

If we now become primary (before the other node could dispatch this event), and 
because we do not have that event in the eventSeqNumQueue or the peekedEvents, 
it gets "stuck."

This also affects the Lucene implementation.  An stuck event can mean 
incorrectly indexed data or data inconsistencies


  was:
In this scenario when peek() is called from BucketRegionQueue, a side effect is 
that the key is removed from the eventSeqNumQueue and an event is placed into 
the peekedEvents list.

If there is failure dispatching the event, we add the peekedEvents list to a 
new peekedEvents list.  Before doing so, we remove any events that we are not 
primary for.  Now the event is not in the eventSeqNumQueue or the peekedEvents 
list

If we now become primary (before the other node could dispatch this event), and 
because we do not have that event in the eventSeqNumQueue or the peekedEvents, 
it gets "stuck."


Component/s: lucene

> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2907) Remove @Experimental tag from the Lucene module

[nabarun (JIRA)]

nabarun created GEODE-2907:
--

 Summary: Remove @Experimental tag from the Lucene module
 Key: GEODE-2907
 URL: https://issues.apache.org/jira/browse/GEODE-2907
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: nabarun


Issue:
Remove the @Experimental tag from the files in the Lucene module to prepare 
Apache Geode for the next release.





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2907) Remove @Experimental tag from the Lucene module

[nabarun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

nabarun reassigned GEODE-2907:
--

Assignee: nabarun

> Remove @Experimental tag from the Lucene module
> ---
>
> Key: GEODE-2907
> URL: https://issues.apache.org/jira/browse/GEODE-2907
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>Assignee: nabarun
>
> Issue:
> Remove the @Experimental tag from the files in the Lucene module to prepare 
> Apache Geode for the next release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2895) CI failure: OldFreeListOffHeapRegionJUnitTest.testLocalPersistent

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-2895:
--
Description: 
FIX: wait up to 60 seconds to check ma.getUsedMemory() 
 

{noformat}
org.apache.geode.internal.offheap.OldFreeListOffHeapRegionJUnitTest > 
testLocalPersistent FAILED
java.lang.AssertionError: expected:<0> but was:<24>

java.lang.AssertionError: expected:<0> but was:<24>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:451)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:211)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.testLocalPersistent(OffHeapRegionBase.java:618)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at 
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 

[jira] [Updated] (GEODE-2895) CI failure: OldFreeListOffHeapRegionJUnitTest.testLocalPersistent

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-2895:
--
Description: 
FIX: 
replaced assertEquals(0, ma.getUsedMemory()); 
for:
Awaitility.await().atMost(60, TimeUnit.SECONDS).until(() -> assertEquals(0, 
ma.getUsedMemory()));

{noformat}
org.apache.geode.internal.offheap.OldFreeListOffHeapRegionJUnitTest > 
testLocalPersistent FAILED
java.lang.AssertionError: expected:<0> but was:<24>

java.lang.AssertionError: expected:<0> but was:<24>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:451)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:211)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.testLocalPersistent(OffHeapRegionBase.java:618)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at 
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 

[jira] [Updated] (GEODE-2895) CI failure: OldFreeListOffHeapRegionJUnitTest.testLocalPersistent

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-2895:
--
Description: 
FIXED: updated Awaitility.await().atMost(60, TimeUnit.SECONDS).until(() -> 
assertEquals(0, ma.getUsedMemory()));

{noformat}
org.apache.geode.internal.offheap.OldFreeListOffHeapRegionJUnitTest > 
testLocalPersistent FAILED
java.lang.AssertionError: expected:<0> but was:<24>

java.lang.AssertionError: expected:<0> but was:<24>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:451)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:211)
at 
org.apache.geode.internal.offheap.OffHeapRegionBase.testLocalPersistent(OffHeapRegionBase.java:618)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at 
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003610#comment-16003610
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit 5b4e4330678f9eb49df2e647a9dd0a0f015d8047 in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5b4e433 ]

GEODE-2900: Renamed method and changed some code comments


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2906) Users need a dynamic way to co-locate entries on partitioned regions

[Fred Krone (JIRA)]

Fred Krone created GEODE-2906:
-

 Summary: Users need a dynamic way to co-locate entries on 
partitioned regions
 Key: GEODE-2906
 URL: https://issues.apache.org/jira/browse/GEODE-2906
 Project: Geode
  Issue Type: Improvement
  Components: regions
Reporter: Fred Krone


Implement a dynamic PartitionResolver that takes a String key and uses a '.' as 
the separator between the actual key and the partitioning key, returning the 
partitioning key when called. 

The actual key would be the entire string, the partitioning key would be 
everything after the last '.' unless there are no dots in which case it is the 
whole String (which is the default without a PartitionResolver).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2903) FreeListOffHeapRegionJUnitTest testLocalPersistentCompressed failing intermittently

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-2903.
-
   Resolution: Duplicate
Fix Version/s: 1.2.0

> FreeListOffHeapRegionJUnitTest testLocalPersistentCompressed failing 
> intermittently
> ---
>
> Key: GEODE-2903
> URL: https://issues.apache.org/jira/browse/GEODE-2903
> Project: Geode
>  Issue Type: Bug
>  Components: offheap
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
> Fix For: 1.2.0
>
>
> org.apache.geode.internal.offheap.FreeListOffHeapRegionJUnitTest > 
> testLocalPersistentCompressed FAILED
> java.lang.AssertionError: expected:<0> but was:<24>
> org.apache.geode.internal.offheap.OldFreeListOffHeapRegionJUnitTest > 
> testLocalPersistentCompressed FAILED
> java.lang.AssertionError: expected:<0> but was:<48>



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2903) FreeListOffHeapRegionJUnitTest testLocalPersistentCompressed failing intermittently

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-2903:
---

Assignee: Darrel Schneider

> FreeListOffHeapRegionJUnitTest testLocalPersistentCompressed failing 
> intermittently
> ---
>
> Key: GEODE-2903
> URL: https://issues.apache.org/jira/browse/GEODE-2903
> Project: Geode
>  Issue Type: Bug
>  Components: offheap
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>
> org.apache.geode.internal.offheap.FreeListOffHeapRegionJUnitTest > 
> testLocalPersistentCompressed FAILED
> java.lang.AssertionError: expected:<0> but was:<24>
> org.apache.geode.internal.offheap.OldFreeListOffHeapRegionJUnitTest > 
> testLocalPersistentCompressed FAILED
> java.lang.AssertionError: expected:<0> but was:<48>



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2902) OffHeapLRURecoveryRegressionTest recoveringTooMuchDataDoesNotRunOutOfOffHeapMemory fails intermittently

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-2902:
---

Assignee: Darrel Schneider

> OffHeapLRURecoveryRegressionTest 
> recoveringTooMuchDataDoesNotRunOutOfOffHeapMemory fails intermittently
> ---
>
> Key: GEODE-2902
> URL: https://issues.apache.org/jira/browse/GEODE-2902
> Project: Geode
>  Issue Type: Bug
>  Components: offheap
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>
> org.apache.geode.internal.offheap.OffHeapLRURecoveryRegressionTest > 
> recoveringTooMuchDataDoesNotRunOutOfOffHeapMemory FAILED
> java.lang.AssertionError: expected:<10> but was:<11>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.offheap.OffHeapLRURecoveryRegressionTest.recoveringTooMuchDataDoesNotRunOutOfOffHeapMemory(OffHeapLRURecoveryRegressionTest.java:74)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2895) CI failure: OldFreeListOffHeapRegionJUnitTest.testLocalPersistent

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-2895.
-
   Resolution: Fixed
Fix Version/s: 1.2.0

> CI failure: OldFreeListOffHeapRegionJUnitTest.testLocalPersistent
> -
>
> Key: GEODE-2895
> URL: https://issues.apache.org/jira/browse/GEODE-2895
> Project: Geode
>  Issue Type: Bug
>  Components: offheap
>Reporter: Lynn Gallinat
>Assignee: Darrel Schneider
> Fix For: 1.2.0
>
>
> {noformat}
> org.apache.geode.internal.offheap.OldFreeListOffHeapRegionJUnitTest > 
> testLocalPersistent FAILED
> java.lang.AssertionError: expected:<0> but was:<24>
> java.lang.AssertionError: expected:<0> but was:<24>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:645)
>   at org.junit.Assert.assertEquals(Assert.java:631)
>   at 
> org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:451)
>   at 
> org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:211)
>   at 
> org.apache.geode.internal.offheap.OffHeapRegionBase.testLocalPersistent(OffHeapRegionBase.java:618)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Assigned] (GEODE-2895) CI failure: OldFreeListOffHeapRegionJUnitTest.testLocalPersistent

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-2895:
---

Assignee: Darrel Schneider

> CI failure: OldFreeListOffHeapRegionJUnitTest.testLocalPersistent
> -
>
> Key: GEODE-2895
> URL: https://issues.apache.org/jira/browse/GEODE-2895
> Project: Geode
>  Issue Type: Bug
>  Components: offheap
>Reporter: Lynn Gallinat
>Assignee: Darrel Schneider
>
> {noformat}
> org.apache.geode.internal.offheap.OldFreeListOffHeapRegionJUnitTest > 
> testLocalPersistent FAILED
> java.lang.AssertionError: expected:<0> but was:<24>
> java.lang.AssertionError: expected:<0> but was:<24>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:645)
>   at org.junit.Assert.assertEquals(Assert.java:631)
>   at 
> org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:451)
>   at 
> org.apache.geode.internal.offheap.OffHeapRegionBase.doRegionTest(OffHeapRegionBase.java:211)
>   at 
> org.apache.geode.internal.offheap.OffHeapRegionBase.testLocalPersistent(OffHeapRegionBase.java:618)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Resolved] (GEODE-2889) Generic session module should touch sessions rather than recreate the native session

[Dan Smith (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith resolved GEODE-2889.
--
   Resolution: Fixed
 Assignee: Dan Smith
Fix Version/s: 1.2.0

> Generic session module should touch sessions rather than recreate the native 
> session
> 
>
> Key: GEODE-2889
> URL: https://issues.apache.org/jira/browse/GEODE-2889
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
> The session module for generic application servers is doing some magic to try 
> to recreate native sessions if they have been idle for too long. This can 
> cause failures if the container expires a session concurrently, because the 
> expiration can happen after we have checked if the session is valid, but 
> before we can read the session creation time.
> {noformat}
> /*
>  * This is a massively gross hack. Currently, there is no way to 
> actually update the last
>  * accessed time for a session, so what we do here is once we're into 
> X% of the session's
>  * TTL we grab a new session from the container.
>  *
>  * (inactive * 1000) * (pct / 100) ==> (inactive * 10 * pct)
>  */
> if (session.getLastAccessedTime()
> - session.getCreationTime() > (session.getMaxInactiveInterval() * 
> 10
> * percentInactiveTimeTriggerRebuild)) {
>   HttpSession nativeSession = super.getSession();
>   session.failoverSession(nativeSession);
> }
> {noformat}
> Instead of this, we should just call getSession on the container and have it 
> update the last accessed time of the native session.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2889) Generic session module should touch sessions rather than recreate the native session

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003456#comment-16003456
 ] 

ASF GitHub Bot commented on GEODE-2889:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/494


> Generic session module should touch sessions rather than recreate the native 
> session
> 
>
> Key: GEODE-2889
> URL: https://issues.apache.org/jira/browse/GEODE-2889
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Dan Smith
>
> The session module for generic application servers is doing some magic to try 
> to recreate native sessions if they have been idle for too long. This can 
> cause failures if the container expires a session concurrently, because the 
> expiration can happen after we have checked if the session is valid, but 
> before we can read the session creation time.
> {noformat}
> /*
>  * This is a massively gross hack. Currently, there is no way to 
> actually update the last
>  * accessed time for a session, so what we do here is once we're into 
> X% of the session's
>  * TTL we grab a new session from the container.
>  *
>  * (inactive * 1000) * (pct / 100) ==> (inactive * 10 * pct)
>  */
> if (session.getLastAccessedTime()
> - session.getCreationTime() > (session.getMaxInactiveInterval() * 
> 10
> * percentInactiveTimeTriggerRebuild)) {
>   HttpSession nativeSession = super.getSession();
>   session.failoverSession(nativeSession);
> }
> {noformat}
> Instead of this, we should just call getSession on the container and have it 
> update the last accessed time of the native session.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #494: GEODE-2889: Update the last access time of native s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/494


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (GEODE-2905) CI failure: org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > searchWithoutIndexShouldReturnError

[Shelley Lynn Hughes-Godfrey (JIRA)]

Shelley Lynn Hughes-Godfrey created GEODE-2905:
--

 Summary: CI failure: 
org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > 
searchWithoutIndexShouldReturnError 
 Key: GEODE-2905
 URL: https://issues.apache.org/jira/browse/GEODE-2905
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: Shelley Lynn Hughes-Godfrey


This test failed in Apache Jenkins build #830.

{noformat}
org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > 
searchWithoutIndexShouldReturnError FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at 
org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest.searchWithoutIndexShouldReturnError(LuceneIndexCommandsDUnitTest.java:462)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59106: GEODE-2898 A non-responsive SSL client can block a server's "acceptor" thread

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59106/#review174363
---


Ship it!




Ship It!

- Udo Kohlmeyer


On May 9, 2017, 7:12 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59106/
> ---
> 
> (Updated May 9, 2017, 7:12 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-2898
> https://issues.apache.org/jira/browse/GEODE-2898
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This moves the SSL handshake from the acceptor thread to the handshake thread 
> and adds a unit test.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  ed294722db4784f1e9fe895d9f00dd6e4521d5d6 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/CacheServerSSLConnectionDUnitTest.java
>  3597152a25de7c2fdc87dfb9ec0e5613b7ec327c 
> 
> 
> Diff: https://reviews.apache.org/r/59106/diff/1/
> 
> 
> Testing
> ---
> 
> TDD - the test failed with a timeout exception but now passes with the 
> supplied fix.
> precheckin testing is underway
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Review Request 59106: GEODE-2898 A non-responsive SSL client can block a server's "acceptor" thread

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59106/
---

Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-2898
https://issues.apache.org/jira/browse/GEODE-2898


Repository: geode


Description
---

This moves the SSL handshake from the acceptor thread to the handshake thread 
and adds a unit test.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 ed294722db4784f1e9fe895d9f00dd6e4521d5d6 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/CacheServerSSLConnectionDUnitTest.java
 3597152a25de7c2fdc87dfb9ec0e5613b7ec327c 


Diff: https://reviews.apache.org/r/59106/diff/1/


Testing
---

TDD - the test failed with a timeout exception but now passes with the supplied 
fix.
precheckin testing is underway


Thanks,

Bruce Schuchardt

[jira] [Created] (GEODE-2903) FreeListOffHeapRegionJUnitTest testLocalPersistentCompressed failing intermittently

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-2903:
---

 Summary: FreeListOffHeapRegionJUnitTest 
testLocalPersistentCompressed failing intermittently
 Key: GEODE-2903
 URL: https://issues.apache.org/jira/browse/GEODE-2903
 Project: Geode
  Issue Type: Bug
  Components: offheap
Reporter: Darrel Schneider


org.apache.geode.internal.offheap.FreeListOffHeapRegionJUnitTest > 
testLocalPersistentCompressed FAILED
java.lang.AssertionError: expected:<0> but was:<24>

org.apache.geode.internal.offheap.OldFreeListOffHeapRegionJUnitTest > 
testLocalPersistentCompressed FAILED
java.lang.AssertionError: expected:<0> but was:<48>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2902) OffHeapLRURecoveryRegressionTest recoveringTooMuchDataDoesNotRunOutOfOffHeapMemory fails intermittently

[Darrel Schneider (JIRA)]

Darrel Schneider created GEODE-2902:
---

 Summary: OffHeapLRURecoveryRegressionTest 
recoveringTooMuchDataDoesNotRunOutOfOffHeapMemory fails intermittently
 Key: GEODE-2902
 URL: https://issues.apache.org/jira/browse/GEODE-2902
 Project: Geode
  Issue Type: Bug
  Components: offheap
Reporter: Darrel Schneider


org.apache.geode.internal.offheap.OffHeapLRURecoveryRegressionTest > 
recoveringTooMuchDataDoesNotRunOutOfOffHeapMemory FAILED
java.lang.AssertionError: expected:<10> but was:<11>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at 
org.apache.geode.internal.offheap.OffHeapLRURecoveryRegressionTest.recoveringTooMuchDataDoesNotRunOutOfOffHeapMemory(OffHeapLRURecoveryRegressionTest.java:74)




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-236) Remove deprecated CacheEvent methods

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-236.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Remove deprecated CacheEvent methods
> 
>
> Key: GEODE-236
> URL: https://issues.apache.org/jira/browse/GEODE-236
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
> Fix For: 1.2.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The following methods need to be removed:
> - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration
> - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed
> This should be a pretty easy task to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003276#comment-16003276
 ] 

ASF subversion and git services commented on GEODE-236:
---

Commit 250c818940ad9fa1c773ce17c85bf02388d2 in geode's branch 
refs/heads/develop from [~dschneider]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=250c818 ]

GEODE-236: fix javadoc warnings

Also removed two implementations of the deprecated
methods that had been removed.


> Remove deprecated CacheEvent methods
> 
>
> Key: GEODE-236
> URL: https://issues.apache.org/jira/browse/GEODE-236
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The following methods need to be removed:
> - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration
> - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed
> This should be a pretty easy task to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-254) Remove deprecated Region.keys and Region.entries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003270#comment-16003270
 ] 

ASF GitHub Bot commented on GEODE-254:
--

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/488
  
Thanks @dschneider-pivotal  for review. I will fix those issue and raise 
another PR, as this one is already merged.


> Remove deprecated Region.keys and Region.entries
> 
>
> Key: GEODE-254
> URL: https://issues.apache.org/jira/browse/GEODE-254
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Remove the deprecated Region.keys and Region.entries. Any calls can be simply 
> changed to Region.keySet and Region.entrySet so this should be an easy change.
> A large number of tests call the deprecated methods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #488: GEODE-254: Removed deprecated Region.keys and Region.entri...

[davinash]

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/488
  
Thanks @dschneider-pivotal  for review. I will fix those issue and raise 
another PR, as this one is already merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (GEODE-2901) Add more tests of http session replication module

[Dan Smith (JIRA)]

Dan Smith created GEODE-2901:


 Summary: Add more tests of http session replication module
 Key: GEODE-2901
 URL: https://issues.apache.org/jira/browse/GEODE-2901
 Project: Geode
  Issue Type: Improvement
  Components: http session
Reporter: Dan Smith


We should add more integration tests of http session replication with failover, 
expiration, and multiple containers.

We currently have some junit tests of the generic session replication module in 
 geode-modules-session and a couple of dunit tests of the tomcat session module 
in geode-modules-tomcat8.

However, we really want a comprehensive set of tests that run against both 
session modules and multiple containers.

I think we can get to that point if we use something like 
[cargo|https://codehaus-cargo.github.io/cargo/Home.html]. We could do something 
like the dunit tests we have where we use httpunit from the client, but use 
cargo to actually launch the containers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-236) Remove deprecated CacheEvent methods

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-236:
--

Assignee: Darrel Schneider  (was: Avinash Dongre)

> Remove deprecated CacheEvent methods
> 
>
> Key: GEODE-236
> URL: https://issues.apache.org/jira/browse/GEODE-236
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The following methods need to be removed:
> - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration
> - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed
> This should be a pretty easy task to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods

[Darrel Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003249#comment-16003249
 ] 

Darrel Schneider commented on GEODE-236:


The previous fix introduced these javadocs warnings. I will check in a fix for 
these soon:
{noformat}
:geode-core:javadoc/tmp/gemfire-build/geode/geode-core/src/main/java/org/apache/geode/internal/cache/RegionEventImpl.java:193:
 warning - Tag @see: can't find isExpiration() in 
org.apache.geode.cache.CacheEvent
/tmp/gemfire-build/geode/geode-core/src/main/java/org/apache/geode/internal/cache/RegionEventImpl.java:200:
 warning - Tag @see: can't find isDistributed() in 
org.apache.geode.cache.CacheEvent

{noformat}



> Remove deprecated CacheEvent methods
> 
>
> Key: GEODE-236
> URL: https://issues.apache.org/jira/browse/GEODE-236
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The following methods need to be removed:
> - CacheEvent.isExpiration: change to CacheEvent.getOperation().isExpiration
> - CacheEvent.isDistributed: change to CacheEvent.getOperation().isDistributed
> This should be a pretty easy task to complete.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-237) Remove EntryEvent deprecated methods

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-237:
--

Assignee: Avinash Dongre  (was: Darrel Schneider)

> Remove EntryEvent deprecated methods
> 
>
> Key: GEODE-237
> URL: https://issues.apache.org/jira/browse/GEODE-237
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The following EntryEvent methods need to be removed:
> - isLocalLoad: change to getOperation().isLocalLoad
> - isNetLoad: change to getOperation().isNetLoad
> - isLoad: change to getOperation().isLoad
> - isNetSearch: change to getOperation().isNetSearch
> - isBridgeEvent: change to hasClientOrigin
> these should be pretty easy to change



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Issue Comment Deleted] (GEODE-237) Remove EntryEvent deprecated methods

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider updated GEODE-237:
---
Comment: was deleted

(was: The previous fix introduced these javadocs warnings. I will check in a 
fix for these soon:
{noformat}
:geode-core:javadoc/tmp/gemfire-build/geode/geode-core/src/main/java/org/apache/geode/internal/cache/RegionEventImpl.java:193:
 warning - Tag @see: can't find isExpiration() in 
org.apache.geode.cache.CacheEvent
/tmp/gemfire-build/geode/geode-core/src/main/java/org/apache/geode/internal/cache/RegionEventImpl.java:200:
 warning - Tag @see: can't find isDistributed() in 
org.apache.geode.cache.CacheEvent

{noformat}

)

> Remove EntryEvent deprecated methods
> 
>
> Key: GEODE-237
> URL: https://issues.apache.org/jira/browse/GEODE-237
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The following EntryEvent methods need to be removed:
> - isLocalLoad: change to getOperation().isLocalLoad
> - isNetLoad: change to getOperation().isNetLoad
> - isLoad: change to getOperation().isLoad
> - isNetSearch: change to getOperation().isNetSearch
> - isBridgeEvent: change to hasClientOrigin
> these should be pretty easy to change



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: Geode-nightly #830

[Apache Jenkins Server]

See 


Changes:

[Anil] GEODE-2776: Setting version tag on the client event from the current

[gzhou] GEODE-2824: When advisor cannot found target nodes for bucket id, should

[nnag] GEODE-2881: Wait for waitForFlushBeforeExecuteTextSearch to complete

[eshu] GEODE-2882: Check if region is destroyed before throw

[dbarnes] GEODE-2352 Document that REST API requires two properties

[dbarnes] GEODE-2815 Incorrect Error Message in REST API docs for {region}/{key}

[jstewart] GEODE-2876: Add logging to diagnose CI failure

[klund] GEODE-2858: Add test for parsing of simple XML file w pool

[klund] GEODE-2884: fix NPE when calling getLatestAsClassLoader before getLatest

[klund] GEODE-2887: exclude build-* output directories from rat

[klund] GEODE-2738: Corrected misspellibng of "occured" to "occurred"

[jstewart] GEODE-2876: Revert 65821d1 due to broken tests

[nnag] GEODE-2879: Shutdown() called from close() in LonerDistributionManager

[nnag] GEODE-2754: Changed the name of unknown host

[upthewaterspout] GEODE-1728: Http session filter should not be applied to 
FORWARDS

--
[...truncated 108.88 KB...]
:geode-json:flakyTest NO-SOURCE
:geode-json:integrationTest NO-SOURCE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources NO-SOURCE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest

org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest > 
searchWithoutIndexShouldReturnError FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at 
org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommandsDUnitTest.searchWithoutIndexShouldReturnError(LuceneIndexCommandsDUnitTest.java:462)

300 tests completed, 1 failed
:geode-lucene:distributedTest FAILED
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources NO-SOURCE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc NO-SOURCE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava NO-SOURCE
:geode-old-versions:processTestResources NO-SOURCE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests NO-SOURCE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test NO-SOURCE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest NO-SOURCE
:geode-old-versions:flakyTest NO-SOURCE
:geode-old-versions:integrationTest NO-SOURCE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources NO-SOURCE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests

[jira] [Commented] (GEODE-237) Remove EntryEvent deprecated methods

[Darrel Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003236#comment-16003236
 ] 

Darrel Schneider commented on GEODE-237:


The previous fix introduced these javadocs warnings. I will check in a fix for 
these soon:
{noformat}
:geode-core:javadoc/tmp/gemfire-build/geode/geode-core/src/main/java/org/apache/geode/internal/cache/RegionEventImpl.java:193:
 warning - Tag @see: can't find isExpiration() in 
org.apache.geode.cache.CacheEvent
/tmp/gemfire-build/geode/geode-core/src/main/java/org/apache/geode/internal/cache/RegionEventImpl.java:200:
 warning - Tag @see: can't find isDistributed() in 
org.apache.geode.cache.CacheEvent

{noformat}



> Remove EntryEvent deprecated methods
> 
>
> Key: GEODE-237
> URL: https://issues.apache.org/jira/browse/GEODE-237
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The following EntryEvent methods need to be removed:
> - isLocalLoad: change to getOperation().isLocalLoad
> - isNetLoad: change to getOperation().isNetLoad
> - isLoad: change to getOperation().isLoad
> - isNetSearch: change to getOperation().isNetSearch
> - isBridgeEvent: change to hasClientOrigin
> these should be pretty easy to change



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-237) Remove EntryEvent deprecated methods

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-237:
--

Assignee: Darrel Schneider  (was: Avinash Dongre)

> Remove EntryEvent deprecated methods
> 
>
> Key: GEODE-237
> URL: https://issues.apache.org/jira/browse/GEODE-237
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The following EntryEvent methods need to be removed:
> - isLocalLoad: change to getOperation().isLocalLoad
> - isNetLoad: change to getOperation().isNetLoad
> - isLoad: change to getOperation().isLoad
> - isNetSearch: change to getOperation().isNetSearch
> - isBridgeEvent: change to hasClientOrigin
> these should be pretty easy to change



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Fixed: apache/geode#2537 (develop - d58be4f)

[Travis CI]

Build Update for apache/geode
-

Build: #2537
Status: Fixed

Duration: 8 minutes and 52 seconds
Commit: d58be4f (develop)
Author: nabarun
Message: GEODE-2896: Changing the test category to IntegrationTest

* Changed the test category to IntegrationTest from being an UnitTest
* This creates a separate VM for these tests which are not affected by 
residual instances created by other tests.

View the changeset: 
https://github.com/apache/geode/compare/23eb2326f15b...d58be4fa2721

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/230445956?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[jira] [Commented] (GEODE-2894) Review getEntry on Region

[Darrel Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003171#comment-16003171
 ] 

Darrel Schneider commented on GEODE-2894:
-

Another key different between get and getEntry is that getEntry will never call 
a CacheLoader.


> Review getEntry on Region
> -
>
> Key: GEODE-2894
> URL: https://issues.apache.org/jira/browse/GEODE-2894
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Fred Krone
>
> This needs to behave the same as .get()
> For example, on a RegionAttributeShortcut.PROXY
> .put will put on the server ... 
> but currently .entry is local only and will return null 
> .get will go to the server and get the value
> ACCEPTANCE
> WHEN Region.put(Object o) is used Region.get or Region.getEntry should return 
> as .get would



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2891) connect-timeout violation in C++ Native Client

[Gregory Vortman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Vortman updated GEODE-2891:
---

Thanks for help



> connect-timeout violation in C++ Native Client
> --
>
> Key: GEODE-2891
> URL: https://issues.apache.org/jira/browse/GEODE-2891
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Gregory Vortman
> Fix For: 1.1.1
>
> Attachments: gemfire-connect-timeout-violation.docx
>
>
> 1.C++ native client doesn’t honour read-timeout-milli-sec in a consistent 
> way while connecting to a server
> 2.The lock on the connection pool has a very high granularity. Even if 
> the client can’t connect to one server, all other threads which are working 
> with totally different servers get affected by it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2891) connect-timeout violation in C++ Native Client

[Bruce Schuchardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003160#comment-16003160
 ] 

Bruce Schuchardt commented on GEODE-2891:
-

You can work on a clone of the github repo and submit a pull request.  You 
might want to assign the JIRA ticket to someone on your team if you are going 
to do this.  Here is the process for submitting a pull request: 
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions

> connect-timeout violation in C++ Native Client
> --
>
> Key: GEODE-2891
> URL: https://issues.apache.org/jira/browse/GEODE-2891
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Gregory Vortman
> Fix For: 1.1.1
>
> Attachments: gemfire-connect-timeout-violation.docx
>
>
> 1.C++ native client doesn’t honour read-timeout-milli-sec in a consistent 
> way while connecting to a server
> 2.The lock on the connection pool has a very high granularity. Even if 
> the client can’t connect to one server, all other threads which are working 
> with totally different servers get affected by it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Revert gradle upgrade

[Udo Kohlmeyer]

I think we have to check the ANTLR plugin to understand it's requirements..

maybe there is a newer plugin version for ANTLR

On 5/9/17 10:00, Kirk Lund wrote:

I've reverted the upgrade to gradle 3.4.1. I also went ahead and created a
branch that repeats the upgrade:

feature/gradle-3.4.1

Feel free to experiment with that branch.

On Tue, May 9, 2017 at 9:53 AM, Kirk Lund  wrote:


I'll go ahead and revert the upgrade. Hopefully we can eventually find the
cause so we can repeat the upgrade.

On Mon, May 8, 2017 at 4:19 PM, Bruce Schuchardt 
wrote:


The "eclipse" target fails, too.

Le 5/8/2017 à 3:32 PM, Kirk Lund a écrit :


I want to revert the gradle upgrade because it breaks IntelliJ and the
idea
gradle task. Please let me know if you have a problem with this.

PS: Please be prepared to help me if you vote against me reverting the
upgrade ;) I really want to be able to work again. Thanks!

Re: Review Request 59035: GEODE-2883: Fix GFSH gc heap size output

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59035/#review174347
---


Ship it!




Ship It!

- Kirk Lund


On May 5, 2017, 11:19 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59035/
> ---
> 
> (Updated May 5, 2017, 11:19 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jinmei Liao, Ken Howe, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2883: Fix GFSH gc heap size output
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GarbageCollectionFunction.java
>  354d353 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/BytesToString.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/BytesToStringTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59035/diff/3/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 59098: GEODE-2876: add logging to diagnose parser test failure in Jenkins

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59098/#review174346
---


Ship it!




Ship It!

- Kirk Lund


On May 9, 2017, 3:32 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59098/
> ---
> 
> (Updated May 9, 2017, 3:32 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2876: add logging to diagnose test failure
> 
> another try to add parser logs using log4j. I have another set of changes 
> that would remove the other loggers in GfshParser. For now, they co-exist.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
>  20ae0226db45574028311493a07cdfcf9fbfb3f0 
> 
> 
> Diff: https://reviews.apache.org/r/59098/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[jira] [Commented] (GEODE-2896) ClassCastException in GMSMembershipManagerJUnitTest

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003129#comment-16003129
 ] 

ASF subversion and git services commented on GEODE-2896:


Commit d58be4fa272135c8688e7e244d4198b73f6e113c in geode's branch 
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d58be4f ]

GEODE-2896: Changing the test category to IntegrationTest

* Changed the test category to IntegrationTest from being an UnitTest
* This creates a separate VM for these tests which are not affected by 
residual instances created by other tests.


> ClassCastException in GMSMembershipManagerJUnitTest
> ---
>
> Key: GEODE-2896
> URL: https://issues.apache.org/jira/browse/GEODE-2896
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: nabarun
>Assignee: nabarun
>
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSendFailureDueToForcedDisconnect FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testDirectChannelSendFailureDueToForcedDisconnect(GMSMembershipManagerJUnitTest.java:343)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testStartupEvents FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testStartupEvents(GMSMembershipManagerJUnitTest.java:219)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testSendToEmptyListIsRejected FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testSendToEmptyListIsRejected(GMSMembershipManagerJUnitTest.java:177)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSendAllRecipients FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testDirectChannelSendAllRecipients(GMSMembershipManagerJUnitTest.java:331)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSend FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testDirectChannelSend(GMSMembershipManagerJUnitTest.java:281)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSendFailureToOneRecipient FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to org.apache.geode.distributed.internal.DistributionManager
> at 
> org.apache.geode.distributed.internal.HighPriorityAckedMessage.(HighPriorityAckedMessage.java:68)
> at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest.testDirectChannelSendFailureToOneRecipient(GMSMembershipManagerJUnitTest.java:294)
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManagerJUnitTest
>  > testDirectChannelSendFailureToAll FAILED
> java.lang.ClassCastException: 
> org.apache.geode.distributed.internal.LonerDistributionManager cannot be cast 
> to 

[jira] [Commented] (GEODE-234) remove deprecated MirrorType class

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003126#comment-16003126
 ] 

ASF GitHub Bot commented on GEODE-234:
--

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/geode/pull/495
  
Yes. I think it is just xsd (not dtd) changes and the java changes needed 
when adding a new xsd.



> remove deprecated MirrorType class
> --
>
> Key: GEODE-234
> URL: https://issues.apache.org/jira/browse/GEODE-234
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>
> All uses of MirrorType should be changed to use DataPolicy.REPLICATE.
> All apis that take it as a parameter or return it need to be deleted.
> The cache-9.0.xsd should also be changed to no longer have the "mirror-type" 
> region-attribute.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #495: GEODE-234: Removed deprecated MirrorType class and its usa...

[dschneider-pivotal]

Github user dschneider-pivotal commented on the issue:

https://github.com/apache/geode/pull/495
  
Yes. I think it is just xsd (not dtd) changes and the java changes needed 
when adding a new xsd.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2891) connect-timeout violation in C++ Native Client

[Gregory Vortman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Vortman updated GEODE-2891:
---
Component/s: (was: client/server)
 native client

> connect-timeout violation in C++ Native Client
> --
>
> Key: GEODE-2891
> URL: https://issues.apache.org/jira/browse/GEODE-2891
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Gregory Vortman
> Fix For: 1.1.1
>
> Attachments: gemfire-connect-timeout-violation.docx
>
>
> 1.C++ native client doesn’t honour read-timeout-milli-sec in a consistent 
> way while connecting to a server
> 2.The lock on the connection pool has a very high granularity. Even if 
> the client can’t connect to one server, all other threads which are working 
> with totally different servers get affected by it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #502: GEODE-2900: push shadow key to the front of eventSe...

[jhuynh1]

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/502

GEODE-2900:  push shadow key to the front of eventSeqNumQueue

Testing still needs to be done on this change, but wanted to get some 
eyeballs on the change in parallel

@upthewaterspout @boglesby 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2900

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #502


commit 240b469ff217fbfba39381f196ae3e0e832a69a6
Author: Jason Huynh 
Date:   2017-05-09T17:11:39Z

GEODE-2900:  push shadow key back into the front of the eventSeqNumber 
"Queue"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003099#comment-16003099
 ] 

ASF GitHub Bot commented on GEODE-2900:
---

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/502

GEODE-2900:  push shadow key to the front of eventSeqNumQueue

Testing still needs to be done on this change, but wanted to get some 
eyeballs on the change in parallel

@upthewaterspout @boglesby 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2900

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #502


commit 240b469ff217fbfba39381f196ae3e0e832a69a6
Author: Jason Huynh 
Date:   2017-05-09T17:11:39Z

GEODE-2900:  push shadow key back into the front of the eventSeqNumber 
"Queue"




> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2891) connect-timeout violation in C++ Native Client

[Gregory Vortman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Vortman updated GEODE-2891:
---

Hu Bruce,
I'll modify the component.
In case I know how to fix the issue, how I or my colleges can be assigned?

Thanks



> connect-timeout violation in C++ Native Client
> --
>
> Key: GEODE-2891
> URL: https://issues.apache.org/jira/browse/GEODE-2891
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Gregory Vortman
> Fix For: 1.1.1
>
> Attachments: gemfire-connect-timeout-violation.docx
>
>
> 1.C++ native client doesn’t honour read-timeout-milli-sec in a consistent 
> way while connecting to a server
> 2.The lock on the connection pool has a very high granularity. Even if 
> the client can’t connect to one server, all other threads which are working 
> with totally different servers get affected by it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003084#comment-16003084
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit 240b469ff217fbfba39381f196ae3e0e832a69a6 in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=240b469 ]

GEODE-2900:  push shadow key back into the front of the eventSeqNumber "Queue"


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-2900:
--

Assignee: Jason Huynh

> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[Jason Huynh (JIRA)]

Jason Huynh created GEODE-2900:
--

 Summary: BucketRegionQueue transitions from 
primary/secondary/primary can lead to events lingering in queue
 Key: GEODE-2900
 URL: https://issues.apache.org/jira/browse/GEODE-2900
 Project: Geode
  Issue Type: Bug
  Components: wan
Reporter: Jason Huynh


In this scenario when peek() is called from BucketRegionQueue, a side effect is 
that the key is removed from the eventSeqNumQueue and an event is placed into 
the peekedEvents list.

If there is failure dispatching the event, we add the peekedEvents list to a 
new peekedEvents list.  Before doing so, we remove any events that we are not 
primary for.  Now the event is not in the eventSeqNumQueue or the peekedEvents 
list

If we now become primary (before the other node could dispatch this event), and 
because we do not have that event in the eventSeqNumQueue or the peekedEvents, 
it gets "stuck."




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Revert gradle upgrade

[Kirk Lund]

I've reverted the upgrade to gradle 3.4.1. I also went ahead and created a
branch that repeats the upgrade:

feature/gradle-3.4.1

Feel free to experiment with that branch.

On Tue, May 9, 2017 at 9:53 AM, Kirk Lund  wrote:

> I'll go ahead and revert the upgrade. Hopefully we can eventually find the
> cause so we can repeat the upgrade.
>
> On Mon, May 8, 2017 at 4:19 PM, Bruce Schuchardt 
> wrote:
>
>> The "eclipse" target fails, too.
>>
>> Le 5/8/2017 à 3:32 PM, Kirk Lund a écrit :
>>
>>> I want to revert the gradle upgrade because it breaks IntelliJ and the
>>> idea
>>> gradle task. Please let me know if you have a problem with this.
>>>
>>> PS: Please be prepared to help me if you vote against me reverting the
>>> upgrade ;) I really want to be able to work again. Thanks!
>>>
>>>
>>
>

[jira] [Updated] (GEODE-2899) Unexpected array lifting in function argument passing

[Augustus Lidaka (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Augustus Lidaka updated GEODE-2899:
---
Description: 
When passing an array with one argument to a function call, the array is 
flattened and:
{code}FunctionContext.getArguments(){code}
returns the value itself. (This is the same behavior within the function 
context as if the caller had passed just the argument object instead of boxed 
in an array.)

For example, given this function:
{code}
public class EchoFunction extends Object implements Function {
public void execute(FunctionContext fc) {
RegionFunctionContext context = (RegionFunctionContext)fc;
Object[] arguments = (Object[])context.getArguments(); // <-
ResultSender resultSender = fc.getResultSender();
for (int i = 0; i < arguments.length - 1; i++) {
resultSender.sendResult(arguments[i].toString());
}
resultSender.lastResult(arguments[arguments.length - 1].toString());
}
// ...
}
{code}

This curl command with 2 arguments {color:green}works{color}:
{code}
 2017-05-09 09:50:10 ☆  EUROPA-WIN10 in ~
○ → curl -H "Content-Type: application/json" -d '[{"@type":"Long", 
"@value":210}, {"@type":"Long", "@value":211}]' http:
//35.165.170.9:8080/gemfire-api/v1/functions/EchoFunction?onRegion=orders
[ "210", "211" ]
{code}

This curl command with 1 argument {color:green}fails in an expected 
manner{color}:
{code}
 2017-05-09 09:51:23 ☆  EUROPA-WIN10 in ~
○ → curl -H "Content-Type: application/json" -d '{"@type":"Long", 
"@value":210}' http://35.165.170.9:8080/gemfire-api/v1
/functions/EchoFunction?onRegion=orders
{"message" : "Server has encountered an error while processing function 
execution!", "stackTrace" : 
"org.apache.geode.rest.internal.web.exception.GemfireRestException: Server has 
encountered an error while processing function execution!
at 
org.apache.geode.rest.internal.web.controllers.FunctionAccessController.execute(FunctionAccessController.java:249)
at 
org.apache.geode.rest.internal.web.controllers.FunctionAccessController$$FastClassBySpringCGLIB$$b1783d32.invoke()
at 
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:720)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
at 
org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:69)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at 
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:655)
at 
org.apache.geode.rest.internal.web.controllers.FunctionAccessController$$EnhancerBySpringCGLIB$$c708a3cd.execute()
at sun.reflect.GeneratedMethodAccessor342.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)
at 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136)
at 
org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:114)
at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)
at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)
at 
org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
at 
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:963)
at 
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:897)
at 
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)
at 
org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:872)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at 
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:821)
at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1685)
at 

[jira] [Commented] (GEODE-2708) Update Gradle Wrapper to Gradle 3

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003038#comment-16003038
 ] 

ASF subversion and git services commented on GEODE-2708:


Commit 4ee7a8e596d1fe47480e7f2acb2d1a2145210bd3 in geode's branch 
refs/heads/feature/gradle-3.4.1 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4ee7a8e ]

Revert "Revert "GEODE-2708: Update Gradle Wrapper To 3.4.1""

This reverts commit 23eb2326f15b4e4260f32a527ab01d9033948330.


> Update Gradle Wrapper to Gradle 3
> -
>
> Key: GEODE-2708
> URL: https://issues.apache.org/jira/browse/GEODE-2708
> Project: Geode
>  Issue Type: Task
>  Components: build
>Reporter: Galen O'Sullivan
>Assignee: Mark Bretl
> Fix For: 1.2.0
>
>
> It looks like we're still running on a very old version of Gradle. This may 
> be related to incremental builds not working properly.
> {code}
> $ ./gradlew --version
> 
> Gradle 2.14.1
> 
> Build time:   2016-07-18 06:38:37 UTC
> Revision: d9e2113d9fb05a5caabba61798bdb8dfdca83719
> Groovy:   2.4.4
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> $ gradle --version
> 
> Gradle 3.4.1
> 
> Build time:   2017-03-03 19:45:41 UTC
> Revision: 9eb76efdd3d034dc506c719dac2955efb5ff9a93
> Groovy:   2.4.7
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2708) Update Gradle Wrapper to Gradle 3

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003040#comment-16003040
 ] 

ASF subversion and git services commented on GEODE-2708:


Commit a926056b7e9bd368fb58b078ad524da1ef2e3c7e in geode's branch 
refs/heads/feature/gradle-3.4.1 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a926056 ]

Revert "Revert "GEODE-2708: Update Minimum Gradle Version To 3.4.1""

This reverts commit 737bb7fac87fc130fd0d85205dac84894827514d.


> Update Gradle Wrapper to Gradle 3
> -
>
> Key: GEODE-2708
> URL: https://issues.apache.org/jira/browse/GEODE-2708
> Project: Geode
>  Issue Type: Task
>  Components: build
>Reporter: Galen O'Sullivan
>Assignee: Mark Bretl
> Fix For: 1.2.0
>
>
> It looks like we're still running on a very old version of Gradle. This may 
> be related to incremental builds not working properly.
> {code}
> $ ./gradlew --version
> 
> Gradle 2.14.1
> 
> Build time:   2016-07-18 06:38:37 UTC
> Revision: d9e2113d9fb05a5caabba61798bdb8dfdca83719
> Groovy:   2.4.4
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> $ gradle --version
> 
> Gradle 3.4.1
> 
> Build time:   2017-03-03 19:45:41 UTC
> Revision: 9eb76efdd3d034dc506c719dac2955efb5ff9a93
> Groovy:   2.4.7
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2708) Update Gradle Wrapper to Gradle 3

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003035#comment-16003035
 ] 

ASF subversion and git services commented on GEODE-2708:


Commit 23eb2326f15b4e4260f32a527ab01d9033948330 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=23eb232 ]

Revert "GEODE-2708: Update Gradle Wrapper To 3.4.1"

This reverts commit 9ed9e329f89f09ff2d91e1de48f17c9bbbf54512.


> Update Gradle Wrapper to Gradle 3
> -
>
> Key: GEODE-2708
> URL: https://issues.apache.org/jira/browse/GEODE-2708
> Project: Geode
>  Issue Type: Task
>  Components: build
>Reporter: Galen O'Sullivan
>Assignee: Mark Bretl
> Fix For: 1.2.0
>
>
> It looks like we're still running on a very old version of Gradle. This may 
> be related to incremental builds not working properly.
> {code}
> $ ./gradlew --version
> 
> Gradle 2.14.1
> 
> Build time:   2016-07-18 06:38:37 UTC
> Revision: d9e2113d9fb05a5caabba61798bdb8dfdca83719
> Groovy:   2.4.4
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> $ gradle --version
> 
> Gradle 3.4.1
> 
> Build time:   2017-03-03 19:45:41 UTC
> Revision: 9eb76efdd3d034dc506c719dac2955efb5ff9a93
> Groovy:   2.4.7
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2708) Update Gradle Wrapper to Gradle 3

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003034#comment-16003034
 ] 

ASF subversion and git services commented on GEODE-2708:


Commit 737bb7fac87fc130fd0d85205dac84894827514d in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=737bb7f ]

Revert "GEODE-2708: Update Minimum Gradle Version To 3.4.1"

This reverts commit 21d4ab2cf1c897bded41c0426a32531e926b689c.


> Update Gradle Wrapper to Gradle 3
> -
>
> Key: GEODE-2708
> URL: https://issues.apache.org/jira/browse/GEODE-2708
> Project: Geode
>  Issue Type: Task
>  Components: build
>Reporter: Galen O'Sullivan
>Assignee: Mark Bretl
> Fix For: 1.2.0
>
>
> It looks like we're still running on a very old version of Gradle. This may 
> be related to incremental builds not working properly.
> {code}
> $ ./gradlew --version
> 
> Gradle 2.14.1
> 
> Build time:   2016-07-18 06:38:37 UTC
> Revision: d9e2113d9fb05a5caabba61798bdb8dfdca83719
> Groovy:   2.4.4
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> $ gradle --version
> 
> Gradle 3.4.1
> 
> Build time:   2017-03-03 19:45:41 UTC
> Revision: 9eb76efdd3d034dc506c719dac2955efb5ff9a93
> Groovy:   2.4.7
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2899) Unexpected array lifting in function argument passing

[Augustus Lidaka (JIRA)]

Augustus Lidaka created GEODE-2899:
--

 Summary: Unexpected array lifting in function argument passing
 Key: GEODE-2899
 URL: https://issues.apache.org/jira/browse/GEODE-2899
 Project: Geode
  Issue Type: Bug
  Components: functions, rest (dev)
Reporter: Augustus Lidaka


When passing an array with one argument to a function call, the array is 
flattened and:
{code}FunctionContext.getArguments(){code}
returns the value itself. (This is the same behavior within the function 
context as if the caller had passed just the argument object instead of boxed 
in an array.)

For example, given this function:
{code}
public class EchoFunction extends Object implements Function {
public void execute(FunctionContext fc) {
RegionFunctionContext context = (RegionFunctionContext)fc;
Object[] arguments = (Object[])context.getArguments(); // <-
ResultSender resultSender = fc.getResultSender();
for (int i = 0; i < arguments.length - 1; i++) {
resultSender.sendResult(arguments[i].toString());
}
resultSender.lastResult(arguments[arguments.length - 1].toString());
}
// ...
}
{code}

This curl command with 2 arguments works:
{code}
 2017-05-09 09:50:10 ☆  EUROPA-WIN10 in ~
○ → curl -H "Content-Type: application/json" -d '[{"@type":"Long", 
"@value":210}, {"@type":"Long", "@value":211}]' http:
//35.165.170.9:8080/gemfire-api/v1/functions/EchoFunction?onRegion=orders
[ "210", "211" ]
{code}

This curl command with 1 argument fails in an expected manner:
{code}
 2017-05-09 09:51:23 ☆  EUROPA-WIN10 in ~
○ → curl -H "Content-Type: application/json" -d '{"@type":"Long", 
"@value":210}' http://35.165.170.9:8080/gemfire-api/v1
/functions/EchoFunction?onRegion=orders
{"message" : "Server has encountered an error while processing function 
execution!", "stackTrace" : 
"org.apache.geode.rest.internal.web.exception.GemfireRestException: Server has 
encountered an error while processing function execution!
at 
org.apache.geode.rest.internal.web.controllers.FunctionAccessController.execute(FunctionAccessController.java:249)
at 
org.apache.geode.rest.internal.web.controllers.FunctionAccessController$$FastClassBySpringCGLIB$$b1783d32.invoke()
at 
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:720)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
at 
org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:69)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
at 
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:655)
at 
org.apache.geode.rest.internal.web.controllers.FunctionAccessController$$EnhancerBySpringCGLIB$$c708a3cd.execute()
at sun.reflect.GeneratedMethodAccessor342.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)
at 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136)
at 
org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:114)
at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)
at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)
at 
org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
at 
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:963)
at 
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:897)
at 
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)
at 
org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:872)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
at 
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:821)
at 

Re: Revert gradle upgrade

[Kirk Lund]

I'll go ahead and revert the upgrade. Hopefully we can eventually find the
cause so we can repeat the upgrade.

On Mon, May 8, 2017 at 4:19 PM, Bruce Schuchardt 
wrote:

> The "eclipse" target fails, too.
>
> Le 5/8/2017 à 3:32 PM, Kirk Lund a écrit :
>
>> I want to revert the gradle upgrade because it breaks IntelliJ and the
>> idea
>> gradle task. Please let me know if you have a problem with this.
>>
>> PS: Please be prepared to help me if you vote against me reverting the
>> upgrade ;) I really want to be able to work again. Thanks!
>>
>>
>

[jira] [Commented] (GEODE-2875) shutdown is taking as long as 20 seconds

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003026#comment-16003026
 ] 

ASF subversion and git services commented on GEODE-2875:


Commit d2edad5eb1d50762a01f372f430464f6919e65fd in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d2edad5 ]

GEODE-2875: SpotlessApply


> shutdown is taking as long as 20 seconds
> 
>
> Key: GEODE-2875
> URL: https://issues.apache.org/jira/browse/GEODE-2875
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>
> Recent changes have introduced a bug where sometimes, particularly during 
> shutdown of a lot of servers, the shutdown process will stall for as long as 
> 20 seconds.  This appears to be due to changes that keep a membership 
> coordinator from sending out a new view during shutdown.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59098: GEODE-2876: add logging to diagnose parser test failure in Jenkins

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59098/#review174334
---


Ship it!




Ship It!

- Patrick Rhomberg


On May 9, 2017, 3:32 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59098/
> ---
> 
> (Updated May 9, 2017, 3:32 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2876: add logging to diagnose test failure
> 
> another try to add parser logs using log4j. I have another set of changes 
> that would remove the other loggers in GfshParser. For now, they co-exist.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
>  20ae0226db45574028311493a07cdfcf9fbfb3f0 
> 
> 
> Diff: https://reviews.apache.org/r/59098/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[jira] [Created] (GEODE-2898) A non-responsive SSL client can block a server's "acceptor" thread

[Bruce Schuchardt (JIRA)]

Bruce Schuchardt created GEODE-2898:
---

 Summary: A non-responsive SSL client can block a server's 
"acceptor" thread
 Key: GEODE-2898
 URL: https://issues.apache.org/jira/browse/GEODE-2898
 Project: Geode
  Issue Type: Bug
  Components: client/server
Reporter: Bruce Schuchardt


During the handoff to the handshake thread pool the accept thread can be 
blocked in the SSL handshake. The SSL handshake should be moved to the 
handshake thread pool. The goal is allow the server to reject clients that 
haven't finished the handshake in the allotted time.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: GMSMembershipManagerJUnitTest failing consistently in precheckin

[Nabarun Nag]

We suspect that it is because of usage of static InternalDistributedSystem
getAnyInstance() which gets it a LonerDistributionManager created by some
other test. We have created a JIRA ticket [GEODE-2896] for it and have a
fix for it.


Regards
Naba

On Tue, May 9, 2017 at 9:00 AM Jinmei Liao  wrote:

> happens on my precheckin as well. not failing when running alone in my
> IDEA.
>
> On Mon, May 8, 2017 at 11:18 AM, Kirk Lund  wrote:
>
> > I don't see this test failing in the nightly build but it seems to fail
> > consistently for me in precheckin (last 6 precheckins). Any ideas what's
> > wrong? Is anyone already looking into this failure?
> >
> > :geode-core:test
> >
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest
> > > testDirectChannelSendFailureDueToForcedDisconnect FAILED
> > java.lang.ClassCastException:
> > org.apache.geode.distributed.internal.LonerDistributionManager cannot be
> > cast to org.apache.geode.distributed.internal.DistributionManager
> > at
> > org.apache.geode.distributed.internal.HighPriorityAckedMessage.(
> > HighPriorityAckedMessage.java:68)
> > at
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest.testDirectChannelSendFailureDu
> > eToForcedDisconnect(GMSMembershipManagerJUnitTest.java:343)
> >
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest
> > > testStartupEvents FAILED
> > java.lang.ClassCastException:
> > org.apache.geode.distributed.internal.LonerDistributionManager cannot be
> > cast to org.apache.geode.distributed.internal.DistributionManager
> > at
> > org.apache.geode.distributed.internal.HighPriorityAckedMessage.(
> > HighPriorityAckedMessage.java:68)
> > at
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest.testStartupEvents(
> > GMSMembershipManagerJUnitTest.java:219)
> >
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest
> > > testSendToEmptyListIsRejected FAILED
> > java.lang.ClassCastException:
> > org.apache.geode.distributed.internal.LonerDistributionManager cannot be
> > cast to org.apache.geode.distributed.internal.DistributionManager
> > at
> > org.apache.geode.distributed.internal.HighPriorityAckedMessage.(
> > HighPriorityAckedMessage.java:68)
> > at
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest.testSendToEmptyListIsRejected(
> > GMSMembershipManagerJUnitTest.java:177)
> >
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest
> > > testDirectChannelSendAllRecipients FAILED
> > java.lang.ClassCastException:
> > org.apache.geode.distributed.internal.LonerDistributionManager cannot be
> > cast to org.apache.geode.distributed.internal.DistributionManager
> > at
> > org.apache.geode.distributed.internal.HighPriorityAckedMessage.(
> > HighPriorityAckedMessage.java:68)
> > at
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest.testDirectChannelSendAllRecipients(
> > GMSMembershipManagerJUnitTest.java:331)
> >
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest
> > > testDirectChannelSend FAILED
> > java.lang.ClassCastException:
> > org.apache.geode.distributed.internal.LonerDistributionManager cannot be
> > cast to org.apache.geode.distributed.internal.DistributionManager
> > at
> > org.apache.geode.distributed.internal.HighPriorityAckedMessage.(
> > HighPriorityAckedMessage.java:68)
> > at
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest.testDirectChannelSend(
> > GMSMembershipManagerJUnitTest.java:281)
> >
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest
> > > testDirectChannelSendFailureToOneRecipient FAILED
> > java.lang.ClassCastException:
> > org.apache.geode.distributed.internal.LonerDistributionManager cannot be
> > cast to org.apache.geode.distributed.internal.DistributionManager
> > at
> > org.apache.geode.distributed.internal.HighPriorityAckedMessage.(
> > HighPriorityAckedMessage.java:68)
> > at
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest.testDirectChannelSendFailureToOneRecipient(
> > GMSMembershipManagerJUnitTest.java:294)
> >
> > org.apache.geode.distributed.internal.membership.gms.mgr.
> > GMSMembershipManagerJUnitTest
> > > testDirectChannelSendFailureToAll FAILED
> > java.lang.ClassCastException:
> > org.apache.geode.distributed.internal.LonerDistributionManager cannot be
> > cast to org.apache.geode.distributed.internal.DistributionManager
> > at
> > org.apache.geode.distributed.internal.HighPriorityAckedMessage.(
> > 

[jira] [Resolved] (GEODE-2815) Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-2815.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Incorrect Error Message in REST API docs for {region}/{key} HTTP.GET command
> 
>
> Key: GEODE-2815
> URL: https://issues.apache.org/jira/browse/GEODE-2815
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Affects Versions: 1.1.1, 1.2.0
>Reporter: Michael Martell
>Assignee: Dave Barnes
>Priority: Minor
> Fix For: 1.2.0
>
>
> According to the docs at 
> http://gemfire.docs.pivotal.io/geode/rest_apps/get_region_key_data.html error 
> responses HTTP 400 and HTTP 404 appear to be very similar,
> # 400 - BAD REQUEST - Returned if the supplied key is not found in the region.
> # 404 - NOT FOUND - Returned if key does not exist for the region.
> The source code at PdxBasedCrudController.java:210 & 213 show that 404 
> actually means "Region does not exist", thus the documentation appears to be 
> incorrect. Other commands are correct in the docs showing 404 means region 
> does not exist.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59098: GEODE-2876: add logging to diagnose parser test failure in Jenkins

[Jinmei Liao]

> On May 9, 2017, 4 p.m., Ken Howe wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
> > Lines 52 (patched)
> > 
> >
> > This is probably OK since the change is presumably temporary, and will 
> > be removed after diagnosing the parsing test failures. However, for style 
> > consistentcy I would have added org.apache.logging.log4j.Logger as an 
> > import rather than specifying the full class path in the declaration.

because it has a name collision with the current java.*.util.Logger. After I 
removed the other loggers, this would automatcially be fixed by my IDEA.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59098/#review174330
---


On May 9, 2017, 3:32 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59098/
> ---
> 
> (Updated May 9, 2017, 3:32 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2876: add logging to diagnose test failure
> 
> another try to add parser logs using log4j. I have another set of changes 
> that would remove the other loggers in GfshParser. For now, they co-exist.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
>  20ae0226db45574028311493a07cdfcf9fbfb3f0 
> 
> 
> Diff: https://reviews.apache.org/r/59098/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 59098: GEODE-2876: add logging to diagnose parser test failure in Jenkins

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59098/#review174330
---


Ship it!





geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
Lines 52 (patched)


This is probably OK since the change is presumably temporary, and will be 
removed after diagnosing the parsing test failures. However, for style 
consistentcy I would have added org.apache.logging.log4j.Logger as an import 
rather than specifying the full class path in the declaration.


- Ken Howe


On May 9, 2017, 3:32 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59098/
> ---
> 
> (Updated May 9, 2017, 3:32 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2876: add logging to diagnose test failure
> 
> another try to add parser logs using log4j. I have another set of changes 
> that would remove the other loggers in GfshParser. For now, they co-exist.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
>  20ae0226db45574028311493a07cdfcf9fbfb3f0 
> 
> 
> Diff: https://reviews.apache.org/r/59098/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[jira] [Commented] (GEODE-2891) connect-timeout violation in C++ Native Client

[Bruce Schuchardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002921#comment-16002921
 ] 

Bruce Schuchardt commented on GEODE-2891:
-

If this is a C++ client issue the component should be "native client", not 
"client server"

> connect-timeout violation in C++ Native Client
> --
>
> Key: GEODE-2891
> URL: https://issues.apache.org/jira/browse/GEODE-2891
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Gregory Vortman
> Fix For: 1.1.1
>
> Attachments: gemfire-connect-timeout-violation.docx
>
>
> 1.C++ native client doesn’t honour read-timeout-milli-sec in a consistent 
> way while connecting to a server
> 2.The lock on the connection pool has a very high granularity. Even if 
> the client can’t connect to one server, all other threads which are working 
> with totally different servers get affected by it



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2875) shutdown is taking as long as 20 seconds

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002903#comment-16002903
 ] 

ASF subversion and git services commented on GEODE-2875:


Commit f0b99b48dca354cd80d0f8620031ecbe780e8fa6 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f0b99b4 ]

GEODE-2875 shutdown is taking as long as 20 seconds

The band-aid fix for this problem was to reduce the wait-time on joining a
thread sending shutdown messages.

This change set alters the membership manager, reviving the path of sending
certain messages like ShutdownMessage over UDP instead of TCP/IP stream
sockets.  This avenue doesn't block trying to form point-to-point
connections so the join() can complete in a short amount of time.


> shutdown is taking as long as 20 seconds
> 
>
> Key: GEODE-2875
> URL: https://issues.apache.org/jira/browse/GEODE-2875
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>
> Recent changes have introduced a bug where sometimes, particularly during 
> shutdown of a lot of servers, the shutdown process will stall for as long as 
> 20 seconds.  This appears to be due to changes that keep a membership 
> coordinator from sending out a new view during shutdown.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 59098: GEODE-2876: add logging to diagnose parser test failure in Jenkins

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59098/
---

Review request for geode.


Repository: geode


Description
---

GEODE-2876: add logging to diagnose test failure

another try to add parser logs using log4j. I have another set of changes that 
would remove the other loggers in GfshParser. For now, they co-exist.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java
 20ae0226db45574028311493a07cdfcf9fbfb3f0 


Diff: https://reviews.apache.org/r/59098/diff/1/


Testing
---

precheckin running


Thanks,

Jinmei Liao

[jira] [Assigned] (GEODE-2890) Incorrect debug log location in AbstractGatewaySenderEventProcessor.processQueue()

[Amey Barve (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve reassigned GEODE-2890:
-

Assignee: Amey Barve

> Incorrect debug log location in 
> AbstractGatewaySenderEventProcessor.processQueue() 
> ---
>
> Key: GEODE-2890
> URL: https://issues.apache.org/jira/browse/GEODE-2890
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Amey Barve
>
> The following code snippet in processQueue() for AEQ's appears to be outside 
> of an if condition where we check to see if the node is primary still or not. 
>  This line prints for every event and I believe it should be inside the 
> previous if condition. 
> {noformat}
> if (qpr != null) {
>BucketRegion bucket = qpr.getDataStore().getLocalBucketById(bucketId);
>if (bucket == null || !bucket.getBucketAdvisor().isPrimary()) {
>  event.setPossibleDuplicate(true);
> //I think the debug log should be placed here?
>}
> }
> if (isDebugEnabled) {
>   logger.debug( "Bucket id: {} is no longer primary on this node. The event 
> {} will be dispatched from this node with possibleDuplicate set to true.", 
> bucketId, event);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2897) Add a GitHub PR template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002108#comment-16002108
 ] 

ASF GitHub Bot commented on GEODE-2897:
---

GitHub user metatype opened a pull request:

https://github.com/apache/geode/pull/501

GEODE-2897 Add PR template for github



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/metatype/incubator-geode develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #501


commit 8308a384dcdcceb7ce91ceedc29c711bc75d24ce
Author: Anthony Baker 
Date:   2017-05-09T06:00:05Z

GEODE-2897 Add PR template for github




> Add a GitHub PR template
> 
>
> Key: GEODE-2897
> URL: https://issues.apache.org/jira/browse/GEODE-2897
> Project: Geode
>  Issue Type: Improvement
>  Components: github
>Reporter: Anthony Baker
>Assignee: Anthony Baker
>
> We should add a PR template to help guide new contributors.
> Here's a good example:
> https://github.com/apache/nifi/blob/master/.github/PULL_REQUEST_TEMPLATE.md



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #501: GEODE-2897 Add PR template for github

[metatype]

GitHub user metatype opened a pull request:

https://github.com/apache/geode/pull/501

GEODE-2897 Add PR template for github



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/metatype/incubator-geode develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #501


commit 8308a384dcdcceb7ce91ceedc29c711bc75d24ce
Author: Anthony Baker 
Date:   2017-05-09T06:00:05Z

GEODE-2897 Add PR template for github




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---