date:20170623

Build failed in Jenkins: Geode-nightly #875

2017-06-23 Thread Apache Jenkins Server

See 


Changes:

[klund] GEODE-3062: create new SecurityService after receiving cluster config

[bschuchardt] GEODE-3052 Restarting 2 locators together causes potential 
locator split

--
[...truncated 51.80 KB...]
:extensions/geode-modules-assembly:integrationTest UP-TO-DATE
:extensions/geode-modules-session:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:extensions/geode-modules-session:processTestResources
:extensions/geode-modules-session:testClasses
:extensions/geode-modules-session:checkMissedTests
:extensions/geode-modules-session:spotlessJavaCheck
:extensions/geode-modules-session:spotlessCheck
:extensions/geode-modules-session:test
:extensions/geode-modules-session:check
:extensions/geode-modules-session:build
:extensions/geode-modules-session:distributedTest
:extensions/geode-modules-session:integrationTest
:extensions/geode-modules-session-internal:javadocJar
:extensions/geode-modules-session-internal:sourcesJar
:extensions/geode-modules-session-internal:signArchives SKIPPED
:extensions/geode-modules-session-internal:assemble
:extensions/geode-modules-session-internal:compileTestJava UP-TO-DATE
:extensions/geode-modules-session-internal:processTestResources UP-TO-DATE
:extensions/geode-modules-session-internal:testClasses UP-TO-DATE
:extensions/geode-modules-session-internal:checkMissedTests UP-TO-DATE
:extensions/geode-modules-session-internal:spotlessJavaCheck
:extensions/geode-modules-session-internal:spotlessCheck
:extensions/geode-modules-session-internal:test UP-TO-DATE
:extensions/geode-modules-session-internal:check
:extensions/geode-modules-session-internal:build
:extensions/geode-modules-session-internal:distributedTest UP-TO-DATE
:extensions/geode-modules-session-internal:integrationTest UP-TO-DATE
:extensions/geode-modules-tomcat7:compileTestJava
:extensions/geode-modules-tomcat7:processTestResources
:extensions/geode-modules-tomcat7:testClasses
:extensions/geode-modules-tomcat7:checkMissedTests
:extensions/geode-modules-tomcat7:spotlessJavaCheck
:extensions/geode-modules-tomcat7:spotlessCheck
:extensions/geode-modules-tomcat7:test
:extensions/geode-modules-tomcat7:check
:extensions/geode-modules-tomcat7:build
:extensions/geode-modules-tomcat7:distributedTest
:extensions/geode-modules-tomcat7:integrationTest
:extensions/geode-modules-tomcat8:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:extensions/geode-modules-tomcat8:processTestResources
:extensions/geode-modules-tomcat8:testClasses
:extensions/geode-modules-tomcat8:checkMissedTests
:extensions/geode-modules-tomcat8:spotlessJavaCheck
:extensions/geode-modules-tomcat8:spotlessCheck
:extensions/geode-modules-tomcat8:test
:extensions/geode-modules-tomcat8:check
:extensions/geode-modules-tomcat8:build
:extensions/geode-modules-tomcat8:distributedTest
:extensions/geode-modules-tomcat8:integrationTest
:geode-assembly:compileJava UP-TO-DATE
:geode-assembly:processResources UP-TO-DATE
:geode-assembly:classes UP-TO-DATE
:geode-assembly:defaultCacheConfig
:geode-assembly:defaultDistributionConfig
:geode-assembly:depsJar
:geode-benchmarks:compileJava UP-TO-DATE
:geode-benchmarks:processResources UP-TO-DATE
:geode-benchmarks:classes UP-TO-DATE
:geode-cq:compileJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processResources
:geode-cq:classes
:geode-lucene:compileJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processResources
:geode-lucene:classes
:geode-old-client-support:compileJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processResources
:geode-old-client-support:classes
:geode-pulse:compileJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:copyGemFireVersionFile
:geode-pulse:processResources
:geode-pulse:classes
:geode-rebalancer:compileJava
:geode-rebalancer:processResources UP-TO-DATE
:geode-rebalancer:classes

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Udo Kohlmeyer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60394/#review178829
---


Ship it!




Ship It!

- Udo Kohlmeyer


On June 23, 2017, 5:52 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60394/
> ---
> 
> (Updated June 23, 2017, 5:52 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This is a merge of https://reviews.apache.org/r/60157 and 
> https://reviews.apache.org/r/60217/ , adding an integration test and a couple 
> small changes. It's probably easiest to read in comparison to those diffs, or 
> in the git history at https://github.com/apache/geode/pull/597 .
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
> 9a3241b05 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  2a8818cef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
>  e0b5ab8b6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  947b83652 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServiceLoadingFailureException.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
>  794c61097 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
>  28c6c8a69 
>   geode-protobuf/build.gradle PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java
>  PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java 
> PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java
>  PRE-CREATION 
>   
>

[GitHub] geode-native pull request #103: GEODE-2525: Removes MersenneTwister sources.

2017-06-23 Thread pivotal-jbarrett

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/103#discussion_r123866557
  
--- Diff: src/tests/cpp/fwklib/GsRandom.cpp ---
@@ -18,60 +18,16 @@
 #include "GsRandom.hpp"
 
 #include 
-#include 
-#include 
 
 namespace apache {
 namespace geode {
 namespace client {
 namespace testframework {
 
-using util::concurrent::spinlock_mutex;
-
-GsRandom *GsRandom::singleton = 0;
-MTRand GsRandom::gen;
-int32_t GsRandom::seedUsed = -101;
-spinlock_mutex GsRandom::lck;
-
-/**
-  * Creates a new random number generator using a single
-  * int32_t seed.
-  *
-  * @param   seed   the initial seed.
-  * @see java.util.Random#Random(int32_t)
-  */
-GsRandom *GsRandom::getInstance(int32_t seed) {
-  if (singleton == 0) {
-setInstance(seed);
-  } else {
-std::lock_guard guard(lck);
-setSeed(seed);
-  }
-  return singleton;
-}
-
-void GsRandom::setInstance(int32_t seed) {
-  std::lock_guard guard(lck);
-  if (singleton == 0) {
-singleton = new GsRandom();
-if (seed != -1) {
-  singleton->gen.seed(seed);
-} else {
-  singleton->gen.seed();
-}
-seedUsed = seed;
-  }
-}
-
-void GsRandom::setSeed(int32_t seed) {
-  if (seed != seedUsed) {
-if (seed != -1) {
-  singleton->gen.seed(seed);
-} else {
-  singleton->gen.seed();
-}
-seedUsed = seed;
-  }
+GsRandom ::getInstance() {
+  // C++11 initializes statics threads safe
--- End diff --

Yeah probably not. I can kill it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #103: GEODE-2525: Removes MersenneTwister sources.

2017-06-23 Thread dgkimura

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/103#discussion_r123862142
  
--- Diff: src/tests/cpp/fwklib/GsRandom.cpp ---
@@ -18,60 +18,16 @@
 #include "GsRandom.hpp"
 
 #include 
-#include 
-#include 
 
 namespace apache {
 namespace geode {
 namespace client {
 namespace testframework {
 
-using util::concurrent::spinlock_mutex;
-
-GsRandom *GsRandom::singleton = 0;
-MTRand GsRandom::gen;
-int32_t GsRandom::seedUsed = -101;
-spinlock_mutex GsRandom::lck;
-
-/**
-  * Creates a new random number generator using a single
-  * int32_t seed.
-  *
-  * @param   seed   the initial seed.
-  * @see java.util.Random#Random(int32_t)
-  */
-GsRandom *GsRandom::getInstance(int32_t seed) {
-  if (singleton == 0) {
-setInstance(seed);
-  } else {
-std::lock_guard guard(lck);
-setSeed(seed);
-  }
-  return singleton;
-}
-
-void GsRandom::setInstance(int32_t seed) {
-  std::lock_guard guard(lck);
-  if (singleton == 0) {
-singleton = new GsRandom();
-if (seed != -1) {
-  singleton->gen.seed(seed);
-} else {
-  singleton->gen.seed();
-}
-seedUsed = seed;
-  }
-}
-
-void GsRandom::setSeed(int32_t seed) {
-  if (seed != seedUsed) {
-if (seed != -1) {
-  singleton->gen.seed(seed);
-} else {
-  singleton->gen.seed();
-}
-seedUsed = seed;
-  }
+GsRandom ::getInstance() {
+  // C++11 initializes statics threads safe
--- End diff --

Nit, I don't this this comment adds much value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #599: GEODE-2819 Document http status code 414 for PUT

2017-06-23 Thread karensmolermiller

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/599

GEODE-2819 Document http status code 414 for PUT

- Include that 2000-byte size limits should work for
most components.

@jinmeiliao @kirklund @joeymcallister @davebarnes97 and all Geode devs
who know the REST API, please review.  I'd particularly like feedback on how
you would word the recommendation of a 2000-byte max size.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2819

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/599.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #599


commit d195f29dac8f39f14db50294b80da65f955a3398
Author: Karen Miller 
Date:   2017-06-23T23:25:32Z

GEODE-2819 Document http status code 414 for PUT

- Include that 2000-byte size limits should work for
most components.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: release 1.2

2017-06-23 Thread Bruce Schuchardt

There is a backward-compatibility problem that we need to address before 
the release can go out.  It prevents the subscription queues in a 1.2 
server from draining if the subscribed client is running an old version.


Barry and I are both working on this issue.  See 
https://issues.apache.org/jira/browse/GEODE-3072

[GitHub] geode-native pull request #103: GEODE-2525: Removes MersenneTwister sources.

2017-06-23 Thread pivotal-jbarrett

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/103

GEODE-2525: Removes MersenneTwister sources.

Can I get a quick review before I merge.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEODE-2525-cp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #103


commit 46a141ca58bdaba3e162dc3e0848a725183169d4
Author: Jacob Barrett 
Date:   2017-03-07T16:35:33Z

GEODE-2525: Removes MersenneTwister sources.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/596


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/596
  
Merged as 451d12e


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #594 was SUCCESSFUL (with 1868 tests)

2017-06-23 Thread Spring CI


---
Spring Data GemFire > Nightly-ApacheGeode > #594 was successful.
---
Scheduled
1870 tests in total.

https://build.spring.io/browse/SGF-NAG-594/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/596
  
Excepting one flaky test, precheckin is green through `14298a`.  Precheckin 
is currently very unhappy, though, and starting new test runs is not going well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #591: GEODE-3073: Renamed OrderByComparatorUnmapped to Or...

2017-06-23 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/591#discussion_r123854670
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java
 ---
@@ -925,79 +917,89 @@ private SelectResults 
applyProjectionOnCollection(SelectResults resultSet,
 
   private SelectResults prepareEmptyResultSet(ExecutionContext context, 
boolean ignoreOrderBy)
   throws TypeMismatchException, AmbiguousNameException {
-// if no projection attributes or '*'as projection attribute
-// & more than one/RunTimeIterator then create a StrcutSet.
-// If attribute is null or '*' & only one RuntimeIterator then create a
-// ResultSet.
-// If single attribute is present without alias name , then create
-// ResultSet
-// Else if more than on attribute or single attribute with alias is
-// present then return a StrcutSet
-// create StructSet which will contain root objects of all iterators in
-// from clause
+// If no projection attributes or '*' as projection attribute & more 
than one/RunTimeIterator
+// then create a StructSet.
+// If attribute is null or '*' & only one RuntimeIterator then create 
a ResultSet.
+// If single attribute is present without alias name, then create 
ResultSet.
+// Else if more than on attribute or single attribute with alias is 
present then return a
+// StructSet.
+// Create StructSet which will contain root objects of all iterators 
in from clause.
 
 ObjectType elementType = this.cachedElementTypeForOrderBy != null
 ? this.cachedElementTypeForOrderBy : prepareResultType(context);
 SelectResults results;
-if (this.distinct || !this.count) {
-  if (this.orderByAttrs != null) {
-boolean nullValuesAtStart = !((CompiledSortCriterion) 
orderByAttrs.get(0)).getCriterion();
-if (elementType.isStructType()) {
-  if (ignoreOrderBy) {
-results = this.distinct ? new LinkedStructSet((StructTypeImpl) 
elementType)
-: new SortedResultsBag(elementType, nullValuesAtStart);
 
-  } else {
-OrderByComparator comparator = this.hasUnmappedOrderByCols
-? new OrderByComparatorUnmapped(this.orderByAttrs, 
(StructTypeImpl) elementType,
-context)
-: new OrderByComparator(this.orderByAttrs, 
(StructTypeImpl) elementType, context);
-results = this.distinct ? new SortedStructSet(comparator, 
(StructTypeImpl) elementType)
-: new SortedStructBag(comparator, (StructType) 
elementType, nullValuesAtStart);
+if (!this.distinct && this.count) {
+  // Shobhit: If it's a 'COUNT' query and no End processing required 
Like for 'DISTINCT'
+  // we can directly keep count in ResultSet and ResultBag is good 
enough for that.
+  countStartQueryResult = 0;
+  return new ResultsBag(new ObjectTypeImpl(Integer.class), 1, 
context.getCachePerfStats());
+}
 
-  }
-} else {
-  if (ignoreOrderBy) {
-results =
-this.distinct ? new LinkedResultSet() : new 
SortedResultsBag(nullValuesAtStart);
+// Potential edge-case: Could this be non-null but empty?
+boolean nullValuesAtStart = orderByAttrs != null && 
!orderByAttrs.get(0).getCriterion();
+OrderByComparator comparator;
+switch (convertToStringCase(elementType, ignoreOrderBy)) {
+  case "UNORDERED DISTINCT STRUCT":
+return new StructSet((StructType) elementType);
+  case "UNORDERED DISTINCT RESULTS":
+return new ResultsSet(elementType);
+  case "UNORDERED INDISTINCT STRUCT":
+return new StructBag((StructType) elementType, 
context.getCachePerfStats());
+  case "UNORDERED INDISTINCT RESULTS":
+return new ResultsBag(elementType, context.getCachePerfStats());
+
+  case "ORDERED DISTINCT STRUCT IGNORED":
+return new LinkedStructSet((StructTypeImpl) elementType);
+  case "ORDERED INDISTINCT STRUCT IGNORED":
+return new SortedResultsBag(elementType, nullValuesAtStart);
+  case "ORDERED DISTINCT STRUCT UNIGNORED":
--- End diff --

Good suggestion - thanks! @PurelyApplied and I worked together to get rid 
of the Strings, and we're now using enums. You should be able to see these 
changes starting at around line 920 of `CompiledSelect` of the latest commit. 
We're using a naming convention that I think follows your suggestion (instead 
of `UNORDERED_DISTINCT_STRUCT_IGNORED`, for example, we just use 
`UNORDERED_DISTINCT_STRUCT`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/596
  
+1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Hitesh Khamesra



> On June 23, 2017, 6:38 p.m., Udo Kohlmeyer wrote:
> >

Will fix this latter on. But merging the code now.


- Hitesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60394/#review178803
---


On June 23, 2017, 5:52 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60394/
> ---
> 
> (Updated June 23, 2017, 5:52 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This is a merge of https://reviews.apache.org/r/60157 and 
> https://reviews.apache.org/r/60217/ , adding an integration test and a couple 
> small changes. It's probably easiest to read in comparison to those diffs, or 
> in the git history at https://github.com/apache/geode/pull/597 .
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
> 9a3241b05 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  2a8818cef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
>  e0b5ab8b6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  947b83652 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServiceLoadingFailureException.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
>  794c61097 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
>  28c6c8a69 
>   geode-protobuf/build.gradle PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java
>  PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java 
> PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java
>

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-23 Thread jinmeiliao

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/589#discussion_r123845237
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
 ---
@@ -37,20 +38,25 @@
 
   private String functionId = null;
 
+  private Cache cache = null;
+
   private ResultSender resultSender = null;
 
   private final boolean isPossDup;
 
   public FunctionContextImpl(final String functionId, final Object args,
   ResultSender resultSender) {
-this.functionId = functionId;
-this.args = args;
-this.resultSender = resultSender;
-this.isPossDup = false;
+this(null, functionId, args, resultSender, false);
+  }
+
+  public FunctionContextImpl(final Cache cache, final String functionId, 
final Object args,
+  ResultSender resultSender) {
+this(cache, functionId, args, resultSender, false);
   }
 
-  public FunctionContextImpl(final String functionId, final Object args, 
ResultSender resultSender,
-  boolean isPossibleDuplicate) {
+  public FunctionContextImpl(final Cache cache, final String functionId, 
final Object args,
+  ResultSender resultSender, boolean isPossibleDuplicate) {
--- End diff --

I agree, once we get rid of that static gemfire cache function, these 
changes will be necessary. better start making the changes somewhere. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-23 Thread Ken Howe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60348/#review178811
---


Ship it!




LGTM


geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
Line 103 (original), 102 (patched)


Yeah, That's even better than my suggestion!


- Ken Howe


On June 23, 2017, 6:01 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60348/
> ---
> 
> (Updated June 23, 2017, 6:01 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - GfshRule writes via a logger rather than StdOut.  This will make it no 
> longer clutter precheckin runs or the nightly build.
> - Introduce ProcessLogger to capture output from the Gfsh JVM so that tests 
> can assert against the output.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 39bb542 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
>  82ee240 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshExecution.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
>  8109377 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
>  3ee1402 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/StreamGobbler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/CommandStringBuilder.java
>  cfb8a24 
> 
> 
> Diff: https://reviews.apache.org/r/60348/diff/3/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-23 Thread Emily Yeh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60348/#review178810
---


Ship it!




Ship It!

- Emily Yeh


On June 23, 2017, 6:01 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60348/
> ---
> 
> (Updated June 23, 2017, 6:01 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - GfshRule writes via a logger rather than StdOut.  This will make it no 
> longer clutter precheckin runs or the nightly build.
> - Introduce ProcessLogger to capture output from the Gfsh JVM so that tests 
> can assert against the output.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 39bb542 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
>  82ee240 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshExecution.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
>  8109377 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
>  3ee1402 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/StreamGobbler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/CommandStringBuilder.java
>  cfb8a24 
> 
> 
> Diff: https://reviews.apache.org/r/60348/diff/3/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/596#discussion_r123832520
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java
 ---
@@ -109,12 +107,10 @@ public Result listClient() {
   }
 
   String memberSeparator = ";  ";
-  Iterator> it = 
clientServerMap.entrySet().iterator();
 
-  while (it.hasNext()) {
-Map.Entry pairs = (Map.Entry) it.next();
-String client = (String) pairs.getKey();
-List servers = (List) pairs.getValue();
+  for (Entry pairs : clientServerMap.entrySet()) 
{
+String client = pairs.getKey();
+List servers = pairs.getValue();
 StringBuilder serverListForClient = new StringBuilder();
--- End diff --

Added in commit `b4bb08b`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/596#discussion_r123832527
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
 ---
@@ -130,31 +125,8 @@ public Result executeFunction(
 return result;
   }
 
-  if (onRegion != null && onMember != null && onGroups != null) {
-ErrorResultData errorResultData =
-
ResultBuilder.createErrorResultData().setErrorCode(ResultBuilder.ERRORCODE_DEFAULT)
-.addLine(CliStrings.EXECUTE_FUNCTION__MSG__OPTIONS);
-result = ResultBuilder.buildResult(errorResultData);
-return result;
-  } else if (onRegion != null && onMember != null) {
-ErrorResultData errorResultData =
-
ResultBuilder.createErrorResultData().setErrorCode(ResultBuilder.ERRORCODE_DEFAULT)
-.addLine(CliStrings.EXECUTE_FUNCTION__MSG__OPTIONS);
-result = ResultBuilder.buildResult(errorResultData);
-return result;
-  } else if (onMember != null && onGroups != null) {
-ErrorResultData errorResultData =
-
ResultBuilder.createErrorResultData().setErrorCode(ResultBuilder.ERRORCODE_DEFAULT)
-.addLine(CliStrings.EXECUTE_FUNCTION__MSG__OPTIONS);
-result = ResultBuilder.buildResult(errorResultData);
-return result;
-  } else if (onRegion != null && onGroups != null) {
-ErrorResultData errorResultData =
-
ResultBuilder.createErrorResultData().setErrorCode(ResultBuilder.ERRORCODE_DEFAULT)
-.addLine(CliStrings.EXECUTE_FUNCTION__MSG__OPTIONS);
-result = ResultBuilder.buildResult(errorResultData);
-return result;
-  } else if (onRegion != null && onMember != null && onGroups != null) 
{
+  if (isMoreThanOneIsTrue(onRegion != null, onMember != null, onGroups 
!= null)) {
--- End diff --

Good call.  Added in commit `b4bb08b`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/596#discussion_r123830383
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBean.java
 ---
@@ -148,7 +148,12 @@ public long getInitialImageTime() {
 
   @Override
   public int getInitialImagesInProgres() {
--- End diff --

This is our internal implementation of 
`GEODE/geode-core/src/main/java/org/apache/geode/management/MemberMXBean.java`. 
 I was hesitant to remove the typo'd version from the public-facing interface 
without at least one version with it `@Deprecated`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-23 Thread jhuynh1

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/589#discussion_r123830138
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
 ---
@@ -37,20 +38,25 @@
 
   private String functionId = null;
 
+  private Cache cache = null;
+
   private ResultSender resultSender = null;
 
   private final boolean isPossDup;
 
   public FunctionContextImpl(final String functionId, final Object args,
   ResultSender resultSender) {
-this.functionId = functionId;
-this.args = args;
-this.resultSender = resultSender;
-this.isPossDup = false;
+this(null, functionId, args, resultSender, false);
+  }
+
+  public FunctionContextImpl(final Cache cache, final String functionId, 
final Object args,
+  ResultSender resultSender) {
+this(cache, functionId, args, resultSender, false);
   }
 
-  public FunctionContextImpl(final String functionId, final Object args, 
ResultSender resultSender,
-  boolean isPossibleDuplicate) {
+  public FunctionContextImpl(final Cache cache, final String functionId, 
final Object args,
+  ResultSender resultSender, boolean isPossibleDuplicate) {
--- End diff --

Sure we can't remove GemFireCacheImpl.getInstance now and we might not be 
able to ever... but in order for it to be possible, this change would need to 
be made anyways if I am not mistaken... not making these constructor changes 
will hinder the effort later.  Since the work is already done, was there a 
reason why we didn't want to make these signature changes?  Is it too 
cumbersome with the number of variables being passed in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/596#discussion_r123829882
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
 ---
@@ -57,7 +56,48 @@ public void setUp() throws Exception {
   }
 
   @Test
-  @ConnectionConfiguration(user = "data-admin", password = "1234567")
+  @ConnectionConfiguration(user = "clusterRead", password = "clusterRead")
+  public void testClusterReadAccess() throws Exception {
+assertThatThrownBy(() -> 
bean.flush()).hasMessageContaining(TestCommand.diskManage.toString());
--- End diff --

Thank you regex.  Done and done in commit `97de2f3`.
For what it's worth / future reference, `s/\(\) -> 
(\w+)\.(\w+)\(\)\)/$1::$2\)` would make 3,232 test replacements, but hits no 
production files, so that's nice.  Maybe something to add to spotless down the 
line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/596#discussion_r123822645
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
 ---
@@ -130,31 +125,8 @@ public Result executeFunction(
 return result;
   }
 
-  if (onRegion != null && onMember != null && onGroups != null) {
-ErrorResultData errorResultData =
-
ResultBuilder.createErrorResultData().setErrorCode(ResultBuilder.ERRORCODE_DEFAULT)
-.addLine(CliStrings.EXECUTE_FUNCTION__MSG__OPTIONS);
-result = ResultBuilder.buildResult(errorResultData);
-return result;
-  } else if (onRegion != null && onMember != null) {
-ErrorResultData errorResultData =
-
ResultBuilder.createErrorResultData().setErrorCode(ResultBuilder.ERRORCODE_DEFAULT)
-.addLine(CliStrings.EXECUTE_FUNCTION__MSG__OPTIONS);
-result = ResultBuilder.buildResult(errorResultData);
-return result;
-  } else if (onMember != null && onGroups != null) {
-ErrorResultData errorResultData =
-
ResultBuilder.createErrorResultData().setErrorCode(ResultBuilder.ERRORCODE_DEFAULT)
-.addLine(CliStrings.EXECUTE_FUNCTION__MSG__OPTIONS);
-result = ResultBuilder.buildResult(errorResultData);
-return result;
-  } else if (onRegion != null && onGroups != null) {
-ErrorResultData errorResultData =
-
ResultBuilder.createErrorResultData().setErrorCode(ResultBuilder.ERRORCODE_DEFAULT)
-.addLine(CliStrings.EXECUTE_FUNCTION__MSG__OPTIONS);
-result = ResultBuilder.buildResult(errorResultData);
-return result;
-  } else if (onRegion != null && onMember != null && onGroups != null) 
{
+  if (isMoreThanOneIsTrue(onRegion != null, onMember != null, onGroups 
!= null)) {
--- End diff --

I like the readability introduced by this `isMoreThanOneIsTrue` method.  It 
might make sense to take the abstraction one step further: 
```
if (isMoreThanOneNonNull(onRegion, onMember, onGroup) {
```

```
  private boolean isMoreThanOneNonNull(Object... values) {
return Stream.of(values).filter(Objects::nonNull).count() > 1;
  }
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/596#discussion_r123820699
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java
 ---
@@ -109,12 +107,10 @@ public Result listClient() {
   }
 
   String memberSeparator = ";  ";
-  Iterator> it = 
clientServerMap.entrySet().iterator();
 
-  while (it.hasNext()) {
-Map.Entry pairs = (Map.Entry) it.next();
-String client = (String) pairs.getKey();
-List servers = (List) pairs.getValue();
+  for (Entry pairs : clientServerMap.entrySet()) 
{
+String client = pairs.getKey();
+List servers = pairs.getValue();
 StringBuilder serverListForClient = new StringBuilder();
--- End diff --

Since we're already cleaning up this section of the code, it might be worth 
considering replacing 114-123 with a one liner: 

```
String serverListForClient = 
servers.stream().collect(Collectors.joining(memberSeparator));
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-23 Thread Jinmei Liao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60348/#review178805
---


Ship it!




Ship It!

- Jinmei Liao


On June 23, 2017, 6:01 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60348/
> ---
> 
> (Updated June 23, 2017, 6:01 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - GfshRule writes via a logger rather than StdOut.  This will make it no 
> longer clutter precheckin runs or the nightly build.
> - Introduce ProcessLogger to capture output from the Gfsh JVM so that tests 
> can assert against the output.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 39bb542 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
>  82ee240 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshExecution.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
>  8109377 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
>  3ee1402 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/StreamGobbler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/CommandStringBuilder.java
>  cfb8a24 
> 
> 
> Diff: https://reviews.apache.org/r/60348/diff/3/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/596#discussion_r123819260
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBean.java
 ---
@@ -148,7 +148,12 @@ public long getInitialImageTime() {
 
   @Override
   public int getInitialImagesInProgres() {
--- End diff --

We ended up with two copies of this method, one with the correct spelling 
and one with the incorrect spelling.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/596#discussion_r123818520
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
 ---
@@ -57,7 +56,48 @@ public void setUp() throws Exception {
   }
 
   @Test
-  @ConnectionConfiguration(user = "data-admin", password = "1234567")
+  @ConnectionConfiguration(user = "clusterRead", password = "clusterRead")
+  public void testClusterReadAccess() throws Exception {
+assertThatThrownBy(() -> 
bean.flush()).hasMessageContaining(TestCommand.diskManage.toString());
--- End diff --

A bunch of tests in this change set can be simplified by using method 
references in place of lambda expressions (when the lambdas take no parameters 
and invoke a no-arg method on the target):
```

assertThatThrownBy(bean::flush).hasMessageContaining(TestCommand.diskManage.toString());
```
in place of 
```
assertThatThrownBy(() -> 
bean.flush()).hasMessageContaining(TestCommand.diskManage.toString());
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-23 Thread jinmeiliao

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/589#discussion_r123818259
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
 ---
@@ -37,20 +38,25 @@
 
   private String functionId = null;
 
+  private Cache cache = null;
+
   private ResultSender resultSender = null;
 
   private final boolean isPossDup;
 
   public FunctionContextImpl(final String functionId, final Object args,
   ResultSender resultSender) {
-this.functionId = functionId;
-this.args = args;
-this.resultSender = resultSender;
-this.isPossDup = false;
+this(null, functionId, args, resultSender, false);
+  }
+
+  public FunctionContextImpl(final Cache cache, final String functionId, 
final Object args,
+  ResultSender resultSender) {
+this(cache, functionId, args, resultSender, false);
   }
 
-  public FunctionContextImpl(final String functionId, final Object args, 
ResultSender resultSender,
-  boolean isPossibleDuplicate) {
+  public FunctionContextImpl(final Cache cache, final String functionId, 
final Object args,
+  ResultSender resultSender, boolean isPossibleDuplicate) {
--- End diff --

we can't remove GemFireCacheImpl.getInstance() for now, that's the way we 
are getting the instance to create the FunctionContext in the first place, why 
not just use it to avoid making more constructor changes. This just my 2 cents. 
I can go either way on this though.

The problem this changeset is trying to solve is that if external developer 
can not use GemfireCacheImpl.getInstance() to get the cache since it's an 
internal api, they can only use CacheFactory.getAnyIntance() and that's a 
synchronized static, so it requires a lock on CachFactory which creates some 
deadlocks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Udo Kohlmeyer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60394/#review178803
---




geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
Line 1428 (original), 1452 (patched)


Any chance that we can move this switch statement into its own method?


- Udo Kohlmeyer


On June 23, 2017, 5:52 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60394/
> ---
> 
> (Updated June 23, 2017, 5:52 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This is a merge of https://reviews.apache.org/r/60157 and 
> https://reviews.apache.org/r/60217/ , adding an integration test and a couple 
> small changes. It's probably easiest to read in comparison to those diffs, or 
> in the git history at https://github.com/apache/geode/pull/597 .
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
> 9a3241b05 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  2a8818cef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
>  e0b5ab8b6 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  947b83652 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServiceLoadingFailureException.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
>  794c61097 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
>  28c6c8a69 
>   geode-protobuf/build.gradle PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java
>  PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java 
> PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java
>  PRE-CREATION 
>   
>

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/596#discussion_r123817037
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/CacheServerMXBean.java ---
@@ -60,48 +61,48 @@
   /**
* Returns the port on which this CacheServer listens for clients.
*/
-  public int getPort();
+  int getPort();
--- End diff --

I think this should be ok actually, since CacheServerMXBean is an interface 
and not a class.  (So all methods will be public by default.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-23 Thread Jared Stewart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60348/
---

(Updated June 23, 2017, 6:01 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Made it easier for tests to grab the output from GfshRule


Repository: geode


Description
---

- GfshRule writes via a logger rather than StdOut.  This will make it no longer 
clutter precheckin runs or the nightly build.
- Introduce ProcessLogger to capture output from the Gfsh JVM so that tests can 
assert against the output.


Diffs (updated)
-

  geode-assembly/build.gradle 39bb542 
  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
 82ee240 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshExecution.java
 PRE-CREATION 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
 8109377 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
 3ee1402 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
 PRE-CREATION 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/StreamGobbler.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/CommandStringBuilder.java
 cfb8a24 


Diff: https://reviews.apache.org/r/60348/diff/3/

Changes: https://reviews.apache.org/r/60348/diff/2-3/


Testing
---

Precheckin running


Thanks,

Jared Stewart

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Galen O'Sullivan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60394/
---

(Updated June 23, 2017, 5:52 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh Khamesra, 
Udo Kohlmeyer, and Brian Rowe.


Repository: geode


Description (updated)
---

This is a merge of https://reviews.apache.org/r/60157 and 
https://reviews.apache.org/r/60217/ , adding an integration test and a couple 
small changes. It's probably easiest to read in comparison to those diffs, or 
in the git history at https://github.com/apache/geode/pull/597 .


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
9a3241b05 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 2a8818cef 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
 e0b5ab8b6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 947b83652 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServiceLoadingFailureException.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
 794c61097 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
 28c6c8a69 
  geode-protobuf/build.gradle PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java
 PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java 
PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/FloatCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/IntCodec.java 
PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/JSONCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/LongCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ShortCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/StringCodec.java
 PRE-CREATION

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Galen O'Sullivan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60394/
---

(Updated June 23, 2017, 5:50 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh Khamesra, 
Udo Kohlmeyer, and Brian Rowe.


Summary (updated)
-

GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.


Repository: geode


Description
---

This is a merge of https://reviews.apache.org/r/60157 and 
https://reviews.apache.org/r/60217/ , adding an integration test and a couple 
small changes.


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
9a3241b05 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 2a8818cef 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
 e0b5ab8b6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 947b83652 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServiceLoadingFailureException.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
 794c61097 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
 28c6c8a69 
  geode-protobuf/build.gradle PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java
 PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java 
PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/FloatCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/IntCodec.java 
PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/JSONCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/LongCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ShortCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/StringCodec.java
 PRE-CREATION

Review Request 60394: GEODE-3075 and GEODE-2995: merg

2017-06-23 Thread Galen O'Sullivan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60394/
---

Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh Khamesra, 
Udo Kohlmeyer, and Brian Rowe.


Repository: geode


Description
---

This is a merge of https://reviews.apache.org/r/60157 and 
https://reviews.apache.org/r/60217/ , adding an integration test and a couple 
small changes.


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 
9a3241b05 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 2a8818cef 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
 e0b5ab8b6 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 947b83652 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServiceLoadingFailureException.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
 794c61097 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 
6a6e0c1f3 
  geode-protobuf/build.gradle PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java
 PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java 
PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/FloatCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/IntCodec.java 
PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/JSONCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/LongCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ShortCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/codec/StringCodec.java
 PRE-CREATION 
  
geode-protobuf/src/main/java/org/apache/geode/serialization/exception/TypeEncodingException.java
 PRE-CREATION

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

2017-06-23 Thread YehEmily

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/598

GEODE-2818: Completing implementation/testing of aliases

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-2818)

Changes were previously implemented to allow users to use either `--group` 
or `--groups` and `--member` or `--members` and `--jar` or `--jars` when 
specifying parameters for certain commands. @sbawaska found that these changes 
weren't fully implemented for some commands, though, so this PR aims to fix 
this. Two tests were also implemented to cover all related changes:

- `OptionAliasesIntegrationTest.java` uses `GfshRule` to show that these 
changes work in the environment (gfsh). Note that this test is not completed 
yet, as some commands were impractical to implement (since they required 
setting up certain permissions, etc.). The test could also be improved by not 
only running the commands, but also checking the contents of the logs written 
up by the `GfshRule`, although these logs aren't accessible yet (changes 
pending via @jaredjstewart). I'll probably file a JIRA ticket to keep track of 
these improvements to this test.
- `OptionAliasesParsingTest.java` shows that all the commands that accept 
either `--group` or `--groups` and `--member` or `--members` and `--jar` or 
`--jars` are parsed correctly.

Some imports were also reordered in the process of implementing changes and 
writing tests.

**_Precheckin status: pending_**

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-2818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #598


commit 5ccd1ac9ea3208540c52241ccae9e7f1d1fd09fe
Author: YehEmily 
Date:   2017-06-20T19:43:07Z

GEODE-2818: Making "groups" a valid option when starting locators or 
servers and adding a comprehensive test to cover changes.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #597: Client protocol with develop, gated by a feature flag.

2017-06-23 Thread galen-pivotal

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/597
  
Added to excluded-classes.txt, hopefully this fixes it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #875

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

[GitHub] geode-native pull request #103: GEODE-2525: Removes MersenneTwister sources.

[GitHub] geode-native pull request #103: GEODE-2525: Removes MersenneTwister sources.

[GitHub] geode pull request #599: GEODE-2819 Document http status code 414 for PUT

Re: release 1.2

[GitHub] geode-native pull request #103: GEODE-2525: Removes MersenneTwister sources.

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #594 was SUCCESSFUL (with 1868 tests)

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[GitHub] geode pull request #591: GEODE-3073: Renamed OrderByComparatorUnmapped to Or...

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

Review Request 60394: GEODE-3075 and GEODE-2995: merg

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

[GitHub] geode issue #597: Client protocol with develop, gated by a feature flag.

36 matches

Site Navigation

Mail list logo

Footer information