Re: [VOTE] Apache Geode 1.7.0 RC1

[Anthony Baker]

+1

Reviewed LICENSE and NOTICE*
Verified signatures and hashes
Checked source releases for binaries
Verified that source releases build successfully
Confirmed that geode-examples run correctly
Verified GitHub tag

Anthony

* I found a few places that need copyright date updates and will tweak those 
for the next release


> On Sep 17, 2018, at 5:06 PM, Nabarun Nag  wrote:
> 
> *DEADLINE :* Kindly complete your vote by Wednesday, 19th September 2018.
> End of day PDT.
> 
> Following checks completed:
> 
> - checked signatures
> - checked sha’s
> - builds from source
> - run gfsh - start locator, server - create region - do put and get -
> execute OQL query
> - examples run cleanly
> 
> @John Blum  , I was looking into the mail chain for
> Apache Geode 1.5.0 RC and I saw that you had some concerns regarding SD
> Geode's behavior with the changes made to Log4j in Apache Geode. In this
> release, too we have made some upgrades to log4j and we would to hear your
> feedback / get a green light on these changes.
> 
> Regards
> Nabarun Nag
> 
> 
> 
> On Fri, Sep 14, 2018 at 2:50 PM Nabarun Nag  wrote:
> 
>> Correction :
>> Please note that we are voting upon the source tags: rel/v1.7.0.RC1
>> 
>> On Fri, Sep 14, 2018 at 2:49 PM Nabarun Nag  wrote:
>> 
>>> This is the first release candidate for Apache Geode, version 1.7.0.
>>> Thanks to all the community members for their contributions to this
>>> release!
>>> 
>>> Please do review and give your feedback.
>>> 
>>> It resolves 351 issues on Apache Geode JIRA system. Release notes can be
>>> found at:
>>> https://cwiki.apache.org/confluence/display/GEODE/
>>> Release+Notes#ReleaseNotes-1.7.0
>>> 
>>> 
>>> Please note that we are voting upon the source tags: rel/v1.6.0.RC1
>>> Apache Geode:
>>> https://github.com/apache/geode/tree/rel/v1.7.0.RC1
>>> Apache Geode examples:
>>> https://github.com/apache/geode-examples/tree/rel/v1.7.0.RC1
>>> 
>>> Commit ID:
>>> Apache Geode:
>>> f9abdeb489c9278f96afd37f72a7a9d14cb0f154
>>> Apache Geode Examples:
>>> 9dca29c7c10fa8d44abc893271420476cfc0808f
>>> 
>>> 
>>> Source and binary files:
>>> https://dist.apache.org/repos/dist/dev/geode/1.7.0.RC1/
>>> 
>>> Maven staging repo:
>>> https://repository.apache.org/content/repositories/orgapachegeode-1042
>>> 
>>> Geode's KEYS file containing PGP keys we use to sign the release:
>>> https://github.com/apache/geode/blob/develop/KEYS
>>> 
>>> Signed the release with fingerprint:
>>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
>>> CE6CD0A89480B1B9FCB98699274C66710770C135
>>> 
>>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
>>> 
>>> I do apologize if there was an oversight.
>>> 
>>> Regards
>>> Nabarun Nag
>>> 
>> 

Re: [VOTE] Apache Geode 1.7.0 RC1

[Nabarun Nag]

*DEADLINE :* Kindly complete your vote by Wednesday, 19th September 2018.
End of day PDT.

Following checks completed:

- checked signatures
- checked sha’s
- builds from source
- run gfsh - start locator, server - create region - do put and get -
execute OQL query
- examples run cleanly

 @John Blum  , I was looking into the mail chain for
Apache Geode 1.5.0 RC and I saw that you had some concerns regarding SD
Geode's behavior with the changes made to Log4j in Apache Geode. In this
release, too we have made some upgrades to log4j and we would to hear your
feedback / get a green light on these changes.

Regards
Nabarun Nag



On Fri, Sep 14, 2018 at 2:50 PM Nabarun Nag  wrote:

> Correction :
> Please note that we are voting upon the source tags: rel/v1.7.0.RC1
>
> On Fri, Sep 14, 2018 at 2:49 PM Nabarun Nag  wrote:
>
>> This is the first release candidate for Apache Geode, version 1.7.0.
>> Thanks to all the community members for their contributions to this
>> release!
>>
>> Please do review and give your feedback.
>>
>> It resolves 351 issues on Apache Geode JIRA system. Release notes can be
>> found at:
>> https://cwiki.apache.org/confluence/display/GEODE/
>> Release+Notes#ReleaseNotes-1.7.0
>>
>>
>> Please note that we are voting upon the source tags: rel/v1.6.0.RC1
>> Apache Geode:
>> https://github.com/apache/geode/tree/rel/v1.7.0.RC1
>> Apache Geode examples:
>> https://github.com/apache/geode-examples/tree/rel/v1.7.0.RC1
>>
>> Commit ID:
>> Apache Geode:
>> f9abdeb489c9278f96afd37f72a7a9d14cb0f154
>> Apache Geode Examples:
>> 9dca29c7c10fa8d44abc893271420476cfc0808f
>>
>>
>> Source and binary files:
>> https://dist.apache.org/repos/dist/dev/geode/1.7.0.RC1/
>>
>> Maven staging repo:
>> https://repository.apache.org/content/repositories/orgapachegeode-1042
>>
>> Geode's KEYS file containing PGP keys we use to sign the release:
>> https://github.com/apache/geode/blob/develop/KEYS
>>
>> Signed the release with fingerprint:
>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
>> CE6CD0A89480B1B9FCB98699274C66710770C135
>>
>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
>>
>> I do apologize if there was an oversight.
>>
>> Regards
>> Nabarun Nag
>>
>

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1043 was SUCCESSFUL (with 2456 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #1043 was successful.
---
Scheduled
2458 tests in total.

https://build.spring.io/browse/SGF-NAG-1043/





--
This message is automatically generated by Atlassian Bamboo

Running tests with a different JVM (eg Java 10)

[Dan Smith]

FYI, you compile geode against one version of java and test using a
different version of java with the testJVM flag. For example, this would
compile with the default JDK on your machine and run tests with java 9.

./gradlew
-PtestJVM=/Library/Java/JavaVirtualMachines/jdk-9.0.4.jdk/Contents/Home/
test

-Dan

Re: Updating instructions to run tests

[Galen O'Sullivan]

+1 to separate files. It's probably worth referencing the other files in
the README.

On Mon, Sep 17, 2018 at 12:16 PM, Jacob Barrett  wrote:

> I prefer creating a TESTING.md to create a clear physical grouping around
> the subject. I like my read me files like my source, small and well
> organized.
>
> > On Sep 17, 2018, at 12:00 PM, Ryan McMahon 
> wrote:
> >
> > Hi all,
> >
> > I recently added instructions on how to setup Geode in IntelliJ
> >  e437f885ab>,
> > and as part of that effort realized there is some duplication between the
> > Wiki [1
> >  Getting+Started+for+Geode+Developers>
> > , 2
> >  Building+and+Running+Geode+from+Source>]
> > and the BUILDING.md
> > .
> >
> > I am removing this duplication and noticed that we have some outdated
> > instructions on how to run tests in those Wiki sections.  Before I update
> > these instructions, I wanted to propose we move these instructions to
> > somewhere in the repo.  Here are some options:
> >
> > 1. Add a TESTING.md with instructions on running tests and link to it
> from
> > the Wiki
> > 2. Add instructions on running tests to the existing BUILDING.md
> > 3. Put all build and test instructions in the README.md, and get rid of
> > BUILDING.md.  I mention this option because this is what Apache Spark and
> > Apache Kafka do.  This might be hard for us because we have examples and
> > other content in the README.md already, so it would become quite bloated.
> > 4. Leave the testing instructions where they are in the Wiki but update
> > them to be accurate
> >
> > I would vote for #1.  I am open to other options as well if none of these
> > seem ideal.
> >
> > Thanks,
> > Ryan
>

Re: Updating instructions to run tests

[Jacob Barrett]

I prefer creating a TESTING.md to create a clear physical grouping around the 
subject. I like my read me files like my source, small and well organized.

> On Sep 17, 2018, at 12:00 PM, Ryan McMahon  wrote:
> 
> Hi all,
> 
> I recently added instructions on how to setup Geode in IntelliJ
> ,
> and as part of that effort realized there is some duplication between the
> Wiki [1
> 
> , 2
> ]
> and the BUILDING.md
> .
> 
> I am removing this duplication and noticed that we have some outdated
> instructions on how to run tests in those Wiki sections.  Before I update
> these instructions, I wanted to propose we move these instructions to
> somewhere in the repo.  Here are some options:
> 
> 1. Add a TESTING.md with instructions on running tests and link to it from
> the Wiki
> 2. Add instructions on running tests to the existing BUILDING.md
> 3. Put all build and test instructions in the README.md, and get rid of
> BUILDING.md.  I mention this option because this is what Apache Spark and
> Apache Kafka do.  This might be hard for us because we have examples and
> other content in the README.md already, so it would become quite bloated.
> 4. Leave the testing instructions where they are in the Wiki but update
> them to be accurate
> 
> I would vote for #1.  I am open to other options as well if none of these
> seem ideal.
> 
> Thanks,
> Ryan

Updating instructions to run tests

[Ryan McMahon]

Hi all,

I recently added instructions on how to setup Geode in IntelliJ
,
and as part of that effort realized there is some duplication between the
Wiki [1

, 2
]
and the BUILDING.md
.

I am removing this duplication and noticed that we have some outdated
instructions on how to run tests in those Wiki sections.  Before I update
these instructions, I wanted to propose we move these instructions to
somewhere in the repo.  Here are some options:

1. Add a TESTING.md with instructions on running tests and link to it from
the Wiki
2. Add instructions on running tests to the existing BUILDING.md
3. Put all build and test instructions in the README.md, and get rid of
BUILDING.md.  I mention this option because this is what Apache Spark and
Apache Kafka do.  This might be hard for us because we have examples and
other content in the README.md already, so it would become quite bloated.
4. Leave the testing instructions where they are in the Wiki but update
them to be accurate

I would vote for #1.  I am open to other options as well if none of these
seem ideal.

Thanks,
Ryan

Re: Need gradle help

[Sai Boorlagadda]

It looks[1] like it is been renamed as 'tests', so you can try

testCompile 'org.apache.logging.log4j:log4j-core:' +
project.'log4j.version' + ':tests'

[1]
https://repo.maven.apache.org/maven2/org/apache/logging/log4j/log4j-core/2.11.0/

On Fri, Sep 14, 2018 at 5:17 PM Jacob Barrett  wrote:

> The concatenation is missing a : in front of the test-jar.
>
> > On Sep 14, 2018, at 4:10 PM, Kirk Lund  wrote:
> >
> > Log4j2 publishes a test jar for log4j-core. The jar includes useful
> things
> > like LoggerContextRule.
> >
> > This blog post shows how to add the dependency for testing to maven:
> > https://relentlesscoding.com/2018/04/21/unit-test-log4j2-log-output/
> >
> > This results look like this:
> >
> > 
> >org.apache.logging.log4j
> >log4j-core
> >2.11.0
> >test-jar
> > 
> >
> > And these various stackoverflow questions talk about using Gradle's "
> > classifier" instead of "type":
> > *
> >
> https://stackoverflow.com/questions/20224260/how-do-i-pull-maven-test-jars-using-gradle
> > *
> >
> https://stackoverflow.com/questions/13188438/how-to-specify-a-classifier-in-a-gradle-dependencys-dependency
> >
> > This gradle man page discusses the "classifier" further:
> > *
> >
> https://docs.gradle.org/current/userguide/declaring_dependencies.html#sub:resolve_specific_artifacts_from_dependency
> >
> > I've tried adding:
> >
> > +  compile 'org.apache.logging.log4j:log4j-core:' +
> project.'log4j.version'
> > + 'test-jar'
> >
> > +  testCompile 'org.apache.logging.log4j:log4j-core:' +
> > project.'log4j.version' + 'test-jar'
> >
> > +  integrationTestCompile 'org.apache.logging.log4j:log4j-core:' +
> > project.'log4j.version' + 'test-jar'
> >
> > ...too geode-core/build.gradle. The result builds but if I then try to
> use
> > any classes from the test jar I have no luck. If I check Project
> Structure
> > in IntelliJ after making sure that my project re synced from gradle, sure
> > enough the test jar is still missing from the dependencies.
> >
> > According to Gradle and SO, this should work. Is the problem our gradle
> > mess? Does anyone know how to get this working in the Geode gradle build?
>

Re: Steps to follow after becoming a Geode committer

[Dan Smith]

Hi Juan,

Great questions! I agree with what Jinmei said - go ahead and merge if you
have:

1) at least one approval
2) No changes requested
3) Checks are passing

The "at least one review" part is somewhat subjective, if you feel the PR
is complicated and you want more reviews, feel free to ask the list for
more feedback.

I see https://github.com/apache/geode/pull/2250 has one reviewer requesting
changes. You should look into the suggestions, or maybe just poke Galen if
he needs to review your fixes and approve them?

-Dan

On Mon, Sep 17, 2018 at 6:45 AM, Jinmei Liao  wrote:

> I believe you can go ahead. :-)
>
> The way I see it, you can merge a PR when all three are satisfied:
> 1) you have the privilege to merge it (the button is activated for you to
> push).
> 2) The PR is approved by a least one reviewer.
> 3) all checks passed.
>
> Thanks!
>
>
> On Mon, Sep 17, 2018, 3:48 AM Ju@N  wrote:
>
> > Hello all,
> >
> > My apache account is already created and everything seems to be working
> > just fine, I've already linked my account through
> > https://gitbox.apache.org/setup/ and I can see the option *Merge pull
> > request* in the *GitHub* interface (disabled in the past when I didn't
> have
> > commit privileges on the project).
> > I have two old pull requests (2376
> >  for GEODE-5353
> >  and 2250
> >  for GEODE-5314
> > ) already approved by
> > other committers, am I ready to go and merge them myself?, or should I
> wait
> > for an announcement or something else?. I've already gone through
> Becoming
> > a Committer
> > 
> >  and Code Contributions
> > 
> but
> > couldn't find a definitive answer about how/when to merge a *pull
> > request* opened
> > by yourself when you're a committer, how does this process work?, should
> I
> > ask in this list for reviews before merging the changes?, should I wait X
> > amount of days before asking for reviewers?, etc.
> > As a side note, I've received an email from *r...@apache.org
> > * with a link to the vote reference in the
> > *private.apache.geode.org
> > * list. I believe that list is only
> for
> > *PMC* members, so I don't (and won't) have access to that list, am I
> > right?.
> > Sorry for the long email and the amount of questions, just trying to make
> > sure I get things right from the very beginning :-).
> > Best regards.
> >
> > --
> > Ju@N
> >
>

Re: Steps to follow after becoming a Geode committer

[Jinmei Liao]

I believe you can go ahead. :-)

The way I see it, you can merge a PR when all three are satisfied:
1) you have the privilege to merge it (the button is activated for you to
push).
2) The PR is approved by a least one reviewer.
3) all checks passed.

Thanks!


On Mon, Sep 17, 2018, 3:48 AM Ju@N  wrote:

> Hello all,
>
> My apache account is already created and everything seems to be working
> just fine, I've already linked my account through
> https://gitbox.apache.org/setup/ and I can see the option *Merge pull
> request* in the *GitHub* interface (disabled in the past when I didn't have
> commit privileges on the project).
> I have two old pull requests (2376
>  for GEODE-5353
>  and 2250
>  for GEODE-5314
> ) already approved by
> other committers, am I ready to go and merge them myself?, or should I wait
> for an announcement or something else?. I've already gone through Becoming
> a Committer
> 
>  and Code Contributions
>  but
> couldn't find a definitive answer about how/when to merge a *pull
> request* opened
> by yourself when you're a committer, how does this process work?, should I
> ask in this list for reviews before merging the changes?, should I wait X
> amount of days before asking for reviewers?, etc.
> As a side note, I've received an email from *r...@apache.org
> * with a link to the vote reference in the
> *private.apache.geode.org
> * list. I believe that list is only for
> *PMC* members, so I don't (and won't) have access to that list, am I
> right?.
> Sorry for the long email and the amount of questions, just trying to make
> sure I get things right from the very beginning :-).
> Best regards.
>
> --
> Ju@N
>

Steps to follow after becoming a Geode committer

[Ju@N]

Hello all,

My apache account is already created and everything seems to be working
just fine, I've already linked my account through
https://gitbox.apache.org/setup/ and I can see the option *Merge pull
request* in the *GitHub* interface (disabled in the past when I didn't have
commit privileges on the project).
I have two old pull requests (2376
 for GEODE-5353
 and 2250
 for GEODE-5314
) already approved by
other committers, am I ready to go and merge them myself?, or should I wait
for an announcement or something else?. I've already gone through Becoming
a Committer

 and Code Contributions
 but
couldn't find a definitive answer about how/when to merge a *pull
request* opened
by yourself when you're a committer, how does this process work?, should I
ask in this list for reviews before merging the changes?, should I wait X
amount of days before asking for reviewers?, etc.
As a side note, I've received an email from *r...@apache.org
* with a link to the vote reference in the
*private.apache.geode.org
* list. I believe that list is only for
*PMC* members, so I don't (and won't) have access to that list, am I right?.
Sorry for the long email and the amount of questions, just trying to make
sure I get things right from the very beginning :-).
Best regards.

-- 
Ju@N