Re: New release branch for Apache Geode 1.10.0

[Owen Nichols]

There appears to be consensus that this is a critical fix.

The following commits have been brought into support/1.10.0 
 as the critical fix for 
GEODE-7001 :

git cherry-pick -x 81f8f9c1ca1ec9a591287905e559051284117057 

git cherry-pick -x c2ef3c682c885b4d49aad51edc1c11e80553bdfa 


GEODE-7001  has been marked 
as 'resolved in' 1.10.0.

-Owen

> On Aug 2, 2019, at 5:21 PM, Michael Oleske  wrote:
> 
> Naba's concern was this PR: https://github.com/apache/geode/pull/3880 which
> has been merged to develop
> 
> -michael
> 
> On Fri, Aug 2, 2019 at 4:33 PM Owen Nichols  wrote:
> 
>> Hi Naba, thank you for bringing your concern.
>> 
>> Our current process <
>> https://lists.apache.org/thread.html/d36a63c3794d13506ecad3d52a2aca938dcf0f8509b61860bbbc50cd@%3Cdev.geode.apache.org%3E>
>> dictates a time-based schedule to cut release branches.  Once cut, the
>> “critical fixes” rule allows critical fixes to be brought to the release
>> branch by proposal on the dev list.
>> 
>> Currently the 1.10.0 release pipeline <
>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-10-0-main>
>> is all green.  Perhaps one way to convince the Geode community that your
>> fix satisfies the “critical fixes” rule might be to share a link to a
>> github commit adding tests that expose the issue.
>> 
>> Thanks,
>> -Owen
>> 
>> 
>>> On Aug 2, 2019, at 12:55 PM, Nabarun Nag  wrote:
>>> 
>>> Hi,
>>> 
>>> We believe that the current release branch has an issue of getting a
>>> NullPointerException when we try calling LocalRegion.getLocalSize when
>> the
>>> region is in the process of being initialized. The fix for this issue is
>>> very critical and we should re-create the branch when the fix is placed
>> in
>>> develop.
>>> We need to hold any pipeline testing on the branch till this fix is in.
>>> 
>>> Regards
>>> Nabarun Nag
>>> 
>>> On Fri, Aug 2, 2019 at 11:17 AM Dick Cavender  wrote:
>>> 
 Hello Geode Dev Community,
 
 We have created a new release branch for Apache Geode 1.10.0 -
 "release/1.10.0"
 
 Please do review and raise any concern with the release branch. If no
 concerns are raised, we will start with the voting for the release
 candidate soon.
 
 Regards
 
 Dick Cavender
 Apache Geode 1.10.0 Release Manager
 
>> 
>> 

Re: New release branch for Apache Geode 1.10.0

[Nabarun Nag]

Thank you  Aaron and Kirk for getting the fix in.

Regards
Naba


On Fri, Aug 2, 2019 at 5:25 PM Aaron Lindsey  wrote:

> +1 to including this PR in the 1.10.0 release.
>
> Just to elaborate on the issue: If the stats sampler calls
> LocalRegion.getLocalSize before that region is initialized, it will throw a
> NullPointerException. This can happen because we have escaping references
> to “this” in the LocalRegion constructor that allow the stats sampler to
> call getLocalSize before the LocalRegion object is fully constructed.
>
> - Aaron
>
> > On Aug 2, 2019, at 5:21 PM, Michael Oleske  wrote:
> >
> > Naba's concern was this PR: https://github.com/apache/geode/pull/3880
> which
> > has been merged to develop
> >
> > -michael
> >
> > On Fri, Aug 2, 2019 at 4:33 PM Owen Nichols  wrote:
> >
> >> Hi Naba, thank you for bringing your concern.
> >>
> >> Our current process <
> >>
> https://lists.apache.org/thread.html/d36a63c3794d13506ecad3d52a2aca938dcf0f8509b61860bbbc50cd@%3Cdev.geode.apache.org%3E
> >
> >> dictates a time-based schedule to cut release branches.  Once cut, the
> >> “critical fixes” rule allows critical fixes to be brought to the release
> >> branch by proposal on the dev list.
> >>
> >> Currently the 1.10.0 release pipeline <
> >>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-10-0-main
> >
> >> is all green.  Perhaps one way to convince the Geode community that your
> >> fix satisfies the “critical fixes” rule might be to share a link to a
> >> github commit adding tests that expose the issue.
> >>
> >> Thanks,
> >> -Owen
> >>
> >>
> >>> On Aug 2, 2019, at 12:55 PM, Nabarun Nag  wrote:
> >>>
> >>> Hi,
> >>>
> >>> We believe that the current release branch has an issue of getting a
> >>> NullPointerException when we try calling LocalRegion.getLocalSize when
> >> the
> >>> region is in the process of being initialized. The fix for this issue
> is
> >>> very critical and we should re-create the branch when the fix is placed
> >> in
> >>> develop.
> >>> We need to hold any pipeline testing on the branch till this fix is in.
> >>>
> >>> Regards
> >>> Nabarun Nag
> >>>
> >>> On Fri, Aug 2, 2019 at 11:17 AM Dick Cavender 
> wrote:
> >>>
>  Hello Geode Dev Community,
> 
>  We have created a new release branch for Apache Geode 1.10.0 -
>  "release/1.10.0"
> 
>  Please do review and raise any concern with the release branch. If no
>  concerns are raised, we will start with the voting for the release
>  candidate soon.
> 
>  Regards
> 
>  Dick Cavender
>  Apache Geode 1.10.0 Release Manager
> 
> >>
> >>
>
>

Re: New release branch for Apache Geode 1.10.0

[Aaron Lindsey]

+1 to including this PR in the 1.10.0 release.

Just to elaborate on the issue: If the stats sampler calls 
LocalRegion.getLocalSize before that region is initialized, it will throw a 
NullPointerException. This can happen because we have escaping references to 
“this” in the LocalRegion constructor that allow the stats sampler to call 
getLocalSize before the LocalRegion object is fully constructed.

- Aaron

> On Aug 2, 2019, at 5:21 PM, Michael Oleske  wrote:
> 
> Naba's concern was this PR: https://github.com/apache/geode/pull/3880 which
> has been merged to develop
> 
> -michael
> 
> On Fri, Aug 2, 2019 at 4:33 PM Owen Nichols  wrote:
> 
>> Hi Naba, thank you for bringing your concern.
>> 
>> Our current process <
>> https://lists.apache.org/thread.html/d36a63c3794d13506ecad3d52a2aca938dcf0f8509b61860bbbc50cd@%3Cdev.geode.apache.org%3E>
>> dictates a time-based schedule to cut release branches.  Once cut, the
>> “critical fixes” rule allows critical fixes to be brought to the release
>> branch by proposal on the dev list.
>> 
>> Currently the 1.10.0 release pipeline <
>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-10-0-main>
>> is all green.  Perhaps one way to convince the Geode community that your
>> fix satisfies the “critical fixes” rule might be to share a link to a
>> github commit adding tests that expose the issue.
>> 
>> Thanks,
>> -Owen
>> 
>> 
>>> On Aug 2, 2019, at 12:55 PM, Nabarun Nag  wrote:
>>> 
>>> Hi,
>>> 
>>> We believe that the current release branch has an issue of getting a
>>> NullPointerException when we try calling LocalRegion.getLocalSize when
>> the
>>> region is in the process of being initialized. The fix for this issue is
>>> very critical and we should re-create the branch when the fix is placed
>> in
>>> develop.
>>> We need to hold any pipeline testing on the branch till this fix is in.
>>> 
>>> Regards
>>> Nabarun Nag
>>> 
>>> On Fri, Aug 2, 2019 at 11:17 AM Dick Cavender  wrote:
>>> 
 Hello Geode Dev Community,
 
 We have created a new release branch for Apache Geode 1.10.0 -
 "release/1.10.0"
 
 Please do review and raise any concern with the release branch. If no
 concerns are raised, we will start with the voting for the release
 candidate soon.
 
 Regards
 
 Dick Cavender
 Apache Geode 1.10.0 Release Manager
 
>> 
>> 

Re: New release branch for Apache Geode 1.10.0

[Michael Oleske]

Naba's concern was this PR: https://github.com/apache/geode/pull/3880 which
has been merged to develop

-michael

On Fri, Aug 2, 2019 at 4:33 PM Owen Nichols  wrote:

> Hi Naba, thank you for bringing your concern.
>
> Our current process <
> https://lists.apache.org/thread.html/d36a63c3794d13506ecad3d52a2aca938dcf0f8509b61860bbbc50cd@%3Cdev.geode.apache.org%3E>
> dictates a time-based schedule to cut release branches.  Once cut, the
> “critical fixes” rule allows critical fixes to be brought to the release
> branch by proposal on the dev list.
>
> Currently the 1.10.0 release pipeline <
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-10-0-main>
> is all green.  Perhaps one way to convince the Geode community that your
> fix satisfies the “critical fixes” rule might be to share a link to a
> github commit adding tests that expose the issue.
>
> Thanks,
> -Owen
>
>
> > On Aug 2, 2019, at 12:55 PM, Nabarun Nag  wrote:
> >
> > Hi,
> >
> > We believe that the current release branch has an issue of getting a
> > NullPointerException when we try calling LocalRegion.getLocalSize when
> the
> > region is in the process of being initialized. The fix for this issue is
> > very critical and we should re-create the branch when the fix is placed
> in
> > develop.
> > We need to hold any pipeline testing on the branch till this fix is in.
> >
> > Regards
> > Nabarun Nag
> >
> > On Fri, Aug 2, 2019 at 11:17 AM Dick Cavender  wrote:
> >
> >> Hello Geode Dev Community,
> >>
> >> We have created a new release branch for Apache Geode 1.10.0 -
> >> "release/1.10.0"
> >>
> >> Please do review and raise any concern with the release branch. If no
> >> concerns are raised, we will start with the voting for the release
> >> candidate soon.
> >>
> >> Regards
> >>
> >> Dick Cavender
> >> Apache Geode 1.10.0 Release Manager
> >>
>
>

Re: New release branch for Apache Geode 1.10.0

[Owen Nichols]

Hi Naba, thank you for bringing your concern.

Our current process 

 dictates a time-based schedule to cut release branches.  Once cut, the 
“critical fixes” rule allows critical fixes to be brought to the release branch 
by proposal on the dev list.

Currently the 1.10.0 release pipeline 

 is all green.  Perhaps one way to convince the Geode community that your fix 
satisfies the “critical fixes” rule might be to share a link to a github commit 
adding tests that expose the issue.

Thanks,
-Owen


> On Aug 2, 2019, at 12:55 PM, Nabarun Nag  wrote:
> 
> Hi,
> 
> We believe that the current release branch has an issue of getting a
> NullPointerException when we try calling LocalRegion.getLocalSize when the
> region is in the process of being initialized. The fix for this issue is
> very critical and we should re-create the branch when the fix is placed in
> develop.
> We need to hold any pipeline testing on the branch till this fix is in.
> 
> Regards
> Nabarun Nag
> 
> On Fri, Aug 2, 2019 at 11:17 AM Dick Cavender  wrote:
> 
>> Hello Geode Dev Community,
>> 
>> We have created a new release branch for Apache Geode 1.10.0 -
>> "release/1.10.0"
>> 
>> Please do review and raise any concern with the release branch. If no
>> concerns are raised, we will start with the voting for the release
>> candidate soon.
>> 
>> Regards
>> 
>> Dick Cavender
>> Apache Geode 1.10.0 Release Manager
>> 

Re: edit permissions on wiki

[Kirk Lund]

Oops. Try now.

On Fri, Aug 2, 2019 at 12:52 PM Joris Melchior  wrote:

> Don't seem to have edit permissions yet though ...
>
> On Fri, Aug 2, 2019 at 3:48 PM Joris Melchior 
> wrote:
>
> > Thanks Kirk!
> >
> > On Fri, Aug 2, 2019 at 12:16 PM Kirk Lund  wrote:
> >
> >> You should have permission now. Thanks!
> >>
> >> On Fri, Aug 2, 2019 at 7:32 AM Joris Melchior 
> >> wrote:
> >>
> >> > Hi,
> >> >
> >> > Can someone provide me with edit permissions on the wiki? Specifically
> >> the
> >> > tree starting with this link
> >> >
> >> >
> >>
> https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service
> >> >
> >> > My user name is 'joris.melchior'.
> >> >
> >> > Thanks,
> >> >
> >> > --
> >> > *Joris Melchior *
> >> > CF Engineering
> >> > Pivotal Toronto
> >> > 416 877 5427
> >> >
> >> > “Programs must be written for people to read, and only incidentally
> for
> >> > machines to execute.” – *Hal Abelson*
> >> > 
> >> >
> >>
> >
> >
> > --
> > *Joris Melchior *
> > CF Engineering
> > Pivotal Toronto
> > 416 877 5427
> >
> > “Programs must be written for people to read, and only incidentally for
> > machines to execute.” – *Hal Abelson*
> > 
> >
>
>
> --
> *Joris Melchior *
> CF Engineering
> Pivotal Toronto
> 416 877 5427
>
> “Programs must be written for people to read, and only incidentally for
> machines to execute.” – *Hal Abelson*
> 
>

Re: New release branch for Apache Geode 1.10.0

[Nabarun Nag]

Hi,

We believe that the current release branch has an issue of getting a
NullPointerException when we try calling LocalRegion.getLocalSize when the
region is in the process of being initialized. The fix for this issue is
very critical and we should re-create the branch when the fix is placed in
develop.
We need to hold any pipeline testing on the branch till this fix is in.

Regards
Nabarun Nag

On Fri, Aug 2, 2019 at 11:17 AM Dick Cavender  wrote:

> Hello Geode Dev Community,
>
> We have created a new release branch for Apache Geode 1.10.0 -
> "release/1.10.0"
>
> Please do review and raise any concern with the release branch. If no
> concerns are raised, we will start with the voting for the release
> candidate soon.
>
> Regards
>
> Dick Cavender
> Apache Geode 1.10.0 Release Manager
>

Re: edit permissions on wiki

[Joris Melchior]

Don't seem to have edit permissions yet though ...

On Fri, Aug 2, 2019 at 3:48 PM Joris Melchior  wrote:

> Thanks Kirk!
>
> On Fri, Aug 2, 2019 at 12:16 PM Kirk Lund  wrote:
>
>> You should have permission now. Thanks!
>>
>> On Fri, Aug 2, 2019 at 7:32 AM Joris Melchior 
>> wrote:
>>
>> > Hi,
>> >
>> > Can someone provide me with edit permissions on the wiki? Specifically
>> the
>> > tree starting with this link
>> >
>> >
>> https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service
>> >
>> > My user name is 'joris.melchior'.
>> >
>> > Thanks,
>> >
>> > --
>> > *Joris Melchior *
>> > CF Engineering
>> > Pivotal Toronto
>> > 416 877 5427
>> >
>> > “Programs must be written for people to read, and only incidentally for
>> > machines to execute.” – *Hal Abelson*
>> > 
>> >
>>
>
>
> --
> *Joris Melchior *
> CF Engineering
> Pivotal Toronto
> 416 877 5427
>
> “Programs must be written for people to read, and only incidentally for
> machines to execute.” – *Hal Abelson*
> 
>


-- 
*Joris Melchior *
CF Engineering
Pivotal Toronto
416 877 5427

“Programs must be written for people to read, and only incidentally for
machines to execute.” – *Hal Abelson*

Re: edit permissions on wiki

[Joris Melchior]

Thanks Kirk!

On Fri, Aug 2, 2019 at 12:16 PM Kirk Lund  wrote:

> You should have permission now. Thanks!
>
> On Fri, Aug 2, 2019 at 7:32 AM Joris Melchior 
> wrote:
>
> > Hi,
> >
> > Can someone provide me with edit permissions on the wiki? Specifically
> the
> > tree starting with this link
> >
> >
> https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service
> >
> > My user name is 'joris.melchior'.
> >
> > Thanks,
> >
> > --
> > *Joris Melchior *
> > CF Engineering
> > Pivotal Toronto
> > 416 877 5427
> >
> > “Programs must be written for people to read, and only incidentally for
> > machines to execute.” – *Hal Abelson*
> > 
> >
>


-- 
*Joris Melchior *
CF Engineering
Pivotal Toronto
416 877 5427

“Programs must be written for people to read, and only incidentally for
machines to execute.” – *Hal Abelson*

New release branch for Apache Geode 1.10.0

[Dick Cavender]

Hello Geode Dev Community,

We have created a new release branch for Apache Geode 1.10.0 -
"release/1.10.0"

Please do review and raise any concern with the release branch. If no
concerns are raised, we will start with the voting for the release
candidate soon.

Regards

Dick Cavender
Apache Geode 1.10.0 Release Manager

Re: Server recovery severely degrades client read traffic

[Anthony Baker]

Interesting find!  Can you share the code path you’re looking at?  I see one 
related to putAll but not for get.  Thanks!

Anthony


> On Aug 1, 2019, at 11:01 PM, Mario Ivanac  wrote:
> 
> Hi,
> 
> we are observing severe throttling from the cluster when getting data from a 
> partitioned region (no SH nor TX) while server hosting one of the redundant 
> buckets is recovering (see ticket 
> https://issues.apache.org/jira/browse/GEODE-7039).
> 
> 
> Currently, Get operations that have not landed on a server hosting the bucket 
> will be proxied to other members that host bucket, in random fashion.
> 
> Question is, can we use bucketProfile.isInitializing flag for member 
> selection algorithm, or do you have some better idea?

Re: edit permissions on wiki

[Kirk Lund]

You should have permission now. Thanks!

On Fri, Aug 2, 2019 at 7:32 AM Joris Melchior  wrote:

> Hi,
>
> Can someone provide me with edit permissions on the wiki? Specifically the
> tree starting with this link
>
> https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service
>
> My user name is 'joris.melchior'.
>
> Thanks,
>
> --
> *Joris Melchior *
> CF Engineering
> Pivotal Toronto
> 416 877 5427
>
> “Programs must be written for people to read, and only incidentally for
> machines to execute.” – *Hal Abelson*
> 
>

edit permissions on wiki

[Joris Melchior]

Hi,

Can someone provide me with edit permissions on the wiki? Specifically the
tree starting with this link
https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service

My user name is 'joris.melchior'.

Thanks,

-- 
*Joris Melchior *
CF Engineering
Pivotal Toronto
416 877 5427

“Programs must be written for people to read, and only incidentally for
machines to execute.” – *Hal Abelson*

Re: Problem with LGTM on geode-native pull request

[Blake Bender]

FWIW, I pushed the fix yesterday afternoon, so if you rebase to pick it up
LGTM will pass.  Thanks for your patience.

Blake


On Thu, Aug 1, 2019 at 9:36 AM Alberto Gomez  wrote:

> Having put it this way, I agree with you guys ;-)
>
> Thanks,
>
> -Alberto
>
> On 1/8/19 18:02, Blake Bender wrote:
> > I agree with Jake on this one.  From a bookkeeping perspective, what I'd
> > like to see in the history is a single commit that fixes all the LGTM
> > issues, and your fix for this bug in a separate commit.  I have a copy of
> > your .yml changes on my "fix LGTM" branch already, please back that
> change
> > out and we can merge your PR without LGTM passing.
> >
> > Thanks,
> >
> > Blake
> >
> >
> > On Thu, Aug 1, 2019 at 12:55 AM Alberto Gomez 
> > wrote:
> >
> >> Hi,
> >>
> >> I would not back out the LGTM changes added in the PR as they are
> >> necessary.
> >>
> >> - Alberto
> >>
> >> On 31/7/19 23:46, Jacob Barrett wrote:
> >>> I would say for this PR, back out the LGTM changes and just move
> forward
> >> ignoring the LGTM results.
> >>
>

Server recovery severely degrades client read traffic

[Mario Ivanac]

Hi,

we are observing severe throttling from the cluster when getting data from a 
partitioned region (no SH nor TX) while server hosting one of the redundant 
buckets is recovering (see ticket 
https://issues.apache.org/jira/browse/GEODE-7039).


Currently, Get operations that have not landed on a server hosting the bucket 
will be proxied to other members that host bucket, in random fashion.

Question is, can we use bucketProfile.isInitializing flag for member selection 
algorithm, or do you have some better idea?