[GitHub] geode-native issue #113: (no ticket) Capitalize C# client member functions
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/113 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #98: Test commit for Vince & Scott
Github user echobravopapa closed the pull request at: https://github.com/apache/geode-native/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #107: GEODE-3019: Refactor Struct class
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/107 @dgkimura @pivotal-jbarrett I think this is all ready for final inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127285583
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
return SelectResultsIterator(m_structVector, shared_from_this());
}
-int32_t StructSetImpl::getFieldIndex(const char* fieldname) {
- std::map<std::string, int32_t>::iterator iter =
+int32_t StructSetImpl::getFieldIndex(const std::string& fieldname) {
+ const auto& iter =
m_fieldNameIndexMap.find(fieldname);
if (iter != m_fieldNameIndexMap.end()) {
return iter->second;
--- End diff --
will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127285563
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char*
fieldname) {
}
}
-const char* StructSetImpl::getFieldName(int32_t index) {
- for (std::map<std::string, int32_t>::iterator iter =
- m_fieldNameIndexMap.begin();
- iter != m_fieldNameIndexMap.end(); ++iter) {
-if (iter->second == index) return iter->first.c_str();
+const std::string& StructSetImpl::getFieldName(int32_t index) {
+ for (const auto& iter : m_fieldNameIndexMap) {
+if (iter.second == index) return (iter.first);
}
- return nullptr;
+
+ throw OutOfRangeException("Struct: fieldName not found.");
--- End diff --
we can do that, I was just using our existing exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #107: GEODE-3019: Refactor Struct class
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/107 @dgkimura @pivotal-jbarrett added unit tests and throwing an exception for out of range now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #107: GEODE-3019: Refactor Struct class
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/107 @dgkimura @pivotal-jbarrett I squashed the latest so you won't get notified, which is a bummer, but please have a look when you have a minute. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126029862
--- Diff: src/cppcache/include/geode/Struct.hpp ---
@@ -138,7 +138,7 @@ class CPPCACHE_EXPORT Struct : public Serializable {
* Returns the name of the field corresponding to the index number in the
* Struct
*/
- virtual const char* getFieldName(const int32_t index) const;
+ virtual const std::string* getFieldName(const int32_t index) const;
--- End diff --
Yes. To remain compatible with the existing usage of the method were
`nullptr` is returned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode-native/pull/107 GEODE-3019: Refactor Struct class - Using std::string now - this also addresses GEODE-3020, the map now used standard types You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode-native feature/GEODE-3019 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/107.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #107 commit a502ce378d26ce374b51c4198f93bbf7d70116a6 Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-06-30T21:42:01Z GEODE-3019: Refactor Struct class - Using std::string now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #106: GEODE-2891 connect-timeout violation in C++ Native ...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/106 @pivotal-jbarrett fair enough on the branching point, I think the rest is still a valid ask --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #106: GEODE-2891 connect-timeout violation in C++ Native ...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/106 @gregt5259 a couple quick items of feedback that need to be addressed before this is reviewed: - please squash your commits, this cleans up the diffs for everyone to better review your contribution please close [#105](https://github.com/apache/geode-native/pull/105) as duplicate of this PR - please have a look at the [Code Contribution](https://cwiki.apache.org/confluence/display/GEODE/Code+contributions) section of the WIKI -- for one you will see that we are using GitFlow and your PR should be coming in from a feature branch (e.g. feature/GEODE-2891) instead of your develop branch Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #104: GEODE-3143 : close socket before deteting
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/104 @fdaniel7 please close this PR, thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #104: Develop
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/104 @fdaniel7 What is the GEODE ticket you are working on? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #98: Test commit for Vince & Scott
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode-native/pull/98 Test commit for Vince & Scott DO NOT MERGE THIS! You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode-native feature/GEODE-4242 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 commit 8daa626d82ed0fb029c5ee747f606be3b25a941c Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-05-12T21:07:06Z Test commit for Vince & Scott --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/90 @ameybarve15 it is simpler to start with a fresh feature branch and follow what @pivotal-jbarrett suggests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/90 @ameybarve15 @PivotalSarge will have a look at this soon. May we stay on the feature branch until the PR is approved, which will alleviate the "merge" commit... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #93: GEODE-2780: Fixing typo in client CONTRIBUTING.md fi...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/93 I thought so too... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/90 @ameybarve15 would you please squash your commits, TIA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #82: GEODE-2736: Fixed orphaned worker threads
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/82#discussion_r109942702
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
---
@@ -303,6 +303,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client1OpTest)
LOGINFO("Executing the exception test it is expected to throw.");
CacheableVectorPtr executeFunctionResult3 =
funcExec->withArgs(arrList)->withFilter(filter)->execute("ThinClientRegionExceptionTest",
15)->getResult();
+FAIL("Failed to throw expected exception.");
--- End diff --
Perfect. @mhansonp may I ask you to please squash your commits as well...?
TIA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #76: GEODE-2726: Add Packer Build Files for VS 2017
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/76 @mmartell merged, please close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #83: GEODE-2691: Fix function execution attributes mismat...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/83 @dgkimura merged, please close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #74: GEODE-2713: Wrap result collector lock in shared_ptr...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/74 @PivotalSarge need to clean up this PR, should not have all of the docs commits included, TIA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #83: GEODE-2691: Fix function execution attributes...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/83#discussion_r109743478
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char*
fn, uint32_t timeout,
bool serverIsHA = false;
bool serverOptimizeForWrite = false;
- if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+ std::vector* attr = getFunctionAttributes(fn);
+ {
--- End diff --
I take that back... @dgkimura what is with the curly braced block?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #83: GEODE-2691: Fix function execution attributes...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/83#discussion_r109743229
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char*
fn, uint32_t timeout,
bool serverIsHA = false;
bool serverOptimizeForWrite = false;
- if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+ std::vector* attr = getFunctionAttributes(fn);
+ {
--- End diff --
looks like it is an artifact from the previous if statement and can be
removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #82: GEODE-2736: Fixed orphaned worker threads
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/82#discussion_r109462974
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
---
@@ -0,0 +1,362 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#define ROOT_NAME "testThinClientPoolExecuteFunctionThrowsException"
+
+#include "fw_dunit.hpp"
+#include "ThinClientHelper.hpp"
+#include "testobject/VariousPdxTypes.hpp"
+
+#include
+#include
+
+using namespace PdxTests;
+/* This is to test
+1- funtion execution on pool
+ */
+
+#define CLIENT1 s1p1
+#define LOCATOR1 s2p1
+#define SERVER s2p2
+
+bool isLocalServer = false;
+bool isLocator = false;
+bool isPoolWithEndpoint = false;
+
+const char* locHostPort =
+CacheHelper::getLocatorHostPort(isLocator, isLocalServer, 1);
+const char* poolRegNames[] = {"partition_region", "PoolRegion2"};
+
+const char* serverGroup = "ServerGroup1";
+
+char* getFuncIName = (char*)"MultiGetFunctionI";
+char* putFuncIName = (char*)"MultiPutFunctionI";
+char* getFuncName = (char*)"MultiGetFunction";
+char* putFuncName = (char*)"MultiPutFunction";
+char* rjFuncName = (char*)"RegionOperationsFunction";
+char* exFuncName = (char*)"ExceptionHandlingFunction";
+char* exFuncNameSendException = (char*)"executeFunction_SendException";
+char* exFuncNamePdxType = (char*)"PdxFunctionTest";
+char* FEOnRegionPrSHOP = (char*)"FEOnRegionPrSHOP";
+char* FEOnRegionPrSHOP_OptimizeForWrite =
+(char*)"FEOnRegionPrSHOP_OptimizeForWrite";
+char* FETimeOut = (char*)"FunctionExecutionTimeOut";
+
+#define verifyGetResults()
\
+bool found = false;
\
+for (int j = 0; j < 34; j++) {
\
+ if (j % 2 == 0) continue;
\
+ sprintf(buf, "VALUE--%d", j);
\
+ if (strcmp(buf,
dynCast(resultList->operator[](i))\
+ ->asChar()) == 0) { \
+LOGINFO(
\
+
"buf = %s " \
+
"dynCast(resultList->operator[](i))->asChar() " \
+
"= %s ",\
+
buf,\
+
dynCast(resultList->operator[](i))->asChar()); \
+
found = true; \
+
break; \
+ }
\
+}
\
+ASSERT(found, "this returned value is invalid");
+
+#define verifyGetKeyResults()
\
+bool found = false;
[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r107994818
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult {
public:
inline ChunkedFunctionExecutionResponse(
- TcrMessage& msg, bool getResult, ResultCollectorPtr rc,
- ACE_Recursive_Thread_Mutex* resultCollectorLock = NULL)
+ TcrMessage& msg, bool getResult, ResultCollectorPtr rc)
: TcrChunkedResult(),
m_msg(msg),
m_getResult(getResult),
-m_rc(rc),
-m_resultCollectorLock(resultCollectorLock) {}
-
+m_rc(rc) {}
+
+inline ChunkedFunctionExecutionResponse(
--- End diff --
I was expecting to see the new version of ChunkedFunctionExecutionResponse
used somewhere...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #74: GEODE-2713: Wrap result collector lock in sha...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r107992569
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult {
public:
inline ChunkedFunctionExecutionResponse(
- TcrMessage& msg, bool getResult, ResultCollectorPtr rc,
- ACE_Recursive_Thread_Mutex* resultCollectorLock = NULL)
+ TcrMessage& msg, bool getResult, ResultCollectorPtr rc)
: TcrChunkedResult(),
m_msg(msg),
m_getResult(getResult),
-m_rc(rc),
-m_resultCollectorLock(resultCollectorLock) {}
-
+m_rc(rc) {}
+
+inline ChunkedFunctionExecutionResponse(
--- End diff --
@PivotalSarge where is this code exercised? any test coverage for it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/73#discussion_r107950987 --- Diff: docs/geode-native-docs/introduction/developing-windows.html.md.erb --- @@ -21,18 +21,18 @@ limitations under the License. Geode uses the Visual Studio 2010 Service Pack 1 compiler for C++ programs on Windows, which invokes Microsoft® `cl.exe` from the command line at compile time. -The Geode native client supports .NET 4.0 and Visual Studio 2010. For advantages and more information on the features of .NET 4.0 and Visual Studio 2010 SP1, see [http://msdn.microsoft.com/en-us/library/dd831853(v=vs.100).aspx](http://msdn.microsoft.com/en-us/library/dd831853(v=vs.100).aspx) and [http://msdn.microsoft.com/en-us/library/vstudio/w0x726c2(v=vs.100).aspx](http://msdn.microsoft.com/en-us/library/vstudio/w0x726c2(v=vs.100).aspx). +The Geode client supports .NET 4.0 and Visual Studio 2010. For advantages and more information on the features of .NET 4.0 and Visual Studio 2010 SP1, see [http://msdn.microsoft.com/en-us/library/dd831853(v=vs.100).aspx](http://msdn.microsoft.com/en-us/library/dd831853(v=vs.100).aspx) and [http://msdn.microsoft.com/en-us/library/vstudio/w0x726c2(v=vs.100).aspx](http://msdn.microsoft.com/en-us/library/vstudio/w0x726c2(v=vs.100).aspx). Visual Studio 2010 SP1 is the recommended compiler. If you are using any other compiler, contact technical support for assistance. --- End diff -- Let's remove any references to "contacting tech support" as this is not a concept in an Apache project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/73#discussion_r107950403 --- Diff: docs/geode-native-docs/introduction/developing-solaris.html.md.erb --- @@ -19,25 +19,25 @@ See the License for the specific language governing permissions and limitations under the License. --> -This section describes how to build and run a native client application on Solaris. +This section describes how to build and run a client application on Solaris. ## Step 1. Set Environment Variables -**Note:** When compiling external projects or applications that are used or referenced by the native client, make sure that you compile them for the same target architecture as your native client installation. For example, if you installed the 32-bit (x86) version of the native client, compile your external projects for 32-bit (x86) architecture. +**Note:** When compiling external projects or applications that are used or referenced by the client, make sure that you compile them for the same target architecture as your client installation. For example, if you installed the 32-bit (x86) version of the client, compile your external projects for 32-bit (x86) architecture. -Set the native client environment variables on each Solaris host. For each case, *product-dir* is the path to the native client product directory. +Set the client environment variables on each Solaris host. For each case, *product-dir* is the path to the client product directory. **For Bourne and Korn shells (sh, ksh, bash)** -GFCPP=_product-dir_; export GFCPP -PATH=$GFCPP/bin:$PATH;export PATH -LD\_LIBRARY\_PATH=$GFCPP/lib:$LD\_LIBRARY\_PATH;export LD\_LIBRARY\_PATH +GEODE=_product-dir_; export GEODE +PATH=$GEODE/bin:$PATH;export PATH +LD\_LIBRARY\_PATH=$GEODE/lib:$LD\_LIBRARY\_PATH;export LD\_LIBRARY\_PATH --- End diff -- The future life of Solaris is very much up in the air, this section could be removed as I don't think it is regarding the "current" version of SunStudio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/73#discussion_r107950013 --- Diff: docs/geode-native-docs/introduction/developing-linux.html.md.erb --- @@ -19,48 +19,48 @@ See the License for the specific language governing permissions and limitations under the License. --> -This section describes how to build and run a native client application on Linux. +This section describes how to build and run a client application on Linux. -**Note:** When compiling external projects or applications that are used or referenced by the Geode native client, make sure that you compile them for the same target architecture as your native client installation. For example, if you installed the 64-bit (x86) version of the native client, compile your external projects for 64-bit (x86) architecture. +**Note:** When compiling external projects or applications that are used or referenced by the Geode client, make sure that you compile them for the same target architecture as your client installation. For example, if you installed the 64-bit (x86) version of the client, compile your external projects for 64-bit (x86) architecture. ## Step 1. Set Environment Variables -Set the native client environment variables on each Linux host. For each case, *product-dir* is the path to the native client product directory. +Set the client environment variables on each Linux host. For each case, *product-dir* is the path to the client product directory. **For Bourne and Korn shells (sh, ksh, bash)** -GFCPP=_product-dir_;export GFCPP -PATH=$GFCPP/bin:$PATH;export PATH -LD\_LIBRARY\_PATH=$GFCPP/lib:$LD\_LIBRARY\_PATH;export LD\_LIBRARY\_PATH +GEODE=_product-dir_;export GEODE +PATH=$GEODE/bin:$PATH;export PATH +LD\_LIBRARY\_PATH=$GEODE/lib:$LD\_LIBRARY\_PATH;export LD\_LIBRARY\_PATH -## Step 2. Compile C++ Clients and Dynamically Link Them to the GemFire Library +## Step 2. Compile C++ Clients and Dynamically Link Them to the Geode Library -On Linux, the `g++` compiler is supported. To build and link a C++ client to GemFire on Linux, the compilation command line must include the arguments listed in the following table. +On Linux, the `g++` compiler is supported. To build and link a C++ client to Geode on Linux, the compilation command line must include the arguments listed in the following table. | Argument | Explanation | ||--| | `-D_REENTRANT` | Required to compile Linux programs in a thread-safe way. | | `-m32` or `-m64` | Enables 32-bit or 64-bit compilation. | -| `-I$GFCPP/include` | Specifies the native client `include` directory. | +| `-I$GEODE/include` | Specifies the client `include` directory. | -The following table lists the linker switches that must be present on the command line when dynamically linking to the GemFire library. +The following table lists the linker switches that must be present on the command line when dynamically linking to the Geode library. | Argument| Explanation | |-|| -| `-rpath $GFCPP/lib` | Tells the linker to look in `$GFCPP/lib` for libraries on which the native client library depends. | -| `-L$GFCPP/lib` | Tells the linker where to find the named libraries.| +| `-rpath $GEODE/lib` | Tells the linker to look in `$GEODE/lib` for libraries on which the client library depends. | +| `-L$GEODE/lib` | Tells the linker where to find the named libraries.| | `-o durableclient` | Tells the linker to output an object file named 'durableclient'. | -| `-lgfcppcache` | Links the native client C++ cache library to the compiled executable. | +| `-lgfcppcache` | Links the client C++ cache library to the compiled executable. | -The following examples compile and link the `$GFCPP/SampleCode/quickstart/cpp/DurableClient.cpp` client to the `durableclient` output file. +The following examples compile and link the `$GEODE/SampleCode/quickstart/cpp/DurableClient.cpp` client to the `durableclient` output file. **Compiling and Dynamically Linking on Linux for 32-bit** --- End diff -- It would be better to have the examp
[GitHub] geode-native pull request #71: GEODE-2687: Ensure three tests for SSL authen...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/71#discussion_r107770677
--- Diff: src/cppcache/integration-test/testThinClientSSLAuthFail.cpp ---
@@ -15,8 +15,180 @@
* limitations under the License.
*/
-#include "ThinClientSSLAuthFail.hpp"
+#include "fw_dunit.hpp"
+#include
+#include
+#include
+#include
+
+#define ROOT_NAME "ThinClientSSLAuthFail"
+#define ROOT_SCOPE DISTRIBUTED_ACK
+
+#include "CacheHelper.hpp"
+
+using namespace apache::geode::client;
+using namespace test;
+
+CacheHelper* cacheHelper = NULL;
+bool isLocalServer = false;
+
+static bool isLocator = false;
+const char* locatorsG =
+CacheHelper::getLocatorHostPort(isLocator, isLocalServer, 1);
+
+#define CLIENT1 s1p1
+#define SERVER1 s2p1
+
+void initClient(const bool isthinClient) {
+ if (cacheHelper == NULL) {
+PropertiesPtr props = Properties::create();
+props->insert("ssl-enabled", "true");
+std::string keystore = std::string(ACE_OS::getenv("TESTSRC")) +
"/keystore";
+std::string pubkey = keystore + "/client_truststore.pem";
+std::string privkey = keystore + "/client_keystore.pem";
+props->insert("ssl-keystore", privkey.c_str());
+props->insert("ssl-truststore", pubkey.c_str());
+cacheHelper = new CacheHelper(isthinClient, props);
+ }
+ ASSERT(cacheHelper, "Failed to create a CacheHelper client instance.");
+}
+void cleanProc() {
+ if (cacheHelper != NULL) {
+delete cacheHelper;
+cacheHelper = NULL;
+ }
+}
+
+CacheHelper* getHelper() {
+ ASSERT(cacheHelper != NULL, "No cacheHelper initialized.");
+ return cacheHelper;
+}
+
+
+void createPooledRegion(const char* name, bool ackMode, const char*
locators,
+const char* poolname,
+bool clientNotificationEnabled = false,
+bool cachingEnable = true) {
+ LOG("createRegion_Pool() entered.");
+ fprintf(stdout, "Creating region -- %s ackMode is %d\n", name,
ackMode);
+ fflush(stdout);
+ RegionPtr regPtr =
+ getHelper()->createPooledRegion(name, ackMode, locators, poolname,
+ cachingEnable,
clientNotificationEnabled);
+ ASSERT(regPtr != NULLPTR, "Failed to create region.");
+ LOG("Pooled Region created.");
+}
+
+void createEntry(const char* name, const char* key, const char* value) {
+ LOG("createEntry() entered.");
+ fprintf(stdout, "Creating entry -- key: %s value: %s in region %s\n",
key,
+ value, name);
+ fflush(stdout);
+ // Create entry, verify entry is correct
+ CacheableKeyPtr keyPtr = createKey(key);
+ CacheableStringPtr valPtr = CacheableString::create(value);
+
+ RegionPtr regPtr = getHelper()->getRegion(name);
+ ASSERT(regPtr != NULLPTR, "Region not found.");
+
+ ASSERT(!regPtr->containsKey(keyPtr),
+ "Key should not have been found in region.");
+ ASSERT(!regPtr->containsValueForKey(keyPtr),
+ "Value should not have been found in region.");
+
+ // regPtr->create( keyPtr, valPtr );
+ regPtr->put(keyPtr, valPtr);
+ LOG("Created entry.");
+
+ //verifyEntry(name, key, value);
+ LOG("Entry created.");
+}
+
+
+
+const char* keys[] = {"Key-1", "Key-2", "Key-3", "Key-4"};
+const char* vals[] = {"Value-1", "Value-2", "Value-3", "Value-4"};
+const char* nvals[] = {"New Value-1", "New Value-2", "New Value-3",
+ "New Value-4"};
+
+const char* regionNames[] = {"DistRegionAck", "DistRegionNoAck"};
+
+const bool USE_ACK = true;
+const bool NO_ACK = false;
+
+DUNIT_TASK_DEFINITION(SERVER1, CreateLocator1_With_SSL_untrustedCert)
+ {
+// starting locator
+if (isLocator) CacheHelper::initLocator(1, true, false, -1, 0, true);
+LOG("Locator1 started with SSL");
+ }
+END_TASK_DEFINITION
+
+
+
+DUNIT_TASK_DEFINITION(SERVER1,
CreateServer1_With_Locator_And_SSL_untrustedCert)
+ {
+// starting servers
+if (isLocalServer) CacheHelper::initServer(1, NULL, locatorsG, NULL,
true, true, false, false, true);
+ }
+END_TASK_DEFINITION
+
+DUNIT_TASK_DEFINITI
[GitHub] geode-native pull request #72: GEODE-2712: Fixed cpp quickstarts building on...
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode-native/pull/72 GEODE-2712: Fixed cpp quickstarts building on Windows. You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2712 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 456de2a24e3f8d5e6fe261f5e8d67260a636b708 Author: Ernie Burghardt <eburgha...@pivotal.io> Date: 2017-03-23T18:28:23Z GEODE-2712: Fixed cpp quickstarts building on Windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #70: GEODE-2470: Fix for Solaris regex short comin...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/70#discussion_r107542483
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1376,6 +1376,41 @@ void
CacheHelper::createDuplicateXMLFile(std::string& originalFile,
CacheHelper::staticConfigFileList.size());
}
+// Need to avoid regex usage in Solaris Studio 12.4.
+#ifdef _SOLARIS
+// @Solaris 12.4 compiler is missing support for C++11 regex
+void CacheHelper::replacePortsInFile(int hostPort1, int hostPort2,
+ int hostPort3, int hostPort4, int
locPort1,
+ int locPort2, const std::string&
inFile,
+ const std::string& outFile) {
+ std::ifstream in(inFile, std::ios::in | std::ios::binary);
+ if (in) {
+std::string contents;
+contents.assign(std::istreambuf_iterator(in),
std::istreambuf_iterator());
+in.close();
+
+replaceInPlace(contents, "HOST_PORT1", std::to_string(hostPort1));
+replaceInPlace(contents, "HOST_PORT2", std::to_string(hostPort2));
+replaceInPlace(contents, "HOST_PORT3", std::to_string(hostPort3));
+replaceInPlace(contents, "HOST_PORT4", std::to_string(hostPort4));
+replaceInPlace(contents, "LOC_PORT1", std::to_string(locPort1));
+replaceInPlace(contents, "LOC_PORT2", std::to_string(locPort2));
+
+std::ofstream out(outFile, std::ios::out);
+out << contents;
+out.close();
+ }
+}
+
+void CacheHelper::replaceInPlace(std::string& searchStr, const
std::string& matchStr,
+ const std::string& replaceStr) {
+size_t pos = 0;
+while ((pos = searchStr.find(matchStr, pos)) != std::string::npos) {
+ searchStr.replace(pos, matchStr.length(), replaceStr);
--- End diff --
There we go... second arg to .replace() makes all the difference
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #70: GEODE-2470: Fix for Solaris regex short comin...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/70#discussion_r107535535
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1376,6 +1376,41 @@ void
CacheHelper::createDuplicateXMLFile(std::string& originalFile,
CacheHelper::staticConfigFileList.size());
}
+// Need to avoid regex usage in Solaris Studio 12.4.
+#ifdef _SOLARIS
+// @Solaris 12.4 compiler is missing support for C++11 regex
+void CacheHelper::replacePortsInFile(int hostPort1, int hostPort2,
+ int hostPort3, int hostPort4, int
locPort1,
+ int locPort2, const std::string&
inFile,
+ const std::string& outFile) {
+ std::ifstream in(inFile, std::ios::in | std::ios::binary);
+ if (in) {
+std::string contents;
+contents.assign(std::istreambuf_iterator(in),
std::istreambuf_iterator());
+in.close();
+
+replaceInPlace(contents, "HOST_PORT1", std::to_string(hostPort1));
+replaceInPlace(contents, "HOST_PORT2", std::to_string(hostPort2));
+replaceInPlace(contents, "HOST_PORT3", std::to_string(hostPort3));
+replaceInPlace(contents, "HOST_PORT4", std::to_string(hostPort4));
+replaceInPlace(contents, "LOC_PORT1", std::to_string(locPort1));
+replaceInPlace(contents, "LOC_PORT2", std::to_string(locPort2));
+
+std::ofstream out(outFile, std::ios::out);
+out << contents;
+out.close();
+ }
+}
+
+void CacheHelper::replaceInPlace(std::string& searchStr, const
std::string& matchStr,
+ const std::string& replaceStr) {
+size_t pos = 0;
+while ((pos = searchStr.find(matchStr, pos)) != std::string::npos) {
--- End diff --
@mmartell I think there is an issue with this replacement code...
I'm not convinced we need the loop and my experiments are showing that a
searchStr like so:
"look do leap be sheep" where the matchStr is "leap" and replaceStr is
"lose" you will end up with "look do lose"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929938
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
SafeConvertClassGeneric::SetAppDomainEnabled(appDomainEnable);
+ if (appDomainEnable)
+ {
+// Register managed AppDomain context with unmanaged.
+apache::geode::client::createAppDomainContext =
::Geode::Client::createAppDomainContext;
--- End diff --
+1 make it a built default, less property juggling for the app devs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106924253
--- Diff:
src/cppcache/integration-test/testThinClientExecuteFunctionPrSHOP.cpp ---
@@ -563,7 +563,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client1OpTest2)
LOGINFO("FETimeOut begin onRegion");
ExecutionPtr RexecutionPtr = FunctionService::onRegion(regPtr0);
CacheableVectorPtr fe =
- RexecutionPtr->withArgs(CacheableInt32::create(5000))
+ RexecutionPtr->withArgs(CacheableInt32::create(5000 * 1000))
--- End diff --
Should we be marking these areas for posterity and conversion to only using
milli?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #59: GEODE-2513 Unbrand Function Execution section...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/59#discussion_r106471945 --- Diff: docs/geode-native-docs/function-execution/solutions-use-cases.html.md.erb --- @@ -19,7 +19,7 @@ See the License for the specific language governing permissions and limitations under the License. --> -The function execution service provides solutions for various application use cases. +The function execution service provides solutions for these application use cases: --- End diff -- Colon is far superior to the period to precede the list of use cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #57: GEODE-2513 Unbrand Programming Examples secti...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/57#discussion_r106279511 --- Diff: docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb --- @@ -883,7 +883,7 @@ limitations under the License. Programming Examples -Declaring a Native Client Region +Declaring a Client Region --- End diff -- That was an odd way to put it, in the original wording... I think "native" snuck in there, but was not correct. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #50: GEODE-2636: Switch to CMake variable for libr...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/50#discussion_r105265184
--- Diff: src/quickstart/cpp/PdxSerializer.cpp ---
@@ -165,15 +165,15 @@ int main(int argc, char** argv) {
LOGINFO("Registered Person Query Objects");
// Populate the Region with some Person objects.
-Person* p1 = new Person("John", 1 /*ID*/, 23 /*age*/);
+Person* p1 = new Person((char *)"John", 1 /*ID*/, 23 /*age*/);
--- End diff --
What led to adding this cast?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #49: GEODE-2513 Unbrand docs section on Preserving...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/49#discussion_r105257135 --- Diff: docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb --- @@ -19,19 +19,19 @@ See the License for the specific language governing permissions and limitations under the License. --> -The durable native client can be configured in the `gfcpp.properties` file, or in the `CacheFactory::set(name, value)` call. +The durable client can be configured in the `gfcpp.properties` file, or in the `CacheFactory::set(name, value)` call. -- **Durable client ID**—You indicate that the client is durable by giving it a `durable-client-ID`. The servers use this ID to identify the client. For a non-durable client, the `durable-client-ID` is an empty string. The ID can be any number that is unique among the clients attached to servers in the same distributed system. +- **Durable client ID**—Indicate that the client is durable by giving it a `durable-client-ID`. The servers use this ID to identify the client. For a non-durable client, the `durable-client-ID` is an empty string. The ID can be any number that is unique among the clients attached to servers in the same distributed system. - **Durable timeout**—The `durable-timeout` setting specifies how long this client’s servers should wait after the client disconnects before terminating its message queue. During that time, the servers consider the client alive and continue to accumulate messages for it. The default is 300 seconds. The `durable-timeout` setting is a tuning parameter. When setting the timeout, take into account the normal activity of your application, the average size of your messages, and the level of risk you can handle. Assuming that no messages are being removed from the queue, how long can the application run before the queue reaches the maximum message count? In addition, how long can it run before the queued messages consume all the memory on the client host? How serious is each of those failures to your operation? -To assist with tuning, Geode provides statistics that track message queues for durable clients through the disconnect and reconnect cycles. For statistics documentation, see [Statistics](geodeman/managing/statistics/chapter_overview.html). +To assist with tuning, Geode statistics track message queues for durable clients through the disconnect and reconnect cycles. -When the queue is full, it blocks further operations that add messages until the queue size drops to an acceptable level. The action to take is specified on the server. For details on configuring the queue, see [Implementing Durable Client/Server Messaging](geodeman/developing/events/implementing_durable_client_server_messaging.html). +When the queue is full, it blocks further operations that add messages until the queue size drops to an acceptable level. Server configuration sets the action to take. See details on server configuration of the queue in the server documentation section [Implementing Durable Client/Server Messaging](geodeman/developing/events/implementing_durable_client_server_messaging.html). -## Configuring a Durable Native Client Using gfcpp.properties +## Configuring a Durable Client Using gfcpp.properties --- End diff -- works for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #49: GEODE-2513 Unbrand docs section on Preserving...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/49#discussion_r105222610 --- Diff: docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb --- @@ -19,19 +19,19 @@ See the License for the specific language governing permissions and limitations under the License. --> -The durable native client can be configured in the `gfcpp.properties` file, or in the `CacheFactory::set(name, value)` call. +The durable client can be configured in the `gfcpp.properties` file, or in the `CacheFactory::set(name, value)` call. -- **Durable client ID**—You indicate that the client is durable by giving it a `durable-client-ID`. The servers use this ID to identify the client. For a non-durable client, the `durable-client-ID` is an empty string. The ID can be any number that is unique among the clients attached to servers in the same distributed system. +- **Durable client ID**—Indicate that the client is durable by giving it a `durable-client-ID`. The servers use this ID to identify the client. For a non-durable client, the `durable-client-ID` is an empty string. The ID can be any number that is unique among the clients attached to servers in the same distributed system. - **Durable timeout**—The `durable-timeout` setting specifies how long this client’s servers should wait after the client disconnects before terminating its message queue. During that time, the servers consider the client alive and continue to accumulate messages for it. The default is 300 seconds. The `durable-timeout` setting is a tuning parameter. When setting the timeout, take into account the normal activity of your application, the average size of your messages, and the level of risk you can handle. Assuming that no messages are being removed from the queue, how long can the application run before the queue reaches the maximum message count? In addition, how long can it run before the queued messages consume all the memory on the client host? How serious is each of those failures to your operation? -To assist with tuning, Geode provides statistics that track message queues for durable clients through the disconnect and reconnect cycles. For statistics documentation, see [Statistics](geodeman/managing/statistics/chapter_overview.html). +To assist with tuning, Geode statistics track message queues for durable clients through the disconnect and reconnect cycles. -When the queue is full, it blocks further operations that add messages until the queue size drops to an acceptable level. The action to take is specified on the server. For details on configuring the queue, see [Implementing Durable Client/Server Messaging](geodeman/developing/events/implementing_durable_client_server_messaging.html). +When the queue is full, it blocks further operations that add messages until the queue size drops to an acceptable level. Server configuration sets the action to take. See details on server configuration of the queue in the server documentation section [Implementing Durable Client/Server Messaging](geodeman/developing/events/implementing_durable_client_server_messaging.html). -## Configuring a Durable Native Client Using gfcpp.properties +## Configuring a Durable Client Using gfcpp.properties --- End diff -- I think this file is called "geode.properities" now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #49: GEODE-2513 Unbrand docs section on Preserving...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/49#discussion_r105222443 --- Diff: docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb --- @@ -19,19 +19,19 @@ See the License for the specific language governing permissions and limitations under the License. --> -The durable native client can be configured in the `gfcpp.properties` file, or in the `CacheFactory::set(name, value)` call. +The durable client can be configured in the `gfcpp.properties` file, or in the `CacheFactory::set(name, value)` call. -- **Durable client ID**—You indicate that the client is durable by giving it a `durable-client-ID`. The servers use this ID to identify the client. For a non-durable client, the `durable-client-ID` is an empty string. The ID can be any number that is unique among the clients attached to servers in the same distributed system. +- **Durable client ID**—Indicate that the client is durable by giving it a `durable-client-ID`. The servers use this ID to identify the client. For a non-durable client, the `durable-client-ID` is an empty string. The ID can be any number that is unique among the clients attached to servers in the same distributed system. - **Durable timeout**—The `durable-timeout` setting specifies how long this client’s servers should wait after the client disconnects before terminating its message queue. During that time, the servers consider the client alive and continue to accumulate messages for it. The default is 300 seconds. The `durable-timeout` setting is a tuning parameter. When setting the timeout, take into account the normal activity of your application, the average size of your messages, and the level of risk you can handle. Assuming that no messages are being removed from the queue, how long can the application run before the queue reaches the maximum message count? In addition, how long can it run before the queued messages consume all the memory on the client host? How serious is each of those failures to your operation? -To assist with tuning, Geode provides statistics that track message queues for durable clients through the disconnect and reconnect cycles. For statistics documentation, see [Statistics](geodeman/managing/statistics/chapter_overview.html). +To assist with tuning, Geode statistics track message queues for durable clients through the disconnect and reconnect cycles. -When the queue is full, it blocks further operations that add messages until the queue size drops to an acceptable level. The action to take is specified on the server. For details on configuring the queue, see [Implementing Durable Client/Server Messaging](geodeman/developing/events/implementing_durable_client_server_messaging.html). +When the queue is full, it blocks further operations that add messages until the queue size drops to an acceptable level. Server configuration sets the action to take. See details on server configuration of the queue in the server documentation section [Implementing Durable Client/Server Messaging](geodeman/developing/events/implementing_durable_client_server_messaging.html). --- End diff -- That is much clearer instruction than before --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r105204008
--- Diff: src/cppcache/include/geode/DataOutput.hpp ---
@@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput {
*/
inline void writeFullUTF(const char* value, uint32_t length = 0) {
--- End diff --
ICKY, sounds like a separable refactoring chore...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104759431
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -555,7 +555,7 @@ class CPPCACHE_EXPORT TcrMessage {
const VectorOfCacheableKey* getAllKeyList = NULL);
void writeHeader(uint32_t msgType, uint32_t numOfParts);
void writeRegionPart(const std::string& regionName);
- void writeStringPart(const std::string& regionName);
+ void writeStringPart(const std::string& str);
--- End diff --
the aforementioned copy/pasting...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104766406
--- Diff: src/cppcache/include/geode/DataOutput.hpp ---
@@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput {
*/
inline void writeFullUTF(const char* value, uint32_t length = 0) {
if (value != NULL) {
- int32_t len = getEncodedLength(value, length);
- uint16_t encodedLen = static_cast(len > 0x ? 0x :
len);
--- End diff --
what was the corner case impact of this line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104766552
--- Diff: src/cppcache/test/DataOutputTest.cpp ---
@@ -305,15 +305,9 @@ TEST_F(DataOutputTest, TestCursorAdvance) {
"001B596F7520686164206D65206174206D65617420746F726E61646F2E",
dataOutput.getByteArray());
- EXPECT_EQ((2 + 27), dataOutput.getBufferLength());
-
- // buffers are pre-allocated 8k and have 2 bytes to hold the data length
- EXPECT_EQ(((8 * 1024) - (2 + 27)),
dataOutput.getRemainingBufferLength());
--- End diff --
What led you to removing the call to getRemainingBufferLength()?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104759602
--- Diff: src/cppcache/src/TcrMessage.cpp ---
@@ -756,8 +756,8 @@ void TcrMessage::writeRegionPart(const std::string&
regionName) {
m_request->writeBytesOnly((int8_t*)regionName.c_str(), len);
}
-void TcrMessage::writeStringPart(const std::string& regionName) {
- m_request->writeFullUTF(regionName.c_str());
+void TcrMessage::writeStringPart(const std::string& str) {
--- End diff --
here as well, much more intuitive var name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104768254
--- Diff: src/cppcache/test/TcrMessage_unittest.cpp ---
@@ -559,3 +560,66 @@ TEST_F(TcrMessageTest,
testConstructorEXECUTE_FUNCTION) {
"75746546756E6374696F6E00030157",
testMessage);
}
+
+TEST_F(TcrMessageTest, testConstructorEXECUTECQ_MSG_TYPE) {
+ CacheablePtr myCacheablePtr(CacheableString::createDeserializable());
+
+ TcrMessageExecuteCq testMessage("ExecuteCQ", "select * from /somewhere",
+ CqState::RUNNING, false,
+ static_cast(NULL));
+
+ EXPECT_EQ(TcrMessage::EXECUTECQ_MSG_TYPE, testMessage.getMessageType());
+
+ EXPECT_MESSAGE_EQ(
+
"002A00450900457865637574654351001800"
+
"73656C656374202A2066726F6D202F736F6D65776865726500040100"
+ "0100010001",
+ testMessage);
+}
+
+TEST_F(TcrMessageTest,
testConstructorWithGinormousQueryEXECUTECQ_MSG_TYPE) {
--- End diff --
I'm not certain that this query's magnitude qualifies for ginormity...
maybe we just call it test*64KiBQuery* - lest we set the bar low for
ginormous...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103713640
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
endif()
--- End diff --
-verbose flag LTGM, I had made the same changes locally
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/42#discussion_r103568625 --- Diff: src/quickstart/runcpp.sh.in --- @@ -150,9 +149,6 @@ else "24") exname='PdxInstance' ;; - "25") -exname='PdxAutoSerializer' - ;; "26") --- End diff -- see above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103569428
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
endif()
--- End diff --
what I did locally to be able to build the quickstarts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103490344
--- Diff: src/cppcache/integration-test/testSpinLock.cpp ---
@@ -20,48 +20,44 @@
#include "fw_dunit.hpp"
#include
+#include
+#include
+
#include
#include
#include
#include
-namespace apache {
-namespace geode {
-namespace client {
+namespace {
-CPPCACHE_EXPORT void* testSpinLockCreate();
-CPPCACHE_EXPORT void testSpinLockAcquire(void* lock);
-CPPCACHE_EXPORT void testSpinLockRelease(void* lock);
-} // namespace client
-} // namespace geode
-} // namespace apache
+using apache::geode::util::concurrent::spinlock_mutex;
DUNIT_TASK(s1p1, Basic)
{
-void* lock = apache::geode::client::testSpinLockCreate();
-apache::geode::client::testSpinLockAcquire(lock);
-apache::geode::client::testSpinLockRelease(lock);
+spinlock_mutex s;
+{ std::lock_guard lk(s); }
--- End diff --
+1 to separate lines, @dgkimura you want to bump the thread and add this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #39: Add rat checks to travis-ci build
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/39 @PivotalSarge .ratignore is in the base dir of geode-native --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #245: native-client-software-grant - ClientMetadata::getServerLo...
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/245 @doribd yes, @fdaniel7 should close the PR on apache/geode/native-client-software-grant and then switch to https://github.com/apache/geode-native and re-open the PR there as appropriate. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #32: GEODE-2439: Replace c-style headers with c++ headers
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/32 @dgkimura STABLE tests passing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/30 @pivotal-jbarrett good question, @mmartell where do the files go to now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #28: Feature/geode 2440
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/28#discussion_r102809166
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -236,8 +236,8 @@ DUNIT_TASK_DEFINITION(CLIENT1,
CheckPrSingleHopForIntKeysTask_REGION)
try {
LOGDEBUG("CPPTEST: Putting key %d with hashcode %d", i,
- static_cast(keyPtr->hashcode()));
-dataReg->put(keyPtr, static_cast(keyPtr->hashcode()));
+ keyPtr->hashcode());
--- End diff --
Nothing better than seeing casting removed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102747970
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public
LocalRegion {
CacheableVectorPtr routingObj, uint8_t getResult,
ResultCollectorPtr rc, int32_t retryAttempts,
uint32_t timeout = DEFAULT_QUERY_RESPONSE_TIMEOUT);
- GfErrType getFuncAttributes(const char* func, std::vector** attr);
+ GfErrType getFuncAttributes(const char* func, std::vector**
attr);
--- End diff --
a vector** ya don't see those too often
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102743535 --- Diff: src/cppcache/src/PdxType.hpp --- @@ -89,7 +89,7 @@ class PdxType : public Serializable, int32_t* m_localToRemoteFieldMap; // TODO: - // int32 **m_positionMap; + // int32_t **m_positionMap; --- End diff -- TONOTGONNA HAPPEN is that TODO meant, let's dump this as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102756763
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -228,10 +228,10 @@ void ResourceInst::writeStatValue(StatisticDescriptor
*sd, int64 v) {
switch (typeCode) {
/* case GF_FIELDTYPE_BYTE:
-this->dataOut->writeByte((int8)v);
+this->dataOut->writeByte((int8_t)v);
--- End diff --
delete this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742761
--- Diff: src/cppcache/src/Log.cpp ---
@@ -732,7 +732,7 @@ void Log::put(LogLevel level, const char* msg) {
// struct dirent **resultArray;
// int entries_count = ACE_OS::scandir(dirname.c_str(), ,
// selector, comparator);
- // int64 spaceUsed = 0;
+ // int64_t spaceUsed = 0;
--- End diff --
dead code, could go
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102757059
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -434,17 +434,17 @@ void StatArchiveWriter::openFile(std::string
filename) {
/*
ACE_Time_Value now = ACE_OS::gettimeofday();
- int64 epochsec = now.sec();
- int64 initialDate = (int64)epochsec * 1000;
+ int64_t epochsec = now.sec();
--- End diff --
another block of dead code to be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102539038
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
for (int i = 0; i < PATH_MAX && path[i] != 0; i++) {
path[i] = ::tolower(path[i]);
}
- dllNamePtr = strstr(path, "apache-geode.dll");
+ std::string cppName = PRODUCT_LIB_NAME;
+ cppName += ".dll";
+ std::string dotNetName = PRODUCT_DLL_NAME;
+ dotNetName += ".dll";
+ dllNamePtr = strstr(path, cppName.c_str());
--- End diff --
fair nit 👍 will change it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102538789
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
$<TARGET_PROPERTY:_apache-geode,INTERFACE_INCLUDE_DIRECTORIES>
)
add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --
will adjust that. cmake did not like duplicate calls to
set_target_properites
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #24: GEODE-2508: Initial work on new approach to g...
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode-native/pull/24 GEODE-2508: Initial work on new approach to generic lib naming. Keeping the changes to CppCacheLibrary.cpp - did not, yet, find a CMake way to do it more seamlessly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2508 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit c3936e60af42b8a7287ac3554b73f0d6892ef764 Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-02-22T16:52:13Z GEODE-2508: Initial work on new approach to generic lib naming. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #19: GEODE-2508: Inital work on making lib names generic.
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/19 Closing to take different approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #19: GEODE-2508: Inital work on making lib names g...
Github user echobravopapa closed the pull request at: https://github.com/apache/geode-native/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #19: GEODE-2508: Inital work on making lib names g...
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode-native/pull/19 GEODE-2508: Inital work on making lib names generic. Just a sneak peak, I think I may have a couple tweaks/additions next week. You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode-native feature/GEODE-2508 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit 2aa2c5acb151ef08761e88290666f3e7e5c6546a Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-02-17T23:53:25Z GEODE-2508: Inital work on making lib names generic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #18: Revert "GEODE-2484 Replace ace calls to standard fun...
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/18 Wise choice, this can revisited in the future when the community has more time and inclination to make the jump to a toolchain with complete or more complete C++11 support. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #14: GEODE-348: fix cast to be in compliance with ...
Github user echobravopapa closed the pull request at: https://github.com/apache/geode-native/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #14: GEODE-348: fix cast to be in compliance with ...
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode-native/pull/14 GEODE-348: fix cast to be in compliance with standards. You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode-native feature/GEODE-348 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 4cfc8d9e58191bb4012d0c2ba25c46c646ac3e9e Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-02-15T22:28:02Z GEODE-348: fix cast to be in compliance with standards. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #11: GEODE-2486: Initialize OpenSSL for DEFAULT ci...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/11#discussion_r101287739
--- Diff: src/cryptoimpl/SSLImpl.cpp ---
@@ -52,25 +52,23 @@ SSLImpl::SSLImpl(ACE_SOCKET sock, const char
*pubkeyfile,
if (SSLImpl::s_initialized == false) {
ACE_SSL_Context *sslctx = ACE_SSL_Context::instance();
-SSL_CTX *opensslctx = sslctx->context();
-if (SSL_CTX_set_cipher_list(opensslctx, "eNULL:DEFAULT") == 0) {
- // if it fails here error is caught at connect.
-}
-// sslctx->set_mode(ACE_SSL_Context::SSLv23_client);
+SSL_CTX_set_cipher_list(sslctx->context(), "DEFAULT");
+sslctx->set_mode(ACE_SSL_Context::SSLv23_client);
--- End diff --
+1 for setting the mode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/391 @metatype in fact, we do have separate stories for the rest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/391 We should have separate stories/jiras for those items. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode/pull/391#discussion_r100191415
--- Diff: src/clicache/integration-test/CacheHelperN.cs ---
@@ -2389,7 +2389,7 @@ public static void KillJavaProcesses()
string commandline = item["CommandLine"].ToString();
Util.Log("processId:{0} name:{1}", item["ProcessId"],
item["Name"]);
- if (commandline.Contains("geode.jar"))
+ if (commandline.Contains("gemfire.jar"))
--- End diff --
We have a story to remove this as is unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/391 Conflicts are removed. ready for Merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode/pull/394#discussion_r99889754 --- Diff: .travis.yml --- @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +language: cpp +sudo: required + +before_install: + - sudo apt-get -qq update + - sudo apt-get -y build-essential + - sudo apt-get install -y cmake + - sudo apt-get install -y doxygen + - sudo apt-get install -y git + - sudo apt-get install -y openjdk-8-jdk + - sudo apt-get install -y wget + - sudo apt-get install -y zlib1g-dev + +install: mkdir build && cd build && cmake ../src && cmake --build . -- -j 8 --- End diff -- It is needed to build the javaobject(s)... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode/pull/394#discussion_r99858609 --- Diff: .travis.yml --- @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +language: cpp +sudo: required + +before_install: + - sudo apt-get -qq update + - sudo apt-get -y build-essential + - sudo apt-get install -y cmake + - sudo apt-get install -y doxygen + - sudo apt-get install -y git + - sudo apt-get install -y openjdk-8-jdk + - sudo apt-get install -y wget + - sudo apt-get install -y zlib1g-dev + +install: mkdir build && cd build && cmake ../src && cmake --build . -- -j 8 --- End diff -- The configuration step will need to be like so: `make ../src -DGEODE_ROOT= ` optionally one could add: `-DCMAKE_BUILD_TYPE=Debug` Debug is default unless Release is specified `-DPRODUCT_VERSION=maj.min.patch-build.N` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #386: Feature/geode 2421
Github user echobravopapa closed the pull request at: https://github.com/apache/geode/pull/386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #384: GEODE-2421: Adding packer portion of making a VS201...
Github user echobravopapa closed the pull request at: https://github.com/apache/geode/pull/384 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #384: GEODE-2421: Adding packer portion of making a VS201...
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode/pull/384 GEODE-2421: Adding packer portion of making a VS2015 dev AMI You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode feature/GEODE-2421 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #384 commit 22638e2c57f66d511a8cb16d68c76ace834c16d8 Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-02-02T22:03:10Z GEODE-2421: Adding packer portion of making a VS2015 dev AMI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #378: GEODE-2406: trimmed off the client from the product...
Github user echobravopapa closed the pull request at: https://github.com/apache/geode/pull/378 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #378: GEODE-2406: trimmed off the client from the product...
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode/pull/378 GEODE-2406: trimmed off the client from the product name. You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode feature/GEODE-2406 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/378.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #378 commit bff3a75870a94dec6f0d421162f5cd1fb4de5fa3 Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-01-31T23:58:23Z GEODE-2406: trimmed off the client from the product name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #375: GEODE-2365: Replace gemfire with geode in clicache ...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode/pull/375#discussion_r98735586
--- Diff: src/clicache/integration-test/CacheHelperN.cs ---
@@ -1877,7 +1878,7 @@ public static int getBaseLocatorPort()
}
try
{
-TextWriter tw = new
StreamWriter(Directory.GetCurrentDirectory() + "\\" + startDir +
"\\gemfire.properties", false);
+TextWriter tw = new
StreamWriter(Directory.GetCurrentDirectory() + "\\" + startDir +
"\\geode.properties", false);
--- End diff --
Does this impact integration tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #373: GEODE-2394: config Doxygen to use short names.
Github user echobravopapa closed the pull request at: https://github.com/apache/geode/pull/373 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #373: GEODE-2394: config Doxygen to use short names.
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode/pull/373 GEODE-2394: config Doxygen to use short names. Fixes the issue with Windows max file path length being exceeded. You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode feature/GEODE-2394 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/373.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #373 commit 9f6e1acc1f6d6e039b370adbdbdeee9d4191 Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-01-30T23:55:00Z GEODE-2394: config Doxygen to use short names. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #367: GEODE-2370: First pass at a CONTRIBUTING document.
Github user echobravopapa closed the pull request at: https://github.com/apache/geode/pull/367 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #371: [GEODE-2308] Change library names to for Apache Geode bran...
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/371 LGTM. Naming conventions make sense per platform and allow our library to fit into the given ecosystems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #367: GEODE-2370: First pass at a CONTRIBUTING document.
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode/pull/367 GEODE-2370: First pass at a CONTRIBUTING document. Just a start with into covering c++ formatting that is not in the BUILDING.md This can be expanded as the community desires... You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode feature/GEODE-2370 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #367 commit 89767eda28523d23bbffe7bf4fc475e14b39ef5f Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-01-26T23:21:13Z GEODE-2370: First pass at a CONTRIBUTING document. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #365: Feature/geode 2346
Github user echobravopapa closed the pull request at: https://github.com/apache/geode/pull/365 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #365: Feature/geode 2346
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode/pull/365 Feature/geode 2346 GemfireStatisticsFactory renaming You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode feature/GEODE-2346 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/365.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #365 commit 009be9b8e2a6784012b6d0d6800c2e57b65e1568 Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-01-24T22:33:28Z GEODE-2346: renamed Gemfire* to Geode* commit d1593a021ada899e663c79c39a95f9589b407fe2 Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-01-24T22:58:49Z GEODE-2346: rename inclusion of GeodeStatisticsFactory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #355: Feature/geode 2340
Github user echobravopapa closed the pull request at: https://github.com/apache/geode/pull/355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #355: Feature/geode 2340
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode/pull/355 Feature/geode 2340 third times a charm You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode feature/GEODE-2340 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #355 commit bc36026c2bc7607f511d37f9a39ddae5a07f4e51 Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-01-24T21:16:58Z GEODE-2340: rename files Gemfire* to Geode* commit 7a8d90d34cd96e488160e8bd9ecd6788d591de13 Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-01-24T21:25:03Z GEODE-2340: Renamed inclusion of the renamed files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #352: Feature/geode 2340
Github user echobravopapa closed the pull request at: https://github.com/apache/geode/pull/352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #352: Feature/geode 2340
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode/pull/352 Feature/geode 2340 First pass at renaming from Gemfire to Geode You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode feature/GEODE-2340 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/352.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #352 commit ec4091bff9eb44bad31b93eb9d17352705ce1eab Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-01-24T18:38:15Z GEODE-2340: Made Gemfire to Geode transformation commit cb5a92bfee647cccd6970e705d64e6ef08801780 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2016-12-17T07:17:34Z GEODE-2307: Initial commit of FindGeode.cmake module. commit 12d247c15e027890b1ed3cac84c90ec055ab8261 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-13T20:36:52Z GEODE-2305: Removed Pivotal_EULA.txt from the packaging. commit fd1c7011fb373f52a7365de9fc4dab3dd5e689eb Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-16T22:46:40Z GEODE-2310: Fixed path to Geode jar. commit 79a4b46fc3ab895d684436c6c962e14e6cfea7d5 Author: Sarge <mdo...@pivotal.io> Date: 2017-01-17T01:20:00Z GEODE-2306: Update the build instructions for GEMFIRE_HOME. commit 41ea2798b4040d67a6b858be9be41d9a4d27e0b2 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-17T04:35:24Z GEODE-2308: Rebranded from GemFire to Geode. commit d478344e7e35e6a10f71abac86531cb79cb3029d Author: Sarge <mdo...@pivotal.io> Date: 2017-01-17T15:16:59Z GEODE-2306: Update the build instructions for GEODE_ROOT. commit c685816691b7924dcb3fbdfbee9f9c4165b49699 Author: Sarge <mdo...@pivotal.io> Date: 2017-01-17T15:43:27Z GEODE-2306: Mark Doxygen as required and fix typo. commit 549cd4398a00459280e4a06a4ee7c5d4689e927a Author: Sarge <mdo...@pivotal.io> Date: 2017-01-17T23:34:56Z GEODE-2306: Moved BUILDING.md to the root. commit 2d8e4040353c0e8d840a145550b9265760862b73 Author: Sarge <mdo...@pivotal.io> Date: 2017-01-18T00:29:04Z GEODE-2306: Extract generator, Geode, and installation instructions into separate sections. This closes #341 commit 73c70bc507a05b875f294069f5033310d5c23779 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-17T06:45:45Z GEODE-2309: Replace Pivotal Copyright and add Apache License notice. commit 6c88ba4e159d7d81caf8fc733cbdcfb4efe98637 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-18T04:07:59Z GEODE-2316: Cleanup headers in preparation for namespace change. - Fixup headers using clang-tidy that were missed in the orginal source cleanup. commit cd9a5f43028b263994faedf3311fb3ce063ab751 Author: Mike Martell <mmart...@pivotal.io> Date: 2017-01-18T05:08:48Z GEODE-2311: Add cmake support for building the C# security dll used by the C# security quickstarts. This closes #345 commit ad03b438207e0969a34fa4d5ac6e762972e88758 Author: Anthony Baker <aba...@apache.org> Date: 2017-01-18T05:14:45Z GEODE-1435 Update LICENSE and NOTICE This closes #343 commit 37afa10afe3f4e1393787ef28b91507388fc2538 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-18T22:22:48Z GEODE-2316: Rename namespace gemfire to apache::geode::client. commit f0e675cf58d777b2573b9fb787547fd60d624bc9 Author: David Kimura <dkim...@pivotal.io> Date: 2017-01-19T02:14:26Z GEODE-2326: Adjust testLogger hardcoded value This closes #346 commit a9355b6d314e1275dd568ca59ce1cd4ae21e5059 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-19T04:17:35Z GEODE-2316: Renamed namespace gemfire_statistics to apache::geode::statistics. commit 8454ac7605279f3e952fdb3cf0636617621fe616 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-19T04:49:15Z GEODE-2316: Rename some minor namespaces. - gemfire_impl -> apache::geode::client::impl - gemfire_log_globals -> apache::geode::log::globals - gemfire_stats_globals -> apache::geode::statistics::globals commit 55793f7bdc6a2e491840ca03c67774b57b824808 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-20T05:32:56Z GEODE-2316: Renamed namespace GemStone.GemFire.Cache -> Apache.Geode.Client - GemStone.GemFire.Cache -> Apache.Geode.Client - GemStone.GemFire -> Apache.Geode commit 93e875e967f5aaaf95b8167963b471a38e984b00 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-21T01:20:31Z GEODE-2316: Removed namespace Apache.Geode.Client.Generic. commit 738ec356d0590d4c39a229ba67a04978ca84bb12 Author: Jacob Barrett <jbarr...@pivotal.io> Date: 2017-01-21T05:45
[GitHub] geode issue #351: GEODE-2340: Made Gemfire to Geode transformation
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/351 Will redo to alleviate conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #351: GEODE-2340: Made Gemfire to Geode transformation
Github user echobravopapa closed the pull request at: https://github.com/apache/geode/pull/351 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #351: GEODE-2340: Made Gemfire to Geode transformation
GitHub user echobravopapa opened a pull request: https://github.com/apache/geode/pull/351 GEODE-2340: Made Gemfire to Geode transformation First pass of making file(s) named Gemfire* into Geode* You can merge this pull request into a Git repository by running: $ git pull https://github.com/echobravopapa/geode feature/GEODE-2340 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/351.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #351 commit ec4091bff9eb44bad31b93eb9d17352705ce1eab Author: Ernest Burghardt <eburgha...@pivotal.io> Date: 2017-01-24T18:38:15Z GEODE-2340: Made Gemfire to Geode transformation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #350: Feature/geode 2316
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/350 +1 on the renaming +1 on marking the closing braces too +1 modernizing the casting +1 on the language specific consistencies LGTM, Ship It! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
