[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037320#comment-16037320 ] ASF subversion and git services commented on GEODE-269: --- Commit 05b736442ccf716cd6de5f00fce5d221e703a5e7 in geode's branch refs/heads/develop from [~deepakddixit] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=05b7364 ] GEODE-269 : SpotlessApply changes. > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037318#comment-16037318 ] ASF subversion and git services commented on GEODE-269: --- Commit ad9e30254d0d0d39ecda94b04ae8b8eedce95d36 in geode's branch refs/heads/develop from [~deepakddixit] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ad9e302 ] GEODE-269 : Fixing RollingUpgrade2DUnitTest. After removing deprecated API withArgs, setArgument alternative API is not available in older version of server causing NoSuchMethodFound exception. The role of setArgument with function is passing class name to load inside the function. As the relevant function is used on in the context of this test, instead of using setArgument method made class name as a field in GetDataSerializableFunction. > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020688#comment-16020688 ] ASF GitHub Bot commented on GEODE-269: -- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/526 > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020687#comment-16020687 ] ASF subversion and git services commented on GEODE-269: --- Commit 18db4bf382ffbf16de04f5d3dc9462677af341e4 in geode's branch refs/heads/develop from [~deepakddixit] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=18db4bf ] GEODE-269 : Removing deprecated API's from FunctionService. * Modified test cases after removing deprecated API's This closes #526 > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020654#comment-16020654 ] ASF GitHub Bot commented on GEODE-269: -- Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/526 Working on merging this change > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020642#comment-16020642 ] ASF GitHub Bot commented on GEODE-269: -- GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/526 GEODE-269 : Removing deprecated API's from FunctionService. Modified test cases after removing deprecated API's Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? Yes.GEODE-269 - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? Yes - [x] Does `gradlew build` run cleanly? Yes - [x] Have you written or updated unit tests to verify your changes? Updated existing test cases. - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? No new dependencies added ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/deepakddixit/incubator-geode GEODE-269 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/526.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #526 commit 4d1663fde42272dcb730d490afe553725442ef37 Author: Deepak Dixit Date: 2017-05-23T04:17:13Z GEODE-269 : Removing deprecated API's from FunctionService. Modified test cases after removing deprecated API's > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020237#comment-16020237 ] ASF subversion and git services commented on GEODE-269: --- Commit b47450667cc608c711e94cfd84f44aef5193345a in geode's branch refs/heads/develop from [~huynhja] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b474506 ] Revert "GEODE-269: Removing deprecated API's from FunctionService." This reverts commit 7da9047a21f6b677066a107c5d378540b5e8b3fd. Reverting pull request completely, will wait for a new pull request without conflict > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020234#comment-16020234 ] ASF subversion and git services commented on GEODE-269: --- Commit 7da9047a21f6b677066a107c5d378540b5e8b3fd in geode's branch refs/heads/develop from [~huynhja] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=7da9047 ] GEODE-269: Removing deprecated API's from FunctionService. This closes #511 > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020230#comment-16020230 ] ASF subversion and git services commented on GEODE-269: --- Commit 4e3a4d762d7caaea21153bbc5c15205b0f0799d9 in geode's branch refs/heads/develop from [~nnag] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=4e3a4d7 ] Revert "Merge branch 'feature/GEODE-269' of https://github.com/deepakddixit/incubator-geode into develop" This reverts commit 227f08be636d12d5e4a268a7039acae528c341d4, reversing changes made to aa189b1a620e543c5fabf007384612f20376be4c. > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020229#comment-16020229 ] ASF subversion and git services commented on GEODE-269: --- Commit 72dbd81e8bac9d420674a92e3e39ee61b2e6d98c in geode's branch refs/heads/develop from [~nnag] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=72dbd81 ] Revert "GEODE-269: spotlessApply on merge resolution" This reverts commit f1280fe89984b6f5034708524db6278ec476439b. > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020198#comment-16020198 ] ASF subversion and git services commented on GEODE-269: --- Commit 3054de42d38aa8bfadd8912f0ab4dde259a701ef in geode's branch refs/heads/develop from [~deepakddixit] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3054de4 ] GEODE-269 : Resolving conflicts with develop. > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020200#comment-16020200 ] ASF GitHub Bot commented on GEODE-269: -- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/511 > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020196#comment-16020196 ] ASF subversion and git services commented on GEODE-269: --- Commit e2f337a23303822f8cd28bc887afca7203759673 in geode's branch refs/heads/develop from [~deepakddixit] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e2f337a ] GEODE-269 : Removing deprecated API's from FunctionService. > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020197#comment-16020197 ] ASF subversion and git services commented on GEODE-269: --- Commit 929687e28335ee5ace679be5c540857080afd48f in geode's branch refs/heads/develop from [~deepakddixit] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=929687e ] GEODE-269 : Resolving conflicts with develop. > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020201#comment-16020201 ] ASF subversion and git services commented on GEODE-269: --- Commit f1280fe89984b6f5034708524db6278ec476439b in geode's branch refs/heads/develop from [~huynhja] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f1280fe ] GEODE-269: spotlessApply on merge resolution > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020199#comment-16020199 ] ASF subversion and git services commented on GEODE-269: --- Commit 227f08be636d12d5e4a268a7039acae528c341d4 in geode's branch refs/heads/develop from [~huynhja] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=227f08b ] Merge branch 'feature/GEODE-269' of https://github.com/deepakddixit/incubator-geode into develop > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (GEODE-269) Remove deprecated methods on FunctionService
[ https://issues.apache.org/jira/browse/GEODE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007815#comment-16007815 ] ASF GitHub Bot commented on GEODE-269: -- GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/511 Feature/geode 269 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? Yes. JIRA reference is GEODE-269. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? Yes. - [ ] Is your initial contribution a single, squashed commit? No. It is multiple commit, one actual code change and other is resolving conflict with latest develop - [ ] Does `gradlew build` run cleanly? Yes - [ ] Have you written or updated unit tests to verify your changes? Updated unit tests - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? Not adding dependencies. ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/deepakddixit/incubator-geode feature/GEODE-269 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #511 commit e2f337a23303822f8cd28bc887afca7203759673 Author: Deepak Dixit Date: 2017-05-10T16:52:03Z GEODE-269 : Removing deprecated API's from FunctionService. commit 929687e28335ee5ace679be5c540857080afd48f Author: Deepak Dixit Date: 2017-05-12T08:33:39Z GEODE-269 : Resolving conflicts with develop. commit 3054de42d38aa8bfadd8912f0ab4dde259a701ef Author: Deepak Dixit Date: 2017-05-12T08:38:21Z GEODE-269 : Resolving conflicts with develop. > Remove deprecated methods on FunctionService > > > Key: GEODE-269 > URL: https://issues.apache.org/jira/browse/GEODE-269 > Project: Geode > Issue Type: Sub-task >Reporter: Darrel Schneider >Assignee: Deepak Dixit > Original Estimate: 4h > Remaining Estimate: 4h > > FunctionService has a three deprecated methods that should be easy to remove. > All the deprecated methods have a DistributedSystem parameter. New flavors of > these methods exist that do not take the DistributedSystem since it is known > implicitly by the FunctionService. > Many tests use the deprecated methods but it should be easy to change them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
