[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014346#comment-16014346
 ] 

ASF GitHub Bot commented on GEODE-2900:
---

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/502


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011133#comment-16011133
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit 161a9a085a6b354e4e64b275346a680b7addfa38 in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=161a9a0 ]

GEODE-2900:  push shadow key back into the front of the eventSeqNumber "Queue"


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008991#comment-16008991
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit 3c55bd7fafcec99a1d8f3fa297a01b0343f6bf5f in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3c55bd7 ]

commit ef5f9a09822eb9a0cd207c8ef183587654beacd8
Merge: 4ad543d 1252cae
Author: Jason Huynh 
Date:   Fri May 12 16:32:23 2017 -0700

Merge branch 'develop' into feature/GEODE-2900

commit 4ad543d600da57185cee5c6714df876d83f751c7
Author: Jason Huynh 
Date:   Fri May 12 16:24:05 2017 -0700

Fix for NPE with stateflush

commit b95ed3c9d1226b5acf3afc5b3261da29230151eb
Author: Jason Huynh 
Date:   Fri May 12 15:18:35 2017 -0700

Fixing failing test

commit da95ce199f1ec87e7466c14910411e89a3981e36
Author: Jason Huynh 
Date:   Fri May 12 10:12:46 2017 -0700

StateFlush changes

commit 5b37efbd75631b99a24b533b62e5f31d7a2a7b4f
Author: Jason Huynh 
Date:   Fri May 12 10:12:35 2017 -0700

NPE check

commit bbf016376b76c501f3051521ac46b995f6795781
Author: Jason Huynh 
Date:   Tue May 9 15:29:12 2017 -0700

GEODE-2900: spotlessApply

commit 5b4e4330678f9eb49df2e647a9dd0a0f015d8047
Author: Jason Huynh 
Date:   Tue May 9 14:40:42 2017 -0700

GEODE-2900: Renamed method and changed some code comments

commit 240b469ff217fbfba39381f196ae3e0e832a69a6
Author: Jason Huynh 
Date:   Tue May 9 10:11:39 2017 -0700

GEODE-2900:  push shadow key back into the front of the eventSeqNumber 
"Queue"


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008992#comment-16008992
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit 3c55bd7fafcec99a1d8f3fa297a01b0343f6bf5f in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3c55bd7 ]

commit ef5f9a09822eb9a0cd207c8ef183587654beacd8
Merge: 4ad543d 1252cae
Author: Jason Huynh 
Date:   Fri May 12 16:32:23 2017 -0700

Merge branch 'develop' into feature/GEODE-2900

commit 4ad543d600da57185cee5c6714df876d83f751c7
Author: Jason Huynh 
Date:   Fri May 12 16:24:05 2017 -0700

Fix for NPE with stateflush

commit b95ed3c9d1226b5acf3afc5b3261da29230151eb
Author: Jason Huynh 
Date:   Fri May 12 15:18:35 2017 -0700

Fixing failing test

commit da95ce199f1ec87e7466c14910411e89a3981e36
Author: Jason Huynh 
Date:   Fri May 12 10:12:46 2017 -0700

StateFlush changes

commit 5b37efbd75631b99a24b533b62e5f31d7a2a7b4f
Author: Jason Huynh 
Date:   Fri May 12 10:12:35 2017 -0700

NPE check

commit bbf016376b76c501f3051521ac46b995f6795781
Author: Jason Huynh 
Date:   Tue May 9 15:29:12 2017 -0700

GEODE-2900: spotlessApply

commit 5b4e4330678f9eb49df2e647a9dd0a0f015d8047
Author: Jason Huynh 
Date:   Tue May 9 14:40:42 2017 -0700

GEODE-2900: Renamed method and changed some code comments

commit 240b469ff217fbfba39381f196ae3e0e832a69a6
Author: Jason Huynh 
Date:   Tue May 9 10:11:39 2017 -0700

GEODE-2900:  push shadow key back into the front of the eventSeqNumber 
"Queue"


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008994#comment-16008994
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit 3c55bd7fafcec99a1d8f3fa297a01b0343f6bf5f in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3c55bd7 ]

commit ef5f9a09822eb9a0cd207c8ef183587654beacd8
Merge: 4ad543d 1252cae
Author: Jason Huynh 
Date:   Fri May 12 16:32:23 2017 -0700

Merge branch 'develop' into feature/GEODE-2900

commit 4ad543d600da57185cee5c6714df876d83f751c7
Author: Jason Huynh 
Date:   Fri May 12 16:24:05 2017 -0700

Fix for NPE with stateflush

commit b95ed3c9d1226b5acf3afc5b3261da29230151eb
Author: Jason Huynh 
Date:   Fri May 12 15:18:35 2017 -0700

Fixing failing test

commit da95ce199f1ec87e7466c14910411e89a3981e36
Author: Jason Huynh 
Date:   Fri May 12 10:12:46 2017 -0700

StateFlush changes

commit 5b37efbd75631b99a24b533b62e5f31d7a2a7b4f
Author: Jason Huynh 
Date:   Fri May 12 10:12:35 2017 -0700

NPE check

commit bbf016376b76c501f3051521ac46b995f6795781
Author: Jason Huynh 
Date:   Tue May 9 15:29:12 2017 -0700

GEODE-2900: spotlessApply

commit 5b4e4330678f9eb49df2e647a9dd0a0f015d8047
Author: Jason Huynh 
Date:   Tue May 9 14:40:42 2017 -0700

GEODE-2900: Renamed method and changed some code comments

commit 240b469ff217fbfba39381f196ae3e0e832a69a6
Author: Jason Huynh 
Date:   Tue May 9 10:11:39 2017 -0700

GEODE-2900:  push shadow key back into the front of the eventSeqNumber 
"Queue"


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008993#comment-16008993
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit 3c55bd7fafcec99a1d8f3fa297a01b0343f6bf5f in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3c55bd7 ]

commit ef5f9a09822eb9a0cd207c8ef183587654beacd8
Merge: 4ad543d 1252cae
Author: Jason Huynh 
Date:   Fri May 12 16:32:23 2017 -0700

Merge branch 'develop' into feature/GEODE-2900

commit 4ad543d600da57185cee5c6714df876d83f751c7
Author: Jason Huynh 
Date:   Fri May 12 16:24:05 2017 -0700

Fix for NPE with stateflush

commit b95ed3c9d1226b5acf3afc5b3261da29230151eb
Author: Jason Huynh 
Date:   Fri May 12 15:18:35 2017 -0700

Fixing failing test

commit da95ce199f1ec87e7466c14910411e89a3981e36
Author: Jason Huynh 
Date:   Fri May 12 10:12:46 2017 -0700

StateFlush changes

commit 5b37efbd75631b99a24b533b62e5f31d7a2a7b4f
Author: Jason Huynh 
Date:   Fri May 12 10:12:35 2017 -0700

NPE check

commit bbf016376b76c501f3051521ac46b995f6795781
Author: Jason Huynh 
Date:   Tue May 9 15:29:12 2017 -0700

GEODE-2900: spotlessApply

commit 5b4e4330678f9eb49df2e647a9dd0a0f015d8047
Author: Jason Huynh 
Date:   Tue May 9 14:40:42 2017 -0700

GEODE-2900: Renamed method and changed some code comments

commit 240b469ff217fbfba39381f196ae3e0e832a69a6
Author: Jason Huynh 
Date:   Tue May 9 10:11:39 2017 -0700

GEODE-2900:  push shadow key back into the front of the eventSeqNumber 
"Queue"


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003670#comment-16003670
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit bbf016376b76c501f3051521ac46b995f6795781 in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=bbf0163 ]

GEODE-2900: spotlessApply


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: lucene, wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."
> This also affects the Lucene implementation.  An stuck event can mean 
> incorrectly indexed data or data inconsistencies



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003610#comment-16003610
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit 5b4e4330678f9eb49df2e647a9dd0a0f015d8047 in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5b4e433 ]

GEODE-2900: Renamed method and changed some code comments


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003099#comment-16003099
 ] 

ASF GitHub Bot commented on GEODE-2900:
---

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/502

GEODE-2900:  push shadow key to the front of eventSeqNumQueue

Testing still needs to be done on this change, but wanted to get some 
eyeballs on the change in parallel

@upthewaterspout @boglesby 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2900

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #502


commit 240b469ff217fbfba39381f196ae3e0e832a69a6
Author: Jason Huynh 
Date:   2017-05-09T17:11:39Z

GEODE-2900:  push shadow key back into the front of the eventSeqNumber 
"Queue"




> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2900) BucketRegionQueue transitions from primary/secondary/primary can lead to events lingering in queue

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003084#comment-16003084
 ] 

ASF subversion and git services commented on GEODE-2900:


Commit 240b469ff217fbfba39381f196ae3e0e832a69a6 in geode's branch 
refs/heads/feature/GEODE-2900 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=240b469 ]

GEODE-2900:  push shadow key back into the front of the eventSeqNumber "Queue"


> BucketRegionQueue transitions from primary/secondary/primary can lead to 
> events lingering in queue
> --
>
> Key: GEODE-2900
> URL: https://issues.apache.org/jira/browse/GEODE-2900
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> In this scenario when peek() is called from BucketRegionQueue, a side effect 
> is that the key is removed from the eventSeqNumQueue and an event is placed 
> into the peekedEvents list.
> If there is failure dispatching the event, we add the peekedEvents list to a 
> new peekedEvents list.  Before doing so, we remove any events that we are not 
> primary for.  Now the event is not in the eventSeqNumQueue or the 
> peekedEvents list
> If we now become primary (before the other node could dispatch this event), 
> and because we do not have that event in the eventSeqNumQueue or the 
> peekedEvents, it gets "stuck."



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)