date:20170802

[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

2017-08-02 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/671#discussion_r131002611
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java
 ---
@@ -1143,4 +721,26 @@ private boolean 
isAttributePersistent(RegionAttributes attributes) {
 return attributes != null && attributes.getDataPolicy() != null
 && attributes.getDataPolicy().toString().contains("PERSISTENT");
   }
+
+  private static boolean regionExists(InternalCache cache, String 
regionPath) {
--- End diff --

Fixed! Thanks for your feedback! Do you mean it would be nice to have a 
test that would fail if `regionExists` always returns `true`, regardless of 
whether the region does or doesn't exist? I wrote a very simple test that does 
this and put it in `CreateRegionCommandTest`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #679: GEODE-3340: Refactor ConfigCommandsDUnitTest to use...

2017-08-02 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/679#discussion_r131003469
  
--- Diff: 
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.ENABLE_TIME_STATISTICS;
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.LOG_LEVEL;
+import static 
org.apache.geode.distributed.ConfigurationProperties.STATISTIC_SAMPLING_ENABLED;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.distributed.internal.ClusterConfigurationService;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogWriterImpl;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+
+@Category(DistributedTest.class)
+@RunWith(JUnitParamsRunner.class)
+public class ConfigCommandDUnitTest {
--- End diff --

I think this move made it possible to run this test over HTTP without 
needing to run it through `CommandOverHttpDUnitTest`, since we are trying to 
get rid of `CommandOverHttpDUnitTest` anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #635 was SUCCESSFUL (with 2024 tests)

2017-08-02 Thread Spring CI


---
Spring Data GemFire > Nightly-ApacheGeode > #635 was successful.
---
Scheduled
2026 tests in total.

https://build.spring.io/browse/SGF-NAG-635/





--
This message is automatically generated by Atlassian Bamboo

RE: Stored procedures on Apache Geode.

2017-08-02 Thread marios390

Hi John,

Thanks a lot for getting back to me. This is the example am trying ,

 
https://github.com/jxblum/contacts-application/blob/master/configuration-example/src/main/java/example/app/spring/annotation/geode/server/AnnotationConfiguredGeodeServerApplication.java

Please find below the output along with errors:


2017-08-02 22:12:22.867  INFO 721 --- [   main] 
d.a.a.server.GeodeRepositoryApplication  : Starting GeodeRepositoryApplication 
on AdminisatorsMBP.fritz.box with PID 721 
(/Users/csukmsss/workspace/GeodeRepository/target/classes started by csukmsss 
in /Users/csukmsss/workspace/GeodeRepository)
2017-08-02 22:12:22.870  INFO 721 --- [   main] 
d.a.a.server.GeodeRepositoryApplication  : No active profile set, falling back 
to default profiles: default
2017-08-02 22:12:22.955  INFO 721 --- [   main] 
s.c.a.AnnotationConfigApplicationContext : Refreshing 
org.springframework.context.annotation.AnnotationConfigApplicationContext@37e547da:
 startup date [Wed Aug 02 22:12:22 EEST 2017]; root of context hierarchy
2017-08-02 22:12:23.847  WARN 721 --- [   main] 
s.c.a.AnnotationConfigApplicationContext : Exception encountered during context 
initialization - cancelling refresh attempt: 
org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
creating bean with name 'gemfireCacheServer' defined in 
org.springframework.data.gemfire.config.annotation.CacheServerConfiguration: 
Unsatisfied dependency expressed through method 'gemfireCacheServer' parameter 
0; nested exception is org.springframework.beans.factory.BeanCreationException: 
Error creating bean with name 'gemfireCache' defined in 
org.springframework.data.gemfire.config.annotation.CacheServerConfiguration: 
Bean instantiation via factory method failed; nested exception is 
org.springframework.beans.BeanInstantiationException: Failed to instantiate 
[org.springframework.data.gemfire.CacheFactoryBean]: Factory method 
'gemfireCache' threw exception; nested exception is 
java.lang.NoSuchMethodError: 
org.springframework.data.gemfire.util.CollectionUtils.nullSafeList(Ljava/util/List;)Ljava/util/List;
2017-08-02 22:12:23.855  INFO 721 --- [   main] 
utoConfigurationReportLoggingInitializer :

Error starting ApplicationContext. To display the auto-configuration report 
re-run your application with 'debug' enabled.
2017-08-02 22:12:23.864 ERROR 721 --- [   main] 
o.s.boot.SpringApplication   : Application startup failed

org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
creating bean with name 'gemfireCacheServer' defined in 
org.springframework.data.gemfire.config.annotation.CacheServerConfiguration: 
Unsatisfied dependency expressed through method 'gemfireCacheServer' parameter 
0; nested exception is org.springframework.beans.factory.BeanCreationException: 
Error creating bean with name 'gemfireCache' defined in 
org.springframework.data.gemfire.config.annotation.CacheServerConfiguration: 
Bean instantiation via factory method failed; nested exception is 
org.springframework.beans.BeanInstantiationException: Failed to instantiate 
[org.springframework.data.gemfire.CacheFactoryBean]: Factory method 
'gemfireCache' threw exception; nested exception is 
java.lang.NoSuchMethodError: 
org.springframework.data.gemfire.util.CollectionUtils.nullSafeList(Ljava/util/List;)Ljava/util/List;
at 
org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:749)
 ~[spring-beans-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:467)
 ~[spring-beans-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1173)
 ~[spring-beans-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1067)
 ~[spring-beans-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:513)
 ~[spring-beans-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:483)
 ~[spring-beans-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306)
 ~[spring-beans-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
 ~[spring-beans-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)

Re: Stored procedures on Apache Geode.

2017-08-02 Thread John Blum

Hi Marios-

Any application config annotated with @PeerCacheApplication /
@CacheServerApplication, or CacheFactoryBean directly in *JavaConfig*, or
 in XML, is a Geode (GemFire) Server, a peer member of the
distributed system (cluster) defined by a Locator.

For instance, I can...

gfsh>start locator --name=*LocatorX* --log-level=config
gfsh>start server --name=*ServerA* --disable-default-server
--log-level=config
gfsh>start server --name=*ServerB* --disable-default-server
--log-level=config

Then run the configuration-example,
AnnotationConfiguredGeodeServerApplication class from my IDE, modified as
so..

@SpringBootApplication
@CacheServerApplication(name = "AnnotationConfiguredGeodeServerApplication",
 port = AnnotationConfiguredGeodeServerApplication.GEODE_CACHE_SERVER_PORT,
*locators
= **"localhost[10334]"*)
@EnableCacheServers(servers = { @EnableCacheServer(port = 12480),
@EnableCacheServer(port = 40404) })
//@EnableLocator
//@EnableManager
...
@Import(EchoServerApplicationConfiguration.class)
public class AnnotationConfiguredGeodeServerApplication {
  ...
}

And then...

gfsh>list members
   Name| Id
-- |
--
*LocatorX*   |
10.99.199.5(LocatorX:57545:locator):1024
*ServerA*|
10.99.199.5(ServerA:57572):1025
*ServerB*|
10.99.199.5(ServerB:57579):1026
*AnnotationConfiguredGeodeServerApplication* |
10.99.199.5(AnnotationConfiguredGeodeServerApplication:57594):1027

Alternatively, I can...


@SpringBootApplication
@CacheServerApplication(name = "AnnotationConfiguredGeodeServerApplication",
  port = AnnotationConfiguredGeodeServerApplication.GEODE_CACHE_SERVER_PORT)
@EnableCacheServers(servers = { @EnableCacheServer(port = 12480),
@EnableCacheServer(port = 40404) })
@EnableLocator
@EnableManager
//@EnableSsl(components = { EnableSsl.Component.SERVER },
// keystore =
"/Users/jblum/pivdev/springonePlatform-2016/configuration-example/etc/geode/security/trusted.keystore",
// keystorePassword = "s3cr3t",
// keystoreType = "JKS",
// truststore =
"/Users/jblum/pivdev/springonePlatform-2016/configuration-example/etc/geode/security/trusted.keystore",
// truststorePassword = "s3cr3t")
@Import(EchoServerApplicationConfiguration.class)
public class AnnotationConfiguredGeodeServerApplication {
  ...
}


That is comment our SSL config, and run the *Spring* class as is.

NOTE: you can run with SSL, but then you must config all servers and
clients connecting to this Locator to use SSL.  This just simplifies
running the example with minimal fuss (such as when starting
Locators/Servers from *Gfsh*, where configuring SSL is much more difficult
to do successfully).

This example is running both an embedded *Locator* (on port 10334, by
default) and has enabled the *Manager* service (on port 1099, by default)
for JMX clients to connect (like *Gfsh*).  The *CacheServers* are
irrelevant for this demonstration.

Now, *without* even being connected, I can start several servers in *Gfsh*
and connect to this application (NOTE: the application must be running),
which again, is a *Spring Boot(ed)* GemFire peer cache member of the DS
(cluster that it forms with the *Locator* endpoint, namely...
localhost[10334]).

NOTE: the @EnableLocator annotation does let you change the embedded
*Locator's* port if you like.  Additionally, the @EnableManager annotation
allows you to change the port of the embedded *Manager* as well.

Ok, my application (AnnotationConfiguredGeodeServerApplication) is running
and I am not (yet) connected in *Gfsh*...

gfsh>list members
Command 'list members' was found but is not currently available (type
'help' then ENTER to learn about this command)

Then, I start some server (in a disconnected state)...

gfsh>start server --name=ServerA --disable-default-server
--log-level=config *--locators=localhost[10334]*
gfsh>start server --name=ServerB --disable-default-server
--log-level=config *--locators=localhost[10334]*

Now, I connect...

gfsh>connect
Connecting to Locator at [host=localhost, port=10334] ..
Connecting to Manager at [host=10.99.199.5, port=1099] ..
Successfully connected to: [host=10.99.199.5, port=1099]

And `list members`...

gfsh>list members
   Name| Id
-- |
--
*AnnotationConfiguredGeodeServerApplication* |
10.99.199.5(AnnotationConfiguredGeodeServerApplication:57663):1024
*ServerA*|
10.99.199.5(ServerA:57704):1025
*ServerB*|
10.99.199.5(ServerB:57711):1026


As some people seem to think "MAGIC", ;-)

After I am connected in *Gfsh* (to the
AnnotationConfiguredGeodeServerApplication application), I can even start
another Geode Server and

[GitHub] geode pull request #679: GEODE-3340: Refactor ConfigCommandsDUnitTest to use...

2017-08-02 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/679#discussion_r131003075
  
--- Diff: 
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.ENABLE_TIME_STATISTICS;
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.LOG_LEVEL;
+import static 
org.apache.geode.distributed.ConfigurationProperties.STATISTIC_SAMPLING_ENABLED;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.distributed.internal.ClusterConfigurationService;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogWriterImpl;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+
+@Category(DistributedTest.class)
+@RunWith(JUnitParamsRunner.class)
+public class ConfigCommandDUnitTest {
+  @Rule
+  public LocatorServerStartupRule startupRule = new 
LocatorServerStartupRule();
+
+  @Rule
+  public GfshShellConnectionRule gfsh = new GfshShellConnectionRule();
+
+  @Rule
+  public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+  @Test
+  @Parameters({"true", "false"})
+  public void testDescribeConfig(final boolean connectOverHttp) throws 
Exception {
+Properties localProps = new Properties();
+localProps.setProperty(STATISTIC_SAMPLING_ENABLED, "true");
+localProps.setProperty(ENABLE_TIME_STATISTICS, "true");
+localProps.setProperty(GROUPS, "G1");
+MemberVM server0 = startupRule.startServerAsJmxManager(0, localProps);
+
+if (connectOverHttp) {
+  gfsh.connectAndVerify(server0.getHttpPort(), 
GfshShellConnectionRule.PortType.http);
+} else {
+  gfsh.connectAndVerify(server0.getJmxPort(), 
GfshShellConnectionRule.PortType.jmxManger);
+}
+
+server0.invoke(() -> {
+  InternalCache cache = 
LocatorServerStartupRule.serverStarter.getCache();
+  InternalDistributedSystem system = 
cache.getInternalDistributedSystem();
+  DistributionConfig config = system.getConfig();
+  config.setArchiveFileSizeLimit(1000);
+});
+
+gfsh.executeAndVerifyCommand("describe config --member=" + 
server0.getName());
+String result = gfsh.getGfshOutput();
+
+assertThat(result).contains("enable-time-statistics   
: true");
--- End diff --

Fixed! Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is

[GitHub] geode pull request #680: GEODE-3257: Refactoring DeployCommands

2017-08-02 Thread YehEmily

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/680

GEODE-3257: Refactoring DeployCommands

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3257)

**Testing Status: Precheckin to be run on morning of 8/3**

- [x] JIRA ticket

- [x] PR rebased

- [x] Commit single & squashed

- [x] `gradlew build` runs cleanly

- [ ] Tests to be updated with 
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #680


commit db50d331c54ec4c8ed7f583685c78002c91c7bde
Author: YehEmily 
Date:   2017-08-03T00:28:10Z

GEODE-3257: Refactoring DeployCommands




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #677: GEODE-3038: A server process shuts down quietly whe...

2017-08-02 Thread dschneider-pivotal

Github user dschneider-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/677#discussion_r131003885
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
---
@@ -1208,6 +1208,9 @@ private void initialize() {
   this.system.getConfig());
   initializeDeclarativeCache();
   completedCacheXml = true;
+} catch (CacheXmlException e) {
--- End diff --

It looks like a number of exceptions can be thrown from 
initializeDeclarativeCache.
Would it be better to catch, log, and rethrow RuntimeException instead of 
CacheXmlException?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-02 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/651#discussion_r130959623
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
 ---
@@ -633,8 +631,8 @@ public DataCommandResult put(String key, String value, 
boolean putIfAbsent, Stri
   try {
 keyObject = getClassObject(key, keyClass);
   } catch (ClassNotFoundException e) {
-return DataCommandResult.createPutResult(key, null, null,
-"ClassNotFoundException " + keyClass, false);
+return DataCommandResult.createPutResult(key, null, 
e.getException(),
--- End diff --

Fixed - thanks for your feedback!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-02 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/651#discussion_r130959557
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/Launcher.java 
---
@@ -99,7 +99,6 @@ protected Launcher() {
 this.allowedCommandLineCommands.add(CliStrings.START_JCONSOLE);
 this.allowedCommandLineCommands.add(CliStrings.START_JVISUALVM);
 this.allowedCommandLineCommands.add(CliStrings.START_LOCATOR);
-this.allowedCommandLineCommands.add(CliStrings.START_MANAGER);
--- End diff --

Sure! Almost none of the `--- manager` CliStrings were used, so I deleted 
them. Only `start manager` was ever used, and only in this place, so I figured 
it would be safe to get rid of it. Do you think this might break any backwards 
compatibility / should I roll back the change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : Geode-nightly-flaky #83

2017-08-02 Thread Apache Jenkins Server

See

Re: Stored procedures on Apache Geode.

2017-08-02 Thread John Blum

Hi Marios-

That is strange.  Seems your problem is this...

Failed to instantiate [org.springframework.data.gemfire.CacheFactoryBean]:
Factory method 'gemfireCache' threw exception; nested exception is
*java.lang.NoSuchMethodError*: *org.springframework.data.*
*gemfire.util.CollectionUtils.nullSafeList(Ljava/util/List;)Ljava/util/List;*

However, I just ran the example it it started up fine for me (from my
IDE)

  .     ___ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  || .__|_| |_|_| |_\__, | / / / /
 =|_|==|___/=/_/_/_/
 :: Spring Boot :: (v2.0.0.M3)

[info 2017/08/02 12:29:32.694 PDT  tid=0x1] Starting
AnnotationConfiguredGeodeServerApplication on jblum-mbpro-2.local with PID
57158
(/Users/jblum/pivdev/spring-data-examples-workspace/contacts-application-workspace/configuration-example/target/classes
started by jblum in
/Users/jblum/pivdev/spring-data-examples-workspace/contacts-application-workspace/configuration-example/target)

[info 2017/08/02 12:29:32.695 PDT  tid=0x1] No active profile set,
falling back to default profiles: default

[info 2017/08/02 12:29:32.741 PDT  tid=0x1] Refreshing
org.springframework.context.annotation.AnnotationConfigApplicationContext@1e81f160:
startup date [Wed Aug 02 12:29:32 PDT 2017]; root of context hierarchy

...

Build-Date: 2017-07-12 07:18:53 -0700
Build-Id: abaker 0
Build-Java-Version: 1.8.0_121
Build-Platform: Mac OS X 10.12.3 x86_64
Product-Name: Apache Geode
Product-Version: 1.2.0
Source-Date: 2017-07-11 09:31:40 -0700
Source-Repository: release/1.2.0
Source-Revision: 964f2749065ce9c6898fd27983b43f1bd9fc77d0
Native version: native code unavailable

...

[info 2017/08/02 12:29:35.236 PDT  tid=0x1] CacheServer
Configuration:   port=12480 max-connections=800 max-threads=0
notify-by-subscription=true socket-buffer-size=32768
maximum-time-between-pings=6 maximum-message-count=23
message-time-to-live=180 eviction-policy=none capacity=1 overflow
directory=. groups=[] loadProbe=ConnectionCountProbe loadPollInterval=5000
tcpNoDelay=true

[info 2017/08/02 12:29:35.238 PDT  tid=0x1] Cache server connection
listener bound to address 0.0.0.0/0.0.0.0:40404 with backlog 1,000.

[info 2017/08/02 12:29:35.239 PDT  tid=0x1] CacheServer
Configuration:   port=40404 max-connections=800 max-threads=0
notify-by-subscription=true socket-buffer-size=32768
maximum-time-between-pings=6 maximum-message-count=23
message-time-to-live=180 eviction-policy=none capacity=1 overflow
directory=. groups=[] loadProbe=ConnectionCountProbe loadPollInterval=5000
tcpNoDelay=true

[info 2017/08/02 12:29:35.250 PDT  tid=0x1] Started
AnnotationConfiguredGeodeServerApplication in 2.83 seconds (JVM running for
4.218)

...


Indeed, I am also able to connect to this *Spring* configure Geode server
in *Gfsh*...

jblum-mbpro-2:lab jblum$ gfsh

_ __
   / _/ __/ __/ // /
  / /  __/ /___  /_  / _  /
 / /__/ / /  _/ / // /
/__/_/  /__/_//_/1.2.0


Monitor and Manage Apache Geode

gfsh>connect
Connecting to Locator at [host=localhost, port=10334] ..
Connecting to Manager at [host=10.99.199.5, port=1099] ..
Successfully connected to: [host=10.99.199.5, port=1099]

gfsh>list members
   Name| Id
-- |
--
AnnotationConfiguredGeodeServerApplication |
10.99.199.5(AnnotationConfiguredGeodeServerApplication:57158):1024


I have updated the dependencies recently and I just checked in a change to
the parent pom and configuration-example pom to base the examples on Apache
Geode (rather than Pivotal GemFire).

Can you please update your clone and verify again.

Thanks,
John








On Wed, Aug 2, 2017 at 12:20 PM, marios390  wrote:

> Hi John,
>
> Thanks a lot for getting back to me. This is the example am trying ,
>
>  https://github.com/jxblum/contacts-application/blob/
> master/configuration-example/src/main/java/example/app/
> spring/annotation/geode/server/AnnotationConfiguredGeodeServe
> rApplication.java
>
> Please find below the output along with errors:
>
>
> 2017-08-02 22:12:22.867  INFO 721 --- [   main] 
> d.a.a.server.GeodeRepositoryApplication
> : Starting GeodeRepositoryApplication on AdminisatorsMBP.fritz.box with PID
> 721 (/Users/csukmsss/workspace/GeodeRepository/target/classes started by
> csukmsss in /Users/csukmsss/workspace/GeodeRepository)
> 2017-08-02 22:12:22.870  INFO 721 --- [   main] 
> d.a.a.server.GeodeRepositoryApplication
> : No active profile set, falling back to default profiles: default
> 2017-08-02 22:12:22.955  INFO 721 --- [   main] s.c.a.
> AnnotationConfigApplicationContext : Refreshing
>

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-02 Thread pdxrunner

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/651#discussion_r130982335
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
 ---
@@ -633,8 +631,8 @@ public DataCommandResult put(String key, String value, 
boolean putIfAbsent, Stri
   try {
 keyObject = getClassObject(key, keyClass);
   } catch (ClassNotFoundException e) {
-return DataCommandResult.createPutResult(key, null, null,
-"ClassNotFoundException " + keyClass, false);
+return DataCommandResult.createPutResult(key, null, 
e.getException(),
--- End diff --

I don't understand the context of this change - the message was 
"ClassNotFound" but now it's "key not found" with a key class? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Broken: apache/geode#3379 (develop - bb847c7)

2017-08-02 Thread Travis CI

Build Update for apache/geode
-

Build: #3379
Status: Broken

Duration: 19 minutes and 54 seconds
Commit: bb847c7 (develop)
Author: zhouxh
Message: GEODE-3055: The old primary's the shadow bucket is not
initialized when rebalance remove it. Thus the new primary candidate can
never initialize from it. The fix is to wait until new primary exists before
remove the old primary's bucket in rebalance.

When the colocated child bucket failed to initialize, remove the leader
bucket since all these buckets should be created atomically.

This closes #570

View the changeset: 
https://github.com/apache/geode/compare/867ac0691cf8...bb847c767f15

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/260301311?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Broken: apache/geode#3378 (develop - 867ac06)

2017-08-02 Thread Travis CI

Build Update for apache/geode
-

Build: #3378
Status: Broken

Duration: 10 minutes and 20 seconds
Commit: 867ac06 (develop)
Author: nabarun
Message: GEODE-3384: Javadoc change for PageableLuceneQueryResults

* Javadocs now mention that PageableLuceneQueryResults are serializable 
and can be sent to other members
This closes #678

View the changeset: 
https://github.com/apache/geode/compare/71dc0f865668...867ac0691cf8

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/260300455?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Errored: apache/geode#3374 (develop - d77d69f)

2017-08-02 Thread Travis CI

Build Update for apache/geode
-

Build: #3374
Status: Errored

Duration: 11 minutes and 28 seconds
Commit: d77d69f (develop)
Author: masaki.yamakawa
Message: GEODE-3028: Fix the expected value of the test that depended on Locale

Fix the test that uses the English message as the expected value so that
it does not depend on the locale at runtime environment.

This closes #556

View the changeset: 
https://github.com/apache/geode/compare/e5f8e8cb29d8...d77d69f65677

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/260288719?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

JIRA permissions

2017-08-02 Thread Brian Rowe

Hello all,

I'm having some trouble assigning tickets to myself and closing them in
JIRA.  Can someone grant me the appropriate permissions.  My username is:
WireBaron

Thanks,
-Brian

[GitHub] geode pull request #679: GEODE-3340: Refactor ConfigCommandsDUnitTest to use...

2017-08-02 Thread jaredjstewart

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/679#discussion_r130998820
  
--- Diff: 
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.ENABLE_TIME_STATISTICS;
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.LOG_LEVEL;
+import static 
org.apache.geode.distributed.ConfigurationProperties.STATISTIC_SAMPLING_ENABLED;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.distributed.internal.ClusterConfigurationService;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogWriterImpl;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+
+@Category(DistributedTest.class)
+@RunWith(JUnitParamsRunner.class)
+public class ConfigCommandDUnitTest {
--- End diff --

What was the motivation to move this test from :geode-core into :geode-web? 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

2017-08-02 Thread WireBaron

Github user WireBaron commented on the issue:

https://github.com/apache/geode/pull/676
  
Rebased to fix conflicts and added an error code to the new 
GetAvailableServers handler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-08-02 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/665#discussion_r130960231
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java
 ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.Map;
+
+import org.apache.geode.management.cli.Result;
+import 
org.apache.geode.management.internal.cli.AbstractCliAroundInterceptor;
+import org.apache.geode.management.internal.cli.GfshParseResult;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.shell.Gfsh;
+
+/**
+ * Interceptor used by gfsh to intercept execution of export config 
command at "shell".
+ */
+public class Interceptor extends AbstractCliAroundInterceptor {
--- End diff --

Ahh, not sure how I didn't notice that! I've deleted it - thanks for your 
feedback!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

2017-08-02 Thread galen-pivotal

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/676
  
Looks like there are some conflicts that need to be resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Stored procedures on Apache Geode.

2017-08-02 Thread marios390

Hi John,

Thanks for providing these details. I am gonna update clone and verify.
I am also have another question for you. I noticed that while executing "list 
members"  only  application listed as member. Locators and servers are not 
supposed to be listed as well?

Thanks
Marios

From: John Blum [via Apache Geode (Incubating) Developers Forum] 
[ml+s70738n2493...@n6.nabble.com]
Sent: Wednesday, August 02, 2017 10:48 PM
To: Marios Sofocleous/IT/CREDITSAFE
Subject: Re: Stored procedures on Apache Geode.

Hi Marios-

That is strange.  Seems your problem is this...

Failed to instantiate [org.springframework.data.gemfire.CacheFactoryBean]:
Factory method 'gemfireCache' threw exception; nested exception is
*java.lang.NoSuchMethodError*: *org.springframework.data.*
*gemfire.util.CollectionUtils.nullSafeList(Ljava/util/List;)Ljava/util/List;*

However, I just ran the example it it started up fine for me (from my
IDE)

  .     ___ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  || .__|_| |_|_| |_\__, | / / / /
 =|_|==|___/=/_/_/_/
 :: Spring Boot :: (v2.0.0.M3)

[info 2017/08/02 12:29:32.694 PDT  tid=0x1] Starting
AnnotationConfiguredGeodeServerApplication on jblum-mbpro-2.local with PID
57158
(/Users/jblum/pivdev/spring-data-examples-workspace/contacts-application-workspace/configuration-example/target/classes
started by jblum in
/Users/jblum/pivdev/spring-data-examples-workspace/contacts-application-workspace/configuration-example/target)

[info 2017/08/02 12:29:32.695 PDT  tid=0x1] No active profile set,
falling back to default profiles: default

[info 2017/08/02 12:29:32.741 PDT  tid=0x1] Refreshing
org.springframework.context.annotation.AnnotationConfigApplicationContext@1e81f160:
startup date [Wed Aug 02 12:29:32 PDT 2017]; root of context hierarchy

...

Build-Date: 2017-07-12 07:18:53 -0700
Build-Id: abaker 0
Build-Java-Version: 1.8.0_121
Build-Platform: Mac OS X 10.12.3 x86_64
Product-Name: Apache Geode
Product-Version: 1.2.0
Source-Date: 2017-07-11 09:31:40 -0700
Source-Repository: release/1.2.0
Source-Revision: 964f2749065ce9c6898fd27983b43f1bd9fc77d0
Native version: native code unavailable

...

[info 2017/08/02 12:29:35.236 PDT  tid=0x1] CacheServer
Configuration:   port=12480 max-connections=800 max-threads=0
notify-by-subscription=true socket-buffer-size=32768
maximum-time-between-pings=6 maximum-message-count=23
message-time-to-live=180 eviction-policy=none capacity=1 overflow
directory=. groups=[] loadProbe=ConnectionCountProbe loadPollInterval=5000
tcpNoDelay=true

[info 2017/08/02 12:29:35.238 PDT  tid=0x1] Cache server connection
listener bound to address 
0.0.0.0/0.0.0.0:40404
 with backlog 1,000.

[info 2017/08/02 12:29:35.239 PDT  tid=0x1] CacheServer
Configuration:   port=40404 max-connections=800 max-threads=0
notify-by-subscription=true socket-buffer-size=32768
maximum-time-between-pings=6 maximum-message-count=23
message-time-to-live=180 eviction-policy=none capacity=1 overflow
directory=. groups=[] loadProbe=ConnectionCountProbe loadPollInterval=5000
tcpNoDelay=true

[info 2017/08/02 12:29:35.250 PDT  tid=0x1] Started
AnnotationConfiguredGeodeServerApplication in 2.83 seconds (JVM running for
4.218)

...

Indeed, I am also able to connect to this *Spring* configure Geode server
in *Gfsh*...

jblum-mbpro-2:lab jblum$ gfsh

_ __
   / _/ __/ __/ // /
  / /  __/ /___  /_  / _  /
 / /__/ / /  _/ / // /
/__/_/  /__/_//_/1.2.0

Monitor and Manage Apache Geode

gfsh>connect
Connecting to Locator at [host=localhost, port=10334] ..
Connecting to Manager at [host=10.99.199.5, port=1099] ..
Successfully connected to: [host=10.99.199.5, port=1099]

gfsh>list members
   Name| Id
-- |
--
AnnotationConfiguredGeodeServerApplication |
10.99.199.5(AnnotationConfiguredGeodeServerApplication:57158):1024

I have updated the dependencies recently and I just checked in a change to
the parent pom and configuration-example pom to base the examples on Apache
Geode (rather than Pivotal GemFire).

Can you please update your clone and verify again.

Thanks,
John

On Wed, Aug 2, 2017 at 12:20 PM, marios390 <[hidden email]
> wrote:

> Hi John,
>
> Thanks a lot for getting back to me. This is the example am trying ,
>
>  
>

Re: Review Request 61281: GEODE-3379 Geode transaction may commit on a secondary bucket after bucket rebalance

2017-08-02 Thread Eric Shu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61281/
---

(Updated Aug. 2, 2017, 9:12 p.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
and Nick Reich.


Changes
---

Fix review comments and handle distributed tx.


Bugs: GEODE-3379
https://issues.apache.org/jira/browse/GEODE-3379


Repository: geode


Description
---

Current geode commit method only hold primary bucket lock when the txRegion is 
a primary bucket. However, in between the tx operation and commit, a rebalance 
could cause primary bucket to move. In this case, commit should detect the 
primary bucket has been moved and throw TransactionDataRebalancedException.


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java 2c8c28b 
  geode-core/src/test/java/org/apache/geode/disttx/PRDistTXDUnitTest.java 
77bf740 
  
geode-core/src/test/java/org/apache/geode/disttx/PRDistTXWithVersionsDUnitTest.java
 9ab5145 
  
geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java
 6578baa 


Diff: https://reviews.apache.org/r/61281/diff/2/

Changes: https://reviews.apache.org/r/61281/diff/1-2/


Testing
---

Ongoing precheckin.


Thanks,

Eric Shu

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

2017-08-02 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/651#discussion_r130958981
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java
 ---
@@ -260,6 +265,7 @@ private JMXServiceURL getJMXServiceURL() throws 
AttachNotSupportedException, IOE
 // need to load the management-agent and get the address
 
 final String javaHome = 
vm.getSystemProperties().getProperty("java.home");
+assertState(StringUtils.isNotBlank(javaHome), 
CliStrings.JAVA_HOME_NOT_FOUND_ERROR_MESSAGE);
--- End diff --

You're right... I was trying to find a place for the 
`JAVA_HOME_NOT_FOUND_ERROR_MESSAGE` variable, but it looks like it would change 
some behavior if inserted here. I'll just roll back the changes on this file 
and delete `JAVA_HOME_NOT_FOUND_ERROR_MESSAGE`. Thanks for your feedback!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #665: GEODE-3254: Refactoring ConfigCommands and ConfigCo...

2017-08-02 Thread YehEmily

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/665#discussion_r130965197
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java
 ---
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.Map;
+
+import org.apache.geode.management.cli.Result;
+import 
org.apache.geode.management.internal.cli.AbstractCliAroundInterceptor;
+import org.apache.geode.management.internal.cli.GfshParseResult;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.shell.Gfsh;
+
+/**
+ * Interceptor used by gfsh to intercept execution of export config 
command at "shell".
+ */
+public class Interceptor extends AbstractCliAroundInterceptor {
--- End diff --

Oops - it seems that it's actually being used, but only in 
`ExportConfigCommand`, so I moved it there. Thanks for pointing this out!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-02 Thread galen-pivotal

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/676#discussion_r130987753
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
 ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License), Version 2.0
+ * (the "License")), you may not use this file except in compliance with 
the License. You may obtain
+ * a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE2.0
+ *
+ * Unless required by applicable law or agreed to in writing), software 
distributed under the
+ * License is distributed on an "AS IS" BASIS), WITHOUT WARRANTIES OR 
CONDITIONS OF ANY KIND),
+ * either express or implied. See the License for the specific language 
governing permissions and
+ * limitations under the License.
+ */
+package org.apache.geode.protocol.protobuf;
+
+public enum ProtocolErrorCode {
+  GENERIC_FAILURE(1000),
--- End diff --

sure, just curious.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #664: Fix for GEODE-3292

2017-08-02 Thread jaredjstewart

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/664
  
Thanks @jujoramos, this looks good to me.  Do you have any thoughts 
@jinmeiliao?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #679: GEODE-3340: Refactor ConfigCommandsDUnitTest to use...

2017-08-02 Thread jaredjstewart

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/679#discussion_r130998592
  
--- Diff: 
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.ENABLE_TIME_STATISTICS;
+import static org.apache.geode.distributed.ConfigurationProperties.GROUPS;
+import static 
org.apache.geode.distributed.ConfigurationProperties.LOG_LEVEL;
+import static 
org.apache.geode.distributed.ConfigurationProperties.STATISTIC_SAMPLING_ENABLED;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.distributed.internal.ClusterConfigurationService;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.logging.LogWriterImpl;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CommandResult;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+
+@Category(DistributedTest.class)
+@RunWith(JUnitParamsRunner.class)
+public class ConfigCommandDUnitTest {
+  @Rule
+  public LocatorServerStartupRule startupRule = new 
LocatorServerStartupRule();
+
+  @Rule
+  public GfshShellConnectionRule gfsh = new GfshShellConnectionRule();
+
+  @Rule
+  public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+  @Test
+  @Parameters({"true", "false"})
+  public void testDescribeConfig(final boolean connectOverHttp) throws 
Exception {
+Properties localProps = new Properties();
+localProps.setProperty(STATISTIC_SAMPLING_ENABLED, "true");
+localProps.setProperty(ENABLE_TIME_STATISTICS, "true");
+localProps.setProperty(GROUPS, "G1");
+MemberVM server0 = startupRule.startServerAsJmxManager(0, localProps);
+
+if (connectOverHttp) {
+  gfsh.connectAndVerify(server0.getHttpPort(), 
GfshShellConnectionRule.PortType.http);
+} else {
+  gfsh.connectAndVerify(server0.getJmxPort(), 
GfshShellConnectionRule.PortType.jmxManger);
+}
+
+server0.invoke(() -> {
+  InternalCache cache = 
LocatorServerStartupRule.serverStarter.getCache();
+  InternalDistributedSystem system = 
cache.getInternalDistributedSystem();
+  DistributionConfig config = system.getConfig();
+  config.setArchiveFileSizeLimit(1000);
+});
+
+gfsh.executeAndVerifyCommand("describe config --member=" + 
server0.getName());
+String result = gfsh.getGfshOutput();
+
+assertThat(result).contains("enable-time-statistics   
: true");
--- End diff --

These assertions might read more cleanly with a regex rather than a 
hardcoded number of spaces, e.g. 
```
assertThat(result).containsPattern("enable-time-statistics\\s+: true");
```


---
If your project

[GitHub] geode pull request #681: Lucene refactoring and clean up

2017-08-02 Thread nabarunnag

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/681

Lucene refactoring and clean up

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3387

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #681


commit 2cfa243ece0494dc983f04e1f1300c46713db5b4
Author: nabarun 
Date:   2017-08-03T01:31:52Z

GEODE-3387: Cleaned up and minor refactoring of lucene module

* In waitUntilFlushedFunction, cleaned out the unused vaiables
* Removed mentions of gemfire from the module in comments
* Removed comment â/* wrapper of IndexWriter */â in 
LuceneIndexForPartitionedRegion
* Renamed initializeAEQ to more suitable / function appropriate name.

commit 90f1dff2d6b5c197410ccb13f3a76a2751f10221
Author: nabarun 
Date:   2017-08-03T02:37:47Z

GEODE-3387: Removing the unused imports and typos




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

2017-08-02 Thread ameybarve15

Github user ameybarve15 commented on a diff in the pull request:

https://github.com/apache/geode/pull/609#discussion_r131056489
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
 ---
@@ -85,8 +72,10 @@ public void execute(FunctionContext context) {
   }
 
 } else {
-  throw new IllegalArgumentException(
+  IllegalStateException illegalStateException = new 
IllegalStateException(
   "The AEQ does not exist for the index " + indexName + " region " 
+ region.getFullPath());
+  logger.error(illegalStateException.getMessage());
--- End diff --

@jhuynh1 
If we throw exception from WaitUntilFlushedFunction then executing side 
will not get a true or false.
Unless we send the result explicitly using resultSender.lastResult(result);
or other alternative is to send this exception using sendException() Api 
and executing side needs to handle this exception to return a boolean result 
for waitUntilFlushed.

@upthewaterspout @dschneider-pivotal @bschuchardt - please correct me if I 
am wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/664#discussion_r131050061
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
 ---
@@ -270,6 +271,7 @@ private void startHttpService(boolean isServer) {
   }
 
   System.setProperty(PULSE_EMBEDDED_PROP, "true");
+  System.setProperty(PULSE_HOST_PROP, "" + 
config.getJmxManagerBindAddress());
--- End diff --

+1 the product code change is good to go. Just some test re-org is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/664#discussion_r131049554
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
 ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.tools.pulse;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_BIND_ADDRESS;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.net.InetAddress;
+import java.util.Properties;
+
+import org.apache.geode.test.dunit.rules.EmbeddedPulseRule;
+import org.apache.geode.test.dunit.rules.LocatorStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.tools.pulse.internal.data.Cluster;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.experimental.runners.Enclosed;
+import org.junit.runner.RunWith;
+
+@RunWith(Enclosed.class)
+@Category(IntegrationTest.class)
+public class PulseConnectivityTest {
+  @ClassRule
+  public static LocatorStarterRule locator = new 
LocatorStarterRule().withJMXManager();
+
+  // Test Connectivity for Default Configuration
+  @Category(IntegrationTest.class)
+  public static class DefaultBindAddressTest {
+@Rule
+public EmbeddedPulseRule pulse = new EmbeddedPulseRule();
+
+@BeforeClass
+public static void beforeClass() throws Exception {
+  locator.startLocator();
+}
+
+@Test
+public void testConnectToJmx() throws Exception {
+  pulse.useJmxPort(locator.getJmxPort());
+  Cluster cluster = pulse.getRepository().getCluster("admin", null);
+  assertThat(cluster.isConnectedFlag()).isTrue();
+  assertThat(cluster.getServerCount()).isEqualTo(0);
+}
+
+@Test
+public void testConnectToLocator() throws Exception {
+  pulse.useLocatorPort(locator.getPort());
+  Cluster cluster = pulse.getRepository().getCluster("admin", null);
+  assertThat(cluster.isConnectedFlag()).isTrue();
+  assertThat(cluster.getServerCount()).isEqualTo(0);
+}
+
+@AfterClass
+public static void afterClass() throws Exception {
--- End diff --

this is not needed. The rule guarantees that this is called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/664#discussion_r131049401
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
 ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.tools.pulse;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_BIND_ADDRESS;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.net.InetAddress;
+import java.util.Properties;
+
+import org.apache.geode.test.dunit.rules.EmbeddedPulseRule;
+import org.apache.geode.test.dunit.rules.LocatorStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.tools.pulse.internal.data.Cluster;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.experimental.runners.Enclosed;
+import org.junit.runner.RunWith;
+
+@RunWith(Enclosed.class)
--- End diff --

I am not sure I've seen this pattern before. It looks like you are adding 
another set of test to the original PulseVerificationTest. I believe another 
separate test class would read better. I would leave the original test alone 
(since it has a test that uses httpClient to try to connect with a wrong 
password). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/664#discussion_r131049994
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java
 ---
@@ -38,6 +38,12 @@ protected void before() throws Throwable {
 repository.setHost("localhost");
   }
 
+  public void useJmxManager(String jmxHost, int jmxPort) {
--- End diff --

+1, very nice addition


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #681: Lucene refactoring and clean up

2017-08-02 Thread nabarunnag

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/681
  
Potential reviewers
@ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/664#discussion_r131050219
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
 ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.tools.pulse;
+
+import static 
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_BIND_ADDRESS;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.net.InetAddress;
+import java.util.Properties;
+
+import org.apache.geode.test.dunit.rules.EmbeddedPulseRule;
+import org.apache.geode.test.dunit.rules.LocatorStarterRule;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.tools.pulse.internal.data.Cluster;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.experimental.runners.Enclosed;
+import org.junit.runner.RunWith;
+
+@RunWith(Enclosed.class)
--- End diff --

the test you removed is slightly different from the one in 
PulseSecurityTest, there it's using a securityManager, but here, it doesn't, 
it's making sure the default username/password (admin/admin) works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Feature branch cleanup

2017-08-02 Thread Jacob Barrett

Along those same lines it would be really nice if people would use their own 
forks for feature branches, then we wouldn't have this mess at all.

Sent from my iPhone

> On Aug 2, 2017, at 9:44 PM, Nabarun Nag  wrote:
> 
> 
> Hi 
> I was wondering if we should clean up the feature branches related to closed 
> or resolved GEODE tickets in the origin repository. Below are the listed 
> tickets and associated branch.
> 
> Regards
> Nabarun Nag
> 
> 
> Branch Name
> Ticket
> Status
> Committers [merged to develop]
> origin/feature/GEODE-11
> GEODE-11
> Closed
> [Ashvin Agrawal, [~adharmakkan], [~agingade], [~barry.oglesby], [~huynhja], 
> [~upthewaterspout], zhouxh]
>  origin/feature/GEODE-1209
> GEODE-1209
> Resolved
> [[~agingade], [~dbarnes97]]
>  origin/feature/GEODE-1912
> GEODE-1912
> Resolved
> [[~jinmeiliao]]
>  origin/feature/GEODE-1969
> GEODE-1969
> Closed
> [shankar]
>  origin/feature/GEODE-1987
> GEODE-1987
> Resolved
> []
>  origin/feature/GEODE-1996
> GEODE-1996
> Closed
> [[~dbarnes97]]
>  origin/feature/GEODE-2097
> GEODE-2097
> Closed
> [[~dschneider]]
>  origin/feature/GEODE-2201
> GEODE-2201
> Closed
> [[~jens.deppe]]
>  origin/feature/GEODE-2231
> GEODE-2231
> Closed
> [[~karensmolermiller]]
>  origin/feature/GEODE-2367
> GEODE-2367
> Closed
> [[~huynhja]]
>  origin/feature/GEODE-2398
> GEODE-2398
> Closed
> [[~lgallinat]]
>  origin/feature/GEODE-2398overflow
> GEODE-2398
> Closed
> [[~lgallinat]]
>  origin/feature/GEODE-2402
> GEODE-2402
> Closed
> [[~upthewaterspout]]
>  origin/feature/GEODE-2420
> GEODE-2420
> Closed
> [[~dbarnes97], [~khowe]]
>  origin/feature/GEODE-2485
> GEODE-2485
> Closed
> [[~dschneider]]
>  origin/feature/GEODE-2497
> GEODE-2497
> Closed
> [[~bschuchardt]]
>  origin/feature/GEODE-2541
> GEODE-2541
> Closed
> [[~khowe]]
>  origin/feature/GEODE-2558
> GEODE-2558
> Resolved
> [[~apa...@the9muses.net ], [~jstewart]]
>  origin/feature/GEODE-2589
> GEODE-2589
> Closed
> [[~lhughesgodfrey]]
>  origin/feature/GEODE-2594
> GEODE-2594
> Resolved
> [[~apa...@the9muses.net ], [~karensmolermiller]]
>  origin/feature/GEODE-2599
> GEODE-2599
> Closed
> [[~khowe]]
>  origin/feature/GEODE-2616
> GEODE-2616
> Closed
> [[~dschneider]]
>  origin/feature/GEODE-2632
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-1
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-10
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-11
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-12
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-13
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-14
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-15
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-3
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-4
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-5
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-6
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-6-1
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-7
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2632-8
> GEODE-2632
> Resolved
> [[~apa...@the9muses.net ], [~jinmeiliao]]
>  origin/feature/GEODE-2645
> GEODE-2645
> Closed
> [[~apa...@the9muses.net ]]
>  origin/feature/GEODE-2648
> GEODE-2648
> Closed
> [[~apa...@the9muses.net ]]
>  origin/feature/GEODE-2654
> GEODE-2654
> Resolved
> [[~lgallinat]]
>  origin/feature/GEODE-2661
> GEODE-2661
> Closed
> [[~lgallinat]]
>  origin/feature/GEODE-2681
> GEODE-2681
> Resolved
> [[~khowe]]
>  origin/feature/GEODE-2703
> GEODE-2703
> Closed
> [[~huynhja]]
>  origin/feature/GEODE-2737
> GEODE-2737
> Closed
> [[~khowe]]
>  origin/feature/GEODE-2745
> GEODE-2745
> Closed
> [[~lhughesgodfrey]]
>  origin/feature/GEODE-2765
> GEODE-2765
> Closed
> [[~apa...@the9muses.net ]]
>  origin/feature/GEODE-2768
> GEODE-2768
> Closed
>

behavior of "connect" command when --use-ssl

2017-08-02 Thread Jinmei Liao

I am looking at a behavior of Gfsh's connect command using ssl. I am not
sure whether it's a valid use case or just some side effect of spaghetti
code.

So if SSL is configured on locator, and we need to connect to it in Gfsh
gfsh>connect --security-properties-file=ssl.properties
this will try to load the file for ssl configs, and use that for
connection, sounds good.

gfsh> connect --use-ssl
this will look for a gfSecurity.properties file in current location, home
dir, or classpath in order and use that for connection. But if that file
doesn't exist or empty, it will prompt for all the ssl info.

So when user issues "connect --use-ssl", sometimes they will get prompted,
sometimes not depending on whether this "special" file exists somewhere in
your environment. This just does not feel right. I am wondering if looking
for this "special" file really a good feature?

-- 
Cheers

Jinmei

[DISCUSS] Feature branch cleanup

2017-08-02 Thread Nabarun Nag


Hi 
I was wondering if we should clean up the feature branches related to closed or 
resolved GEODE tickets in the origin repository. Below are the listed tickets 
and associated branch.

Regards
Nabarun Nag


Branch Name
Ticket
Status
Committers [merged to develop]
origin/feature/GEODE-11
GEODE-11
Closed
[Ashvin Agrawal, [~adharmakkan], [~agingade], [~barry.oglesby], [~huynhja], 
[~upthewaterspout], zhouxh]
  origin/feature/GEODE-1209
GEODE-1209
Resolved
[[~agingade], [~dbarnes97]]
  origin/feature/GEODE-1912
GEODE-1912
Resolved
[[~jinmeiliao]]
  origin/feature/GEODE-1969
GEODE-1969
Closed
[shankar]
  origin/feature/GEODE-1987
GEODE-1987
Resolved
[]
  origin/feature/GEODE-1996
GEODE-1996
Closed
[[~dbarnes97]]
  origin/feature/GEODE-2097
GEODE-2097
Closed
[[~dschneider]]
  origin/feature/GEODE-2201
GEODE-2201
Closed
[[~jens.deppe]]
  origin/feature/GEODE-2231
GEODE-2231
Closed
[[~karensmolermiller]]
  origin/feature/GEODE-2367
GEODE-2367
Closed
[[~huynhja]]
  origin/feature/GEODE-2398
GEODE-2398
Closed
[[~lgallinat]]
  origin/feature/GEODE-2398overflow
GEODE-2398
Closed
[[~lgallinat]]
  origin/feature/GEODE-2402
GEODE-2402
Closed
[[~upthewaterspout]]
  origin/feature/GEODE-2420
GEODE-2420
Closed
[[~dbarnes97], [~khowe]]
  origin/feature/GEODE-2485
GEODE-2485
Closed
[[~dschneider]]
  origin/feature/GEODE-2497
GEODE-2497
Closed
[[~bschuchardt]]
  origin/feature/GEODE-2541
GEODE-2541
Closed
[[~khowe]]
  origin/feature/GEODE-2558
GEODE-2558
Resolved
[[~apa...@the9muses.net ], [~jstewart]]
  origin/feature/GEODE-2589
GEODE-2589
Closed
[[~lhughesgodfrey]]
  origin/feature/GEODE-2594
GEODE-2594
Resolved
[[~apa...@the9muses.net ], [~karensmolermiller]]
  origin/feature/GEODE-2599
GEODE-2599
Closed
[[~khowe]]
  origin/feature/GEODE-2616
GEODE-2616
Closed
[[~dschneider]]
  origin/feature/GEODE-2632
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-1
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-10
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-11
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-12
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-13
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-14
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-15
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-3
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-4
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-5
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-6
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-6-1
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-7
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2632-8
GEODE-2632
Resolved
[[~apa...@the9muses.net ], [~jinmeiliao]]
  origin/feature/GEODE-2645
GEODE-2645
Closed
[[~apa...@the9muses.net ]]
  origin/feature/GEODE-2648
GEODE-2648
Closed
[[~apa...@the9muses.net ]]
  origin/feature/GEODE-2654
GEODE-2654
Resolved
[[~lgallinat]]
  origin/feature/GEODE-2661
GEODE-2661
Closed
[[~lgallinat]]
  origin/feature/GEODE-2681
GEODE-2681
Resolved
[[~khowe]]
  origin/feature/GEODE-2703
GEODE-2703
Closed
[[~huynhja]]
  origin/feature/GEODE-2737
GEODE-2737
Closed
[[~khowe]]
  origin/feature/GEODE-2745
GEODE-2745
Closed
[[~lhughesgodfrey]]
  origin/feature/GEODE-2765
GEODE-2765
Closed
[[~apa...@the9muses.net ]]
  origin/feature/GEODE-2768
GEODE-2768
Closed
[[~huynhja]]
  origin/feature/GEODE-2801
GEODE-2801
Closed
[[~dschneider]]
  origin/feature/GEODE-2804
GEODE-2804
Resolved
[[~hitesh.khamesra]]
  origin/feature/GEODE-2804v2
GEODE-2804
Resolved
[[~hitesh.khamesra]]
  origin/feature/GEODE-2804v3
GEODE-2804
Resolved
[[~hitesh.khamesra]]
  origin/feature/GEODE-2811
GEODE-2811
Closed
[[~dschneider]]
  origin/feature/GEODE-2825
GEODE-2825
Closed
[[~huynhja]]
  origin/feature/GEODE-2852
GEODE-2852
Closed
[[~lhughesgodfrey]]
  origin/feature/GEODE-2858
GEODE-2858
Closed
[[~oshvarts]]
  origin/feature/GEODE-2860
GEODE-2860
Resolved
[[~nreich]]

[GitHub] geode issue #664: Fix for GEODE-3292

2017-08-02 Thread jujoramos

Github user jujoramos commented on the issue:

https://github.com/apache/geode/pull/664
  
Hello @jaredjstewart,

Just pushed the requested changes.

- Renamed `PulseVerificationTest` to `PulseConnectivityTest`.
- Removed `loginWithIncorrectPassword` test method, it is the same as the 
one in `PulseSecurityTest`.
- Added integration tests to check the connectivity between PULSE and the 
local jmx-manager, both when the default and non-default bind-address is used.
- Added `PulseAppListenerTest` unit test to verify that the repository is 
correctly configured by the `PulseAppListener` when PULSE is running in 
embedded mode.

Cheers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #677: GEODE-3038: A server process shuts down quietly whe...

2017-08-02 Thread anton-mironenko

GitHub user anton-mironenko opened a pull request:

https://github.com/apache/geode/pull/677

GEODE-3038: A server process shuts down quietly when path to cache.xml is 
incorrect

[GEODE-3038](https://issues.apache.org/jira/browse/GEODE-3038)
The error 
"Declarative Cache XML file/resource \[path-to-cache-xml\] does not exist"
is trying to be written into the log in GemFireCacheImpl.basicCreate(), 
after method GemFireCacheImpl.close() is called, so that writing into the log 
is already not available.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anton-mironenko/geode develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #677


commit f119fb381d4212e8714d26f2388860206daa3d8a
Author: Anton Mironenko 
Date:   2017-08-01T12:18:12Z

write cachexml-not-found exception into the log in a proper place

commit bf0b059035751b3d7cba82a145546edb7efce824
Author: Anton Mironenko 
Date:   2017-08-01T12:52:14Z

Merge remote-tracking branch 'upstream/develop' into GEODE-3038




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Stored procedures on Apache Geode.

2017-08-02 Thread marios390

Hi John,

I am following you example for setting up geode cluster using annotation but 
getting
a few errors. Do these annotations apply only for gemfire?

Thanks
Marios

From: John Blum [via Apache Geode (Incubating) Developers Forum] 
[ml+s70738n2447...@n6.nabble.com]
Sent: Wednesday, July 19, 2017 6:13 PM
To: Marios Sofocleous/IT/CREDITSAFE
Subject: Re: Stored procedures on Apache Geode.

Hi Marios-

Regarding...

*> Do you think this indeed will have a huge impact on the performance?*

There are many factors that affect performance.  A few things to consider
might be...

1. How well you planned and organized the data (e.g. partitioning strategy,
possible collocation).
2. How large are the data entries.
3. What type of queries you may be performing (which might be an important
factor in collocation, with the ability to run queries local to the node).
4. What data management policies are in effect (e.g. eviction, expiration).
5. What the logic in your SPs are doing and how effectively they can be
parallelized.
6. etc.

*> Is there any best practises for doing this or any demo you could provide
demonstrating this process?(SP to geode/gemfire functions)*

I know of customers who have migrated or are migrating from a RDBMS to an
IMDG like Geode/GemFire, but I do not know the results of their work.  I am
in R and not regularly exposed to that type of information.  Others on
this list might have better information for you.

Regards,
John

On Tue, Jul 18, 2017 at 10:59 PM, marios390 <
[hidden email]> wrote:

> Hi John,
>
> As mentioned the other day, we are interested in lift all the stored
> procedures up into the
> cluster.Do
>  you think this indeed will have a huge impact on the
> performance? Is there any best practises for doing this or any demo you
> could provide demonstrating this process?(SP to geode/gemfire functions)
> I would really appreciate it if you could provide any material related to
> this.
>
> Thanks
> Marios
> 
> From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> [hidden email]]
> Sent: Friday, July 14, 2017 6:35 PM
> To: Marios Sofocleous/IT/CREDITSAFE
> Subject: Re: Stored procedures on Apache Geode.
>
> Hi Marios-
>
> I may not be the best person to answer this.  There is a Pivotal GemFire /
> Greenplum Connector available for download here...
>
> https://network.pivotal.io/products/pivotal-gemfire/#/
> releases/5376/file_groups/495 smbkFovlp6IgDkajN0nKt4CrX58E5K46E5Gas7UCAFodHRwOi8vc2Nhbm1ha
> WwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9MS1UbzJSR211OUx2TE
> NHdk1HTXFNMXliTUZtU0xZV293d2dsYWNUMHJBJnU9aHR0cHMlM2ElMmYlMm
> ZuZXR3b3JrJTJlcGl2b3RhbCUyZWlvJTJmcHJvZHVjdHMlMmZwaXZvdGFsLW
> dlbWZpcmUlMmYlMjMlMmZyZWxlYXNlcyUyZjUzNzYlMmZmaWxlJTVmZ3JvdXBzJTJmNDk1>
>
> More information on the Connector can be found here...
>
> http://ggc.docs.pivotal.io/ggc/relnotes/release_notes30.html
>  7o1EZnK4vhJL646E5Gas7UCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_
> Yz03NDIyJmQ9MS1UbzJSR211OUx2TENHdk1HTXFNMXliTUZtU0xZV293d3dq
> T0pPbHJnJnU9aHR0cCUzYSUyZiUyZmdnYyUyZWRvY3MlMmVwaXZvdGFsJTJl
> aW8lMmZnZ2MlMmZyZWxub3RlcyUyZnJlbGVhc2UlNWZub3RlczMwJTJlaHRtbA..>
>
> As you may know, Apache Geode is the open source core of Pivotal GemFire (
> https://pivotal.io/pivotal-gemfire avpjDplcz8GhyxNakFqKyxR0D7vFnF2EyHNgs3HhSye46E5Gas7UCAFodHRw
> Oi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9MS1UbzJSR211OUx2TE
> NHdk1HTXFNMXliTUZtU0xZV293d3R4Yk1DZ3JnJnU9aHR0cHMlM2ElMmYlMm
> ZwaXZvdGFsJTJlaW8lMmZwaXZvdGFsLWdlbWZpcmU.>).  Theoretically, it probably
> would/should work to connect Geode with Greenplum, though I have not done
> this and I am not sure it is a combination Pivotal nor the Apache Geode
> community supports.
>
> There is example of using this Connector with Geode here...
>
>

Re: Stored procedures on Apache Geode.

2017-08-02 Thread John Blum

Hi Marios-

To which example are you referring and what is the error you are getting?

Also, if you could please share a small snippet of code showing how you
used the annotations, that would be helpful.

The new Annotation based configuration (beginning with 1 of...
@ClientCacheApplication, @PeerCacheApplication or
@CacheServerApplication) *applies
to both GemFire and Geode*.  @ClientCacheApplication is probably going to
be the most widely used annotation while the later 2 are used to embed
either a GemFire/Geode data node in your application or just configure 1.

Finally, while I am still in the process of building examples/documentation
for the new Annotations, there are plenty of tests in the SDG test suite
showing them in action and how they work...

https://github.com/spring-projects/spring-data-geode/tree/master/src/test/java/org/springframework/data/gemfire/config/annotation


Regards,

-j


On Wed, Aug 2, 2017 at 8:04 AM, marios390 
wrote:

> Hi John,
>
> I am following you example for setting up geode cluster using annotation
> but getting
> a few errors. Do these annotations apply only for gemfire?
>
> Thanks
> Marios
> 
> From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> ml+s70738n2447...@n6.nabble.com]
> Sent: Wednesday, July 19, 2017 6:13 PM
> To: Marios Sofocleous/IT/CREDITSAFE
> Subject: Re: Stored procedures on Apache Geode.
>
> Hi Marios-
>
> Regarding...
>
> *> Do you think this indeed will have a huge impact on the performance?*
>
> There are many factors that affect performance.  A few things to consider
> might be...
>
> 1. How well you planned and organized the data (e.g. partitioning strategy,
> possible collocation).
> 2. How large are the data entries.
> 3. What type of queries you may be performing (which might be an important
> factor in collocation, with the ability to run queries local to the node).
> 4. What data management policies are in effect (e.g. eviction, expiration).
> 5. What the logic in your SPs are doing and how effectively they can be
> parallelized.
> 6. etc.
>
> *> Is there any best practises for doing this or any demo you could provide
> demonstrating this process?(SP to geode/gemfire functions)*
>
> I know of customers who have migrated or are migrating from a RDBMS to an
> IMDG like Geode/GemFire, but I do not know the results of their work.  I am
> in R and not regularly exposed to that type of information.  Others on
> this list might have better information for you.
>
> Regards,
> John
>
>
> On Tue, Jul 18, 2017 at 10:59 PM, marios390 <
> [hidden email]> wrote:
>
> > Hi John,
> >
> > As mentioned the other day, we are interested in lift all the stored
> > procedures up into the
> > cluster.Do Ab7asC9ITedw5Cv9II58t9nUCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_
> Yz03NDIyJmQ9Z3ZmdjJiZEV2ek9Ub3NsLTJYX2RlY0FGd0Y0NDFEQWJWdjh2
> TDFSdDRBJnU9aHR0cCUzYSUyZiUyZmNsdXN0ZXIlMmVEbw..> you think this indeed
> will have a huge impact on the
> > performance? Is there any best practises for doing this or any demo you
> > could provide demonstrating this process?(SP to geode/gemfire functions)
> > I would really appreciate it if you could provide any material related to
> > this.
> >
> > Thanks
> > Marios
> > 
> > From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> > [hidden email]]
> > Sent: Friday, July 14, 2017 6:35 PM
> > To: Marios Sofocleous/IT/CREDITSAFE
> > Subject: Re: Stored procedures on Apache Geode.
> >
> > Hi Marios-
> >
> > I may not be the best person to answer this.  There is a Pivotal GemFire
> /
> > Greenplum Connector available for download here...
> >
> > https://network.pivotal.io/products/pivotal-gemfire/#/<
> redir.aspx?REF=zlKGb_nE7XEGmuoUFLjEyh3PFSlMkNxc4E-
> 1GwecQR79II58t9nUCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_
> Yz03NDIyJmQ9Z3ZmdjJiZEV2ek9Ub3NsLTJYX2RlY0FGd0Y0NDFEQWJWdmgz
> S2dNeHRnJnU9aHR0cHMlM2ElMmYlMmZuZXR3b3JrJTJlcGl2b3RhbCUyZWlv
> JTJmcHJvZHVjdHMlMmZwaXZvdGFsLWdlbWZpcmUlMmYlMjMlMmY.>
> > releases/5376/file_groups/495 > smbkFovlp6IgDkajN0nKt4CrX58E5K46E5Gas7UCAFodHRwOi8vc2Nhbm1ha
> > WwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9MS1UbzJSR211OUx2TE
> > NHdk1HTXFNMXliTUZtU0xZV293d2dsYWNUMHJBJnU9aHR0cHMlM2ElMmYlMm
> > ZuZXR3b3JrJTJlcGl2b3RhbCUyZWlvJTJmcHJvZHVjdHMlMmZwaXZvdGFsLW
> > dlbWZpcmUlMmYlMjMlMmZyZWxlYXNlcyUyZjUzNzYlMmZmaWxlJTVmZ3JvdXBzJTJmNDk1>
> >
> > More information on the Connector can be found here...
> >
> > http://ggc.docs.pivotal.io/ggc/relnotes/release_notes30.html
>  8t9nUCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_
> Yz03NDIyJmQ9Z3ZmdjJiZEV2ek9Ub3NsLTJYX2RlY0FGd0Y0NDFEQWJWdjht
> ZkFSbTVnJnU9aHR0cCUzYSUyZiUyZmdnYyUyZWRvY3MlMmVwaXZvdGFsJTJl
> aW8lMmZnZ2MlMmZyZWxub3RlcyUyZnJlbGVhc2UlNWZub3RlczMwJTJlaHRtbA..>
> >

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

2017-08-02 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/#review181999
---


Ship it!




You might consider hoisting these classes out of management pkg and into 
org.apache.geode.test.something. Maybe even move them to geode-test module. 
They seem very useful even outside of geode-core and management.

Ship It!

- Kirk Lund


On Aug. 1, 2017, 6:31 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61166/
> ---
> 
> (Updated Aug. 1, 2017, 6:31 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3313: Test utility supports building jar files with multiple classes
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCodeTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61166/diff/6/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 61231: GEODE-3328: simply extract connect command from ShellCommand

2017-08-02 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61231/#review182000
---


Ship it!




Ship It!

- Kirk Lund


On July 28, 2017, 8:41 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61231/
> ---
> 
> (Updated July 28, 2017, 8:41 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I am working on GEM-1575 which involves prompting for ssl configuration 
> properties when connecting to the cluster. So I refactoring the 
> ConnectCommand before doing that.
> This is the first step: simply extracting the command to its separate class 
> without any refactor at all
> 
> GEODE-3328: simply extract connect command from ShellCommand
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/util/PasswordUtil.java 
> ac0b8459e1cd8f399eed5e98bd9d5fbd4953f9c3 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
>  d5e1b27715420818e9a63c9bd467d771e5ee20e3 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommand.java
>  10dc0db871898b4fe95027baeacfc72f0e16d4a3 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/GfshConsoleReader.java
>  80a20e6d075f2b7c9202df96f36aa4c99c445e04 
>   
> geode-core/src/test/java/org/apache/geode/internal/util/PasswordUtilJUnitTest.java
>  8051c5671650ad4f4756f9f614778d1ae1387fa7 
> 
> 
> Diff: https://reviews.apache.org/r/61231/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 61185: GEODE-3231: use tempWorkingFolder to avoid test log file contamination between tests.

2017-08-02 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61185/#review182001
---


Ship it!




Ship It!

- Kirk Lund


On July 27, 2017, 4:57 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61185/
> ---
> 
> (Updated July 27, 2017, 4:57 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3231: use tempWorkingFolder to avoid test log file contamination 
> between tests.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsWithMemberGroupDUnitTest.java
>  ef62269133a9842b81bfaa661b77ed80ddf8552d 
> 
> 
> Diff: https://reviews.apache.org/r/61185/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 61119: GEODE-3097: GFSH works over HTTP with SSL

2017-08-02 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61119/#review182002
---


Ship it!




Ship It!

- Kirk Lund


On July 25, 2017, 10:11 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61119/
> ---
> 
> (Updated July 25, 2017, 10:11 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3097: GFSH works over HTTP with SSL
> 
> put the overhttp change in another test class and have it launhced in 
> geode-assembly, since only in that module the war file is created.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
>  2da95a7c3f305aab4e615d4be7b14c19b9b31dbc 
>   
> geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
>  844e0322eecdc93c4d46c546f4df2d278c5f15cd 
>   
> geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorWithLegacySSLDUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  df371d28eac9d03cfb69ef462daf56f86bb95738 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectToLocatorSSLOverHttpTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61119/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

2017-08-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/673


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #661: GEODE-3319 - refactor to use protobuf encoding for ...

2017-08-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/661


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #556: GEODE-3028: Fix the expected value of the test that...

2017-08-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/556


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : Geode-nightly #914

2017-08-02 Thread Apache Jenkins Server

See

[GitHub] geode pull request #663: GEODE-3314: Fix DLockService token leak.

2017-08-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/663


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

2017-08-02 Thread boglesby

Github user boglesby commented on a diff in the pull request:

https://github.com/apache/geode/pull/570#discussion_r130937683
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 ---
@@ -494,6 +494,18 @@ CreateBucketResult grabFreeBucket(final int 
possiblyFreeBucketId, final Distribu
 
   return result;
 
+} catch (RuntimeException validationException) {
+  // GEODE-3055
+  PartitionedRegion leader = 
ColocationHelper.getLeaderRegion(this.partitionedRegion);
+  boolean isLeader = leader.equals(this.partitionedRegion);
--- End diff --

What if there is more than one colocated child region and one of the child 
buckets is successfully created, but the other is not. This code will remove 
the parent bucket. Will the one that was successfully created also get removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #467: GEODE-258: Remove deprecated Cache.getLoggerI18n and getSe...

2017-08-02 Thread kirklund

Github user kirklund commented on the issue:

https://github.com/apache/geode/pull/467
  
@davinash Sorry to take so long to respond! For the security logger you can 
use this:
```java
  private static Logger securityLogger = 
LogService.getLogger(LogService.SECURITY_LOGGER_NAME);
```
At some point, we should add this to LogService (feel free to add this if 
you want to):
```java
  public static Logger getSecurityLogger() {
return getLogger(LogService.SECURITY_LOGGER_NAME);
  }
```
Then you could use:
```java
  private static Logger securityLogger = LogService.getSecurityLogger();
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

2017-08-02 Thread boglesby

Github user boglesby commented on a diff in the pull request:

https://github.com/apache/geode/pull/570#discussion_r130941287
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 ---
@@ -494,6 +494,18 @@ CreateBucketResult grabFreeBucket(final int 
possiblyFreeBucketId, final Distribu
 
   return result;
 
+} catch (RuntimeException validationException) {
+  // GEODE-3055
+  PartitionedRegion leader = 
ColocationHelper.getLeaderRegion(this.partitionedRegion);
+  boolean isLeader = leader.equals(this.partitionedRegion);
--- End diff --

Nice. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #678: GEODE-3384: Javadoc change for PageableLuceneQueryR...

2017-08-02 Thread nabarunnag

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/678

GEODE-3384: Javadoc change for PageableLuceneQueryResults

* Javadocs now mention that PageableLuceneQueryResults are serializable 
and can be sent to other members

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3384

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #678


commit 5eddfc9ac1b70757e7dedf9c4e8cb9d0c3078614
Author: nabarun 
Date:   2017-08-02T17:26:07Z

GEODE-3384: Javadoc change for PageabelLuceneQueryResults

* Javadocs now mention that PageableLuceneQueryResults are serializable 
and can be sent to other members




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61281: GEODE-3379 Geode transaction may commit on a secondary bucket after bucket rebalance

2017-08-02 Thread Darrel Schneider


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61281/#review182006
---


Ship it!




Ship It!

- Darrel Schneider


On Aug. 1, 2017, 2:41 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61281/
> ---
> 
> (Updated Aug. 1, 2017, 2:41 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3379
> https://issues.apache.org/jira/browse/GEODE-3379
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Current geode commit method only hold primary bucket lock when the txRegion 
> is a primary bucket. However, in between the tx operation and commit, a 
> rebalance could cause primary bucket to move. In this case, commit should 
> detect the primary bucket has been moved and throw 
> TransactionDataRebalancedException.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java 
> 2c8c28b 
>   geode-core/src/test/java/org/apache/geode/disttx/PRDistTXDUnitTest.java 
> 77bf740 
>   
> geode-core/src/test/java/org/apache/geode/disttx/PRDistTXWithVersionsDUnitTest.java
>  9ab5145 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java
>  6578baa 
> 
> 
> Diff: https://reviews.apache.org/r/61281/diff/1/
> 
> 
> Testing
> ---
> 
> Ongoing precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

2017-08-02 Thread kirklund

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/672#discussion_r130944162
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommandsUtils.java
 ---
@@ -0,0 +1,311 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Set;
+import java.util.StringTokenizer;
+
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang.StringUtils;
+
+import org.apache.geode.LogWriter;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.cache.execute.ResultCollector;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.management.DistributedRegionMXBean;
+import org.apache.geode.management.ManagementService;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.MBeanJMXAdapter;
+import org.apache.geode.management.internal.cli.CliUtil;
+import org.apache.geode.management.internal.cli.LogWrapper;
+import org.apache.geode.management.internal.cli.domain.DataCommandRequest;
+import org.apache.geode.management.internal.cli.domain.DataCommandResult;
+import 
org.apache.geode.management.internal.cli.functions.DataCommandFunction;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.CompositeResultData;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.result.TabularResultData;
+
+public class DataCommandsUtils {
--- End diff --

I would prefer to avoid *Utils classes as well. It's reasonable to 
introduce it as a temporary refactoring though just to facilitate breaking 
DataCommands up into multiple Command classes. At some point, we should try to 
refactor DataCommandUtils to non-static OO classes.

Unfortunately I don't have any examples for changing DataCommandUtils to OO 
off the top of my head. That code is going to require some studying to figure 
out how to properly organize it. 

I guess my recommendation at this point is to pull in these changes as they 
are and then @jaredjstewart @YehEmily @jinmeiliao and myself could get together 
and mob on restructuring DataCommandUtils. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #674: GEODE-3380: There're 2 problems here

2017-08-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/674


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-02 Thread kohlmu-pivotal

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/676#discussion_r130928974
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
 ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License), Version 2.0
+ * (the "License")), you may not use this file except in compliance with 
the License. You may obtain
+ * a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE2.0
+ *
+ * Unless required by applicable law or agreed to in writing), software 
distributed under the
+ * License is distributed on an "AS IS" BASIS), WITHOUT WARRANTIES OR 
CONDITIONS OF ANY KIND),
+ * either express or implied. See the License for the specific language 
governing permissions and
+ * limitations under the License.
+ */
+package org.apache.geode.protocol.protobuf;
+
+public enum ProtocolErrorCode {
+  GENERIC_FAILURE(1000),
--- End diff --

I believe any error code structure decides how many characters are to be 
used for an error code. 
The fact that we represent them as integers is merely a "simplification" 
choice over using Alpha numerics.
I don't believe starting the error code at 1000 is a problem


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-02 Thread kohlmu-pivotal

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/676#discussion_r130928395
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandlerJUnitTest.java
 ---
@@ -95,8 +97,8 @@ public void 
processReturnsUnsucessfulResponseForInvalidRegion()
 operationHandler.process(serializationServiceStub, removeRequest, 
cacheStub);
 
 assertTrue(result instanceof Failure);
-org.junit.Assert.assertThat(result.getErrorMessage().getMessage(),
-CoreMatchers.containsString("Region"));
+assertEquals(ProtocolErrorCode.REGION_NOT_FOUND.codeValue,
--- End diff --

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

2017-08-02 Thread bschuchardt

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/676
  
The license header was probably damaged during some search 
operations to transform the google-doc version of the list into an enum


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #670: GEODE-3336: Refactor IndexCommandsDUnitTest to use ...

2017-08-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/670


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #673: GEODE-3284: New flow: getAvailableServers

2017-08-02 Thread bschuchardt

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/673
  
Locators aren't configured via cluster config.  None of the 
distributed-system properties are configured through cluster configuration 
because you must connect to the distributed system in order to obtain the 
cluster configuration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #675: GEODE-3339: Refactoring ClusterConfigurationService...

2017-08-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/675


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

2017-08-02 Thread pivotal-amurmann

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/676#discussion_r130920986
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
 ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License), Version 2.0
+ * (the "License")), you may not use this file except in compliance with 
the License. You may obtain
+ * a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE2.0
+ *
+ * Unless required by applicable law or agreed to in writing), software 
distributed under the
+ * License is distributed on an "AS IS" BASIS), WITHOUT WARRANTIES OR 
CONDITIONS OF ANY KIND),
+ * either express or implied. See the License for the specific language 
governing permissions and
+ * limitations under the License.
+ */
+package org.apache.geode.protocol.protobuf;
+
+public enum ProtocolErrorCode {
+  GENERIC_FAILURE(1000),
--- End diff --

This originally started at "1" and was followed by "100". After I protested 
it was changed to "001". After more discussion we ended up with the "1000" and 
"2000" ranges to accommodate for sub-ranges.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

2017-08-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/570


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

2017-08-02 Thread Jared Stewart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/
---

(Updated Aug. 2, 2017, 5:54 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Moved classes into geode-junit


Repository: geode


Description
---

GEODE-3313: Test utility supports building jar files with multiple classes


Diffs (updated)
-

  geode-junit/build.gradle e47095f 
  
geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java
 PRE-CREATION 
  
geode-junit/src/main/java/org/apache/geode/test/compiler/CompiledSourceCode.java
 PRE-CREATION 
  geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java 
PRE-CREATION 
  geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java 
PRE-CREATION 
  
geode-junit/src/main/java/org/apache/geode/test/compiler/UncompiledSourceCode.java
 PRE-CREATION 
  
geode-junit/src/test/java/org/apache/geode/test/compiler/ClassNameExtractorTest.java
 PRE-CREATION 
  geode-junit/src/test/java/org/apache/geode/test/compiler/JarBuilderTest.java 
PRE-CREATION 
  
geode-junit/src/test/java/org/apache/geode/test/compiler/JavaCompilerTest.java 
PRE-CREATION 
  
geode-junit/src/test/java/org/apache/geode/test/compiler/UncompiledSourceCodeTest.java
 PRE-CREATION 
  
geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractFunction.java
 PRE-CREATION 
  
geode-junit/src/test/resources/org/apache/geode/test/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsAbstractFunction.java
 PRE-CREATION 
  
geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-junit/src/test/resources/org/apache/geode/test/compiler/ImplementsFunction.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61166/diff/7/

Changes: https://reviews.apache.org/r/61166/diff/6-7/


Testing
---

Precheckin running


Thanks,

Jared Stewart

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

2017-08-02 Thread Jared Stewart



> On Aug. 2, 2017, 4:44 p.m., Kirk Lund wrote:
> > You might consider hoisting these classes out of management pkg and into 
> > org.apache.geode.test.something. Maybe even move them to geode-test module. 
> > They seem very useful even outside of geode-core and management.
> > 
> > Ship It!

Great suggestion, this also lets me separate the test utilities from the tests 
that test the test utilities.  (That was a tongue twister..)


- Jared


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/#review181999
---


On Aug. 2, 2017, 5:54 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61166/
> ---
> 
> (Updated Aug. 2, 2017, 5:54 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3313: Test utility supports building jar files with multiple classes
> 
> 
> Diffs
> -
> 
>   geode-junit/build.gradle e47095f 
>   
> geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java
>  PRE-CREATION 
>   
> geode-junit/src/main/java/org/apache/geode/test/compiler/CompiledSourceCode.java
>  PRE-CREATION 
>   geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java 
> PRE-CREATION 
>   geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java 
> PRE-CREATION 
>   
> geode-junit/src/main/java/org/apache/geode/test/compiler/UncompiledSourceCode.java
>  PRE-CREATION 
>   
> geode-junit/src/test/java/org/apache/geode/test/compiler/ClassNameExtractorTest.java
>  PRE-CREATION 
>   
> geode-junit/src/test/java/org/apache/geode/test/compiler/JarBuilderTest.java 
> PRE-CREATION 
>   
> geode-junit/src/test/java/org/apache/geode/test/compiler/JavaCompilerTest.java
>  PRE-CREATION 
>   
> geode-junit/src/test/java/org/apache/geode/test/compiler/UncompiledSourceCodeTest.java
>  PRE-CREATION 
>   
> geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractFunction.java
>  PRE-CREATION 
>   
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsAbstractFunction.java
>  PRE-CREATION 
>   
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-junit/src/test/resources/org/apache/geode/test/compiler/ImplementsFunction.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61166/diff/7/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

2017-08-02 Thread jhuynh1

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/609#discussion_r130952081
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
 ---
@@ -85,8 +72,10 @@ public void execute(FunctionContext context) {
   }
 
 } else {
-  throw new IllegalArgumentException(
+  IllegalStateException illegalStateException = new 
IllegalStateException(
   "The AEQ does not exist for the index " + indexName + " region " 
+ region.getFullPath());
+  logger.error(illegalStateException.getMessage());
--- End diff --

I still think we should just throw the exception here.  The executing side 
will either get a true or false anyways and the exception never actually gets 
propagated to the user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

70 matches

Mail list logo