Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

2020-02-05 Thread Alexander Murmann
+1

On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer  wrote:

> +1 - for inclusion
>
> On 2/5/20 4:22 AM, Ju@N wrote:
> > Hello devs,
> >
> > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
> > The change is basically to avoid throwing an exception and return the
> > correct result whenever a query has more than one condition and one of
> them
> > compares two indexed fields.
> > This is not a new issue but it can be hit by any user under the
> conditions
> > I've mentioned, it is also considered critical for one of the customers I
> > work for, thus I'm eagerly asking to include the fix in the next release.
> > The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
> > Best regards.
> >
> > [1]: https://issues.apache.org/jira/browse/GEODE-7728
> > [2]:
> >
> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
> >
>


Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

2020-02-05 Thread Ivan Godwin
+1

On Wed, Feb 5, 2020 at 10:16 AM Nabarun Nag  wrote:

> ++
>
> On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann 
> wrote:
>
> > +1
> >
> > On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer  wrote:
> >
> > > +1 - for inclusion
> > >
> > > On 2/5/20 4:22 AM, Ju@N wrote:
> > > > Hello devs,
> > > >
> > > > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
> > > > The change is basically to avoid throwing an exception and return the
> > > > correct result whenever a query has more than one condition and one
> of
> > > them
> > > > compares two indexed fields.
> > > > This is not a new issue but it can be hit by any user under the
> > > conditions
> > > > I've mentioned, it is also considered critical for one of the
> > customers I
> > > > work for, thus I'm eagerly asking to include the fix in the next
> > release.
> > > > The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
> > > > Best regards.
> > > >
> > > > [1]: https://issues.apache.org/jira/browse/GEODE-7728
> > > > [2]:
> > > >
> > >
> >
> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
> > > >
> > >
> >
>


Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

2020-02-05 Thread Nabarun Nag
++

On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann 
wrote:

> +1
>
> On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer  wrote:
>
> > +1 - for inclusion
> >
> > On 2/5/20 4:22 AM, Ju@N wrote:
> > > Hello devs,
> > >
> > > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
> > > The change is basically to avoid throwing an exception and return the
> > > correct result whenever a query has more than one condition and one of
> > them
> > > compares two indexed fields.
> > > This is not a new issue but it can be hit by any user under the
> > conditions
> > > I've mentioned, it is also considered critical for one of the
> customers I
> > > work for, thus I'm eagerly asking to include the fix in the next
> release.
> > > The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
> > > Best regards.
> > >
> > > [1]: https://issues.apache.org/jira/browse/GEODE-7728
> > > [2]:
> > >
> >
> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
> > >
> >
>


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Patrick Johnson
+1

On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:

Hi there Geode dev,

I would like to request that GEODE-7752 
(7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.

This piece of code is a refactor of work done in GEODE-7715. This 
refactor specializes Builders and simplifies Builder behavior for better 
user experience.

--Udo





[Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Udo Kohlmeyer

Hi there Geode dev,

I would like to request that GEODE-7752 
(7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.


This piece of code is a refactor of work done in GEODE-7715. This 
refactor specializes Builders and simplifies Builder behavior for better 
user experience.


--Udo



Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Udo Kohlmeyer
My apologies.. I had paid further attention to this, after I made 
changes to the assembly-context.txt file.


I will revert now and then come back when it passes all test requirements.

--Udo


On 2/5/20 4:14 PM, Ernest Burghardt wrote:

Udo,
the PR has some failing tests that are in the "non-mandatory" category for
merge, TBH I'd prefer to have solid green changes being added at this point
forward...

Thanks,
EB

On Wed, Feb 5, 2020 at 3:01 PM Alexander Murmann 
wrote:


Udo, you say "refactor", but this sounds more like a feature or user facing
improvement. Do you mind elaborating a little more why this should be in
this release?

On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson 
+1

On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:

 Hi there Geode dev,

 I would like to request that GEODE-7752
 (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.

 This piece of code is a refactor of work done in GEODE-7715. This
 refactor specializes Builders and simplifies Builder behavior for
better
 user experience.

 --Udo






Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

2020-02-05 Thread Ernest Burghardt
+1

I'll plan to cherry-pick in the morning if there are no objections...


On Wed, Feb 5, 2020 at 11:20 AM Ivan Godwin  wrote:

> +1
>
> On Wed, Feb 5, 2020 at 10:16 AM Nabarun Nag  wrote:
>
> > ++
> >
> > On Wed, Feb 5, 2020 at 9:54 AM Alexander Murmann 
> > wrote:
> >
> > > +1
> > >
> > > On Wed, Feb 5, 2020 at 9:29 AM Udo Kohlmeyer  wrote:
> > >
> > > > +1 - for inclusion
> > > >
> > > > On 2/5/20 4:22 AM, Ju@N wrote:
> > > > > Hello devs,
> > > > >
> > > > > I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
> > > > > The change is basically to avoid throwing an exception and return
> the
> > > > > correct result whenever a query has more than one condition and one
> > of
> > > > them
> > > > > compares two indexed fields.
> > > > > This is not a new issue but it can be hit by any user under the
> > > > conditions
> > > > > I've mentioned, it is also considered critical for one of the
> > > customers I
> > > > > work for, thus I'm eagerly asking to include the fix in the next
> > > release.
> > > > > The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
> > > > > Best regards.
> > > > >
> > > > > [1]: https://issues.apache.org/jira/browse/GEODE-7728
> > > > > [2]:
> > > > >
> > > >
> > >
> >
> https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb
> > > > >
> > > >
> > >
> >
>


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread John Blum
+1

On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson 
wrote:

> +1
>
> On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:
>
> Hi there Geode dev,
>
> I would like to request that GEODE-7752
> (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
>
> This piece of code is a refactor of work done in GEODE-7715. This
> refactor specializes Builders and simplifies Builder behavior for
> better
> user experience.
>
> --Udo
>
>
>
>

-- 
-John
Spring Data Team


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Ernest Burghardt
Udo,
the PR has some failing tests that are in the "non-mandatory" category for
merge, TBH I'd prefer to have solid green changes being added at this point
forward...

Thanks,
EB

On Wed, Feb 5, 2020 at 3:01 PM Alexander Murmann 
wrote:

> Udo, you say "refactor", but this sounds more like a feature or user facing
> improvement. Do you mind elaborating a little more why this should be in
> this release?
>
> On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson  >
> wrote:
>
> > +1
> >
> > On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:
> >
> > Hi there Geode dev,
> >
> > I would like to request that GEODE-7752
> > (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
> >
> > This piece of code is a refactor of work done in GEODE-7715. This
> > refactor specializes Builders and simplifies Builder behavior for
> > better
> > user experience.
> >
> > --Udo
> >
> >
> >
> >
>


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Mark Hanson
Hi Ernie,

Thanks for the heads up. This is breaking DistributedTestOpenJDK and Udo 
confirmed the are of concern and is going to revert this.

Thanks,

Mark

> On Feb 5, 2020, at 4:14 PM, Ernest Burghardt  wrote:
> 
> Udo,
> the PR has some failing tests that are in the "non-mandatory" category for
> merge, TBH I'd prefer to have solid green changes being added at this point
> forward...
> 
> Thanks,
> EB
> 
> On Wed, Feb 5, 2020 at 3:01 PM Alexander Murmann 
> wrote:
> 
>> Udo, you say "refactor", but this sounds more like a feature or user facing
>> improvement. Do you mind elaborating a little more why this should be in
>> this release?
>> 
>> On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson >> 
>> wrote:
>> 
>>> +1
>>> 
>>> On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:
>>> 
>>>Hi there Geode dev,
>>> 
>>>I would like to request that GEODE-7752
>>>(7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
>>> 
>>>This piece of code is a refactor of work done in GEODE-7715. This
>>>refactor specializes Builders and simplifies Builder behavior for
>>> better
>>>user experience.
>>> 
>>>--Udo
>>> 
>>> 
>>> 
>>> 
>> 



Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Alexander Murmann
Thanks for the additional context, Udo! That makes a lot of sense.

I want to make sure we are very deliberate about including anything but a
critical fix in a release branch after it has been cut.

+1 to including Udo's change once we feel confident about the tests

On Wed, Feb 5, 2020 at 4:27 PM Jinmei Liao  wrote:

> Even though the management service is still marketed as "experimental" and
> we don't need to go through deprecations, I would still very much prefer
> this gets pulled into 1.12 so that users don't have to deal with
> experimental public API changes.
>
> On Wed, Feb 5, 2020 at 4:23 PM Udo Kohlmeyer  wrote:
>
> > @Alexander, I can most certainly elaborate more.
> >
> > In short, this refactor does not have to be in 1.12, but it does alter
> > public Builders and classes. Which means, that if we don't release it
> > with 1.12, we would have to go through the cycle of deprecation,etc. to
> > get this change in. Given that the initial GEODE-7715 ticket is not in
> > any released version of Geode, it would just simplify the process of not
> > having to go through unnecessary pain to simplify and make this process
> > more intuitive for users.
> >
> > Does this answer your question as to why?
> >
> > --Udo
> >
> >
> > On 2/5/20 3:01 PM, Alexander Murmann wrote:
> > > Udo, you say "refactor", but this sounds more like a feature or user
> > facing
> > > improvement. Do you mind elaborating a little more why this should be
> in
> > > this release?
> > >
> > > On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson
> > 
> > > wrote:
> > >
> > >> +1
> > >>
> > >> On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:
> > >>
> > >>  Hi there Geode dev,
> > >>
> > >>  I would like to request that GEODE-7752
> > >>  (7028f601680fee3f57cbdff63951128d7180ca13) gets included into
> 1.12.
> > >>
> > >>  This piece of code is a refactor of work done in GEODE-7715. This
> > >>  refactor specializes Builders and simplifies Builder behavior for
> > >> better
> > >>  user experience.
> > >>
> > >>  --Udo
> > >>
> > >>
> > >>
> > >>
> >
>
>
> --
> Cheers
>
> Jinmei
>


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Jinmei Liao
+1

On Wed, Feb 5, 2020 at 2:36 PM John Blum  wrote:

> +1
>
> On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson  >
> wrote:
>
> > +1
> >
> > On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:
> >
> > Hi there Geode dev,
> >
> > I would like to request that GEODE-7752
> > (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
> >
> > This piece of code is a refactor of work done in GEODE-7715. This
> > refactor specializes Builders and simplifies Builder behavior for
> > better
> > user experience.
> >
> > --Udo
> >
> >
> >
> >
>
> --
> -John
> Spring Data Team
>


-- 
Cheers

Jinmei


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Udo Kohlmeyer

@Alexander, I can most certainly elaborate more.

In short, this refactor does not have to be in 1.12, but it does alter 
public Builders and classes. Which means, that if we don't release it 
with 1.12, we would have to go through the cycle of deprecation,etc. to 
get this change in. Given that the initial GEODE-7715 ticket is not in 
any released version of Geode, it would just simplify the process of not 
having to go through unnecessary pain to simplify and make this process 
more intuitive for users.


Does this answer your question as to why?

--Udo


On 2/5/20 3:01 PM, Alexander Murmann wrote:

Udo, you say "refactor", but this sounds more like a feature or user facing
improvement. Do you mind elaborating a little more why this should be in
this release?

On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson 
wrote:


+1

On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:

 Hi there Geode dev,

 I would like to request that GEODE-7752
 (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.

 This piece of code is a refactor of work done in GEODE-7715. This
 refactor specializes Builders and simplifies Builder behavior for
better
 user experience.

 --Udo






Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Alexander Murmann
Udo, you say "refactor", but this sounds more like a feature or user facing
improvement. Do you mind elaborating a little more why this should be in
this release?

On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson 
wrote:

> +1
>
> On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:
>
> Hi there Geode dev,
>
> I would like to request that GEODE-7752
> (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
>
> This piece of code is a refactor of work done in GEODE-7715. This
> refactor specializes Builders and simplifies Builder behavior for
> better
> user experience.
>
> --Udo
>
>
>
>


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Ernest Burghardt
Fair enough Udo, just let us know when you have it ready.

Thanks,
EB

On Wed, Feb 5, 2020 at 4:31 PM Udo Kohlmeyer  wrote:

> My apologies.. I had paid further attention to this, after I made
> changes to the assembly-context.txt file.
>
> I will revert now and then come back when it passes all test requirements.
>
> --Udo
>
>
> On 2/5/20 4:14 PM, Ernest Burghardt wrote:
> > Udo,
> > the PR has some failing tests that are in the "non-mandatory" category
> for
> > merge, TBH I'd prefer to have solid green changes being added at this
> point
> > forward...
> >
> > Thanks,
> > EB
> >
> > On Wed, Feb 5, 2020 at 3:01 PM Alexander Murmann 
> > wrote:
> >
> >> Udo, you say "refactor", but this sounds more like a feature or user
> facing
> >> improvement. Do you mind elaborating a little more why this should be in
> >> this release?
> >>
> >> On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson
>  >> wrote:
> >>
> >>> +1
> >>>
> >>> On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:
> >>>
> >>>  Hi there Geode dev,
> >>>
> >>>  I would like to request that GEODE-7752
> >>>  (7028f601680fee3f57cbdff63951128d7180ca13) gets included into
> 1.12.
> >>>
> >>>  This piece of code is a refactor of work done in GEODE-7715. This
> >>>  refactor specializes Builders and simplifies Builder behavior for
> >>> better
> >>>  user experience.
> >>>
> >>>  --Udo
> >>>
> >>>
> >>>
> >>>
>


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Jinmei Liao
Even though the management service is still marketed as "experimental" and
we don't need to go through deprecations, I would still very much prefer
this gets pulled into 1.12 so that users don't have to deal with
experimental public API changes.

On Wed, Feb 5, 2020 at 4:23 PM Udo Kohlmeyer  wrote:

> @Alexander, I can most certainly elaborate more.
>
> In short, this refactor does not have to be in 1.12, but it does alter
> public Builders and classes. Which means, that if we don't release it
> with 1.12, we would have to go through the cycle of deprecation,etc. to
> get this change in. Given that the initial GEODE-7715 ticket is not in
> any released version of Geode, it would just simplify the process of not
> having to go through unnecessary pain to simplify and make this process
> more intuitive for users.
>
> Does this answer your question as to why?
>
> --Udo
>
>
> On 2/5/20 3:01 PM, Alexander Murmann wrote:
> > Udo, you say "refactor", but this sounds more like a feature or user
> facing
> > improvement. Do you mind elaborating a little more why this should be in
> > this release?
> >
> > On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson
> 
> > wrote:
> >
> >> +1
> >>
> >> On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:
> >>
> >>  Hi there Geode dev,
> >>
> >>  I would like to request that GEODE-7752
> >>  (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
> >>
> >>  This piece of code is a refactor of work done in GEODE-7715. This
> >>  refactor specializes Builders and simplifies Builder behavior for
> >> better
> >>  user experience.
> >>
> >>  --Udo
> >>
> >>
> >>
> >>
>


-- 
Cheers

Jinmei


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Owen Nichols
+1

Getting it right the first time will definitely save us pains down the road.

> On Feb 5, 2020, at 4:23 PM, Udo Kohlmeyer  wrote:
> 
> @Alexander, I can most certainly elaborate more.
> 
> In short, this refactor does not have to be in 1.12, but it does alter public 
> Builders and classes. Which means, that if we don't release it with 1.12, we 
> would have to go through the cycle of deprecation,etc. to get this change in. 
> Given that the initial GEODE-7715 ticket is not in any released version of 
> Geode, it would just simplify the process of not having to go through 
> unnecessary pain to simplify and make this process more intuitive for users.
> 
> Does this answer your question as to why?
> 
> --Udo
> 
> 
> On 2/5/20 3:01 PM, Alexander Murmann wrote:
>> Udo, you say "refactor", but this sounds more like a feature or user facing
>> improvement. Do you mind elaborating a little more why this should be in
>> this release?
>> 
>> On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson 
>> wrote:
>> 
>>> +1
>>> 
>>> On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:
>>> 
>>> Hi there Geode dev,
>>> 
>>> I would like to request that GEODE-7752
>>> (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
>>> 
>>> This piece of code is a refactor of work done in GEODE-7715. This
>>> refactor specializes Builders and simplifies Builder behavior for
>>> better
>>> user experience.
>>> 
>>> --Udo
>>> 
>>> 
>>> 
>>> 



Odg: StressNewTest timeout exceeded

2020-02-05 Thread Mario Kevo
Thanks Owen Nichols!

Šalje: Robert Houghton 
Poslano: 5. veljače 2020. 16:30
Prima: dev@geode.apache.org 
Predmet: Re: StressNewTest timeout exceeded

How did you change its timeout?

On Wed, Feb 5, 2020, 07:27 Owen Nichols  wrote:

> Hi Mario, I’ve re-triggered your PR check with a longer timeout, since I
> think you are only about an hour over the current timeout of 6 hours for
> StressNewTest.
>
> > On Feb 5, 2020, at 5:10 AM, Mario Kevo  wrote:
> >
> > Hi all,
> >
> > I'm working on https://issues.apache.org/jira/browse/GEODE-7309
> > PR: https://github.com/apache/geode/pull/4395
> > All tests passed except stressNewTest which failed with timeout exceeded.
> >
> > Can we somehow override it to pass this tests?
> >
> > BR,
> > Mario
>
>


Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Udo Kohlmeyer

Hi there EB,

fix has been merged to develop. (Everything is green now)

9c102e4f8836ca32ad51a05bbd4d0107e8fc0343

Thanks

--Udo

0On 2/5/20 4:34 PM, Ernest Burghardt wrote:

Fair enough Udo, just let us know when you have it ready.

Thanks,
EB

On Wed, Feb 5, 2020 at 4:31 PM Udo Kohlmeyer  wrote:


My apologies.. I had paid further attention to this, after I made
changes to the assembly-context.txt file.

I will revert now and then come back when it passes all test requirements.

--Udo


On 2/5/20 4:14 PM, Ernest Burghardt wrote:

Udo,
the PR has some failing tests that are in the "non-mandatory" category

for

merge, TBH I'd prefer to have solid green changes being added at this

point

forward...

Thanks,
EB

On Wed, Feb 5, 2020 at 3:01 PM Alexander Murmann 
wrote:


Udo, you say "refactor", but this sounds more like a feature or user

facing

improvement. Do you mind elaborating a little more why this should be in
this release?

On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson


wrote:


+1

On 2/5/20, 1:53 PM, "Udo Kohlmeyer"  wrote:

  Hi there Geode dev,

  I would like to request that GEODE-7752
  (7028f601680fee3f57cbdff63951128d7180ca13) gets included into

1.12.

  This piece of code is a refactor of work done in GEODE-7715. This
  refactor specializes Builders and simplifies Builder behavior for
better
  user experience.

  --Udo






Re: [PROPOSAL]: Include GEODE-7728 in Release 1.12.0

2020-02-05 Thread Udo Kohlmeyer

+1 - for inclusion

On 2/5/20 4:22 AM, Ju@N wrote:

Hello devs,

I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
The change is basically to avoid throwing an exception and return the
correct result whenever a query has more than one condition and one of them
compares two indexed fields.
This is not a new issue but it can be hit by any user under the conditions
I've mentioned, it is also considered critical for one of the customers I
work for, thus I'm eagerly asking to include the fix in the next release.
The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
Best regards.

[1]: https://issues.apache.org/jira/browse/GEODE-7728
[2]:
https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb



[PROPOSAL]: Include GEODE-7728 in Release 1.12.0

2020-02-05 Thread Ju@N
Hello devs,

I'd like to include the fix for GEODE-7728 [1] in release 1.12.0.
The change is basically to avoid throwing an exception and return the
correct result whenever a query has more than one condition and one of them
compares two indexed fields.
This is not a new issue but it can be hit by any user under the conditions
I've mentioned, it is also considered critical for one of the customers I
work for, thus I'm eagerly asking to include the fix in the next release.
The SHA is 6e35c201ea605075433203d4e64ca887bafd8fcb [2].
Best regards.

[1]: https://issues.apache.org/jira/browse/GEODE-7728
[2]:
https://github.com/apache/geode/commit/6e35c201ea605075433203d4e64ca887bafd8fcb

-- 
Ju@N


StressNewTest timeout exceeded

2020-02-05 Thread Mario Kevo
Hi all,

I'm working on https://issues.apache.org/jira/browse/GEODE-7309
PR: https://github.com/apache/geode/pull/4395
All tests passed except stressNewTest which failed with timeout exceeded.

Can we somehow override it to pass this tests?

BR,
Mario


Re: StressNewTest timeout exceeded

2020-02-05 Thread Robert Houghton
How did you change its timeout?

On Wed, Feb 5, 2020, 07:27 Owen Nichols  wrote:

> Hi Mario, I’ve re-triggered your PR check with a longer timeout, since I
> think you are only about an hour over the current timeout of 6 hours for
> StressNewTest.
>
> > On Feb 5, 2020, at 5:10 AM, Mario Kevo  wrote:
> >
> > Hi all,
> >
> > I'm working on https://issues.apache.org/jira/browse/GEODE-7309
> > PR: https://github.com/apache/geode/pull/4395
> > All tests passed except stressNewTest which failed with timeout exceeded.
> >
> > Can we somehow override it to pass this tests?
> >
> > BR,
> > Mario
>
>


Re: StressNewTest timeout exceeded

2020-02-05 Thread Owen Nichols
Hi Mario, I’ve re-triggered your PR check with a longer timeout, since I think 
you are only about an hour over the current timeout of 6 hours for 
StressNewTest. 

> On Feb 5, 2020, at 5:10 AM, Mario Kevo  wrote:
> 
> Hi all,
> 
> I'm working on https://issues.apache.org/jira/browse/GEODE-7309
> PR: https://github.com/apache/geode/pull/4395
> All tests passed except stressNewTest which failed with timeout exceeded.
> 
> Can we somehow override it to pass this tests?
> 
> BR,
> Mario