Review Request 45919: Updates to NOTICE

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45919/
---

Review request for geode, Joey McAllister, Swapnil Bawaskar, and Dan Smith.


Repository: geode


Description
---

GEODE-914: Remove log4j from NOTICE

Commit 5342935d301a4026b289637885e9236414feeb78 cleaned up log4j
code so this no longer needs to be declared in NOTICE.

GEODE-914: Removed unnecessary declarations from NOTICE

Removed spring-petclinic, Apache MyFaces, and fastutil from
NOTICE.  None of these project contain a NOTICE with content
that needs to be propagated.

GEODE-914: Reworked NOTICE for binary distribution

Update binary NOTICE to match changes to bundled jar files.


Diffs
-

  NOTICE 8e7485fe5d8da0548cdb7d4d958bb612ea2c501a 
  geode-assembly/src/main/dist/NOTICE ec14cdaf4677c47032bf4840eca9d07da7ef4475 

Diff: https://reviews.apache.org/r/45919/diff/


Testing
---


Thanks,

Anthony Baker

[GitHub] incubator-geode pull request: Feature/geode 904

[joeymcallister]

GitHub user joeymcallister opened a pull request:

https://github.com/apache/incubator-geode/pull/126

Feature/geode 904

For GEODE-904, this:
- Adds the additional bundle listings to the LICENSES.
- Reformats the LICENSE files around the embedded licenses.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joeymcallister/incubator-geode 
feature/GEODE-904

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit c37f532f9a70376c48c8dabe0fae36a3c5d5c602
Author: Joey McAllister 
Date:   2016-04-05T01:13:06Z

GEODE-904 Adds file listings to LICENSE

commit c1c1c4adc0a137771339a7c146324e18e6d0ce76
Author: Joey McAllister 
Date:   2016-04-06T18:15:09Z

GEODE-904 Updates tooltip.js link to a working one.

http://flowplayer.org/tools/tooltip is in the packaged license but is
an outdated and broken link. Changed it to
https://github.com/jquerytools/jquerytools. GEODE-904

commit ea1d1dc26d7c3bca0d1ed2ff03b68d2942366470
Author: Joey McAllister 
Date:   2016-04-07T02:28:52Z

GEODE-904 Reformatted LICENSE around Licenses

Using Apache Samza LICENSE as a guide, separated components by license
and added versions (where available), copyright dates (where
applicable), copyright owners, and texts of component licenses.

commit 62c0d343d5737b0abdbd81309c042707685e4c36
Author: Joey McAllister 
Date:   2016-04-08T01:31:56Z

Merge remote-tracking branch 'apache/develop' into feature/GEODE-904

# Conflicts:
#   LICENSE

commit 6f5d277feb8d7742bbe625972b59da158a3a8039
Author: Joey McAllister 
Date:   2016-04-08T01:51:52Z

GEODE-904 Adds matchMedia() polyfill to MIT listings, cleanup edits

Adds matchMedia() polyfill to the MIT license and adds “.js” to end of
“Respond.js” name. Other changes are just aesthetic cleanups.

commit 447433557e020564a19fd5c26855e6b4b4ef3d1f
Author: Joey McAllister 
Date:   2016-04-08T03:44:25Z

GEODE-904 Updates formatting of geode-assembly/src/main/dist/LICENSE to 
match LICENSE

Matched formatting of main LICENSE for binary distribution LICENSE and
added missing listings from main LICENSE. GEODE-904




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [discuss] Install Google Analytics for tracking activity on geode.incubator.apache.org

[Nitin Lamba]

Done [1].

Nitin
[1] https://issues.apache.org/jira/browse/INFRA-11619

On Wed, Apr 6, 2016 at 7:05 PM, Roman Shaposhnik 
wrote:

> On Wed, Apr 6, 2016 at 5:36 PM, Nitin Lamba  wrote:
> > +1
> >
> > Another option (mentioned in today's Geode Clubhouse), is to have Geode
> at
> > http://analysis.apache.org
>
> That'd be pretty sweet!
>
> > Most of the projects are TLPs but I could find at least one valid
> Incubator:
> > https://analysis.apache.org/dashboard/index/201547
> >
> > @rvs, would you know who has the karma to get geode added on this site?
> > Doesn't look like an INFRA request but I may be wrong.
>
> I don't think you need karma for that -- you just need to file an INFRA
> issue
> asking for ASF Sonar hookup.
>
> Thanks,
> Roman.
>

Re: Review Request 45844: GEODE-1187 If a server launched by Gfsh goes into auto-reconnect the server's PID file is deleted

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45844/#review127703
---


Ship it!




Ship It!

- Jens Deppe


On April 6, 2016, 11:39 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45844/
> ---
> 
> (Updated April 6, 2016, 11:39 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Jens Deppe, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> ServerLauncher needed to be made aware of auto-reconnect.  I changed 
> getCache() to look for a new, reconnected cache and I changed isWaiting() to 
> see if the current cache is in a reconnecting state.
> 
> I also changed the shutdown logic to cancel reconnect attempts if the cache 
> is in that state when a stop is requested.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 
> 2a8c9f3c232a981fb8123df57c1f207d5de81f4f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java
>  d3a7050749004fd62975d10024f9e59752700e54 
> 
> Diff: https://reviews.apache.org/r/45844/diff/
> 
> 
> Testing
> ---
> 
> new tests for reconnect and for stopping the server.  Precheckin is underway. 
>  I ran manual network-down tests as well using iptable manipulation to 
> simulate a network partition with and without the change.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Building Geode with IntelliJ

[Jens Deppe]

If you've had problems with IntelliJ + Gradle correctly resolving test code
as a dependency in other sub-modules I think I've found (and committed a
fix).

Specifically, the geode-core-test.jar is necessary to build test code in
almost all other submodules. When importing the gradle project, IntelliJ
would correctly recognize a dependency on the jar but wouldn't know or be
able to build it prior to actually needing it. This would mean you'd have
to do a CLI build before being able to build in IntelliJ.

The relevant dependency is now just the geode-core test source and not the
artifacts defined by the test configuration.

Let me know (or raise a Jira) if you still have these issues after this
fix. I've tested with the latest IntelliJ (2016.1.1)

--Jens

Re: Bundled jar dependencies

[Dan Smith]

3 of these dependencies should now be gone with the changes for GEODE-1025.
spring-context-support
spring-data-gemfire
spring-data-commons

BTW, if you want to see the list of jars we ship, there's a handy gradle
task I added. It will show you what is in each war file as well as the lib
directory:

./gradlew dumpInstalledJars

On Thu, Apr 7, 2016 at 10:50 AM, Anthony Baker  wrote:

> Added JIRA:
> https://issues.apache.org/jira/browse/GEODE-1193
>
> Anthony
>
> > On Apr 7, 2016, at 9:44 AM, Jens Deppe  wrote:
> >
> > The reason that the servlet API jar is included is because it gets used
> on
> > the server classpath (where the sessions are stored). I'm going through
> the
> > Modules docs now, so we should be able to direct users to use the servlet
> > jar provided by the container. We should be OK not to ship it.
> >
> > --Jens
> >
> > On Thu, Apr 7, 2016 at 8:33 AM, John Blum  wrote:
> >
> >> I would not include the (javax.)servlet-api JAR with Geode. It will be a
> >> significant pain point for web applications (and frameworks, e.g.
> *Spring
> >> Session*) that expect a specific version of the Servlet API and then
> >> suddenly encounter conflicting versions.
> >>
> >> Also, FYI, the latest release of the core *Spring Framework
> >> * [1] is now
> 4.2.5.RELEASE.
> >> The latest *Spring Security  >*
> >> [2]
> >> release is 4.0.4.RELEASE.  The latest in the 3.x line is 3.2.9; the
> *Spring
> >> Security* version used by Geode (3.1.x) is not even supported any more.
> >>
> >>
> >> [1] http://projects.spring.io/spring-framework/
> >> [2] http://projects.spring.io/spring-security/
> >>
> >>
> >> On Thu, Apr 7, 2016 at 8:21 AM, Anthony Baker 
> wrote:
> >>
> >>> You can’t tell from the diff below but it turns out we’re including two
> >>> versions of servlet-api:
> >>>
> >>> servlet-api-2.5.jar
> >>> javax.servlet-api-3.1.0.jar
> >>>
> >>> Version 3.1.0 is from the geode/lib while the older jar is from the app
> >>> server module.  Do we need to ship these at all since they are only
> >> needed
> >>> for compiling?
> >>>
> >>> Anthony
> >>>
> >>>
>  On Apr 6, 2016, at 10:51 PM, Anthony Baker  wrote:
> 
>  Here’s a comparison of the bundled jar dependencies present in the
> >>> binary distribution from the M1 release versus the current develop
> >> branch.
> >>> The good news is there aren’t that many changes despite lots of build
> >>> refactoring and new source code in pulse / modules / wan / cq.
> 
>  If you see something that looks wrong, please speak up.  I see a
> >>> possible version conflict on sl4j.
> 
>  Anthony-Baker-MacBook-Pro:tmp abaker$ diff -y --suppress-common-lines
> >>> license.M1/M1-jars license.M2/M2-jars
>  activation-1.1.1.jar|
> >>> activation-1.1.jar
> >
> >>> commons-beanutils-1.8.3.jar
> >
> >>> commons-collections-3.2.2.jar
> >
> >>> commons-digester-2.1.jar
>  commons-logging-1.1.1.jar   |
> >>> commons-logging-1.2.jar
>  hbase-0.94.27.jar   <
>  jgroups-3.6.6.Final.jar |
> >>> jgroups-3.6.7.Final.jar
> >
> >>> servlet-api-2.5.jar
> >
> >>> slf4j-api-1.7.12.jar
> >
> >>> slf4j-jdk14-1.7.7.jar
>  spring-aop-3.2.12.RELEASE.jar   |
> >>> spring-aop-4.2.4.RELEASE.jar
>  spring-aspects-3.2.12.RELEASE.jar   |
> >>> spring-aspects-4.2.4.RELEASE.jar
>  spring-beans-3.2.12.RELEASE.jar |
> >>> spring-beans-4.2.4.RELEASE.jar
>  spring-context-3.2.12.RELEASE.jar   |
> >>> spring-context-4.2.4.RELEASE.jar
>  spring-context-support-3.2.12.RELEASE.jar   |
> >>> spring-context-support-4.2.4.RELEASE.jar
>  spring-core-3.2.12.RELEASE.jar  |
> >>> spring-core-4.2.4.RELEASE.jar
>  spring-data-gemfire-1.5.1.RELEASE.jar   |
> >>> spring-data-gemfire-1.7.2.RELEASE.jar
>  spring-expression-3.2.12.RELEASE.jar|
> >>> spring-expression-4.2.4.RELEASE.jar
>  spring-oxm-3.2.12.RELEASE.jar   |
> >>> spring-ldap-core-1.3.2.RELEASE.jar
> >
> >>> spring-oxm-4.2.4.RELEASE.jar
> >
> >>> spring-security-config-3.1.7.RELEASE.jar
> >
> >>> spring-security-core-3.1.7.RELEASE.jar
> >
> >>> spring-security-ldap-3.1.7.RELEASE.jar
> >
> >>> spring-security-web-3.1.7.RELEASE.jar
>  spring-tx-3.2.12.RELEASE.jar|
> >>> spring-tx-4.2.4.RELEASE.jar
>  spring-web-3.2.12.RELEASE.jar   |
> >>> spring-web-4.2.4.RELEASE.jar
>  spring-webmvc-3.2.12.RELEASE.jar

Re: Review Request 45844: GEODE-1187 If a server launched by Gfsh goes into auto-reconnect the server's PID file is deleted

[Jianxia Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45844/#review127686
---


Ship it!




Ship It!

- Jianxia Chen


On April 6, 2016, 11:39 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45844/
> ---
> 
> (Updated April 6, 2016, 11:39 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Jens Deppe, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> ServerLauncher needed to be made aware of auto-reconnect.  I changed 
> getCache() to look for a new, reconnected cache and I changed isWaiting() to 
> see if the current cache is in a reconnecting state.
> 
> I also changed the shutdown logic to cancel reconnect attempts if the cache 
> is in that state when a stop is requested.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 
> 2a8c9f3c232a981fb8123df57c1f207d5de81f4f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java
>  d3a7050749004fd62975d10024f9e59752700e54 
> 
> Diff: https://reviews.apache.org/r/45844/diff/
> 
> 
> Testing
> ---
> 
> new tests for reconnect and for stopping the server.  Precheckin is underway. 
>  I ran manual network-down tests as well using iptable manipulation to 
> simulate a network partition with and without the change.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 45880: Added Lucene Index creation on RR expects exception test. Minor refactoring

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45880/#review127669
---


Fix it, then Ship it!





geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
 (line 214)


It would be good to stick with the naming conventions of the other methods. 
Eg 

cannotCreateLuceneIndexForReplicationRegion instead of 
testCannot...


- Dan Smith


On April 7, 2016, 5:22 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45880/
> ---
> 
> (Updated April 7, 2016, 5:22 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added a test that expects unsupported exception when creating a lucene index 
> on replicated region
> 
> Instead of a sleep/wait, instead will use awaitility to wait until async 
> queue size is 0.  The todo to flush the queue instead is still there and 
> should be easy to replace the awaitility call
> 
> Removed the createBasicCache code and merged it with getCache() (This will 
> hopefully remove any chance to accidently createBasicCache and then call 
> getCache() and end up with two caches).  
> 
> getCache() and getService() will now return the cache and luceneservice.
> 
> renamed a test to be slightly more descriptive.  createRegionFirst() to 
> cannotCreateLuceneIndexAfterRegionHasBeenCreated()
> 
> removed dead code on else block where a root region was being created even 
> though it was not supposed to be and it was also not being used.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java
>  405c986 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
>  159fd46 
> 
> Diff: https://reviews.apache.org/r/45880/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Review Request 45897: Update gemfire-spark project to geode-spark project and also renamed packages and files

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45897/
---

Review request for geode, anilkumar gingade, Jianxia Chen, Qihong Chen, and Dan 
Smith.


Repository: geode


Description
---

Related to GEODE-917

May have gone too far with this, but removed GemFire, Gemfire and gemfire from 
all possible locations (except for imports that use geode classes, which still 
have the old package name)

Updated docs and examples


Diffs
-

  geode-spark-connector/doc/10_demos.md 30da687 
  geode-spark-connector/doc/1_building.md 9b4d69e 
  geode-spark-connector/doc/2_quick.md ec331c3 
  geode-spark-connector/doc/3_connecting.md 8972be9 
  geode-spark-connector/doc/4_loading.md b67a96e 
  geode-spark-connector/doc/5_rdd_join.md 81be061 
  geode-spark-connector/doc/6_save_rdd.md 004ef62 
  geode-spark-connector/doc/7_save_dstream.md ecc793b 
  geode-spark-connector/doc/8_oql.md f409698 
  geode-spark-connector/doc/9_java_api.md b9ac91e 
  
geode-spark-connector/gemfire-functions/src/main/java/io/pivotal/gemfire/spark/connector/internal/RegionMetadata.java
 fde6204 
  
geode-spark-connector/gemfire-functions/src/main/java/io/pivotal/gemfire/spark/connector/internal/gemfirefunctions/QueryFunction.java
 862bc9f 
  
geode-spark-connector/gemfire-functions/src/main/java/io/pivotal/gemfire/spark/connector/internal/gemfirefunctions/RetrieveRegionFunction.java
 d5a69f3 
  
geode-spark-connector/gemfire-functions/src/main/java/io/pivotal/gemfire/spark/connector/internal/gemfirefunctions/RetrieveRegionMetadataFunction.java
 de62cc1 
  
geode-spark-connector/gemfire-functions/src/main/java/io/pivotal/gemfire/spark/connector/internal/gemfirefunctions/StructStreamingResultSender.java
 793de6a 
  
geode-spark-connector/gemfire-spark-connector/src/it/java/ittest/io/pivotal/gemfire/spark/connector/Employee.java
 6cb571f 
  
geode-spark-connector/gemfire-spark-connector/src/it/java/ittest/io/pivotal/gemfire/spark/connector/JavaApiIntegrationTest.java
 bb75c7a 
  
geode-spark-connector/gemfire-spark-connector/src/it/java/ittest/io/pivotal/gemfire/spark/connector/Portfolio.java
 5fa03c6 
  
geode-spark-connector/gemfire-spark-connector/src/it/java/ittest/io/pivotal/gemfire/spark/connector/Position.java
 b8e8be9 
  
geode-spark-connector/gemfire-spark-connector/src/it/resources/test-regions.xml 
79893d6 
  
geode-spark-connector/gemfire-spark-connector/src/it/resources/test-retrieve-regions.xml
 3023959 
  
geode-spark-connector/gemfire-spark-connector/src/it/scala/ittest/io/pivotal/gemfire/spark/connector/BasicIntegrationTest.scala
 10c7eaf 
  
geode-spark-connector/gemfire-spark-connector/src/it/scala/ittest/io/pivotal/gemfire/spark/connector/RDDJoinRegionIntegrationTest.scala
 c286491 
  
geode-spark-connector/gemfire-spark-connector/src/it/scala/ittest/io/pivotal/gemfire/spark/connector/RetrieveRegionIntegrationTest.scala
 0ab8110 
  
geode-spark-connector/gemfire-spark-connector/src/it/scala/ittest/io/pivotal/gemfire/spark/connector/package.scala
 298dc4a 
  
geode-spark-connector/gemfire-spark-connector/src/it/scala/ittest/io/pivotal/gemfire/spark/connector/testkit/GemFireCluster.scala
 d8e07f5 
  
geode-spark-connector/gemfire-spark-connector/src/it/scala/ittest/io/pivotal/gemfire/spark/connector/testkit/GemFireRunner.scala
 b4ee572 
  
geode-spark-connector/gemfire-spark-connector/src/it/scala/ittest/io/pivotal/gemfire/spark/connector/testkit/IOUtils.scala
 28134a8 
  
geode-spark-connector/gemfire-spark-connector/src/it/scala/org/apache/spark/streaming/ManualClockHelper.scala
 67f9e57 
  
geode-spark-connector/gemfire-spark-connector/src/it/scala/org/apache/spark/streaming/TestInputDStream.scala
 fce1e67 
  
geode-spark-connector/gemfire-spark-connector/src/main/java/io/pivotal/gemfire/spark/connector/javaapi/GemFireJavaDStreamFunctions.java
 527b462 
  
geode-spark-connector/gemfire-spark-connector/src/main/java/io/pivotal/gemfire/spark/connector/javaapi/GemFireJavaPairDStreamFunctions.java
 6556462 
  
geode-spark-connector/gemfire-spark-connector/src/main/java/io/pivotal/gemfire/spark/connector/javaapi/GemFireJavaPairRDDFunctions.java
 72fa7a9 
  
geode-spark-connector/gemfire-spark-connector/src/main/java/io/pivotal/gemfire/spark/connector/javaapi/GemFireJavaRDDFunctions.java
 519ba6e 
  
geode-spark-connector/gemfire-spark-connector/src/main/java/io/pivotal/gemfire/spark/connector/javaapi/GemFireJavaSQLContextFunctions.java
 980c409 
  
geode-spark-connector/gemfire-spark-connector/src/main/java/io/pivotal/gemfire/spark/connector/javaapi/GemFireJavaSparkContextFunctions.java
 f8b930c 
  
geode-spark-connector/gemfire-spark-connector/src/main/java/io/pivotal/gemfire/spark/connector/javaapi/GemFireJavaUtil.java
 679f197 
  
geode-spark-connector/gemfire-spark-connector/src/main/scala/io/pivotal/gemfire/spark/connector/GemFireConnection.scala
 39ec1c1 
  

Re: Review Request 45881: GEODE-704: CI failure: HAInterestPart2DUnitTest.testRefreshEntriesFromPrimaryWhenDSMDetectsServerLive

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45881/#review127668
---


Ship it!




Ship It!

- Dan Smith


On April 7, 2016, 5:34 p.m., anilkumar gingade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45881/
> ---
> 
> (Updated April 7, 2016, 5:34 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, 
> nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-704: CI failure: 
> HAInterestPart2DUnitTest.testRefreshEntriesFromPrimaryWhenDSMDetectsServerLive
> 
> In the test client re-registers the interests after cache-server is started 
> and expects entries to be refreshed (it stops and starts the cache-server, 
> without closing the cache)...
> It looks like we are not waiting enough to see the client registration is 
> complete and events are refreshed (the re-registration happens with 
> redundancy satisfier thread).
> 
> Added wait/check to see interest registration is complete before check is 
> done for the cache entries...
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestPart2DUnitTest.java
>  02c3e71 
> 
> Diff: https://reviews.apache.org/r/45881/diff/
> 
> 
> Testing
> ---
> 
> Testing:
> Run the test 100+ times.
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>

Re: Review Request 45884: GEODE-1194: Improve Gradle build so that IntelliJ can correctly use test code in module dependencies

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45884/#review127666
---


Ship it!




Looks good! It would probably be good to verify that this doesn't screw up the 
task dependency in gradle. In other words, can you do this and see if it 
correctly compiles the geode-core test code before the lucene test code?
git clean
git geode-lucene:compileTestJava

Also, it would be good to verify this doesn't screw up the generated eclipse 
projects. Just do ./gradlew geode-lucene:eclipse and look at the generated 
geode-lucene/.classpath file to make sure no gradle output directories show up 
in there.

- Dan Smith


On April 7, 2016, 6:26 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45884/
> ---
> 
> (Updated April 7, 2016, 6:26 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1194: Improve Gradle build so that IntelliJ can correctly use test code 
> in module dependencies
> 
> 
> Diffs
> -
> 
>   extensions/geode-modules-tomcat7/build.gradle 
> 07619e86bfb4126fe79874ac0115b7f41bef32a0 
>   extensions/geode-modules/build.gradle 
> e007bca503d80371feceb49866afccfe79a11b43 
>   geode-assembly/build.gradle 7e61d1d9c7ba44ecff4c4322151a9ea715f8976a 
>   geode-cq/build.gradle 081f903318b9f582ee8e66f4fd0c33526da396c8 
>   geode-lucene/build.gradle c1eeb2eeb8bb21e382a069d34316f4023a698cdc 
>   geode-wan/build.gradle 081f903318b9f582ee8e66f4fd0c33526da396c8 
> 
> Diff: https://reviews.apache.org/r/45884/diff/
> 
> 
> Testing
> ---
> 
> Ran `test` task.
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Passed: apache/incubator-geode#317 (keys - f2eeebb)

[Travis CI]

Build Update for apache/incubator-geode
-

Build: #317
Status: Passed

Duration: 16 minutes and 44 seconds
Commit: f2eeebb (keys)
Author: Jens Deppe
Message: Adding GPG key for Jens Deppe

View the changeset: 
https://github.com/apache/incubator-geode/commit/f2eeebbb0471

View the full build log and details: 
https://travis-ci.org/apache/incubator-geode/builds/121535121

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #272 was SUCCESSFUL (with 1379 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #272 was successful.
---
Scheduled
1383 tests in total.

https://build.spring.io/browse/SGF-NAG-272/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 45879: (GEODE-1186) Geode website: reinstate Google Analytics

[Sai Boorlagadda]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45879/#review127642
---


Ship it!




Ship It!

- Sai Boorlagadda


On April 7, 2016, 6:43 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45879/
> ---
> 
> (Updated April 7, 2016, 6:43 p.m.)
> 
> 
> Review request for geode, Anthony Baker, William Markito, and Sai Boorlagadda.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> (GEODE-1186) Geode website: reinstate Google Analytics
> 
> 
> Diffs
> -
> 
>   geode-site/website/layouts/footer.html 
> 3d31236a76a0182bf43d8ebfc12a8ad610db7cf3 
>   geode-site/website/layouts/header.html 
> 5d89d7184115c8d41133bd8840d9d142b793a9da 
> 
> Diff: https://reviews.apache.org/r/45879/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

Re: Review Request 45844: GEODE-1187 If a server launched by Gfsh goes into auto-reconnect the server's PID file is deleted

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45844/#review127639
---


Ship it!




Ship It!

- Udo Kohlmeyer


On April 6, 2016, 11:39 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45844/
> ---
> 
> (Updated April 6, 2016, 11:39 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Jens Deppe, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> ServerLauncher needed to be made aware of auto-reconnect.  I changed 
> getCache() to look for a new, reconnected cache and I changed isWaiting() to 
> see if the current cache is in a reconnecting state.
> 
> I also changed the shutdown logic to cancel reconnect attempts if the cache 
> is in that state when a stop is requested.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 
> 2a8c9f3c232a981fb8123df57c1f207d5de81f4f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java
>  d3a7050749004fd62975d10024f9e59752700e54 
> 
> Diff: https://reviews.apache.org/r/45844/diff/
> 
> 
> Testing
> ---
> 
> new tests for reconnect and for stopping the server.  Precheckin is underway. 
>  I ran manual network-down tests as well using iptable manipulation to 
> simulate a network partition with and without the change.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 45879: (GEODE-1186) Geode website: reinstate Google Analytics

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45879/
---

(Updated April 7, 2016, 6:43 p.m.)


Review request for geode, Anthony Baker, William Markito, and Sai Boorlagadda.


Changes
---

Per Google's recommendation, relocated Google analytics snippet from footer to 
header


Repository: geode


Description
---

(GEODE-1186) Geode website: reinstate Google Analytics


Diffs (updated)
-

  geode-site/website/layouts/footer.html 
3d31236a76a0182bf43d8ebfc12a8ad610db7cf3 
  geode-site/website/layouts/header.html 
5d89d7184115c8d41133bd8840d9d142b793a9da 

Diff: https://reviews.apache.org/r/45879/diff/


Testing
---


Thanks,

Dave Barnes

Review Request 45884: GEODE-1194: Improve Gradle build so that IntelliJ can correctly use test code in module dependencies

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45884/
---

Review request for geode and Dan Smith.


Repository: geode


Description
---

GEODE-1194: Improve Gradle build so that IntelliJ can correctly use test code 
in module dependencies


Diffs
-

  extensions/geode-modules-tomcat7/build.gradle 
07619e86bfb4126fe79874ac0115b7f41bef32a0 
  extensions/geode-modules/build.gradle 
e007bca503d80371feceb49866afccfe79a11b43 
  geode-assembly/build.gradle 7e61d1d9c7ba44ecff4c4322151a9ea715f8976a 
  geode-cq/build.gradle 081f903318b9f582ee8e66f4fd0c33526da396c8 
  geode-lucene/build.gradle c1eeb2eeb8bb21e382a069d34316f4023a698cdc 
  geode-wan/build.gradle 081f903318b9f582ee8e66f4fd0c33526da396c8 

Diff: https://reviews.apache.org/r/45884/diff/


Testing
---

Ran `test` task.


Thanks,

Jens Deppe

Re: source code build instruction improvements on the cwiki

[Sai Boorlagadda]

Karen,

Looks good to me.

Just a suggestion to continue with the flow of instructions,
Do we need to point user to the gfsh available in the bin folder of the
extracted binary distribution?
As we instructed about extracting the binary and add the bin directory to
the path.

Sai

On Tue, Apr 5, 2016 at 1:42 PM, Karen Miller  wrote:

> I have again updated the build instructions, incorporating Dan's
> suggestions for
> for improvement.
>
> Note that while there is a gradlew.bat script (for a build on Windows) in
> the develop branch
> of the repository, there is *no* gradlew.bat script included with an Apache
> Geode
> (incubating) release of the source code.  This means that the build
> instructions differ
> based on where the source is acquired from.  These instructions assume
> acquisition of the
> repository from the develop branch, as I think should be the case for a
> Geode developer.
>
> Please take a look and suggest further feedback.  Karen
>
>
> On Fri, Mar 18, 2016 at 4:27 PM, Dan Smith  wrote:
>
> > build depends on installDist so I think "build installDist" is redundant.
> > It should be just
> > ./gradlew build
> > or
> > ./gradlew build -Dskip.tests=true
> >
> >
> > There is a gradlew.bat script for windows if you actually clone the
> source.
> > Should we tell people that only need to install gradle if they download
> the
> > source distribution?
> >
> > -Dan
> >
> > On Fri, Mar 18, 2016 at 4:20 PM, Karen Miller 
> wrote:
> >
> > > Check out improvements to the cwiki page on building Geode from source
> at
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/GEODE/Building+and+Running+Geode+from+Source
> > >
> > > I've also refined the Geode In 5 Minutes guide found at
> > > https://cwiki.apache.org/confluence/display/GEODE/Index
> > >
> > > Please consider and provide feedback.  Karen
> > >
> >
>



-- 
Sai Boorlagadda

Re: Review Request 45879: (GEODE-1186) Geode website: reinstate Google Analytics

[Sai Boorlagadda]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45879/#review127632
---


Ship it!




Ship It!

- Sai Boorlagadda


On April 7, 2016, 5:01 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45879/
> ---
> 
> (Updated April 7, 2016, 5:01 p.m.)
> 
> 
> Review request for geode, Anthony Baker, William Markito, and Sai Boorlagadda.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> (GEODE-1186) Geode website: reinstate Google Analytics
> 
> 
> Diffs
> -
> 
>   geode-site/website/layouts/footer.html 
> 3d31236a76a0182bf43d8ebfc12a8ad610db7cf3 
> 
> Diff: https://reviews.apache.org/r/45879/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

Re: Bundled jar dependencies

[Anthony Baker]

Added JIRA:
https://issues.apache.org/jira/browse/GEODE-1193

Anthony

> On Apr 7, 2016, at 9:44 AM, Jens Deppe  wrote:
> 
> The reason that the servlet API jar is included is because it gets used on
> the server classpath (where the sessions are stored). I'm going through the
> Modules docs now, so we should be able to direct users to use the servlet
> jar provided by the container. We should be OK not to ship it.
> 
> --Jens
> 
> On Thu, Apr 7, 2016 at 8:33 AM, John Blum  wrote:
> 
>> I would not include the (javax.)servlet-api JAR with Geode. It will be a
>> significant pain point for web applications (and frameworks, e.g. *Spring
>> Session*) that expect a specific version of the Servlet API and then
>> suddenly encounter conflicting versions.
>> 
>> Also, FYI, the latest release of the core *Spring Framework
>> * [1] is now 4.2.5.RELEASE.
>> The latest *Spring Security *
>> [2]
>> release is 4.0.4.RELEASE.  The latest in the 3.x line is 3.2.9; the *Spring
>> Security* version used by Geode (3.1.x) is not even supported any more.
>> 
>> 
>> [1] http://projects.spring.io/spring-framework/
>> [2] http://projects.spring.io/spring-security/
>> 
>> 
>> On Thu, Apr 7, 2016 at 8:21 AM, Anthony Baker  wrote:
>> 
>>> You can’t tell from the diff below but it turns out we’re including two
>>> versions of servlet-api:
>>> 
>>> servlet-api-2.5.jar
>>> javax.servlet-api-3.1.0.jar
>>> 
>>> Version 3.1.0 is from the geode/lib while the older jar is from the app
>>> server module.  Do we need to ship these at all since they are only
>> needed
>>> for compiling?
>>> 
>>> Anthony
>>> 
>>> 
 On Apr 6, 2016, at 10:51 PM, Anthony Baker  wrote:
 
 Here’s a comparison of the bundled jar dependencies present in the
>>> binary distribution from the M1 release versus the current develop
>> branch.
>>> The good news is there aren’t that many changes despite lots of build
>>> refactoring and new source code in pulse / modules / wan / cq.
 
 If you see something that looks wrong, please speak up.  I see a
>>> possible version conflict on sl4j.
 
 Anthony-Baker-MacBook-Pro:tmp abaker$ diff -y --suppress-common-lines
>>> license.M1/M1-jars license.M2/M2-jars
 activation-1.1.1.jar|
>>> activation-1.1.jar
> 
>>> commons-beanutils-1.8.3.jar
> 
>>> commons-collections-3.2.2.jar
> 
>>> commons-digester-2.1.jar
 commons-logging-1.1.1.jar   |
>>> commons-logging-1.2.jar
 hbase-0.94.27.jar   <
 jgroups-3.6.6.Final.jar |
>>> jgroups-3.6.7.Final.jar
> 
>>> servlet-api-2.5.jar
> 
>>> slf4j-api-1.7.12.jar
> 
>>> slf4j-jdk14-1.7.7.jar
 spring-aop-3.2.12.RELEASE.jar   |
>>> spring-aop-4.2.4.RELEASE.jar
 spring-aspects-3.2.12.RELEASE.jar   |
>>> spring-aspects-4.2.4.RELEASE.jar
 spring-beans-3.2.12.RELEASE.jar |
>>> spring-beans-4.2.4.RELEASE.jar
 spring-context-3.2.12.RELEASE.jar   |
>>> spring-context-4.2.4.RELEASE.jar
 spring-context-support-3.2.12.RELEASE.jar   |
>>> spring-context-support-4.2.4.RELEASE.jar
 spring-core-3.2.12.RELEASE.jar  |
>>> spring-core-4.2.4.RELEASE.jar
 spring-data-gemfire-1.5.1.RELEASE.jar   |
>>> spring-data-gemfire-1.7.2.RELEASE.jar
 spring-expression-3.2.12.RELEASE.jar|
>>> spring-expression-4.2.4.RELEASE.jar
 spring-oxm-3.2.12.RELEASE.jar   |
>>> spring-ldap-core-1.3.2.RELEASE.jar
> 
>>> spring-oxm-4.2.4.RELEASE.jar
> 
>>> spring-security-config-3.1.7.RELEASE.jar
> 
>>> spring-security-core-3.1.7.RELEASE.jar
> 
>>> spring-security-ldap-3.1.7.RELEASE.jar
> 
>>> spring-security-web-3.1.7.RELEASE.jar
 spring-tx-3.2.12.RELEASE.jar|
>>> spring-tx-4.2.4.RELEASE.jar
 spring-web-3.2.12.RELEASE.jar   |
>>> spring-web-4.2.4.RELEASE.jar
 spring-webmvc-3.2.12.RELEASE.jar|
>>> spring-webmvc-4.2.4.RELEASE.jar
 
 
 Anthony
 
 
>>> 
>>> 
>> 
>> 
>> --
>> -John
>> 503-504-8657
>> john.blum10101 (skype)
>> 



signature.asc
Description: Message signed with OpenPGP using GPGMail

[GitHub] incubator-geode pull request: GEODE-235: Add region name to EntryE...

[gemzdude]

GitHub user gemzdude opened a pull request:

https://github.com/apache/incubator-geode/pull/125

GEODE-235: Add region name to EntryEventImpl.toString



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gemzdude/incubator-geode feature/GEODE-235

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #125


commit 143ecafe9a40f43fb27751bf667f6aa608ed95ec
Author: Scott Jewell 
Date:   2016-04-05T18:03:06Z

GEODE-235 Modify EntryEventImpl toString to include region name and new 
unit test

commit 5fab4e86e52c1fba4b6de10f2d235ca718b159ab
Author: Scott Jewell 
Date:   2016-04-05T22:06:47Z

GEODE-235: Remove spy of system under test

commit 0c9e9a6d2a4e82bdb50a8a90c5942a99e8e01d8c
Author: Scott Jewell 
Date:   2016-04-05T23:19:30Z

GEODE-235: Simplify mock of LocalRegion

commit 96d175abc41b3b7a0d8889aaaefc504e90168314
Author: Scott Jewell 
Date:   2016-04-05T23:25:21Z

GEODE-235: Simplify mock of LocalRegion

commit b26abfc3c7580664e1a6487039906370bcab55d4
Author: Scott Jewell 
Date:   2016-04-07T17:29:41Z

Merge branch 'develop' into feature/GEODE-235




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 45881: GEODE-704: CI failure: HAInterestPart2DUnitTest.testRefreshEntriesFromPrimaryWhenDSMDetectsServerLive

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45881/
---

Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, 
nabarun nag, Dan Smith, and xiaojian zhou.


Repository: geode


Description
---

GEODE-704: CI failure: 
HAInterestPart2DUnitTest.testRefreshEntriesFromPrimaryWhenDSMDetectsServerLive

In the test client re-registers the interests after cache-server is started and 
expects entries to be refreshed (it stops and starts the cache-server, without 
closing the cache)...
It looks like we are not waiting enough to see the client registration is 
complete and events are refreshed (the re-registration happens with redundancy 
satisfier thread).

Added wait/check to see interest registration is complete before check is done 
for the cache entries...


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestPart2DUnitTest.java
 02c3e71 

Diff: https://reviews.apache.org/r/45881/diff/


Testing
---

Testing:
Run the test 100+ times.


Thanks,

anilkumar gingade

Review Request 45880: Added Lucene Index creation on RR expects exception test. Minor refactoring

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45880/
---

Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

Added a test that expects unsupported exception when creating a lucene index on 
replicated region

Instead of a sleep/wait, instead will use awaitility to wait until async queue 
size is 0.  The todo to flush the queue instead is still there and should be 
easy to replace the awaitility call

Removed the createBasicCache code and merged it with getCache() (This will 
hopefully remove any chance to accidently createBasicCache and then call 
getCache() and end up with two caches).  

getCache() and getService() will now return the cache and luceneservice.

renamed a test to be slightly more descriptive.  createRegionFirst() to 
cannotCreateLuceneIndexAfterRegionHasBeenCreated()

removed dead code on else block where a root region was being created even 
though it was not supposed to be and it was also not being used.


Diffs
-

  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAJUnitTest.java
 405c986 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java
 159fd46 

Diff: https://reviews.apache.org/r/45880/diff/


Testing
---


Thanks,

Jason Huynh

[GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

[sboorlagadda]

Github user sboorlagadda commented on the pull request:

https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 45819: GEODE-386: Change xsd namespace to apache

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45819/#review127618
---


Ship it!




Ship It!

- Dan Smith


On April 7, 2016, 2:31 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45819/
> ---
> 
> (Updated April 7, 2016, 2:31 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-386: Change xsd namespace to apache
> 
> With this change I've already pushed the XSD to 
> http://geode.apache.org/schema/cache/cache-1.0.xsd. This was needed to get 
> some of the tests to pass.
> 
> 
> Diffs
> -
> 
>   extensions/geode-modules-assembly/release/conf/cache-client.xml 
> 3ae9ba737c51ebdbf7c5bca17f2fa7d2ba4096b7 
>   extensions/geode-modules-assembly/release/conf/cache-peer.xml 
> 1f62cb1f29be965fb106617646bfdad95d97aead 
>   extensions/geode-modules-assembly/release/conf/cache-server.xml 
> b9d8c2c730d83610e0f57334c9c2d7de44925ac7 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/SharedConfiguration.java
>  a8f331a29269262772e3d62d9bf9ca13daa27592 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXml.java
>  4f1facbf4b7549df77cceaf0f40145d12640aeee 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlGenerator.java
>  57d06b0a091f23633e0bd55ba87f85694746c0da 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlParser.java
>  69899fd903b54a5d66af54d81ad61f4c2fb8de7c 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlVersion.java
>  51e840a95136d48abb4dbf1f4bad839b92dc3ecf 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GeodeEntityResolver.java
>  59d58604da9635cefa0a06bd20d1b399e06c4daf 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/configuration/domain/CacheElement.java
>  2da57968d08b776bdb0ab4a190ed3f70de8c45b8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/configuration/domain/XmlEntity.java
>  8517fc61175e137a7eaa9be2fd1353ab2eb2a82f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtils.java
>  37b7321b6513012b7e1313c2b9d9c0737af11a24 
>   
> geode-core/src/main/resources/META-INF/schemas/schema.pivotal.io/gemfire/cache/cache-9.0.xsd
>  1cd356797e7c917d1cc7ab7168814c762b96d408 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml58DUnitTest.java
>  2b2242b26f7801af932402b36bce6d806189808d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml90DUnitTest.java
>  21e6c614f090c3d5520d281ca344ebe265d3d4a7 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/SharedConfigurationJUnitTest.java
>  963f7ce55189f82430828c0a50c8e537bbb1200a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/AbstractEntityResolverTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlVersionJUnitTest.java
>  eb4ce86ebd73edbe291ebf7092635b2b8a99c2d0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/GeodeEntityResolverJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/PivotalEntityResolverJUnitTest.java
>  800e5ce83830df2501edeb252335414e8809284b 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/domain/CacheElementJUnitTest.java
>  bcb88c067221cc00303a004ad48b40a81aefd5fb 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.java
>  d8c52c697f3b6048e1e8e7c3b3b818184b8bdcbe 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsJUnitTest.java
>  0e145013da0e7f994f035a4db949ddd05a15fdaf 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/domain/CacheElementJUnitTest.xml
>  269ddcf1eb432230561928a8dae06051fbc68f83 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewNamed.xml
>  3055f31a155444ae9fab1421632088fb1a82299a 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewUnnamed.xml
>  fb50e6b7e81515fcb3c6079749a041d2e164564e 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewUnnamedExtension.xml
>  

Review Request 45879: (GEODE-1186) Geode website: reinstate Google Analytics

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45879/
---

Review request for geode, Anthony Baker, William Markito, and Sai Boorlagadda.


Repository: geode


Description
---

(GEODE-1186) Geode website: reinstate Google Analytics


Diffs
-

  geode-site/website/layouts/footer.html 
3d31236a76a0182bf43d8ebfc12a8ad610db7cf3 

Diff: https://reviews.apache.org/r/45879/diff/


Testing
---


Thanks,

Dave Barnes

Re: Bundled jar dependencies

[Jens Deppe]

The reason that the servlet API jar is included is because it gets used on
the server classpath (where the sessions are stored). I'm going through the
Modules docs now, so we should be able to direct users to use the servlet
jar provided by the container. We should be OK not to ship it.

--Jens

On Thu, Apr 7, 2016 at 8:33 AM, John Blum  wrote:

> I would not include the (javax.)servlet-api JAR with Geode. It will be a
> significant pain point for web applications (and frameworks, e.g. *Spring
> Session*) that expect a specific version of the Servlet API and then
> suddenly encounter conflicting versions.
>
> Also, FYI, the latest release of the core *Spring Framework
> * [1] is now 4.2.5.RELEASE.
> The latest *Spring Security *
> [2]
> release is 4.0.4.RELEASE.  The latest in the 3.x line is 3.2.9; the *Spring
> Security* version used by Geode (3.1.x) is not even supported any more.
>
>
> [1] http://projects.spring.io/spring-framework/
> [2] http://projects.spring.io/spring-security/
>
>
> On Thu, Apr 7, 2016 at 8:21 AM, Anthony Baker  wrote:
>
> > You can’t tell from the diff below but it turns out we’re including two
> > versions of servlet-api:
> >
> > servlet-api-2.5.jar
> > javax.servlet-api-3.1.0.jar
> >
> > Version 3.1.0 is from the geode/lib while the older jar is from the app
> > server module.  Do we need to ship these at all since they are only
> needed
> > for compiling?
> >
> > Anthony
> >
> >
> > > On Apr 6, 2016, at 10:51 PM, Anthony Baker  wrote:
> > >
> > > Here’s a comparison of the bundled jar dependencies present in the
> > binary distribution from the M1 release versus the current develop
> branch.
> > The good news is there aren’t that many changes despite lots of build
> > refactoring and new source code in pulse / modules / wan / cq.
> > >
> > > If you see something that looks wrong, please speak up.  I see a
> > possible version conflict on sl4j.
> > >
> > > Anthony-Baker-MacBook-Pro:tmp abaker$ diff -y --suppress-common-lines
> > license.M1/M1-jars license.M2/M2-jars
> > > activation-1.1.1.jar|
> > activation-1.1.jar
> > > >
> > commons-beanutils-1.8.3.jar
> > > >
> > commons-collections-3.2.2.jar
> > > >
> > commons-digester-2.1.jar
> > > commons-logging-1.1.1.jar   |
> > commons-logging-1.2.jar
> > > hbase-0.94.27.jar   <
> > > jgroups-3.6.6.Final.jar |
> > jgroups-3.6.7.Final.jar
> > > >
> > servlet-api-2.5.jar
> > > >
> > slf4j-api-1.7.12.jar
> > > >
> > slf4j-jdk14-1.7.7.jar
> > > spring-aop-3.2.12.RELEASE.jar   |
> > spring-aop-4.2.4.RELEASE.jar
> > > spring-aspects-3.2.12.RELEASE.jar   |
> > spring-aspects-4.2.4.RELEASE.jar
> > > spring-beans-3.2.12.RELEASE.jar |
> > spring-beans-4.2.4.RELEASE.jar
> > > spring-context-3.2.12.RELEASE.jar   |
> > spring-context-4.2.4.RELEASE.jar
> > > spring-context-support-3.2.12.RELEASE.jar   |
> > spring-context-support-4.2.4.RELEASE.jar
> > > spring-core-3.2.12.RELEASE.jar  |
> > spring-core-4.2.4.RELEASE.jar
> > > spring-data-gemfire-1.5.1.RELEASE.jar   |
> > spring-data-gemfire-1.7.2.RELEASE.jar
> > > spring-expression-3.2.12.RELEASE.jar|
> > spring-expression-4.2.4.RELEASE.jar
> > > spring-oxm-3.2.12.RELEASE.jar   |
> > spring-ldap-core-1.3.2.RELEASE.jar
> > > >
> > spring-oxm-4.2.4.RELEASE.jar
> > > >
> > spring-security-config-3.1.7.RELEASE.jar
> > > >
> > spring-security-core-3.1.7.RELEASE.jar
> > > >
> > spring-security-ldap-3.1.7.RELEASE.jar
> > > >
> > spring-security-web-3.1.7.RELEASE.jar
> > > spring-tx-3.2.12.RELEASE.jar|
> > spring-tx-4.2.4.RELEASE.jar
> > > spring-web-3.2.12.RELEASE.jar   |
> > spring-web-4.2.4.RELEASE.jar
> > > spring-webmvc-3.2.12.RELEASE.jar|
> > spring-webmvc-4.2.4.RELEASE.jar
> > >
> > >
> > > Anthony
> > >
> > >
> >
> >
>
>
> --
> -John
> 

Re: Need a boost in my JIRA privileges

[William Markito]

Fixed Dave.  Sorry about that.

On Thu, Apr 7, 2016 at 8:57 AM Dave Barnes  wrote:

> I can create JIRA tickets and comment on them, but am unable to assign a
> ticket (even to myself). Would someone be so kind as to enlarge my scope?
> My Apache JIRA ID is 'dbarnes97'.
> Thanks,
> -Dave
>
-- 
~/William

Need a boost in my JIRA privileges

[Dave Barnes]

I can create JIRA tickets and comment on them, but am unable to assign a
ticket (even to myself). Would someone be so kind as to enlarge my scope?
My Apache JIRA ID is 'dbarnes97'.
Thanks,
-Dave

Re: Bundled jar dependencies

[John Blum]

I would not include the (javax.)servlet-api JAR with Geode. It will be a
significant pain point for web applications (and frameworks, e.g. *Spring
Session*) that expect a specific version of the Servlet API and then
suddenly encounter conflicting versions.

Also, FYI, the latest release of the core *Spring Framework
* [1] is now 4.2.5.RELEASE.
The latest *Spring Security * [2]
release is 4.0.4.RELEASE.  The latest in the 3.x line is 3.2.9; the *Spring
Security* version used by Geode (3.1.x) is not even supported any more.


[1] http://projects.spring.io/spring-framework/
[2] http://projects.spring.io/spring-security/


On Thu, Apr 7, 2016 at 8:21 AM, Anthony Baker  wrote:

> You can’t tell from the diff below but it turns out we’re including two
> versions of servlet-api:
>
> servlet-api-2.5.jar
> javax.servlet-api-3.1.0.jar
>
> Version 3.1.0 is from the geode/lib while the older jar is from the app
> server module.  Do we need to ship these at all since they are only needed
> for compiling?
>
> Anthony
>
>
> > On Apr 6, 2016, at 10:51 PM, Anthony Baker  wrote:
> >
> > Here’s a comparison of the bundled jar dependencies present in the
> binary distribution from the M1 release versus the current develop branch.
> The good news is there aren’t that many changes despite lots of build
> refactoring and new source code in pulse / modules / wan / cq.
> >
> > If you see something that looks wrong, please speak up.  I see a
> possible version conflict on sl4j.
> >
> > Anthony-Baker-MacBook-Pro:tmp abaker$ diff -y --suppress-common-lines
> license.M1/M1-jars license.M2/M2-jars
> > activation-1.1.1.jar|
> activation-1.1.jar
> > >
> commons-beanutils-1.8.3.jar
> > >
> commons-collections-3.2.2.jar
> > >
> commons-digester-2.1.jar
> > commons-logging-1.1.1.jar   |
> commons-logging-1.2.jar
> > hbase-0.94.27.jar   <
> > jgroups-3.6.6.Final.jar |
> jgroups-3.6.7.Final.jar
> > >
> servlet-api-2.5.jar
> > >
> slf4j-api-1.7.12.jar
> > >
> slf4j-jdk14-1.7.7.jar
> > spring-aop-3.2.12.RELEASE.jar   |
> spring-aop-4.2.4.RELEASE.jar
> > spring-aspects-3.2.12.RELEASE.jar   |
> spring-aspects-4.2.4.RELEASE.jar
> > spring-beans-3.2.12.RELEASE.jar |
> spring-beans-4.2.4.RELEASE.jar
> > spring-context-3.2.12.RELEASE.jar   |
> spring-context-4.2.4.RELEASE.jar
> > spring-context-support-3.2.12.RELEASE.jar   |
> spring-context-support-4.2.4.RELEASE.jar
> > spring-core-3.2.12.RELEASE.jar  |
> spring-core-4.2.4.RELEASE.jar
> > spring-data-gemfire-1.5.1.RELEASE.jar   |
> spring-data-gemfire-1.7.2.RELEASE.jar
> > spring-expression-3.2.12.RELEASE.jar|
> spring-expression-4.2.4.RELEASE.jar
> > spring-oxm-3.2.12.RELEASE.jar   |
> spring-ldap-core-1.3.2.RELEASE.jar
> > >
> spring-oxm-4.2.4.RELEASE.jar
> > >
> spring-security-config-3.1.7.RELEASE.jar
> > >
> spring-security-core-3.1.7.RELEASE.jar
> > >
> spring-security-ldap-3.1.7.RELEASE.jar
> > >
> spring-security-web-3.1.7.RELEASE.jar
> > spring-tx-3.2.12.RELEASE.jar|
> spring-tx-4.2.4.RELEASE.jar
> > spring-web-3.2.12.RELEASE.jar   |
> spring-web-4.2.4.RELEASE.jar
> > spring-webmvc-3.2.12.RELEASE.jar|
> spring-webmvc-4.2.4.RELEASE.jar
> >
> >
> > Anthony
> >
> >
>
>


-- 
-John
503-504-8657
john.blum10101 (skype)

Re: Bundled jar dependencies

[Anthony Baker]

You can’t tell from the diff below but it turns out we’re including two 
versions of servlet-api:

servlet-api-2.5.jar
javax.servlet-api-3.1.0.jar

Version 3.1.0 is from the geode/lib while the older jar is from the app server 
module.  Do we need to ship these at all since they are only needed for 
compiling?

Anthony


> On Apr 6, 2016, at 10:51 PM, Anthony Baker  wrote:
> 
> Here’s a comparison of the bundled jar dependencies present in the binary 
> distribution from the M1 release versus the current develop branch.  The good 
> news is there aren’t that many changes despite lots of build refactoring and 
> new source code in pulse / modules / wan / cq.
> 
> If you see something that looks wrong, please speak up.  I see a possible 
> version conflict on sl4j.
> 
> Anthony-Baker-MacBook-Pro:tmp abaker$ diff -y --suppress-common-lines 
> license.M1/M1-jars license.M2/M2-jars
> activation-1.1.1.jar| 
> activation-1.1.jar
> > 
> commons-beanutils-1.8.3.jar
> > 
> commons-collections-3.2.2.jar
> > 
> commons-digester-2.1.jar
> commons-logging-1.1.1.jar   | 
> commons-logging-1.2.jar
> hbase-0.94.27.jar   <
> jgroups-3.6.6.Final.jar | 
> jgroups-3.6.7.Final.jar
> > 
> servlet-api-2.5.jar
> > 
> slf4j-api-1.7.12.jar
> > 
> slf4j-jdk14-1.7.7.jar
> spring-aop-3.2.12.RELEASE.jar   | 
> spring-aop-4.2.4.RELEASE.jar
> spring-aspects-3.2.12.RELEASE.jar   | 
> spring-aspects-4.2.4.RELEASE.jar
> spring-beans-3.2.12.RELEASE.jar | 
> spring-beans-4.2.4.RELEASE.jar
> spring-context-3.2.12.RELEASE.jar   | 
> spring-context-4.2.4.RELEASE.jar
> spring-context-support-3.2.12.RELEASE.jar   | 
> spring-context-support-4.2.4.RELEASE.jar
> spring-core-3.2.12.RELEASE.jar  | 
> spring-core-4.2.4.RELEASE.jar
> spring-data-gemfire-1.5.1.RELEASE.jar   | 
> spring-data-gemfire-1.7.2.RELEASE.jar
> spring-expression-3.2.12.RELEASE.jar| 
> spring-expression-4.2.4.RELEASE.jar
> spring-oxm-3.2.12.RELEASE.jar   | 
> spring-ldap-core-1.3.2.RELEASE.jar
> > 
> spring-oxm-4.2.4.RELEASE.jar
> > 
> spring-security-config-3.1.7.RELEASE.jar
> > 
> spring-security-core-3.1.7.RELEASE.jar
> > 
> spring-security-ldap-3.1.7.RELEASE.jar
> > 
> spring-security-web-3.1.7.RELEASE.jar
> spring-tx-3.2.12.RELEASE.jar| 
> spring-tx-4.2.4.RELEASE.jar
> spring-web-3.2.12.RELEASE.jar   | 
> spring-web-4.2.4.RELEASE.jar
> spring-webmvc-3.2.12.RELEASE.jar| 
> spring-webmvc-4.2.4.RELEASE.jar
> 
> 
> Anthony
> 
> 



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: Review Request 45819: GEODE-386: Change xsd namespace to apache

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45819/
---

(Updated April 7, 2016, 2:31 p.m.)


Review request for geode, Anthony Baker, Jinmei Liao, Kirk Lund, and Dan Smith.


Repository: geode


Description
---

GEODE-386: Change xsd namespace to apache

With this change I've already pushed the XSD to 
http://geode.apache.org/schema/cache/cache-1.0.xsd. This was needed to get some 
of the tests to pass.


Diffs
-

  extensions/geode-modules-assembly/release/conf/cache-client.xml 
3ae9ba737c51ebdbf7c5bca17f2fa7d2ba4096b7 
  extensions/geode-modules-assembly/release/conf/cache-peer.xml 
1f62cb1f29be965fb106617646bfdad95d97aead 
  extensions/geode-modules-assembly/release/conf/cache-server.xml 
b9d8c2c730d83610e0f57334c9c2d7de44925ac7 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/SharedConfiguration.java
 a8f331a29269262772e3d62d9bf9ca13daa27592 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXml.java
 4f1facbf4b7549df77cceaf0f40145d12640aeee 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlGenerator.java
 57d06b0a091f23633e0bd55ba87f85694746c0da 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlParser.java
 69899fd903b54a5d66af54d81ad61f4c2fb8de7c 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlVersion.java
 51e840a95136d48abb4dbf1f4bad839b92dc3ecf 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GeodeEntityResolver.java
 59d58604da9635cefa0a06bd20d1b399e06c4daf 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/configuration/domain/CacheElement.java
 2da57968d08b776bdb0ab4a190ed3f70de8c45b8 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/configuration/domain/XmlEntity.java
 8517fc61175e137a7eaa9be2fd1353ab2eb2a82f 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtils.java
 37b7321b6513012b7e1313c2b9d9c0737af11a24 
  
geode-core/src/main/resources/META-INF/schemas/schema.pivotal.io/gemfire/cache/cache-9.0.xsd
 1cd356797e7c917d1cc7ab7168814c762b96d408 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml58DUnitTest.java 
2b2242b26f7801af932402b36bce6d806189808d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml90DUnitTest.java 
21e6c614f090c3d5520d281ca344ebe265d3d4a7 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/SharedConfigurationJUnitTest.java
 963f7ce55189f82430828c0a50c8e537bbb1200a 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/AbstractEntityResolverTest.java
 PRE-CREATION 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlVersionJUnitTest.java
 eb4ce86ebd73edbe291ebf7092635b2b8a99c2d0 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/GeodeEntityResolverJUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/PivotalEntityResolverJUnitTest.java
 800e5ce83830df2501edeb252335414e8809284b 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/domain/CacheElementJUnitTest.java
 bcb88c067221cc00303a004ad48b40a81aefd5fb 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.java
 d8c52c697f3b6048e1e8e7c3b3b818184b8bdcbe 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsJUnitTest.java
 0e145013da0e7f994f035a4db949ddd05a15fdaf 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/domain/CacheElementJUnitTest.xml
 269ddcf1eb432230561928a8dae06051fbc68f83 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewNamed.xml
 3055f31a155444ae9fab1421632088fb1a82299a 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewUnnamed.xml
 fb50e6b7e81515fcb3c6079749a041d2e164564e 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewUnnamedExtension.xml
 38f791deeadacd4a9bbf782dc2f9f6c65b2c5d64 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeReplaceNamed.xml
 4f5b1a16b986d6535271f7db81e00c4536075e1f 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeReplaceUnnamed.xml
 4db37998ea9f3574f1e9c75e9aa46ab2e7084918 
  

Re: Review Request 45819: GEODE-386: Change xsd namespace to apache

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45819/
---

(Updated April 7, 2016, 2:31 p.m.)


Review request for geode, Anthony Baker, Jinmei Liao, Kirk Lund, and Dan Smith.


Repository: geode


Description
---

GEODE-386: Change xsd namespace to apache

With this change I've already pushed the XSD to 
http://geode.apache.org/schema/cache/cache-1.0.xsd. This was needed to get some 
of the tests to pass.


Diffs (updated)
-

  extensions/geode-modules-assembly/release/conf/cache-client.xml 
3ae9ba737c51ebdbf7c5bca17f2fa7d2ba4096b7 
  extensions/geode-modules-assembly/release/conf/cache-peer.xml 
1f62cb1f29be965fb106617646bfdad95d97aead 
  extensions/geode-modules-assembly/release/conf/cache-server.xml 
b9d8c2c730d83610e0f57334c9c2d7de44925ac7 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/SharedConfiguration.java
 a8f331a29269262772e3d62d9bf9ca13daa27592 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXml.java
 4f1facbf4b7549df77cceaf0f40145d12640aeee 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlGenerator.java
 57d06b0a091f23633e0bd55ba87f85694746c0da 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlParser.java
 69899fd903b54a5d66af54d81ad61f4c2fb8de7c 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlVersion.java
 51e840a95136d48abb4dbf1f4bad839b92dc3ecf 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/GeodeEntityResolver.java
 59d58604da9635cefa0a06bd20d1b399e06c4daf 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/configuration/domain/CacheElement.java
 2da57968d08b776bdb0ab4a190ed3f70de8c45b8 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/configuration/domain/XmlEntity.java
 8517fc61175e137a7eaa9be2fd1353ab2eb2a82f 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtils.java
 37b7321b6513012b7e1313c2b9d9c0737af11a24 
  
geode-core/src/main/resources/META-INF/schemas/schema.pivotal.io/gemfire/cache/cache-9.0.xsd
 1cd356797e7c917d1cc7ab7168814c762b96d408 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml58DUnitTest.java 
2b2242b26f7801af932402b36bce6d806189808d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml90DUnitTest.java 
21e6c614f090c3d5520d281ca344ebe265d3d4a7 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/SharedConfigurationJUnitTest.java
 963f7ce55189f82430828c0a50c8e537bbb1200a 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/AbstractEntityResolverTest.java
 PRE-CREATION 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlVersionJUnitTest.java
 eb4ce86ebd73edbe291ebf7092635b2b8a99c2d0 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/GeodeEntityResolverJUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/PivotalEntityResolverJUnitTest.java
 800e5ce83830df2501edeb252335414e8809284b 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/domain/CacheElementJUnitTest.java
 bcb88c067221cc00303a004ad48b40a81aefd5fb 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.java
 d8c52c697f3b6048e1e8e7c3b3b818184b8bdcbe 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsJUnitTest.java
 0e145013da0e7f994f035a4db949ddd05a15fdaf 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/domain/CacheElementJUnitTest.xml
 269ddcf1eb432230561928a8dae06051fbc68f83 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewNamed.xml
 3055f31a155444ae9fab1421632088fb1a82299a 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewUnnamed.xml
 fb50e6b7e81515fcb3c6079749a041d2e164564e 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeNewUnnamedExtension.xml
 38f791deeadacd4a9bbf782dc2f9f6c65b2c5d64 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeReplaceNamed.xml
 4f5b1a16b986d6535271f7db81e00c4536075e1f 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.testAddNewNodeReplaceUnnamed.xml
 4db37998ea9f3574f1e9c75e9aa46ab2e7084918