DistributionConfig and Geode system properties

[Udo Kohlmeyer]

Hi there,

As per GEODE-1377  
I've refactored DistributionConfig to extract all public system 
properties into a public DistributedSystemConfigProperties interface.


With that refactor I've touched a significant amount of classed and I, 
in advance, apologize for the merging.


I've have tried to find all references to all the properties that we use 
within Geode (be it main and test).


For future development, if we are to use and system properties, that we 
use the provided definition for that property. That will help us to 
understand where the properties are used and will make it easier if we 
need to refactor anything in the future.


I've also tried to find every reference to "gemfire." and replaced it 
with its defined counterpart. This should hopefully help us if we were 
to move away from property definitions like "gemfire.locators" to 
"geode.locators". If someone were to find that I had missed an obvious 
property to please refactor and resolve that issue.


In addition to this effort I have noticed that we use a large amount of 
properties to configure functionality. I respectfully request from all 
developers that if you were to work on some code that uses "internal" 
properties to maybe pull it out into a common interface which can be 
reused throughout the code base.


--Udo

Geode Clubhouse next Weds, June 8, 9AM PDT - Cluster Replication via WAN Gateway

[Gregory Chase]

Greetings Geode Community

It's time for the next Apache Geode Clubhouse Meeting on June 8th!

Each meeting starts with a user technology discussion topic, followed by a
contributor & committer discussion of open JIRA issues, release
coordination, and open Q

User Tech Talk: Cluster Replication via WAN Gateway

Mike Stolz, Committer to Apache Geode, and Product Manager for GemFire will
talk about how Geode and GemFire users make use of the WAN Gateway feature
to enable cluster to cluster replication.

For more information about this feature, see the recently posted blog
Active/Active
WAN-based Replication in Apache Geode
.

About the speaker: Mike leads the Product Management team for Gemfire.
He brings
a long history in the Financial Services community to Pivotal.

Standing agenda:

-Open Jiras, and ways to contribute
-Next release coordination
-Open Q

Please join us on June 8th, 2016 at:
https://pivotalcommunity.adobeconnect.com/clubhouse/

6/8 San Francisco, CA 9:00 AM PDT UTC-8 hours
6/8 New York, NY 12:00 PM EDT UTC-5 hours

As always, this meeting will be recorded and posted.


Adobe Connect tips: For issues with Chrome.  A little icon appears in the
address bar.  It's EASY to miss. You click it and it allows Adobe to use
the mic, even if you select 'allow' in the popup, it doesn't work until you
change it in address bar too.

Also, preload as much content as is possible to help bandwidth issues.

If you have never attended an Adobe Connect meeting before:

Test your connection:
https://pivotalcommunity.adobeconnect.com/common/help/en/support/meeting_test.htm

Get a quick overview: http://www.adobe.com/products/adobeconnect.html

-- 
Greg Chase

Global Head, Big Data Communities
http://www.pivotal.io/big-data

Pivotal Software
http://www.pivotal.io/

650-215-0477
@GregChase
Blog: http://geekmarketing.biz/

Re: Proposal - provide a callback to compute statistics

[Dan Smith]

I'm suggesting using standard Java 8 function interfaces for the
callbacks - IntSupplier, DoubleSupplier, etc. I can change the name of
the argument to supplier.

-Dan

On Wed, Jun 1, 2016 at 4:18 PM, Xiaojian Zhou  wrote:
> what's the difference btw supplier and sampler?
>
> On Wed, Jun 1, 2016 at 4:12 PM, Dan Smith  wrote:
>
>> Hi,
>>
>> I'd like to add some new methods to the Statistics interface to compute
>> statistics using callbacks. My original motivation for this is to make it
>> easy to record statistics that come from lucene for our lucene integration,
>> but I think this could simplify recording statistics in a lot of places.
>>
>> The basic idea is that the user provides a callback that returns the value
>> of the statistic. Geode will call the callback every sample interval to
>> recompute the value.
>>
>> See the JIRA for more details:
>> https://issues.apache.org/jira/browse/GEODE-1494
>>
>> Thoughts?
>>
>> -Dan
>>

Re: Proposal - provide a callback to compute statistics

[Xiaojian Zhou]

what's the difference btw supplier and sampler?

On Wed, Jun 1, 2016 at 4:12 PM, Dan Smith  wrote:

> Hi,
>
> I'd like to add some new methods to the Statistics interface to compute
> statistics using callbacks. My original motivation for this is to make it
> easy to record statistics that come from lucene for our lucene integration,
> but I think this could simplify recording statistics in a lot of places.
>
> The basic idea is that the user provides a callback that returns the value
> of the statistic. Geode will call the callback every sample interval to
> recompute the value.
>
> See the JIRA for more details:
> https://issues.apache.org/jira/browse/GEODE-1494
>
> Thoughts?
>
> -Dan
>

Proposal - provide a callback to compute statistics

[Dan Smith]

Hi,

I'd like to add some new methods to the Statistics interface to compute
statistics using callbacks. My original motivation for this is to make it
easy to record statistics that come from lucene for our lucene integration,
but I think this could simplify recording statistics in a lot of places.

The basic idea is that the user provides a callback that returns the value
of the statistic. Geode will call the callback every sample interval to
recompute the value.

See the JIRA for more details:
https://issues.apache.org/jira/browse/GEODE-1494

Thoughts?

-Dan

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #327 was SUCCESSFUL (with 1398 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #327 was successful.
---
Scheduled
1400 tests in total.

https://build.spring.io/browse/SGF-NAG-327/





--
This message is automatically generated by Atlassian Bamboo

Fw: Proposal for Secure UDP communication

[Hitesh Khamesra]

 
- Forwarded Message -
 From: Hitesh Khamesra 
 To: "u...@geode.incubator.apache.org"  
 Sent: Tuesday, May 31, 2016 10:57 AM
 Subject: Proposal for Secure UDP communication
   
We propose secure UDP communication for Geode 
https://cwiki.apache.org/confluence/display/GEODE/Secure+UDP+Communication+in+Geode
 here. Please let us know your feedback on this.
Thanks.HItesh



   

Re: Review Request 48148: GEODE-1179: Remove references to vsd

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48148/#review135866
---


Ship it!




- Dave Barnes


On June 1, 2016, 6:49 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48148/
> ---
> 
> (Updated June 1, 2016, 6:49 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - Also removed lingering references to DataBrowser
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java
>  5d57db6c31585cf63b4fdab4ff328fb9c9c2d94e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java
>  eca3e65ff7ffe27a9d1b4c954ea7b6cf64e7c5d6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java
>  241c9e217efb05ad1cb8bb5458cb86121e7848f9 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java
>  2ddc6eee691b7305a0618f9a40e03a39526bc7b5 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties
>  74db3930d216fffa57342d215a520b935980d5e1 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties
>  57f8f37c5df5840895d8d3374502884f95ed9829 
> 
> Diff: https://reviews.apache.org/r/48148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 48150: GEODE-1185: typo in gfsh help on alter disk-store

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48150/#review135865
---


Ship it!




- Dave Barnes


On June 1, 2016, 7:05 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48150/
> ---
> 
> (Updated June 1, 2016, 7:05 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1185: typo in gfsh help on alter disk-store
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java
>  241c9e217efb05ad1cb8bb5458cb86121e7848f9 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties
>  74db3930d216fffa57342d215a520b935980d5e1 
> 
> Diff: https://reviews.apache.org/r/48150/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 48151: Prevent lucene index from being created on region with eviction action local destroy

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48151/#review135858
---


Ship it!




Ship It!

- Dan Smith


On June 1, 2016, 8:15 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48151/
> ---
> 
> (Updated June 1, 2016, 8:15 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Throws and UnsupportedOperationException when a lucene index is being created 
> on a region with eviction action local-destroy.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java
>  f9bb8ba 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java
>  d1cd8ac 
> 
> Diff: https://reviews.apache.org/r/48151/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 48153: Resolved compile warning for LuceneQueriesIntegrationTest

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48153/#review135857
---


Ship it!




Ship It!

- Dan Smith


On June 1, 2016, 8:48 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48153/
> ---
> 
> (Updated June 1, 2016, 8:48 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Due to the method signature of verifyQueryKeys using the types supplied by 
> the LuceneQuery argument, it was expecting Object...  
> In this specific usage, we are actually always passed String... as the 
> expectedKeys.  So instead of changing the method signature of verifyQueryKeys 
> or casting a String[] to an Object[], I just changed the LuceneQuery types 
> from  to 
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java
>  13df7a9 
> 
> Diff: https://reviews.apache.org/r/48153/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 48145: GEODE-11: Adding a method to LuceneIndexImpl to dump indexes

[Dan Smith]

> On June 1, 2016, 8:49 p.m., Jason Huynh wrote:
> > Do the tests clean up the exported files?

Yes. The DiskDirRule will delete the directory after the test completes.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48145/#review135850
---


On June 1, 2016, 6:34 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48145/
> ---
> 
> (Updated June 1, 2016, 6:34 p.m.)
> 
> 
> Review request for geode and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a method to LuceneIndexImpl to invoke the DumpDirectoryFiles
> function and dump all of the index files to disk.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneIndex.java
>  951b0f9eb1fcef187dd57e3379a4f1065e12cef4 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java
>  c24cb9d8a8da1b6bb9e9f34ad2c8255f2057cdae 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java
>  0d7b859c51bc2b701b866f87d9ea496a013e1762 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java
>  4ae1efec926b495c99097a467ebcfdd3a2de802e 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
>  9f02f2b780067e742635e416286969145c8c4862 
> 
> Diff: https://reviews.apache.org/r/48145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48145: GEODE-11: Adding a method to LuceneIndexImpl to dump indexes

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48145/#review135850
---


Ship it!




Do the tests clean up the exported files?

- Jason Huynh


On June 1, 2016, 6:34 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48145/
> ---
> 
> (Updated June 1, 2016, 6:34 p.m.)
> 
> 
> Review request for geode and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a method to LuceneIndexImpl to invoke the DumpDirectoryFiles
> function and dump all of the index files to disk.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneIndex.java
>  951b0f9eb1fcef187dd57e3379a4f1065e12cef4 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java
>  c24cb9d8a8da1b6bb9e9f34ad2c8255f2057cdae 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java
>  0d7b859c51bc2b701b866f87d9ea496a013e1762 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java
>  4ae1efec926b495c99097a467ebcfdd3a2de802e 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
>  9f02f2b780067e742635e416286969145c8c4862 
> 
> Diff: https://reviews.apache.org/r/48145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48145: GEODE-11: Adding a method to LuceneIndexImpl to dump indexes

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48145/#review135848
---


Ship it!




Ship It!

- xiaojian zhou


On June 1, 2016, 6:34 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48145/
> ---
> 
> (Updated June 1, 2016, 6:34 p.m.)
> 
> 
> Review request for geode and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a method to LuceneIndexImpl to invoke the DumpDirectoryFiles
> function and dump all of the index files to disk.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneIndex.java
>  951b0f9eb1fcef187dd57e3379a4f1065e12cef4 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java
>  c24cb9d8a8da1b6bb9e9f34ad2c8255f2057cdae 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java
>  0d7b859c51bc2b701b866f87d9ea496a013e1762 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java
>  4ae1efec926b495c99097a467ebcfdd3a2de802e 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
>  9f02f2b780067e742635e416286969145c8c4862 
> 
> Diff: https://reviews.apache.org/r/48145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

M3 - config/cache.xml cleanup

[bdunlap22]

I noticed the packaged Geode M2 has some of Dan's config info the 
config/cache.xml.  Just wanted to give the M3 release peeps a friendly 
heads-up. 

Not sure if it's something that would still be in the M3 distribution.
:)

Thanks,
Brian 

Sent from my iPhone

Review Request 48151: Prevent lucene index from being created on region with eviction action local destroy

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48151/
---

Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
Smith, and xiaojian zhou.


Repository: geode


Description
---

Throws and UnsupportedOperationException when a lucene index is being created 
on a region with eviction action local-destroy.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java
 f9bb8ba 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java
 d1cd8ac 

Diff: https://reviews.apache.org/r/48151/diff/


Testing
---


Thanks,

Jason Huynh

Re: Review Request 48138: GEODE-11 Adding stats for the lucene file system.

[Dan Smith]

> On June 1, 2016, 6:27 p.m., Jason Huynh wrote:
> > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java,
> >  line 71
> > 
> >
> > Should these be passed in or be created in an overrideable method?  Do 
> > we plan on having different stats/stat types for pr and replicated region 
> > in the future?

Hmm, not yet, but I could see it happening the near future. I'll hoist these up 
into LuceneIndexForPartitionedRegion.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48138/#review135834
---


On June 1, 2016, 5:52 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48138/
> ---
> 
> (Updated June 1, 2016, 5:52 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding stats to track changes to the lucene file system.
> 
> This adds the following stats:
> readBytes
> writtenBytes
> fileCreates
> temporaryFileCreates
> fileDeletes
> fileRenames
> 
> Also added a stat for totalHits to the LuceneIndexStats.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java
>  3b58a956857830a55f11fe11ac8a57adb3b53846 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java
>  dab1b0f65c1ff38cd0a2ed09f0a981e82c39552e 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java
>  1b48316e9568f92ce02ca6fa34ebc90228736e63 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectory.java
>  28117bda74f10d8ec5c34707e935a31fadeca6a4 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java
>  5f5218a9050157836e72d64ab5d9d4c7eeeb3346 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStats.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
>  47e43b54eda9ea185650922a2c41572bce5af059 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
>  b4de0c53a5cb94380443b44b31d2fc23405e3933 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStatsJUnitTest.java
>  6633f22ea162ee18abfdde837970821178830a5b 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java
>  f0ff7cae3f68fcdb1854e04d920e40818207088c 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectoryJUnitTest.java
>  e8118c538e624e8857579345f5f314ee7c4a10ce 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java
>  4cc2d5cb5cd3682a119e91f64bb4c7a508b8e759 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java
>  78bf1de500269d06b6670174883bf268441e126d 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStatsJUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java
>  f2a6bc44b0d19bb9df465c5df336cb5ff64d2e63 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java
>  934998550420cdd900fc59a0dc0f87a80473b4af 
> 
> Diff: https://reviews.apache.org/r/48138/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48148: GEODE-1179: Remove references to vsd

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48148/#review135844
---


Ship it!




Ship It!

- Jinmei Liao


On June 1, 2016, 6:49 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48148/
> ---
> 
> (Updated June 1, 2016, 6:49 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - Also removed lingering references to DataBrowser
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java
>  5d57db6c31585cf63b4fdab4ff328fb9c9c2d94e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java
>  eca3e65ff7ffe27a9d1b4c954ea7b6cf64e7c5d6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java
>  241c9e217efb05ad1cb8bb5458cb86121e7848f9 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java
>  2ddc6eee691b7305a0618f9a40e03a39526bc7b5 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties
>  74db3930d216fffa57342d215a520b935980d5e1 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties
>  57f8f37c5df5840895d8d3374502884f95ed9829 
> 
> Diff: https://reviews.apache.org/r/48148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 48150: GEODE-1185: typo in gfsh help on alter disk-store

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48150/#review135843
---


Ship it!




Ship It!

- Jinmei Liao


On June 1, 2016, 7:05 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48150/
> ---
> 
> (Updated June 1, 2016, 7:05 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1185: typo in gfsh help on alter disk-store
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java
>  241c9e217efb05ad1cb8bb5458cb86121e7848f9 
>   
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties
>  74db3930d216fffa57342d215a520b935980d5e1 
> 
> Diff: https://reviews.apache.org/r/48150/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

[Bruce Schuchardt]

> On June 1, 2016, 5:40 p.m., Hitesh Khamesra wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java,
> >  line 373
> > 
> >
> > We were doing this.chunks = null, so jvm should claim chunks no?, I am 
> > missing something here..
> 
> Bruce Schuchardt wrote:
> A user wants us to clear the chunks list to aid in GC.  Their client JVM 
> threw an OOME and had two of these lists consuming most of the heap, though 
> there were no references to them.
> 
> Hitesh Khamesra wrote:
> Just browse client code and it seems we are calling clear method from 
> multiple places. May be we should call from "AbstractOp" after reading the 
> whole message.
> 
> Bruce Schuchardt wrote:
> After reading the Message it holds Parts that the command classes need to 
> access to deserialize the message components.  We can't clear it out until 
> all of the components have been read.  Currently server-side clearing is done 
> just before filling the Message with new contents in read().
> 
> It might be an improvement to null out the entries in the Part array in 
> Message though.
> 
> Hitesh Khamesra wrote:
> Server side, we are calling in ServerConnetcion.DoNormalMsg's finally 
> block, this looks fine. But at client side, I see it get called from multiple 
> places.

client-side clears the parts right after transmitting the message, in 
Message.sendBytes(), so I think the client side is also fine


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48095/#review135818
---


On May 31, 2016, 10:15 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48095/
> ---
> 
> (Updated May 31, 2016, 10:15 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-1468
> https://issues.apache.org/jira/browse/GEODE-1468
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> After a Message has been sent we invoke clear() on each Part contained by the 
> Message.  This was nulling out the "part" variable of the Part objects but if 
> one of these "parts" was a HeapDataOutputStream it might hold a list of large 
> buffers.  This change set alters Part to close these streams so that their 
> buffers can be cleared.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java
>  20d01da880f2786a01ee4d4bd64681cd646acd31 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java
>  a011875d4ea9aa9a14ac96e568fe6bba464bca89 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java
>  bf90fab4999ce96adced9574678605d2bf8a903a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java
>  9f05aa7a0ae0d433ff9675a5fbcffc9c98ce8e7b 
> 
> Diff: https://reviews.apache.org/r/48095/diff/
> 
> 
> Testing
> ---
> 
> New test, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Review Request 48150: GEODE-1185: typo in gfsh help on alter disk-store

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48150/
---

Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

GEODE-1185: typo in gfsh help on alter disk-store


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java
 241c9e217efb05ad1cb8bb5458cb86121e7848f9 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties
 74db3930d216fffa57342d215a520b935980d5e1 

Diff: https://reviews.apache.org/r/48150/diff/


Testing
---


Thanks,

Jens Deppe

Review Request 48148: GEODE-1179: Remove references to vsd

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48148/
---

Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.


Repository: geode


Description
---

- Also removed lingering references to DataBrowser


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/Launcher.java
 5d57db6c31585cf63b4fdab4ff328fb9c9c2d94e 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java
 eca3e65ff7ffe27a9d1b4c954ea7b6cf64e7c5d6 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java
 241c9e217efb05ad1cb8bb5458cb86121e7848f9 
  
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestCommand.java
 2ddc6eee691b7305a0618f9a40e03a39526bc7b5 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties
 74db3930d216fffa57342d215a520b935980d5e1 
  
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-online.properties
 57f8f37c5df5840895d8d3374502884f95ed9829 

Diff: https://reviews.apache.org/r/48148/diff/


Testing
---


Thanks,

Jens Deppe

Re: Review Request 48090: GEODE-1469: correctly handle the step arguements in http request

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48090/
---

(Updated June 1, 2016, 6:38 p.m.)


Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund.


Repository: geode


Description (updated)
---

GEODE-1469: correctly handle the step arguements in http request

rework. Turns out we need the expand operation of the UriComponents (some of 
our uri do have variables in them). Rework by ending and decoding the stepArgs


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java
 5ddcc514e2a72a1ec584f2d8755b53df0e59f457 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/multistep/CLIMultiStepHelper.java
 393f09bc7d92b61a24afdb8e3d4602488864f492 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
 f78c6f924f27ce0ca2bae43c3663f97ee9cd4b98 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ConfigCommandsController.java
 ebacd3d6b9d5a49d5a5e20b7598674d1ba0ea146 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/LoginHandlerInterceptor.java
 cefec91f74b499a60b21961dbbe997532a00da1d 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/ClientHttpRequest.java
 447733d28dc7397ec0d968315152583194bb447f 

Diff: https://reviews.apache.org/r/48090/diff/


Testing
---

prechecking running


Thanks,

Jinmei Liao

Re: Review Request 48138: GEODE-11 Adding stats for the lucene file system.

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48138/#review135838
---


Ship it!




Ship It!

- xiaojian zhou


On June 1, 2016, 5:52 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48138/
> ---
> 
> (Updated June 1, 2016, 5:52 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding stats to track changes to the lucene file system.
> 
> This adds the following stats:
> readBytes
> writtenBytes
> fileCreates
> temporaryFileCreates
> fileDeletes
> fileRenames
> 
> Also added a stat for totalHits to the LuceneIndexStats.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  8f2cb10a0dc2d930362473f575042ec25f04c7f2 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java
>  3b58a956857830a55f11fe11ac8a57adb3b53846 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java
>  dab1b0f65c1ff38cd0a2ed09f0a981e82c39552e 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java
>  1b48316e9568f92ce02ca6fa34ebc90228736e63 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectory.java
>  28117bda74f10d8ec5c34707e935a31fadeca6a4 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java
>  5f5218a9050157836e72d64ab5d9d4c7eeeb3346 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStats.java
>  PRE-CREATION 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
>  47e43b54eda9ea185650922a2c41572bce5af059 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
>  b4de0c53a5cb94380443b44b31d2fc23405e3933 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStatsJUnitTest.java
>  6633f22ea162ee18abfdde837970821178830a5b 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java
>  f0ff7cae3f68fcdb1854e04d920e40818207088c 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectoryJUnitTest.java
>  e8118c538e624e8857579345f5f314ee7c4a10ce 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java
>  4cc2d5cb5cd3682a119e91f64bb4c7a508b8e759 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java
>  78bf1de500269d06b6670174883bf268441e126d 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStatsJUnitTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java
>  f2a6bc44b0d19bb9df465c5df336cb5ff64d2e63 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java
>  934998550420cdd900fc59a0dc0f87a80473b4af 
> 
> Diff: https://reviews.apache.org/r/48138/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

[Hitesh Khamesra]

> On June 1, 2016, 5:40 p.m., Hitesh Khamesra wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java,
> >  line 373
> > 
> >
> > We were doing this.chunks = null, so jvm should claim chunks no?, I am 
> > missing something here..
> 
> Bruce Schuchardt wrote:
> A user wants us to clear the chunks list to aid in GC.  Their client JVM 
> threw an OOME and had two of these lists consuming most of the heap, though 
> there were no references to them.
> 
> Hitesh Khamesra wrote:
> Just browse client code and it seems we are calling clear method from 
> multiple places. May be we should call from "AbstractOp" after reading the 
> whole message.
> 
> Bruce Schuchardt wrote:
> After reading the Message it holds Parts that the command classes need to 
> access to deserialize the message components.  We can't clear it out until 
> all of the components have been read.  Currently server-side clearing is done 
> just before filling the Message with new contents in read().
> 
> It might be an improvement to null out the entries in the Part array in 
> Message though.

Server side, we are calling in ServerConnetcion.DoNormalMsg's finally block, 
this looks fine. But at client side, I see it get called from multiple places.


- Hitesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48095/#review135818
---


On May 31, 2016, 10:15 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48095/
> ---
> 
> (Updated May 31, 2016, 10:15 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-1468
> https://issues.apache.org/jira/browse/GEODE-1468
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> After a Message has been sent we invoke clear() on each Part contained by the 
> Message.  This was nulling out the "part" variable of the Part objects but if 
> one of these "parts" was a HeapDataOutputStream it might hold a list of large 
> buffers.  This change set alters Part to close these streams so that their 
> buffers can be cleared.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java
>  20d01da880f2786a01ee4d4bd64681cd646acd31 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java
>  a011875d4ea9aa9a14ac96e568fe6bba464bca89 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java
>  bf90fab4999ce96adced9574678605d2bf8a903a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java
>  9f05aa7a0ae0d433ff9675a5fbcffc9c98ce8e7b 
> 
> Diff: https://reviews.apache.org/r/48095/diff/
> 
> 
> Testing
> ---
> 
> New test, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Review Request 48145: GEODE-11: Adding a method to LuceneIndexImpl to dump indexes

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48145/
---

Review request for geode and xiaojian zhou.


Repository: geode


Description
---

Adding a method to LuceneIndexImpl to invoke the DumpDirectoryFiles
function and dump all of the index files to disk.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneIndex.java
 951b0f9eb1fcef187dd57e3379a4f1065e12cef4 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 8f2cb10a0dc2d930362473f575042ec25f04c7f2 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForReplicatedRegion.java
 c24cb9d8a8da1b6bb9e9f34ad2c8255f2057cdae 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java
 0d7b859c51bc2b701b866f87d9ea496a013e1762 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java
 4ae1efec926b495c99097a467ebcfdd3a2de802e 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java
 9f02f2b780067e742635e416286969145c8c4862 

Diff: https://reviews.apache.org/r/48145/diff/


Testing
---


Thanks,

Dan Smith

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

[Bruce Schuchardt]

> On June 1, 2016, 5:40 p.m., Hitesh Khamesra wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java,
> >  line 373
> > 
> >
> > We were doing this.chunks = null, so jvm should claim chunks no?, I am 
> > missing something here..
> 
> Bruce Schuchardt wrote:
> A user wants us to clear the chunks list to aid in GC.  Their client JVM 
> threw an OOME and had two of these lists consuming most of the heap, though 
> there were no references to them.
> 
> Hitesh Khamesra wrote:
> Just browse client code and it seems we are calling clear method from 
> multiple places. May be we should call from "AbstractOp" after reading the 
> whole message.

After reading the Message it holds Parts that the command classes need to 
access to deserialize the message components.  We can't clear it out until all 
of the components have been read.  Currently server-side clearing is done just 
before filling the Message with new contents in read().

It might be an improvement to null out the entries in the Part array in Message 
though.


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48095/#review135818
---


On May 31, 2016, 10:15 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48095/
> ---
> 
> (Updated May 31, 2016, 10:15 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-1468
> https://issues.apache.org/jira/browse/GEODE-1468
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> After a Message has been sent we invoke clear() on each Part contained by the 
> Message.  This was nulling out the "part" variable of the Part objects but if 
> one of these "parts" was a HeapDataOutputStream it might hold a list of large 
> buffers.  This change set alters Part to close these streams so that their 
> buffers can be cleared.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java
>  20d01da880f2786a01ee4d4bd64681cd646acd31 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java
>  a011875d4ea9aa9a14ac96e568fe6bba464bca89 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java
>  bf90fab4999ce96adced9574678605d2bf8a903a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java
>  9f05aa7a0ae0d433ff9675a5fbcffc9c98ce8e7b 
> 
> Diff: https://reviews.apache.org/r/48095/diff/
> 
> 
> Testing
> ---
> 
> New test, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] incubator-geode pull request #150: Feature/geode 308

[kjduling]

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/150

Feature/geode 308

Partially addresses GEODE-308, removing several Hydra classes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-308

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #150


commit b3613606edf154315f98dbc3f9f0bfb9e2fb9a73
Author: Kevin J. Duling 
Date:   2016-05-31T22:39:16Z

GEODE-308: Separate hydra from dunit and junit tests in gemfire-core

Removed hydra classes.

commit 0caa1c8cef35ee8ac24dae604e7cfae422db361f
Author: Kevin J. Duling 
Date:   2016-05-31T22:58:21Z

Merge branch 'develop' into feature/GEODE-308

commit eb37b1cac9d611d77374949065364f79861f62d1
Author: Kevin J. Duling 
Date:   2016-06-01T17:14:47Z

Merge branch 'develop' into feature/GEODE-308




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

[Hitesh Khamesra]

> On June 1, 2016, 5:40 p.m., Hitesh Khamesra wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java,
> >  line 373
> > 
> >
> > We were doing this.chunks = null, so jvm should claim chunks no?, I am 
> > missing something here..
> 
> Bruce Schuchardt wrote:
> A user wants us to clear the chunks list to aid in GC.  Their client JVM 
> threw an OOME and had two of these lists consuming most of the heap, though 
> there were no references to them.

Just browse client code and it seems we are calling clear method from multiple 
places. May be we should call from "AbstractOp" after reading the whole message.


- Hitesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48095/#review135818
---


On May 31, 2016, 10:15 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48095/
> ---
> 
> (Updated May 31, 2016, 10:15 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-1468
> https://issues.apache.org/jira/browse/GEODE-1468
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> After a Message has been sent we invoke clear() on each Part contained by the 
> Message.  This was nulling out the "part" variable of the Part objects but if 
> one of these "parts" was a HeapDataOutputStream it might hold a list of large 
> buffers.  This change set alters Part to close these streams so that their 
> buffers can be cleared.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java
>  20d01da880f2786a01ee4d4bd64681cd646acd31 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java
>  a011875d4ea9aa9a14ac96e568fe6bba464bca89 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java
>  bf90fab4999ce96adced9574678605d2bf8a903a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java
>  9f05aa7a0ae0d433ff9675a5fbcffc9c98ce8e7b 
> 
> Diff: https://reviews.apache.org/r/48095/diff/
> 
> 
> Testing
> ---
> 
> New test, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Review Request 48138: GEODE-11 Adding stats for the lucene file system.

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48138/
---

Review request for geode, Barry Oglesby, Jason Huynh, and xiaojian zhou.


Repository: geode


Description
---

Adding stats to track changes to the lucene file system.

This adds the following stats:
readBytes
writtenBytes
fileCreates
temporaryFileCreates
fileDeletes
fileRenames

Also added a stat for totalHits to the LuceneIndexStats.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 8f2cb10a0dc2d930362473f575042ec25f04c7f2 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java
 3b58a956857830a55f11fe11ac8a57adb3b53846 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStats.java
 dab1b0f65c1ff38cd0a2ed09f0a981e82c39552e 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java
 1b48316e9568f92ce02ca6fa34ebc90228736e63 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectory.java
 28117bda74f10d8ec5c34707e935a31fadeca6a4 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java
 5f5218a9050157836e72d64ab5d9d4c7eeeb3346 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStats.java
 PRE-CREATION 
  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImpl.java
 47e43b54eda9ea185650922a2c41572bce5af059 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java
 b4de0c53a5cb94380443b44b31d2fc23405e3933 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexStatsJUnitTest.java
 6633f22ea162ee18abfdde837970821178830a5b 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java
 f0ff7cae3f68fcdb1854e04d920e40818207088c 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/RegionDirectoryJUnitTest.java
 e8118c538e624e8857579345f5f314ee7c4a10ce 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java
 4cc2d5cb5cd3682a119e91f64bb4c7a508b8e759 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemJUnitTest.java
 78bf1de500269d06b6670174883bf268441e126d 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystemStatsJUnitTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java
 f2a6bc44b0d19bb9df465c5df336cb5ff64d2e63 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java
 934998550420cdd900fc59a0dc0f87a80473b4af 

Diff: https://reviews.apache.org/r/48138/diff/


Testing
---


Thanks,

Dan Smith

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

[Bruce Schuchardt]

> On June 1, 2016, 5:40 p.m., Hitesh Khamesra wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java,
> >  line 373
> > 
> >
> > We were doing this.chunks = null, so jvm should claim chunks no?, I am 
> > missing something here..

A user wants us to clear the chunks list to aid in GC.  Their client JVM threw 
an OOME and had two of these lists consuming most of the heap, though there 
were no references to them.


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48095/#review135818
---


On May 31, 2016, 10:15 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48095/
> ---
> 
> (Updated May 31, 2016, 10:15 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-1468
> https://issues.apache.org/jira/browse/GEODE-1468
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> After a Message has been sent we invoke clear() on each Part contained by the 
> Message.  This was nulling out the "part" variable of the Part objects but if 
> one of these "parts" was a HeapDataOutputStream it might hold a list of large 
> buffers.  This change set alters Part to close these streams so that their 
> buffers can be cleared.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java
>  20d01da880f2786a01ee4d4bd64681cd646acd31 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java
>  a011875d4ea9aa9a14ac96e568fe6bba464bca89 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java
>  bf90fab4999ce96adced9574678605d2bf8a903a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java
>  9f05aa7a0ae0d433ff9675a5fbcffc9c98ce8e7b 
> 
> Diff: https://reviews.apache.org/r/48095/diff/
> 
> 
> Testing
> ---
> 
> New test, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48095/#review135818
---




geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java
 (line 373)


We were doing this.chunks = null, so jvm should claim chunks no?, I am 
missing something here..


- Hitesh Khamesra


On May 31, 2016, 10:15 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48095/
> ---
> 
> (Updated May 31, 2016, 10:15 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-1468
> https://issues.apache.org/jira/browse/GEODE-1468
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> After a Message has been sent we invoke clear() on each Part contained by the 
> Message.  This was nulling out the "part" variable of the Part objects but if 
> one of these "parts" was a HeapDataOutputStream it might hold a list of large 
> buffers.  This change set alters Part to close these streams so that their 
> buffers can be cleared.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java
>  20d01da880f2786a01ee4d4bd64681cd646acd31 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java
>  a011875d4ea9aa9a14ac96e568fe6bba464bca89 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java
>  bf90fab4999ce96adced9574678605d2bf8a903a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java
>  9f05aa7a0ae0d433ff9675a5fbcffc9c98ce8e7b 
> 
> Diff: https://reviews.apache.org/r/48095/diff/
> 
> 
> Testing
> ---
> 
> New test, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Async queue mechanism

[Barry Oglesby]

Sure. Its a pretty simple fix. When the xml is parsed, the AEQ's attributes
are set into an intermediate object called an AsyncEventQueueCreation. The
AsyncEventQueueImpl is instantiated based on this AsyncEventQueueCreation.
During this processing, any configured GatewayEventFilters were left behind
and not set on the AsyncEventQueueImpl. The fix was to not leave any
configured GatewayEventFilters behind.

Thanks,
Barry Oglesby


On Tue, May 31, 2016 at 11:16 PM, Gal Palmery 
wrote:

> Thanks a lot Barry!
>
> Can you pls share the quick explanation about the fix?
>
>
>
> *From:* Barry Oglesby [mailto:bogle...@pivotal.io]
> *Sent:* Wednesday, June 01, 2016 03:44
> *To:* u...@geode.incubator.apache.org
> *Cc:* geode (dev@geode.incubator.apache.org)
> *Subject:* Re: Async queue mechanism
>
>
>
> I see the issue. It looks like a merge issue. I have a fix that I'll check
> in in the next day or so.
>
>
> Thanks,
>
> Barry Oglesby
>
>
>
>
>
> On Tue, May 31, 2016 at 12:52 PM, Barry Oglesby 
> wrote:
>
> I see this same behavior. I'll look into it a bit more and let you know
> what I find.
>
>
> Thanks,
>
> Barry Oglesby
>
>
>
>
>
> On Sun, May 29, 2016 at 5:38 AM, Gal Palmery 
> wrote:
>
> +Adding the dev group
>
>
>
> Thanks,
>
> Gal
>
>
>
> *From:* Gal Palmery
> *Sent:* Sunday, May 29, 2016 15:30
> *To:* u...@geode.incubator.apache.org
> *Subject:* Async queue mechanism
>
>
>
> Hi,
>
>
>
> We are using the Async queue mechanism when inserting objects into the
> regions, which is defined as follows:
>
>  batch-size="10"
>
>disk-store-name="queue-overflow" maximum-queue-memory="256">
>
> 
>
>
> imdg.listeners.myClassFilter
>
> 
>
> < >
>
>
> imdg.listeners.myClassSubstitutionFilter
>
> 
>
> 
>
>
> imdg.listeners.myClassListener
>
> 
>
> 
>
>
>
> In gemfire version 8.2,these were the steps for inserting the object to
> the queue :
>
> · SubstitutionFilter : we are taking the required objects from the
> event object and return them as the result to the filter.
>
> · Filter: beforeEnqueue method is invoked and it’s decided if the
> object will be passed to the listener. (In our filter classes - if the
> object is null we are not sending it to the listener)
>
> · Listener: gets the de-serialized value, processes it puts it in
> the relevant regions.
>
>
>
> Seems like in geode we are not passing through beforeEnqueue method in the
> Fillter step, and the null objects are not been filtered.
>
> This means that when there is no object to pass through the queue, still
> null will be passed, and in the listener code, when asking for the
> de-serialized value,
>
> we are getting also the null object, which results in a Null Pointer
> Exception.
>
>
>
> Was anything changed recently in the Async queue mechanism?
>
>
>
> Thanks,
>
> Gal
>
>
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement, you may review at
> http://www.amdocs.com/email_disclaimer.asp
>
>
>
>
>

Re: Async queue mechanism

[Barry Oglesby]

Sure. I created https://issues.apache.org/jira/browse/GEODE-1471 last night
and just added Gal's details this morning.

Thanks,
Barry Oglesby


On Wed, Jun 1, 2016 at 3:44 AM, Dor Ben Dov  wrote:

> Barry,
>
> Can you open a jira issue to file this problem, maybe with Gal's details
> mentioned below ?
>
> Dor
>
> -Original Message-
> From: Gal Palmery
> Sent: יום ד 01 יוני 2016 09:17
> To: u...@geode.incubator.apache.org
> Cc: geode (dev@geode.incubator.apache.org)
> Subject: RE: Async queue mechanism
>
> Thanks a lot Barry!
> Can you pls share the quick explanation about the fix?
>
> From: Barry Oglesby [mailto:bogle...@pivotal.io]
> Sent: Wednesday, June 01, 2016 03:44
> To: u...@geode.incubator.apache.org
> Cc: geode (dev@geode.incubator.apache.org)
> Subject: Re: Async queue mechanism
>
> I see the issue. It looks like a merge issue. I have a fix that I'll check
> in in the next day or so.
>
> Thanks,
> Barry Oglesby
>
>
> On Tue, May 31, 2016 at 12:52 PM, Barry Oglesby  > wrote:
> I see this same behavior. I'll look into it a bit more and let you know
> what I find.
>
> Thanks,
> Barry Oglesby
>
>
> On Sun, May 29, 2016 at 5:38 AM, Gal Palmery  > wrote:
> +Adding the dev group
>
> Thanks,
> Gal
>
> From: Gal Palmery
> Sent: Sunday, May 29, 2016 15:30
> To: u...@geode.incubator.apache.org >
> Subject: Async queue mechanism
>
> Hi,
>
> We are using the Async queue mechanism when inserting objects into the
> regions, which is defined as follows:
>  batch-size="10"
>disk-store-name="queue-overflow" maximum-queue-memory="256">
> 
>
> imdg.listeners.myClassFilter
> 
> < >
>
> imdg.listeners.myClassSubstitutionFilter
> 
> 
>
> imdg.listeners.myClassListener
> 
> 
>
> In gemfire version 8.2,these were the steps for inserting the object to
> the queue :
>
> · SubstitutionFilter : we are taking the required objects from the
> event object and return them as the result to the filter.
>
> · Filter: beforeEnqueue method is invoked and it’s decided if the
> object will be passed to the listener. (In our filter classes - if the
> object is null we are not sending it to the listener)
>
> · Listener: gets the de-serialized value, processes it puts it in
> the relevant regions.
>
> Seems like in geode we are not passing through beforeEnqueue method in the
> Fillter step, and the null objects are not been filtered.
> This means that when there is no object to pass through the queue, still
> null will be passed, and in the listener code, when asking for the
> de-serialized value, we are getting also the null object, which results in
> a Null Pointer Exception.
>
> Was anything changed recently in the Async queue mechanism?
>
> Thanks,
> Gal
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement, you may review at
> http://www.amdocs.com/email_disclaimer.asp
>
>
>

Re: Review Request 47899: GEODE-1452: Annotate disabled test methods with @Ignore and @Test

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47899/#review135802
---


Ship it!




Ship It!

- Jens Deppe


On May 26, 2016, 4:36 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47899/
> ---
> 
> (Updated May 26, 2016, 4:36 p.m.)
> 
> 
> Review request for geode, Jens Deppe, Jinmei Liao, Kevin Duling, and Dan 
> Smith.
> 
> 
> Bugs: GEODE-1452
> https://issues.apache.org/jira/browse/GEODE-1452
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1452: Annotate disabled test methods with @Ignore and @Test
> 
> * remove some invalid tests
> * remove some empty javadocs
> * remove some dead code
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-hibernate/src/test/java/com/gemstone/gemfire/modules/HibernateJUnitTest.java
>  9a86f10 
>   
> extensions/geode-modules-hibernate/src/test/java/com/gemstone/gemfire/modules/SecondVMTest.java
>  e3b6480 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/mapInterface/ExceptionHandlingJUnitTest.java
>  fc3c35c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/QueryServiceJUnitTest.java
>  0c34de7 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/CustomerOptimizationsJUnitTest.java
>  26e3aff 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/INOperatorJUnitTest.java
>  fbc887c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/IUMRCompositeIteratorJUnitTest.java
>  7c627c1 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/LimitClauseJUnitTest.java
>  5280dfb 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/MiscJUnitTest.java
>  4bd3258 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/MultiRegionIndexUsageJUnitTest.java
>  4b6071c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/NestedQueryJUnitTest.java
>  11dcb0e 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/ResultsDataSerializabilityJUnitTest.java
>  cb45bad 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/CompiledJunctionInternalsJUnitTest.java
>  c3e1a45 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/QCompilerJUnitTest.java
>  bcf0b65 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/IndexMaintainceJUnitTest.java
>  3ee758b 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/transaction/QueryAndJtaJUnitTest.java
>  162ffb1 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java
>  827091f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java
>  4eea76d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/LIFOEvictionAlgoEnabledRegionJUnitTest.java
>  9df2468 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java
>  d1be04d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/BlockingHARegionJUnitTest.java
>  4b36b79 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/BlockingHARegionQueueJUnitTest.java
>  ffb4771 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARQAddOperationJUnitTest.java
>  1c7b0d0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueJUnitTest.java
>  b7fae40 
> 
> Diff: https://reviews.apache.org/r/47899/diff/
> 
> 
> Testing
> ---
> 
> precheckin (100% green)
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Review Request 48076: GEODE-1463: Legacy OperationContexts do not set the appropriate Shiro permission tuple

[Jens Deppe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48076/
---

(Updated June 1, 2016, 2:52 p.m.)


Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.


Changes
---

Added additional constructor in ResourceOperationContext


Repository: geode


Description
---

- Moved ResourceOperationContext into a 'public' package.
- Converted OperationContext into an interface.
- Cleaned up the hierarchy of everything that previously
  extended OperationContext.
- Marked GetOperationContext as abstract seeing that
  GetOperationContextImpl extends it and there are no uses of
  GetOperationContext anywhere. (So why does it still exist?).


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/CloseCQOperationContext.java
 3a29981d0712bb9bb609731b818702a4d36f91cc 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/DestroyOperationContext.java
 48ae9e519ecb10fa1209428b243e12d6f0cba0a1 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/ExecuteCQOperationContext.java
 b4a07648726dc51ed4d9ec0ee68c2133af411c61 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/ExecuteFunctionOperationContext.java
 e6bd455c0faa15e7ca63a6f96d8adb4f93043a8b 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetDurableCQsOperationContext.java
 a8de1a95e4aea8f077022fe0bb1d83bddf53c09b 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetOperationContext.java
 43b9e3aab0a20d2c149879bb04977631dd4e918a 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/InterestOperationContext.java
 79632551bd73e9d3806323fa29ca06704547c7f8 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/InvalidateOperationContext.java
 75b0c3754e317a73b45cc5955edfbe3da0a162a6 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyOperationContext.java
 71430afff5eeac8ed611461a7f2537bf25ffd9a1 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeySetOperationContext.java
 5c0eeb91f0337e317a17c990eebc4331f90d3179 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyValueOperationContext.java
 7f7ab8c404ce7ac47643eaad9723f83780fcba55 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java
 317fee6b62d084716565f008d4d99ea6376b28dc 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutAllOperationContext.java
 aff44962377f8862e40aa0ca029035780bc0c0c3 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutOperationContext.java
 867c25617d96b9404875e0b738ea63295b7b4bf3 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/QueryOperationContext.java
 f9711b7e64bfac5033805410dea7488439add9ec 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionClearOperationContext.java
 370ec6e87d67b03dd94f2eecd5f5777fedbe11e7 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionCreateOperationContext.java
 430ed084c4f564fddbf32f2358474b824951ab8a 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionDestroyOperationContext.java
 d4693d04d88d8768ba0b73911716fcb701157b0b 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionOperationContext.java
 ba199c6f84539cb474356c023cde251de67267ec 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegisterInterestOperationContext.java
 4189c31c85b017d3a434fa6833301925bee5bd45 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RemoveAllOperationContext.java
 ebc3694d50abc219855ad7988f2a5f36bafb20b0 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/StopCQOperationContext.java
 1c28f75aa4d12dc24daa30e784b87dbbce0b1ebd 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/UnregisterInterestOperationContext.java
 078066e2575a812f66c2de42d4245ec6a35eb620 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImpl.java
 f664061cdb28b6fd0de0d2cede88d55062046b92 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/ResourceOperationContext.java
 PRE-CREATION 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerToClientFunctionResultSender.java
 14b81a19a618ad997d5fc389508c01f199d3c138 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/operations/ContainsKeyOperationContext.java
 b3a7536fddbc650ec7259d0798505ec65ee69853 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommandQuery.java
 3a80e25a6f070b3e8cf27ca49dea9d074e4b5f18 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
 f8da7a8a7217b04a2cb254f1b654bd8e7ce4cca2 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java
 

Re: Review Request 48076: GEODE-1463: Legacy OperationContexts do not set the appropriate Shiro permission tuple

[Jens Deppe]

> On May 31, 2016, 9:55 p.m., Jinmei Liao wrote:
> > geode-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt,
> >  line 133
> > 
> >
> > Now that ResourceOperationContext is not public, should it still be 
> > listed here?

Yes. This file covers all classes, not just public ones.


- Jens


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48076/#review135688
---


On May 31, 2016, 9:27 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48076/
> ---
> 
> (Updated May 31, 2016, 9:27 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - Moved ResourceOperationContext into a 'public' package.
> - Converted OperationContext into an interface.
> - Cleaned up the hierarchy of everything that previously
>   extended OperationContext.
> - Marked GetOperationContext as abstract seeing that
>   GetOperationContextImpl extends it and there are no uses of
>   GetOperationContext anywhere. (So why does it still exist?).
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/CloseCQOperationContext.java
>  3a29981d0712bb9bb609731b818702a4d36f91cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/DestroyOperationContext.java
>  48ae9e519ecb10fa1209428b243e12d6f0cba0a1 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/ExecuteCQOperationContext.java
>  b4a07648726dc51ed4d9ec0ee68c2133af411c61 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/ExecuteFunctionOperationContext.java
>  e6bd455c0faa15e7ca63a6f96d8adb4f93043a8b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetDurableCQsOperationContext.java
>  a8de1a95e4aea8f077022fe0bb1d83bddf53c09b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/GetOperationContext.java
>  43b9e3aab0a20d2c149879bb04977631dd4e918a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/InterestOperationContext.java
>  79632551bd73e9d3806323fa29ca06704547c7f8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/InvalidateOperationContext.java
>  75b0c3754e317a73b45cc5955edfbe3da0a162a6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyOperationContext.java
>  71430afff5eeac8ed611461a7f2537bf25ffd9a1 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeySetOperationContext.java
>  5c0eeb91f0337e317a17c990eebc4331f90d3179 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyValueOperationContext.java
>  7f7ab8c404ce7ac47643eaad9723f83780fcba55 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/OperationContext.java
>  317fee6b62d084716565f008d4d99ea6376b28dc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutAllOperationContext.java
>  aff44962377f8862e40aa0ca029035780bc0c0c3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutOperationContext.java
>  867c25617d96b9404875e0b738ea63295b7b4bf3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/QueryOperationContext.java
>  f9711b7e64bfac5033805410dea7488439add9ec 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionClearOperationContext.java
>  370ec6e87d67b03dd94f2eecd5f5777fedbe11e7 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionCreateOperationContext.java
>  430ed084c4f564fddbf32f2358474b824951ab8a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionDestroyOperationContext.java
>  d4693d04d88d8768ba0b73911716fcb701157b0b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegionOperationContext.java
>  ba199c6f84539cb474356c023cde251de67267ec 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RegisterInterestOperationContext.java
>  4189c31c85b017d3a434fa6833301925bee5bd45 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/RemoveAllOperationContext.java
>  ebc3694d50abc219855ad7988f2a5f36bafb20b0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/StopCQOperationContext.java
>  1c28f75aa4d12dc24daa30e784b87dbbce0b1ebd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/UnregisterInterestOperationContext.java
>  078066e2575a812f66c2de42d4245ec6a35eb620 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImpl.java
>  f664061cdb28b6fd0de0d2cede88d55062046b92 
>   

Re: c++ native client memory management

[Jacob Barrett]

We do not use an external memory manager.

On Tue, May 31, 2016 at 8:14 AM Gal Palmery  wrote:

> Hi,
>
> Do you use a specific external memory manager (like mtmalloc, hoard,
> etc..) for native-client code?
>
> Thanks,
> Gal
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
> you may review at http://www.amdocs.com/email_disclaimer.asp
>

Build failed in Jenkins: Geode-nightly #486

[Apache Jenkins Server]

See 

Changes:

[jdeppe] GEODE-1455: Add SecurityTest JUnit category to outstanding gfsh / JMX

[jdeppe] GEODE-1454: Have "region" attribute, in JSONAuthorization json file be

[huynhja] GEODE-1316: Changing @since tags to @GemFire or @Geode

[eshu] GEODE-1400: An inflight transaction op could arrive later than a client

[upthewaterspout] GEODE-11: Adding a tool to dump the lucene index files

--
[...truncated 526 lines...]
:geode-web-api:signArchives SKIPPED
:geode-assembly:distTar
:geode-assembly:distZip
:geode-assembly:writeBuildInfo
:geode-assembly:srcDistTar
:geode-assembly:srcDistZip
:geode-assembly:signArchives SKIPPED
:geode-assembly:assemble
:geode-assembly:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-assembly:processTestResources
:geode-assembly:testClasses
:geode-assembly:checkMissedTests
:geode-assembly:installDist
:geode-assembly:test
:geode-assembly:check
:geode-assembly:build
:geode-assembly:distributedTest
:geode-assembly:integrationTest
:geode-common:assemble
:geode-common:compileTestJava
:geode-common:processTestResources UP-TO-DATE
:geode-common:testClasses
:geode-common:checkMissedTests
:geode-common:test
:geode-common:check
:geode-common:build
:geode-common:distributedTest
:geode-common:integrationTest
:geode-core:assemble
:geode-core:checkMissedTests
:geode-core:test
:geode-core:check
:geode-core:build
:geode-core:distributedTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:integrationTest
:geode-joptsimple:assemble
:geode-joptsimple:compileTestJava UP-TO-DATE
:geode-joptsimple:processTestResources UP-TO-DATE
:geode-joptsimple:testClasses UP-TO-DATE
:geode-joptsimple:checkMissedTests UP-TO-DATE
:geode-joptsimple:test UP-TO-DATE
:geode-joptsimple:check
:geode-joptsimple:build
:geode-joptsimple:distributedTest UP-TO-DATE
:geode-joptsimple:integrationTest UP-TO-DATE
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJava:185:
 warning: non-varargs call of varargs method with inexact argument type for 
last parameter;
verifyQueryKeys(queryWithStandardAnalyzer, expectedKeys);
   ^
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 warning

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:test

Geode M3 Release - Status

[William Markito]

We are down to only 3 items [1] and made very good progress. 

Hopefully we should be able to wrap up by end of this week and start release 
procedures next week. 

[1] 
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=92=planning=GEODE-1293=visible=12335358

~/William

RE: Async queue mechanism

[Gal Palmery]

Thanks a lot Barry!
Can you pls share the quick explanation about the fix?

From: Barry Oglesby [mailto:bogle...@pivotal.io]
Sent: Wednesday, June 01, 2016 03:44
To: u...@geode.incubator.apache.org
Cc: geode (dev@geode.incubator.apache.org)
Subject: Re: Async queue mechanism

I see the issue. It looks like a merge issue. I have a fix that I'll check in 
in the next day or so.

Thanks,
Barry Oglesby


On Tue, May 31, 2016 at 12:52 PM, Barry Oglesby 
> wrote:
I see this same behavior. I'll look into it a bit more and let you know what I 
find.

Thanks,
Barry Oglesby


On Sun, May 29, 2016 at 5:38 AM, Gal Palmery 
> wrote:
+Adding the dev group

Thanks,
Gal

From: Gal Palmery
Sent: Sunday, May 29, 2016 15:30
To: u...@geode.incubator.apache.org
Subject: Async queue mechanism

Hi,

We are using the Async queue mechanism when inserting objects into the regions, 
which is defined as follows:


imdg.listeners.myClassFilter

< >

imdg.listeners.myClassSubstitutionFilter


imdg.listeners.myClassListener



In gemfire version 8.2,these were the steps for inserting the object to the 
queue :

· SubstitutionFilter : we are taking the required objects from the 
event object and return them as the result to the filter.

· Filter: beforeEnqueue method is invoked and it’s decided if the 
object will be passed to the listener. (In our filter classes - if the object 
is null we are not sending it to the listener)

· Listener: gets the de-serialized value, processes it puts it in the 
relevant regions.

Seems like in geode we are not passing through beforeEnqueue method in the 
Fillter step, and the null objects are not been filtered.
This means that when there is no object to pass through the queue, still null 
will be passed, and in the listener code, when asking for the de-serialized 
value,
we are getting also the null object, which results in a Null Pointer Exception.

Was anything changed recently in the Async queue mechanism?

Thanks,
Gal

This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement, you may review at 
http://www.amdocs.com/email_disclaimer.asp