Re: [VOTE] Release Geronimo eclipse plugin 3.0.1 - second try
+1 On Wed, May 29, 2013 at 4:31 PM, Forrest Xia forres...@gmail.com wrote: Hi Devs, Second try to release GEP 3.0.1. It fixed the build problem on Mac OS. Please vote Geronimo eclipse plugin(GEP) 3.0.1 release. This is a release along with Geronimo server runtime release 3.0.1. For details, see http://people.apache.org/builds/geronimo/eclipse/updates/PLUGIN_RELEASE-NOTES-3.0.1.txt The GEP code up for vote is: https://repository.apache.org/content/repositories/orgapachegeronimo-031/org/apache/geronimo/devtools/geronimo-eclipse-plugin/3.0.1/geronimo-eclipse-plugin-3.0.1-source-release.tar.gz https://repository.apache.org/content/repositories/orgapachegeronimo-031/org/apache/geronimo/devtools/geronimo-eclipse-plugin/3.0.1/geronimo-eclipse-plugin-3.0.1-source-release.zip To build this source code, you need to build maven-eclipsepde-plugin 1.2 first(Its vote is ongoing now): http://svn.apache.org/repos/asf/geronimo/devtools/maven-plugins/tags/maven-plugins-1.2/ NOTE: Please use Maven 2.2.1 and Java 6 to build them. The GEP staging update site is: http://people.apache.org/builds/geronimo/eclipse/updates/ The release staging site is: https://repository.apache.org/content/repositories/orgapachegeronimo-031 The tag has created at: http://svn.apache.org/repos/asf/geronimo/devtools/eclipse-plugin/tags/geronimo-eclipse-plugin-3.0.1/ Vote will be at most open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Thanks! Regards, Forrest -- Shawn
Re: [VOTE] Geronimo devtools maven-eclipsepde-plugin 1.2 release
+1 On Wed, May 29, 2013 at 2:46 PM, Forrest Xia forres...@gmail.com wrote: Hi all, To make Geronimo eclipse plugin compiled on Mac OS, we need to release a new maven-eclipsepde-plugin 1.2. Here are artifacts for vote: Source code: https://repository.apache.org/content/repositories/orgapachegeronimo-030/org/apache/geronimo/devtools/maven-eclipsepde-plugin/1.2/maven-eclipsepde-plugin-1.2-sources.jar svn tag: http://svn.apache.org/repos/asf/geronimo/devtools/maven-plugins/tags/maven-plugins-1.2/ NOTE: please build it with maven 2.2.1 and Java 6. Vote will be at most open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Thanks! Regards, Forrest -- Shawn
[VOTE] take2 - release xbean-3.14
Hi!
I'd like to call a 2nd VOTE for releasing xbean-3.14.
This time I fixed the missing license headers and activated RAT for each build.
The staging repo can be found here:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/
The tag is https://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-3.14/
And here comes the source.zip:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/org/apache/xbean/xbean/3.14/xbean-3.14-source-release.zip
sha1:
0362adbf3364a86c5fa91001a72152a2a3a83935
The VOTE is open for 72h
[+1] all fine, let's ship it
[+0] meh don't care
[-1] nope because it contains a ${blocker}
LieGrue,
strub
Re: [VOTE] Geronimo devtools maven-eclipsepde-plugin 1.2 release
+1 2013/5/30 Shawn Jiang genspr...@gmail.com +1 On Wed, May 29, 2013 at 2:46 PM, Forrest Xia forres...@gmail.com wrote: Hi all, To make Geronimo eclipse plugin compiled on Mac OS, we need to release a new maven-eclipsepde-plugin 1.2. Here are artifacts for vote: Source code: https://repository.apache.org/content/repositories/orgapachegeronimo-030/org/apache/geronimo/devtools/maven-eclipsepde-plugin/1.2/maven-eclipsepde-plugin-1.2-sources.jar svn tag: http://svn.apache.org/repos/asf/geronimo/devtools/maven-plugins/tags/maven-plugins-1.2/ NOTE: please build it with maven 2.2.1 and Java 6. Vote will be at most open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Thanks! Regards, Forrest -- Shawn -- Ivan
[VOTE PASS] Geronimo devtools maven-eclipsepde-plugin 1.2 release
+1 vote: Forrest, Jarek, Janet, Shawn, Ivan. No -1 and +0. On Thu, May 30, 2013 at 3:40 PM, Ivan xhh...@gmail.com wrote: +1 2013/5/30 Shawn Jiang genspr...@gmail.com +1 On Wed, May 29, 2013 at 2:46 PM, Forrest Xia forres...@gmail.com wrote: Hi all, To make Geronimo eclipse plugin compiled on Mac OS, we need to release a new maven-eclipsepde-plugin 1.2. Here are artifacts for vote: Source code: https://repository.apache.org/content/repositories/orgapachegeronimo-030/org/apache/geronimo/devtools/maven-eclipsepde-plugin/1.2/maven-eclipsepde-plugin-1.2-sources.jar svn tag: http://svn.apache.org/repos/asf/geronimo/devtools/maven-plugins/tags/maven-plugins-1.2/ NOTE: please build it with maven 2.2.1 and Java 6. Vote will be at most open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Thanks! Regards, Forrest -- Shawn -- Ivan -- Thanks! Regards, Forrest
Re: [VOTE] take2 - release xbean-3.14
+1 looks good for me, thanks!
On Thu, May 30, 2013 at 3:03 PM, Mark Struberg strub...@yahoo.de wrote:
Hi!
I'd like to call a 2nd VOTE for releasing xbean-3.14.
This time I fixed the missing license headers and activated RAT for each
build.
The staging repo can be found here:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/
The tag is
https://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-3.14/
And here comes the source.zip:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/org/apache/xbean/xbean/3.14/xbean-3.14-source-release.zip
sha1:
0362adbf3364a86c5fa91001a72152a2a3a83935
The VOTE is open for 72h
[+1] all fine, let's ship it
[+0] meh don't care
[-1] nope because it contains a ${blocker}
LieGrue,
strub
--
Thanks!
Regards, Forrest
Re: [VOTE] Release Geronimo eclipse plugin 3.0.1 - second try
any more vote? On Thu, May 30, 2013 at 3:02 PM, Shawn Jiang genspr...@gmail.com wrote: +1 On Wed, May 29, 2013 at 4:31 PM, Forrest Xia forres...@gmail.com wrote: Hi Devs, Second try to release GEP 3.0.1. It fixed the build problem on Mac OS. Please vote Geronimo eclipse plugin(GEP) 3.0.1 release. This is a release along with Geronimo server runtime release 3.0.1. For details, see http://people.apache.org/builds/geronimo/eclipse/updates/PLUGIN_RELEASE-NOTES-3.0.1.txt The GEP code up for vote is: https://repository.apache.org/content/repositories/orgapachegeronimo-031/org/apache/geronimo/devtools/geronimo-eclipse-plugin/3.0.1/geronimo-eclipse-plugin-3.0.1-source-release.tar.gz https://repository.apache.org/content/repositories/orgapachegeronimo-031/org/apache/geronimo/devtools/geronimo-eclipse-plugin/3.0.1/geronimo-eclipse-plugin-3.0.1-source-release.zip To build this source code, you need to build maven-eclipsepde-plugin 1.2 first(Its vote is ongoing now): http://svn.apache.org/repos/asf/geronimo/devtools/maven-plugins/tags/maven-plugins-1.2/ NOTE: Please use Maven 2.2.1 and Java 6 to build them. The GEP staging update site is: http://people.apache.org/builds/geronimo/eclipse/updates/ The release staging site is: https://repository.apache.org/content/repositories/orgapachegeronimo-031 The tag has created at: http://svn.apache.org/repos/asf/geronimo/devtools/eclipse-plugin/tags/geronimo-eclipse-plugin-3.0.1/ Vote will be at most open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Thanks! Regards, Forrest -- Shawn -- Thanks! Regards, Forrest
Re: [VOTE] take2 - release xbean-3.14
+1
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
2013/5/30 Forrest Xia forres...@gmail.com
+1 looks good for me, thanks!
On Thu, May 30, 2013 at 3:03 PM, Mark Struberg strub...@yahoo.de wrote:
Hi!
I'd like to call a 2nd VOTE for releasing xbean-3.14.
This time I fixed the missing license headers and activated RAT for each
build.
The staging repo can be found here:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/
The tag is
https://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-3.14/
And here comes the source.zip:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/org/apache/xbean/xbean/3.14/xbean-3.14-source-release.zip
sha1:
0362adbf3364a86c5fa91001a72152a2a3a83935
The VOTE is open for 72h
[+1] all fine, let's ship it
[+0] meh don't care
[-1] nope because it contains a ${blocker}
LieGrue,
strub
--
Thanks!
Regards, Forrest
Re: [VOTE PASS] Geronimo devtools maven-eclipsepde-plugin 1.2 release
Forrest, by my count this vote was open just a bit more than 24 hours. The norm is a minimum of 72 hours. There are times when expedited release votes can be used, but not without discussion. I notice that there is not an actual source archive that is buildable. The references sources jar only contains java sources. Anyone else bothered by this? The ASF norm is to vote on source archives prepared by the release manager. I assume everyone else is voting on the svn tag? --kevan On May 30, 2013, at 7:51 AM, Forrest Xia forres...@gmail.com wrote: +1 vote: Forrest, Jarek, Janet, Shawn, Ivan. No -1 and +0. On Thu, May 30, 2013 at 3:40 PM, Ivan xhh...@gmail.com wrote: +1 2013/5/30 Shawn Jiang genspr...@gmail.com +1 On Wed, May 29, 2013 at 2:46 PM, Forrest Xia forres...@gmail.com wrote: Hi all, To make Geronimo eclipse plugin compiled on Mac OS, we need to release a new maven-eclipsepde-plugin 1.2. Here are artifacts for vote: Source code: https://repository.apache.org/content/repositories/orgapachegeronimo-030/org/apache/geronimo/devtools/maven-eclipsepde-plugin/1.2/maven-eclipsepde-plugin-1.2-sources.jar svn tag: http://svn.apache.org/repos/asf/geronimo/devtools/maven-plugins/tags/maven-plugins-1.2/ NOTE: please build it with maven 2.2.1 and Java 6. Vote will be at most open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Thanks! Regards, Forrest -- Shawn -- Ivan -- Thanks! Regards, Forrest
Re: [VOTE] take2 - release xbean-3.14
There's one minor problem, that I see.
The source archive contains a DEPENDENCIES file that causes the RAT check to
fail. After removing the file, I'm able to build. This file is not present in
the svn tag.
Everything else looks good: signature/checksum, license/notice, source, RAT.
I'm ok with or without fixing this DEPENDENCIES issue (as long as it's fixed
for future releases).
So, here's my +1 for release.
--kevan
On May 30, 2013, at 3:03 AM, Mark Struberg strub...@yahoo.de wrote:
Hi!
I'd like to call a 2nd VOTE for releasing xbean-3.14.
This time I fixed the missing license headers and activated RAT for each
build.
The staging repo can be found here:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/
The tag is https://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-3.14/
And here comes the source.zip:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/org/apache/xbean/xbean/3.14/xbean-3.14-source-release.zip
sha1:
0362adbf3364a86c5fa91001a72152a2a3a83935
The VOTE is open for 72h
[+1] all fine, let's ship it
[+0] meh don't care
[-1] nope because it contains a ${blocker}
LieGrue,
strub
Re: [VOTE] take2 - release xbean-3.14
+1
Jarek
On Thu, May 30, 2013 at 3:03 AM, Mark Struberg strub...@yahoo.de wrote:
Hi!
I'd like to call a 2nd VOTE for releasing xbean-3.14.
This time I fixed the missing license headers and activated RAT for each
build.
The staging repo can be found here:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/
The tag is https://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-3.14/
And here comes the source.zip:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/org/apache/xbean/xbean/3.14/xbean-3.14-source-release.zip
sha1:
0362adbf3364a86c5fa91001a72152a2a3a83935
The VOTE is open for 72h
[+1] all fine, let's ship it
[+0] meh don't care
[-1] nope because it contains a ${blocker}
LieGrue,
strub
Re: [VOTE] Release Geronimo eclipse plugin 3.0.1 - second try
Here's my +1 Signature/checksum, license/notice, RAT, and build all look good. On Mac OS, I built as follows: $ PATH=/usr/local/apache-maven-2.2.1/bin:$PATH M2_HOME=/usr/local/apache-maven-2.2.1/ JAVA_HOME=/System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Home mvn clean install --kevan On May 29, 2013, at 4:31 AM, Forrest Xia forres...@gmail.com wrote: Hi Devs, Second try to release GEP 3.0.1. It fixed the build problem on Mac OS. Please vote Geronimo eclipse plugin(GEP) 3.0.1 release. This is a release along with Geronimo server runtime release 3.0.1. For details, see http://people.apache.org/builds/geronimo/eclipse/updates/PLUGIN_RELEASE-NOTES-3.0.1.txt The GEP code up for vote is: https://repository.apache.org/content/repositories/orgapachegeronimo-031/org/apache/geronimo/devtools/geronimo-eclipse-plugin/3.0.1/geronimo-eclipse-plugin-3.0.1-source-release.tar.gz https://repository.apache.org/content/repositories/orgapachegeronimo-031/org/apache/geronimo/devtools/geronimo-eclipse-plugin/3.0.1/geronimo-eclipse-plugin-3.0.1-source-release.zip To build this source code, you need to build maven-eclipsepde-plugin 1.2 first(Its vote is ongoing now): http://svn.apache.org/repos/asf/geronimo/devtools/maven-plugins/tags/maven-plugins-1.2/ NOTE: Please use Maven 2.2.1 and Java 6 to build them. The GEP staging update site is: http://people.apache.org/builds/geronimo/eclipse/updates/ The release staging site is: https://repository.apache.org/content/repositories/orgapachegeronimo-031 The tag has created at: http://svn.apache.org/repos/asf/geronimo/devtools/eclipse-plugin/tags/geronimo-eclipse-plugin-3.0.1/ Vote will be at most open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Thanks! Regards, Forrest
Re: [VOTE] take2 - release xbean-3.14
How are you guys able to get a clean rat:check?
Regards,
Alan
On May 30, 2013, at 12:03 AM, Mark Struberg strub...@yahoo.de wrote:
Hi!
I'd like to call a 2nd VOTE for releasing xbean-3.14.
This time I fixed the missing license headers and activated RAT for each
build.
The staging repo can be found here:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/
The tag is https://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-3.14/
And here comes the source.zip:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/org/apache/xbean/xbean/3.14/xbean-3.14-source-release.zip
sha1:
0362adbf3364a86c5fa91001a72152a2a3a83935
The VOTE is open for 72h
[+1] all fine, let's ship it
[+0] meh don't care
[-1] nope because it contains a ${blocker}
LieGrue,
strub
Re: [VOTE] Release Geronimo eclipse plugin 3.0.1 - second try
How are you guys able to get a clean rat:check? Regards, Alan On May 29, 2013, at 1:31 AM, Forrest Xia forres...@gmail.com wrote: Hi Devs, Second try to release GEP 3.0.1. It fixed the build problem on Mac OS. Please vote Geronimo eclipse plugin(GEP) 3.0.1 release. This is a release along with Geronimo server runtime release 3.0.1. For details, see http://people.apache.org/builds/geronimo/eclipse/updates/PLUGIN_RELEASE-NOTES-3.0.1.txt The GEP code up for vote is: https://repository.apache.org/content/repositories/orgapachegeronimo-031/org/apache/geronimo/devtools/geronimo-eclipse-plugin/3.0.1/geronimo-eclipse-plugin-3.0.1-source-release.tar.gz https://repository.apache.org/content/repositories/orgapachegeronimo-031/org/apache/geronimo/devtools/geronimo-eclipse-plugin/3.0.1/geronimo-eclipse-plugin-3.0.1-source-release.zip To build this source code, you need to build maven-eclipsepde-plugin 1.2 first(Its vote is ongoing now): http://svn.apache.org/repos/asf/geronimo/devtools/maven-plugins/tags/maven-plugins-1.2/ NOTE: Please use Maven 2.2.1 and Java 6 to build them. The GEP staging update site is: http://people.apache.org/builds/geronimo/eclipse/updates/ The release staging site is: https://repository.apache.org/content/repositories/orgapachegeronimo-031 The tag has created at: http://svn.apache.org/repos/asf/geronimo/devtools/eclipse-plugin/tags/geronimo-eclipse-plugin-3.0.1/ Vote will be at most open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) -- Thanks! Regards, Forrest
Re: enabled RAT checks during build
On May 29, 2013, at 2:01 AM, Mark Struberg strub...@yahoo.de wrote: hi folks! I've enabled apache-rat in the whole xbean build. Which means the build is now defunct due to a few missing licenses. Hope we gonna fix those soon… Great idea! Regards, Alan
Re: enabled RAT checks during build
My 2 cents, I prefer to have this turned on and feel that littering the source tree with patch files and the like is a poor practice; I've seen too many debug files accidentally checked in during my lifetime. Just my 2 cents. Regards, Alan On May 29, 2013, at 8:17 AM, Jarek Gawor jga...@gmail.com wrote: I don't know about others but my source tree is usually polluted with patch files and other files that I create during development/testing/debugging. With Rat enabled by default my build will fail (as it does currently after doing svn up on xbean). So I would prefer to either delay RAT until the deploy phase or just enable RAT on the buildbot setup for xbean. Jarek On Wed, May 29, 2013 at 5:01 AM, Mark Struberg strub...@yahoo.de wrote: hi folks! I've enabled apache-rat in the whole xbean build. Which means the build is now defunct due to a few missing licenses. Hope we gonna fix those soon... LieGrue, strub
Re: enabled RAT checks during build
Running findbugs for example on each build makes sense to me at dev time. Running rat doesn't because most of the time one is changing an existing file and not adding new ones. Running rat at release time (as the name of the tool suggests) or deploy time make sense to me as that's when we want to make sure everything is in proper shape. So, my preference as mentioned before is to run it in the deploy phase as it still will catch the problems early but won't fail builds for silly reasons. Jarek On Wed, May 29, 2013 at 11:19 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: Hi i like to get it by default, @Jarek: rat can be skipped with a system property, isn't it enough for dev time? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2013/5/29 Jarek Gawor jga...@gmail.com I don't know about others but my source tree is usually polluted with patch files and other files that I create during development/testing/debugging. With Rat enabled by default my build will fail (as it does currently after doing svn up on xbean). So I would prefer to either delay RAT until the deploy phase or just enable RAT on the buildbot setup for xbean. Jarek On Wed, May 29, 2013 at 5:01 AM, Mark Struberg strub...@yahoo.de wrote: hi folks! I've enabled apache-rat in the whole xbean build. Which means the build is now defunct due to a few missing licenses. Hope we gonna fix those soon... LieGrue, strub
Re: enabled RAT checks during build
Rat is fast compared to other mvn phases so not sure you see it in dev time and if it bother you just add skip system prop to maven opts no? Le 30 mai 2013 23:25, Jarek Gawor jga...@gmail.com a écrit : Running findbugs for example on each build makes sense to me at dev time. Running rat doesn't because most of the time one is changing an existing file and not adding new ones. Running rat at release time (as the name of the tool suggests) or deploy time make sense to me as that's when we want to make sure everything is in proper shape. So, my preference as mentioned before is to run it in the deploy phase as it still will catch the problems early but won't fail builds for silly reasons. Jarek On Wed, May 29, 2013 at 11:19 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: Hi i like to get it by default, @Jarek: rat can be skipped with a system property, isn't it enough for dev time? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2013/5/29 Jarek Gawor jga...@gmail.com I don't know about others but my source tree is usually polluted with patch files and other files that I create during development/testing/debugging. With Rat enabled by default my build will fail (as it does currently after doing svn up on xbean). So I would prefer to either delay RAT until the deploy phase or just enable RAT on the buildbot setup for xbean. Jarek On Wed, May 29, 2013 at 5:01 AM, Mark Struberg strub...@yahoo.de wrote: hi folks! I've enabled apache-rat in the whole xbean build. Which means the build is now defunct due to a few missing licenses. Hope we gonna fix those soon... LieGrue, strub
Re: [VOTE] take2 - release xbean-3.14
txs Kevan.
This file gets generated during the maven release process. Will add this to the
exclude list.
And here is my
+1
LieGrue,
strub
- Original Message -
From: Kevan Miller kevan.mil...@gmail.com
To: dev@geronimo.apache.org; Mark Struberg strub...@yahoo.de
Cc:
Sent: Thursday, 30 May 2013, 16:21
Subject: Re: [VOTE] take2 - release xbean-3.14
T here's one minor problem, that I see.
The source archive contains a DEPENDENCIES file that causes the RAT check to
fail. After removing the file, I'm able to build. This file is not present
in the svn tag.
Everything else looks good: signature/checksum, license/notice, source, RAT.
I'm ok with or without fixing this DEPENDENCIES issue (as long as it's
fixed for future releases).
So, here's my +1 for release.
--kevan
On May 30, 2013, at 3:03 AM, Mark Struberg strub...@yahoo.de wrote:
Hi!
I'd like to call a 2nd VOTE for releasing xbean-3.14.
This time I fixed the missing license headers and activated RAT for each
build.
The staging repo can be found here:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/
The tag is https://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-3.14/
And here comes the source.zip:
https://repository.apache.org/content/repositories/orgapachegeronimo-038/org/apache/xbean/xbean/3.14/xbean-3.14-source-release.zip
sha1:
0362adbf3364a86c5fa91001a72152a2a3a83935
The VOTE is open for 72h
[+1] all fine, let's ship it
[+0] meh don't care
[-1] nope because it contains a ${blocker}
LieGrue,
strub
