[jira] [Updated] (GERONIMO-6792) Fix hard-coded TLSv1 version in MailConnection.java for Java Mail 1.6

[Francois Papon (Jira)]

 [ 
https://issues.apache.org/jira/browse/GERONIMO-6792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francois Papon updated GERONIMO-6792:
-
Fix Version/s: Javamail_1.6_1.0.1

> Fix hard-coded TLSv1 version in MailConnection.java for Java Mail 1.6
> -
>
> Key: GERONIMO-6792
> URL: https://issues.apache.org/jira/browse/GERONIMO-6792
> Project: Geronimo
>  Issue Type: Bug
>  Security Level: public(Regular issues) 
>  Components: mail
>Reporter: Richard Zowalla
>Priority: Major
> Fix For: Javamail_1.6_1.0.1
>
> Attachments: GERONIMO-6792-v4-no-hardcoding.diff, 
> GERONIMO-6792-v4.diff
>
>
> Hi,
> I encountered some issues when using Geronimo Java Mail 1.6 (1.0.0) bundled 
> with TomEE 8.0.5. The related thread [1] can be found on the 
> [us...@tomee.apache.org|mailto:us...@tomee.apache.org] Mailing-List.
> In short: 
>  * Our mail server does only support TLS 1.2 or TLS 1.3
>  * Geronimo Java Mail 1.6 in version 1.0.0 has TLS 1.0 hard-coded in the 
> source and does not use the default protocols or the specified ones via 
> *mail.smtp.ssl.protocols* for a TLS connection.
> I have attached a patch created via SVN DIFF. 
> [1] [https://www.mail-archive.com/users@tomee.apache.org/msg17544.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GERONIMO-6793) Do not auto-enable all available Cyphers in TLS/SSL protocol handling in MailConnection

[Francois Papon (Jira)]

 [ 
https://issues.apache.org/jira/browse/GERONIMO-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francois Papon updated GERONIMO-6793:
-
Fix Version/s: Javamail_1.6_1.0.1

> Do not auto-enable all available Cyphers in TLS/SSL protocol handling in 
> MailConnection
> ---
>
> Key: GERONIMO-6793
> URL: https://issues.apache.org/jira/browse/GERONIMO-6793
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: mail
>Reporter: Richard Zowalla
>Priority: Major
> Fix For: Javamail_1.6_1.0.1
>
> Attachments: GERONIMO-6793.diff
>
>
> Check and discuss, if it is a good idea to enable all cyphers in TLS/SSL 
> protocol handling in MailConnection.java 
> Some cyphers are deprecated for good reasons and shouldn't be used.
> This enhancement might possibily include
>  * Allow users to specifiy cyphers via properties (custom factory is already 
> possible)
>  * If we have no user defined cyphers available, fallback to the JVMs default 
> cyphers.
>  
> This is a follow up issue raised from the discussion on the dev mailing list, 
> see 
> http://mail-archives.apache.org/mod_mbox/geronimo-dev/202012.mbox/%3C096fbb867eda8e090eddf80fbd81cf787ac87945.camel%40hs-heilbronn.de%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [geronimo-javamail] fpapon commented on pull request #1: GERONIMO-6780 added Oauth2 support for geronimo Java Mail Provider

[GitBox]

fpapon commented on pull request #1:
URL: https://github.com/apache/geronimo-javamail/pull/1#issuecomment-884174733


   This one was already merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geronimo-javamail] fpapon closed pull request #1: GERONIMO-6780 added Oauth2 support for geronimo Java Mail Provider

[GitBox]

fpapon closed pull request #1:
URL: https://github.com/apache/geronimo-javamail/pull/1


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geronimo-txmanager] fpapon merged pull request #7: Update scm informations after svn to gitbox migration and add readme

[GitBox]

fpapon merged pull request #7:
URL: https://github.com/apache/geronimo-txmanager/pull/7


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geronimo-xbean] fpapon merged pull request #23: Update scm informations after svn to gitbox migration and add readme

[GitBox]

fpapon merged pull request #23:
URL: https://github.com/apache/geronimo-xbean/pull/23


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geronimo-javamail] rzo1 opened a new pull request #3: GERONIMO-6793 - Do not auto-enable all available Cyphers in TLS/SSL protocol handling in MailConnection

[GitBox]

rzo1 opened a new pull request #3:
URL: https://github.com/apache/geronimo-javamail/pull/3


   https://issues.apache.org/jira/browse/GERONIMO-6793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geronimo-javamail] rzo1 opened a new pull request #2: GERONIMO-6792 - Fix hard-coded TLSv1 version in MailConnection.java for Java Mail 1.6

[GitBox]

rzo1 opened a new pull request #2:
URL: https://github.com/apache/geronimo-javamail/pull/2


   As discussed in https://issues.apache.org/jira/browse/GERONIMO-6792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Pending patches

[Francois Papon]

Thanks!

François
fpa...@apache.org

Le 21/07/2021 à 11:59, Zowalla, Richard a écrit :
> Ok. Will do!
>
> Am Mittwoch, den 21.07.2021, 11:58 +0200 schrieb Francois Papon:
>> Hi,
>>
>> I think it's better if you can push a PR via github.
>>
>> regards,
>>
>> François
>> fpa...@apache.org
>>
>> Le 21/07/2021 à 11:01, Zowalla, Richard a écrit :
>>> Hi François,
>>>
>>> thanks for the update.
>>>
>>> Shall I migrate my SVN patch files towards GitHub Pull Requests or
>>> is
>>> the plan to apply them directly?
>>>
>>> Gruss
>>> Richard
>>>
>>>
>>> Am Mittwoch, den 21.07.2021, 10:58 +0200 schrieb Francois Papon:
 Hi all,

 This 3 repo has moved successfuly to gitbox:

   https://github.com/apache/geronimo-xbean
   https://github.com/apache/geronimo-javamail
   https://github.com/apache/geronimo-txmanager

 We can now merge the pending PRs.

 regards,

 François
 fpa...@apache.org

 Le 08/06/2021 à 14:15, Richard Zowalla a écrit :
> Thx for the ticket id !
>
> Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois
> Papon:
>> Hi,
>>
>> Migration is still pending, waiting for infra:
>>
>> https://issues.apache.org/jira/browse/INFRA-21908
>> 
>>
>> regards,
>>
>> François
>> fpa...@apache.org
>>
>> Le 08/06/2021 à 13:56, Richard Zowalla a écrit :
>>> Hi François,
>>>
>>> any updates from INFRA on this? Couldnt find the ticket id
>>> anymore,
>>> sry.
>>>
>>> Gruss
>>> Richard
>>>
>>> Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois
>>> Papon:
 Hi,

 Yes, we plan to do this just after the migration to git
 ;)

 regards,

 François
 fpa...@apache.org

 Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :
> Hi,
>
> thanks for your response! I think, that [1] might also
> affect
> the
> hard-
> coded TLS1.0 in GERONIMO-6792 [2], so the pending patch
> would
> be
> very
> appreciated.
>
> Maybe after the migration to git? ;)
>
> Gruss
> Richard
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8202343
> [2] https://issues.apache.org/jira/browse/GERONIMO-6792
>
> Am Samstag, den 01.05.2021, 08:20 +0200 schrieb 
> fpa...@apache.org:
>> Hi,
>>
>> I think I can take a look to the Jira and merge the
>> PRs.
>>
>> regards,
>>
>> François
>> fpa...@apache.org
>>
>> Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :
>>> Just to follow up on this thread:
>>>
>>> Do we have any plans for moving forward with the
>>> mail-
>>> related
>>> patches?
>>> The hard-coded TLS config in mail is a bit "pain"
>>> ;)
>>>
>>> Gruss
>>> Richard
>>>
>>> Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb
>>> Romain
>>> Manni-
>>> Bucau:
 Well it can use a singleton but from a factory
 method. So
 immediate
 solution is to add a public static X
 getInstance();.
 But as mentionned it means, to keep the
 pluggability
 we
 should
 target
 with such a spi, you will enforce all other impl
 to
 use
 such
 a
 pattern (you cant' just switch with -D easily
 since
 adding is
 easy
 but dropping system props is almost impossible).
 A noarg public constructor is trivial and more
 natural
 with
 resources
 IMHO - but once again tomee can does all the work
 to
 makes it
 equivalent, just requires to duplicate/wrap the
 impls
 of
 the
 SPI
 in
 tomee codebase which sounds weird to me ("we have
 an
 impl
 but
 you
 need to use another one").

 On a more personal note I think this pattern is
 no
 more
 relevant
 and
 has more pitfalls since you enforce a static
 instance
 as
 soon
 as
 the
 class is loaded whereas it is not needed
 depending
 the
 lifecycle
 of
 your main - it is not much but still, I see it as
 a
 leak
 in
 terms
 of

[GitHub] [geronimo-txmanager] fpapon opened a new pull request #7: Update scm informations after svn to gitbox migration and add readme

[GitBox]

fpapon opened a new pull request #7:
URL: https://github.com/apache/geronimo-txmanager/pull/7


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Pending patches

[Zowalla, Richard]

Ok. Will do!

Am Mittwoch, den 21.07.2021, 11:58 +0200 schrieb Francois Papon:
> Hi,
> 
> I think it's better if you can push a PR via github.
> 
> regards,
> 
> François
> fpa...@apache.org
> 
> Le 21/07/2021 à 11:01, Zowalla, Richard a écrit :
> > Hi François,
> > 
> > thanks for the update.
> > 
> > Shall I migrate my SVN patch files towards GitHub Pull Requests or
> > is
> > the plan to apply them directly?
> > 
> > Gruss
> > Richard
> > 
> > 
> > Am Mittwoch, den 21.07.2021, 10:58 +0200 schrieb Francois Papon:
> > > Hi all,
> > > 
> > > This 3 repo has moved successfuly to gitbox:
> > > 
> > >   https://github.com/apache/geronimo-xbean
> > >   https://github.com/apache/geronimo-javamail
> > >   https://github.com/apache/geronimo-txmanager
> > > 
> > > We can now merge the pending PRs.
> > > 
> > > regards,
> > > 
> > > François
> > > fpa...@apache.org
> > > 
> > > Le 08/06/2021 à 14:15, Richard Zowalla a écrit :
> > > > Thx for the ticket id !
> > > > 
> > > > Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois
> > > > Papon:
> > > > > Hi,
> > > > > 
> > > > > Migration is still pending, waiting for infra:
> > > > > 
> > > > > https://issues.apache.org/jira/browse/INFRA-21908
> > > > > 
> > > > > 
> > > > > regards,
> > > > > 
> > > > > François
> > > > > fpa...@apache.org
> > > > > 
> > > > > Le 08/06/2021 à 13:56, Richard Zowalla a écrit :
> > > > > > Hi François,
> > > > > > 
> > > > > > any updates from INFRA on this? Couldnt find the ticket id
> > > > > > anymore,
> > > > > > sry.
> > > > > > 
> > > > > > Gruss
> > > > > > Richard
> > > > > > 
> > > > > > Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois
> > > > > > Papon:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > Yes, we plan to do this just after the migration to git
> > > > > > > ;)
> > > > > > > 
> > > > > > > regards,
> > > > > > > 
> > > > > > > François
> > > > > > > fpa...@apache.org
> > > > > > > 
> > > > > > > Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :
> > > > > > > > Hi,
> > > > > > > > 
> > > > > > > > thanks for your response! I think, that [1] might also
> > > > > > > > affect
> > > > > > > > the
> > > > > > > > hard-
> > > > > > > > coded TLS1.0 in GERONIMO-6792 [2], so the pending patch
> > > > > > > > would
> > > > > > > > be
> > > > > > > > very
> > > > > > > > appreciated.
> > > > > > > > 
> > > > > > > > Maybe after the migration to git? ;)
> > > > > > > > 
> > > > > > > > Gruss
> > > > > > > > Richard
> > > > > > > > 
> > > > > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8202343
> > > > > > > > [2] https://issues.apache.org/jira/browse/GERONIMO-6792
> > > > > > > > 
> > > > > > > > Am Samstag, den 01.05.2021, 08:20 +0200 schrieb 
> > > > > > > > fpa...@apache.org:
> > > > > > > > > Hi,
> > > > > > > > > 
> > > > > > > > > I think I can take a look to the Jira and merge the
> > > > > > > > > PRs.
> > > > > > > > > 
> > > > > > > > > regards,
> > > > > > > > > 
> > > > > > > > > François
> > > > > > > > > fpa...@apache.org
> > > > > > > > > 
> > > > > > > > > Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :
> > > > > > > > > > Just to follow up on this thread:
> > > > > > > > > > 
> > > > > > > > > > Do we have any plans for moving forward with the
> > > > > > > > > > mail-
> > > > > > > > > > related
> > > > > > > > > > patches?
> > > > > > > > > > The hard-coded TLS config in mail is a bit "pain"
> > > > > > > > > > ;)
> > > > > > > > > > 
> > > > > > > > > > Gruss
> > > > > > > > > > Richard
> > > > > > > > > > 
> > > > > > > > > > Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb
> > > > > > > > > > Romain
> > > > > > > > > > Manni-
> > > > > > > > > > Bucau:
> > > > > > > > > > > Well it can use a singleton but from a factory
> > > > > > > > > > > method. So
> > > > > > > > > > > immediate
> > > > > > > > > > > solution is to add a public static X
> > > > > > > > > > > getInstance();.
> > > > > > > > > > > But as mentionned it means, to keep the
> > > > > > > > > > > pluggability
> > > > > > > > > > > we
> > > > > > > > > > > should
> > > > > > > > > > > target
> > > > > > > > > > > with such a spi, you will enforce all other impl
> > > > > > > > > > > to
> > > > > > > > > > > use
> > > > > > > > > > > such
> > > > > > > > > > > a
> > > > > > > > > > > pattern (you cant' just switch with -D easily
> > > > > > > > > > > since
> > > > > > > > > > > adding is
> > > > > > > > > > > easy
> > > > > > > > > > > but dropping system props is almost impossible).
> > > > > > > > > > > A noarg public constructor is trivial and more
> > > > > > > > > > > natural
> > > > > > > > > > > with
> > > > > > > > > > > resources
> > > > > > > > > > > IMHO - but once again tomee can does all the work
> > > > > > > > > > > to
> > > > > > > > > > > makes it
> > > > > > > > > > > equivalent, just requires to duplicate/wrap the
> > > > > > > > > > > impls
> > > > > > > > > > > of
> > > > > > > > > > > the
> > > > > > > > > > > SPI
> > > > > > > > > > > in
> > > > > 

Re: Pending patches

[Francois Papon]

Hi,

I think it's better if you can push a PR via github.

regards,

François
fpa...@apache.org

Le 21/07/2021 à 11:01, Zowalla, Richard a écrit :
> Hi François,
>
> thanks for the update.
>
> Shall I migrate my SVN patch files towards GitHub Pull Requests or is
> the plan to apply them directly?
>
> Gruss
> Richard
>
>
> Am Mittwoch, den 21.07.2021, 10:58 +0200 schrieb Francois Papon:
>> Hi all,
>>
>> This 3 repo has moved successfuly to gitbox:
>>
>>   https://github.com/apache/geronimo-xbean
>>   https://github.com/apache/geronimo-javamail
>>   https://github.com/apache/geronimo-txmanager
>>
>> We can now merge the pending PRs.
>>
>> regards,
>>
>> François
>> fpa...@apache.org
>>
>> Le 08/06/2021 à 14:15, Richard Zowalla a écrit :
>>> Thx for the ticket id !
>>>
>>> Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois Papon:
 Hi,

 Migration is still pending, waiting for infra:

 https://issues.apache.org/jira/browse/INFRA-21908
 

 regards,

 François
 fpa...@apache.org

 Le 08/06/2021 à 13:56, Richard Zowalla a écrit :
> Hi François,
>
> any updates from INFRA on this? Couldnt find the ticket id
> anymore,
> sry.
>
> Gruss
> Richard
>
> Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois
> Papon:
>> Hi,
>>
>> Yes, we plan to do this just after the migration to git ;)
>>
>> regards,
>>
>> François
>> fpa...@apache.org
>>
>> Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :
>>> Hi,
>>>
>>> thanks for your response! I think, that [1] might also
>>> affect
>>> the
>>> hard-
>>> coded TLS1.0 in GERONIMO-6792 [2], so the pending patch
>>> would
>>> be
>>> very
>>> appreciated.
>>>
>>> Maybe after the migration to git? ;)
>>>
>>> Gruss
>>> Richard
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8202343
>>> [2] https://issues.apache.org/jira/browse/GERONIMO-6792
>>>
>>> Am Samstag, den 01.05.2021, 08:20 +0200 schrieb 
>>> fpa...@apache.org:
 Hi,

 I think I can take a look to the Jira and merge the PRs.

 regards,

 François
 fpa...@apache.org

 Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :
> Just to follow up on this thread:
>
> Do we have any plans for moving forward with the mail-
> related
> patches?
> The hard-coded TLS config in mail is a bit "pain" ;)
>
> Gruss
> Richard
>
> Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb Romain
> Manni-
> Bucau:
>> Well it can use a singleton but from a factory
>> method. So
>> immediate
>> solution is to add a public static X getInstance();.
>> But as mentionned it means, to keep the pluggability
>> we
>> should
>> target
>> with such a spi, you will enforce all other impl to
>> use
>> such
>> a
>> pattern (you cant' just switch with -D easily since
>> adding is
>> easy
>> but dropping system props is almost impossible).
>> A noarg public constructor is trivial and more
>> natural
>> with
>> resources
>> IMHO - but once again tomee can does all the work to
>> makes it
>> equivalent, just requires to duplicate/wrap the impls
>> of
>> the
>> SPI
>> in
>> tomee codebase which sounds weird to me ("we have an
>> impl
>> but
>> you
>> need to use another one").
>>
>> On a more personal note I think this pattern is no
>> more
>> relevant
>> and
>> has more pitfalls since you enforce a static instance
>> as
>> soon
>> as
>> the
>> class is loaded whereas it is not needed depending
>> the
>> lifecycle
>> of
>> your main - it is not much but still, I see it as a
>> leak
>> in
>> terms
>> of
>> design (indeed this one is not important and not a
>> blocker
>> but
>> all
>> implies to move to the noarg public constructor on my
>> side).
>> Maybe a habit and personal choice so would be great
>> to
>> have
>> another
>> opinion to move forward :).
>>
>> Le mar. 23 mars 2021 à 08:38, Zowalla, Richard <
>> richard.zowa...@hs-heilbronn.de> a écrit :
>>> Hi,
>>>
>>> I think, it is about the configuration flexibility
>>> in
>>> tomee's
>>>  definitions, which wouldn't allow the
>>> use of
>>> a
>>> singleton
>>> instance. 

[GitHub] [geronimo-xbean] fpapon commented on pull request #20: Add gitignore

[GitBox]

fpapon commented on pull request #20:
URL: https://github.com/apache/geronimo-xbean/pull/20#issuecomment-884052134


   gitignore already present in the repo since svn synchro.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geronimo-xbean] fpapon closed pull request #20: Add gitignore

[GitBox]

fpapon closed pull request #20:
URL: https://github.com/apache/geronimo-xbean/pull/20


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geronimo-xbean] fpapon opened a new pull request #23: Update scm informations after svn to gitbox migration and add readme

[GitBox]

fpapon opened a new pull request #23:
URL: https://github.com/apache/geronimo-xbean/pull/23


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Pending patches

[Francois Papon]

Good point!

I will update the scm section of the pom and ask to pass the the old svn
repo in read only.

François
fpa...@apache.org

Le 21/07/2021 à 11:02, Romain Manni-Bucau a écrit :
> great news!
> did the  section and release plugin was updated to enable releases?
> Also should we pass svn in read only if possible? recall xbean already
> got some weird state where we pushed to both locations
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github
>  | LinkedIn
>  | Book
> 
>
>
> Le mer. 21 juil. 2021 à 11:00, Jean-Baptiste Onofré  > a écrit :
>
> Thanks for the update and taking action !
>
> Regards
> JB
>
> On 7/21/21 10:58 AM, Francois Papon wrote:
> > Hi all,
> >
> > This 3 repo has moved successfuly to gitbox:
> >
> >    https://github.com/apache/geronimo-xbean
> 
> >    https://github.com/apache/geronimo-javamail
> 
> >    https://github.com/apache/geronimo-txmanager
> 
> >
> > We can now merge the pending PRs.
> >
> > regards,
> >
> > François
> > fpa...@apache.org 
> >
> > Le 08/06/2021 à 14:15, Richard Zowalla a écrit :
> >> Thx for the ticket id !
> >>
> >> Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois Papon:
> >>> Hi,
> >>>
> >>> Migration is still pending, waiting for infra:
> >>>
> >>> https://issues.apache.org/jira/browse/INFRA-21908
> 
> >>>  >
> >>>
> >>> regards,
> >>>
> >>> François
> >>> fpa...@apache.org 
> >>>
> >>> Le 08/06/2021 à 13:56, Richard Zowalla a écrit :
>  Hi François,
> 
>  any updates from INFRA on this? Couldnt find the ticket id
> anymore,
>  sry.
> 
>  Gruss
>  Richard
> 
>  Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois Papon:
> > Hi,
> >
> > Yes, we plan to do this just after the migration to git ;)
> >
> > regards,
> >
> > François
> > fpa...@apache.org 
> >
> > Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :
> >> Hi,
> >>
> >> thanks for your response! I think, that [1] might also affect
> >> the
> >> hard-
> >> coded TLS1.0 in GERONIMO-6792 [2], so the pending patch would
> >> be
> >> very
> >> appreciated.
> >>
> >> Maybe after the migration to git? ;)
> >>
> >> Gruss
> >> Richard
> >>
> >> [1] https://bugs.openjdk.java.net/browse/JDK-8202343
> 
> >> [2] https://issues.apache.org/jira/browse/GERONIMO-6792
> 
> >>
> >> Am Samstag, den 01.05.2021, 08:20 +0200 schrieb
> >> fpa...@apache.org :
> >>> Hi,
> >>>
> >>> I think I can take a look to the Jira and merge the PRs.
> >>>
> >>> regards,
> >>>
> >>> François
> >>> fpa...@apache.org 
> >>>
> >>> Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :
>  Just to follow up on this thread:
> 
>  Do we have any plans for moving forward with the mail-
>  related
>  patches?
>  The hard-coded TLS config in mail is a bit "pain" ;)
> 
>  Gruss
>  Richard
> 
>  Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb Romain
>  Manni-
>  Bucau:
> > Well it can use a singleton but from a factory method. So
> > immediate
> > solution is to add a public static X getInstance();.
> > But as mentionned it means, to keep the pluggability we
> > should
> > target
> > with such a spi, you will enforce all other impl to use
> > such
> > a
> > pattern (you cant' just switch with -D easily since
> > adding is
> > easy
> > but dropping system props is almost impossible).
> > A noarg public constructor is trivial and more natural
> > 

Re: Pending patches

[Romain Manni-Bucau]

great news!
did the  section and release plugin was updated to enable releases?
Also should we pass svn in read only if possible? recall xbean already got
some weird state where we pushed to both locations

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mer. 21 juil. 2021 à 11:00, Jean-Baptiste Onofré  a
écrit :

> Thanks for the update and taking action !
>
> Regards
> JB
>
> On 7/21/21 10:58 AM, Francois Papon wrote:
> > Hi all,
> >
> > This 3 repo has moved successfuly to gitbox:
> >
> >https://github.com/apache/geronimo-xbean
> >https://github.com/apache/geronimo-javamail
> >https://github.com/apache/geronimo-txmanager
> >
> > We can now merge the pending PRs.
> >
> > regards,
> >
> > François
> > fpa...@apache.org
> >
> > Le 08/06/2021 à 14:15, Richard Zowalla a écrit :
> >> Thx for the ticket id !
> >>
> >> Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois Papon:
> >>> Hi,
> >>>
> >>> Migration is still pending, waiting for infra:
> >>>
> >>> https://issues.apache.org/jira/browse/INFRA-21908
> >>> 
> >>>
> >>> regards,
> >>>
> >>> François
> >>> fpa...@apache.org
> >>>
> >>> Le 08/06/2021 à 13:56, Richard Zowalla a écrit :
>  Hi François,
> 
>  any updates from INFRA on this? Couldnt find the ticket id anymore,
>  sry.
> 
>  Gruss
>  Richard
> 
>  Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois Papon:
> > Hi,
> >
> > Yes, we plan to do this just after the migration to git ;)
> >
> > regards,
> >
> > François
> > fpa...@apache.org
> >
> > Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :
> >> Hi,
> >>
> >> thanks for your response! I think, that [1] might also affect
> >> the
> >> hard-
> >> coded TLS1.0 in GERONIMO-6792 [2], so the pending patch would
> >> be
> >> very
> >> appreciated.
> >>
> >> Maybe after the migration to git? ;)
> >>
> >> Gruss
> >> Richard
> >>
> >> [1] https://bugs.openjdk.java.net/browse/JDK-8202343
> >> [2] https://issues.apache.org/jira/browse/GERONIMO-6792
> >>
> >> Am Samstag, den 01.05.2021, 08:20 +0200 schrieb
> >> fpa...@apache.org:
> >>> Hi,
> >>>
> >>> I think I can take a look to the Jira and merge the PRs.
> >>>
> >>> regards,
> >>>
> >>> François
> >>> fpa...@apache.org
> >>>
> >>> Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :
>  Just to follow up on this thread:
> 
>  Do we have any plans for moving forward with the mail-
>  related
>  patches?
>  The hard-coded TLS config in mail is a bit "pain" ;)
> 
>  Gruss
>  Richard
> 
>  Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb Romain
>  Manni-
>  Bucau:
> > Well it can use a singleton but from a factory method. So
> > immediate
> > solution is to add a public static X getInstance();.
> > But as mentionned it means, to keep the pluggability we
> > should
> > target
> > with such a spi, you will enforce all other impl to use
> > such
> > a
> > pattern (you cant' just switch with -D easily since
> > adding is
> > easy
> > but dropping system props is almost impossible).
> > A noarg public constructor is trivial and more natural
> > with
> > resources
> > IMHO - but once again tomee can does all the work to
> > makes it
> > equivalent, just requires to duplicate/wrap the impls of
> > the
> > SPI
> > in
> > tomee codebase which sounds weird to me ("we have an impl
> > but
> > you
> > need to use another one").
> >
> > On a more personal note I think this pattern is no more
> > relevant
> > and
> > has more pitfalls since you enforce a static instance as
> > soon
> > as
> > the
> > class is loaded whereas it is not needed depending the
> > lifecycle
> > of
> > your main - it is not much but still, I see it as a leak
> > in
> > terms
> > of
> > design (indeed this one is not important and not a
> > blocker
> > but
> > all
> > implies to move to the noarg public constructor on my
> > side).
> > Maybe a habit and personal choice so would be great to
> > have
> > another
> > opinion to move forward :).
> >
> > Le mar. 23 mars 2021 à 08:38, 

Re: Pending patches

[Zowalla, Richard]

Hi François,

thanks for the update.

Shall I migrate my SVN patch files towards GitHub Pull Requests or is
the plan to apply them directly?

Gruss
Richard


Am Mittwoch, den 21.07.2021, 10:58 +0200 schrieb Francois Papon:
> Hi all,
> 
> This 3 repo has moved successfuly to gitbox:
> 
>   https://github.com/apache/geronimo-xbean
>   https://github.com/apache/geronimo-javamail
>   https://github.com/apache/geronimo-txmanager
> 
> We can now merge the pending PRs.
> 
> regards,
> 
> François
> fpa...@apache.org
> 
> Le 08/06/2021 à 14:15, Richard Zowalla a écrit :
> > Thx for the ticket id !
> > 
> > Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois Papon:
> > > Hi,
> > > 
> > > Migration is still pending, waiting for infra:
> > > 
> > > https://issues.apache.org/jira/browse/INFRA-21908
> > > 
> > > 
> > > regards,
> > > 
> > > François
> > > fpa...@apache.org
> > > 
> > > Le 08/06/2021 à 13:56, Richard Zowalla a écrit :
> > > > Hi François,
> > > > 
> > > > any updates from INFRA on this? Couldnt find the ticket id
> > > > anymore,
> > > > sry.
> > > > 
> > > > Gruss
> > > > Richard
> > > > 
> > > > Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois
> > > > Papon:
> > > > > Hi,
> > > > > 
> > > > > Yes, we plan to do this just after the migration to git ;)
> > > > > 
> > > > > regards,
> > > > > 
> > > > > François
> > > > > fpa...@apache.org
> > > > > 
> > > > > Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :
> > > > > > Hi,
> > > > > > 
> > > > > > thanks for your response! I think, that [1] might also
> > > > > > affect
> > > > > > the
> > > > > > hard-
> > > > > > coded TLS1.0 in GERONIMO-6792 [2], so the pending patch
> > > > > > would
> > > > > > be
> > > > > > very
> > > > > > appreciated.
> > > > > > 
> > > > > > Maybe after the migration to git? ;)
> > > > > > 
> > > > > > Gruss
> > > > > > Richard
> > > > > > 
> > > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8202343
> > > > > > [2] https://issues.apache.org/jira/browse/GERONIMO-6792
> > > > > > 
> > > > > > Am Samstag, den 01.05.2021, 08:20 +0200 schrieb 
> > > > > > fpa...@apache.org:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > I think I can take a look to the Jira and merge the PRs.
> > > > > > > 
> > > > > > > regards,
> > > > > > > 
> > > > > > > François
> > > > > > > fpa...@apache.org
> > > > > > > 
> > > > > > > Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :
> > > > > > > > Just to follow up on this thread:
> > > > > > > > 
> > > > > > > > Do we have any plans for moving forward with the mail-
> > > > > > > > related
> > > > > > > > patches?
> > > > > > > > The hard-coded TLS config in mail is a bit "pain" ;)
> > > > > > > > 
> > > > > > > > Gruss
> > > > > > > > Richard
> > > > > > > > 
> > > > > > > > Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb Romain
> > > > > > > > Manni-
> > > > > > > > Bucau:
> > > > > > > > > Well it can use a singleton but from a factory
> > > > > > > > > method. So
> > > > > > > > > immediate
> > > > > > > > > solution is to add a public static X getInstance();.
> > > > > > > > > But as mentionned it means, to keep the pluggability
> > > > > > > > > we
> > > > > > > > > should
> > > > > > > > > target
> > > > > > > > > with such a spi, you will enforce all other impl to
> > > > > > > > > use
> > > > > > > > > such
> > > > > > > > > a
> > > > > > > > > pattern (you cant' just switch with -D easily since
> > > > > > > > > adding is
> > > > > > > > > easy
> > > > > > > > > but dropping system props is almost impossible).
> > > > > > > > > A noarg public constructor is trivial and more
> > > > > > > > > natural
> > > > > > > > > with
> > > > > > > > > resources
> > > > > > > > > IMHO - but once again tomee can does all the work to
> > > > > > > > > makes it
> > > > > > > > > equivalent, just requires to duplicate/wrap the impls
> > > > > > > > > of
> > > > > > > > > the
> > > > > > > > > SPI
> > > > > > > > > in
> > > > > > > > > tomee codebase which sounds weird to me ("we have an
> > > > > > > > > impl
> > > > > > > > > but
> > > > > > > > > you
> > > > > > > > > need to use another one").
> > > > > > > > > 
> > > > > > > > > On a more personal note I think this pattern is no
> > > > > > > > > more
> > > > > > > > > relevant
> > > > > > > > > and
> > > > > > > > > has more pitfalls since you enforce a static instance
> > > > > > > > > as
> > > > > > > > > soon
> > > > > > > > > as
> > > > > > > > > the
> > > > > > > > > class is loaded whereas it is not needed depending
> > > > > > > > > the
> > > > > > > > > lifecycle
> > > > > > > > > of
> > > > > > > > > your main - it is not much but still, I see it as a
> > > > > > > > > leak
> > > > > > > > > in
> > > > > > > > > terms
> > > > > > > > > of
> > > > > > > > > design (indeed this one is not important and not a
> > > > > > > > > blocker
> > > > > > > > > but
> > > > > > > > > all
> > > > > > > > > implies to move to the noarg public constructor on my
> > > > > > > > > side).
> > 

Re: Pending patches

[Jean-Baptiste Onofré]

Thanks for the update and taking action !

Regards
JB

On 7/21/21 10:58 AM, Francois Papon wrote:

Hi all,

This 3 repo has moved successfuly to gitbox:

   https://github.com/apache/geronimo-xbean
   https://github.com/apache/geronimo-javamail
   https://github.com/apache/geronimo-txmanager

We can now merge the pending PRs.

regards,

François
fpa...@apache.org

Le 08/06/2021 à 14:15, Richard Zowalla a écrit :

Thx for the ticket id !

Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois Papon:

Hi,

Migration is still pending, waiting for infra:

https://issues.apache.org/jira/browse/INFRA-21908


regards,

François
fpa...@apache.org

Le 08/06/2021 à 13:56, Richard Zowalla a écrit :

Hi François,

any updates from INFRA on this? Couldnt find the ticket id anymore,
sry.

Gruss
Richard

Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois Papon:

Hi,

Yes, we plan to do this just after the migration to git ;)

regards,

François
fpa...@apache.org

Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :

Hi,

thanks for your response! I think, that [1] might also affect
the
hard-
coded TLS1.0 in GERONIMO-6792 [2], so the pending patch would
be
very
appreciated.

Maybe after the migration to git? ;)

Gruss
Richard

[1] https://bugs.openjdk.java.net/browse/JDK-8202343
[2] https://issues.apache.org/jira/browse/GERONIMO-6792

Am Samstag, den 01.05.2021, 08:20 +0200 schrieb
fpa...@apache.org:

Hi,

I think I can take a look to the Jira and merge the PRs.

regards,

François
fpa...@apache.org

Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :

Just to follow up on this thread:

Do we have any plans for moving forward with the mail-
related
patches?
The hard-coded TLS config in mail is a bit "pain" ;)

Gruss
Richard

Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb Romain
Manni-
Bucau:

Well it can use a singleton but from a factory method. So
immediate
solution is to add a public static X getInstance();.
But as mentionned it means, to keep the pluggability we
should
target
with such a spi, you will enforce all other impl to use
such
a
pattern (you cant' just switch with -D easily since
adding is
easy
but dropping system props is almost impossible).
A noarg public constructor is trivial and more natural
with
resources
IMHO - but once again tomee can does all the work to
makes it
equivalent, just requires to duplicate/wrap the impls of
the
SPI
in
tomee codebase which sounds weird to me ("we have an impl
but
you
need to use another one").

On a more personal note I think this pattern is no more
relevant
and
has more pitfalls since you enforce a static instance as
soon
as
the
class is loaded whereas it is not needed depending the
lifecycle
of
your main - it is not much but still, I see it as a leak
in
terms
of
design (indeed this one is not important and not a
blocker
but
all
implies to move to the noarg public constructor on my
side).
Maybe a habit and personal choice so would be great to
have
another
opinion to move forward :).

Le mar. 23 mars 2021 à 08:38, Zowalla, Richard <
richard.zowa...@hs-heilbronn.de> a écrit :

Hi,

I think, it is about the configuration flexibility in
tomee's
 definitions, which wouldn't allow the use of
a
singleton
instance. Hence, the consuming project would need to
implement
the
interface to make it possible. But I am not that deep
as
Romain
in
the
TomEE codebase, so it is still a guess from my side.

Gruss
Richard

Am Montag, den 22.03.2021, 23:14 +0100 schrieb Florent
Guillaume:

Hi,

I can drop the private constructor if you want.
I'm surprised it's needed though, as the default
instance
is

already

used by the code if no value is provided for the
timeProvider
parameter of TransactionImpl.

Florent


On Mon, Mar 22, 2021 at 5:49 PM Romain Manni-Bucau <
rmannibu...@gmail.com> wrote:

Hi Richard,

I still think SystemCurrentTime should have a
public
noarg
constructor (or just drop the private one) since it
will
enable
tomee to fully configure dynamically the tx mgr
with
this
new
feature but otherwise +1 to apply them all.

Romain Manni-Bucau
@rmannibucau |  Blog | Old Blog | Github | LinkedIn
|
Book


Le lun. 22 mars 2021 à 17:03, Zowalla, Richard <
richard.zowa...@hs-heilbronn.de> a écrit :

Hi all,

wanted to raise attention on this again. 6792
would
be
very

nice

as we
should allow TLS/SSL protocol versions for a
given
mail

server

instead
of falling back to some hard-coded default.

Gruss
Richard

Am Mittwoch, den 24.02.2021, 09:33 +0100 schrieb
Romain

Manni-

Bucau:

Hi all,

AFAIK we have a few pending patches to
apply/issue
to

close:

- [mail]

https://issues.apache.org/jira/browse/GERONIMO-6792:

update

some defaults and config capacity
- [mail]

https://issues.apache.org/jira/browse/GERONIMO-6801

and

https://issues.apache.org/jira/browse/GERONIMO-6800

(setText)

- [transaction-manager]
https://issues.apache.org/jira/browse/GERONIMO-6805
:
enable

to

change

the time evaluator impl

If someone else can have a 

Re: Pending patches

[Francois Papon]

Hi all,

This 3 repo has moved successfuly to gitbox:

  https://github.com/apache/geronimo-xbean
  https://github.com/apache/geronimo-javamail
  https://github.com/apache/geronimo-txmanager

We can now merge the pending PRs.

regards,

François
fpa...@apache.org

Le 08/06/2021 à 14:15, Richard Zowalla a écrit :
> Thx for the ticket id !
>
> Am Dienstag, den 08.06.2021, 14:07 +0200 schrieb Francois Papon:
>> Hi,
>>
>> Migration is still pending, waiting for infra:
>>
>> https://issues.apache.org/jira/browse/INFRA-21908
>> 
>>
>> regards,
>>
>> François
>> fpa...@apache.org
>>
>> Le 08/06/2021 à 13:56, Richard Zowalla a écrit :
>>> Hi François,
>>>
>>> any updates from INFRA on this? Couldnt find the ticket id anymore,
>>> sry.
>>>
>>> Gruss
>>> Richard
>>>
>>> Am Mittwoch, den 19.05.2021, 09:38 +0200 schrieb Francois Papon:
 Hi,

 Yes, we plan to do this just after the migration to git ;)

 regards,

 François
 fpa...@apache.org

 Le 19/05/2021 à 09:09, Zowalla, Richard a écrit :
> Hi,
>
> thanks for your response! I think, that [1] might also affect
> the
> hard-
> coded TLS1.0 in GERONIMO-6792 [2], so the pending patch would
> be
> very
> appreciated.
>
> Maybe after the migration to git? ;)
>
> Gruss
> Richard
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8202343
> [2] https://issues.apache.org/jira/browse/GERONIMO-6792
>
> Am Samstag, den 01.05.2021, 08:20 +0200 schrieb 
> fpa...@apache.org:
>> Hi,
>>
>> I think I can take a look to the Jira and merge the PRs.
>>
>> regards,
>>
>> François
>> fpa...@apache.org
>>
>> Le 28/04/2021 à 11:09, Zowalla, Richard a écrit :
>>> Just to follow up on this thread:
>>>
>>> Do we have any plans for moving forward with the mail-
>>> related
>>> patches?
>>> The hard-coded TLS config in mail is a bit "pain" ;)
>>>
>>> Gruss
>>> Richard
>>>
>>> Am Dienstag, den 23.03.2021, 08:50 +0100 schrieb Romain
>>> Manni-
>>> Bucau:
 Well it can use a singleton but from a factory method. So
 immediate
 solution is to add a public static X getInstance();.
 But as mentionned it means, to keep the pluggability we
 should
 target
 with such a spi, you will enforce all other impl to use
 such
 a
 pattern (you cant' just switch with -D easily since
 adding is
 easy
 but dropping system props is almost impossible).
 A noarg public constructor is trivial and more natural
 with
 resources
 IMHO - but once again tomee can does all the work to
 makes it
 equivalent, just requires to duplicate/wrap the impls of
 the
 SPI
 in
 tomee codebase which sounds weird to me ("we have an impl
 but
 you
 need to use another one").

 On a more personal note I think this pattern is no more
 relevant
 and
 has more pitfalls since you enforce a static instance as
 soon
 as
 the
 class is loaded whereas it is not needed depending the
 lifecycle
 of
 your main - it is not much but still, I see it as a leak
 in
 terms
 of
 design (indeed this one is not important and not a
 blocker
 but
 all
 implies to move to the noarg public constructor on my
 side).
 Maybe a habit and personal choice so would be great to
 have
 another
 opinion to move forward :).

 Le mar. 23 mars 2021 à 08:38, Zowalla, Richard <
 richard.zowa...@hs-heilbronn.de> a écrit :
> Hi,
>
> I think, it is about the configuration flexibility in
> tomee's
>  definitions, which wouldn't allow the use of
> a
> singleton
> instance. Hence, the consuming project would need to
> implement
> the
> interface to make it possible. But I am not that deep
> as
> Romain
> in
> the
> TomEE codebase, so it is still a guess from my side.
>
> Gruss
> Richard
>
> Am Montag, den 22.03.2021, 23:14 +0100 schrieb Florent
> Guillaume:
>> Hi,
>>
>> I can drop the private constructor if you want.
>> I'm surprised it's needed though, as the default
>> instance
>> is
> already
>> used by the code if no value is provided for the
>> timeProvider
>> parameter of TransactionImpl. 
>>
>> Florent
>>
>>
>> On Mon, Mar 22, 2021 at 5:49 PM Romain Manni-Bucau <
>> rmannibu...@gmail.com> wrote: