Cancel [VOTE] Release Geronimo Tomcat 7.0.39.1 for RAT check issue
On Thu, May 9, 2013 at 1:37 PM, Kevan Miller wrote: > > On May 9, 2013, at 1:17 PM, Alan Cabrera wrote: > > > I got > > > > [ERROR] Failed to execute goal > org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:check (default-cli) on > project tomcat-parent-7.0.39: Too many unapproved licenses: 1 -> [Help 1] > > > > for a mvn rat: check. Do we care? > > Depending on the file(s), we care… > > Here are the files that I see that are flagged by RAT: > > !? ./DEPENDENCIES > !? ./HowTo.txt > N ./LICENSE > N ./NOTICE >./jasper-el/src/main/java/org/apache/el/parser/ELParser.java >./jasper-el/src/main/java/org/apache/el/parser/ELParserConstants.java >./jasper-el/src/main/java/org/apache/el/parser/ELParserTokenManager.java > > ./jasper-el/src/main/java/org/apache/el/parser/ELParserTreeConstants.java >./jasper-el/src/main/java/org/apache/el/parser/JJTELParserState.java >./jasper-el/src/main/java/org/apache/el/parser/Node.java >./jasper-el/src/main/java/org/apache/el/parser/ParseException.java >./jasper-el/src/main/java/org/apache/el/parser/SimpleCharStream.java >./jasper-el/src/main/java/org/apache/el/parser/Token.java >./jasper-el/src/main/java/org/apache/el/parser/TokenMgrError.java > > The jasper-el files are all machine generated. Here's a sample header: > > /* Generated By:JavaCC: Do not edit this line. TokenMgrError.java Version > 5.0 */ > /* JavaCCOptions: */ > package org.apache.el.parser; > > So, these look fine to me. LICENSE/NOTICE/DEPENDENCIES are not an issue. > > HowTo.txt should have a src license header. Once that's fixed I should be > +1... > > --kevan -- Thanks! Regards, Forrest
Re: [VOTE] Release Geronimo Tomcat 7.0.39.1
On May 9, 2013, at 1:17 PM, Alan Cabrera wrote: > I got > > [ERROR] Failed to execute goal > org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:check (default-cli) on project > tomcat-parent-7.0.39: Too many unapproved licenses: 1 -> [Help 1] > > for a mvn rat: check. Do we care? Depending on the file(s), we care… Here are the files that I see that are flagged by RAT: !? ./DEPENDENCIES !? ./HowTo.txt N ./LICENSE N ./NOTICE ./jasper-el/src/main/java/org/apache/el/parser/ELParser.java ./jasper-el/src/main/java/org/apache/el/parser/ELParserConstants.java ./jasper-el/src/main/java/org/apache/el/parser/ELParserTokenManager.java ./jasper-el/src/main/java/org/apache/el/parser/ELParserTreeConstants.java ./jasper-el/src/main/java/org/apache/el/parser/JJTELParserState.java ./jasper-el/src/main/java/org/apache/el/parser/Node.java ./jasper-el/src/main/java/org/apache/el/parser/ParseException.java ./jasper-el/src/main/java/org/apache/el/parser/SimpleCharStream.java ./jasper-el/src/main/java/org/apache/el/parser/Token.java ./jasper-el/src/main/java/org/apache/el/parser/TokenMgrError.java The jasper-el files are all machine generated. Here's a sample header: /* Generated By:JavaCC: Do not edit this line. TokenMgrError.java Version 5.0 */ /* JavaCCOptions: */ package org.apache.el.parser; So, these look fine to me. LICENSE/NOTICE/DEPENDENCIES are not an issue. HowTo.txt should have a src license header. Once that's fixed I should be +1... --kevan
Re: [VOTE] Release Geronimo Tomcat 7.0.39.1
I got [ERROR] Failed to execute goal org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:check (default-cli) on project tomcat-parent-7.0.39: Too many unapproved licenses: 1 -> [Help 1] for a mvn rat: check. Do we care? Regards, Alan On May 9, 2013, at 9:15 AM, Forrest Xia wrote: > Hi, > > Please vote for the Geronimo Tomcat 7.0.39.1 release, which is based on > Tomcat 7.0.39 tag. > > The components up for vote are: > https://repository.apache.org/content/repositories/orgapachegeronimo-026/org/apache/geronimo/ext/tomcat/tomcat-parent-7.0.39/7.0.39.1/tomcat-parent-7.0.39-7.0.39.1-source-release.zip > > > Staging repo is here: > https://repository.apache.org/content/repositories/orgapachegeronimo-026 > > tag is here: > https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.39.1 > > > Vote open 72 hours > > [ ] +1 release this > [ ] 0 don't care > [ ] -1 don't release this (please explain) > > -- > Thanks! > > Regards, Forrest
Re: [VOTE] Release Geronimo Tomcat 7.0.39.1
+1 - looks good to me. Thanks! Jarek On Thu, May 9, 2013 at 12:15 PM, Forrest Xia wrote: > Hi, > > Please vote for the Geronimo Tomcat 7.0.39.1 release, which is based on > Tomcat 7.0.39 tag. > > The components up for vote are: > https://repository.apache.org/content/repositories/orgapachegeronimo-026/org/apache/geronimo/ext/tomcat/tomcat-parent-7.0.39/7.0.39.1/tomcat-parent-7.0.39-7.0.39.1-source-release.zip > > > Staging repo is here: > https://repository.apache.org/content/repositories/orgapachegeronimo-026 > > tag is here: > https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.39.1 > > > Vote open 72 hours > > [ ] +1 release this > [ ] 0 don't care > [ ] -1 don't release this (please explain) > > -- > Thanks! > > Regards, Forrest
Re: [VOTE] Release Geronimo Tomcat 7.0.39.1
+1 On Fri, May 10, 2013 at 12:15 AM, Forrest Xia wrote: > Hi, > > Please vote for the Geronimo Tomcat 7.0.39.1 release, which is based on > Tomcat 7.0.39 tag. > > The components up for vote are: > > https://repository.apache.org/content/repositories/orgapachegeronimo-026/org/apache/geronimo/ext/tomcat/tomcat-parent-7.0.39/7.0.39.1/tomcat-parent-7.0.39-7.0.39.1-source-release.zip > > > Staging repo is here: > https://repository.apache.org/content/repositories/orgapachegeronimo-026 > > tag is here: > > https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.39.1 > > > Vote open 72 hours > > [ ] +1 release this > [ ] 0 don't care > [ ] -1 don't release this (please explain) > > -- > Thanks! > > Regards, Forrest > -- Shawn
Re: [VOTE] Release Geronimo Tomcat 7.0.39.1
+1 myself On Thu, May 9, 2013 at 12:15 PM, Forrest Xia wrote: > Hi, > > Please vote for the Geronimo Tomcat 7.0.39.1 release, which is based on > Tomcat 7.0.39 tag. > > The components up for vote are: > > https://repository.apache.org/content/repositories/orgapachegeronimo-026/org/apache/geronimo/ext/tomcat/tomcat-parent-7.0.39/7.0.39.1/tomcat-parent-7.0.39-7.0.39.1-source-release.zip > > > Staging repo is here: > https://repository.apache.org/content/repositories/orgapachegeronimo-026 > > tag is here: > > https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.39.1 > > > Vote open 72 hours > > [ ] +1 release this > [ ] 0 don't care > [ ] -1 don't release this (please explain) > > -- > Thanks! > > Regards, Forrest > -- Thanks! Regards, Forrest
[VOTE] Release Geronimo Tomcat 7.0.39.1
Hi, Please vote for the Geronimo Tomcat 7.0.39.1 release, which is based on Tomcat 7.0.39 tag. The components up for vote are: https://repository.apache.org/content/repositories/orgapachegeronimo-026/org/apache/geronimo/ext/tomcat/tomcat-parent-7.0.39/7.0.39.1/tomcat-parent-7.0.39-7.0.39.1-source-release.zip Staging repo is here: https://repository.apache.org/content/repositories/orgapachegeronimo-026 tag is here: https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.39.1 Vote open 72 hours [ ] +1 release this [ ] 0 don't care [ ] -1 don't release this (please explain) -- Thanks! Regards, Forrest
