Re: Please revert 219816 assembly/maven.xml change

2005-07-27 Thread David Jencks
I certainly have no problem with getting all the schemas into the 
output schema directory.  I don't remember too clearly but I think I 
commented that out because it was causing an error.  All the schemas 
should be present in the builder jar files now, so I will look for a 
more uniform way of extracting all of them.  It may be tomorrow before 
I can look at this, I hope that is not a problem.


thanks
david jencks

On Jul 27, 2005, at 6:04 PM, Aaron Mulder wrote:


Please revert the change to modules/assembly/maven.xml in HEAD
from revision 219816.  I don't know if there's a polite way to present
this, but I am -1 on this change as it results in the openejb schemas 
not

being present in the output schema/ directory.  The change was made by
djencks with the comment dependency cleanup.  I don't want to just 
do
it and start a back and forth war without making sure you don't have 
some

overriding concern.

http://svn.apache.org/viewcvs.cgi?rev=219816view=rev

Thanks,
Aaron





Re: Please revert 219816 assembly/maven.xml change

2005-07-27 Thread Aaron Mulder
The only case I'm aware of where it caused an error was if you 
didn't do an uberbuild (because at the time the latest published OpenEJB 
JARs didn't have the schemas included).  Anyway, it's not urgent, but I 
don't want to forget either.  Our schema directory tends to steadily 
depopulate itself over time.  :)

Thanks,
Aaron

On Wed, 27 Jul 2005, David Jencks wrote:
 I certainly have no problem with getting all the schemas into the 
 output schema directory.  I don't remember too clearly but I think I 
 commented that out because it was causing an error.  All the schemas 
 should be present in the builder jar files now, so I will look for a 
 more uniform way of extracting all of them.  It may be tomorrow before 
 I can look at this, I hope that is not a problem.
 
 thanks
 david jencks
 
 On Jul 27, 2005, at 6:04 PM, Aaron Mulder wrote:
 
  Please revert the change to modules/assembly/maven.xml in HEAD
  from revision 219816.  I don't know if there's a polite way to present
  this, but I am -1 on this change as it results in the openejb schemas 
  not
  being present in the output schema/ directory.  The change was made by
  djencks with the comment dependency cleanup.  I don't want to just 
  do
  it and start a back and forth war without making sure you don't have 
  some
  overriding concern.
 
  http://svn.apache.org/viewcvs.cgi?rev=219816view=rev
 
  Thanks,
  Aaron