Re: progress bar at Geronimo startup

2008-01-22 Thread Jarek Gawor 
Thanks! I added the breaks but stayed with .equals() to be on the safe side.

Jarek

On Jan 17, 2008 5:45 AM, Alexey Petrenko [EMAIL PROTECTED] wrote:
 Hi, Jarek.

 Just few comments about the patch...
 As far as understand each module appears only once in modules array.
 And the objects there are the same with coming to moduleLoading,
 moduleLoaded, moduleStarting and moduleStarted methods.

 If I'm correct here then I suggest to change the following statements
 a little...
 === original ===
 for (int i = 0; i  modules.length; i++) {
 if (modules[i].equals(module)) {
 moduleStatus[i] = STATUS_LOADED;
 }
 }
 === original ===

 === suggested ===
 for (int i = 0; i  modules.length; i++) {
 if (modules[i] == module) {
 moduleStatus[i] = STATUS_LOADED;
 break;
 }
 }
 === suggested ===

 Not very significant change but will boost startup performance a
 little (probably very little :) for big list of modules.

 SY, Alexey

 2008/1/16, Jarek Gawor [EMAIL PROTECTED]:

  Folks,
 
  A few times before I've ran into some problems with the progress bar
  displayed at Geronimo startup as I had a lot of modules installed. I
  described the problem in
  https://issues.apache.org/jira/browse/GERONIMO-3725.  I also just
  attached to the bug report a patch with a new and simpler progress bar
  hat does not suffer from the same problem as the existing bar but at
  the same time it does not it display the same detail info as the
  existing bar. I tired to explain this difference in the bug report.
 
  So, any thoughts/objections on replacing the existing progress bar
  with the one I attached to the bug report?
 
  Thanks,
  Jarek

Re: progress bar at Geronimo startup

2008-01-17 Thread Alexey Petrenko 
Hi, Jarek.

Just few comments about the patch...
As far as understand each module appears only once in modules array.
And the objects there are the same with coming to moduleLoading,
moduleLoaded, moduleStarting and moduleStarted methods.

If I'm correct here then I suggest to change the following statements
a little...
=== original ===
for (int i = 0; i  modules.length; i++) {
if (modules[i].equals(module)) {
moduleStatus[i] = STATUS_LOADED;
}
}
=== original ===

=== suggested ===
for (int i = 0; i  modules.length; i++) {
if (modules[i] == module) {
moduleStatus[i] = STATUS_LOADED;
break;
}
}
=== suggested ===

Not very significant change but will boost startup performance a
little (probably very little :) for big list of modules.

SY, Alexey

2008/1/16, Jarek Gawor [EMAIL PROTECTED]:
 Folks,

 A few times before I've ran into some problems with the progress bar
 displayed at Geronimo startup as I had a lot of modules installed. I
 described the problem in
 https://issues.apache.org/jira/browse/GERONIMO-3725.  I also just
 attached to the bug report a patch with a new and simpler progress bar
 hat does not suffer from the same problem as the existing bar but at
 the same time it does not it display the same detail info as the
 existing bar. I tired to explain this difference in the bug report.

 So, any thoughts/objections on replacing the existing progress bar
 with the one I attached to the bug report?

 Thanks,
 Jarek