[jira] [Commented] (GOBBLIN-707) combine & standardize all gobblin scripts into one master script & restructure configs accordingly
[
https://issues.apache.org/jira/browse/GOBBLIN-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840878#comment-16840878
]
Jay Sen commented on GOBBLIN-707:
-
Hi [~ibuenros], can you pls take a look, and I will push the commit. Thanks. If
it helps, Can we meet online and figure this out to expedite ?
> combine & standardize all gobblin scripts into one master script &
> restructure configs accordingly
> --
>
> Key: GOBBLIN-707
> URL: https://issues.apache.org/jira/browse/GOBBLIN-707
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Jay Sen
>Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> gobblin supports multiple modes of executions ( CLI, Standalone,
> cluster-master, cluster-worker, AWS, YARN, MR ) and various command lines
> utility to run cli and admin commands. There is a individual script for each
> of them.
> Having individual script introduces lot of issues
> # all scripts handles gobblin variables, user parameters differently, and
> its highly inconsistent among various different gobblin scripts
> # functionality around start, stop, status checking and handling PID's among
> lot of other things, varies vastly as per the implementation of the script.
> # features like GC & JVM params, log4j file selection, classpath
> calculation, etc... exists in some gobblin scripts but not all, adding to
> inconsistent user experience.
> # maintaining total 13 script would be too much effort.
> Also all the gobblin scripts share lot of common code to handle params,
> start, stop services, status checks, pid handling, etc... combining all the
> scripts into 1 not only makes maintenance easier but also brings clarity and
> consistency.
>
> Solution:
> 1. there can be one gobblin.sh script to handle all gobblin commands and
> deployment options as per following signature. NOTE: This
> {{gobblin.sh }}
> {{gobblin.sh }}
> {{commands values: admin, cli, statestore-check, statestore-clean,
> historystore-manager, classpath}}
> {{service values: standalone, cluster-master, cluster-worker, aws, yarn, mr,
> service}}
> with above change, following becomes valid command.
> {code:java}
> # all under GobblinCli class
> gobblin run listQuickApps –> gobblin cli run listQuickApps
> gobblin run listQuickApps –> gobblin cli run listQuickApps
> gobblin run -> gobblin cli run
> # class: JobStateToJsonConverter
> statestore-checker.sh -> gobblin statestore-checker
> # class: StateStoreCleaner
> statestore-clean.sh -> gobblin statestore-clean
> # class: DatabaseJobHistoryStoreSchemaManager
> historystore-manager.sh -> gobblin historystore-manager
> # class: Cli
> gobblin-admin.sh-> gobblin admin
> # all gobblin deployment modes
> gobblin-cluster-master.sh -> gobblin cluster-mater start|stop|status
> gobblin-cluster-worker.sh -> gobblin cluster-mater start|stop|status
> gobblin-compaction.sh -> gobblin cluster-mater start|stop|status
> gobblin-env.sh -> gobblin cluster-mater start|stop|status
> gobblin-mapreduce.sh-> gobblin cluster-mater start|stop|status
> gobblin-service.sh -> gobblin cluster-mater start|stop|status
> gobblin-standalone.sh -> gobblin cluster-mater start|stop|status
> gobblin-yarn.sh -> gobblin cluster-mater start|stop|status
> {code}
>
> 2. Also configs needs to be structured and deduped accordingly to make it
> clear on which config will be picked up for which execution mode.
> {color:#ff}
> NOTE: this refactoring adds all cli and service commands to gobblin.sh and
> hence changes the syntax for all commands and services.{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242952=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242952 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 15/May/19 23:13 Start Date: 15/May/19 23:13 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on pull request #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284486925 ## File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/JobEvent.java ## @@ -31,6 +31,7 @@ public static final String LOCK_IN_USE = "LockInUse"; public static final String WORK_UNITS_MISSING = "WorkUnitsMissing"; public static final String WORK_UNITS_EMPTY = "WorkUnitsEmpty"; + public static final String WORK_UNITS_CREATED = "WorkUnitsCreated"; Review comment: seems like these event name constants are scattered between `JobEvents` class and `EventNames` enum. should we combine them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 242952) Time Spent: 0.5h (was: 20m) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-768) Add MySQL implementation of SpecStore
[ https://issues.apache.org/jira/browse/GOBBLIN-768?focusedWorklogId=242956=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242956 ] ASF GitHub Bot logged work on GOBBLIN-768: -- Author: ASF GitHub Bot Created on: 15/May/19 23:21 Start Date: 15/May/19 23:21 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on issue #2631: [GOBBLIN-768] Add MySQL implementation of SpecStore URL: https://github.com/apache/incubator-gobblin/pull/2631#issuecomment-492859328 LGTM, Thanks @jack-moseley taking up the change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 242956) Time Spent: 3h 20m (was: 3h 10m) > Add MySQL implementation of SpecStore > - > > Key: GOBBLIN-768 > URL: https://issues.apache.org/jira/browse/GOBBLIN-768 > Project: Apache Gobblin > Issue Type: New Feature >Reporter: Jack Moseley >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2631: [GOBBLIN-768] Add MySQL implementation of SpecStore
jhsenjaliya commented on issue #2631: [GOBBLIN-768] Add MySQL implementation of SpecStore URL: https://github.com/apache/incubator-gobblin/pull/2631#issuecomment-492859328 LGTM, Thanks @jack-moseley taking up the change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242955=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242955 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 15/May/19 23:18 Start Date: 15/May/19 23:18 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on pull request #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284486925 ## File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/JobEvent.java ## @@ -31,6 +31,7 @@ public static final String LOCK_IN_USE = "LockInUse"; public static final String WORK_UNITS_MISSING = "WorkUnitsMissing"; public static final String WORK_UNITS_EMPTY = "WorkUnitsEmpty"; + public static final String WORK_UNITS_CREATED = "WorkUnitsCreated"; Review comment: optional: seems like these event name constants are scattered between `JobEvents` class and `EventNames` enum. should we combine them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 242955) Time Spent: 1h (was: 50m) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[
https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242954=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242954
]
ASF GitHub Bot logged work on GOBBLIN-766:
--
Author: ASF GitHub Bot
Created on: 15/May/19 23:18
Start Date: 15/May/19 23:18
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #2636:
[GOBBLIN-766] Emit Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284487478
##
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##
@@ -377,6 +378,13 @@ public void apply(JobListener jobListener, JobContext
jobContext)
jobState.setState(JobState.RunningState.COMMITTED);
isWorkUnitsEmpty = true;
return;
+} else {
Review comment:
optional: how about reporting `workUnitsCreated=0` when there is no
workUnits instead of reporting `WorkUnitsEmpty` event?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 242954)
Time Spent: 50m (was: 40m)
> Emit Workunits created event in Apache gobblin
> -
>
> Key: GOBBLIN-766
> URL: https://issues.apache.org/jira/browse/GOBBLIN-766
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: kraman
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Emit a new workunits created metric to be captured for monitoring/Alerting
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2636: [GOBBLIN-766] Emit Workunits Created event
jhsenjaliya commented on a change in pull request #2636: [GOBBLIN-766] Emit
Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284487478
##
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##
@@ -377,6 +378,13 @@ public void apply(JobListener jobListener, JobContext
jobContext)
jobState.setState(JobState.RunningState.COMMITTED);
isWorkUnitsEmpty = true;
return;
+} else {
Review comment:
optional: how about reporting `workUnitsCreated=0` when there is no
workUnits instead of reporting `WorkUnitsEmpty` event?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[
https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242953=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242953
]
ASF GitHub Bot logged work on GOBBLIN-766:
--
Author: ASF GitHub Bot
Created on: 15/May/19 23:15
Start Date: 15/May/19 23:15
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #2636:
[GOBBLIN-766] Emit Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284487478
##
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##
@@ -377,6 +378,13 @@ public void apply(JobListener jobListener, JobContext
jobContext)
jobState.setState(JobState.RunningState.COMMITTED);
isWorkUnitsEmpty = true;
return;
+} else {
Review comment:
how about reporting `workUnitsCreated=0` when there is no workUnits instead
of reporting `WorkUnitsEmpty` event?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 242953)
Time Spent: 40m (was: 0.5h)
> Emit Workunits created event in Apache gobblin
> -
>
> Key: GOBBLIN-766
> URL: https://issues.apache.org/jira/browse/GOBBLIN-766
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: kraman
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Emit a new workunits created metric to be captured for monitoring/Alerting
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2636: [GOBBLIN-766] Emit Workunits Created event
jhsenjaliya commented on a change in pull request #2636: [GOBBLIN-766] Emit
Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284487478
##
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##
@@ -377,6 +378,13 @@ public void apply(JobListener jobListener, JobContext
jobContext)
jobState.setState(JobState.RunningState.COMMITTED);
isWorkUnitsEmpty = true;
return;
+} else {
Review comment:
how about reporting `workUnitsCreated=0` when there is no workUnits instead
of reporting `WorkUnitsEmpty` event?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2636: [GOBBLIN-766] Emit Workunits Created event
jhsenjaliya commented on a change in pull request #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284486925 ## File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/JobEvent.java ## @@ -31,6 +31,7 @@ public static final String LOCK_IN_USE = "LockInUse"; public static final String WORK_UNITS_MISSING = "WorkUnitsMissing"; public static final String WORK_UNITS_EMPTY = "WorkUnitsEmpty"; + public static final String WORK_UNITS_CREATED = "WorkUnitsCreated"; Review comment: seems like these event name constants are scattered between `JobEvents` class and `EventNames` enum. should we combine them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242943=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242943 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 15/May/19 23:06 Start Date: 15/May/19 23:06 Worklog Time Spent: 10m Work Description: krishh85 commented on issue #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#issuecomment-492856313 @htran1 @yukuai518 Can you please review this PL. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 242943) Time Spent: 20m (was: 10m) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [incubator-gobblin] krishh85 commented on issue #2636: [GOBBLIN-766] Emit Workunits Created event
krishh85 commented on issue #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#issuecomment-492856313 @htran1 @yukuai518 Can you please review this PL. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-770) Add JVM configuration to avoid exhausting YARN container memory
[ https://issues.apache.org/jira/browse/GOBBLIN-770?focusedWorklogId=242856=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242856 ] ASF GitHub Bot logged work on GOBBLIN-770: -- Author: ASF GitHub Bot Created on: 15/May/19 21:09 Start Date: 15/May/19 21:09 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2634: [GOBBLIN-770] Add JVM configuration to avoid exhausting YARN containe… URL: https://github.com/apache/incubator-gobblin/pull/2634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 242856) Time Spent: 20m (was: 10m) > Add JVM configuration to avoid exhausting YARN container memory > > > Key: GOBBLIN-770 > URL: https://issues.apache.org/jira/browse/GOBBLIN-770 > Project: Apache Gobblin > Issue Type: Task >Reporter: Hung Tran >Assignee: Hung Tran >Priority: Major > Fix For: 0.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The current code sets Xmx to the value of the YARN container memory limit. > The JVM is highly likely to hit the container memory limit with this > configuration due to overhead costs that are not in the JVM heap. > Configuration should be added to set JVM memory as a percentage of the > container memory minus a configurable overhead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GOBBLIN-770) Add JVM configuration to avoid exhausting YARN container memory
[ https://issues.apache.org/jira/browse/GOBBLIN-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hung Tran resolved GOBBLIN-770. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request #2634 [https://github.com/apache/incubator-gobblin/pull/2634] > Add JVM configuration to avoid exhausting YARN container memory > > > Key: GOBBLIN-770 > URL: https://issues.apache.org/jira/browse/GOBBLIN-770 > Project: Apache Gobblin > Issue Type: Task >Reporter: Hung Tran >Assignee: Hung Tran >Priority: Major > Fix For: 0.15.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The current code sets Xmx to the value of the YARN container memory limit. > The JVM is highly likely to hit the container memory limit with this > configuration due to overhead costs that are not in the JVM heap. > Configuration should be added to set JVM memory as a percentage of the > container memory minus a configurable overhead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [incubator-gobblin] asfgit closed pull request #2634: [GOBBLIN-770] Add JVM configuration to avoid exhausting YARN containe…
asfgit closed pull request #2634: [GOBBLIN-770] Add JVM configuration to avoid exhausting YARN containe… URL: https://github.com/apache/incubator-gobblin/pull/2634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[
https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242642=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242642
]
ASF GitHub Bot logged work on GOBBLIN-766:
--
Author: ASF GitHub Bot
Created on: 15/May/19 16:32
Start Date: 15/May/19 16:32
Worklog Time Spent: 10m
Work Description: krishraman commented on pull request #2636:
[GOBBLIN-766] Emit Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit test cases added.
tested new created event log messages in Yugioh cluster.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 242642)
Time Spent: 10m
Remaining Estimate: 0h
> Emit Workunits created event in Apache gobblin
> -
>
> Key: GOBBLIN-766
> URL: https://issues.apache.org/jira/browse/GOBBLIN-766
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: kraman
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Emit a new workunits created metric to be captured for monitoring/Alerting
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [incubator-gobblin] krishraman opened a new pull request #2636: [GOBBLIN-766] Emit Workunits Created event
krishraman opened a new pull request #2636: [GOBBLIN-766] Emit Workunits
Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit test cases added.
tested new created event log messages in Yugioh cluster.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
