[jira] [Work logged] (GOBBLIN-1207) Clear references to large objects in Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter
[ https://issues.apache.org/jira/browse/GOBBLIN-1207?focusedWorklogId=453165=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453165 ] ASF GitHub Bot logged work on GOBBLIN-1207: --- Author: ASF GitHub Bot Created on: 30/Jun/20 23:45 Start Date: 30/Jun/20 23:45 Worklog Time Spent: 10m Work Description: asfgit closed pull request #3052: URL: https://github.com/apache/incubator-gobblin/pull/3052 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 453165) Time Spent: 40m (was: 0.5h) > Clear references to large objects in Fork, FileBasedExtractor, and > HiveWritableHdfsDataWriter > - > > Key: GOBBLIN-1207 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1207 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: Hung Tran >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter objects contain > references to objects that can be large, such as ORC reader and writer > buffers. Clear these references to allow the memory to be reclaimed during > the job execution. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GOBBLIN-1207) Clear references to large objects in Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter
[ https://issues.apache.org/jira/browse/GOBBLIN-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hung Tran resolved GOBBLIN-1207. Fix Version/s: 0.15.0 Resolution: Fixed Issue resolved by pull request #3052 [https://github.com/apache/incubator-gobblin/pull/3052] > Clear references to large objects in Fork, FileBasedExtractor, and > HiveWritableHdfsDataWriter > - > > Key: GOBBLIN-1207 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1207 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: Hung Tran >Priority: Major > Fix For: 0.15.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter objects contain > references to objects that can be large, such as ORC reader and writer > buffers. Clear these references to allow the memory to be reclaimed during > the job execution. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-gobblin] asfgit closed pull request #3052: [GOBBLIN-1207] Clear references to potentially large objects in Fork,…
asfgit closed pull request #3052: URL: https://github.com/apache/incubator-gobblin/pull/3052 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (GOBBLIN-1208) Fix - restApiRetryLimit cannot be set to 0
[
https://issues.apache.org/jira/browse/GOBBLIN-1208?focusedWorklogId=453140=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453140
]
ASF GitHub Bot logged work on GOBBLIN-1208:
---
Author: ASF GitHub Bot
Created on: 30/Jun/20 22:13
Start Date: 30/Jun/20 22:13
Worklog Time Spent: 10m
Work Description: asfgit closed pull request #3053:
URL: https://github.com/apache/incubator-gobblin/pull/3053
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 453140)
Time Spent: 20m (was: 10m)
> Fix - restApiRetryLimit cannot be set to 0
> --
>
> Key: GOBBLIN-1208
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1208
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Alex Li
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Fix - restApiRetryLimit cannot be set to 0
> if we set restApiRetryLimit=0, the code should be execute 1 time.
> change code:
> {code:java}
> private JsonArray getRecordsForQuery(SalesforceConnector connector, String
> query) {
> RestApiProcessingException exception = null;
> for (int i = 0; i < workUnitConf.restApiRetryLimit; i++) {
> {code}
> to
> {code:java}
> private JsonArray getRecordsForQuery(SalesforceConnector connector, String
> query) {
> RestApiProcessingException exception = null;
> for (int i = 0; i < workUnitConf.restApiRetryLimit+1; i++) {
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [incubator-gobblin] asfgit closed pull request #3053: GOBBLIN-1208 & DSS-27156: Fix - restApiRetryLimit cannot be set to 0
asfgit closed pull request #3053: URL: https://github.com/apache/incubator-gobblin/pull/3053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #3052: [GOBBLIN-1207] Clear references to potentially large objects in Fork,…
htran1 commented on a change in pull request #3052:
URL: https://github.com/apache/incubator-gobblin/pull/3052#discussion_r447976480
##
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/fork/ForkTest.java
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.fork;
+
+import java.io.IOException;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.runtime.ExecutionModel;
+import org.apache.gobblin.runtime.TaskContext;
+import org.apache.gobblin.writer.DataWriter;
+import org.apache.gobblin.writer.DataWriterBuilder;
+import org.apache.gobblin.writer.RetryWriter;
+import org.junit.Assert;
+import org.testng.annotations.DataProvider;
+import org.testng.annotations.Test;
+
+
+public class ForkTest {
Review comment:
Fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (GOBBLIN-1207) Clear references to large objects in Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter
[
https://issues.apache.org/jira/browse/GOBBLIN-1207?focusedWorklogId=453109=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453109
]
ASF GitHub Bot logged work on GOBBLIN-1207:
---
Author: ASF GitHub Bot
Created on: 30/Jun/20 21:01
Start Date: 30/Jun/20 21:01
Worklog Time Spent: 10m
Work Description: htran1 commented on a change in pull request #3052:
URL: https://github.com/apache/incubator-gobblin/pull/3052#discussion_r447976480
##
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/fork/ForkTest.java
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.fork;
+
+import java.io.IOException;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.runtime.ExecutionModel;
+import org.apache.gobblin.runtime.TaskContext;
+import org.apache.gobblin.writer.DataWriter;
+import org.apache.gobblin.writer.DataWriterBuilder;
+import org.apache.gobblin.writer.RetryWriter;
+import org.junit.Assert;
+import org.testng.annotations.DataProvider;
+import org.testng.annotations.Test;
+
+
+public class ForkTest {
Review comment:
Fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 453109)
Time Spent: 0.5h (was: 20m)
> Clear references to large objects in Fork, FileBasedExtractor, and
> HiveWritableHdfsDataWriter
> -
>
> Key: GOBBLIN-1207
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1207
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Hung Tran
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter objects contain
> references to objects that can be large, such as ORC reader and writer
> buffers. Clear these references to allow the memory to be reclaimed during
> the job execution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3052: [GOBBLIN-1207] Clear references to potentially large objects in Fork,…
autumnust commented on a change in pull request #3052:
URL: https://github.com/apache/incubator-gobblin/pull/3052#discussion_r447928386
##
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/fork/ForkTest.java
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.fork;
+
+import java.io.IOException;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.runtime.ExecutionModel;
+import org.apache.gobblin.runtime.TaskContext;
+import org.apache.gobblin.writer.DataWriter;
+import org.apache.gobblin.writer.DataWriterBuilder;
+import org.apache.gobblin.writer.RetryWriter;
+import org.junit.Assert;
+import org.testng.annotations.DataProvider;
+import org.testng.annotations.Test;
+
+
+public class ForkTest {
Review comment:
The intention in this file doesn't seem to be right. Can you fix it ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (GOBBLIN-1207) Clear references to large objects in Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter
[
https://issues.apache.org/jira/browse/GOBBLIN-1207?focusedWorklogId=453107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453107
]
ASF GitHub Bot logged work on GOBBLIN-1207:
---
Author: ASF GitHub Bot
Created on: 30/Jun/20 20:55
Start Date: 30/Jun/20 20:55
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3052:
URL: https://github.com/apache/incubator-gobblin/pull/3052#discussion_r447928386
##
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/fork/ForkTest.java
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.fork;
+
+import java.io.IOException;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.runtime.ExecutionModel;
+import org.apache.gobblin.runtime.TaskContext;
+import org.apache.gobblin.writer.DataWriter;
+import org.apache.gobblin.writer.DataWriterBuilder;
+import org.apache.gobblin.writer.RetryWriter;
+import org.junit.Assert;
+import org.testng.annotations.DataProvider;
+import org.testng.annotations.Test;
+
+
+public class ForkTest {
Review comment:
The intention in this file doesn't seem to be right. Can you fix it ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 453107)
Time Spent: 20m (was: 10m)
> Clear references to large objects in Fork, FileBasedExtractor, and
> HiveWritableHdfsDataWriter
> -
>
> Key: GOBBLIN-1207
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1207
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Hung Tran
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter objects contain
> references to objects that can be large, such as ORC reader and writer
> buffers. Clear these references to allow the memory to be reclaimed during
> the job execution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
