[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=389516=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389516 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 19/Feb/20 17:40 Start Date: 19/Feb/20 17:40 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389516) Time Spent: 2h 10m (was: 2h) > Emit helix leader metrics to ingraph > - > > Key: GOBBLIN-1051 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1051 > Project: Apache Gobblin > Issue Type: Task >Reporter: Wei-Hsiang Lin >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=389278=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389278 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 19/Feb/20 02:31 Start Date: 19/Feb/20 02:31 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#issuecomment-586523868 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=h1) Report > Merging [#2891](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0b059870755bbab93f11d1cf620862e7502b2d4c?src=pr=desc) will **increase** coverage by `1.05%`. > The diff coverage is `79.16%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2891 +/- ## + Coverage 44.78% 45.83% +1.05% - Complexity 8958 9151 +193 Files 1926 1929 +3 Lines 7255572649 +94 Branches 7992 7999 +7 + Hits 3249133296 +805 + Misses3707336314 -759 - Partials 2991 3039 +48 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/gobblin/metrics/ServiceMetricNames.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvU2VydmljZU1ldHJpY05hbWVzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh) | `56.74% <79.16%> (+2.03%)` | `25 <0> (ø)` | :arrow_down: | | [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `36.28% <0%> (-2.97%)` | `13% <0%> (ø)` | | | [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | | | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | | | [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | | | [...rg/apache/gobblin/publisher/BaseDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9CYXNlRGF0YVB1Ymxpc2hlci5qYXZh) | `67.74% <0%> (-0.31%)` | `61% <0%> (-1%)` | | | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `64.62% <0%> (-0.29%)` | `28% <0%> (-1%)` | | | [...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==) | `18.8% <0%> (-0.06%)` | `15% <0%> (ø)` | | |
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[
https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=389268=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389268
]
ASF GitHub Bot logged work on GOBBLIN-1051:
---
Author: ASF GitHub Bot
Created on: 19/Feb/20 01:59
Start Date: 19/Feb/20 01:59
Worklog Time Spent: 10m
Work Description: linweihs commented on pull request #2891:
[GOBBLIN-1051] Emit Helix Leader Metrics
URL: https://github.com/apache/incubator-gobblin/pull/2891#discussion_r381038891
##
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java
##
@@ -645,4 +678,21 @@ private static void
testGobblinService(GobblinServiceManager gobblinServiceManag
throw new RuntimeException(e);
}
}
+
+ @Setter
+ private static class HelixLeaderState {
+private LeaderState state = LeaderState.UNKNOWN;
+ }
+
+ private enum LeaderState {
+UNKNOWN(-1),
+SLAVE(0),
+MASTER(1);
+
+public int value;
Review comment:
good point. added
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 389268)
Time Spent: 1h 40m (was: 1.5h)
> Emit helix leader metrics to ingraph
> -
>
> Key: GOBBLIN-1051
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1051
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Wei-Hsiang Lin
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=389267=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389267 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 19/Feb/20 01:59 Start Date: 19/Feb/20 01:59 Worklog Time Spent: 10m Work Description: linweihs commented on pull request #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#discussion_r381038818 ## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java ## @@ -25,6 +28,9 @@ import java.util.Properties; import java.util.concurrent.TimeUnit; +import org.slf4j.Logger; Review comment: no. these are used on here `private static final Logger LOGGER = LoggerFactory.getLogger(GobblinServiceManager.class);` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389267) Time Spent: 1.5h (was: 1h 20m) > Emit helix leader metrics to ingraph > - > > Key: GOBBLIN-1051 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1051 > Project: Apache Gobblin > Issue Type: Task >Reporter: Wei-Hsiang Lin >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=389269=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389269 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 19/Feb/20 01:59 Start Date: 19/Feb/20 01:59 Worklog Time Spent: 10m Work Description: linweihs commented on pull request #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#discussion_r381038920 ## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java ## @@ -214,6 +223,14 @@ public GobblinServiceManager(String serviceName, String serviceId, Config config this.isGitConfigMonitorEnabled = false; } +// Initialize Helix leader guage +helixLeaderGauges = Optional.of(new HelixLeaderState()); +String helixLeaderStateGaugeName = +MetricRegistry.name(MetricReportUtils.GOBBLIN_SERVICE_METRICS_PREFIX, ServiceMetricNames.HELIX_LEADER_STATE); +ContextAwareGauge gauge = metricContext.newContextAwareGauge(helixLeaderStateGaugeName, () -> helixLeaderGauges.get().state.value); Review comment: updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389269) Time Spent: 1h 50m (was: 1h 40m) > Emit helix leader metrics to ingraph > - > > Key: GOBBLIN-1051 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1051 > Project: Apache Gobblin > Issue Type: Task >Reporter: Wei-Hsiang Lin >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=389029=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389029 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 18/Feb/20 19:45 Start Date: 18/Feb/20 19:45 Worklog Time Spent: 10m Work Description: sv2000 commented on pull request #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#discussion_r380895329 ## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java ## @@ -214,6 +223,14 @@ public GobblinServiceManager(String serviceName, String serviceId, Config config this.isGitConfigMonitorEnabled = false; } +// Initialize Helix leader guage +helixLeaderGauges = Optional.of(new HelixLeaderState()); +String helixLeaderStateGaugeName = +MetricRegistry.name(MetricReportUtils.GOBBLIN_SERVICE_METRICS_PREFIX, ServiceMetricNames.HELIX_LEADER_STATE); +ContextAwareGauge gauge = metricContext.newContextAwareGauge(helixLeaderStateGaugeName, () -> helixLeaderGauges.get().state.value); Review comment: Use helixLeaderGauges.get().state.getValue() with Getter on value field? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389029) Time Spent: 1h 10m (was: 1h) > Emit helix leader metrics to ingraph > - > > Key: GOBBLIN-1051 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1051 > Project: Apache Gobblin > Issue Type: Task >Reporter: Wei-Hsiang Lin >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[
https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=389030=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389030
]
ASF GitHub Bot logged work on GOBBLIN-1051:
---
Author: ASF GitHub Bot
Created on: 18/Feb/20 19:45
Start Date: 18/Feb/20 19:45
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2891: [GOBBLIN-1051]
Emit Helix Leader Metrics
URL: https://github.com/apache/incubator-gobblin/pull/2891#discussion_r380895014
##
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java
##
@@ -645,4 +678,21 @@ private static void
testGobblinService(GobblinServiceManager gobblinServiceManag
throw new RuntimeException(e);
}
}
+
+ @Setter
+ private static class HelixLeaderState {
+private LeaderState state = LeaderState.UNKNOWN;
+ }
+
+ private enum LeaderState {
+UNKNOWN(-1),
+SLAVE(0),
+MASTER(1);
+
+public int value;
Review comment:
Annotate with @Getter?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 389030)
Time Spent: 1h 20m (was: 1h 10m)
> Emit helix leader metrics to ingraph
> -
>
> Key: GOBBLIN-1051
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1051
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Wei-Hsiang Lin
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=389028=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389028 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 18/Feb/20 19:45 Start Date: 18/Feb/20 19:45 Worklog Time Spent: 10m Work Description: sv2000 commented on pull request #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#discussion_r380894548 ## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java ## @@ -25,6 +28,9 @@ import java.util.Properties; import java.util.concurrent.TimeUnit; +import org.slf4j.Logger; Review comment: Are these unused imports? Don't see them being used in this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389028) Time Spent: 1h (was: 50m) > Emit helix leader metrics to ingraph > - > > Key: GOBBLIN-1051 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1051 > Project: Apache Gobblin > Issue Type: Task >Reporter: Wei-Hsiang Lin >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=387788=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387788 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 15/Feb/20 01:40 Start Date: 15/Feb/20 01:40 Worklog Time Spent: 10m Work Description: arjun4084346 commented on issue #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#issuecomment-586540415 LGTM +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 387788) Time Spent: 50m (was: 40m) > Emit helix leader metrics to ingraph > - > > Key: GOBBLIN-1051 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1051 > Project: Apache Gobblin > Issue Type: Task >Reporter: Wei-Hsiang Lin >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=387787=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387787 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 15/Feb/20 01:37 Start Date: 15/Feb/20 01:37 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#issuecomment-586523868 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=h1) Report > Merging [#2891](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0b059870755bbab93f11d1cf620862e7502b2d4c?src=pr=desc) will **increase** coverage by `1.03%`. > The diff coverage is `82.6%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2891 +/- ## + Coverage 44.78% 45.81% +1.03% - Complexity 8958 9143 +185 Files 1926 1929 +3 Lines 7255572625 +70 Branches 7992 7997 +5 + Hits 3249133273 +782 + Misses3707336311 -762 - Partials 2991 3041 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/gobblin/metrics/ServiceMetricNames.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvU2VydmljZU1ldHJpY05hbWVzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh) | `56.94% <82.6%> (+2.22%)` | `24 <0> (-1)` | :arrow_down: | | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | | | [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `36.28% <0%> (-2.97%)` | `13% <0%> (ø)` | | | [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | | | [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `78.12% <0%> (-1.57%)` | `15% <0%> (-1%)` | | | [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `79.43% <0%> (-0.94%)` | `24% <0%> (ø)` | | | [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.53% <0%> (-0.34%)` | `24% <0%> (-1%)` | | | [...rg/apache/gobblin/publisher/BaseDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9CYXNlRGF0YVB1Ymxpc2hlci5qYXZh) | `67.74% <0%> (-0.31%)` | `61% <0%> (-1%)` | | |
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=38=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-38 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 15/Feb/20 01:04 Start Date: 15/Feb/20 01:04 Worklog Time Spent: 10m Work Description: linweihs commented on pull request #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#discussion_r379704682 ## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java ## @@ -58,15 +35,30 @@ import com.linkedin.restli.server.resources.BaseResource; import com.typesafe.config.Config; import com.typesafe.config.ConfigFactory; - +import java.io.IOException; +import java.lang.reflect.InvocationTargetException; Review comment: import order restored by code style This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 38) Time Spent: 0.5h (was: 20m) > Emit helix leader metrics to ingraph > - > > Key: GOBBLIN-1051 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1051 > Project: Apache Gobblin > Issue Type: Task >Reporter: Wei-Hsiang Lin >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=387770=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387770 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 15/Feb/20 00:52 Start Date: 15/Feb/20 00:52 Worklog Time Spent: 10m Work Description: arjun4084346 commented on pull request #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#discussion_r379702360 ## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java ## @@ -58,15 +35,30 @@ import com.linkedin.restli.server.resources.BaseResource; import com.typesafe.config.Config; import com.typesafe.config.ConfigFactory; - +import java.io.IOException; +import java.lang.reflect.InvocationTargetException; Review comment: this is not correct. please follow https://gobblin.readthedocs.io/en/latest/developer-guide/CodingStyle/ and use gobblin's codestyle This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 387770) Time Spent: 20m (was: 10m) > Emit helix leader metrics to ingraph > - > > Key: GOBBLIN-1051 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1051 > Project: Apache Gobblin > Issue Type: Task >Reporter: Wei-Hsiang Lin >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1051) Emit helix leader metrics to ingraph
[ https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=387750=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387750 ] ASF GitHub Bot logged work on GOBBLIN-1051: --- Author: ASF GitHub Bot Created on: 14/Feb/20 23:54 Start Date: 14/Feb/20 23:54 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2891: [GOBBLIN-1051] Emit Helix Leader Metrics URL: https://github.com/apache/incubator-gobblin/pull/2891#issuecomment-586523868 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=h1) Report > Merging [#2891](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/0b059870755bbab93f11d1cf620862e7502b2d4c?src=pr=desc) will **increase** coverage by `1.04%`. > The diff coverage is `82.6%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2891 +/- ## + Coverage 44.78% 45.82% +1.04% - Complexity 8958 9146 +188 Files 1926 1929 +3 Lines 7255572625 +70 Branches 7992 7997 +5 + Hits 3249133279 +788 + Misses3707336306 -767 - Partials 2991 3040 +49 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/gobblin/metrics/ServiceMetricNames.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvU2VydmljZU1ldHJpY05hbWVzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh) | `56.94% <82.6%> (+2.22%)` | `25 <0> (ø)` | :arrow_down: | | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | | | [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | | | [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `38.93% <0%> (-0.32%)` | `14% <0%> (+1%)` | | | [...rg/apache/gobblin/publisher/BaseDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9CYXNlRGF0YVB1Ymxpc2hlci5qYXZh) | `67.74% <0%> (-0.31%)` | `61% <0%> (-1%)` | | | [...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==) | `18.8% <0%> (-0.06%)` | `15% <0%> (ø)` | | | [...va/org/apache/gobblin/publisher/DataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcHVibGlzaGVyL0RhdGFQdWJsaXNoZXIuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...a/org/apache/gobblin/runtime/util/ForkMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Gb3JrTWV0cmljcy5qYXZh) | `100% <0%> (ø)` | `5% <0%> (-1%)` | :arrow_down: | |
