[jira] [Work logged] (GOBBLIN-1207) Clear references to large objects in Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter

2020-06-30 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1207?focusedWorklogId=453165=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453165
 ]

ASF GitHub Bot logged work on GOBBLIN-1207:
---

Author: ASF GitHub Bot
Created on: 30/Jun/20 23:45
Start Date: 30/Jun/20 23:45
Worklog Time Spent: 10m 
  Work Description: asfgit closed pull request #3052:
URL: https://github.com/apache/incubator-gobblin/pull/3052


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 453165)
Time Spent: 40m  (was: 0.5h)

> Clear references to large objects in Fork, FileBasedExtractor, and 
> HiveWritableHdfsDataWriter
> -
>
> Key: GOBBLIN-1207
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1207
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Hung Tran
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter objects contain 
> references to objects that can be large, such as ORC reader and writer 
> buffers. Clear these references to allow the memory to be reclaimed during 
> the job execution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-1207) Clear references to large objects in Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter

2020-06-30 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1207?focusedWorklogId=453109=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453109
 ]

ASF GitHub Bot logged work on GOBBLIN-1207:
---

Author: ASF GitHub Bot
Created on: 30/Jun/20 21:01
Start Date: 30/Jun/20 21:01
Worklog Time Spent: 10m 
  Work Description: htran1 commented on a change in pull request #3052:
URL: https://github.com/apache/incubator-gobblin/pull/3052#discussion_r447976480



##
File path: 
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/fork/ForkTest.java
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.fork;
+
+import java.io.IOException;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.runtime.ExecutionModel;
+import org.apache.gobblin.runtime.TaskContext;
+import org.apache.gobblin.writer.DataWriter;
+import org.apache.gobblin.writer.DataWriterBuilder;
+import org.apache.gobblin.writer.RetryWriter;
+import org.junit.Assert;
+import org.testng.annotations.DataProvider;
+import org.testng.annotations.Test;
+
+
+public class ForkTest {

Review comment:
   Fixed.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 453109)
Time Spent: 0.5h  (was: 20m)

> Clear references to large objects in Fork, FileBasedExtractor, and 
> HiveWritableHdfsDataWriter
> -
>
> Key: GOBBLIN-1207
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1207
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Hung Tran
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter objects contain 
> references to objects that can be large, such as ORC reader and writer 
> buffers. Clear these references to allow the memory to be reclaimed during 
> the job execution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-1207) Clear references to large objects in Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter

2020-06-30 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1207?focusedWorklogId=453107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453107
 ]

ASF GitHub Bot logged work on GOBBLIN-1207:
---

Author: ASF GitHub Bot
Created on: 30/Jun/20 20:55
Start Date: 30/Jun/20 20:55
Worklog Time Spent: 10m 
  Work Description: autumnust commented on a change in pull request #3052:
URL: https://github.com/apache/incubator-gobblin/pull/3052#discussion_r447928386



##
File path: 
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/fork/ForkTest.java
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.fork;
+
+import java.io.IOException;
+import lombok.Getter;
+import lombok.Setter;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.runtime.ExecutionModel;
+import org.apache.gobblin.runtime.TaskContext;
+import org.apache.gobblin.writer.DataWriter;
+import org.apache.gobblin.writer.DataWriterBuilder;
+import org.apache.gobblin.writer.RetryWriter;
+import org.junit.Assert;
+import org.testng.annotations.DataProvider;
+import org.testng.annotations.Test;
+
+
+public class ForkTest {

Review comment:
   The intention in this file doesn't seem to be right. Can you fix it ? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 453107)
Time Spent: 20m  (was: 10m)

> Clear references to large objects in Fork, FileBasedExtractor, and 
> HiveWritableHdfsDataWriter
> -
>
> Key: GOBBLIN-1207
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1207
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Hung Tran
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter objects contain 
> references to objects that can be large, such as ORC reader and writer 
> buffers. Clear these references to allow the memory to be reclaimed during 
> the job execution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (GOBBLIN-1207) Clear references to large objects in Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter

2020-06-29 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-1207?focusedWorklogId=452677=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452677
 ]

ASF GitHub Bot logged work on GOBBLIN-1207:
---

Author: ASF GitHub Bot
Created on: 29/Jun/20 23:01
Start Date: 29/Jun/20 23:01
Worklog Time Spent: 10m 
  Work Description: htran1 opened a new pull request #3052:
URL: https://github.com/apache/incubator-gobblin/pull/3052


   … FileBasedExtractor, and HiveWritableHdfsDataWriter
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [1207] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
   - https://issues.apache.org/jira/browse/GOBBLIN-1207
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if 
applicable):
   Remove the reference to the underlying writer when 
HiveWritableHdfsDataWriter.close() is called.
   Remove the reference to the record iterator when the FileBasedExtractor is 
done with it.
   Add an option to close the Writer when the Fork is done.
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   ForkTest
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 452677)
Remaining Estimate: 0h
Time Spent: 10m

> Clear references to large objects in Fork, FileBasedExtractor, and 
> HiveWritableHdfsDataWriter
> -
>
> Key: GOBBLIN-1207
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1207
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Hung Tran
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Fork, FileBasedExtractor, and HiveWritableHdfsDataWriter objects contain 
> references to objects that can be large, such as ORC reader and writer 
> buffers. Clear these references to allow the memory to be reclaimed during 
> the job execution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)