[GitHub] [griffin] asfgit closed pull request #495: Update version information for new release.

2019-04-03 Thread GitBox 
asfgit closed pull request #495: Update version information for new release.
URL: https://github.com/apache/griffin/pull/495
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [griffin] toyboxman opened a new pull request #495: Update version information for new release.

2019-04-03 Thread GitBox 
toyboxman opened a new pull request #495: Update version information for new 
release.
URL: https://github.com/apache/griffin/pull/495
 
 
   change version 0.4.0 --> 0.5.0


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id

2019-04-03 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=222411=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222411
 ]

ASF GitHub Bot logged work on GRIFFIN-244:
--

Author: ASF GitHub Bot
Created on: 03/Apr/19 16:55
Start Date: 03/Apr/19 16:55
Worklog Time Spent: 10m 
  Work Description: RodionGork commented on pull request #492: GRIFFIN-244 
get metrics by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271838431
 
 

 ##
 File path: 
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
 ##
 @@ -211,9 +213,13 @@ private static String buildBasicAuthString(String user, 
String password) {
 
 @Override
 public MetricValue getMetric(String applicationId) throws IOException {
-Map map = new HashMap<>();
-map.put("q", "applicationId:" + applicationId);
-Response response = client.performRequest("GET", urlGet, map);
+Response response0 = client.performRequest(
 
 Review comment:
   @dershovGD thanks a lot, it was debug stuff. Let me get rid of it...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 222411)
Time Spent: 2h 40m  (was: 2.5h)

> [Service, Metric]Implement possibility to get metrics for certain Job 
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
>  Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> In addition to functionality described in tasks 
> https://issues.apache.org/jira/browse/GRIFFIN-240, 
> https://issues.apache.org/jira/browse/GRIFFIN-233 and 
> https://issues.apache.org/jira/browse/GRIFFIN-234  it will be very convenient 
> to have a possibility to obtain the metrics for given Job Instance Id.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [griffin] RodionGork commented on a change in pull request #492: GRIFFIN-244 get metrics by instance

2019-04-03 Thread GitBox 
RodionGork commented on a change in pull request #492: GRIFFIN-244 get metrics 
by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271838431
 
 

 ##
 File path: 
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
 ##
 @@ -211,9 +213,13 @@ private static String buildBasicAuthString(String user, 
String password) {
 
 @Override
 public MetricValue getMetric(String applicationId) throws IOException {
-Map map = new HashMap<>();
-map.put("q", "applicationId:" + applicationId);
-Response response = client.performRequest("GET", urlGet, map);
+Response response0 = client.performRequest(
 
 Review comment:
   @dershovGD thanks a lot, it was debug stuff. Let me get rid of it...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id

2019-04-03 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=222402=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222402
 ]

ASF GitHub Bot logged work on GRIFFIN-244:
--

Author: ASF GitHub Bot
Created on: 03/Apr/19 16:47
Start Date: 03/Apr/19 16:47
Worklog Time Spent: 10m 
  Work Description: dershovGD commented on pull request #492: GRIFFIN-244 
get metrics by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271835189
 
 

 ##
 File path: 
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
 ##
 @@ -211,9 +213,13 @@ private static String buildBasicAuthString(String user, 
String password) {
 
 @Override
 public MetricValue getMetric(String applicationId) throws IOException {
-Map map = new HashMap<>();
-map.put("q", "applicationId:" + applicationId);
-Response response = client.performRequest("GET", urlGet, map);
+Response response0 = client.performRequest(
 
 Review comment:
   Looks like this value never used.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 222402)
Time Spent: 2.5h  (was: 2h 20m)

> [Service, Metric]Implement possibility to get metrics for certain Job 
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
>  Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> In addition to functionality described in tasks 
> https://issues.apache.org/jira/browse/GRIFFIN-240, 
> https://issues.apache.org/jira/browse/GRIFFIN-233 and 
> https://issues.apache.org/jira/browse/GRIFFIN-234  it will be very convenient 
> to have a possibility to obtain the metrics for given Job Instance Id.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [griffin] dershovGD commented on a change in pull request #492: GRIFFIN-244 get metrics by instance

2019-04-03 Thread GitBox 
dershovGD commented on a change in pull request #492: GRIFFIN-244 get metrics 
by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271835189
 
 

 ##
 File path: 
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
 ##
 @@ -211,9 +213,13 @@ private static String buildBasicAuthString(String user, 
String password) {
 
 @Override
 public MetricValue getMetric(String applicationId) throws IOException {
-Map map = new HashMap<>();
-map.put("q", "applicationId:" + applicationId);
-Response response = client.performRequest("GET", urlGet, map);
+Response response0 = client.performRequest(
 
 Review comment:
   Looks like this value never used.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (GRIFFIN-246) Angular routing error in UI

2019-04-03 Thread Allen ONeill (JIRA) 
Allen ONeill created GRIFFIN-246:


 Summary: Angular routing error in UI
 Key: GRIFFIN-246
 URL: https://issues.apache.org/jira/browse/GRIFFIN-246
 Project: Griffin (Incubating)
  Issue Type: Bug
Reporter: Allen ONeill


app.component.html, line 47,48 refers to:


{{}}
{code:java}
 User 
Profile 
Settings{code}
{{}}
 
As there is no route to inline '#!/undercons' it gives no UI feedback to the 
user, but raises a console error:


{code:java}
ERROR Error: Uncaught (in promise): Error: Cannot match any routes. URL 
Segment: '!/undercons'
Error: Cannot match any routes. URL Segment: '!/undercons'{code}

should '#!/undercons' be defined as a route and a user message shown for 
anything 'under construction' ?
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)