[GitHub] [guacamole-client] jmuehlner merged pull request #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus.
jmuehlner merged pull request #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus. URL: https://github.com/apache/guacamole-client/pull/421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [guacamole-client] jmuehlner commented on issue #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus.
jmuehlner commented on issue #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus. URL: https://github.com/apache/guacamole-client/pull/421#issuecomment-505700924 Well, I don't fully understand this, but testing confirms that this fixes the issue on several different browsers. LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [guacamole-client] jmuehlner merged pull request #418: GUACAMOLE-822: Correct retrieval of client identifier for connection groups.
jmuehlner merged pull request #418: GUACAMOLE-822: Correct retrieval of client identifier for connection groups. URL: https://github.com/apache/guacamole-client/pull/418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [guacamole-client] chisatohasimoto commented on issue #413: GUACAMOLE-821: Add Japanese translation
chisatohasimoto commented on issue #413: GUACAMOLE-821: Add Japanese translation URL: https://github.com/apache/guacamole-client/pull/413#issuecomment-505682881 Many thanks for your advice. I changed the commit message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: guacamole-common-js BlobWriter.js Bug
Hi James, Thanks! However: 1) Your modified BlobWriter.js didn't actually make it through. The attachment was likely stripped. 2) That doesn't matter anyway, as contributions need to be submitted via pull request, not via email / mailing list. If you would like to contribute a change, please submit that change by opening an issue in JIRA describing the bug/feature/etc and then opening a pull request in GitHub containing your change. Please see our contribution guidelines: https://github.com/apache/guacamole-client/blob/master/CONTRIBUTING You can also see this in practice if you look over the git history and past merged pull requests. - Mike On Mon, Jun 24, 2019 at 7:44 PM James Caple wrote: > Hi, > > Thanks for the guacamole project. I've been using it with good success on > a project at work. I've been developing a Javascript Client to integrate > with MS Windows Virtual Machines. I used the Javascript API to develop > some file transfer capabilities. I was unable to get the BlobWriter JS > file to work as currently available here ( > https://github.com/apache/guacamole-client/tree/master/guacamole-common-js/src/main/webapp/modules). > I kept getting the following error whenever I'd try to write files to the > VM: > > zone.js:1495 Uncaught (in promise) DOMException: Failed to execute > 'readAsArrayBuffer' on 'FileReader': The object is already busy reading > Blobs. > at _global.. [as readAsArrayBuffer] ( > https://redacted/polyfills.6e39da16eddfecb84434.js:3830:60) > at readNextChunk ( > https://redacted/main.51a4f7c78afe09ae8d5e.js:168269:20) > at > push../src/app/components/core/desktop/js/BlobWriter.js.redacted.ArrayBufferWriter.sendMoreChunks > [as onack] (https://redacted/main.51a4f7c78afe09ae8d5e.js:168295:17) > at > push../node_modules/guacamole-common-js/dist/guacamole-common.js.Guacamole.OutputStream.stream.onack > (https://redacted/main.51a4f7c78afe09ae8d5e.js:168396:25) > at ack (https://redacted/main.51a4f7c78afe09ae8d5e.js:114024:28) > at > push../node_modules/guacamole-common-js/dist/guacamole-common.js.Guacamole.HTTPTunnel.tunnel.oninstruction > (https://redacted/main.51a4f7c78afe09ae8d5e.js:114685:13) > at XMLHttpRequest.parseResponse [as > __zone_symbol__ON_PROPERTYreadystatechange] ( > https://redacted/main.51a4f7c78afe09ae8d5e.js:123910:40) > at XMLHttpRequest.wrapFn ( > https://redacted/polyfills.6e39da16eddfecb84434.js:3667:39) > at > ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask > (https://redacted/polyfills.6e39da16eddfecb84434.js:2758:31) > at Object.onInvokeTask ( > https://redacted/main.51a4f7c78afe09ae8d5e.js:33312:33) > > I came up with an easy workaround to this issue, and thought someone might > be interested. My amended BlobWriter.js is attached. > > Thanks, > > James Caple >
[GitHub] [guacamole-client] mike-jumper opened a new pull request #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus.
mike-jumper opened a new pull request #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus. URL: https://github.com/apache/guacamole-client/pull/421 It appears that we cannot rely on `focus()` working as expected unless its execution is deferred via `window.setTimeout()` or equivalent. If not deferred, the target element may not be ready to receive focus, and the attempt will silently fail. Note that while there is a _chance_ that deferred execution will happen with the current usage of `$evalAsync()` within the `guacFocus` directive, but this is not guaranteed. If it can, AngularJS will execute function provided to `$evalAsync()` immediately after the current `$digest` loop and without control returning to the browser. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on issue #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure
mike-jumper commented on issue #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure URL: https://github.com/apache/guacamole-client/pull/420#issuecomment-505607016 > As far as the inconsistency in focusing the username field on the initial page load is concerned, that seems to no longer happen as a result of this fix. I do not understand why that is the case, but that is the behavior I have observed. For that reason, I am uncertain whether we can deem that part as resolved. I'm still seeing the same behavior following merge. The issue specifically addressed by these changes is fixed, but the inconsistent focus remains. If things were working for you after making this change, that was likely a coincidence. Testing against things before the merge, the focus behavior doesn't correlate with the error message. The error message appeared when fields were manually blurred, but didn't appear when the username failed to receive focus or when it successfully received focus. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [guacamole-client] mike-jumper merged pull request #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure
mike-jumper merged pull request #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure URL: https://github.com/apache/guacamole-client/pull/420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [guacamole-client] m-khan-glyptodon opened a new pull request #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure
m-khan-glyptodon opened a new pull request #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure URL: https://github.com/apache/guacamole-client/pull/420 Note: There were two parts of this issue this time around. The first(error message) has been fixed and described in the commit itself. As far as the inconsistency in focusing the username field on the initial page load, that seems to no longer happen as a result of this fix. I do not understand why that is the case, but that is the behavior I have observed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
