Re: [ANNOUNCE] New HBase committer Istvan Toth

2024-04-02 Thread Nihal Jain
Congratulations Istvan. Welcome !

On Wed, 3 Apr 2024, 01:53 Rushabh Shah, 
wrote:

> Congratulations Istvan, welcome !!
>
>
> On Tue, Apr 2, 2024 at 4:23 AM Duo Zhang  wrote:
>
> > On behalf of the Apache HBase PMC, I am pleased to announce that
> > Istvan Toth(stoty)
> > has accepted the PMC's invitation to become a committer on the
> > project. We appreciate all
> > of Istvan Toth's generous contributions thus far and look forward to
> > his continued involvement.
> >
> > Congratulations and welcome, Istvan Toth!
> >
> > 我很高兴代表 Apache HBase PMC 宣布 Istvan Toth 已接受我们的邀请,成
> > 为 Apache HBase 项目的 Committer。感谢 Istvan Toth 一直以来为 HBase 项目
> > 做出的贡献,并期待他在未来继续承担更多的责任。
> >
> > 欢迎 Istvan Toth!
> >
>


[jira] [Created] (HBASE-28482) Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE

2024-04-02 Thread Vineet Kumar Maheshwari (Jira)
Vineet Kumar Maheshwari created HBASE-28482:
---

 Summary: Reverse scan with tags throws 
ArrayIndexOutOfBoundsException with DBE
 Key: HBASE-28482
 URL: https://issues.apache.org/jira/browse/HBASE-28482
 Project: HBase
  Issue Type: Bug
  Components: HFile
Reporter: Vineet Kumar Maheshwari


Facing ArrayIndexOutOfBoundsException when performing reverse scan on a table 
with 30K+ records in single hfile.

Exception is happening  when block changes during seekBefore call.
{code:java}
Caused by: java.lang.ArrayIndexOutOfBoundsException
    at 
org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray(ByteBufferUtils.java:1326)
    at org.apache.hadoop.hbase.nio.SingleByteBuff.get(SingleByteBuff.java:213)
    at 
org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decode(DiffKeyDeltaEncoder.java:431)
    at 
org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decodeNext(DiffKeyDeltaEncoder.java:502)
    at 
org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.seekToKeyInBlock(BufferedDataBlockEncoder.java:1012)
    at 
org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$EncodedScanner.loadBlockAndSeekToKey(HFileReaderImpl.java:1605)
    at 
org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekBefore(HFileReaderImpl.java:719)
    at 
org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekBeforeAndSaveKeyToPreviousRow(StoreFileScanner.java:645)
    at 
org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekToPreviousRowWithoutHint(StoreFileScanner.java:570)
    at 
org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekToPreviousRow(StoreFileScanner.java:506)
    at 
org.apache.hadoop.hbase.regionserver.ReversedKeyValueHeap.next(ReversedKeyValueHeap.java:126)
    at 
org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:693)
    at 
org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:151){code}
 

Steps to reproduce:

Create a table with DataBlockEncoding.DIFF and block size as 1024, write some 
30K+ puts with setTTL, then do a reverse scan.
{code:java}
@Test
public void testReverseScanWithDBEWhenCurrentBlockUpdates() throws IOException {
byte[] family = Bytes.toBytes("0");

Configuration conf = new Configuration(TEST_UTIL.getConfiguration());
conf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 1);

try (Connection connection = ConnectionFactory.createConnection(conf)) {
testReverseScanWithDBE(connection, DataBlockEncoding.DIFF, family, 1024, 3);
for (DataBlockEncoding encoding : DataBlockEncoding.values()) {
testReverseScanWithDBE(connection, encoding, family, 1024, 3);
}
}
}

private void testReverseScanWithDBE(Connection conn, DataBlockEncoding 
encoding, byte[] family, int blockSize, int maxRows)
throws IOException {
LOG.info("Running test with DBE={}", encoding);
TableName tableName = TableName.valueOf(TEST_NAME.getMethodName() + "-" + 
encoding);
TEST_UTIL.createTable(TableDescriptorBuilder.newBuilder(tableName)
.setColumnFamily(
ColumnFamilyDescriptorBuilder.newBuilder(family).setDataBlockEncoding(encoding).setBlocksize(blockSize).build())
.build(), null);

Table table = conn.getTable(tableName);

byte[] val1 = new byte[10];
byte[] val2 = new byte[10];
Bytes.random(val1);
Bytes.random(val2);

for (int i = 0; i < maxRows; i++) {
table.put(new Put(Bytes.toBytes(i)).addColumn(family, Bytes.toBytes(1), val1)
.addColumn(family, Bytes.toBytes(2), val2).setTTL(600_000));
}

TEST_UTIL.flush(table.getName());

Scan scan = new Scan();
scan.setReversed(true);

try (ResultScanner scanner = table.getScanner(scan)) {
for (int i = maxRows - 1; i >= 0; i--) {
Result row = scanner.next();
assertEquals(2, row.size());

Cell cell1 = row.getColumnLatestCell(family, Bytes.toBytes(1));
assertTrue(CellUtil.matchingRows(cell1, Bytes.toBytes(i)));
assertTrue(CellUtil.matchingValue(cell1, val1));

Cell cell2 = row.getColumnLatestCell(family, Bytes.toBytes(2));
assertTrue(CellUtil.matchingRows(cell2, Bytes.toBytes(i)));
assertTrue(CellUtil.matchingValue(cell2, val2));
}
}

}
{code}
 

HBASE-27580 has fixed the issue for seekBefore in rewind function flow, but 
similar change is required in setCurrentBlock function flow also.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Considering deprecation and removal of XZ compression (hbase-compression-xz)

2024-04-02 Thread Duo Zhang
For me I've never seen people actually use the xz compression.

For size, usually people will choose gzip, and for speed, in the past
people will choose lzo and now they choose snappy or zstd.

So for me I prefer we just deprecated the xz compression immediately
and remove it 2.6.0.

Thanks.

Andrew Purtell  于2024年4月2日周二 08:02写道:
>
> Red Hat filed CVE-2024-3094 late last week on 2024-03-29. This implicates
> recent releases of the native liblzma library as a vector for malicious
> code.
>
> This is not the pure Java version that we depend upon for HBase's support
> for the LZMA algorithm (
> https://github.com/apache/hbase/tree/master/hbase-compression/hbase-compression-xz).
> We depend on version 1.9 of xz-java, which was published in 2021, well
> before maintenance changes in the project and the involvement of a person
> who is now believed to be a malicious actor. Projects like HBase that
> depend on xz-java have no reason to be concerned about the issues affecting
> the native xz library.
>
> How the backdoor was introduced calls into question the trustworthiness and
> viability of the XZ project. GitHub has disabled all repositories related
> to XZ and liblzma, even xz-java. The webpage for XZ and xz-java is down.
> The open source software community is responding vigorously. CVE-2024-3094
> has a CVSS score 10, the highest possible score. Your security team may
> become interested in HBase because of hbase-compression-xz's dependency on
> xz-java. It is likely any discovered dependency on any LZMA implementation
> will at least raise questions.
>
> For now xz-java remains available in Maven central. (See
> https://central.sonatype.com/artifact/org.tukaani/xz/versions) We may have
> no choice but to immediately remove hbase-compression-xz if Maven blocks or
> drops xz-java too, because that will break our builds.
>
> There is no immediate cause for concern. Still, we believe XZ compression
> provides little to no value over more modern alternatives, like ZStandard,
> that can also achieve similar compression ratios. XZ, and alternatives like
> ZStandard with the compression level set to a high value, are also suitable
> only for archival use cases and unsuitable for compression of flush files
> or for use in minor compactions. Given how niche any use of XZ
> compression could
> be, we are wondering if there are actually any users of it.
>
> If we have no users of hbase-compression-xz, then it provides little to no
> value and continued maintenance of hbase-compression-xz given the issues
> with its dependency does not make sense.
>
> Do you use XZ compression, or are you planning to?
>
> If we deprecate XZ compression immediately and then remove it in 2.6, would
> this present a problem? In a private discussion we reached consensus on
> this approach, but, of course, that is not yet a plan, and something that
> could easily change based on feedback.
>
> From https://nvd.nist.gov/vuln/detail/CVE-2024-3094:
> "Malicious code was discovered in the upstream tarballs of xz, starting
> with version 5.6.0. Through a series of complex obfuscations, the liblzma
> build process extracts a prebuilt object file from a disguised test file
> existing in the source code, which is then used to modify specific
> functions in the liblzma code. This results in a modified liblzma library
> that can be used by any software linked against this library, intercepting
> and modifying the data interaction with this library."
>
> --
> Best regards,
> Andrew


Re: [ANNOUNCE] New HBase committer Istvan Toth

2024-04-02 Thread Rushabh Shah
Congratulations Istvan, welcome !!


On Tue, Apr 2, 2024 at 4:23 AM Duo Zhang  wrote:

> On behalf of the Apache HBase PMC, I am pleased to announce that
> Istvan Toth(stoty)
> has accepted the PMC's invitation to become a committer on the
> project. We appreciate all
> of Istvan Toth's generous contributions thus far and look forward to
> his continued involvement.
>
> Congratulations and welcome, Istvan Toth!
>
> 我很高兴代表 Apache HBase PMC 宣布 Istvan Toth 已接受我们的邀请,成
> 为 Apache HBase 项目的 Committer。感谢 Istvan Toth 一直以来为 HBase 项目
> 做出的贡献,并期待他在未来继续承担更多的责任。
>
> 欢迎 Istvan Toth!
>


Re: [ANNOUNCE] New HBase committer Istvan Toth

2024-04-02 Thread Ankit Singhal
Congratulations Istvan !!

On Tue, 2 Apr 2024 at 08:53, Shanmukha Haripriya Kota
 wrote:

> Congratulations Istvan!
>
> Regards,
> Shanmukha K
>
> On Tue, Apr 2, 2024 at 10:39 AM Viraj Jasani  wrote:
>
> > Many Congratulations and Welcome, Istvan!!!
> >
> >
> > On Tue, Apr 2, 2024 at 4:23 AM Duo Zhang  wrote:
> >
> > > On behalf of the Apache HBase PMC, I am pleased to announce that
> > > Istvan Toth(stoty)
> > > has accepted the PMC's invitation to become a committer on the
> > > project. We appreciate all
> > > of Istvan Toth's generous contributions thus far and look forward to
> > > his continued involvement.
> > >
> > > Congratulations and welcome, Istvan Toth!
> > >
> > > 我很高兴代表 Apache HBase PMC 宣布 Istvan Toth 已接受我们的邀请,成
> > > 为 Apache HBase 项目的 Committer。感谢 Istvan Toth 一直以来为 HBase 项目
> > > 做出的贡献,并期待他在未来继续承担更多的责任。
> > >
> > > 欢迎 Istvan Toth!
> > >
> >
>
>
> --
> Regards,
> Shanmukha Kota
>


Re: [ANNOUNCE] New HBase committer Istvan Toth

2024-04-02 Thread Shanmukha Haripriya Kota
Congratulations Istvan!

Regards,
Shanmukha K

On Tue, Apr 2, 2024 at 10:39 AM Viraj Jasani  wrote:

> Many Congratulations and Welcome, Istvan!!!
>
>
> On Tue, Apr 2, 2024 at 4:23 AM Duo Zhang  wrote:
>
> > On behalf of the Apache HBase PMC, I am pleased to announce that
> > Istvan Toth(stoty)
> > has accepted the PMC's invitation to become a committer on the
> > project. We appreciate all
> > of Istvan Toth's generous contributions thus far and look forward to
> > his continued involvement.
> >
> > Congratulations and welcome, Istvan Toth!
> >
> > 我很高兴代表 Apache HBase PMC 宣布 Istvan Toth 已接受我们的邀请,成
> > 为 Apache HBase 项目的 Committer。感谢 Istvan Toth 一直以来为 HBase 项目
> > 做出的贡献,并期待他在未来继续承担更多的责任。
> >
> > 欢迎 Istvan Toth!
> >
>


-- 
Regards,
Shanmukha Kota


Re: [ANNOUNCE] New HBase committer Istvan Toth

2024-04-02 Thread Viraj Jasani
Many Congratulations and Welcome, Istvan!!!


On Tue, Apr 2, 2024 at 4:23 AM Duo Zhang  wrote:

> On behalf of the Apache HBase PMC, I am pleased to announce that
> Istvan Toth(stoty)
> has accepted the PMC's invitation to become a committer on the
> project. We appreciate all
> of Istvan Toth's generous contributions thus far and look forward to
> his continued involvement.
>
> Congratulations and welcome, Istvan Toth!
>
> 我很高兴代表 Apache HBase PMC 宣布 Istvan Toth 已接受我们的邀请,成
> 为 Apache HBase 项目的 Committer。感谢 Istvan Toth 一直以来为 HBase 项目
> 做出的贡献,并期待他在未来继续承担更多的责任。
>
> 欢迎 Istvan Toth!
>


[jira] [Resolved] (HBASE-28460) Full backup restore fails for empty HFiles

2024-04-02 Thread Bryan Beaudreault (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-28460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault resolved HBASE-28460.
---
Fix Version/s: 2.6.0
   3.0.0-beta-2
 Assignee: Dieter De Paepe
   Resolution: Fixed

Thanks for the contribution [~dieterdp_ng]! Pushed to branch-2.6+

> Full backup restore fails for empty HFiles
> --
>
> Key: HBASE-28460
> URL: https://issues.apache.org/jira/browse/HBASE-28460
> Project: HBase
>  Issue Type: Bug
>  Components: backuprestore
>Affects Versions: 2.6.0, 4.0.0-alpha-1
>Reporter: Dieter De Paepe
>Assignee: Dieter De Paepe
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.6.0, 3.0.0-beta-2
>
>
> A full backup restore fails if the backup contains an empty HFile, for 
> example when all data has been deleted from a table and full compaction has 
> run. There are several issues:
>  * HFiles are read in `RestoreTool` to read the first/last key, but this 
> fails for empty HFiles
>  * In `RestoreTool`, table creation also incorrectly assumes the region 
> contains keys
>  * In `MapReduceRestoreJob`, the tool incorrectly assumes that a bulkload 
> with no loaded entries is an error.
> Example stacktrace:
> {code:java}
> 24/03/21 18:38:09 ERROR org.apache.hadoop.hbase.backup.util.BackupUtils: 
> java.util.NoSuchElementException: No value present
> java.util.NoSuchElementException: No value present
>   at java.base/java.util.Optional.get(Optional.java:143)
>   at 
> org.apache.hadoop.hbase.backup.util.RestoreTool.generateBoundaryKeys(RestoreTool.java:440)
>   at 
> org.apache.hadoop.hbase.backup.util.RestoreTool.checkAndCreateTable(RestoreTool.java:493)
>   at 
> org.apache.hadoop.hbase.backup.util.RestoreTool.createAndRestoreTable(RestoreTool.java:351)
>   at 
> org.apache.hadoop.hbase.backup.util.RestoreTool.fullRestoreTable(RestoreTool.java:211)
>   at 
> org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restoreImages(RestoreTablesClient.java:151)
>   at 
> org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restore(RestoreTablesClient.java:229)
>   at 
> org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.execute(RestoreTablesClient.java:265)
>   at 
> org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.restore(BackupAdminImpl.java:518)
>   at 
> org.apache.hadoop.hbase.backup.RestoreDriver.parseAndRun(RestoreDriver.java:176)
>   at 
> org.apache.hadoop.hbase.backup.RestoreDriver.doWork(RestoreDriver.java:216)
>   at 
> org.apache.hadoop.hbase.backup.RestoreDriver.run(RestoreDriver.java:252)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)
>   at 
> org.apache.hadoop.hbase.backup.RestoreDriver.main(RestoreDriver.java:224)
> 24/03/21 18:38:09 ERROR org.apache.hadoop.hbase.backup.RestoreDriver: Error 
> while running restore backup
> java.lang.IllegalStateException: Cannot restore hbase table
>   at 
> org.apache.hadoop.hbase.backup.util.RestoreTool.createAndRestoreTable(RestoreTool.java:360)
>   at 
> org.apache.hadoop.hbase.backup.util.RestoreTool.fullRestoreTable(RestoreTool.java:211)
>   at 
> org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restoreImages(RestoreTablesClient.java:151)
>   at 
> org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restore(RestoreTablesClient.java:229)
>   at 
> org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.execute(RestoreTablesClient.java:265)
>   at 
> org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.restore(BackupAdminImpl.java:518)
>   at 
> org.apache.hadoop.hbase.backup.RestoreDriver.parseAndRun(RestoreDriver.java:176)
>   at 
> org.apache.hadoop.hbase.backup.RestoreDriver.doWork(RestoreDriver.java:216)
>   at 
> org.apache.hadoop.hbase.backup.RestoreDriver.run(RestoreDriver.java:252)
>   at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)
>   at 
> org.apache.hadoop.hbase.backup.RestoreDriver.main(RestoreDriver.java:224)
> Caused by: java.util.NoSuchElementException: No value present
>   at java.base/java.util.Optional.get(Optional.java:143)
>   at 
> org.apache.hadoop.hbase.backup.util.RestoreTool.generateBoundaryKeys(RestoreTool.java:440)
>   at 
> org.apache.hadoop.hbase.backup.util.RestoreTool.checkAndCreateTable(RestoreTool.java:493)
>   at 
> org.apache.hadoop.hbase.backup.util.RestoreTool.createAndRestoreTable(RestoreTool.java:351)
>   ... 10 more {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [ANNOUNCE] New HBase committer Istvan Toth

2024-04-02 Thread Jan Hentschel
Congratulations and welcome!

From: Duo Zhang 
Date: Tuesday, April 2, 2024 at 13:23
To: HBase Dev List , hbase-user , 
user-zh 
Subject: [ANNOUNCE] New HBase committer Istvan Toth
On behalf of the Apache HBase PMC, I am pleased to announce that
Istvan Toth(stoty)
has accepted the PMC's invitation to become a committer on the
project. We appreciate all
of Istvan Toth's generous contributions thus far and look forward to
his continued involvement.

Congratulations and welcome, Istvan Toth!

我很高兴代表 Apache HBase PMC 宣布 Istvan Toth 已接受我们的邀请,成
为 Apache HBase 项目的 Committer。感谢 Istvan Toth 一直以来为 HBase 项目
做出的贡献,并期待他在未来继续承担更多的责任。

欢迎 Istvan Toth!


[ANNOUNCE] New HBase committer Istvan Toth

2024-04-02 Thread Duo Zhang
On behalf of the Apache HBase PMC, I am pleased to announce that
Istvan Toth(stoty)
has accepted the PMC's invitation to become a committer on the
project. We appreciate all
of Istvan Toth's generous contributions thus far and look forward to
his continued involvement.

Congratulations and welcome, Istvan Toth!

我很高兴代表 Apache HBase PMC 宣布 Istvan Toth 已接受我们的邀请,成
为 Apache HBase 项目的 Committer。感谢 Istvan Toth 一直以来为 HBase 项目
做出的贡献,并期待他在未来继续承担更多的责任。

欢迎 Istvan Toth!


Re: [VOTE] The first release candidate for 2.6.0 (RC2) is available

2024-04-02 Thread Bryan Beaudreault
Oh, sorry! I missed that it was just merged. Thanks again

On Tue, Apr 2, 2024 at 7:06 AM Wellington Chevreuil <
wellington.chevre...@gmail.com> wrote:

> I've just got the approval from Duo and merged it. Am cherry-picking to
> lower branches now.
>
> Em ter., 2 de abr. de 2024 às 12:02, Bryan Beaudreault <
> bbeaudrea...@apache.org> escreveu:
>
> > Thanks Wellington. Was there a reason to only merge that to master?
> >
> > On Tue, Apr 2, 2024 at 5:23 AM Wellington Chevreuil <
> > wellington.chevre...@gmail.com> wrote:
> >
> > > Regarding TestBucketCachePersister flakeyness, I have noticed that last
> > > week and had submitted a fix in
> > > https://issues.apache.org/jira/browse/HBASE-28458.
> > >
> > > Em sex., 29 de mar. de 2024 às 15:41, Bryan Beaudreault <
> > > bbeaudrea...@apache.org> escreveu:
> > >
> > > > Thanks. I pushed the addendum fix to HBASE-27657. I will start
> another
> > RC
> > > > on Monday so that people have time to notice any other issues to
> > include.
> > > >
> > > > On Fri, Mar 29, 2024 at 11:24 AM 张铎(Duo Zhang) <
> palomino...@gmail.com>
> > > > wrote:
> > > >
> > > > > The other parts of the RC are good.
> > > > >
> > > > > I ran all the UTs and also started a mini cluster to test basic
> shell
> > > > > commands, all good.
> > > > >
> > > > > Will vote a +1 after fixing the above compatibility issue.
> > > > >
> > > > > Thanks.
> > > > >
> > > > > Bryan Beaudreault  于2024年3月29日周五 23:10写道:
> > > > > >
> > > > > > Thanks for catching that. I looked at the compatibility report
> but
> > > > missed
> > > > > > that one. I will work on fixing.
> > > > > >
> > > > > > If anyone else wants to take a look for other reasons to sink the
> > > RC, I
> > > > > > will also tackle those before the next one.
> > > > > >
> > > > > > On Fri, Mar 29, 2024 at 11:07 AM 张铎(Duo Zhang) <
> > > palomino...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Sorry but -1 binding
> > > > > > >
> > > > > > > After checking the compatibility report, I found that we made a
> > > > > > > mistake when implementing HBASE-27657.
> > > > > > >
> > > > > > > The 'createConnection(Configuration conf, ExecutorService pool,
> > > final
> > > > > > > User user)' method was lost... We should keep it and make it
> call
> > > the
> > > > > > > newly introduced 'createConnection(Configuration conf,
> > > > ExecutorService
> > > > > > > pool, final User user, Map
> connectionAttributes)'
> > > > > > > method.
> > > > > > > This is an unnecessary incompatible change, we should apply an
> > > > > > > addendum to add this method back.
> > > > > > >
> > > > > > > Thanks.
> > > > > > >
> > > > > > > 张铎(Duo Zhang)  于2024年3月29日周五 22:55写道:
> > > > > > > >
> > > > > > > > OK, I tried several more times, it passed...
> > > > > > > >
> > > > > > > > Bryan Beaudreault  于2024年3月29日周五
> > > 19:21写道:
> > > > > > > >
> > > > > > > > >
> > > > > > > > > TestBucketCachePersister is passing for me locally. I've
> > tried
> > > it
> > > > > a few
> > > > > > > > > times and no issues
> > > > > > > > >
> > > > > > > > > On Thu, Mar 28, 2024 at 9:19 PM 张铎(Duo Zhang) <
> > > > > palomino...@gmail.com>
> > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > TestBucketCachePersister always fail for me locally.
> > > > > > > > > >
> > > > > > > > > > Is this a known issue which is not very critical?
> > > > > > > > > >
> > > > > > > > > > Bryan Beaudreault 
> 于2024年3月28日周四
> > > > > 04:01写道:
> > > > > > > > > > >
> > > > > > > > > > > Please vote on this Apache hbase release candidate,
> > > > > > > > > > > hbase-2.6.0RC2
> > > > > > > > > > >
> > > > > > > > > > > The VOTE will remain open for at least 72 hours.
> > > > > > > > > > >
> > > > > > > > > > > [ ] +1 Release this package as Apache hbase 2.6.0
> > > > > > > > > > > [ ] -1 Do not release this package because ...
> > > > > > > > > > >
> > > > > > > > > > > The tag to be voted on is 2.6.0RC2:
> > > > > > > > > > >
> > > > > > > > > > >   https://github.com/apache/hbase/tree/2.6.0RC2
> > > > > > > > > > >
> > > > > > > > > > > This tag currently points to git reference
> > > > > > > > > > >
> > > > > > > > > > >   413bb6d733f2917ff94ce799306d8ab7c3132373
> > > > > > > > > > >
> > > > > > > > > > > The release files, including signatures, digests, as
> well
> > > as
> > > > > > > CHANGES.md
> > > > > > > > > > > and RELEASENOTES.md included in this RC can be found
> at:
> > > > > > > > > > >
> > > > > > > > > > >
> https://dist.apache.org/repos/dist/dev/hbase/2.6.0RC2/
> > > > > > > > > > >
> > > > > > > > > > > Maven artifacts are available in a staging repository
> at:
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > >
> > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachehbase-1537/
> > > > > > > > > > >
> > > > > > > > > > > Maven artifacts for hadoop3 are available in a staging
> > > > > repository
> > > > > > > at:
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > >
> > > > >
> > >
> 

Re: [VOTE] The first release candidate for 2.6.0 (RC2) is available

2024-04-02 Thread Wellington Chevreuil
I've just got the approval from Duo and merged it. Am cherry-picking to
lower branches now.

Em ter., 2 de abr. de 2024 às 12:02, Bryan Beaudreault <
bbeaudrea...@apache.org> escreveu:

> Thanks Wellington. Was there a reason to only merge that to master?
>
> On Tue, Apr 2, 2024 at 5:23 AM Wellington Chevreuil <
> wellington.chevre...@gmail.com> wrote:
>
> > Regarding TestBucketCachePersister flakeyness, I have noticed that last
> > week and had submitted a fix in
> > https://issues.apache.org/jira/browse/HBASE-28458.
> >
> > Em sex., 29 de mar. de 2024 às 15:41, Bryan Beaudreault <
> > bbeaudrea...@apache.org> escreveu:
> >
> > > Thanks. I pushed the addendum fix to HBASE-27657. I will start another
> RC
> > > on Monday so that people have time to notice any other issues to
> include.
> > >
> > > On Fri, Mar 29, 2024 at 11:24 AM 张铎(Duo Zhang) 
> > > wrote:
> > >
> > > > The other parts of the RC are good.
> > > >
> > > > I ran all the UTs and also started a mini cluster to test basic shell
> > > > commands, all good.
> > > >
> > > > Will vote a +1 after fixing the above compatibility issue.
> > > >
> > > > Thanks.
> > > >
> > > > Bryan Beaudreault  于2024年3月29日周五 23:10写道:
> > > > >
> > > > > Thanks for catching that. I looked at the compatibility report but
> > > missed
> > > > > that one. I will work on fixing.
> > > > >
> > > > > If anyone else wants to take a look for other reasons to sink the
> > RC, I
> > > > > will also tackle those before the next one.
> > > > >
> > > > > On Fri, Mar 29, 2024 at 11:07 AM 张铎(Duo Zhang) <
> > palomino...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Sorry but -1 binding
> > > > > >
> > > > > > After checking the compatibility report, I found that we made a
> > > > > > mistake when implementing HBASE-27657.
> > > > > >
> > > > > > The 'createConnection(Configuration conf, ExecutorService pool,
> > final
> > > > > > User user)' method was lost... We should keep it and make it call
> > the
> > > > > > newly introduced 'createConnection(Configuration conf,
> > > ExecutorService
> > > > > > pool, final User user, Map connectionAttributes)'
> > > > > > method.
> > > > > > This is an unnecessary incompatible change, we should apply an
> > > > > > addendum to add this method back.
> > > > > >
> > > > > > Thanks.
> > > > > >
> > > > > > 张铎(Duo Zhang)  于2024年3月29日周五 22:55写道:
> > > > > > >
> > > > > > > OK, I tried several more times, it passed...
> > > > > > >
> > > > > > > Bryan Beaudreault  于2024年3月29日周五
> > 19:21写道:
> > > > > > >
> > > > > > > >
> > > > > > > > TestBucketCachePersister is passing for me locally. I've
> tried
> > it
> > > > a few
> > > > > > > > times and no issues
> > > > > > > >
> > > > > > > > On Thu, Mar 28, 2024 at 9:19 PM 张铎(Duo Zhang) <
> > > > palomino...@gmail.com>
> > > > > > wrote:
> > > > > > > >
> > > > > > > > > TestBucketCachePersister always fail for me locally.
> > > > > > > > >
> > > > > > > > > Is this a known issue which is not very critical?
> > > > > > > > >
> > > > > > > > > Bryan Beaudreault  于2024年3月28日周四
> > > > 04:01写道:
> > > > > > > > > >
> > > > > > > > > > Please vote on this Apache hbase release candidate,
> > > > > > > > > > hbase-2.6.0RC2
> > > > > > > > > >
> > > > > > > > > > The VOTE will remain open for at least 72 hours.
> > > > > > > > > >
> > > > > > > > > > [ ] +1 Release this package as Apache hbase 2.6.0
> > > > > > > > > > [ ] -1 Do not release this package because ...
> > > > > > > > > >
> > > > > > > > > > The tag to be voted on is 2.6.0RC2:
> > > > > > > > > >
> > > > > > > > > >   https://github.com/apache/hbase/tree/2.6.0RC2
> > > > > > > > > >
> > > > > > > > > > This tag currently points to git reference
> > > > > > > > > >
> > > > > > > > > >   413bb6d733f2917ff94ce799306d8ab7c3132373
> > > > > > > > > >
> > > > > > > > > > The release files, including signatures, digests, as well
> > as
> > > > > > CHANGES.md
> > > > > > > > > > and RELEASENOTES.md included in this RC can be found at:
> > > > > > > > > >
> > > > > > > > > >   https://dist.apache.org/repos/dist/dev/hbase/2.6.0RC2/
> > > > > > > > > >
> > > > > > > > > > Maven artifacts are available in a staging repository at:
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachehbase-1537/
> > > > > > > > > >
> > > > > > > > > > Maven artifacts for hadoop3 are available in a staging
> > > > repository
> > > > > > at:
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachehbase-1538/
> > > > > > > > > >
> > > > > > > > > > Artifacts were signed with the 0x74EFF462 key which can
> be
> > > > found
> > > > > > in:
> > > > > > > > > >
> > > > > > > > > >   https://downloads.apache.org/hbase/KEYS
> > > > > > > > > >
> > > > > > > > > > To learn more about Apache hbase, please see
> > > > > > > > > >
> > > > > > > > > >   http://hbase.apache.org/
> > > > > > > > > >
> > > > > > > > > > 

Re: [VOTE] The first release candidate for 2.6.0 (RC2) is available

2024-04-02 Thread Bryan Beaudreault
Thanks Wellington. Was there a reason to only merge that to master?

On Tue, Apr 2, 2024 at 5:23 AM Wellington Chevreuil <
wellington.chevre...@gmail.com> wrote:

> Regarding TestBucketCachePersister flakeyness, I have noticed that last
> week and had submitted a fix in
> https://issues.apache.org/jira/browse/HBASE-28458.
>
> Em sex., 29 de mar. de 2024 às 15:41, Bryan Beaudreault <
> bbeaudrea...@apache.org> escreveu:
>
> > Thanks. I pushed the addendum fix to HBASE-27657. I will start another RC
> > on Monday so that people have time to notice any other issues to include.
> >
> > On Fri, Mar 29, 2024 at 11:24 AM 张铎(Duo Zhang) 
> > wrote:
> >
> > > The other parts of the RC are good.
> > >
> > > I ran all the UTs and also started a mini cluster to test basic shell
> > > commands, all good.
> > >
> > > Will vote a +1 after fixing the above compatibility issue.
> > >
> > > Thanks.
> > >
> > > Bryan Beaudreault  于2024年3月29日周五 23:10写道:
> > > >
> > > > Thanks for catching that. I looked at the compatibility report but
> > missed
> > > > that one. I will work on fixing.
> > > >
> > > > If anyone else wants to take a look for other reasons to sink the
> RC, I
> > > > will also tackle those before the next one.
> > > >
> > > > On Fri, Mar 29, 2024 at 11:07 AM 张铎(Duo Zhang) <
> palomino...@gmail.com>
> > > > wrote:
> > > >
> > > > > Sorry but -1 binding
> > > > >
> > > > > After checking the compatibility report, I found that we made a
> > > > > mistake when implementing HBASE-27657.
> > > > >
> > > > > The 'createConnection(Configuration conf, ExecutorService pool,
> final
> > > > > User user)' method was lost... We should keep it and make it call
> the
> > > > > newly introduced 'createConnection(Configuration conf,
> > ExecutorService
> > > > > pool, final User user, Map connectionAttributes)'
> > > > > method.
> > > > > This is an unnecessary incompatible change, we should apply an
> > > > > addendum to add this method back.
> > > > >
> > > > > Thanks.
> > > > >
> > > > > 张铎(Duo Zhang)  于2024年3月29日周五 22:55写道:
> > > > > >
> > > > > > OK, I tried several more times, it passed...
> > > > > >
> > > > > > Bryan Beaudreault  于2024年3月29日周五
> 19:21写道:
> > > > > >
> > > > > > >
> > > > > > > TestBucketCachePersister is passing for me locally. I've tried
> it
> > > a few
> > > > > > > times and no issues
> > > > > > >
> > > > > > > On Thu, Mar 28, 2024 at 9:19 PM 张铎(Duo Zhang) <
> > > palomino...@gmail.com>
> > > > > wrote:
> > > > > > >
> > > > > > > > TestBucketCachePersister always fail for me locally.
> > > > > > > >
> > > > > > > > Is this a known issue which is not very critical?
> > > > > > > >
> > > > > > > > Bryan Beaudreault  于2024年3月28日周四
> > > 04:01写道:
> > > > > > > > >
> > > > > > > > > Please vote on this Apache hbase release candidate,
> > > > > > > > > hbase-2.6.0RC2
> > > > > > > > >
> > > > > > > > > The VOTE will remain open for at least 72 hours.
> > > > > > > > >
> > > > > > > > > [ ] +1 Release this package as Apache hbase 2.6.0
> > > > > > > > > [ ] -1 Do not release this package because ...
> > > > > > > > >
> > > > > > > > > The tag to be voted on is 2.6.0RC2:
> > > > > > > > >
> > > > > > > > >   https://github.com/apache/hbase/tree/2.6.0RC2
> > > > > > > > >
> > > > > > > > > This tag currently points to git reference
> > > > > > > > >
> > > > > > > > >   413bb6d733f2917ff94ce799306d8ab7c3132373
> > > > > > > > >
> > > > > > > > > The release files, including signatures, digests, as well
> as
> > > > > CHANGES.md
> > > > > > > > > and RELEASENOTES.md included in this RC can be found at:
> > > > > > > > >
> > > > > > > > >   https://dist.apache.org/repos/dist/dev/hbase/2.6.0RC2/
> > > > > > > > >
> > > > > > > > > Maven artifacts are available in a staging repository at:
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachehbase-1537/
> > > > > > > > >
> > > > > > > > > Maven artifacts for hadoop3 are available in a staging
> > > repository
> > > > > at:
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachehbase-1538/
> > > > > > > > >
> > > > > > > > > Artifacts were signed with the 0x74EFF462 key which can be
> > > found
> > > > > in:
> > > > > > > > >
> > > > > > > > >   https://downloads.apache.org/hbase/KEYS
> > > > > > > > >
> > > > > > > > > To learn more about Apache hbase, please see
> > > > > > > > >
> > > > > > > > >   http://hbase.apache.org/
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Your HBase Release Manager
> > > > > > > >
> > > > >
> > >
> >
>


Re: [VOTE] The first release candidate for 2.6.0 (RC2) is available

2024-04-02 Thread Wellington Chevreuil
Regarding TestBucketCachePersister flakeyness, I have noticed that last
week and had submitted a fix in
https://issues.apache.org/jira/browse/HBASE-28458.

Em sex., 29 de mar. de 2024 às 15:41, Bryan Beaudreault <
bbeaudrea...@apache.org> escreveu:

> Thanks. I pushed the addendum fix to HBASE-27657. I will start another RC
> on Monday so that people have time to notice any other issues to include.
>
> On Fri, Mar 29, 2024 at 11:24 AM 张铎(Duo Zhang) 
> wrote:
>
> > The other parts of the RC are good.
> >
> > I ran all the UTs and also started a mini cluster to test basic shell
> > commands, all good.
> >
> > Will vote a +1 after fixing the above compatibility issue.
> >
> > Thanks.
> >
> > Bryan Beaudreault  于2024年3月29日周五 23:10写道:
> > >
> > > Thanks for catching that. I looked at the compatibility report but
> missed
> > > that one. I will work on fixing.
> > >
> > > If anyone else wants to take a look for other reasons to sink the RC, I
> > > will also tackle those before the next one.
> > >
> > > On Fri, Mar 29, 2024 at 11:07 AM 张铎(Duo Zhang) 
> > > wrote:
> > >
> > > > Sorry but -1 binding
> > > >
> > > > After checking the compatibility report, I found that we made a
> > > > mistake when implementing HBASE-27657.
> > > >
> > > > The 'createConnection(Configuration conf, ExecutorService pool, final
> > > > User user)' method was lost... We should keep it and make it call the
> > > > newly introduced 'createConnection(Configuration conf,
> ExecutorService
> > > > pool, final User user, Map connectionAttributes)'
> > > > method.
> > > > This is an unnecessary incompatible change, we should apply an
> > > > addendum to add this method back.
> > > >
> > > > Thanks.
> > > >
> > > > 张铎(Duo Zhang)  于2024年3月29日周五 22:55写道:
> > > > >
> > > > > OK, I tried several more times, it passed...
> > > > >
> > > > > Bryan Beaudreault  于2024年3月29日周五 19:21写道:
> > > > >
> > > > > >
> > > > > > TestBucketCachePersister is passing for me locally. I've tried it
> > a few
> > > > > > times and no issues
> > > > > >
> > > > > > On Thu, Mar 28, 2024 at 9:19 PM 张铎(Duo Zhang) <
> > palomino...@gmail.com>
> > > > wrote:
> > > > > >
> > > > > > > TestBucketCachePersister always fail for me locally.
> > > > > > >
> > > > > > > Is this a known issue which is not very critical?
> > > > > > >
> > > > > > > Bryan Beaudreault  于2024年3月28日周四
> > 04:01写道:
> > > > > > > >
> > > > > > > > Please vote on this Apache hbase release candidate,
> > > > > > > > hbase-2.6.0RC2
> > > > > > > >
> > > > > > > > The VOTE will remain open for at least 72 hours.
> > > > > > > >
> > > > > > > > [ ] +1 Release this package as Apache hbase 2.6.0
> > > > > > > > [ ] -1 Do not release this package because ...
> > > > > > > >
> > > > > > > > The tag to be voted on is 2.6.0RC2:
> > > > > > > >
> > > > > > > >   https://github.com/apache/hbase/tree/2.6.0RC2
> > > > > > > >
> > > > > > > > This tag currently points to git reference
> > > > > > > >
> > > > > > > >   413bb6d733f2917ff94ce799306d8ab7c3132373
> > > > > > > >
> > > > > > > > The release files, including signatures, digests, as well as
> > > > CHANGES.md
> > > > > > > > and RELEASENOTES.md included in this RC can be found at:
> > > > > > > >
> > > > > > > >   https://dist.apache.org/repos/dist/dev/hbase/2.6.0RC2/
> > > > > > > >
> > > > > > > > Maven artifacts are available in a staging repository at:
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachehbase-1537/
> > > > > > > >
> > > > > > > > Maven artifacts for hadoop3 are available in a staging
> > repository
> > > > at:
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachehbase-1538/
> > > > > > > >
> > > > > > > > Artifacts were signed with the 0x74EFF462 key which can be
> > found
> > > > in:
> > > > > > > >
> > > > > > > >   https://downloads.apache.org/hbase/KEYS
> > > > > > > >
> > > > > > > > To learn more about Apache hbase, please see
> > > > > > > >
> > > > > > > >   http://hbase.apache.org/
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Your HBase Release Manager
> > > > > > >
> > > >
> >
>