Re: [VOTE][RESULT] HttpComponents Client 4.2.3 release based on RC3

2013-01-15 Thread Oleg Kalnichevski
On Mon, 2013-01-14 at 17:49 -0500, Karl Wright wrote:
 Typically when do these artifacts get pushed to Maven, and by whom?
 
 Karl
 

Usually Maven artifacts get promoted from the staging repo to the
official release repo by the release manager shortly after the release
vote has been closed. However, all other bits such as web site updates
might take a while and may not be in place until the official release
announcement.

Oleg   

 On Mon, Jan 14, 2013 at 3:49 PM, Oleg Kalnichevski ol...@apache.org wrote:
  The vote to release HttpComponents Client 4.2.3 has passed with the
  following results
 
  +1 (4 binding votes in total)
  Sebastian Bazley sebb -at- apache.org *
  Oleg Kalnichevski olegk -at- apache.org *
  Karl Wright kwright -at- apache.org
  ant elder antelder -at- apache.org *
  Asankha C. Perera asankha -at- apache.org *
 
  no other votes
 
  * binding votes
 
  Original voting thread:
  http://mail-archives.apache.org/mod_mbox/hc-dev/201301.mbox/%
  3C1357857174.8184.3.camel%40ubuntu%3E
 
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
  For additional commands, e-mail: dev-h...@hc.apache.org
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org
 



-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



HttpClient 4.3a1 release notes

2013-01-15 Thread Oleg Kalnichevski
Folks,

Could someone please proof read the HttpClient 4.3a1 release notes? 

http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/RELEASE_NOTES.txt

I would like to proceed with a formal release and put it on vote soon.

Oleg


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: HttpClient 4.3a1 release notes

2013-01-15 Thread sebb
On 15 January 2013 11:46, Oleg Kalnichevski ol...@apache.org wrote:
 Folks,

 Could someone please proof read the HttpClient 4.3a1 release notes?

Looks fine to me.

 http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/RELEASE_NOTES.txt

 I would like to proceed with a formal release and put it on vote soon.

 Oleg


 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: svn commit: r1433338 - /httpcomponents/project/trunk/pom.xml

2013-01-15 Thread sebb
On 15 January 2013 10:19,  ol...@apache.org wrote:
 Author: olegk
 Date: Tue Jan 15 10:19:55 2013
 New Revision: 148

 URL: http://svn.apache.org/viewvc?rev=148view=rev
 Log:
 Added William Speirs and Karl Wright to the list of committers; externalized 
 repostory, snapshotRepository and site URLs to POM properties that could be 
 overridden through custom profiles

 Modified:
 httpcomponents/project/trunk/pom.xml

 Modified: httpcomponents/project/trunk/pom.xml
 URL: 
 http://svn.apache.org/viewvc/httpcomponents/project/trunk/pom.xml?rev=148r1=147r2=148view=diff
 ==
 --- httpcomponents/project/trunk/pom.xml (original)
 +++ httpcomponents/project/trunk/pom.xml Tue Jan 15 10:19:55 2013
 @@ -192,6 +192,24 @@ Felix bundle plugin updated: 2.3.5 - 2.
  roleCommitter/role
/roles
  /developer
 +developer
 +  nameWilliam Speirs/name
 +  idwspeirs/id
 +  emailwspeirs at apache.org/email
 +  roles
 +roleCommitter/role
 +  /roles
 +  timezone-5/timezone
 +/developer
 +developer
 +  nameKarl Wright/name
 +  idkwright/id
 +  emailkwright -at- apache.org/email
 +  roles
 +roleCommitter/role
 +  /roles
 +  timezone-5/timezone
 +/developer
/developers

contributors
 @@ -278,17 +296,17 @@ Felix bundle plugin updated: 2.3.5 - 2.
  repository
idapache.releases.https/id
nameApache Release Distribution Repository/name
 -  
 urlhttps://repository.apache.org/service/local/staging/deploy/maven2/url
 +  url${asf.repository.url}/url

This one does not have a property in Apache Parent Pom; not sure it
makes sense to allow it to be overridden.

  /repository
  snapshotRepository
idapache.snapshots.https/id
nameApache Development Snapshot Repository/name
 -  urlhttps://repository.apache.org/content/repositories/snapshots/url
 +  url${asf.snapshotRepository.url}/url

Why not use the Apache pom variable, i.e.

distMgmtSnapshotsUrlhttps://repository.apache.org/content/repositories/snapshots/distMgmtSnapshotsUrl

The overrides could be dropped completely if delegated to the Apache Pom.

  /snapshotRepository
  site
idapache.website/id
nameApache Website/name
 -  urlscp://people.apache.org/www/hc.apache.org//url
 +  url${asf.site.url}/url
  /site
/distributionManagement

 @@ -671,6 +689,10 @@ Felix bundle plugin updated: 2.3.5 - 2.
 maven.compile.deprecationtrue/maven.compile.deprecation
 project.build.sourceEncodingUTF-8/project.build.sourceEncoding
 project.reporting.outputEncodingUTF-8/project.reporting.outputEncoding
 +   
 asf.repository.urlhttps://repository.apache.org/service/local/staging/deploy/maven2/asf.repository.url
 +   
 asf.snapshotRepository.urlhttps://repository.apache.org/content/repositories/snapshots/asf.snapshotRepository.url
 +   asf.site.urlscp://people.apache.org/www/hc.apache.org//asf.site.url
 +
 !-- Define the Clover version here - it's needed in pluginManagement 
 here and the reporting sections in modules --
 !-- N.B. It appears that the latest version for which the ASF has a 
 licence is 2.6.3 --
 !-- TODO - try 3.1.0 --



-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: HttpClient 4.3a1 release notes

2013-01-15 Thread Jon Moore
I'm away from my IDE or I'd fix these myself, but just a couple of quick typos:

Reliance on object immutablity - Reliance on object immutability

There is now option - There is now an option

Otherwise looks good.

Jon

On Tue, Jan 15, 2013 at 6:46 AM, Oleg Kalnichevski ol...@apache.org wrote:
 Folks,

 Could someone please proof read the HttpClient 4.3a1 release notes?

 http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/RELEASE_NOTES.txt

 I would like to proceed with a formal release and put it on vote soon.

 Oleg


 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 

Jon Moore

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: svn commit r1433338

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 11:57 +, sebb wrote:
 On 15 January 2013 10:19,  ol...@apache.org wrote:
  Author: olegk
  Date: Tue Jan 15 10:19:55 2013
  New Revision: 148
 
  URL: http://svn.apache.org/viewvc?rev=148view=rev
  Log:
  Added William Speirs and Karl Wright to the list of committers; 
  externalized repostory, snapshotRepository and site URLs to POM properties 
  that could be overridden through custom profiles
 
  Modified:
  httpcomponents/project/trunk/pom.xml
 
  Modified: httpcomponents/project/trunk/pom.xml
  URL: 
  http://svn.apache.org/viewvc/httpcomponents/project/trunk/pom.xml?rev=148r1=147r2=148view=diff
  ==
  --- httpcomponents/project/trunk/pom.xml (original)
  +++ httpcomponents/project/trunk/pom.xml Tue Jan 15 10:19:55 2013
  @@ -192,6 +192,24 @@ Felix bundle plugin updated: 2.3.5 - 2.
   roleCommitter/role
 /roles
   /developer
  +developer
  +  nameWilliam Speirs/name
  +  idwspeirs/id
  +  emailwspeirs at apache.org/email
  +  roles
  +roleCommitter/role
  +  /roles
  +  timezone-5/timezone
  +/developer
  +developer
  +  nameKarl Wright/name
  +  idkwright/id
  +  emailkwright -at- apache.org/email
  +  roles
  +roleCommitter/role
  +  /roles
  +  timezone-5/timezone
  +/developer
 /developers
 
 contributors
  @@ -278,17 +296,17 @@ Felix bundle plugin updated: 2.3.5 - 2.
   repository
 idapache.releases.https/id
 nameApache Release Distribution Repository/name
  -  
  urlhttps://repository.apache.org/service/local/staging/deploy/maven2/url
  +  url${asf.repository.url}/url
 
 This one does not have a property in Apache Parent Pom; not sure it
 makes sense to allow it to be overridden.
 
   /repository
   snapshotRepository
 idapache.snapshots.https/id
 nameApache Development Snapshot Repository/name
  -  
  urlhttps://repository.apache.org/content/repositories/snapshots/url
  +  url${asf.snapshotRepository.url}/url
 
 Why not use the Apache pom variable, i.e.
 
 distMgmtSnapshotsUrlhttps://repository.apache.org/content/repositories/snapshots/distMgmtSnapshotsUrl
 
 The overrides could be dropped completely if delegated to the Apache Pom.
 
   /snapshotRepository
   site
 idapache.website/id
 nameApache Website/name
  -  urlscp://people.apache.org/www/hc.apache.org//url
  +  url${asf.site.url}/url
   /site
 /distributionManagement
 
  @@ -671,6 +689,10 @@ Felix bundle plugin updated: 2.3.5 - 2.
  maven.compile.deprecationtrue/maven.compile.deprecation
  project.build.sourceEncodingUTF-8/project.build.sourceEncoding
  
  project.reporting.outputEncodingUTF-8/project.reporting.outputEncoding
  +   
  asf.repository.urlhttps://repository.apache.org/service/local/staging/deploy/maven2/asf.repository.url
  +   
  asf.snapshotRepository.urlhttps://repository.apache.org/content/repositories/snapshots/asf.snapshotRepository.url
  +   asf.site.urlscp://people.apache.org/www/hc.apache.org//asf.site.url
  +
  !-- Define the Clover version here - it's needed in pluginManagement 
  here and the reporting sections in modules --
  !-- N.B. It appears that the latest version for which the ASF has a 
  licence is 2.6.3 --
  !-- TODO - try 3.1.0 --
 
 
 

I needed a fast solution of some sort in order to be able to publish web
site updates for HttpClient 4.2.3 release. I'd be more than happy to
have our project metadata better aligned with the rest of ASF (at least
in trunks). I might try to get around to it while working on HC 4.3a1
release there are other volunteers.

Oleg



-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: HttpClient 4.3a1 release notes

2013-01-15 Thread Gary Gregory
I made a couple of edits to
https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/RELEASE_NOTES.txt

Gary


On Tue, Jan 15, 2013 at 7:05 AM, Jon Moore j...@jjmoore.net wrote:

 I'm away from my IDE or I'd fix these myself, but just a couple of quick
 typos:

 Reliance on object immutablity - Reliance on object immutability

 There is now option - There is now an option

 Otherwise looks good.

 Jon

 On Tue, Jan 15, 2013 at 6:46 AM, Oleg Kalnichevski ol...@apache.org
 wrote:
  Folks,
 
  Could someone please proof read the HttpClient 4.3a1 release notes?
 
 
 http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/RELEASE_NOTES.txt
 
  I would like to proceed with a formal release and put it on vote soon.
 
  Oleg
 
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
  For additional commands, e-mail: dev-h...@hc.apache.org
 



 --
 
 Jon Moore

 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[jira] [Updated] (HTTPCLIENT-1253) URIBuilder setParameter() method could exceed the HTTP header size.

2013-01-15 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated HTTPCLIENT-1253:
-

Summary: URIBuilder setParameter() method could exceed the HTTP header 
size.(was: URIBuilder setParameter() method could exceed the http header 
size.  )

 URIBuilder setParameter() method could exceed the HTTP header size.  
 -

 Key: HTTPCLIENT-1253
 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1253
 Project: HttpComponents HttpClient
  Issue Type: Improvement
  Components: HttpClient
Affects Versions: 4.2.1
Reporter: Alan T Chen
Priority: Minor
 Fix For: 4.3 Alpha1


 Maybe the URIBuilder is not designed with POST vs GET in mind so it will 
 construct the form parameters into the header by default.  However, this is 
 an issue when the content exceeds what the header allows.
 the following code will cause issues when the length of the parameters exceed 
 the http header.
 // TODO: need to pass in the target host/port
 URIBuilder builder = new URIBuilder();
 
 builder.setScheme(http).setHost(targetHost).setPort(targetPort).setPath(s);
 MapString, String params = 
 getRequestParameters(servletRequest);
 for (String key : params.keySet())
 {
 String value = params.get(key);
 builder.setParameter(key, value);
 }
 httpPost = new HttpPost(builder.build());
  
 I have to fix it by using the httpPost.setEntity() method to ensure the form 
 post will insert all parameters into the body of the http post request 
 instead of the header.
 httpPost = new HttpPost(builder.build());
 MapString, String params = 
 getRequestParameters(servletRequest);
 ListNameValuePair nameValuePairs = new 
 ArrayListNameValuePair(20);
 // add the params
 for (String key : params.keySet())
 {
 String value = params.get(key);
 // only add the http param if both key and value are not 
 null
 if( key != null  value != null )
 nameValuePairs.add(new BasicNameValuePair(key, 
 value));
 }
 httpPost.setEntity( new UrlEncodedFormEntity(nameValuePairs) 
 );

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: execchain package name

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 08:00 -0500, Gary Gregory wrote:
 Hi,
 
 When I see a package name like execchain, I wonder what other kind of
 chains are there aside from execution chains? Would chain be enough, or
 exec?
 
 Gary
 

Most likely, chain or exec would be enough. Feel free to rename the
package.

Cheers

Oleg


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: Use of final keyword

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote:
 Over in Log4J-land, we've discussed [1] the use of the final keyword for
 locals and parameters.
 
 In brief [1]: The final keyword in trunk: sometimes it is used, sometimes
 not. I propose we use it all over consistently.
 
 [1] http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html
 

I tend to use final modifier for method parameters a lot (an old habit
that goes back to my Delphi programming days ;)). If it is done for
local variables (as long as it is done consistently and enforced with
the style check plugin) I would be in favor it. I would not bother with
one time exercise, though.

Oleg


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[ANNOUNCEMENT] HttpComponents HttpClient 4.2.3 GA release

2013-01-15 Thread Oleg Kalnichevski
The HttpComponents project is pleased to announce 4.2.3 GA release of
Apache HttpClient. This is a bug fix release that addresses a number of
issues reported since release 4.2.2. This release also includes a
thoroughly reworked NTLM authentication engine  which should result in a
better compatibility with the newest Microsoft products. 

Users of HttpClient 4.x are advised to upgrade.

---
Download -
http://hc.apache.org/downloads.cgi

Release notes -
http://www.apache.org/dist/httpcomponents/httpclient/RELEASE_NOTES.txt

HttpComponents site -
http://hc.apache.org/

---

About Apache HttpClient

Although the java.net package provides basic functionality for accessing
resources via HTTP, it doesn't provide the full flexibility or
functionality needed by many applications. HttpClient seeks to fill this
void by providing an efficient, up-to-date, and feature-rich package
implementing the client side of the most recent HTTP standards and
recommendations.

Designed for extension while providing robust support for the base HTTP
protocol, HttpClient may be of interest to anyone building HTTP-aware
client applications such as web browsers, web service clients, or
systems that leverage or extend the HTTP protocol for distributed
communication.


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



svnpubsub misery (dropping Maven Clover reports)

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 14:30 +, ol...@apache.org wrote:
 Author: olegk
 Date: Tue Jan 15 14:10:42 2013
 New Revision: 1433427
 
 URL: http://svn.apache.org/viewvc?rev=1433427view=rev
 Log:
 Updated project web site for HttpClient 4.2.3 release
 
 
 [This commit notification would consist of 6158 parts, 
 which exceeds the limit of 50 ones, so it was shortened to the summary.]

I don't know. At the moment the new shiny SvnPubSub thing feels, well,
awkward. It took me close to 4 hours to commit updates to the project
web site. 

The largest chunk of module specific files appear to be Clover coverage
reports. It would help enormously if we did not have to commit those to
the SVN repository. Besides, Clover Maven plugin is a major pain in the
rectum by itself due to compatibility issues with Maven 3. 

I would like to propose Clover reports be removed from the release
process. Clover reports are to be generated independently of the release
process using a separate Maven profile (or maybe even using Gradle).
They could be published to people.apache.org every once in a while, if
desired.

Oleg


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: svn commit r1433338

2013-01-15 Thread sebb
On 15 January 2013 12:08, Oleg Kalnichevski ol...@apache.org wrote:
 On Tue, 2013-01-15 at 11:57 +, sebb wrote:
 On 15 January 2013 10:19,  ol...@apache.org wrote:
  Author: olegk
  Date: Tue Jan 15 10:19:55 2013
  New Revision: 148
 
  URL: http://svn.apache.org/viewvc?rev=148view=rev
  Log:
  Added William Speirs and Karl Wright to the list of committers; 
  externalized repostory, snapshotRepository and site URLs to POM properties 
  that could be overridden through custom profiles
 
  Modified:
  httpcomponents/project/trunk/pom.xml
 
  Modified: httpcomponents/project/trunk/pom.xml
  URL: 
  http://svn.apache.org/viewvc/httpcomponents/project/trunk/pom.xml?rev=148r1=147r2=148view=diff
  ==
  --- httpcomponents/project/trunk/pom.xml (original)
  +++ httpcomponents/project/trunk/pom.xml Tue Jan 15 10:19:55 2013
  @@ -192,6 +192,24 @@ Felix bundle plugin updated: 2.3.5 - 2.
   roleCommitter/role
 /roles
   /developer
  +developer
  +  nameWilliam Speirs/name
  +  idwspeirs/id
  +  emailwspeirs at apache.org/email
  +  roles
  +roleCommitter/role
  +  /roles
  +  timezone-5/timezone
  +/developer
  +developer
  +  nameKarl Wright/name
  +  idkwright/id
  +  emailkwright -at- apache.org/email
  +  roles
  +roleCommitter/role
  +  /roles
  +  timezone-5/timezone
  +/developer
 /developers
 
 contributors
  @@ -278,17 +296,17 @@ Felix bundle plugin updated: 2.3.5 - 2.
   repository
 idapache.releases.https/id
 nameApache Release Distribution Repository/name
  -  
  urlhttps://repository.apache.org/service/local/staging/deploy/maven2/url
  +  url${asf.repository.url}/url

 This one does not have a property in Apache Parent Pom; not sure it
 makes sense to allow it to be overridden.

   /repository
   snapshotRepository
 idapache.snapshots.https/id
 nameApache Development Snapshot Repository/name
  -  
  urlhttps://repository.apache.org/content/repositories/snapshots/url
  +  url${asf.snapshotRepository.url}/url

 Why not use the Apache pom variable, i.e.

 distMgmtSnapshotsUrlhttps://repository.apache.org/content/repositories/snapshots/distMgmtSnapshotsUrl

 The overrides could be dropped completely if delegated to the Apache Pom.

   /snapshotRepository
   site
 idapache.website/id
 nameApache Website/name
  -  urlscp://people.apache.org/www/hc.apache.org//url
  +  url${asf.site.url}/url
   /site
 /distributionManagement
 
  @@ -671,6 +689,10 @@ Felix bundle plugin updated: 2.3.5 - 2.
  maven.compile.deprecationtrue/maven.compile.deprecation
  project.build.sourceEncodingUTF-8/project.build.sourceEncoding
  
  project.reporting.outputEncodingUTF-8/project.reporting.outputEncoding
  +   
  asf.repository.urlhttps://repository.apache.org/service/local/staging/deploy/maven2/asf.repository.url
  +   
  asf.snapshotRepository.urlhttps://repository.apache.org/content/repositories/snapshots/asf.snapshotRepository.url
  +   asf.site.urlscp://people.apache.org/www/hc.apache.org//asf.site.url
  +
  !-- Define the Clover version here - it's needed in pluginManagement 
  here and the reporting sections in modules --
  !-- N.B. It appears that the latest version for which the ASF has a 
  licence is 2.6.3 --
  !-- TODO - try 3.1.0 --
 
 


 I needed a fast solution of some sort in order to be able to publish web
 site updates for HttpClient 4.2.3 release.

OK, but the overrides I was referring to were the snapshot and release
repos, not the website.

The parent pom does not define a site url.

 I'd be more than happy to
 have our project metadata better aligned with the rest of ASF (at least
 in trunks). I might try to get around to it while working on HC 4.3a1
 release there are other volunteers.

 Oleg



 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: svn commit: r1433565 - /httpcomponents/project/trunk/pom.xml

2013-01-15 Thread sebb
On 15 January 2013 18:25, Gary Gregory garydgreg...@gmail.com wrote:
 Can you build?

Did it build before the changes?

 From the project dir, mvn clean test gives me:

 [ERROR] Failed to execute goal
 org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
 (validate) on project httpcomponents-core: An error has occurred in
 Checkstyle report generation. Failed during checkstyle configurat
 ion: cannot initialize module Header - unable to load header file
 asl2.header: asl2.header (The system cannot find the file specified) -
 [Help 1]

 Gary


 On Tue, Jan 15, 2013 at 1:22 PM, s...@apache.org wrote:

 Author: sebb
 Date: Tue Jan 15 18:22:13 2013
 New Revision: 1433565

 URL: http://svn.apache.org/viewvc?rev=1433565view=rev
 Log:
 Add Maven minimum version pre-requisite; update clirr and buildnumber
 plugin versions

 Modified:
 httpcomponents/project/trunk/pom.xml

 Modified: httpcomponents/project/trunk/pom.xml
 URL:
 http://svn.apache.org/viewvc/httpcomponents/project/trunk/pom.xml?rev=1433565r1=1433564r2=1433565view=diff

 ==
 --- httpcomponents/project/trunk/pom.xml (original)
 +++ httpcomponents/project/trunk/pom.xml Tue Jan 15 18:22:13 2013
 @@ -44,6 +44,13 @@


  !--
 +Version 7 - changes since version 6
 +===
 +
 +Added Maven pre-requisite of 2.2.1 (minimum)
 +Clirr 2.3 = 2.5
 +Buildnumber 1.0 = 1.2
 +
  Changes since previous version (5)
  ==

 @@ -526,7 +533,7 @@ Felix bundle plugin updated: 2.3.5 - 2.
  plugin
groupIdorg.codehaus.mojo/groupId
artifactIdbuildnumber-maven-plugin/artifactId
 -  version1.0/version
 +  version1.2/version
  /plugin
  plugin
groupIdorg.codehaus.mojo/groupId
 @@ -675,6 +682,10 @@ Felix bundle plugin updated: 2.3.5 - 2.

   /profiles

 + prerequisites
 +   maven2.2.1/maven
 + /prerequisites
 +
   properties
 maven.compile.source1.5/maven.compile.source
 maven.compile.target1.5/maven.compile.target
 @@ -689,7 +700,7 @@ Felix bundle plugin updated: 2.3.5 - 2.
 !-- TODO - try 3.1.0 --
 clover.version2.6.3/clover.version
 !-- Define versions of all report plugins, because they should match
 usage in pluginManagement and modules --
 -   hc.clirr.version2.3/hc.clirr.version
 +   hc.clirr.version2.5/hc.clirr.version
 hc.javadoc.version2.8/hc.javadoc.version
 hc.jxr.version2.3/hc.jxr.version
 hc.surefire-report.version2.9/hc.surefire-report.version





 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: svn commit: r1433565 - /httpcomponents/project/trunk/pom.xml

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 1:30 PM, sebb seb...@gmail.com wrote:

 On 15 January 2013 18:25, Gary Gregory garydgreg...@gmail.com wrote:
  Can you build?

 Did it build before the changes?


Nope, not before this one :(

Gary



  From the project dir, mvn clean test gives me:
 
  [ERROR] Failed to execute goal
  org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
  (validate) on project httpcomponents-core: An error has occurred in
  Checkstyle report generation. Failed during checkstyle configurat
  ion: cannot initialize module Header - unable to load header file
  asl2.header: asl2.header (The system cannot find the file specified) -
  [Help 1]
 
  Gary
 
 
  On Tue, Jan 15, 2013 at 1:22 PM, s...@apache.org wrote:
 
  Author: sebb
  Date: Tue Jan 15 18:22:13 2013
  New Revision: 1433565
 
  URL: http://svn.apache.org/viewvc?rev=1433565view=rev
  Log:
  Add Maven minimum version pre-requisite; update clirr and buildnumber
  plugin versions
 
  Modified:
  httpcomponents/project/trunk/pom.xml
 
  Modified: httpcomponents/project/trunk/pom.xml
  URL:
 
 http://svn.apache.org/viewvc/httpcomponents/project/trunk/pom.xml?rev=1433565r1=1433564r2=1433565view=diff
 
 
 ==
  --- httpcomponents/project/trunk/pom.xml (original)
  +++ httpcomponents/project/trunk/pom.xml Tue Jan 15 18:22:13 2013
  @@ -44,6 +44,13 @@
 
 
   !--
  +Version 7 - changes since version 6
  +===
  +
  +Added Maven pre-requisite of 2.2.1 (minimum)
  +Clirr 2.3 = 2.5
  +Buildnumber 1.0 = 1.2
  +
   Changes since previous version (5)
   ==
 
  @@ -526,7 +533,7 @@ Felix bundle plugin updated: 2.3.5 - 2.
   plugin
 groupIdorg.codehaus.mojo/groupId
 artifactIdbuildnumber-maven-plugin/artifactId
  -  version1.0/version
  +  version1.2/version
   /plugin
   plugin
 groupIdorg.codehaus.mojo/groupId
  @@ -675,6 +682,10 @@ Felix bundle plugin updated: 2.3.5 - 2.
 
/profiles
 
  + prerequisites
  +   maven2.2.1/maven
  + /prerequisites
  +
properties
  maven.compile.source1.5/maven.compile.source
  maven.compile.target1.5/maven.compile.target
  @@ -689,7 +700,7 @@ Felix bundle plugin updated: 2.3.5 - 2.
  !-- TODO - try 3.1.0 --
  clover.version2.6.3/clover.version
  !-- Define versions of all report plugins, because they should
 match
  usage in pluginManagement and modules --
  -   hc.clirr.version2.3/hc.clirr.version
  +   hc.clirr.version2.5/hc.clirr.version
  hc.javadoc.version2.8/hc.javadoc.version
  hc.jxr.version2.3/hc.jxr.version
  hc.surefire-report.version2.9/hc.surefire-report.version
 
 
 
 
 
  --
  E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
  JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
  Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
  Blog: http://garygregory.wordpress.com
  Home: http://garygregory.com/
  Tweet! http://twitter.com/GaryGregory

 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org wrote:

 On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote:
  Over in Log4J-land, we've discussed [1] the use of the final keyword for
  locals and parameters.
 
  In brief [1]: The final keyword in trunk: sometimes it is used, sometimes
  not. I propose we use it all over consistently.
 
  [1]
 http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html
 

 I tend to use final modifier for method parameters a lot (an old habit
 that goes back to my Delphi programming days ;)).


Done in trunk (revision 1433569).

Gary


 If it is done for
 local variables (as long as it is done consistently and enforced with
 the style check plugin) I would be in favor it. I would not bother with
 one time exercise, though.

 Oleg


 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: trunk build error

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 12:12 -0500, Gary Gregory wrote:
 Hi,
 
 I get:
 
 [ERROR] Failed to execute goal
 org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
 (validate) on project httpcomponents-core: An error has occurred in
 Checkstyle report generation. Failed during checkstyle configurat
 ion: cannot initialize module Header - unable to load header file
 asl2.header: asl2.header (The system cannot find the file specified) -
 [Help 1]
 
 Did someone forget to commit asl2.header?
 
 Gary
 

Trunk passes style checks for me (after fixing tabs introduced by a
previous commit). The asl2.header file seems to be at the right place.

Oleg


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 3:03 PM, Oleg Kalnichevski ol...@apache.org wrote:

 On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote:
  On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org
 wrote:
 
   On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote:
Over in Log4J-land, we've discussed [1] the use of the final keyword
 for
locals and parameters.
   
In brief [1]: The final keyword in trunk: sometimes it is used,
 sometimes
not. I propose we use it all over consistently.
   
[1]
   http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html
   
  
   I tend to use final modifier for method parameters a lot (an old habit
   that goes back to my Delphi programming days ;)).
 
 
  Done in trunk (revision 1433569).
 
  Gary
 

 Gary

 Could you please configure your IDE to use spaces instead of tabs?


I thought I had! Crud. Will do.

Gary



 Oleg


 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 3:35 PM, Gary Gregory garydgreg...@gmail.comwrote:

 On Tue, Jan 15, 2013 at 3:03 PM, Oleg Kalnichevski ol...@apache.orgwrote:

 On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote:
  On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org
 wrote:
 
   On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote:
Over in Log4J-land, we've discussed [1] the use of the final
 keyword for
locals and parameters.
   
In brief [1]: The final keyword in trunk: sometimes it is used,
 sometimes
not. I propose we use it all over consistently.
   
[1]
  
 http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html
   
  
   I tend to use final modifier for method parameters a lot (an old habit
   that goes back to my Delphi programming days ;)).
 
 
  Done in trunk (revision 1433569).
 
  Gary
 

 Gary

 Could you please configure your IDE to use spaces instead of tabs?


 I thought I had! Crud. Will do.


How many spaces per 'tab' do you use?

Gary



 Gary





 Oleg


 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: trunk build error

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 3:10 PM, Oleg Kalnichevski ol...@apache.org wrote:

 On Tue, 2013-01-15 at 12:12 -0500, Gary Gregory wrote:
  Hi,
 
  I get:
 
  [ERROR] Failed to execute goal
  org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
  (validate) on project httpcomponents-core: An error has occurred in
  Checkstyle report generation. Failed during checkstyle configurat
  ion: cannot initialize module Header - unable to load header file
  asl2.header: asl2.header (The system cannot find the file specified) -
  [Help 1]
 
  Did someone forget to commit asl2.header?
 
  Gary
 

 Trunk passes style checks for me (after fixing tabs introduced by a
 previous commit). The asl2.header file seems to be at the right place.


Weird, I wonder what is wrong on my end then. I have in
C:\svn\org\apache\httpcomponents\trunk the following dirs:

httpasync
httpasyncclient
httpclient
httpcore
httpcore-benchmark
httpcore-contrib
project

To get the error, I do:

cd project
mvn clean test

Can you try that?

Gary



 Oleg


 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Use of final keyword

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 15:40 -0500, Gary Gregory wrote:
 On Tue, Jan 15, 2013 at 3:35 PM, Gary Gregory garydgreg...@gmail.comwrote:
 
  On Tue, Jan 15, 2013 at 3:03 PM, Oleg Kalnichevski ol...@apache.orgwrote:
 
  On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote:
   On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org
  wrote:
  
On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote:
 Over in Log4J-land, we've discussed [1] the use of the final
  keyword for
 locals and parameters.

 In brief [1]: The final keyword in trunk: sometimes it is used,
  sometimes
 not. I propose we use it all over consistently.

 [1]
   
  http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html

   
I tend to use final modifier for method parameters a lot (an old habit
that goes back to my Delphi programming days ;)).
  
  
   Done in trunk (revision 1433569).
  
   Gary
  
 
  Gary
 
  Could you please configure your IDE to use spaces instead of tabs?
 
 
  I thought I had! Crud. Will do.
 
 
 How many spaces per 'tab' do you use?
 

I use 4 spaces.

Oleg



-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: trunk build error

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 15:46 -0500, Gary Gregory wrote:
 On Tue, Jan 15, 2013 at 3:10 PM, Oleg Kalnichevski ol...@apache.org wrote:
 
  On Tue, 2013-01-15 at 12:12 -0500, Gary Gregory wrote:
   Hi,
  
   I get:
  
   [ERROR] Failed to execute goal
   org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
   (validate) on project httpcomponents-core: An error has occurred in
   Checkstyle report generation. Failed during checkstyle configurat
   ion: cannot initialize module Header - unable to load header file
   asl2.header: asl2.header (The system cannot find the file specified) -
   [Help 1]
  
   Did someone forget to commit asl2.header?
  
   Gary
  
 
  Trunk passes style checks for me (after fixing tabs introduced by a
  previous commit). The asl2.header file seems to be at the right place.
 
 
 Weird, I wonder what is wrong on my end then. I have in
 C:\svn\org\apache\httpcomponents\trunk the following dirs:
 
 httpasync
 httpasyncclient
 httpclient
 httpcore
 httpcore-benchmark
 httpcore-contrib
 project
 
 To get the error, I do:
 
 cd project
 mvn clean test
 
 Can you try that?
 
 Gary
 

I am getting the same error. I could work this problem around by coping
asl2.header to 'project'. Once the style checks are more or less stable
they can be put into a separate binary artifact and re-used by all
modules without having to duplicate the style check definitions and
redundant copies of the asl2.header file.

Oleg


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: trunk build error

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 3:58 PM, Oleg Kalnichevski ol...@apache.org wrote:

 On Tue, 2013-01-15 at 15:46 -0500, Gary Gregory wrote:
  On Tue, Jan 15, 2013 at 3:10 PM, Oleg Kalnichevski ol...@apache.org
 wrote:
 
   On Tue, 2013-01-15 at 12:12 -0500, Gary Gregory wrote:
Hi,
   
I get:
   
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
(validate) on project httpcomponents-core: An error has occurred in
Checkstyle report generation. Failed during checkstyle configurat
ion: cannot initialize module Header - unable to load header file
asl2.header: asl2.header (The system cannot find the file specified)
 -
[Help 1]
   
Did someone forget to commit asl2.header?
   
Gary
   
  
   Trunk passes style checks for me (after fixing tabs introduced by a
   previous commit). The asl2.header file seems to be at the right place.
  
 
  Weird, I wonder what is wrong on my end then. I have in
  C:\svn\org\apache\httpcomponents\trunk the following dirs:
 
  httpasync
  httpasyncclient
  httpclient
  httpcore
  httpcore-benchmark
  httpcore-contrib
  project
 
  To get the error, I do:
 
  cd project
  mvn clean test
 
  Can you try that?
 
  Gary
 

 I am getting the same error. I could work this problem around by coping
 asl2.header to 'project'. Once the style checks are more or less stable
 they can be put into a separate binary artifact and re-used by all
 modules without having to duplicate the style check definitions and
 redundant copies of the asl2.header file.


Avoiding redundancies would be good.

Gary



 Oleg


 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: trunk build error

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 16:21 -0500, Gary Gregory wrote:
 On Tue, Jan 15, 2013 at 3:58 PM, Oleg Kalnichevski ol...@apache.org wrote:
 
  On Tue, 2013-01-15 at 15:46 -0500, Gary Gregory wrote:
   On Tue, Jan 15, 2013 at 3:10 PM, Oleg Kalnichevski ol...@apache.org
  wrote:
  
On Tue, 2013-01-15 at 12:12 -0500, Gary Gregory wrote:
 Hi,

 I get:

 [ERROR] Failed to execute goal
 org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
 (validate) on project httpcomponents-core: An error has occurred in
 Checkstyle report generation. Failed during checkstyle configurat
 ion: cannot initialize module Header - unable to load header file
 asl2.header: asl2.header (The system cannot find the file specified)
  -
 [Help 1]

 Did someone forget to commit asl2.header?

 Gary

   
Trunk passes style checks for me (after fixing tabs introduced by a
previous commit). The asl2.header file seems to be at the right place.
   
  
   Weird, I wonder what is wrong on my end then. I have in
   C:\svn\org\apache\httpcomponents\trunk the following dirs:
  
   httpasync
   httpasyncclient
   httpclient
   httpcore
   httpcore-benchmark
   httpcore-contrib
   project
  
   To get the error, I do:
  
   cd project
   mvn clean test
  
   Can you try that?
  
   Gary
  
 
  I am getting the same error. I could work this problem around by coping
  asl2.header to 'project'. Once the style checks are more or less stable
  they can be put into a separate binary artifact and re-used by all
  modules without having to duplicate the style check definitions and
  redundant copies of the asl2.header file.
 
 
 Avoiding redundancies would be good.
 
 Gary
 
 

Agreed. At the same time it would be enormously painful to have a call
for a release vote after each little style check tweak.

Oleg



-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Clover 3.1.x license is now available!!! was Re: svnpubsub misery (dropping Maven Clover reports)

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 16:26 +, sebb wrote:
 On 15 January 2013 15:13, Oleg Kalnichevski ol...@apache.org wrote:
  On Tue, 2013-01-15 at 14:30 +, ol...@apache.org wrote:
  Author: olegk
  Date: Tue Jan 15 14:10:42 2013
  New Revision: 1433427
 
  URL: http://svn.apache.org/viewvc?rev=1433427view=rev
  Log:
  Updated project web site for HttpClient 4.2.3 release
 
 
  [This commit notification would consist of 6158 parts,
  which exceeds the limit of 50 ones, so it was shortened to the summary.]
 
  I don't know. At the moment the new shiny SvnPubSub thing feels, well,
  awkward. It took me close to 4 hours to commit updates to the project
  web site.
 
  The largest chunk of module specific files appear to be Clover coverage
  reports. It would help enormously if we did not have to commit those to
  the SVN repository. Besides, Clover Maven plugin is a major pain in the
  rectum by itself due to compatibility issues with Maven 3.
 
  I would like to propose Clover reports be removed from the release
  process. Clover reports are to be generated independently of the release
  process using a separate Maven profile (or maybe even using Gradle).
 
 OK by me.
 A separate profile would be easy to use and should be fairly simple to
 implement.
 
  They could be published to people.apache.org every once in a while, if
  desired.
 
 That may not be possible long-term, as infra want to limit the need
 for shell access to minotaur.
 
  Oleg
 


Hallelujah! Clover 3.1.x license is now available to the ASF committers.
Upgrading to clover plugin 3.1.10 fixed all Clover issues.

We can now mandate the use of Maven 3.0.x for building trunks of all HC
modules.

Oleg 

 


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: trunk build error

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 4:31 PM, Oleg Kalnichevski ol...@apache.org wrote:

 On Tue, 2013-01-15 at 16:21 -0500, Gary Gregory wrote:
  On Tue, Jan 15, 2013 at 3:58 PM, Oleg Kalnichevski ol...@apache.org
 wrote:
 
   On Tue, 2013-01-15 at 15:46 -0500, Gary Gregory wrote:
On Tue, Jan 15, 2013 at 3:10 PM, Oleg Kalnichevski ol...@apache.org
 
   wrote:
   
 On Tue, 2013-01-15 at 12:12 -0500, Gary Gregory wrote:
  Hi,
 
  I get:
 
  [ERROR] Failed to execute goal
  org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
  (validate) on project httpcomponents-core: An error has occurred
 in
  Checkstyle report generation. Failed during checkstyle configurat
  ion: cannot initialize module Header - unable to load header file
  asl2.header: asl2.header (The system cannot find the file
 specified)
   -
  [Help 1]
 
  Did someone forget to commit asl2.header?
 
  Gary
 

 Trunk passes style checks for me (after fixing tabs introduced by a
 previous commit). The asl2.header file seems to be at the right
 place.

   
Weird, I wonder what is wrong on my end then. I have in
C:\svn\org\apache\httpcomponents\trunk the following dirs:
   
httpasync
httpasyncclient
httpclient
httpcore
httpcore-benchmark
httpcore-contrib
project
   
To get the error, I do:
   
cd project
mvn clean test
   
Can you try that?
   
Gary
   
  
   I am getting the same error. I could work this problem around by coping
   asl2.header to 'project'. Once the style checks are more or less stable
   they can be put into a separate binary artifact and re-used by all
   modules without having to duplicate the style check definitions and
   redundant copies of the asl2.header file.
  
 
  Avoiding redundancies would be good.
 
  Gary
 
 

 Agreed. At the same time it would be enormously painful to have a call
 for a release vote after each little style check tweak.


I do not understand this last point.

Gary


 Oleg



 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: trunk build error

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 4:52 PM, Gary Gregory garydgreg...@gmail.comwrote:

 On Tue, Jan 15, 2013 at 4:31 PM, Oleg Kalnichevski ol...@apache.orgwrote:

 On Tue, 2013-01-15 at 16:21 -0500, Gary Gregory wrote:
  On Tue, Jan 15, 2013 at 3:58 PM, Oleg Kalnichevski ol...@apache.org
 wrote:
 
   On Tue, 2013-01-15 at 15:46 -0500, Gary Gregory wrote:
On Tue, Jan 15, 2013 at 3:10 PM, Oleg Kalnichevski 
 ol...@apache.org
   wrote:
   
 On Tue, 2013-01-15 at 12:12 -0500, Gary Gregory wrote:
  Hi,
 
  I get:
 
  [ERROR] Failed to execute goal
 
 org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
  (validate) on project httpcomponents-core: An error has
 occurred in
  Checkstyle report generation. Failed during checkstyle
 configurat
  ion: cannot initialize module Header - unable to load header
 file
  asl2.header: asl2.header (The system cannot find the file
 specified)
   -
  [Help 1]
 
  Did someone forget to commit asl2.header?
 
  Gary
 

 Trunk passes style checks for me (after fixing tabs introduced by
 a
 previous commit). The asl2.header file seems to be at the right
 place.

   
Weird, I wonder what is wrong on my end then. I have in
C:\svn\org\apache\httpcomponents\trunk the following dirs:
   
httpasync
httpasyncclient
httpclient
httpcore
httpcore-benchmark
httpcore-contrib
project
   
To get the error, I do:
   
cd project
mvn clean test
   
Can you try that?
   
Gary
   
  
   I am getting the same error. I could work this problem around by
 coping
   asl2.header to 'project'. Once the style checks are more or less
 stable
   they can be put into a separate binary artifact and re-used by all
   modules without having to duplicate the style check definitions and
   redundant copies of the asl2.header file.
  
 
  Avoiding redundancies would be good.


Oh, now I do.

Yes, that is crazy. Duplicate files it is then.

Gary


 
  Gary
 
 

 Agreed. At the same time it would be enormously painful to have a call
 for a release vote after each little style check tweak.


 I do not understand this last point.

 Gary


 Oleg



 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Clover 3.1.x license is now available!!! was Re: svnpubsub misery (dropping Maven Clover reports)

2013-01-15 Thread Gary Gregory
Where is our Clover license?

G


On Tue, Jan 15, 2013 at 4:52 PM, Oleg Kalnichevski ol...@apache.org wrote:

 On Tue, 2013-01-15 at 16:26 +, sebb wrote:
  On 15 January 2013 15:13, Oleg Kalnichevski ol...@apache.org wrote:
   On Tue, 2013-01-15 at 14:30 +, ol...@apache.org wrote:
   Author: olegk
   Date: Tue Jan 15 14:10:42 2013
   New Revision: 1433427
  
   URL: http://svn.apache.org/viewvc?rev=1433427view=rev
   Log:
   Updated project web site for HttpClient 4.2.3 release
  
  
   [This commit notification would consist of 6158 parts,
   which exceeds the limit of 50 ones, so it was shortened to the
 summary.]
  
   I don't know. At the moment the new shiny SvnPubSub thing feels, well,
   awkward. It took me close to 4 hours to commit updates to the project
   web site.
  
   The largest chunk of module specific files appear to be Clover coverage
   reports. It would help enormously if we did not have to commit those to
   the SVN repository. Besides, Clover Maven plugin is a major pain in the
   rectum by itself due to compatibility issues with Maven 3.
  
   I would like to propose Clover reports be removed from the release
   process. Clover reports are to be generated independently of the
 release
   process using a separate Maven profile (or maybe even using Gradle).
 
  OK by me.
  A separate profile would be easy to use and should be fairly simple to
  implement.
 
   They could be published to people.apache.org every once in a while, if
   desired.
 
  That may not be possible long-term, as infra want to limit the need
  for shell access to minotaur.
 
   Oleg
  


 Hallelujah! Clover 3.1.x license is now available to the ASF committers.
 Upgrading to clover plugin 3.1.10 fixed all Clover issues.

 We can now mandate the use of Maven 3.0.x for building trunks of all HC
 modules.

 Oleg




 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Clover 3.1.x license is now available!!! was Re: svnpubsub misery (dropping Maven Clover reports)

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 16:54 -0500, Gary Gregory wrote:
 Where is our Clover license?
 
 G
 

The same place

https://svn.apache.org/repos/private/committers/donated-licenses/clover

Oleg

 
 On Tue, Jan 15, 2013 at 4:52 PM, Oleg Kalnichevski ol...@apache.org wrote:
 
  On Tue, 2013-01-15 at 16:26 +, sebb wrote:
   On 15 January 2013 15:13, Oleg Kalnichevski ol...@apache.org wrote:
On Tue, 2013-01-15 at 14:30 +, ol...@apache.org wrote:
Author: olegk
Date: Tue Jan 15 14:10:42 2013
New Revision: 1433427
   
URL: http://svn.apache.org/viewvc?rev=1433427view=rev
Log:
Updated project web site for HttpClient 4.2.3 release
   
   
[This commit notification would consist of 6158 parts,
which exceeds the limit of 50 ones, so it was shortened to the
  summary.]
   
I don't know. At the moment the new shiny SvnPubSub thing feels, well,
awkward. It took me close to 4 hours to commit updates to the project
web site.
   
The largest chunk of module specific files appear to be Clover coverage
reports. It would help enormously if we did not have to commit those to
the SVN repository. Besides, Clover Maven plugin is a major pain in the
rectum by itself due to compatibility issues with Maven 3.
   
I would like to propose Clover reports be removed from the release
process. Clover reports are to be generated independently of the
  release
process using a separate Maven profile (or maybe even using Gradle).
  
   OK by me.
   A separate profile would be easy to use and should be fairly simple to
   implement.
  
They could be published to people.apache.org every once in a while, if
desired.
  
   That may not be possible long-term, as infra want to limit the need
   for shell access to minotaur.
  
Oleg
   
 
 
  Hallelujah! Clover 3.1.x license is now available to the ASF committers.
  Upgrading to clover plugin 3.1.10 fixed all Clover issues.
 
  We can now mandate the use of Maven 3.0.x for building trunks of all HC
  modules.
 
  Oleg
 
 
 
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
  For additional commands, e-mail: dev-h...@hc.apache.org
 
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[continuum] BUILD FAILURE: Apache HttpComponents - HttpComponents - Non-recursive build

2013-01-15 Thread Continuum@vmbuild
Online report : 
http://vmbuild.apache.org/continuum/buildResult.action?buildId=25796projectId=128

Build statistics:
  State: Failed
  Previous State: Ok
  Started at: Tue 15 Jan 2013 23:01:52 +
  Finished at: Tue 15 Jan 2013 23:01:54 +
  Total time: 1s
  Build Trigger: Schedule
  Build Number: 76
  Exit code: 1
  Building machine hostname: vmbuild
  Operating system : Linux(unknown)
  Java Home version : 
  java version 1.6.0_30
  Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
  Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

  Builder version :
  Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+)
  Java version: 1.6.0_30
  Java home: /usr/lib/jvm/jdk1.6.0_30/jre
  Default locale: en_AU, platform encoding: UTF-8
  OS name: linux version: 2.6.32-41-server arch: amd64 Family: 
unix


SCM Changes:

Changed: olegk @ Tue 15 Jan 2013 22:07:45 +
Comment: Set Maven 3.0.3 as a pre-requisite; added stylecheck plugin 2.9.1;  
upgraded Clover version to 3.1.10; added optional Clover profile
Files changed:
  /httpcomponents/project/trunk/pom.xml ( 1433690 )


Dependencies Changes:

No dependencies changed



Build Definition:

POM filename: pom.xml
Goals: clean install   
Arguments: --batch-mode --non-recursive
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: DEFAULT_SCHEDULE
Profile Name: Maven 2.2.1
Description: Non-recursive build


Test Summary:

Tests: 0
Failures: 0
Errors: 0
Total time: 0.0




-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



[continuum] BUILD FAILURE: Apache HttpComponents - HttpComponents Core - Default Maven 2 Build Definition

2013-01-15 Thread Continuum@vmbuild
Online report : 
http://vmbuild.apache.org/continuum/buildResult.action?buildId=25798projectId=66

Build statistics:
  State: Failed
  Previous State: Ok
  Started at: Tue 15 Jan 2013 23:03:01 +
  Finished at: Tue 15 Jan 2013 23:03:39 +
  Total time: 38s
  Build Trigger: Schedule
  Build Number: 347
  Exit code: 1
  Building machine hostname: vmbuild
  Operating system : Linux(unknown)
  Java Home version : 
  java version 1.6.0_30
  Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
  Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

  Builder version :
  Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+)
  Java version: 1.6.0_30
  Java home: /usr/lib/jvm/jdk1.6.0_30/jre
  Default locale: en_AU, platform encoding: UTF-8
  OS name: linux version: 2.6.32-41-server arch: amd64 Family: 
unix


SCM Changes:

Changed: olegk @ Tue 15 Jan 2013 22:16:06 +
Comment: Updated build instructions; Maven 3.0.3+ is not required; upgraded 
Clover plugin to 3.1.10
Files changed:
  /httpcomponents/httpcore/trunk/BUILDING.txt ( 1433699 )
  /httpcomponents/httpcore/trunk/pom.xml ( 1433699 )

Changed: olegk @ Tue 15 Jan 2013 22:20:08 +
Comment: Fixed style check violations (tabs introduced by a previous commit)
Files changed:
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/HttpHost.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/DefaultConnectionReuseStrategy.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/EnglishReasonPhraseCatalog.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ChunkedOutputStream.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderElement.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderIterator.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueFormatter.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueParser.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineFormatter.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineParser.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicListHeaderIterator.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicNameValuePair.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicTokenIterator.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/RouteSpecificPool.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/VersionInfo.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/codecs/TestIdentityDecoder.java
 ( 1433704 )
  
/httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/codecs/TestLengthDelimitedDecoder.java
 ( 1433704 )


Dependencies Changes:

No dependencies changed



Build Definition:

POM filename: pom.xml
Goals: clean deploy   
Arguments: --batch-mode
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: DEFAULT_SCHEDULE
Profile Name: Maven 2.2.1
Description: Default Maven 2 Build Definition


Test Summary:

Tests: 957
Failures: 0
Errors: 0
Success Rate: 100
Total time: 31.161003




-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: svn commit: r1433565 - /httpcomponents/project/trunk/pom.xml

2013-01-15 Thread sebb
On 15 January 2013 18:41, Gary Gregory garydgreg...@gmail.com wrote:
 On Tue, Jan 15, 2013 at 1:30 PM, sebb seb...@gmail.com wrote:

 On 15 January 2013 18:25, Gary Gregory garydgreg...@gmail.com wrote:
  Can you build?

 Did it build before the changes?


 Nope, not before this one :(

In that case I don't understand what your question has to do with my change?

 Gary



  From the project dir, mvn clean test gives me:
 
  [ERROR] Failed to execute goal
  org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
  (validate) on project httpcomponents-core: An error has occurred in
  Checkstyle report generation. Failed during checkstyle configurat
  ion: cannot initialize module Header - unable to load header file
  asl2.header: asl2.header (The system cannot find the file specified) -
  [Help 1]
 
  Gary
 
 
  On Tue, Jan 15, 2013 at 1:22 PM, s...@apache.org wrote:
 
  Author: sebb
  Date: Tue Jan 15 18:22:13 2013
  New Revision: 1433565
 
  URL: http://svn.apache.org/viewvc?rev=1433565view=rev
  Log:
  Add Maven minimum version pre-requisite; update clirr and buildnumber
  plugin versions
 
  Modified:
  httpcomponents/project/trunk/pom.xml
 
  Modified: httpcomponents/project/trunk/pom.xml
  URL:
 
 http://svn.apache.org/viewvc/httpcomponents/project/trunk/pom.xml?rev=1433565r1=1433564r2=1433565view=diff
 
 
 ==
  --- httpcomponents/project/trunk/pom.xml (original)
  +++ httpcomponents/project/trunk/pom.xml Tue Jan 15 18:22:13 2013
  @@ -44,6 +44,13 @@
 
 
   !--
  +Version 7 - changes since version 6
  +===
  +
  +Added Maven pre-requisite of 2.2.1 (minimum)
  +Clirr 2.3 = 2.5
  +Buildnumber 1.0 = 1.2
  +
   Changes since previous version (5)
   ==
 
  @@ -526,7 +533,7 @@ Felix bundle plugin updated: 2.3.5 - 2.
   plugin
 groupIdorg.codehaus.mojo/groupId
 artifactIdbuildnumber-maven-plugin/artifactId
  -  version1.0/version
  +  version1.2/version
   /plugin
   plugin
 groupIdorg.codehaus.mojo/groupId
  @@ -675,6 +682,10 @@ Felix bundle plugin updated: 2.3.5 - 2.
 
/profiles
 
  + prerequisites
  +   maven2.2.1/maven
  + /prerequisites
  +
properties
  maven.compile.source1.5/maven.compile.source
  maven.compile.target1.5/maven.compile.target
  @@ -689,7 +700,7 @@ Felix bundle plugin updated: 2.3.5 - 2.
  !-- TODO - try 3.1.0 --
  clover.version2.6.3/clover.version
  !-- Define versions of all report plugins, because they should
 match
  usage in pluginManagement and modules --
  -   hc.clirr.version2.3/hc.clirr.version
  +   hc.clirr.version2.5/hc.clirr.version
  hc.javadoc.version2.8/hc.javadoc.version
  hc.jxr.version2.3/hc.jxr.version
  hc.surefire-report.version2.9/hc.surefire-report.version
 
 
 
 
 
  --
  E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
  JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
  Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
  Blog: http://garygregory.wordpress.com
  Home: http://garygregory.com/
  Tweet! http://twitter.com/GaryGregory

 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: svn commit: r1433565 - /httpcomponents/project/trunk/pom.xml

2013-01-15 Thread Gary Gregory
On Jan 15, 2013, at 20:06, sebb seb...@gmail.com  wrote:

 On 15 January 2013 18:41, Gary Gregory garydgreg...@gmail.com wrote:
 On Tue, Jan 15, 2013 at 1:30 PM, sebb seb...@gmail.com wrote:

 On 15 January 2013 18:25, Gary Gregory garydgreg...@gmail.com wrote:
 Can you build?

 Did it build before the changes?


 Nope, not before this one :(

 In that case I don't understand what your question has to do with my change?

Personally, I would want to know that POM change does not break the
build. So I assumed that the build worked for you and that you tested
the POM change locally.

G


 Gary



 From the project dir, mvn clean test gives me:

 [ERROR] Failed to execute goal
 org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
 (validate) on project httpcomponents-core: An error has occurred in
 Checkstyle report generation. Failed during checkstyle configurat
 ion: cannot initialize module Header - unable to load header file
 asl2.header: asl2.header (The system cannot find the file specified) -
 [Help 1]

 Gary


 On Tue, Jan 15, 2013 at 1:22 PM, s...@apache.org wrote:

 Author: sebb
 Date: Tue Jan 15 18:22:13 2013
 New Revision: 1433565

 URL: http://svn.apache.org/viewvc?rev=1433565view=rev
 Log:
 Add Maven minimum version pre-requisite; update clirr and buildnumber
 plugin versions

 Modified:
httpcomponents/project/trunk/pom.xml

 Modified: httpcomponents/project/trunk/pom.xml
 URL:

 http://svn.apache.org/viewvc/httpcomponents/project/trunk/pom.xml?rev=1433565r1=1433564r2=1433565view=diff


 ==
 --- httpcomponents/project/trunk/pom.xml (original)
 +++ httpcomponents/project/trunk/pom.xml Tue Jan 15 18:22:13 2013
 @@ -44,6 +44,13 @@


 !--
 +Version 7 - changes since version 6
 +===
 +
 +Added Maven pre-requisite of 2.2.1 (minimum)
 +Clirr 2.3 = 2.5
 +Buildnumber 1.0 = 1.2
 +
 Changes since previous version (5)
 ==

 @@ -526,7 +533,7 @@ Felix bundle plugin updated: 2.3.5 - 2.
 plugin
   groupIdorg.codehaus.mojo/groupId
   artifactIdbuildnumber-maven-plugin/artifactId
 -  version1.0/version
 +  version1.2/version
 /plugin
 plugin
   groupIdorg.codehaus.mojo/groupId
 @@ -675,6 +682,10 @@ Felix bundle plugin updated: 2.3.5 - 2.

  /profiles

 + prerequisites
 +   maven2.2.1/maven
 + /prerequisites
 +
  properties
maven.compile.source1.5/maven.compile.source
maven.compile.target1.5/maven.compile.target
 @@ -689,7 +700,7 @@ Felix bundle plugin updated: 2.3.5 - 2.
!-- TODO - try 3.1.0 --
clover.version2.6.3/clover.version
!-- Define versions of all report plugins, because they should
 match
 usage in pluginManagement and modules --
 -   hc.clirr.version2.3/hc.clirr.version
 +   hc.clirr.version2.5/hc.clirr.version
hc.javadoc.version2.8/hc.javadoc.version
hc.jxr.version2.3/hc.jxr.version
hc.surefire-report.version2.9/hc.surefire-report.version





 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory

 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory

 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: trunk build error

2013-01-15 Thread Gary Gregory
FYI: I added the asl header file to the 'project' project and now the build
is OK.

Gary


On Tue, Jan 15, 2013 at 4:54 PM, Gary Gregory garydgreg...@gmail.comwrote:

 On Tue, Jan 15, 2013 at 4:52 PM, Gary Gregory garydgreg...@gmail.comwrote:

 On Tue, Jan 15, 2013 at 4:31 PM, Oleg Kalnichevski ol...@apache.orgwrote:

 On Tue, 2013-01-15 at 16:21 -0500, Gary Gregory wrote:
  On Tue, Jan 15, 2013 at 3:58 PM, Oleg Kalnichevski ol...@apache.org
 wrote:
 
   On Tue, 2013-01-15 at 15:46 -0500, Gary Gregory wrote:
On Tue, Jan 15, 2013 at 3:10 PM, Oleg Kalnichevski 
 ol...@apache.org
   wrote:
   
 On Tue, 2013-01-15 at 12:12 -0500, Gary Gregory wrote:
  Hi,
 
  I get:
 
  [ERROR] Failed to execute goal
 
 org.apache.maven.plugins:maven-checkstyle-plugin:2.9.1:checkstyle
  (validate) on project httpcomponents-core: An error has
 occurred in
  Checkstyle report generation. Failed during checkstyle
 configurat
  ion: cannot initialize module Header - unable to load header
 file
  asl2.header: asl2.header (The system cannot find the file
 specified)
   -
  [Help 1]
 
  Did someone forget to commit asl2.header?
 
  Gary
 

 Trunk passes style checks for me (after fixing tabs introduced
 by a
 previous commit). The asl2.header file seems to be at the right
 place.

   
Weird, I wonder what is wrong on my end then. I have in
C:\svn\org\apache\httpcomponents\trunk the following dirs:
   
httpasync
httpasyncclient
httpclient
httpcore
httpcore-benchmark
httpcore-contrib
project
   
To get the error, I do:
   
cd project
mvn clean test
   
Can you try that?
   
Gary
   
  
   I am getting the same error. I could work this problem around by
 coping
   asl2.header to 'project'. Once the style checks are more or less
 stable
   they can be put into a separate binary artifact and re-used by all
   modules without having to duplicate the style check definitions and
   redundant copies of the asl2.header file.
  
 
  Avoiding redundancies would be good.


 Oh, now I do.

 Yes, that is crazy. Duplicate files it is then.

 Gary


  
  Gary
 
 

 Agreed. At the same time it would be enormously painful to have a call
 for a release vote after each little style check tweak.


 I do not understand this last point.

 Gary


 Oleg



 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory




 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org wrote:

 On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote:
  Over in Log4J-land, we've discussed [1] the use of the final keyword for
  locals and parameters.
 
  In brief [1]: The final keyword in trunk: sometimes it is used, sometimes
  not. I propose we use it all over consistently.
 
  [1]
 http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html
 

 I tend to use final modifier for method parameters a lot (an old habit
 that goes back to my Delphi programming days ;)). If it is done for
 local variables (as long as it is done consistently and enforced with
 the style check plugin) I would be in favor it. I would not bother with
 one time exercise, though.


I added final for locals in trunk r 1433815.

Gary



 Oleg


 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[continuum] BUILD FAILURE: Apache HttpComponents - HttpComponents - Non-recursive build

2013-01-15 Thread Continuum@vmbuild
Online report : 
http://vmbuild.apache.org/continuum/buildResult.action?buildId=25799projectId=128

Build statistics:
  State: Failed
  Previous State: Failed
  Started at: Wed 16 Jan 2013 04:08:03 +
  Finished at: Wed 16 Jan 2013 04:08:14 +
  Total time: 10s
  Build Trigger: Schedule
  Build Number: 76
  Exit code: 1
  Building machine hostname: vmbuild
  Operating system : Linux(unknown)
  Java Home version : 
  java version 1.6.0_30
  Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
  Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

  Builder version :
  Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+)
  Java version: 1.6.0_30
  Java home: /usr/lib/jvm/jdk1.6.0_30/jre
  Default locale: en_AU, platform encoding: UTF-8
  OS name: linux version: 2.6.32-41-server arch: amd64 Family: 
unix


SCM Changes:

Changed: ggregory @ Wed 16 Jan 2013 03:12:21 +
Comment: Add missing asl2.header file.
Files changed:
  /httpcomponents/project/trunk/asl2.header ( 1433810 )


Dependencies Changes:

No dependencies changed



Build Definition:

POM filename: pom.xml
Goals: clean install   
Arguments: --batch-mode --non-recursive
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: DEFAULT_SCHEDULE
Profile Name: Maven 2.2.1
Description: Non-recursive build


Test Summary:

Tests: 0
Failures: 0
Errors: 0
Total time: 0.0




-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org



Re: [continuum] BUILD FAILURE: Apache HttpComponents - HttpComponents - Non-recursive build

2013-01-15 Thread Gary Gregory
Can someone please tell Continuum to use Maven = 3.0.3?

Thank you,
Gary


On Tue, Jan 15, 2013 at 11:08 PM, Continuum@vmbuild contin...@apache.orgwrote:

 Online report :
 http://vmbuild.apache.org/continuum/buildResult.action?buildId=25799projectId=128

 Build statistics:
   State: Failed
   Previous State: Failed
   Started at: Wed 16 Jan 2013 04:08:03 +
   Finished at: Wed 16 Jan 2013 04:08:14 +
   Total time: 10s
   Build Trigger: Schedule
   Build Number: 76
   Exit code: 1
   Building machine hostname: vmbuild
   Operating system : Linux(unknown)
   Java Home version :
   java version 1.6.0_30
   Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
   Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

   Builder version :
   Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+)
   Java version: 1.6.0_30
   Java home: /usr/lib/jvm/jdk1.6.0_30/jre
   Default locale: en_AU, platform encoding: UTF-8
   OS name: linux version: 2.6.32-41-server arch: amd64
 Family: unix


 
 SCM Changes:

 
 Changed: ggregory @ Wed 16 Jan 2013 03:12:21 +
 Comment: Add missing asl2.header file.
 Files changed:
   /httpcomponents/project/trunk/asl2.header ( 1433810 )


 
 Dependencies Changes:

 
 No dependencies changed



 
 Build Definition:

 
 POM filename: pom.xml
 Goals: clean install
 Arguments: --batch-mode --non-recursive
 Build Fresh: false
 Always Build: false
 Default Build Definition: true
 Schedule: DEFAULT_SCHEDULE
 Profile Name: Maven 2.2.1
 Description: Non-recursive build


 
 Test Summary:

 
 Tests: 0
 Failures: 0
 Errors: 0
 Total time: 0.0




 -
 To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
 For additional commands, e-mail: dev-h...@hc.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory