[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909989#comment-16909989
]
Kristian Kraljic commented on HTTPCLIENT-1983:
--
Seems this change didn't solve HTTPCLIENT-2011
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822065#comment-16822065
]
Varun Nandi commented on HTTPCLIENT-1983:
-
[~olegk]
The current behavior breaks so many customers upgrading from 4.5.6. I think
disabling normalization is good default behavior as it doesn't break customers
moving from 4.5.6. The customers using 4.5.7 and 4.5.8 (who will be effected by
this change) should be relatively small compared to customers using 4.5.6 or
less. So I think changing normalization default behavior from true to false is
reasonable.
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821781#comment-16821781
]
Oleg Kalnichevski commented on HTTPCLIENT-1983:
---
[~rschmitt] This is indeed the case. One thing one needs to accept about
open-source development is that often there is no way to please everyone.
Sometimes unpleasant decisions cannot be avoided. What we have now is a
reasonable default behavior and an option to override the default behavior if
so is desired.
Oleg
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821432#comment-16821432
]
Ryan Schmitt commented on HTTPCLIENT-1983:
--
[~olegk] You're right, and unfortunately that means there's no easy way to
address this problem. It seems like no matter what we do we'll be breaking
compatibility again with a prior version of the client.
[~reschke] What about the {{RequestConfig}} changes made in HTTPCLIENT-1968? Do
we back them out as well, or reinterpret the {{normalizeUri}} flag to mean
something different than what it currently means?
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820828#comment-16820828
]
Julian Reschke commented on HTTPCLIENT-1983:
FWIW, given the amount of heated discussion *and* breakage, the obvious short
term fix would be to back out the change that was made for HTTPCLIENT-1960 for
now.
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820807#comment-16820807
]
Oleg Kalnichevski commented on HTTPCLIENT-1983:
---
[~rschmitt] HttpClient has been normalizing such request URIs by default since
release 4.1. The change you are proposing breaks compatibility with all
versions of HttpClient since 4.1.
Oleg
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820709#comment-16820709
]
Ryan Schmitt commented on HTTPCLIENT-1983:
--
[~olegk] I don't think I understand the relevance of the question. It's not
that I object to how normalization is being done now, or that I prefer what was
being done prior to 4.5.7; my point is that the change in _default _behavior is
turning out to have more impact than we might have expected.
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820590#comment-16820590
]
Mateusz Mrozewski commented on HTTPCLIENT-1983:
---
This issue causes problems when calling some of the AWS services and results in
exceptions like:
{code:java}
com.amazonaws.services.lambda.model.AWSLambdaException: The request signature
we calculated does not match the signature you provided. Check your AWS Secret
Access Key and signing method. Consult the service documentation for details.
{code}
Switching back to 4.5.6 resolves the problem.
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820497#comment-16820497
]
Oleg Kalnichevski commented on HTTPCLIENT-1983:
---
[~rschmitt] What do you intend to do about request URIs like
[http://host//blah] ?
Oleg
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820410#comment-16820410
]
Ryan Schmitt commented on HTTPCLIENT-1983:
--
PR: [https://github.com/apache/httpcomponents-client/pull/145]
Thoughts?
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-1983) URIBuilder normalization change is significantly breaking
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819256#comment-16819256
]
Varun Nandi commented on HTTPCLIENT-1983:
-
Any updates on this issue? This change is helpful for existing customers to
upgrade to newer versions without breaking their application and without any
code change.
Customers who want to enable normalization can make the code change to
explicitly enable the option. The new behavior (disable normalization by
default) will effect only few Apache customers as compared to current behavior
(enable normalization by default) which effects lot of customers.
> URIBuilder normalization change is significantly breaking
> -
>
> Key: HTTPCLIENT-1983
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1983
> Project: HttpComponents HttpClient
> Issue Type: Bug
>Affects Versions: 4.5.7, 4.5.8
>Reporter: Ryan Schmitt
>Priority: Major
> Fix For: 4.5.9
>
>
> In 4.5.7, the behavior of URIBuilder changed in order to address
> HTTPCLIENT-1960. Since that version was released, I have seen a concerning
> number of users complain that this change has broken their code (see issue
> links). In 4.5.8, as a result of HTTPCLIENT-1968, an option was added to
> allow users to opt in to the old behavior, but the new behavior is what they
> will get by default. This problem is difficult to work around for developers
> who cannot exercise exact control over the runtime version of HttpClient: the
> method they need might not be there, and if it is, it needs to be invoked
> reflectively, or in a way that tolerates a {{NoSuchMethodError}}.
> For the sake of compatibility, I propose that we change the default value of
> {{normalizeUri}} to {{false}}. This will be the default on the 4.5.x line
> only; the 5.0.x line, as well as any future 4.6.x line, will normalize by
> default (if an option is needed at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
