Re: Use of final keyword
On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used, sometimes not. I propose we use it all over consistently. [1] http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html I tend to use final modifier for method parameters a lot (an old habit that goes back to my Delphi programming days ;)). If it is done for local variables (as long as it is done consistently and enforced with the style check plugin) I would be in favor it. I would not bother with one time exercise, though. Oleg - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
Re: Use of final keyword
On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org wrote: On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used, sometimes not. I propose we use it all over consistently. [1] http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html I tend to use final modifier for method parameters a lot (an old habit that goes back to my Delphi programming days ;)). Done in trunk (revision 1433569). Gary If it is done for local variables (as long as it is done consistently and enforced with the style check plugin) I would be in favor it. I would not bother with one time exercise, though. Oleg - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
Re: Use of final keyword
On Tue, Jan 15, 2013 at 3:03 PM, Oleg Kalnichevski ol...@apache.org wrote: On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote: On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org wrote: On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used, sometimes not. I propose we use it all over consistently. [1] http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html I tend to use final modifier for method parameters a lot (an old habit that goes back to my Delphi programming days ;)). Done in trunk (revision 1433569). Gary Gary Could you please configure your IDE to use spaces instead of tabs? I thought I had! Crud. Will do. Gary Oleg - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
Re: Use of final keyword
On Tue, Jan 15, 2013 at 3:35 PM, Gary Gregory garydgreg...@gmail.comwrote: On Tue, Jan 15, 2013 at 3:03 PM, Oleg Kalnichevski ol...@apache.orgwrote: On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote: On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org wrote: On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used, sometimes not. I propose we use it all over consistently. [1] http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html I tend to use final modifier for method parameters a lot (an old habit that goes back to my Delphi programming days ;)). Done in trunk (revision 1433569). Gary Gary Could you please configure your IDE to use spaces instead of tabs? I thought I had! Crud. Will do. How many spaces per 'tab' do you use? Gary Gary Oleg - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
Re: Use of final keyword
On Tue, 2013-01-15 at 15:40 -0500, Gary Gregory wrote: On Tue, Jan 15, 2013 at 3:35 PM, Gary Gregory garydgreg...@gmail.comwrote: On Tue, Jan 15, 2013 at 3:03 PM, Oleg Kalnichevski ol...@apache.orgwrote: On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote: On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org wrote: On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used, sometimes not. I propose we use it all over consistently. [1] http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html I tend to use final modifier for method parameters a lot (an old habit that goes back to my Delphi programming days ;)). Done in trunk (revision 1433569). Gary Gary Could you please configure your IDE to use spaces instead of tabs? I thought I had! Crud. Will do. How many spaces per 'tab' do you use? I use 4 spaces. Oleg - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
Re: Use of final keyword
On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org wrote: On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used, sometimes not. I propose we use it all over consistently. [1] http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html I tend to use final modifier for method parameters a lot (an old habit that goes back to my Delphi programming days ;)). If it is done for local variables (as long as it is done consistently and enforced with the style check plugin) I would be in favor it. I would not bother with one time exercise, though. I added final for locals in trunk r 1433815. Gary Oleg - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
