[GitHub] helix pull request: [HELIX-537] Shutdown executors
GitHub user atcurtis opened a pull request: https://github.com/apache/helix/pull/8 [HELIX-537] Shutdown executors https://issues.apache.org/jira/browse/HELIX-537 You can merge this pull request into a Git repository by running: $ git pull https://github.com/atcurtis/helix HELIX-537 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/helix/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 commit d6fbcf17e01439a290a0cc273933660274841663 Author: Antony T Curtis acur...@linkedin.com Date: 2014-11-11T19:17:43Z [HELIX-537] Shutdown executors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (HELIX-537) org.apache.helix.task.TaskStateModel should have a shutdown method.
[
https://issues.apache.org/jira/browse/HELIX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14206903#comment-14206903
]
ASF GitHub Bot commented on HELIX-537:
--
GitHub user atcurtis opened a pull request:
https://github.com/apache/helix/pull/8
[HELIX-537] Shutdown executors
https://issues.apache.org/jira/browse/HELIX-537
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/atcurtis/helix HELIX-537
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
commit d6fbcf17e01439a290a0cc273933660274841663
Author: Antony T Curtis acur...@linkedin.com
Date: 2014-11-11T19:17:43Z
[HELIX-537] Shutdown executors
org.apache.helix.task.TaskStateModel should have a shutdown method.
---
Key: HELIX-537
URL: https://issues.apache.org/jira/browse/HELIX-537
Project: Apache Helix
Issue Type: Bug
Components: helix-core
Affects Versions: 0.6.3
Reporter: Antony T Curtis
Priority: Blocker
There should be a shutdown method to terminate the Timer and Executor which
the org.apache.helix.task.TaskStateModel class creates.
ie.
{noformat}
public boolean shutdown(long timeout, TimeUnit unit)
throws InterruptedException
{
reset();
_taskExecutor.shutdown();
_timer.cancel();
return _taskExecutor.awaitTermination(timeout, unit);
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HELIX-537) org.apache.helix.task.TaskStateModel should have a shutdown method.
[
https://issues.apache.org/jira/browse/HELIX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207128#comment-14207128
]
Antony T Curtis commented on HELIX-537:
---
There is no RB for this at this time. I was only asked to create a pull request.
org.apache.helix.task.TaskStateModel should have a shutdown method.
---
Key: HELIX-537
URL: https://issues.apache.org/jira/browse/HELIX-537
Project: Apache Helix
Issue Type: Bug
Components: helix-core
Affects Versions: 0.6.3
Reporter: Antony T Curtis
Priority: Blocker
There should be a shutdown method to terminate the Timer and Executor which
the org.apache.helix.task.TaskStateModel class creates.
ie.
{noformat}
public boolean shutdown(long timeout, TimeUnit unit)
throws InterruptedException
{
reset();
_taskExecutor.shutdown();
_timer.cancel();
return _taskExecutor.awaitTermination(timeout, unit);
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HELIX-537) org.apache.helix.task.TaskStateModel should have a shutdown method.
[
https://issues.apache.org/jira/browse/HELIX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207665#comment-14207665
]
Kanak Biscuitwala commented on HELIX-537:
-
RBs are unnecessary. Code reviews can be done directly on PRs.
org.apache.helix.task.TaskStateModel should have a shutdown method.
---
Key: HELIX-537
URL: https://issues.apache.org/jira/browse/HELIX-537
Project: Apache Helix
Issue Type: Bug
Components: helix-core
Affects Versions: 0.6.3
Reporter: Antony T Curtis
Priority: Blocker
There should be a shutdown method to terminate the Timer and Executor which
the org.apache.helix.task.TaskStateModel class creates.
ie.
{noformat}
public boolean shutdown(long timeout, TimeUnit unit)
throws InterruptedException
{
reset();
_taskExecutor.shutdown();
_timer.cancel();
return _taskExecutor.awaitTermination(timeout, unit);
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] helix pull request: [HELIX-537] Shutdown executors
Github user kanakb commented on the pull request: https://github.com/apache/helix/pull/8#issuecomment-62669496 ```[INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /Users/kanak/Developer/incubator-helix/helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java:[70,2] missing return statement [INFO] 1 error [INFO] - [INFO] [INFO] BUILD FAILURE``` `TaskStateModel#shutdown` has return type `boolean`, but returns nothing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (HELIX-537) org.apache.helix.task.TaskStateModel should have a shutdown method.
[
https://issues.apache.org/jira/browse/HELIX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207673#comment-14207673
]
ASF GitHub Bot commented on HELIX-537:
--
Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/8#issuecomment-62669496
```[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/Users/kanak/Developer/incubator-helix/helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java:[70,2]
missing return statement
[INFO] 1 error
[INFO] -
[INFO]
[INFO] BUILD FAILURE```
`TaskStateModel#shutdown` has return type `boolean`, but returns nothing.
org.apache.helix.task.TaskStateModel should have a shutdown method.
---
Key: HELIX-537
URL: https://issues.apache.org/jira/browse/HELIX-537
Project: Apache Helix
Issue Type: Bug
Components: helix-core
Affects Versions: 0.6.3
Reporter: Antony T Curtis
Priority: Blocker
There should be a shutdown method to terminate the Timer and Executor which
the org.apache.helix.task.TaskStateModel class creates.
ie.
{noformat}
public boolean shutdown(long timeout, TimeUnit unit)
throws InterruptedException
{
reset();
_taskExecutor.shutdown();
_timer.cancel();
return _taskExecutor.awaitTermination(timeout, unit);
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] helix pull request: [HELIX-537] Shutdown executors
Github user atcurtis commented on the pull request: https://github.com/apache/helix/pull/8#issuecomment-62669668 Oops, I pushed the wrong commit to github. Iâll force push the correct one to my repo. On Nov 11, 2014, at 8:42 PM, Kanak Biscuitwala notificati...@github.com wrote: [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /Users/kanak/Developer/incubator-helix/helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java:[70,2] missing return statement [INFO] 1 error [INFO] - [INFO] [INFO] BUILD FAILURE TaskStateModel#shutdown has return type boolean, but returns nothing. â Reply to this email directly or view it on GitHub. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (HELIX-537) org.apache.helix.task.TaskStateModel should have a shutdown method.
[
https://issues.apache.org/jira/browse/HELIX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207681#comment-14207681
]
ASF GitHub Bot commented on HELIX-537:
--
Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/8#issuecomment-62670141
LGTM, tests pass, will merge.
org.apache.helix.task.TaskStateModel should have a shutdown method.
---
Key: HELIX-537
URL: https://issues.apache.org/jira/browse/HELIX-537
Project: Apache Helix
Issue Type: Bug
Components: helix-core
Affects Versions: 0.6.3
Reporter: Antony T Curtis
Priority: Blocker
There should be a shutdown method to terminate the Timer and Executor which
the org.apache.helix.task.TaskStateModel class creates.
ie.
{noformat}
public boolean shutdown(long timeout, TimeUnit unit)
throws InterruptedException
{
reset();
_taskExecutor.shutdown();
_timer.cancel();
return _taskExecutor.awaitTermination(timeout, unit);
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] helix pull request: [HELIX-537] Shutdown executors
Github user asfgit closed the pull request at: https://github.com/apache/helix/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (HELIX-537) org.apache.helix.task.TaskStateModel should have a shutdown method.
[
https://issues.apache.org/jira/browse/HELIX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207745#comment-14207745
]
ASF GitHub Bot commented on HELIX-537:
--
Github user asfgit closed the pull request at:
https://github.com/apache/helix/pull/8
org.apache.helix.task.TaskStateModel should have a shutdown method.
---
Key: HELIX-537
URL: https://issues.apache.org/jira/browse/HELIX-537
Project: Apache Helix
Issue Type: Bug
Components: helix-core
Affects Versions: 0.6.3
Reporter: Antony T Curtis
Priority: Blocker
There should be a shutdown method to terminate the Timer and Executor which
the org.apache.helix.task.TaskStateModel class creates.
ie.
{noformat}
public boolean shutdown(long timeout, TimeUnit unit)
throws InterruptedException
{
reset();
_taskExecutor.shutdown();
_timer.cancel();
return _taskExecutor.awaitTermination(timeout, unit);
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Review Request 27808: [HELIX-543] Avoid moving partitions unnecessarily when auto-rebalancing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27808/#review60959 --- Ship it! Looks good, assuming that existing integration tests still pass. Some ones to try include TestAutoRebalance, TestFullAutoNodeTagging, TestAutoRebalancePartitionLimit, and TestIndependentTaskRebalancer. Only minor comments regarding the code. helix-agent/helix-agent-0.7.2-SNAPSHOT.ivy https://reviews.apache.org/r/27808/#comment102379 thanks! helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java https://reviews.apache.org/r/27808/#comment102380 active for each participant* helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java https://reviews.apache.org/r/27808/#comment102381 It may be cleaner to use Guava comparator helpers, but this is fine too. Reference: https://code.google.com/p/guava-libraries/wiki/CommonObjectUtilitiesExplained#compare/compareTo - Kanak Biscuitwala On Nov. 10, 2014, 5:07 a.m., Tom Widmer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27808/ --- (Updated Nov. 10, 2014, 5:07 a.m.) Review request for helix and Kanak Biscuitwala. Bugs: HELIX-543 Repository: helix-git Description --- commit ba45d4bc2019c4069fe810c6e61a0696391f207e Author: Tom Widmer tom.wid...@camcog.com Date: Mon Nov 10 12:40:33 2014 + [HELIX-543] Add missing licence header :100644 100644 f59be07... ef1f57e... M helix-agent/helix-agent-0.7.2-SNAPSHOT.ivy commit 5f63c6d69d594c70e85de31d5ed67f62f348ecb0 Author: Tom Widmer tom.wid...@camcog.com Date: Mon Nov 10 12:26:40 2014 + [HELIX-543] Avoid moving partitions unnecessarily when auto-rebalancing This is done by allocating capacity first to those nodes which already have the most partitions. :100644 100644 09b66c1... 6e0e226... M helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java :100644 100644 1322b40... 25c550d... M helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java Diffs - helix-agent/helix-agent-0.7.2-SNAPSHOT.ivy f59be07 helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java 09b66c1 helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java 1322b40 Diff: https://reviews.apache.org/r/27808/diff/ Testing --- Added new test to check case (failed before, now passes). Ran other re-balancing tests. Thanks, Tom Widmer
